[07:10:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Live Update causes problems with "Navigation popups" gadget - https://phabricator.wikimedia.org/T172957#3514413 (10APerson)... [08:59:25] 10Collaboration-Team-Triage, 10StructuredDiscussions: Flow is vulnerable to mass vandalism lacking mass rollback function - https://phabricator.wikimedia.org/T162228#3630918 (10Trizek-WMF) The case happen over the week end on mediawiki.org. A spammer has created about 20 topics. I was not able to delete them /... [14:48:30] (03CR) 10Jforrester: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 13.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/380152 (owner: 10Libraryupgrader) [15:11:14] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 13.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/380152 (owner: 10Libraryupgrader) [15:32:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Latest revision' filter includes 'User creation log' and other not-related to page actions logged entries - https://phabricator.wikimedia.org/T176531#3632351 (10Etonkovidova) [15:42:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Latest revision' filter includes 'User creation log' and other not-related to page actions logged entries - https://phabricator.wikimedia.org/T176531#3632370 (10Etonkovidova) The description of 'Latest revision' fi... [15:56:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: [wmf.19]Namespace filters do not display some actions on SD board - https://phabricator.wikimedia.org/T176377#3632412 (10Etonkovidova) [16:03:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: [wmf.19]Namespace filters do not display some SD board actions - https://phabricator.wikimedia.org/T176377#3632432 (10Etonkovidova) [16:34:49] 10Collaboration-Team-Triage, 10Notifications, 10Regression: Echo incorrectly sends notification about incoming link to page I created - https://phabricator.wikimedia.org/T176343#3622135 (10Quiddity) From a quick glance at a few examples, I believe these notifications are all related to this edit: https://sv.... [17:16:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Operations, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3632705 (10jmatazzoni) a:03Catrope [17:18:43] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Performance-Team: Performance review of RCFilters feature - https://phabricator.wikimedia.org/T176652#3632721 (10Krinkle) [17:19:39] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Performance-Team: Performance review of RCFilters feature - https://phabricator.wikimedia.org/T176652#3632721 (10Krinkle) Moving to External for now as I believe @Catrope is already doing some work in this area. Once completed, or... [17:26:23] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10GlobalUsage, and 4 others: Show edits made on WikimediaCommons on the Watchlist - https://phabricator.wikimedia.org/T91192#3632773 (10D3r1ck01) [17:28:26] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Performance-Team (Radar): Performance review of RCFilters feature - https://phabricator.wikimedia.org/T176652#3632777 (10Krinkle) [17:34:22] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Performance-Team (Radar): Performance review of RCFilters feature - https://phabricator.wikimedia.org/T176652#3632797 (10Catrope) See also {T176445} [17:38:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review: 'Latest revision' + 'Logged actions' filters don't display Deleted ... - https://phabricator.wikimedia.org/T176328#3632805 [17:39:42] 10Collaboration-Team-Triage, 10Notifications, 10Regression: Echo incorrectly sends notification about incoming link to page I created - https://phabricator.wikimedia.org/T176343#3632811 (10Nirmos) Ah, ok! That makes perfect sense. Then the issue is solved on my part. [18:46:35] (03PS5) 10Kaldari: Don't delete stuff from the pagetriage_log unless it's a year old [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/379604 (https://phabricator.wikimedia.org/T168335) [18:49:35] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: 'Latest revision' hides all Flow actions - https://phabricator.wikimedia.org/T176329#3633007 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [18:51:13] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Operations, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3633009 (10jmatazzoni) a:05Catrope>03Mattflaschen-WMF [19:29:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation: Add a help link to the Tagged Edits menu - https://phabricator.wikimedia.org/T176661#3633069 (10jmatazzoni) [19:29:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation: Add a help link to the Tagged Edits menu - https://phabricator.wikimedia.org/T176661#3633069 (10jmatazzoni) [19:47:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation: Write help documentation for Tagged Edits filtering of Recent Changes. - https://phabricator.wikimedia.org/T167740#3633190 (10jmatazzoni) @Pginer-WMF, I put this task in because [[ htt... [20:05:35] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), and 2 others: Defer building new filters ... - https://phabricator.wikimedia.org/T176250#3633280 [20:20:37] 10Collaboration-Team-Triage: Contribution page: 'Hide probably good edits' displays entries that do not get ORES highlighted - https://phabricator.wikimedia.org/T176667#3633304 (10Etonkovidova) [20:21:54] 10Collaboration-Team-Triage: Contribution page: 'Hide probably good edits' displays entries that do not get ORES highlighted - https://phabricator.wikimedia.org/T176667#3633320 (10Etonkovidova) [20:23:37] RoanKattouw: ping [20:33:16] matanya: Pong [20:34:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/380608 (owner: 10L10n-bot) [20:41:50] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [wmf.19] The invite opt-in popup does not accommodate some languages - https://phabricator.wikimedia.org/T168413#3633380 (10Etonkovidova) [20:46:28] RoanKattouw: I moved the watchlist messages on en.wp [20:47:04] Thanks [20:47:09] RoanKattouw: as i'll soon be asleep... can you keep a casual eye on it for the next hours ? [20:47:34] Looking at what exactly you did [20:48:25] OK so you did both things [20:48:30] yup [20:48:37] Moved them to their own MW page, and moved its transclusion to the right message [20:49:04] yes. [20:49:58] Cool [20:50:07] Looks good to me, I'll keep an eye on it [20:55:39] <3 at ya both. [21:06:06] matt_flaschen: I wrote a patch for the tag message caching thing https://gerrit.wikimedia.org/r/380578 [21:06:18] Complete with the Krinkle Seal of Approval :) [21:07:20] RoanKattouw: I wanted to praise the new RC [21:07:52] and give some feedback if you are free to hear [21:09:49] Sure! [21:15:09] (03CR) 10Jforrester: [C: 032] Improve some parameter docs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/380329 (owner: 10Umherirrender) [21:15:26] So i am a huge fan of rtrc [21:15:47] and this new RC is getting closer to RTRC in many ways [21:16:19] what makes me stick to rtrc for now i the ability to see diffs in the RC windows with a toggle [21:16:50] is there a ticket requesting this in phab ? [21:17:19] What do you mean exactly by "see diffs in the RC window"? [21:17:28] Like, do individual changes expand on click to show a diff [21:17:38] https://commons.wikimedia.org/wiki/File:RTRC_v0.9.9_edit_view.png [21:17:40] yes [21:17:41] like that :) [21:17:52] exactly [21:17:57] @^@^# i should go to bed... [21:18:02] Ooh very fancy [21:18:02] * thedj signs off [21:18:09] No phab task for that yet, no [21:18:14] nice thedj [21:18:19] *night [21:18:39] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] RC page - oo-ui-popupWidget for number of changes/day selection does not adjust its width to accommodate two (three)-digit numbers - https://phabricator.wikimedia.org/T171777#3633489 (10Etonkovidova) Re-checked in wmf.19 - with autoclose... [21:18:44] RoanKattouw: would you consider doing that ? [21:18:50] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] RC page - oo-ui-popupWidget for number of changes/day selection does not adjust its width to accommodate two (three)-digit numbers - https://phabricator.wikimedia.org/T171777#3633492 (10Etonkovidova) 05Open>03Resolved [21:25:59] matanya, RoanKattouw, I use this script https://en.wikipedia.org/wiki/User:Writ_Keeper/Scripts/inlineDiffDocs (with the first example's tweaks to make the diff-links into just a "+") [21:26:02] Screenshot: h_1506374617_9327027_e48cfee4c8 [21:26:14] quiddity: Broken link to screenshot [21:26:17] Screenshot: http://storage6.static.itmages.com/i/17/0925/h_1506374617_9327027_e48cfee4c8.jpeg [21:26:17] Thanks [21:27:16] (03Merged) 10jenkins-bot: Improve some parameter docs [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/380329 (owner: 10Umherirrender) [21:27:29] That looks cool [21:27:34] I try to avoid user scripts as much as possible, due to frequent breakage and general hate for security reviews of code of other people [21:27:37] Has gadget-ifying that script been discussed? [21:28:01] not that i know of [21:28:56] Huh, someone (me!) suggested it in 2013: https://en.wikipedia.org/wiki/User_talk:Writ_Keeper/Scripts/inlineDiffDocs#Suggest_putting_this_forward_as_a_Gadget [21:28:59] and if you wondered, krinkle doesn't not fall under the category of the above statement [21:30:36] I'm open to building a feature like this into the new filters UI, but it's jmatazzoni_'s call, and I think the harder part is the design considerations of where it makes sense to put the diff (RTRC and Writ Keeper's script have different approaches), what happens if the diff is really large, etc [21:30:45] Coding it is probably pretty easy [21:31:11] I'll file it [21:31:16] Thanks! [21:31:42] another thing [21:35:01] matanya: RoanKattouw: https://phabricator.wikimedia.org/T53958 [21:35:15] We had edits from wikidata and that is gone now [21:35:22] quiddity: ^^^ [21:35:29] (in the he.wiki rc [21:35:56] MatmaRex: well, its 2017 ... ;) [21:36:37] yup, and that was what I linked to when I suggested that WritKeeper gadgetify his script. But core would be so much better! /me goes for a walk, bbiab. [21:36:58] 10MediaWiki-Watchlist: Watchlist and recent changes should be able to show diffs inline - https://phabricator.wikimedia.org/T53958#585069 (10Matanya) And here one from RTRC : https://commons.wikimedia.org/wiki/File:RTRC_v0.9.9_edit_view.png [21:37:14] matanya: Wikidata edits should still be accessible if you enable them as a filter, no? [21:37:47] yes, i am stupid [21:42:43] RoanKattouw: in he.wiki most people use https://he.wikipedia.org/wiki/%D7%9E%D7%93%D7%99%D7%94_%D7%95%D7%99%D7%A7%D7%99:Gadget-QuickRCDiff.js [21:42:59] which is not great [21:52:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Performance: Stop community links from opening then closing on Recent changes - https://phabricator.wikimedia.org/T176380#3633608 (10... [23:48:40] 10Collaboration-Team-Triage: Unwatch/watch links are not displayed for Move log entires in Grouped by change mode - https://phabricator.wikimedia.org/T176684#3633799 (10Etonkovidova)