[00:44:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3626121 (10jmatazzoni) Roan pointed out that turning Live Update off and on should not affect the d... [01:12:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), and 2 others: Fix page reflow on Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176300#3620451 (... [01:12:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), and 2 others: Fix page reflow on Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176300#3626147 (... [01:15:17] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3626148 (10jmatazzoni) [02:22:20] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on - https://phabricator.wikimedia.org/T176456#3626199 (10jmatazzoni) [02:24:20] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on - https://phabricator.wikimedia.org/T176456#3626212 (10jmatazzoni) [02:25:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on - https://phabricator.wikimedia.org/T176456#3626199 (10jmatazzoni) [02:26:04] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on - https://phabricator.wikimedia.org/T176456#3626199 (10jmatazzoni) [04:15:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Create new RC Filters group for 'Flagged Revisions', based on the old 'Hide reviewed edits' function - https://phabricator.wikimedia.org/T159791#3626223 (10Zache) Fix for the emp... [07:23:19] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Epic, 10Tracking: [Epic] Wikidata watchlist improvements (client) - https://phabricator.wikimedia.org/T90435#3626253 (10matej_suchanek) [07:23:25] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikidata, and 6 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3626255 (10matej_suchanek) [08:46:35] 10Collaboration-Team-Triage, 10MediaWiki-General-or-Unknown, 10StructuredDiscussions, 10Wikimedia-log-errors: unable to undelete a page in the MediaWiki namespace in din.wikipedia.org (due to system user ID being 0 or negative?) - https://phabricator.wikimedia.org/T171842#3626322 (10Aklapper) p:05High>0... [08:56:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MediaWiki-extensions-Newsletter, 10StructuredDiscussions, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable Newsletter extension in office.wikimedia.org (and Structured Discussions in its re... - https://phabricator.wikimedia.org/T176199#3626339 [09:41:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Operations, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3626375 (10mark) [09:53:22] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikidata, and 6 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3626425 (10jcrespo) @Catrope Unfortunately it will t... [09:56:28] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10DBA, and 7 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3626435 (10mark) [09:59:41] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10GlobalUsage, and 4 others: Show edits made on WikimediaCommons on the Watchlist - https://phabricator.wikimedia.org/T91192#3626442 (10Noella94) Thank you @D3r1ck01 for the response and for the detailed description of the task. [10:33:38] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Community-Liaisons (Oct-Dec 2017), 10Goal: Support Structured discussions features developments for FY 2017-2018 - https://phabricator.wikimedia.org/T175678#3626596 (10Qgil) a:03Trizek-WMF (As discussed.) [10:34:38] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Community-Liaisons (Oct-Dec 2017), 10Goal: Support Structured discussions features developments for FY 2017-2018 - https://phabricator.wikimedia.org/T175678#3626600 (10Qgil) p:05Triage>03Normal [10:38:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), and 2 others: New Watchlist UI with edit filters breaks unwatch... - https://phabricator.wikimedia.org/T176264#3626609 [10:42:13] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: 'Latest revision' hides all Flow actions - https://phabricator.wikimedia.org/T176329#3626618 (10SBisson) Should be fixed by https://gerrit.wikimedia.org/r/#/c/379614/ [11:56:35] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Design: 'Live update' button animation draws attention to wrong place - https://phabricator.wikimedia.org/T176474#3626772 (10Esanders) [11:57:30] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Design: 'Live update' button animation draws attention to wrong place - https://phabricator.wikimedia.org/T176474#3626786 (10Esanders) The speed of the animation may also be a factor. Looking at that page with the fast pulsing makes me feel a... [13:13:12] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Live Update causes problems with "Navigation popups" gadget - https://phabricator.wikimedia.org/T172957#3514413 (10Petar.pet... [13:35:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Live Update causes problems with "Navigation popups" gadget - https://phabricator.wikimedia.org/T172957#3627034 (10Petar.pet... [13:36:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review, 10User-Petar.petkovic: `eri-rcfilters-beta-description-ores` message should contain a link to a Special:MyLanguage page - https://phabricator.wikimedia.org/T174377#3559832 (10Petar.petkovic) a... [13:59:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10MediaWiki-Watchlist: Asymmetrical MediaWiki:Watchlist-summary - https://phabricator.wikimedia.org/T176251#3627121 (10Bencemac) Thanks for everybody! [15:02:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3627417 [15:03:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3627419 [15:35:37] 10Collaboration-Team-Triage, 10StructuredDiscussions, 10Community-Liaisons (Oct-Dec 2017), 10Goal: Support Structured discussions features developments for FY 2017-2018 - https://phabricator.wikimedia.org/T175678#3599935 (10Qgil) [16:00:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3627563 [16:04:55] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Design: 'Live update' button animation draws attention to wrong place - https://phabricator.wikimedia.org/T176474#3626772 (10jmatazzoni) I'm adding @Pginer-WMF to the ticket. I can see how some might feel the animation is too active, and I i... [16:12:33] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filters for Recent changes by default deployme... - https://phabricator.wikimedia.org/T164489#3627583 [16:13:07] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filters for Recent changes by default deployme... - https://phabricator.wikimedia.org/T164489#3235320 [16:22:28] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Israel-Hackers: Improve usage tracking granularity to avoid irrelevant changes showing in the watchlist. - https://phabricator.wikimedia.org/T90436#3627599 (10Mattflaschen-WMF) [16:57:11] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Patch-For-Review: Graduate New Filters UX out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3627771 (10jmatazzoni) [17:00:37] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Patch-For-Review: Graduate New Filters UX out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3627775 (10jmatazzoni) [17:03:09] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Patch-For-Review: Graduate New Filters UX out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3627780 (10jmatazzoni) [17:03:40] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Patch-For-Review: Graduate New Filters UX out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3476383 (10jmatazzoni) [18:41:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Operations, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3628015 (10jmatazzoni) [18:51:09] 10Collaboration-Team-Triage, 10StructuredDiscussions: When deleting Flow topic or post, contributions should appear in DeletedContributions - https://phabricator.wikimedia.org/T118024#3628037 (10Quiddity) [18:51:12] 10Collaboration-Team-Triage, 10StructuredDiscussions: Deleted Flow contributions don't show up on Special:DeletedContributions - https://phabricator.wikimedia.org/T176313#3628039 (10Quiddity) [18:59:38] 10Collaboration-Team-Triage, 10StructuredDiscussions: When deleting Flow topic or post, contributions should appear in DeletedContributions - https://phabricator.wikimedia.org/T118024#3628050 (10Wargo) And are visible in deleted contributions of deletor. Is this intentional? [19:00:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Performance: Stop community links from opening then closing on Recent changes - https://phabricator.wikimedia.org/T176380#3623361 (10... [19:03:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), and 2 others: Slowdown due to new filters - https://phabricator.wikimedia.org/T176250#3628057... [19:03:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Performance: Stop community links from opening then closing on Recent changes - https://phabricator.wikimedia.org/T176380#3628056 (10... [19:06:04] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Patch-For-Review: Graduate New Filters UX out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3628062 (10jmatazzoni) [19:36:49] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Monitoring Wikidata changes from client using new filters - https://phabricator.wikimedia.org/T176515#3628149 (10eranroz) [19:38:21] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Epic, 10Tracking: [Epic] Wikidata watchlist improvements (client) - https://phabricator.wikimedia.org/T90435#3628169 (10eranroz) [19:38:24] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Monitoring Wikidata changes from client using new filters - https://phabricator.wikimedia.org/T176515#3628168 (10eranroz) [19:56:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Scoring-platform-team, 10Wikimedia-log-errors: Attempted to serialize unserializable builtin class Closure$ORES\Hooks::makeApplicableCallback;343 in /srv/mediawiki/php-1.30.0-wmf.... - https://phabricator.wikimedia.org/T176236#3628220 [19:58:17] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Scoring-platform-team, 10Wikimedia-log-errors: Attempted to serialize unserializable builtin class Closure$ORES\Hooks::makeApplicableCallback;343 in /srv/mediawiki/php-1.30.0-wmf.... - https://phabricator.wikimedia.org/T176236#3628223 [19:58:38] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Scoring-platform-team, 10Wikimedia-log-errors: PHP Warning: Attempted to serialize unserializable builtin class Closure$ChangesListSpecialPage::__construct#28;1852 - https://phabricator.wikimedia.org/T176236#3628227 (10Legoktm) [19:58:47] RoanKattouw: https://phabricator.wikimedia.org/T176236 [19:59:25] Hah weird [20:01:32] RoanKattouw: somehow the entire structured filters stuff is making it into ParserOutput, but I couldn't figure out how [20:02:12] Yeah I'm confused too [20:02:24] I tried to var_dump() a ParserOutput in eval.php last night and it was way too many lines [20:03:36] in Parser::braceSubstitution() the only thing that's fishy is $this->mOutput->addOutputPageMetadata( $context->getOutput() ); [20:03:45] Do you know enough about this Closure$ChangesListSpecialPage::__construct#28;1852 syntax to identify which closure it's trying to serialize? Or is your theory that it's just the entire data structure? [20:04:19] the entire data structure [20:04:35] because some tracebacks have an ORES closure in them [20:04:40] Aha Ok [20:04:45] so maybe it's just fataling on the first one in the array? [20:04:50] (thats just my theory) [20:04:52] Well yeah I was going to say [20:05:02] If it's the entire structure, shouldn't you /never/ see an ORES closure? [20:05:13] Shouldn't it fatal on the first one in the array, which will probably always be a core one? [20:05:40] When I was reading through the code there were some usort calls based on priority? I didn't look further to see how it worked [20:05:55] Oh yes! [20:05:59] And ORES ends up on top [20:24:43] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikimedia-Israel-Hackers: Improve usage tracking granularity to avoid irrelevant changes showing in the watchlist. - https://phabricator.wikimedia.org/T90436#3628274 (10jmatazzoni) Is T176515 a related task? [20:28:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Operations, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3628281 (10jmatazzoni) [20:32:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Operations, 10Performance: Systematically test load speeds of Watchlist and Recent Changes - https://phabricator.wikimedia.org/T176445#3628285 (10jmatazzoni) [20:36:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Performance: ORES on Watchlist causes big slowdown—especially with 'Last revision' filter turned on - https://phabricator.wikimedia.org/T176456#3628311 (10jmatazzoni) [20:47:55] RoanKattouw, I realized the rc_type for Wikidata is RC_EXTERNAL, which is from core and thus I don't think we can say it's Wikidata-specific (core also doesn't document it at all). [20:48:11] Hmm right [20:48:21] RoanKattouw, but we should still get a benefit if we filter on both rc_type and rc_source, right (since rc_namespace, rc_type is an index)? [20:51:23] Ah yes we can do that, good idea [20:51:38] Because (we suspect) rc_type=RC_EXTERNAL is broader than rc_source='wb' [20:51:51] Although that only works when including WB changes, not when excluding them [20:52:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10ORES, 10Scoring-platform-team, 10editquality-modeling, and 2 others: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3628377 (10Halfak) This deployment has been delayed substantially. We were originally targeting 9/20,... [20:52:12] Hold on, lemme look if we have rows with rc_type=RC_EXTERNAL but rc_source != 'wb' in practice [20:54:45] No we don't [20:55:03] RoanKattouw, yeah, but in theory there is nothing stopping someone. [20:55:05] It still feels dirty though [20:55:08] Yeah exactly [20:55:19] Also, rc_type != 5 probably wouldn't actually use the indx [20:55:30] Oh, really? [20:55:36] I was hoping that would work nicely. [20:55:41] I'll test, but you might have to use rc_type IN (everything, that, is, not, five) to convince MySQL to use the index [20:55:53] (Then we could still do (rc_type != RC_EXTERNAL OR rc_source != 'wb' )) [20:56:09] That might mildly slow it down when you *did* want Wikidata though. [20:56:37] Also the only index that contains rc_type contains rc_namespace before it, so this only helps if there's a namespace conditon [20:58:07] Oh but also! [20:58:15] It's all moot anyway because you need to sort by timestamp [20:58:32] And you can't do that if you have a point of divergence that precedes the timestamp in the index [20:58:36] KEY `rc_name_type_patrolled_timestamp` (`rc_namespace`,`rc_type`,`rc_patrolled`,`rc_timestamp`) [20:58:43] I did know about the namespace thing. [20:59:16] RoanKattouw, it can't use the dedicated index for rc_timestamp, then the other one for the rest? [20:59:34] means you have to either have a single fixed value for each of namespace, type and patrolled, then order by timestamp; or have a single fixed value for namespace and type and order by patrolled then timestamp, or a fixed namespace and order by type then patrolled then timestamp [20:59:38] Sorry, trying to learn this stuff. Basically all I know is that you can use a prefix of an index (e.g. rc_namespace, rc_type in this case). [21:00:07] Yeah I don't fully understand everything either but I know what tends to work and what doesn't [21:00:21] The idea is that an index is basically a presorted list of rows (row pointers) [21:00:40] Right [21:00:45] So the DB stores and maintains a sorted list of row pointers/IDs ordered by (ns, type, patrolled, timestamp) [21:01:07] So then for WHERE conditions, you can efficiently resolve them using binary search [21:01:16] And for ORDER BY, you can take advantage of the fact that stuff is already ordered [21:02:10] So using the (rc_user_text, rc_timestamp) index it's easy to do WHERE rc_user_text='Superm401' WHERE rc_timestamp >= '20170901000000' ORDER BY rc_timestamp because all the resulting rows are adjacent to each other in the index, and you can use binary search to find the starting point [21:02:25] (sorry I meant AND not WHERE for the second one obviously) [21:03:14] RoanKattouw, but can't it use https://dev.mysql.com/doc/refman/5.7/en/index-merge-optimization.html in some cases? [21:03:16] For things where it's not that clear cut, sometimes MySQL has an implementation that's still able to use the index and sometimes it doesn't, and you kind of learn by experience from looking at EXPLAINs which is which [21:03:21] I don't know how index merge works that well [21:03:25] brb phone call [21:06:29] mooeypoo: sorry to bother you again on that agian :( I see "eri-rcfilters-beta-description-ores": "Review edits on Recent Changes and Watchlist using an easier and more powerful interface and many new tools, including predictive filters powered by [[mw:Special:MyLanguage/ORES|ORES]].... [21:07:11] mooeypoo: and I see it perfectly in enwiki betlabs, but in hewiki betalabs it's still mw:Ores [21:07:47] etonkovidova, the translators have to update it. [21:09:38] matt_flaschen: ah - sure, just double checking. Did not know that it needs to be specifically translated, hmm... ok [21:11:37] etonkovidova, yeah, the message is one unit, so every aspect needs to be updated in translations, even parts that are technical not language. [21:12:22] Yeah it's the translation [21:12:53] thank you! [21:14:01] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10User-Petar.petkovic: `eri-rcfilters-beta-description-ores` message should ... - https://phabricator.wikimedia.org/T174377#3559832 [21:14:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10User-Petar.petkovic: `eri-rcfilters-beta-description-ores` message should ... - https://phabricator.wikimedia.org/T174377#3628459 [21:29:26] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filters for Recent changes by default deployme... - https://phabricator.wikimedia.org/T164489#3628555 [21:29:29] RoanKattouw, now I'm not sure having (rc_type in (everything_but_external) OR rc_source != 'wb' ) would help (even aside from the rc_timestamp issue). It could easily tell "those 5% of rows without RC_EXTERNAL are definitely in", but it would still need to check every single row with rc_source (which has no index at all) to see if they are some non-Wikidata row that's allowed. So it's doing 95% of the work. [21:31:44] Hmm it's not clear to me from the docs how index_merge interacts with ORDER BY [21:31:56] Right [21:32:20] If we had an index on rc_source that would have been better [21:32:33] Or if we could assume that rc_type=external is the same as rc_source=wb [21:32:54] "every single row with RC_EXTERNAL" [21:33:41] RoanKattouw, I think "Or if we could assume that rc_type=external is the same as rc_source=wb" is bad. At that point, we should just remove RC_EXTERNAL from core and move it to Wikibase and rename RC_WIKIBASE_TYPE (which wouldn't be the end of the world) [21:33:47] But I wouldn't want to leave it in core and do that. [21:33:54] Right [21:34:52] RoanKattouw, I agree with you about having an index on rc_source. Then, we also have to have a hook to register all the rc_sources, so we can convert "not Wikibase, not new pages" to (rc_source IN a, b, c, d) [21:35:08] Assuming we can still benefit from the index with a IN with 5 or so values. [21:36:06] I am doubtful that the index would help much [21:36:17] Because rc_type is only in one index and the rest of that index isn't terribly useful [21:36:45] Well, we'd have to make a new index anyway for rc_source, so at that point we can make whatever we need. [21:36:51] Or really, the problem is that rc_namespace is in there [21:37:07] Oh, sorr, yes [21:37:10] E.g. (rc_timestamp, rc_source); [21:37:11] rc_SOURCE not rc_TYPE [21:37:17] Apologies, I got them mixed up [21:39:00] Yeah, it's confusing. I'm going to get something to eat, then I'll add a note on the task (but feel free to do so). [22:23:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/379873 (owner: 10L10n-bot) [22:50:24] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review: 'Latest revision' + 'Logged actions' filters don't display Deleted ... - https://phabricator.wikimedia.org/T176328#3621711 [23:39:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Latest revision' filter includes 'User creation log' and other not-related to page actions logged entries - https://phabricator.wikimedia.org/T176531#3628821 (10Etonkovidova)