[03:49:51] 10Collaboration-Team-Triage, 10Flow, 10AbuseFilter, 10Analytics, and 30 others: Possible WMF deployed extension PHP 7 issues - https://phabricator.wikimedia.org/T173850#3595275 (10Nuria) [04:06:33] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikimedia-General-or-Unknown, and 5 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3595277 (10Bawolff) >>! In T1710... [05:13:25] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikimedia-General-or-Unknown, and 5 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3595298 (10Jmabel) > virtually a... [06:56:02] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikimedia-General-or-Unknown, and 5 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3595334 (10Bawolff) Ok, so my pr... [07:15:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review: Update gadgets for seen/unseen styling - https://phabricator.wikimedia.org/T175062#3595345 (10Mattflaschen-WMF) >>! In T175062#3582119, @jmatazzoni wrote: > E... [07:29:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10ORES, 10Scoring-platform-team, 10editquality-modeling, and 2 others: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3595357 (10Alicia_Fagerving_WMSE) [11:06:18] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 (owner: 10Hashar) [12:19:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 10MW-1.29-release-notes, 10Patch-For-Review: Unstructured filters replaced by Structured filters may ... - https://phabricator.wikimedia.org/T162158#3596272 [12:38:55] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-Newsletter: Please enable Flow in MediaWiki.org's Newsletter talk namespace - https://phabricator.wikimedia.org/T175502#3596321 (10Trizek-WMF) There is a config change to do to have Flow automatically on this namespace. In the meantime, I can enable... [12:48:37] 10Collaboration-Team-Triage, 10Flow: Special:EnableFlow missing description - https://phabricator.wikimedia.org/T175552#3596345 (10MarcoAurelio) [12:50:12] 10Collaboration-Team-Triage, 10Flow: Special:EnableFlow missing description - https://phabricator.wikimedia.org/T175552#3596368 (10MarcoAurelio) [12:52:25] 10Collaboration-Team-Triage, 10Flow: Special:EnableFlow missing description - https://phabricator.wikimedia.org/T175552#3596370 (10MarcoAurelio) `You can use this page to enable Flow on a single page. Please note that existing content will not be converted and instead will get archived in a subpage.` Does it... [13:29:41] 10Collaboration-Team-Triage, 10Flow: Support rollback on Flow - https://phabricator.wikimedia.org/T175558#3596472 (10MarcoAurelio) [13:29:47] 10Collaboration-Team-Triage, 10Flow: Support rollback on Flow - https://phabricator.wikimedia.org/T175559#3596486 (10MarcoAurelio) [13:43:05] 10Collaboration-Team-Triage, 10Flow: Support rollback on Flow - https://phabricator.wikimedia.org/T175559#3596678 (10MarcoAurelio) Good job Phabricator... Duplicate of {T175558}. [13:43:22] 10Collaboration-Team-Triage, 10Flow: Support rollback on Flow - https://phabricator.wikimedia.org/T175559#3596681 (10MarcoAurelio) [13:43:26] 10Collaboration-Team-Triage, 10Flow: Support rollback on Flow - https://phabricator.wikimedia.org/T175558#3596472 (10MarcoAurelio) [14:02:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Create new RC Filters group for 'Flagged Revisions', based on the old 'Hide reviewed edits' function - https://phabricator.wikimedia.org/T159791#3596799 (10Trizek-WMF) We have tw... [14:39:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-Petar.petkovic: `eri-rcfilters-beta-description-ores` message should contain a link to a Special:MyLanguage page - https://phabricator.wikimedia.org/T174377#3596922 (10SBisson) [14:39:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-Petar.petkovic: 'Legend' retains some space if 'Group results by change' with highlight options is enabled - https://phabricator.wikimedia.org/T174728#3596924 (10SBisson) [14:39:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10User-Petar.petkovic: [wmf.15] 'Save current filter settings' cancel button (X) is misaligned - https://phabricator.wikimedia.org/T174454#3596926 (10SBisson) [14:40:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10User-Petar.petkovic: Namespace filter does not display highlight option if 'Group results by page' is enabled - https://phabricator.wikimedia.org/T174734#3596934 (10SBisson) [14:40:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-Petar.petkovic: Logged actions selected by namespace filters cannot be highlighted - https://phabricator.wikimedia.org/T174732#3596937 (10SBisson) [14:40:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-Petar.petkovic: [wmf.16-regression] Saved query names displayed shifted up - https://phabricator.wikimedia.org/T174111#3596938 (10SBisson) [14:41:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10User-Petar.petkovic, 10User-notice-collaboration: Recent changes min-height pushes content down unnecesarily - https://phabricator.wikimedia.org/T172140#3596939 (10SBisson) [14:41:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10User-Petar.petkovic: Implement sticky control panel - https://phabricator.wikimedia.org/T167932#3596943 (10SBisson) [14:41:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-Petar.petkovic: [monobook] 'Advanced filters' label (color #ccc) has low contrast - https://phabricator.wikimedia.org/T172733#3596946 (10SBisson) [14:42:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Live Update causes problems with "Navigation popups" gadget - https://phabricator.wikimedia.org/T172957#3596948 (10SBisson) [14:51:47] 10Collaboration-Team-Triage, 10Flow: Special:EnableFlow missing description - https://phabricator.wikimedia.org/T175552#3596345 (10Trizek-WMF) Good idea to document this! The sentence sounds good. Maybe remove the "please note that"? Can you add a link to the Help page about Activation? https://www.mediawik... [14:56:33] 10Collaboration-Team-Triage, 10Flow: Special:EnableFlow missing description - https://phabricator.wikimedia.org/T175552#3597037 (10MarcoAurelio) On Arabic, "you" seems to be different when referring to different genders iirc. Not sure about removing the "please note that...", but I'm no linguist. If the majori... [15:01:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Watchlist 'Hide: probably good edits' box ignores selected Preferences-Watchlist option 'Show only likely problem edits...' after New filters beta feature is enabled - https://phabricator.wikimedia.org/T164797#3245735... [15:01:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10User-Petar.petkovic: [regression] Broken link in a user rights change notification email from Echo - https://phabricator.wikimedia.org/T172636#3597075 (10SBisson) [15:03:05] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10User-Petar.petkovic: Make icons size more consistent for Recent Changes filters - https://phabricator.wikimedia.org/T168835#3597079 (10SBisson) [15:12:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [betalabs-regression] Watchlist setting ' Show only likely problem edits (and hide probably good edits)' does not propagate to Watchlist - https://phabricator.wikimedia.org/T170848#3444635 (10SBisson) @Etonkovidova Do you still see this issue? I don't. [15:15:20] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3534668 (10matmarex) I only see a HTTP 503 in the case... [15:18:27] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [betalabs-regression] Watchlist setting ' Show only likely problem edits (and hide probably good edits)' does not propagate to Watchlist - https://phabricator.wikimedia.org/T170848#3597170 (10Etonkovidova) Re-checked in betalabs - the issue does not exi... [15:18:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [betalabs-regression] Watchlist setting ' Show only likely problem edits (and hide probably good edits)' does not propagate to Watchlist - https://phabricator.wikimedia.org/T170848#3597171 (10Etonkovidova) 05Open>03Invalid [15:21:14] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: Turn off 'classic' ORES highlighting on t... - https://phabricator.wikimedia.org/T174725#3597187 [15:22:14] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: Turn off 'classic' ORES highlighting on t... - https://phabricator.wikimedia.org/T174725#3597193 [15:50:25] 10Collaboration-Team-Triage, 10Flow, 10Dumps-Generation, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), and 2 others: Make flow dumps run faster - https://phabricator.wikimedia.org/T164262#3597320 (10ArielGlenn) [16:46:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Watchlist 'Hide: probably good edits' box ignores selected Preferences-Watchlist option 'Show only likely problem edits...' after New filters beta feature is enabled - https://phabricator.wikimedia.org/T164797#3597627... [16:47:06] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Watchlist 'Hide: probably good edits' box ignores selected Preferences-Watchlist option 'Show only likely problem edits...' after New filters beta feature is enabled - https://phabricator.wikimedia.org/T164797#3597628... [17:07:42] 10MediaWiki-Watchlist, 10MediaWiki-Email, 10Wikidata: [Bug] Email notification of a Wikidata page change should contain relevant links - https://phabricator.wikimedia.org/T129255#3597700 (10Quiddity) [17:10:01] 10MediaWiki-Watchlist, 10MediaWiki-Email, 10Wikidata: [Bug] Email notification of a Wikidata page change should contain relevant links - https://phabricator.wikimedia.org/T129255#3597704 (10Quiddity) I've added a large section to the top of the description. Possibly the problem needs to be split into 2 or mo... [17:40:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Preferences - Watchlist still has "Revision scoring" displayed after beta feature "New filters for edit review" is enabled - https://phabricator.wikimedia.org/T175611#3597808 (10Etonkovidova) [17:41:29] 10Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 10Documentation: Improve the presentation of structured discussion features improvements on-wiki - https://phabricator.wikimedia.org/T175142#3597821 (10Jdforrester-WMF) p:05Triage>03Normal a:03Trizek-WMF [17:46:41] 10Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10Documentation: Improve the presentation of structured discussion features improvements on-wiki - https://phabricator.wikimedia.org/T175142#3597837 (10Trizek-WMF) [18:34:07] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikimedia-General-or-Unknown, and 5 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3598182 (10Bawolff) A further op... [18:55:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10ORES, 10Scoring-platform-team, 10editquality-modeling, and 2 others: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3598253 (10Halfak) @Lokal_Profil, it looks like we have some delays. We'll need to finish T175053 fir... [19:16:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3582364 (10Etonkovidova) Checked /srv/m... [19:16:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3598344 (10Etonkovidova) 05Open>03Re... [20:00:46] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10User-notice-collaboration: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3598440 (10Volker_E) [20:00:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10User-Petar.petkovic: Make icons size more consistent for Recent Changes filters - https://phabricator.wikimedia.org/T168835#3598438 (10Volker_E) 05Open>03stalled Well, the reason is simple: The pat... [20:31:30] (03CR) 10Catrope: [C: 032] Align board overflow menu with WikimediaUI Style Guide [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376913 (owner: 10VolkerE) [20:31:54] (03CR) 10Catrope: [C: 032] ReorderTopicsWidget: Remove hack and custom padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376882 (owner: 10VolkerE) [20:33:10] (03CR) 10Catrope: [C: 032] Move handling for missing post content to lower level [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376478 (https://phabricator.wikimedia.org/T139791) (owner: 10Mattflaschen) [20:40:15] (03Merged) 10jenkins-bot: Align board overflow menu with WikimediaUI Style Guide [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376913 (owner: 10VolkerE) [20:44:25] (03Merged) 10jenkins-bot: ReorderTopicsWidget: Remove hack and custom padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376882 (owner: 10VolkerE) [20:45:55] (03Merged) 10jenkins-bot: Move handling for missing post content to lower level [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376478 (https://phabricator.wikimedia.org/T139791) (owner: 10Mattflaschen) [20:46:50] (03CR) 10Mattflaschen: [C: 04-1] "This is included within https://gerrit.wikimedia.org/r/#/c/376862/ and can be abandoned after that is merged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376644 (owner: 10Mattflaschen) [20:52:25] (03CR) 10jenkins-bot: Align board overflow menu with WikimediaUI Style Guide [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376913 (owner: 10VolkerE) [20:53:16] (03CR) 10jenkins-bot: ReorderTopicsWidget: Remove hack and custom padding [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376882 (owner: 10VolkerE) [20:54:24] (03CR) 10jenkins-bot: Move handling for missing post content to lower level [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376478 (https://phabricator.wikimedia.org/T139791) (owner: 10Mattflaschen) [21:09:00] matt_flaschen, https://gerrit.wikimedia.org/r/#/c/376857 <-- the name looks ok? Or should it be "StructuredFilters.ui.xxxx" ? I went with Roan's previous comment... last bikeshedding! ;) [21:10:37] (03CR) 10Catrope: [C: 032] Fix interpretation of 'prioritized' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376644 (owner: 10Mattflaschen) [21:16:37] (03Merged) 10jenkins-bot: Fix interpretation of 'prioritized' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376644 (owner: 10Mattflaschen) [21:18:41] (03PS3) 10Mooeypoo: Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) [21:18:50] (03CR) 10jerkins-bot: [V: 04-1] Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [21:19:42] (03CR) 10Mooeypoo: Always place items outside menu if there's less than two of them (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [21:20:02] matt_flaschen, you broke RoanKattouw and my brains. https://gerrit.wikimedia.org/r/#/c/376862 [21:20:03] :P [21:27:50] (03PS3) 10Catrope: Fix left padding of root comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) (owner: 10Esanders) [21:28:06] (03PS4) 10Catrope: Fix left padding of root comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) (owner: 10Esanders) [22:10:34] mooeypoo, could you have three values (true, false, undefined/unset)? All of those are unambiguous and exist in both PHP and JS. [22:10:38] ^ RoanKattouw [22:10:57] She initially wanted to do it that way and I thought it was too complicated [22:11:07] But we could do that if properly documented [22:12:02] mooeypoo, RoanKattouw, I don't think it's that complicated, but we think it's useless to set to false, I'm fine dropping that. [22:12:18] Right [22:12:20] Yeah, whatever makes sense [22:12:48] mooeypoo, I'm fine with structuredChangeFilters. [22:19:39] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikimedia-General-or-Unknown, and 5 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3598747 (10greg) >>! In T171027#... [22:20:06] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10Wikidata, and 6 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on several wikis - https://phabricator.wikimedia.org/T171027#3598748 (10greg) [22:20:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RCFilters intro tour displayed on Special:Watchlist even if filters are disabled on watchlist - https://phabricator.wikimedia.org/T175639#3598752 (10Catrope) [22:21:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RCFilters intro tour displayed on Special:Watchlist even if filters are disabled on watchlist - https://phabricator.wikimedia.org/T175639#3598764 (10Catrope) @jmatazzoni Not sure if this is a blocker for anything sin... [22:35:01] (03CR) 10Mattflaschen: [C: 04-1] "Suggested tweak since we're not going to allow 'false to always put inside'." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [22:35:51] ^ Sorry, that's a little long. [22:52:02] matt_flaschen, I'm correcting to your text, but I will not use double-spacing-after-dots. [22:52:33] mooeypoo, you're right, that will make it even longer. :) [22:52:51] :D [22:53:02] Also, okay, just to verify -- the text change will mean we don't need to change the code [22:53:12] I got a little confused with this [22:55:04] (03PS4) 10Mooeypoo: Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) [22:55:11] (03CR) 10jerkins-bot: [V: 04-1] Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [22:55:19] (03CR) 10Mooeypoo: Always place items outside menu if there's less than two of them (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [22:57:30] (03PS5) 10Mooeypoo: Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) [22:59:11] mooeypoo, yeah. Before I was suggesting to change the JS to allow "false still put it inside" (which the docs allowed). Since you and RoanKattouw said that is confusing/unnecessary, I just looked at the doc. [22:59:32] matt_flaschen, ... according to this, the underscore is for the docs but the actual event is with dots. Am I understanding this right? It makes no sense https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki/page/startup.js;d400024d28aba2fe50dfad64e38bc68f727bae63$25 [22:59:51] matt_flaschen, okay just verifying, since I started getting super confused by that if statement [23:00:04] mooeypoo, yes, the event is definitely with dots. I assume it's just a JSDuck quirk/glitch. [23:00:11] (The reason for the underscores) [23:00:18] ah [23:00:23] that's.. awful [23:01:04] anyways, it's updated [23:01:06] mooeypoo, yeah, I'm not sure if it's just a URL-escaping thing, or a more valid thing (like wikipage.content should "belong" to wikipage), didn't investigate. [23:01:14] I.E. a wikipage class. [23:01:41] They are all like that, though. [23:04:43] interesting [23:07:10] (03CR) 10Mattflaschen: [C: 04-1] "Docs" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [23:09:18] mooeypoo, finishing up the gadget CSS. I wish we had LESS there... [23:09:33] I know, me too [23:09:48] (03CR) 10Mooeypoo: Always place items outside menu if there's less than two of them (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) (owner: 10Mooeypoo) [23:09:57] (03PS6) 10Mooeypoo: Always place items outside menu if there's less than two of them [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376862 (https://phabricator.wikimedia.org/T174927) [23:19:21] 10Collaboration-Team-Triage, 10Flow: Flow should provide an easy way to quote other user comments - https://phabricator.wikimedia.org/T94644#1168919 (10Tgr) A modest first step: add quote-like styling for `
` or some similar semantically applicable element in Flow comments. (Do any of the existing w... [23:27:32] (03PS5) 10VolkerE: Fix left padding of root comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) (owner: 10Esanders) [23:27:42] (03CR) 10VolkerE: Fix left padding of root comments (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) (owner: 10Esanders)