[00:34:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3534668 (10Etonkovidova) @SBisson In betalabs I do not see 'Live update... [01:04:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications: [regression] Broken link in a user rights change notification email from Echo - https://phabricator.wikimedia.org/T172636#3590312 (10jmatazzoni) [01:06:55] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10VisualEditor, 10User-MarcoAurelio: Flow with VE breaks when trying to insert links - https://phabricator.wikimedia.org/T172634#3590327 (10jmatazzoni) [01:08:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications: Maintenance script to look for scheduled events and fire them - https://phabricator.wikimedia.org/T172542#3590330 (10jmatazzoni) [01:09:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10Patch-For-Review: Method API for scheduled events - https://phabricator.wikimedia.org/T172541#3590332 (10jmatazzoni) [01:11:16] 10Collaboration-Team-Triage, 10Flow, 10Regression: [betalabs-regression] Noticeable delay when a Flow post opens for edit - https://phabricator.wikimedia.org/T172469#3499523 (10jmatazzoni) [01:15:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Cannot set my default to see all results (no filters) - https://phabricator.wikimedia.org/T172387#3590354 (10jmatazzoni) [01:18:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: rclistfromreset and rclistfrom are too close - https://phabricator.wikimedia.org/T172263#3590357 (10jmatazzoni) [02:12:41] (03PS3) 10Mattflaschen: WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) (owner: 10Catrope) [02:13:20] (03CR) 10Mattflaschen: "This is ready for review." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) (owner: 10Catrope) [07:26:14] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3590592 (10Aklapper) [08:39:34] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3590655 (10Trizek-WMF) [09:34:55] 10Collaboration-Team-Triage, 10Flow: Adjust the indentation level for direct mentions - https://phabricator.wikimedia.org/T94381#1161422 (10Qgil) > I want to see how people use the new model before we make more changes. I have been used the model almost on a daily basis for years, and I can assure that @Pgin... [09:58:28] 10Collaboration-Team-Triage, 10Notifications: Transcluding a talk page on another page sends mention notifications for all the users on the page being transcluded - https://phabricator.wikimedia.org/T174642#3590865 (10Trizek-WMF) [10:38:20] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Performance, and 3 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 artic... - https://phabricator.wikimedia.org/T171027#3591014 [11:19:14] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: rclistfromreset and rclistfrom are too close - https://phabricator.wikimedia.org/T172263#3591113 (10SBisson) 05Open>03Invalid "View newest" is ON by default everywhere. These links don't exist anymore. [11:37:00] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filters for Recent changes by default deployme... - https://phabricator.wikimedia.org/T164489#3591161 [12:19:26] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 (owner: 10Hashar) [12:19:37] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 [12:19:43] (03CR) 10Hashar: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 (owner: 10Hashar) [12:23:41] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Performance, and 3 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 artic... - https://phabricator.wikimedia.org/T171027#3591292 [12:46:35] (03CR) 10Hashar: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/185163 (owner: 10Hashar) [13:43:35] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support VE source mode (NWE) in Flow - https://phabricator.wikimedia.org/T175366#3591445 (10Esanders) [14:07:22] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support VE source mode (NWE) in Flow - https://phabricator.wikimedia.org/T175366#3591554 (10Suhadakashter) [14:08:22] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support VE source mode (NWE) in Flow - https://phabricator.wikimedia.org/T175366#3591445 (10Suhadakashter) [14:11:56] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Support VE source mode (NWE) in Flow - https://phabricator.wikimedia.org/T175366#3591635 (10Reedy) 05duplicate>03Open [14:14:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review: Turn off 'classic' ORES highlighting on the Watchlist (with beta) - https://phabricator.wikimedia.org/T174725#3591651 (10SBisson) >>! In T174725#3590145, @Eto... [14:19:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review, 10Performance: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3591657 (10SBisson) >>! In T173613#3590285, @Etonkovido... [16:24:16] stephanebisson: thanks for looking at T173613 and T174725 :) [16:24:16] T173613: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613 [16:24:17] T174725: Turn off 'classic' ORES highlighting on the Watchlist (with beta) - https://phabricator.wikimedia.org/T174725 [16:48:47] no problem, thanks for finding bugs! [17:28:31] RoanKattouw, let me know if you want me to look at your Vagrant later. [17:30:37] matt_flaschen: I'm just going to rebuild it with Jessie [17:30:41] It still had that APT error [18:38:49] 10Collaboration-Team-Triage, 10Notifications, 10Hindi-Sites: Ping system failed to notify mention on hi.wikiversity - https://phabricator.wikimedia.org/T174873#3575590 (10Etonkovidova) I tested - mentioning on hi.wiversity with [[ https://hi.wikiversity.org/w/index.php?title=%E0%A4%B8%E0%A4%A6%E0%A4%B8%E0%... [19:10:51] (03CR) 10Catrope: [C: 032] WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) (owner: 10Catrope) [19:17:56] (03Merged) 10jenkins-bot: WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) (owner: 10Catrope) [19:18:12] (03CR) 10jenkins-bot: WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) (owner: 10Catrope) [20:02:25] stephanebisson, RoanKattouw, any objection to suggested changes at https://gerrit.wikimedia.org/r/#/c/372877/ and https://gerrit.wikimedia.org/r/#/c/376719/ ? [20:04:11] matt_flaschen: I don't understand your comment on the first patch. The second one makes sense. [20:05:02] stephanebisson, you made it so ?hideanons=1 has no effect, which affects backwards compatibility, and I'm not sure why. [20:05:25] I support having the default being forced to inactive/not-hide/not-extend, but this means you can't override. [20:05:42] T162158 [20:05:42] T162158: Unstructured filters replaced by Structured filters may still affect the results - https://phabricator.wikimedia.org/T162158 [20:06:46] (03PS1) 10Chad: WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376786 (https://phabricator.wikimedia.org/T175085) [20:08:23] (03CR) 10Chad: [C: 032] WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376786 (https://phabricator.wikimedia.org/T175085) (owner: 10Chad) [20:09:16] It's made inactive on structured UI when it's replaced by another filter, how does it affect b/c? [20:15:35] (03Merged) 10jenkins-bot: WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376786 (https://phabricator.wikimedia.org/T175085) (owner: 10Chad) [20:21:00] stephanebisson, if you have existing URLs bookmarked. They will still use the old parameter/filter name, and thus it won't work, AFAICT. [20:21:17] stephanebisson, or existing URLs linked, e.g. from recentchangestext/summary or elsewhere. [20:21:24] Probably second more likely. [20:22:02] These are in fact used on enwiki (https://en.wikipedia.org/wiki/Special:RecentChanges), e.g. "IPs' contribs" [20:22:27] most old param names are kept and respected in the new system [20:23:04] Give me a complete example so I can understand what you have in mind [20:23:04] stephanebisson, I know, but I don't see the advantage of ignoring the URL parameter here. There may be one, I just don't understand yet. [20:23:26] stephanebisson, https://en.wikipedia.org/w/index.php?title=Special:Recentchanges&hideliu=1&hideanons=0 , linked from https://en.wikipedia.org/wiki/Special:RecentChanges . hideliu=1 will be ignored since it is isReplacedInStructuredUi [20:23:46] I know it's only a limited set, but the issue applies to that set. [20:24:07] This was put together to prevent 'hidedamaging', when set to true in your config, from filtering out results even though there is no UI to control it in the new system. [20:25:32] stephanebisson, the default is already false (even if true in preferences, it is forced to false in getDefault). I support forcing the default to false, I just think you should be able to override in the URL. [20:25:47] Now, forced to "opposite of active", which is usually false. [20:26:48] So unless you use bookmarked URLs, you won't filter it out, even if preferences say to. [20:42:01] Changing this behaviour was not my intention when I introduced the concept of activeValue. I also don't see how the front end would have preserved those values before. I can see your point about respecting the URL but showing results that don't match the filter area is also problematic. I guess it needs a product discussion. [20:43:57] matt_flaschen: About your other comment, I can revert the previous patch and make the change to cast to bool in setDefault from the constructor IF you can merge those today so I can swat it on Monday. [20:45:07] stephanebisson, I have a patch in progress for both right now. I'll have it up in a couple minutes. [20:45:30] stephanebisson, oh, just saw the other. I'll separate it. [20:56:47] stephanebisson, it's up at https://gerrit.wikimedia.org/r/376793 . I can ask RoanKattouw or mooeypoo to review. [20:58:49] I tested by changing $user->getBoolOption( 'hideminor' ) to $user->getOption( 'hideminor' ). [21:01:35] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Change "new editors" filter in New Pages Feed to be non-extended confirmed - https://phabricator.wikimedia.org/T175225#3587125 (10jmatazzoni) I think we can get this done in the coming weeks, if it will help out. To be clear, do you want a fil... [21:01:55] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MediaWiki-extensions-PageCuration: Change "new editors" filter in New Pages Feed to be non-extended confirmed - https://phabricator.wikimedia.org/T175225#3592960 (10jmatazzoni) [21:10:40] 10Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 10MW-1.29-release-notes, 10Patch-For-Review: Unstructured filters replaced by Structured filters may ... - https://phabricator.wikimedia.org/T162158#3592972 [21:11:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 10MW-1.29-release-notes, 10Patch-For-Review: Unstructured filters replaced by Structured filters may ... - https://phabricator.wikimedia.org/T162158#3592976 [21:17:24] 10MediaWiki-Watchlist, 10Contributors-Team, 10Wikimedia-General-or-Unknown, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), and 4 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000... - https://phabricator.wikimedia.org/T171027#3592982 [21:30:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review: Turn off 'classic' ORES highlighting on the Watchlist (with beta) - https://phabricator.wikimedia.org/T174725#3593026 (10Etonkovidova) Checked the last patch... [21:41:12] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3593044 (10Mooeypoo) @jmatazzoni question/clarification; as @Mattflaschen-WMF point... [21:41:32] matt_flaschen, updated https://gerrit.wikimedia.org/r/#/c/375097 [21:42:02] matt_flaschen, also, I added a clarification to the bug -- it will only work on RecentChanges for the moment because the **language** is RecentChanges specific, but your point is a good one - we might want to extend this out to work in Watchlist and Related Changes too [22:00:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376816 (owner: 10L10n-bot) [22:44:09] Hey, given that the whole cluster is on wmf.17 now, should I just tick the wmf.16 backports on T164234 as effectively done? [22:44:10] T164234: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234 [22:50:08] James_F, yeah, or removing them might be better. That list is getting pretty long. [22:52:32] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3593212 (10Jdforrester-WMF) [22:58:42] Also, can T175085 be marked Resolved? [22:58:42] T175085: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085 [23:08:09] 10Collaboration-Team-Triage, 10Flow, 10Notifications: Interwiki flow bundles do not update wiki names on the fly - https://phabricator.wikimedia.org/T174773#3593233 (10Etonkovidova) The issue is not reproduced reliably, unfortunately. I definitely saw it once in wmf.17 (in enwiki with notifications from test... [23:19:32] 10Collaboration-Team-Triage, 10Flow, 10Notifications: Interwiki flow bundles do not update wiki names on the fly - https://phabricator.wikimedia.org/T174773#3593281 (10IKhitron) >>! In T174773#3593233, @Etonkovidova wrote: > The issue is not reproduced reliably, unfortunately. I definitely saw it once in wmf... [23:23:50] James_F, I'll put it in QA. [23:23:57] Kk. [23:24:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3593284 (10Mattflaschen-WMF) [23:24:19] You're all awesome. Sorry I didn't get the time to come to the KIT this morning to say so. [23:25:44] James_F, that's a small patch, but thank you. What is KIT? [23:26:19] matt_flaschen: Keeping In Touch meeting. You call it a "stand-up", which is a deprecated term in business British English. [23:28:05] James_F, I can guess why it's deprecated, but when is it scheduled for removal? [23:28:43] * James_F grins. [23:48:15] 10MediaWiki-Recent-changes, 10MediaWiki-History-or-Diffs: Improve [rolblack] logic when it encounters null edits - https://phabricator.wikimedia.org/T175437#3593315 (10aaron) [23:53:25] mooeypoo, re-reviewed the tour patch. Just a couple small items about the actual tour, after that I'll test and hopefully merge.