[00:01:41] matt_flaschen: Happy to argue about wg names. :-) [00:01:59] wg-off! [00:03:13] James_F, okay, so see above, but I think the simplest option is $wgStructuredChangeFiltersShowPreference temporarily, then after we get rid of the beta feature, we'll get rid of that $wg. In the end, you can still disable the feature entirely, but using the general-purpose pref functionality (LocalSettings.php: Set default pref to what you want, hide the preference if you want). [00:03:20] matt_flaschen: I was thinking that third party users of MediaWiki might want some way of disabling RCFilters™ for their installs, so we should provide a normal wgUse* config variable, and rather than have that and also one for WMF prod enablement, blend the two use cases. But happy to be pushed other ways. [00:03:51] Yep, see immediately above. [00:04:20] matt_flaschen: Hmm. That's also a possibility. Is there anything not short-circuited by rcenhancedfilters-disable = 1 but that is/would be by wgStructuredChangeFiltersShowPreference ? [00:04:49] (I have an alternate suggestion, but it's magic-er (relies on getting rid of $wg immediately and reading between the lines of what you did with hidden prefs and defaults).) [00:05:24] James_F, I'm about to look at your patch again, but there shouldn't be. E.g. filters are registered with the same hook either way. [00:05:27] Your method is fine by me, though. You're the team that's going to support it, I'm just a by-stander. ;-) [00:05:37] Right, in that case, steam ahead. [00:15:29] I need to head off; matt_flaschen I trust your judgment and renaming skills. Can you comment on my patch if the names changed ? [00:19:24] mooeypoo, yep. [00:43:10] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email: EmailNotification should provide a getter for pageStatus - https://phabricator.wikimedia.org/T175104#3582891 (10MarkAHershberger) [00:53:31] RoanKattouw, do you think rcfilters=1 should work if it's disabled in user preferences, or should it just bypass StructuredChangeFiltersOnWatchlist ? [00:53:46] ?rcfilters=1 [00:58:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Tracking: Expose filter combinations for the main review activities - https://phabricator.wikimedia.org/T174800#3582919 (10jmatazzoni) [00:58:37] matt_flaschen: I think it would be most in keeping with precedent for URL params to override user prefs [00:58:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Tracking: Expose filter combinations for the main review activities - https://phabricator.wikimedia.org/T174800#3573379 (10jmatazzoni) a:03jmatazzoni [00:58:46] That's also what VE did back in the day [00:58:54] You could even use ?veaction=edit as an anon [00:59:09] RoanKattouw, will do. [00:59:18] Thanks [00:59:46] RoanKattouw, currently it's only for watchlist though. I can change that as well, though. [01:00:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Logged actions selected by namespace filters cannot be highlighted - https://phabricator.wikimedia.org/T174732#3582923 (10jmatazzoni) [01:01:17] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Legend' retains some space if 'Group results by change' with highlight options is enabled - https://phabricator.wikimedia.org/T174728#3582927 (10jmatazzoni) [01:02:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Make 'View newest changes' divider persistent so newest changes can be filtered - https://phabricator.wikimedia.org/T174712#3582930 (10jmatazzoni) [01:12:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Let the community display 'other review tools' by default - https://phabricator.wikimedia.org/T174574#3582946 (10jmatazzoni) [01:13:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10ORES, 10Scoring-platform-team-Backlog, 10editquality-modeling, 10artificial-intelligence: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3582948 (10jmatazzoni) [01:14:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Make default filter status visible in Active filter area - https://phabricator.wikimedia.org/T174501#3582950 (10jmatazzoni) [01:40:57] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: UsersMultiselectWidget should throw error if unselected text is present onSubmit - https://phabricator.wikimedia.org/T174485#3582992 (10dbarratt) 05duplicate>03Open [01:41:01] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3582995 (10dbarratt) [01:45:26] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: UsersMultiselectWidget should throw error if unselected text is present onSubmit - https://phabricator.wikimedia.org/T174485#3582996 (10dbarratt) @TBolliger I've simplified this issue so it is no longer a duplica... [01:45:43] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: UsersMultiselectWidget should throw error if unselected text is present onSubmit - https://phabricator.wikimedia.org/T174485#3582997 (10dbarratt) [07:47:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Update gadgets for seen/unseen styling - https://phabricator.wikimedia.org/T175062#3583260 (10Trizek-WMF) We are removing green dots only for Beta. At the moment, the majority of u... [07:54:19] 10Collaboration-Team-Triage, 10Flow: Use of Flow's TOC is not consistant with Browser history - https://phabricator.wikimedia.org/T175119#3583285 (10Trizek-WMF) [09:16:21] 10Collaboration-Team-Triage, 10Notifications: Transcluding a page on Wikipedia sends mention notifications for all the users on the page being transcluded - https://phabricator.wikimedia.org/T174642#3583461 (10Aklapper) A list of steps to reproduce, step by step, as bullet points, which leave no room for any i... [09:24:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3583484 [09:24:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3451529 [09:25:06] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3583487 (10Trizek-WMF) [10:06:09] 10Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 10Documentation: Improve the presentation structured discussion features improvements - https://phabricator.wikimedia.org/T175142#3583836 (10Trizek-WMF) [10:06:34] 10Collaboration-Team-Triage, 10Flow, 10Epic: Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt - https://phabricator.wikimedia.org/T167928#3583849 (10Trizek-WMF) [10:07:20] 10Collaboration-Team-Triage, 10Flow, 10Epic: Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt - https://phabricator.wikimedia.org/T167928#3349982 (10Trizek-WMF) [10:17:06] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Add "stub" as a possible issue (flagged in red) in the New Pages Feed/Page Curation Tool - https://phabricator.wikimedia.org/T157054#2993819 (10Kudpung) Where is the follow up to this? [10:22:32] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Allow moving to draftspace and tagging accordingly - https://phabricator.wikimedia.org/T124396#3583904 (10Kudpung) No coment? Just being ignored? [10:56:24] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: Don't hide the View newsletter link? - https://phabricator.wikimedia.org/T174927#3583944 (10Elitre) [12:17:10] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3584068 (10Trizek-WMF... [12:36:45] 10Collaboration-Team-Triage, 10Flow: When you mention someone on Flow, the cursor is positioned before the template - https://phabricator.wikimedia.org/T175152#3584141 (10Trizek-WMF) [12:40:51] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3584149 (10SBisson) [13:41:04] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Browser-Support-Firefox: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580332 (10Zebulon84) Simple example to explicit this : with this code ``` 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Type ":not [namespace]" is not doesn't excludes [namespace] namespace - https://phabricator.wikimedia.org/T175169#3584852 (10Trizek-WMF) [16:05:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3584853 (10Trizek-WMF) [16:05:53] (03CR) 10jerkins-bot: [V: 04-1] Handle new fields for RecentChange object attributes [extensions/Flow] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376286 (https://phabricator.wikimedia.org/T166732) (owner: 10Chad) [16:20:31] 10Collaboration-Team-Triage, 10Flow, 10Multimedia, 10Parsoid: Flow doesn't render correctly - https://phabricator.wikimedia.org/T124876#3584885 (10dr0ptp4kt) [16:21:10] 10Collaboration-Team-Triage, 10Flow, 10Parsoid: Flow doesn't render correctly - https://phabricator.wikimedia.org/T124876#1969230 (10dr0ptp4kt) [16:48:37] (03CR) 10Chad: [V: 032 C: 032] "stfu jenkins" [extensions/Flow] (wmf/1.30.0-wmf.17) - 10https://gerrit.wikimedia.org/r/376286 (https://phabricator.wikimedia.org/T166732) (owner: 10Chad) [16:54:49] 10Collaboration-Team-Triage, 10Flow: Contents from thread appear or disappear depending on cursor position - https://phabricator.wikimedia.org/T174460#3562740 (10Etonkovidova) Confirmed the issue in betalabs. To reproduce the issue - a topic should be 'Marked as resolved' - the comments (the thread) of a to... [17:06:38] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog (Current): Confirm that "thresholds" change will not affect RCFilters - https://phabricator.wikimedia.org/T175053#3585145 (10awight) [17:11:02] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog (Current): Some RC changes do not display highlight with ORES Quality and Intent filters - https://phabricator.wikimedia.org/T172840#3510959 (10Halfak) [17:14:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10ORES, 10editquality-modeling, 10Scoring-platform-team-Backlog (Current), 10artificial-intelligence: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3585217 (10awight) [17:15:37] (03PS1) 10Anomie: Remove reference to deprecated IDatabase->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376297 [17:15:41] (03PS1) 10Anomie: Remove reference to deprecated IDatabase->nextSequenceValue() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/376299 [17:17:46] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog (Current): Confirm that "thresholds" change will not affect RCFilters - https://phabricator.wikimedia.org/T175053#3585258 (10Halfak) [17:23:02] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog: Confirm that "thresholds" change will not affect RCFilters - https://phabricator.wikimedia.org/T175053#3585285 (10Halfak) [17:23:04] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10ORES, 10Scoring-platform-team-Backlog, 10editquality-modeling, 10artificial-intelligence: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3585286 (10Halfak) [17:23:07] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog: Some RC changes do not display highlight with ORES Quality and Intent filters - https://phabricator.wikimedia.org/T172840#3585287 (10Halfak) [17:23:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)): Componentization-lite of Extension:ORES UI and API - https://phabricator.wikimedia.org/T172339#3585288 (10Halfak) [17:23:14] 10Collaboration-Team-Triage, 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)): Hide ORES review letter from the change list legend. - https://phabricator.wikimedia.org/T172338#3585289 (10Halfak) [17:30:00] (03CR) 10Legoktm: [C: 032] Remove reference to deprecated IDatabase->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376297 (owner: 10Anomie) [17:30:24] (03CR) 10Legoktm: [C: 032] Remove reference to deprecated IDatabase->nextSequenceValue() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/376299 (owner: 10Anomie) [17:35:01] 10Collaboration-Team-Triage, 10Flow, 10Parsoid: Flow doesn't render correctly - https://phabricator.wikimedia.org/T124876#1969230 (10Arlolra) The problem seems to be that gallery.css is only loaded when you enter visual editing mode. When you click it, you can see a style element injected into th... [17:40:07] (03Merged) 10jenkins-bot: Remove reference to deprecated IDatabase->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/376297 (owner: 10Anomie) [17:40:15] (03Merged) 10jenkins-bot: Remove reference to deprecated IDatabase->nextSequenceValue() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/376299 (owner: 10Anomie) [18:13:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'What's this?' element is misaligned. - https://phabricator.wikimedia.org/T165627#3585744 (10Volker_E) 05Resolved>03Open Not sure what happened here, patch hasn't been merged: https://gerrit.wikimedi... [18:16:24] 10Collaboration-Team-Triage, 10Notifications: Transcluding a page on Wikipedia sends mention notifications for all the users on the page being transcluded - https://phabricator.wikimedia.org/T174642#3585758 (10UpsandDowns1234) Check on en.wikipedia.org. I have done it there, and I do not want to send mentions... [18:21:10] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-User-preferences: UsersMultiselectWidget should throw error if unselected text is present onSubmit - https://phabricator.wikimedia.org/T174485#3585782 (10TBolliger) [18:21:37] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-User-preferences: UsersMultiselectWidget should throw error if unselected text is present onSubmit - https://phabricator.wikimedia.org/T174485#3563539 (10TBolliger) Low prio for AHT, removing #anti-harassment tag. [18:35:24] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-User-preferences: UsersMultiselectWidget should throw error if unselected text is present onSubmit - https://phabricator.wikimedia.org/T174485#3563539 (10matmarex) I think we solved a very similar issue some years ago per T115010, with 9aba218a882f. E... [19:46:16] RoanKattouw, matt_flaschen: Hey, have either of you seen https://phabricator.wikimedia.org/T175080 yet? It's blocking the train. Not sure if it's our fault or Cirrus's. [19:48:14] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3586165 (10Jdforrester-WMF) On hearing of this I initially presumed that {T172025} might be related, but it wasn't... [19:56:04] Also https://phabricator.wikimedia.org/T175085 [20:01:06] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3582364 (10Catrope) `/w/api.php?action=flow&format=json&submodule=view-header&uselang=en&page=Special%3AUndelete&vhformat=html` is a very weird request. Who o... [20:01:58] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3582221 (10Catrope) Does anyone know which wikis this error happens on? For example, does it only happen on testwi... [20:03:27] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3582221 (10EBernhardson) It was only deployed to group0, looks like mostly testwiki: https://logstash.wikimedia.or... [20:04:41] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3586313 (10Catrope) Aha. But there are some fawiki occurrences too, although they look different. [20:09:59] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3586345 (10Catrope) a:03Catrope [20:12:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3586348 (10SBisson) Do we want the 2 new filters (page name, to vs. from) to be included in the saved queries... [20:14:16] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3586365 (10demon) Indeed, that was my thought--bizarre requests to make. Without digging into the request logs I couldn't answer //who// is causing it. [20:34:00] 10Collaboration-Team-Triage, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#3586426 (10Krinkle) [20:34:02] 10Collaboration-Team-Triage, 10WikiLove: WikiLove: Clicking "Edit source" in preview opens the first section on the page, not the one you're trying to add - https://phabricator.wikimedia.org/T71260#3586428 (10Krinkle) [20:38:18] 10Collaboration-Team-Triage, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#2112870 (10Krinkle) Just ran into this on Commons. The "[edit]" section edit link points to .... [20:38:33] James_F: Stopgap: don't move to wmf.17 on flow wikis? [20:38:34] :) [20:39:18] no_justification: Meh. [20:41:05] Well barring a real fix I can only think of hacks. I really dont want to hold the train because of it cuz its not an actual problem [20:41:25] Its just sufficiently noisey to drown out real issues [20:41:33] And im grumpy [20:42:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376394 (owner: 10L10n-bot) [20:42:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'What's this?' element is misaligned. - https://phabricator.wikimedia.org/T165627#3586446 (10jmatazzoni) @Etonkovidova, did you check this? Should I Resolve? [20:43:28] no_justification: Sure, but so far you've had a quick response on one and no response on the other. Maybe it's a 30 second fix but it's RoanKattouw's input you need, not mine. [20:43:50] The -1 one I can probably fix today [20:44:23] But it's also not a very real problem [20:44:38] The cirrus exceptions are more problematic, I talked to Matt about an hour ago and he's going to work on those [20:44:50] (cc matt_flaschen ) [20:45:22] Right. [20:45:58] Ok good. Thx folks :) [20:46:10] * no_justification wanders off for some lunch [20:55:39] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3586485 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [20:58:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3586489 (10jmatazzoni) >>! In T172161#3586348, @SBisson wrote: > Do we want the 2 new filters (page name, to... [21:31:46] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: Have a way to unsubscribe to the Newsletter in Notifications. - https://phabricator.wikimedia.org/T174666#3586586 (10Qgil) p:05Triage>03Low Now the notification has two links, one to the issue announced and another one to th... [21:37:24] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: Have a way to differenciate the Newsletter title in Notifications. - https://phabricator.wikimedia.org/T174658#3586672 (10Qgil) p:05Triage>03Low What benefit would it have to use italics? It's a notification and not a PhD, s... [21:57:41] (03PS1) 10Legoktm: Disable edit section links in preview [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/376440 (https://phabricator.wikimedia.org/T129692) [22:05:14] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team: Make RCFilters compatible with both the old and new thresholds APIs - https://phabricator.wikimedia.org/T175053#3586754 (10Catrope) [22:11:36] (03CR) 10Catrope: [C: 032] Disable edit section links in preview [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/376440 (https://phabricator.wikimedia.org/T129692) (owner: 10Legoktm) [22:12:55] (03Merged) 10jenkins-bot: Disable edit section links in preview [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/376440 (https://phabricator.wikimedia.org/T129692) (owner: 10Legoktm) [22:31:38] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team: Make RCFilters compatible with both the old and new thresholds APIs - https://phabricator.wikimedia.org/T175053#3586831 (10Catrope) [22:36:47] thanks RoanKattouw [22:37:32] 10Collaboration-Team-Triage, 10WikiLove, 10Patch-For-Review: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#3586854 (10Legoktm) 05Open>03Resolved a:03Legoktm [22:37:35] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Tweak UI for main filtering entry point - https://phabricator.wikimedia.org/T175217#3586856 (10jmatazzoni) [22:45:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Tweak UI for main filtering entry point - https://phabricator.wikimedia.org/T175217#3586886 (10jmatazzoni) @Pginer-WMF, you may need to clarify the desired font for the instruction text in the search bar.... [22:57:43] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3582364 (10Mattflaschen-WMF) >>! In T175085#3586241, @Catrope wrote: > That said, we shouldn't die with an exception. But do we have any information about who... [22:58:10] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3586926 (10Mattflaschen-WMF) https://www.mediawiki.org/w/api.php?action=help&modules=flow%20view-header [23:07:59] 10Collaboration-Team-Triage, 10Flow: Revisions for $UUID could not be found - https://phabricator.wikimedia.org/T175219#3586947 (10Mattflaschen-WMF) [23:08:41] matt_flaschen: Hmph so vagrant provision is still broken on my machine, so I can't install Flow to test my patch [23:08:49] I'll upload it anyway, can you test it? [23:09:38] (03PS1) 10Catrope: [WIP] WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) [23:09:41] matt_flaschen: --^^ [23:09:45] RoanKattouw, yeah. [23:12:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) (owner: 10Catrope) [23:20:44] (03PS2) 10Catrope: [WIP] WorkflowLoaderFactory: Don't crash for negative namespace titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376447 (https://phabricator.wikimedia.org/T175085) [23:32:00] RoanKattouw, I get a different error on master. Investigating. [23:32:15] Might depend on config [23:32:27] "Page provided does not have Flow enabled and safeAllowCreation failed with: User does not have the \"Create Flow boards in any location\" permission" [23:38:46] no_justification or RoanKattouw, can you add a specific example (i.e. which wiki/domain) to T175085? [23:38:46] T175085: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085 [23:42:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Documentation, 10Goal: 'Integrated filters'— document all new implementations defined on T162675 - https://phabricator.wikimedia.org/T167855#3586992 (10jmatazzo... [23:42:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation: Write help documentation for Tagged Edits filtering of Recent Changes. - https://phabricator.wikimedia.org/T167740#3586990 (10jmatazzoni) 05Open>03Resolved Here is the page. https... [23:43:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3586998 (10jmatazzoni) [23:43:54] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation: Write help doc for Namespace filtering of Recent Changes, and link to it from Namespace filter panel - https://phabricator.wikimedia.org/T167741#3586995 (10jmatazzoni) 05Open>03Resolv... [23:47:49] 10Collaboration-Team-Triage, 10Flow, 10Patch-For-Review, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3587004 (10Mattflaschen-WMF) [23:52:51] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Make it more obvious to user how to add a filter - https://phabricator.wikimedia.org/T173257#3587022 (10jmatazzoni) 05Open>03Resolved Closing this design task, which is succeeded by T175217 [23:55:31] RoanKattouw, yeah, you get the safeAllowCreation if you don't have flow-create-board. I can reproduce the other one on master if I do have that. [23:57:50] RoanKattouw, and your fix sort of works, but it makes it create an actual workflow. I think it is never saved (just for the request), but I think it would be better to throw, both in WorkflowLoaderFactory (similar to the CrossWikiException, but a FlowException) and ApiFlow->getPage (a dieWithError) [23:58:06] I did check the DB and I'm pretty confident it's not saving anything.