[04:27:06] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Tagging redirect for CSD or RfD with Twinkle no longer adds page to page triage list - https://phabricator.wikimedia.org/T171063#3578810 (10GeoffreyT2000) 05Open>03Resolved a:03GeoffreyT2000 Seems to no longer be a problem. [08:18:15] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Performance, and 3 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 artic... - https://phabricator.wikimedia.org/T171027#3484259 [09:41:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3579274 (10Trizek-WMF) [09:42:01] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Tracking: Expose filter combinations for the main review activities - https://phabricator.wikimedia.org/T174800#3579273 (10Trizek-WMF) [09:53:01] 10MediaWiki-Watchlist, 10Commons, 10Contributors-Team, 10GlobalUsage, and 3 others: Show edits made on WikimediaCommons on the Watchlist - https://phabricator.wikimedia.org/T91192#1076399 (10srishakatux) Would there be any interest in mentoring this project for Outreachy Round 15? Application period opens... [12:49:14] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: "View newsletter" should be changed to "Manage your newsletter options" in Email Notifications - https://phabricator.wikimedia.org/T174805#3579799 (10Trizek-WMF) I'm referring to Email notifications, like in: {F9339729} Here, vi... [14:31:25] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3580163 (10Mattflaschen-WMF) [14:36:15] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3580189 (10Mattflaschen-WMF) [14:43:47] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3580216 (10Mattflaschen-WMF) [14:55:34] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3580242 (10Mattflaschen-WMF) [14:59:01] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3580251 (10Mattflaschen-WMF) [15:01:42] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3580261 (10SBisson) What is being downloaded every 3 seconds is a page with # the standard MW... [15:09:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3534668 (10Mattflaschen-WMF) >>! In T173613#3580261, @SBisson wrote: > By-passing #2 and #3 do... [15:21:58] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10OOjs-UI: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580332 (10Trizek-WMF) [15:22:26] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10OOjs-UI: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580345 (10Trizek-WMF) [15:23:04] matt_flaschen: We didn't enable T164234 during the window? [15:23:05] T164234: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234 [15:25:20] James_F, no. I'm still deploying, but there are unmerged blockers, so we'll have to follow up. [15:26:01] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10OOjs-UI: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580350 (10Trizek-WMF) BTW, fr.wp [[ https://fr.wikipedia.org/w/index.php?title=MediaWiki:Rcfilters-other-review-tools&a... [15:26:35] mooeypoo: this last bug may interest you. ^ [15:31:05] stephanebisson, scap is running; this covers all the changes previously merged to master (except config). I'll start reviewing the unmerged ones, but we'll need an additional later window. [15:32:37] matt_flaschen: Ah, right. [15:43:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3580430 (10jmatazzoni) @Trizek-WMF I see that you made this a child of T174800. A... [15:50:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Make "live update" not download the entire RC page every 3 seconds - https://phabricator.wikimedia.org/T173613#3580449 (10SBisson) a:03SBisson [15:52:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3580458 (10Trizek-WMF) >>! In T167944#3580430, @jmatazzoni wrote: > @Trizek-WMF I... [15:58:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3580474 (10SBisson) a:03SBisson [16:09:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3580527 (10jmatazzoni) [16:10:17] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3580527 (10jmatazzoni) [16:10:59] 10Collaboration-Team-Triage, 10Flow, 10AbuseFilter: AbuseFilter test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1715614 (10matej_suchanek) In rEABF32e2a7c27e9b0f5dba0328287434a0a3a5331e48, I tried to generalize how `recentchanges` are used in both interfaces for testing. I... [16:18:16] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment (AHT Sprint 4), 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: Preferences/Notification, Save button stays disable when editing Block list - https://phabricator.wikimedia.org/T173973#3546650 (10dbarratt)... [16:18:19] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3580564 (10dbarratt) [16:38:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3580677 (10awight) I'm not sure I see the need for short-circuitin... [16:40:54] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3580688 (10Mattflaschen-WMF) [16:42:30] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3226582 (10Mattflaschen-WMF) [16:45:13] stephanebisson, mooeypoo, James_F, deploy is done for now. In addition to having more patches to merge on our side (which is still the case), I ran into mysterious T175041 so aborted the scap. I then did a sync-dir instead of reverting the non-i18n patch. [16:45:14] T175041: scap sync failed on i18n - https://phabricator.wikimedia.org/T175041 [16:47:04] I deployed "WLFilters: adapt to customized watchlist-details" (https://gerrit.wikimedia.org/r/376030) and "WLFilters: wrap Watchlist-details in a div instead of a p" (https://gerrit.wikimedia.org/r/376031). [16:47:48] stephanebisson, mooeypoo, James_F, those are tested in production, but feel free to do so as well. Unfortunately, although none of the unmerged patches include i18n, we need to redo that (and hope we don't run into the bug again). i18n is the slow part of these deploys. [16:54:00] ^ etonkovi_ [16:56:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3226582 (10Mattflaschen-WMF) I ran into {T175041} (apparently unrelated to our code, but I cancelled the... [17:14:59] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10OOjs-UI, 10Browser-Support-Firefox: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580890 (10Trizek-WMF) [17:22:11] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Browser-Support-Firefox: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580918 (10matmarex) [17:33:01] stephanebisson, thanks, I was looking at the wrong message. It's in https://en.wikipedia.org/wiki/MediaWiki:Wlheader-showupdated . [17:33:16] matt_flaschen: yep [17:34:02] matt_flaschen: You see the custom html, they toggle visibility of the last 2 parts (bold, green dot) [17:35:14] stephanebisson, yeah, for the key too. [17:35:26] key/legend [17:38:07] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Browser-Support-Firefox: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3581035 (10Trizek-WMF) [17:40:09] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Browser-Support-Firefox: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3580332 (10jmatazzoni) Not seeing this in Mac Firefox. {F9343284} [17:42:01] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: Don't hide the View newsletter link? - https://phabricator.wikimedia.org/T174927#3581048 (10Mattflaschen-WMF) If you're getting duplicate notifications, please file that separately. [17:43:15] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Browser-Support-Firefox: Remove on MediaWiki:Rcfilters-other-review-tools - https://phabricator.wikimedia.org/T175031#3581051 (10Trizek-WMF) [17:45:42] (03Abandoned) 10Paladox: Update onLoadExtensionSchemaUpdates hook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260254 (owner: 10Paladox) [17:57:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3581096 (10SBisson) @jmatazzoni I have 2 questions about Related Changes, not about this task specifically bu... [17:58:15] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3581101 (10TBolliger) From {T174191} we can see that on pl.wikipedia for the past 30 days only 7 user... [17:58:29] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3581103 (10TBolliger) [17:59:10] 10Collaboration-Team-Triage, 10Notifications: Transcluding a page on Wikipedia sends mention notifications for all the users on the page being transcluded - https://phabricator.wikimedia.org/T174642#3568842 (10Trizek-WMF) Can you clarify how you have done this transclusion, @UpsandDowns1234 ? Do you have any l... [18:01:42] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Let the community display 'other review tools' by default - https://phabricator.wikimedia.org/T174574#3581116 (10Trizek-WMF) [18:10:30] RoanKattouw, is there a separate step for enabling the filters, vs. enabling the models themselves? And who does each step? Asking re T174560. [18:10:30] T174560: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560 [18:15:38] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Introduce the New Filters to users upon beta graduation through a GuidedTour - https://phabricator.wikimedia.org/T174701#3581150 (10jmatazzoni) [18:15:48] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Introduce the New Filters to users upon beta graduation through a GuidedTour - https://phabricator.wikimedia.org/T174701#3570601 (10jmatazzoni) 05Open>03declined [18:15:51] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3581155 (10jmatazzoni) [18:16:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Introduce the New Filters to users upon beta graduation through a GuidedTour - https://phabricator.wikimedia.org/T174701#3581161 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [18:17:55] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog: Confirm that "thresholds" change will not affect RCFilters - https://phabricator.wikimedia.org/T175053#3581177 (10Halfak) [18:26:20] RoanKattouw, relatedly, is T172339 still in the quarter? [18:26:20] T172339: Componentization-lite of Extension:ORES UI and API - https://phabricator.wikimedia.org/T172339 [18:43:09] (03CR) 10Legoktm: [C: 032] "This is all a bad hack :(" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/374861 (https://phabricator.wikimedia.org/T166732) (owner: 10Anomie) [18:45:52] 10Collaboration-Team-Triage, 10ORES, 10Scoring-platform-team-Backlog, 10editquality-modeling, 10artificial-intelligence: Enable ORES filters for svwiki - https://phabricator.wikimedia.org/T174560#3581253 (10jmatazzoni) @Trizek-WMF, Rev Scoring is shooting for Sept. 20th to enable, according to Aaron. [18:47:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3581268 (10jmatazzoni) [18:51:51] (03Merged) 10jenkins-bot: Handle new fields for RecentChange object attributes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/374861 (https://phabricator.wikimedia.org/T166732) (owner: 10Anomie) [18:55:50] stephanebisson, do you want to set a time to go over Related Changes? [18:56:33] (03CR) 10jenkins-bot: Handle new fields for RecentChange object attributes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/374861 (https://phabricator.wikimedia.org/T166732) (owner: 10Anomie) [18:56:40] matt_flaschen: I put my questions in T172161 [18:56:41] T172161: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161 [18:56:54] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3581349 (10jmatazzoni) In T172161#3581096, @SBisson wrote: > 1. Do we expect Related Changes to graduate out... [19:00:35] matt_flaschen, mooeypoo: regression on related changes: https://gerrit.wikimedia.org/r/#/c/376074/ [19:02:29] stephanebisson, reviewing. [19:07:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161#3581427 (10SBisson) >>! In T172161#3581349, @jmatazzoni wrote: > In general we are seeing Related Changes as... [19:07:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3581445 (10Mattflaschen-WMF) [19:11:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Long search times for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith" OR "May be bad faith") - https://phabricator.wikimedia.org/T164292#3581461 (10jmatazzoni) [19:13:27] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Long search times for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith" OR "May be bad faith") - https://phabricator.wikimedia.org/T164292#3228852 (10jmatazzoni) [19:13:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Regression: [regression - wmf.12] RC page - Timeout with "may be bad faith" and "likely good" - https://phabricator.wikimedia.org/T172816#3581480 (10jmatazzoni) [19:15:27] 10Collab-Notifications-Page, 10Collaboration-Team-Triage: Pagination direction widget should scroll users to top of page - https://phabricator.wikimedia.org/T170203#3581495 (10jmatazzoni) [19:16:36] 10Collaboration-Team-Triage, 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)): Hide ORES review letter from the change list legend. - https://phabricator.wikimedia.org/T172338#3581499 (10jmatazzoni) [19:17:39] 10Collaboration-Team-Triage, 10Flow, 10Epic: Improve structured discussion features for the communities that use them, based on user feedback and prioritising technical debt - https://phabricator.wikimedia.org/T167928#3581514 (10jmatazzoni) [19:19:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Accessibility: Show last 250 changes and period selection dropdowns are not keyboard accessible - https://phabricator.wikimedia.org/T174819#3581523 (10jmatazzoni) [19:20:55] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Update gadgets for seen/unseen styling - https://phabricator.wikimedia.org/T175062#3581532 (10Mattflaschen-WMF) [19:21:02] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: Minor UI problems with List type preference for Mute - https://phabricator.wikimedia.org/T174485#3581550 (10TBolliger) >>! In T174485#3570755, @dbarratt wrote: > So @dmaza and I talked about this and {T173973} co... [19:21:33] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment (AHT Sprint 4), 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: Preferences/Notification, Save button stays disable when editing Block list - https://phabricator.wikimedia.org/T173973#3581553 (10TBolliger) [19:21:38] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: Minor UI problems with List type preference for Mute - https://phabricator.wikimedia.org/T174485#3581555 (10TBolliger) [19:45:17] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: RCFilters: Some active tags with 0 tagged changes show, others do not - https://phabricator.wikimedia.org/T175066#3581692 (10Mattflaschen-WMF) [19:50:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3581740 (10Mattflaschen-WMF) There are 3 active tags containing 2017 (code n... [19:50:24] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3581758 (10Mattflaschen-WMF) @jmatazzoni If your screenshot is different, ca... [19:57:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3581772 (10Deskana) I've been wondering what these tags were for a while. Lo... [19:58:13] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3581774 (10Mattflaschen-WMF) >>! In T150419#3542516, @TBollig... [19:58:54] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3581777 (10Jdforrester-WMF) I don't know if it's possible to delete the `201... [20:01:01] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3581782 (10Deskana) >>! In T175038#3581777, @Jdforrester-WMF wrote: > I don'... [20:07:10] stephanebisson, I raised a question we might want to properly discuss re https://gerrit.wikimedia.org/r/#/c/376041 [20:11:58] 10Collab-Notifications-Page, 10Collaboration-Team-Triage: Special:Notifications - Pagination direction widget should scroll users to top of page - https://phabricator.wikimedia.org/T170203#3581846 (10Etonkovidova) [20:15:29] stephanebisson, also, we can do this check in JS using $.ajax( { type: 'HEAD' } ) and check the response [20:16:20] mooeypoo: does MW respond to http head? [20:16:47] that's what I'm emulating with the 'peek' param [20:16:51] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: Don't hide the View newsletter link? - https://phabricator.wikimedia.org/T174927#3581862 (10Qgil) > So I think I got two notifications about the same newsletter? (One is read and is at bottom of screenshot.) No, looking at http... [20:16:52] stephanebisson, we can check [20:17:00] stephanebisson, yeah I see but I think it should... [20:17:09] anyways, I think if we're already doing that, let's not mark 404 ? :\ [20:18:00] you understand that making this case not 404 doesn't change the other 404 case [20:18:51] unless we can change the other one (set up 3 years ago) we still have to check for 404 in the front end [20:19:35] OF course, but if we already check-before-we-fetch, we might as well make that test be better experience? [20:20:05] You're creating a new API now -- shouldn't we make it better? :\ [20:20:31] sure [20:20:46] We can at least not have 404 errors every 30 seconds like that [20:21:01] 30 seconds!? 3 seconds ;) [20:21:07] err yes [20:21:38] But I don't know.. RoanKattouw should probably pitch in here in terms of strategic codewise.. I think htat since it's essentially just a "do I have results?" question API, we should output a clear yes/no code that doesn't need to be 404 if possible [20:21:51] But that *would* make it different behavior to the other one [20:22:14] mooeypoo: Not 200 vs. 208? [20:22:45] 304 (not modified) is close enough in term of meaning [20:22:47] mooeypoo: "Already reported"; non-standard usage but it's more a 20x error. [20:22:52] Or that. [20:24:12] mooeypoo: also, I wanted to ask you about T172161. Which widget is closer to the drop down menu there? [20:24:13] T172161: Integrating 'Related Changes' tools into the new UX - https://phabricator.wikimedia.org/T172161 [20:25:01] it's kind of a frameless DropdownWidget? [20:29:49] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3581961 (10TBolliger) >>! In T150419#3581774, @Mattflaschen-W... [20:30:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3581968 (10Mattflaschen-WMF) >>! In T175038#3581782, @Deskana wrote: > They... [20:30:58] stephanebisson, looking [20:31:25] stephanebisson, you're talking about the "Show changes on pages linked to" dropdown? [20:31:35] that looks like a TitleLookupWidget [20:31:35] yep [20:31:39] VE uses it with links [20:31:45] not sure if it's a VE-specific widget or if it was generalized [20:31:49] * mooeypoo looks at James_F [20:31:52] no, the one one top [20:32:07] look at all the screenshots [20:32:17] mooeypoo: It's in MW. [20:32:18] The one that opens to "NASA / Nashville, Tenessee / etc" ? [20:32:24] no [20:32:27] oh [20:32:29] Which? [20:32:31] the one on top [20:32:39] oh [20:32:44] It's a different one... [20:32:46] I se it [20:33:33] I would say that's a custom dropdown select widget? We'll have to customize the items to display the image from the page [20:33:42] stephanebisson, wait, this should titles too, right? [20:34:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [testwiki-wmf.17] default Preferences-Gadgets setting "Display green collapsible arrows and green bullets..." displays colored dots on RC page - https://phabricator.wikimedia.org/T175074#3581996 (10Etonkovidova) [20:34:46] hold on, you see it open here: https://phabricator.wikimedia.org/F9213497 [20:34:56] stephanebisson, on first quick glance, I'd try and reuse the OptionWidgets used inside TitleLookupWidget [20:35:02] it's not the title, it's to select TO vs. FROM [20:35:16] oh [20:35:17] what [20:35:20] that's so confusing [20:35:27] ok that's just a dropdown widget [20:35:35] pretty sure we're using the exact style in Flow [20:35:37] yes, this UI is... sub par [20:35:42] stephanebisson: can you take a look at https://phabricator.wikimedia.org/T175074, please? It might be a regression. I do not recall that behavior before [20:35:56] look at the select widget that chooses the topic order in Flow boards [20:36:04] it's the same except it has an icon [20:36:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3582014 (10jmatazzoni) @Mattflaschen-WMF, the one that I called just "2017"... [20:36:55] meh shoot I forgot to enable Flow on my new computer's vagrant [20:36:59] reprovisioning [20:37:08] right [20:37:36] It should just be a straight-up dropdown widget though [20:38:30] etonkovi_: it's the same gadget that's causing headache on watchlist... I don't think it's a regression [20:38:34] https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#DropdownWidget [20:38:57] stephanebisson, I think the design should go with **standard** dropdown honestly (muttermutter) but if we must we can get rid of the border. [20:39:15] mooeypoo: yeah, according to the task, the widget shows a label that is slightly different than the selected option... [20:39:26] stephanebisson: oh, good to know that is not a regression [20:39:27] but I'm not doing that [20:39:42] If that's the case(meeeehhh) then we can do a button with a menu [20:39:46] but... mehhhh [20:40:10] The Simplest Thing That Can Possibly Work, then we'll see [20:40:16] +1 [20:40:38] Yeah it should just be straight-up dropdown widget with straight-up MenuOptionWidgets [20:41:01] listen to "choose" and see what item was chosen by its data [20:41:22] And for the other one, you're saying TitleLookupWidget is close but doesn't have images... [20:42:21] in which repo would that be? [20:42:46] Title Lookup should have images [20:43:05] So the widget seems to have 2 states; the lookup to ADD pages, but then it displays a list of chosen pages already? [20:43:10] if I understand the interface [20:43:54] not quite, it's a lookup to select THE page [20:44:32] and the dropdown above selects if we should show changes that link TO or FROM the selected page [20:44:53] OK, so two things happen -- a lookup thing (TitleLookupWidget, it looks like) but then the chosen page is displayed, which looks like it's the same **item** from what we see inside the dropdown of the title lookup [20:44:58] the fact that the first widget opens up and cover the second one completely is really confusing [20:45:14] so I'd use title lookup, and then extract the MenuItem that's used for title lookup and use that inside some wrapper for the "display" of the chosen page [20:45:16] yes [20:45:23] thatshould be the least amount of work, reusing the existing stuff [20:45:28] where is TitleLookupWidget? [20:45:33] looking [20:45:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/376114 (owner: 10L10n-bot) [20:45:39] can't find that string in core [20:45:57] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: Minor UI problems with List type preference for Mute - https://phabricator.wikimedia.org/T174485#3582053 (10dbarratt) @TBolliger > If a username is typed (not selected from the list), the 'Save' button is active... [20:47:05] stephanebisson, ha, they changed the name "mw.widgets.TitleWidget" [20:47:21] great, [20:47:23] thanks! [20:47:24] hang on though [20:47:26] that's a mixin [20:47:33] you should probably use it with a lookup element [20:47:37] let me find a complete thing [20:48:03] oh, no, it seems to be doing the lookup itself [20:48:40] what should I mix it with, a cup of flour, sugar and butter? [20:48:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3582055 (10jmatazzoni) I did a search using highlights to see if either of t... [20:49:29] It should be with a search widget .. hang on, I'm slightly confused here about how it was separated from VE [20:49:33] stephanebisson, looking, one sec [20:50:19] stephanebisson, ha! okay, scratch that. Use mw.widgets.TitleSearchWidget -- that's already built for you with SearchWidget + RequestManager + TitleWidget [20:50:34] stephanebisson, it should be straight forward [20:50:40] ... **should** [20:50:40] I'm lucky [20:50:49] or not [20:50:59] stephanebisson, I thought you'd be disappointed you don't need to extend everything! [20:52:03] stephanebisson, we will need to change the "choose" event slightly, though. Teh current widget just chooses the title to be in the input text (which makes sense, really) -- if we want, instead, to display the item itself, we'll have to change that behavior. [20:52:09] Start with straight forward, though. [20:52:11] We can change later. [20:52:41] will do [20:55:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [testwiki-wmf.17] RC page with "Grouped by page" option-Preferences-Gadgets setting "Display green collapsible arrows and green bullets..." displays colored dots - https://phabricator.wikimedia.org/T175074#3582101 (1... [21:00:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3582113 [21:00:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Delete useless '2017' and '2017 source edit' tags at the top of the Tags filter menu - https://phabricator.wikimedia.org/T175038#3582115 (10Jdforrester-WMF) a:03Jdforrester-WMF OK, these are now deleted. [21:01:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Update gadgets for seen/unseen styling - https://phabricator.wikimedia.org/T175062#3582119 (10jmatazzoni) Elena just pointed out to me that the gadget about green dots affects RC p... [21:25:44] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3582197 (10matmarex) > If the problem returns we should think about a more universal solution, such a... [21:30:04] 10Collaboration-Team-Triage, 10Notifications: Transcluding a page on Wikipedia sends mention notifications for all the users on the page being transcluded - https://phabricator.wikimedia.org/T174642#3582213 (10UpsandDowns1234) I transcluded a userpage with a bunch of links to other's userpages into another use... [21:30:39] 10Collaboration-Team-Triage, 10Notifications: Transcluding a page on Wikipedia sends mention notifications for all the users on the page being transcluded - https://phabricator.wikimedia.org/T174642#3582214 (10UpsandDowns1234) Also, see //en.wikipedia.org/wiki/User_talk:Iridescent [21:34:05] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10MediaWiki-User-preferences: Minor UI problems with List type preference for Mute - https://phabricator.wikimedia.org/T174485#3582216 (10TBolliger) I've seen several examples of pages warning when a user tries to navigate away with unsubmitt... [21:36:15] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3582221 (10demon) [21:43:01] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3582268 (10Catrope) [21:53:21] I keep trying to review a patchset and I get "The following command failed with exit code 104" and then code with 404 not found [21:53:24] anyone encountered this?! [21:55:40] ok my git remote was all messed up [21:58:06] stephanebisson, I'm a little confused -- $user->getOption( 'rcenhancedfilters' ) <-- this marks whether a user has the beta enabled. When we graduate out of beta, won't this now mark whether the user is opted in or opted out [22:02:53] mooeypoo, no, we're making a new preference (I guess because in the new preference, checked means off). [22:05:09] matt_flaschen, ah. Hm. So... I should probably check for tht new preference before the tour? [22:05:22] or are we assuming the user wouldn't have had the time to mark it off by then? [22:05:35] The "which preference to check to load the tour" is super confusing [22:05:50] mooeypoo, new one is rcenhancedfilters-disable BTW: https://gerrit.wikimedia.org/r/#/c/373384/ . [22:05:56] mooeypoo, are you deciding whether to load on server or client? [22:06:05] server [22:06:16] right now, I do this: [22:06:17] $welcomeTourName = $wgUseStructuredChangeFilters ? [22:06:17] 'RcFiltersIntro' : 'RcFiltersBeta'; [22:06:17] if ( $wgUseStructuredChangeFilters || $user->getOption( 'rcenhancedfilters' ) ) { [22:06:24] ... load tour ... [22:06:37] (there's another check for whether the user SEEn the tour yet) [22:06:44] It seems right, but ... I'm confused [22:06:46] mooeypoo, use $specialPage->isStructuredFilterUiEnabled() [22:07:29] mooeypoo, we'll make sure that's right in James_F's patch before merging. [22:07:39] matt_flaschen, it's in WikimediaMessages.hooks [22:07:41] we don't have that [22:07:44] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3582364 (10demon) [22:07:49] we don't have that method there [22:07:51] * James_F nods. [22:07:59] (It basically already is right, we just will update StructuredChangeFiltersOnWatchlist at some point) [22:08:10] mooeypoo, let me look at the patch. One sec. [22:08:24] I'm fixing it up slightly but I'm confused about what to check [22:08:25] mooeypoo, there is another patch to make that public, which I'll review next, BTW. [22:08:28] 10Collaboration-Team-Triage, 10Flow, 10CirrusSearch, 10Discovery, and 2 others: Flow fails to load content when running CirrusSearchLinksUpdate jobs - https://phabricator.wikimedia.org/T175080#3582380 (10demon) [22:08:28] 10Collaboration-Team-Triage, 10Flow, 10Wikimedia-log-errors: Invalid namespace given (-1) when undeleting? - https://phabricator.wikimedia.org/T175085#3582382 (10demon) [22:09:07] also, James_F / RoanKattouw can you help optimizing the svg? https://gerrit.wikimedia.org/r/#/c/375097/5/modules/images/rc-intro-tour-preferences.svg@1 [22:09:28] Sure, one sec. [22:10:03] mooeypoo: Should it be LTR/RTL flipped? [22:11:01] mooeypoo, okay, you can move the hook listener to ChangesListSpecialPageStructuredFilters (you can get output and skin from the page). [22:11:11] Oh, I see, it's just a cog icon. [22:11:15] James_F, yeah [22:11:17] blue [22:11:17] I think that should work. Otherwise, you could reimplement the logic. It's relatively simple, but getting more complicated. [22:12:23] matt_flaschen, I'm not sure if it's a good thing to have the patch split up between repos [22:12:29] especially when it's already set up? [22:12:43] mooeypoo: Done. [22:13:00] James_F, thanks!! [22:13:56] mooeypoo, I'm not saying to modify core. The only core modification needed is to make the method public, which I just merged: https://gerrit.wikimedia.org/r/#/c/375417/ [22:14:09] OH to call it [22:14:11] good point [22:14:30] ChangesListSpecialPageStructuredFilters isn't really intended for this, but whatever. [22:14:38] I think it's better than duplicating the logic. [22:14:58] eh oops I didn't notice you +2ed O.o [22:15:08] I ... double... +2'ed [22:15:20] matt_flaschen, I thik I killed it... [22:15:34] mooeypoo, also, you voted Verified+2. [22:15:44] I removed myself! it should've stopped... [22:15:47] crap [22:15:55] undo me! undo me! [22:16:11] I think I undid me [22:16:19] ... didn't I? [22:16:27] mooeypoo, yes. [22:16:30] * mooeypoo phews [22:16:32] sorry [22:16:37] No problem. [22:16:54] Hopefully it ignores human V+2. It is still running at any rate. [22:16:58] There was a Big Blue Button saying +2 and I just clicked it. [22:17:34] mooeypoo, bash? :) [22:17:43] omg which one of that :D :D [22:17:46] go for it [22:17:56] There was a Big Blue Button saying +2 and I just clicked it. [22:17:57] I was thinking I need a shirt going "Undo me! Undo me!" [22:18:03] haha [22:18:16] go for it [22:20:40] matt_flaschen, so, ChangesListSpecialPageStructuredFilters is a hook... I'm confused now, are you saying I should move the guided tour load to there? [22:21:28] That would also mean moving it from WikimediaMessasges to WikimediaEvents? [22:21:29] mooeypoo, yeah, register the listener in Hooks.php, then move anything that relies on whether it's enabled to there. [22:21:39] mooeypoo, how come? [22:21:48] It's already listening to a hook, just a different one: BeforePageDisplay [22:22:07] onChangesListSpecialPageStructuredFilters is in WikimediaEvents [22:22:14] I can re-listen to it in WikimediaMessages [22:22:19] mooeypoo, sorry, register listener in Hooks section of extension.json [22:22:28] I misspoke above. [22:22:32] but just saying... currently, we're listening to it in WikimediaEvents [22:22:39] Yeah, you can re-listen. [22:22:42] ok so we'll listen to it in both [22:22:43] * mooeypoo nods [22:22:50] It's just super confusing [22:23:39] mooeypoo, well, it's somewhat confusing to register all these tours in WikimediaMessages (which is primarily just for Wikimedia-specific message customizations). [22:23:42] mooeypoo, but I don't see how listening to ChangesListSpecialPageStructuredFilters from an additional place is confusing. [22:23:50] We listen to that everywhere we register structured filters. [22:24:30] It's like mw.hook or whatever, we can listen as many places as we want. [22:24:59] yeah [22:25:01] just checking [22:30:37] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3582458 (10TBolliger) >>! In T169268#3582197, @matmarex wrote: >> If the problem returns we should th... [22:31:11] It seems like a bug that we get a Big Blue Button offering to V+2: T175090 [22:31:13] T175090: Blue button to do Verified+2 - https://phabricator.wikimedia.org/T175090 [22:36:30] !bash There was a Big Blue Button saying +2 and I just clicked it. [22:36:30] matt_flaschen: Stored quip at https://tools.wmflabs.org/bash/quip/AV5UMBNawg13V6285iWQ [22:36:53] https://tools.wmflabs.org/bash/help has better documentation than many MediaWiki features. [22:37:06] :) [22:37:36] single author, small scope [22:38:23] bd808, sometimes single author, small scope are the worst docs of all (not necessarily for MW). [22:38:43] true. I have those projects on my resume too [22:48:24] matt_flaschen, stephanebisson does this make more sense? https://gerrit.wikimedia.org/r/#/c/375097/7/WikimediaMessages.hooks.php [22:51:37] Meh, the diff is unhelpful [22:54:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#3582574 (10Reedy) And still ``` 22:23:08 ............................PHP Fatal error: Call to a member function getId() on a non-object in /home/jenkins/workspace... [22:56:23] mooeypoo, you're not checking $special->isStructuredFilterUiEnabled() yet. [22:56:55] mooeypoo, I also find the name $wgUseStructuredChangeFilters confusing, since they could be using RCFilters either way, that just controls whether the preference exists. [22:57:28] But that's from a different patch. [22:58:42] mooeypoo, can you add a Depends-On to https://gerrit.wikimedia.org/r/#/c/373384/ ? [23:02:02] mooeypoo, also, you need to change how you get $title and $user [23:03:51] oh whoops I didn't notice that [23:06:13] matt_flaschen, hang on, I thought I don't **need** to check that; the hook should only be emitted if it's enabled!? or did I misunderstand [23:06:57] oh it's structured filters but not structured filters UI ? I'm confused. [23:07:44] mooeypoo, yeah, it's a bit confusing, but structured filters refers to them being defined via groups (e.g. Type of Change). Structured UI means it looks different. So the hook is fired either way. [23:08:06] ha [23:08:06] ok [23:08:22] mooeypoo, since extensions register it the same way regardless of which UI is being used (mostly :)) [23:08:52] Or rather, I think always, but a couple are only registered for the old UI (e.g. flagged revisions, old ORES). [23:08:58] matt_flaschen, I couldn't really check it on "onBeforePageDisplay" -- I left that one as-is [23:09:06] just rearranged the if statement for the "invite to beta" [23:09:12] That is, I'm checking it the dirty way [23:10:03] mooeypoo, I think it's fine, since it really only applies if Beta is still in place, right? [23:10:17] matt_flaschen, also, this is pretty insane. The hook is "ChangesListSpecialPageStructuredFilters" and it's fired whether the UI is there or not, but the wgUseStructuredChangeFilters is only true when the UI is available out of beta [23:10:20] SUPER confusing [23:10:43] matt_flaschen, yeah, if beta exists, is still in place, and the user has not activated it [23:12:02] mooeypoo, well, we can definitely rename isStructuredFilterUiEnabled (it only became public an hour or something ago), and I agree with you about $wgUseStructuredChangeFilters (I suggested names that I thought were more clear). [23:12:31] mooeypoo, ChangesListSpecialPageStructuredFilters seemed like a good idea at the time (there was already ChangesListSpecialPageFilters), and is probably too late to change, unless we *really* want to. [23:12:44] mooeypoo, $wgUseStructuredChangeFilters is not merged yet, and I will comment again about it. [23:13:16] mooeypoo, if you have an idea to rename isStructuredFilterUiEnabled let me know. [23:13:17] Actually, that's the only one that's not confusing since it's strictly says "UI" [23:13:59] I mean, that's the only one where I can say I know what it'll give me -- whether the UI is available or not [23:14:01] the others are super confusing [23:14:46] If we can make that method encompass all options to whether the UI is available (if beta && the user chose the beta || if public to all && user didn't opt out) that will be ideal [23:15:22] It would still require a bit of mucking around in that specific patch, because we have more nuanced cases for the tour like whether the user JUST joined,or whether they have or haven't seen the beta,etc [23:15:35] matt_flaschen, but it will definitely make it clearer [23:16:00] mooeypoo, that is what isStructuredFilterUiEnabled is. If not, it's a bug (or it's James's in-progress patch). [23:16:08] Whether the user sees the new UI, period. [23:16:58] right [23:17:01] that is helpful and it makes sense [23:17:09] the other wg vars and hooks are confusing as hell [23:17:10] mooeypoo, I should make this more clear for ChangesListSpecialPageStructuredFilters. The normal use case is different, but it's still important that people know it applies to both UIs (e.g. they need to register i18n for both). [23:17:22] Right [23:18:00] matt_flaschen, I fixed up the patch, i think it makes more sense [23:18:07] meh jenkins fails on lock file [23:18:10] the hell [23:18:18] Should I run composer update ?! [23:19:38] Maybe rebase will solve it [23:19:52] mooeypoo, this might be oojs-ui's break-every-week thing? [23:20:01] oojs/oojs-ui: 0.23.0 installed, 0.22.5 required [23:20:22] :\ [23:20:33] * mooeypoo pokes James_F [23:20:36] yeah. just try again [23:20:44] it should be fixed now [23:20:58] but apparently it took us 50 minutes to merge the two patches that should be merged at the same time [23:21:23] ha [23:21:41] because apparently test for the Thanks extension are broken and causing random things to fail? weird stuff [23:22:06] (https://gerrit.wikimedia.org/r/#/c/376147/) [23:22:10] MatmaRex, which is weird, because I don't remember anyone changing thanks lately. [23:22:36] https://phabricator.wikimedia.org/T151878 [23:22:46] Thanks, Thanks. [23:32:39] mooeypoo, also $wgUseStructuredChangeFilters could be true, but RCFilters could be default-off. We're unlikely to configure WMF like that, but in the interest of things actually being correct and making sense, I'll update James_F's patch to add a method to tell you whether RCFilters are enabled by default. [23:32:56] James_F, do you have a second to argue about $wg names? [23:39:54] 10Collaboration-Team-Triage, 10Notifications, 10Refreshed, 10Patch-For-Review: Echo badges don’t appear on mobile on MediaWiki 1.29+ - https://phabricator.wikimedia.org/T170773#3582731 (10MacFan4000) @SamanthaNguyen Could you please look at my patch? [23:44:23] mooeypoo, is https://gerrit.wikimedia.org/r/376155 (docs) more clear? [23:45:22] matt_flaschen, yeah I think so [23:46:53] mooeypoo, thanks, can you +2 when ready? [23:48:12] Yup I'm waiting for the Big Blue Button to show up [23:48:13] :P [23:50:45] matt_flaschen, +2'ed correctly this time. [23:50:50] :) [23:51:09] mooeypoo, I don't think you have to wait, though, at least for a doc fix. It won't merge it failing gate tests. [23:51:43] mooeypoo, what do you think of getting rid of $wgUseStructuredChangeFilters entirely, and just having a method isStructuredFilterUiEnabledByDefault()? [23:51:55] In addition to isStructuredFilterUi() [23:52:26] matt_flaschen, that's fine, but do we need it anywhere else? [23:52:40] Usually we'd need "Does the user get the UI" regardless of whether it's from beta or default or whatever [23:52:52] the distinction seems to only matter for tours or stuff, no? [23:53:12] Then again == it **is** clearer [23:53:24] mooeypoo, there is James_F's patch itself and some details there, but I will figure out how to reconcile that. Wanted to check before re-reviewing that patch. I don't know of any other patch using it. [23:53:33] But that means we can change the wg name to it, too [23:53:55] mooeypoo, $wgIsStructuredChangeFiltersEnabledByDefault ? [23:54:02] I think the name of the wg var is the confusing bit; if it's meant as "we enabled RCFilters by default on this wiki" then rename that variable [23:54:07] I don't like that because core already has a defined way to enable preferences by default. [23:54:08] Yeah that's fine [23:54:20] RoanKattouw might not like long vars, but seriously, it's confusing enough to warrant it [23:54:29] also we already have a bunch that are long anyways [23:54:35] The $wg just controls whether the preference shows up. To enable preferences by default, we use wgDefaultUserOptions [23:54:49] And we can also hide preferences, so I think it's all covered, and that is the clearest solution. [23:55:11] As of now, if you wanted to show the preference, but have it default-checked (which is completely valid in theory), you would have to do: [23:55:21] $wgUseStructuredChangeFilters = true; [23:55:28] MatmaRex: matt_flaschen: That Thanks breakage is a pretty old issue, it's intermittent [23:55:30] Rarely happens [23:55:33] Yeah as long as we know what to check/call and that it's clear [23:55:37] Yeah, I saw [23:56:01] Then $wgDefaultUserOptions['rcenhancedfilters-disable'] = 1; [23:56:07] mooeypoo, so I think it's clearer just not to have the $wg. [23:56:22] yeah. it's just bad timing that it happened on this patch, and that no one immediately noticed that it failed to merge