[00:04:37] stephanebisson, we're graduating from beta incrementally, right? [00:04:54] I think so [00:04:56] I have to duplicate the "welcome" tour 'cause I can't just change it [00:05:04] so we'll have to find a trick to load the correct one [00:05:31] I'm creating another tour for the graduation, but it will be 99% the same as the old tour, except slightly different language + another step [00:05:55] I will use the same cookie so we know *not* to load it if the other was seen, but I'll have to figure out how to load it **instead** of the other one in hooks [00:06:06] I assume we'll have a config variable for graduating out of beta [00:06:17] well, if there's different language and another step, I doubt it can be 99% the same, it's mostly just language [00:06:21] Or lose the config we have no for beta [00:06:30] well, it's the same styling and mostly the same language [00:06:47] but yeah, the point is that we'll have to load the new one instead of the old, and I'm not sure what condition to use [00:07:23] there's a variable for rcfilters ON by default, see https://gerrit.wikimedia.org/r/#/c/373384/ [00:07:36] oh! there. Thanks [00:08:06] James_F has to rework that patch (ping!) [00:08:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3572040 [00:10:12] I'll use the var anyways; if it's not there, it'll not be truthy anyways [00:10:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3572044 (10Mooeypoo) a:03Mooeypoo [00:25:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3572062 [00:36:57] matt_flaschen, I'm writing the guided tour, and I am looking for a method to call the next step from a custom button [00:36:59] https://www.mediawiki.org/wiki/Extension:GuidedTour/Write_an_extension_tour [00:37:09] ^ this has an example but it's pretty convoluted [00:37:16] is it mw.libs.guiders.next(); ? [00:37:47] mooeypoo, yeah, how custom is it? Just the label, or also other behavior? [00:38:05] behavior -- it needs to be the "next" button but look like it's a "OK, thanks" button [00:38:18] this tour isn't QUITE in steps. It's a 2-step tour pretending to be two separate tours, I guess [00:38:48] matt_flaschen, https://phabricator.wikimedia.org/T169613 [00:39:05] see, first window is just like we had so far (1-step tour) but then a tiny little message should also show on the preferences [00:39:20] But it's not really a "next / back" sort of tour [00:40:25] mooeypoo, so it's a next button, no icon, but label is 'Ok, got it'. [00:41:15] matt_flaschen, https://gerrit.wikimedia.org/r/#/c/375097/1/modules/rcfilters-intro-tour.js [00:41:21] Yeah [00:41:26] mooeypoo, you can use { action: 'next', name: mw.msg( 'some-message' ) } [00:41:36] gotcha [00:41:55] name or namemsg [00:42:14] mooeypoo, namemsg will actually work, it's just not documented, let me fix that. [00:42:25] it's been namemsg in the other tour, hence asking [00:42:37] mooeypoo, yeah, I thought it might be missing from this path, but it's not. [00:42:45] * mooeypoo nods [00:42:50] Just docs are slightly wrong [00:43:02] I am trying to test if it's even loading for me, just shared to give context to my question [00:43:06] I think this should work, then [00:43:12] mooeypoo, it's designed so normally you can just use the actions, but at some point we added label overrides, and it automatically doesn't show the icon if you have a custom label. [00:43:32] oh, good, so it's better than using name, sounds like [00:44:06] mooeypoo, well, the custom label and dropping icon will work either way, but namemsg is better just because it's simpler. [00:44:15] * mooeypoo nods [00:45:26] mooeypoo, can you merge https://gerrit.wikimedia.org/r/375098 after you confirm it works? [00:45:40] Just the namemsg thing [00:48:04] mooeypoo, if it won't load, let me know and I'll take a look. [00:49:29] You can use ?tour=name if you just want to test the tour itself before getting the server part going. [00:54:37] matt_flaschen, the second step doesn't get attached to the preferences... it just appears as a big box... even though I have { attachTo: '#pt-preferences a' } [00:54:38] O.o [00:55:46] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3572120 (10jmatazzoni) [00:55:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3572119 [00:56:07] Testing [00:56:21] I just pushed another patchset btw [00:56:21] test that one [00:56:51] like 2 minutes ago, cleaned up text stuff mostly [00:56:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Integrate Watchlist-management links and ... - https://phabricator.wikimedia.org/T172030#3572123 [00:58:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Integrate Watchlist-management links and ... - https://phabricator.wikimedia.org/T172030#3572125 [00:58:54] matt_flaschen, also, I'm "cancelling" the tour (setting the cookie to never show again) after the first screen, not the second. I think that's reasonable. [01:00:20] mooeypoo, if you use isSinglePage, there is no cookie. [01:00:31] mooeypoo, or do you mean the user preference? [01:00:45] matt_flaschen, also, I can't manage to get rid of the "check" button. Bah. [01:00:49] matt_flaschen, no, sorry, the user pref [01:00:51] sorry yeah [01:01:12] gah, why is it not attaching itself... [01:01:18] mooeypoo, I think because there's no position. [01:01:27] What do you mean? [01:01:37] mooeypoo, you need to say where to attach (bottom in this case, I think) [01:01:43] I.E. left right, bottom top, topRight. [01:01:48] wait, isn't it just "#pt-preferences a" [01:02:02] mooeypoo, that's what you attach to, you need to also say where relative to that element. [01:02:07] oh position: 'bottom' [01:02:12] meh that should really have a default value [01:02:44] mooeypoo, it depends where the element is. It could be auto-calculated somehow, though. [01:03:27] okay, it's attaching now [01:03:38] now to get rid of the "check" button and see why it's so big [01:04:09] matt_flaschen, there doesn't seem to be a way to get rid of the header of a step, too [01:04:30] If you give it none, it should really just be nothing, not "fall back" on "Simple title goes here" [01:04:53] mooeypoo, yeah, I'll fix that. [01:05:07] I'll hide it for now [01:05:11] mooeypoo, the check button is allowAutomaticOkay. Though I think there should be either an x or a button to close. [01:05:27] I thought that was to allow dismissing by clicking out [01:05:33] mooeypoo, these are non-standard, which I'm meh about, but we should at least allow the user to close the guider, which the mockup doesn't. [01:05:40] oh automaticOkay as in automatically show an Ok button [01:05:45] I thought automatically okay the step [01:05:49] I misread the docs [01:05:51] mooeypoo, no, that's closeOnClickOutside [01:05:57] yeah I mixed them up [01:06:03] not sure how, really... but yeah [01:06:11] Not everyone knows they can click outside. [01:06:41] Yeah that's why we usually have an "x" on things [01:07:10] mooeypoo, there's not even a way to customize that in GuidedTour I believe, it's being done in LESS, which I'm very eh about. [01:07:15] Hiding the X. [01:07:28] mooeypoo, I'll comment about that. [01:07:47] Yeah [01:07:54] I made the LESS file only customize the **first** step [01:07:59] removing all customizatin from the second [01:08:04] (except for hiding the h1 for now) [01:11:15] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3572151 (10Mattflaschen-WMF) In general, I think we should be cautious about using... [01:12:57] matt_flaschen, okay, this works, except for the gear icon which I don't have (will write in the ticket) [01:14:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3572154 (10Mooeypoo) @Pginer-WMF Do you have a copy of the gear icon in the proper... [01:21:13] mooeypoo, changed above GuidedTour commit to grab bag of small fixes, including removing the default title: https://gerrit.wikimedia.org/r/375098 [01:30:36] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes: Blank spaces in the 'Other review tools' box (MediaWiki:Recentchangestext box) - https://phabricator.wikimedia.org/T173079#3518016 (10Mattflaschen-WMF) >>! In T173079#3569883... [01:35:17] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-General-or-Unknown, 10Wikimedia-log-errors: unable to undelete a page in the MediaWiki namespace in din.wikipedia.org (due to system user ID being 0 or negative?) - https://phabricator.wikimedia.org/T171842#3572178 (10Mattflaschen-WMF) [01:35:19] 10Collaboration-Team-Triage, 10Flow, 10Hindi-Sites, 10Wikimedia-log-errors: Internal Error occurred during restore the page on hiwikiversity - https://phabricator.wikimedia.org/T174645#3572180 (10Mattflaschen-WMF) [01:37:24] matt_flaschen, you want to throw an error, or define a default for 'position' ? It's already flipping for RTL anyways [01:37:46] Seems "bottom" makes sense for *most* actions, and if someone wants to override, they will? [01:38:13] It's not a blocker for -1'ing if you think throwing an error is better. [01:38:42] mooeypoo, what happens if you put bottom for something on the sidebar? [01:39:10] mooeypoo, also "If it would go off the bottom of the screen do nothing, since most pages scroll in the vertical direction" [01:39:12] That is kind of lame. [01:39:53] Comment from mediawiki.libs.guiders.js [01:40:05] matt_flaschen, honestly, at some point, we might want to use OO.ui.mixin.ClippableElement to resolve all these [01:40:33] PopupWidget has a new "flip me automatically if I reach the edge" behavior, or it should soon with RoanKattouw's patch [01:40:46] anyways, yeah, maybe throw an error now, deal with a proper default/behavior later [01:41:31] Okay. [01:41:33] I do think it's good to customize it anyway, but if the default actually works (it fully shows the guider and what it's next to), it would be good (later) [01:41:41] matt_flaschen, also, I think that if you say nothing and it's in the sidebar and appears under, you can realize you need to change to "right" (or whatever) fairly easily [01:41:47] but it's really not that important [01:41:48] either way [01:42:00] mooeypoo, well, not if you don't know it's customizable (which you might not because you left it out before) [01:42:10] hm, good point [01:42:14] ok, fair enough [01:42:26] merged [01:43:09] ok I'm off for the evening. Thanks for the help matt_flaschen [01:43:12] see you tomorrow! [01:43:31] mooeypoo, have a good night. [01:43:38] You too [04:48:57] (03PS1) 10Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/375181 [04:50:34] (03PS1) 10Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/375197 [04:55:14] (03PS1) 10Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/375256 [04:58:04] (03PS1) 10Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/375298 [04:59:48] (03PS1) 10Libraryupgrader: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/375319 [05:31:43] (03PS2) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [05:54:13] (03CR) 10Niharika29: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/375181 (owner: 10Libraryupgrader) [05:59:38] (03CR) 10Niharika29: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/375197 (owner: 10Libraryupgrader) [06:20:45] (03CR) 10MaxSem: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/375256 (owner: 10Libraryupgrader) [06:22:01] (03CR) 10Niharika29: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/375319 (owner: 10Libraryupgrader) [06:26:28] (03CR) 10Niharika29: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/375298 (owner: 10Libraryupgrader) [06:32:18] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/375181 (owner: 10Libraryupgrader) [06:53:27] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/375197 (owner: 10Libraryupgrader) [08:16:44] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/375256 (owner: 10Libraryupgrader) [08:23:08] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/375319 (owner: 10Libraryupgrader) [08:44:30] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/375298 (owner: 10Libraryupgrader) [08:49:10] 10Collaboration-Team-Triage, 10Flow, 10Notifications: Interwiki flow bundles do not update wiki names on the fly - https://phabricator.wikimedia.org/T174773#3572614 (10IKhitron) [12:14:30] (03CR) 10jerkins-bot: [V: 04-1] Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) (owner: 10Dbarratt) [12:17:35] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Integrate Watchlist-management links and ... - https://phabricator.wikimedia.org/T172030#3572941 [12:19:31] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/375197 (owner: 10Libraryupgrader) [12:20:01] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/375181 (owner: 10Libraryupgrader) [12:44:47] Hello guys, we need a feature on the Flow extension wherein we have a Special page to display topics and their replies from all the pages on the wiki. I have gone through the documentation of the extension but it doesn't seem like a simple job. Would be great if someone from the core team could shed some light. [13:23:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3573073 [14:06:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10Patch-For-Review: Flow isAllowed gets actual revision text before it is needed - https://phabricator.wikimedia.org/T172025#3573173 (10ArielGlenn) I've done some testing and still not sure my testing is correct. Code is slightly modified fr... [14:07:38] (03CR) 10ArielGlenn: "Did some testing, see comments on ticket." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/370154 (https://phabricator.wikimedia.org/T172025) (owner: 10Mattflaschen) [14:29:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3573266 [14:31:54] (03PS3) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [14:39:34] (03CR) 10jerkins-bot: [V: 04-1] Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) (owner: 10Dbarratt) [14:45:46] (03PS4) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [14:48:25] stephanebisson: concerning green dots and watchlists, I'm not sure of the options we have. Do we have a way to have the two gadgets enabled with no impact on the Beta? [14:48:44] (Related task: T171235) [14:48:44] T171235: Standardize system for indicating unseen/seen changes on Watchlist - https://phabricator.wikimedia.org/T171235 [14:50:53] Trizek: to have them work on standard watchlist but completely no-effect with the beta? [14:51:02] Yes. [14:51:24] possibly, with added complexity, but that would contradict the statement that users can still customize what they don't like [14:53:44] I imagine you change classes on elements. If they have to code a CSS hack to have it working, we still allow customization. [14:53:58] they = users [14:54:35] The goal is not to absolutly block customization. The goal is to avoir the bold+greendot gadget to work by default. [14:56:01] Is it possible? [14:56:26] we can change the classes on the lines and let customizers start from scratch but we would break possibly app gadgets [14:56:34] all gadgets [14:56:51] Also, that would do nothing for the message at the top [15:00:50] (03CR) 10jerkins-bot: [V: 04-1] Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) (owner: 10Dbarratt) [15:04:11] The best way to make it not work by default is to change it in gadget-definition to not be default [15:04:15] So the only way is to convince the English community to change the activation of those gadgets from 'by default' to 'opt-in'. [15:04:18] (03PS5) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [15:05:06] That seems to be the proper way [15:06:10] we could also hack the preferences to turn them off for people using the beta feature but I don't know where we would do that [15:08:25] Some people would complain we go against the community decision. [15:08:42] Ok, I'll update the task. [15:10:08] (03PS6) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [15:11:23] Could we convince the maintainers of the green dot gadget to make it explicitly not work when the rcfilters in ON? [15:12:02] that would be pretty easy from within the gadget and it wouldn't mess with the text above [15:19:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3573360 [15:23:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Tracking: Expose filter combinations for the main review activities - https://phabricator.wikimedia.org/T174800#3573379 (10Pginer-WMF) [15:26:03] (03PS7) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [15:30:09] So it is possible to make the gadget not working on the Beta? [15:32:51] I'll ask the gadgets maintainers. [16:02:11] (03PS8) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [16:15:58] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-Newsletter: "View newsletter" should be changed to "Manage your newsletter options" in Email Notifications - https://phabricator.wikimedia.org/T174805#3573530 (10Trizek-WMF) [16:26:39] (03PS9) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [17:04:45] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment (AHT Sprint 4), 10Patch-For-Review, 10Security: Echo Notification Mute (Block List) can be bypassed by changing username - https://phabricator.wikimedia.org/T173475#3573633 (10dbarratt) [17:06:20] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment (AHT Sprint 4), 10Patch-For-Review, 10Security: Echo Notification Mute (Block List) can be bypassed by changing username - https://phabricator.wikimedia.org/T173475#3529575 (10dbarratt) 05Open>03stalled Need to wait for {T138166} to use... [17:10:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Turn off 'classic' ORES highlighting on the Watchlist (with beta) - https://phabricator.wikimedia.org/T174725#3573689 (10SBisson) a:03SBisson [17:14:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3573698 (10Mooeypoo) >>! In T169613#3536768, @Pginer-WMF wrote: >>>! In T169613#353... [17:26:40] matt_flaschen, stephanebisson: Can you take over https://gerrit.wikimedia.org/r/#/c/373384/ ? I'm a bit busy right now, as you might imagine. [17:32:55] James_F: I understand, I'll take it [17:41:55] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3573763 [17:46:14] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3573782 (10jmatazzoni) [17:53:16] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3573797 (10Mattflaschen-WMF) [18:02:02] stephanebisson: Thank you [18:02:42] James_F: I've delegated to Moriel. You're welcome. [18:03:00] :-) [18:03:24] plus I'll stay on as a reviewer so that's actually better [18:17:23] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3573873 (10jmatazzoni) [18:24:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Integrate Watchlist-management links and ... - https://phabricator.wikimedia.org/T172030#3573885 [18:36:11] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [wmf.16-regression] Saved query names displayed shifted up - https://phabricator.wikimedia.org/T174111#3551233 (10Etonkovidova) [19:05:00] Trizek: so the problem with the wl gadget is that the person who had the full understanding of them is no longer active.. [19:05:24] Trizek: and since they are default enabled... they are a bit scary to start messing with them. [19:13:32] Trizek: is there some higher level CSS class on the body or content or something that clearly indicates this beta ? [19:14:42] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: Make 'Other review tools' (MediaWik... - https://phabricator.wikimedia.org/T174617#3574025 [19:17:23] cause the only real way to do this that I can sort of get behind is by prefixing ever single rule in all those gadgets with body:not(.beta) or something, otherwise it's gonna be a mess. [19:29:09] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Accessibility: Show last 250 changes and period selection dropdowns are not keyboard accessible - https://phabricator.wikimedia.org/T174819#3574051 (10TheDJ) [19:29:11] thedj: In existing MW changes are in a
with class "mw-changeslist"; with the RCFilters, said div also has "mw-rcfilters-ui-changesListWrapperWidget" (as well as mw-changeslist). Does that help? [19:33:30] yes.. though i do just realize, that other people have built other modifications on top of this again, so we will probably break their specificity... [19:36:36] or.. we could delete the stylerules from the dom.. with JS, but that would be rather complex i think... [19:38:31] document.styleSheets[0].rules[0].selectorText.. Hmm, maybe that's feasible after all... we'd just have to check for rules with the same selector... [19:46:34] (03PS10) 10Dbarratt: Use User Ids instead of User Names for Echo Mute [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374871 (https://phabricator.wikimedia.org/T173475) [20:10:27] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3574159 (10SBisson) [20:18:11] James_F: something scary like this: https://en.wikipedia.org/wiki/User:TheDJ/deleteWatchlistModifications.js [21:01:18] thedj: That looks potentially fragile. But maybe? [21:08:52] (03PS3) 10Etonkovidova: Notificaiton about editing Flow board description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/374662 [21:08:54] (03PS1) 10Etonkovidova: Notification about editing Flow topic summary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/375441 [21:14:52] 10Collaboration-Team-Triage, 10Notifications: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click - https://phabricator.wikimedia.org/T173970#3574303 (10Prod) I don't have CentralAuth on my wiki, so I'm not sure this is related. [21:36:00] 10Collaboration-Team-Triage, 10Notifications: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click - https://phabricator.wikimedia.org/T173970#3574342 (10Mattflaschen-WMF) So this is not a Wikimedia wiki? In general, please specify that in bug reports (if you're usin... [21:37:56] mooeypoo, you might be able to comment on T173970? Is the off-screen text for accessibility? [21:37:56] T173970: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click - https://phabricator.wikimedia.org/T173970 [21:40:06] 10Collaboration-Team-Triage, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 10Google-Summer-of-Code (2017): Implement Thanks support in Pywikibot - https://phabricator.wikimedia.org/T161426#3574344 (10happy5214) Copy-pasted from [[ https://happy5214.wordpress.com/2017/09/01/summer-is-gone-wrapping-up-gs... [21:47:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Standardize system for indicating unseen/... - https://phabricator.wikimedia.org/T171235#3574398 [21:57:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10Patch-For-Review: Flow isAllowed gets actual revision text before it is needed - https://phabricator.wikimedia.org/T172025#3574428 (10Mattflaschen-WMF) >>! In T172025#3573173, @ArielGlenn wrote: > I've done some testing and still not sure m... [22:01:26] 10Collaboration-Team-Triage, 10Flow: internal "external" links in flow topics and board descriptions are recorded in database - https://phabricator.wikimedia.org/T174688#3570270 (10Etonkovidova) The issue confirmed in betalabs. [22:04:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes, 10MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), 10Patch-For-Review: Make 'Other review tools' (MediaWik... - https://phabricator.wikimedia.org/T174617#3574434 [22:06:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Integrate Watchlist-management links and ... - https://phabricator.wikimedia.org/T172030#3574440 [22:11:04] 10Collaboration-Team-Triage, 10Notifications: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click - https://phabricator.wikimedia.org/T173970#3546438 (10Mooeypoo) This sounds a little weird; the nojs CSS should override the number from the beginning, regardless of JS... [22:18:45] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Documentation: Update RC and Watchlist Preferences Help to reflect consolidation of preferences - https://phabricator.wikimedia.org/T163279#3574469 (10jmatazzoni) [22:27:19] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3574481 (10Jdforrester-WMF) [23:19:39] 10Collaboration-Team-Triage, 10Notifications: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click - https://phabricator.wikimedia.org/T173970#3574549 (10Prod) The default vector CSS moves the text off the screen, so it's not seen on wikimedia wikis, although the prob... [23:52:08] 10Collaboration-Team-Triage, 10Notifications: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click - https://phabricator.wikimedia.org/T173970#3574557 (10Mooeypoo) (from an IRC conversation) - Alright so I think there are 2 issues here 1. The text of the going u...