[01:16:04] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review, 10Regression: [Regression] Pagination doesn't work (there's no automatic load of previous threads on sc... - https://phabricator.wikimedia.org/T173807#3551613 [01:20:07] (03CR) 10Mattflaschen: "Change to offset is documented at https://jquery.com/upgrade-guide/3.0/#offset ." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373566 (https://phabricator.wikimedia.org/T173807) (owner: 10Sbisson) [02:33:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3551660 [02:57:19] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3551667 (10Legoktm) >>! In T169268#3550124, @Urbanecm wrote: > It will be reverted at some day, even if the community didn... [05:04:19] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled - https://phabricator.wikimedia.org/T173838#3551748 (10dbarratt) [x] Put us on the [[ https://wikitech.wikimedia.org/w/index.php?title=De... [05:05:00] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Wikimedia-Extension-setup, and 4 others: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled - https://phabricator.wikimedia.org/T173838#3551749 (10dbarratt) [05:05:58] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Wikimedia-Extension-setup, and 4 others: Enable EchoPerUserBlacklist on all Wikimedia wikis with Echo enabled - https://phabricator.wikimedia.org/T173838#3541476 (10dbarratt) a:05Urbanecm>03dbarratt [07:23:47] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Epic, and 2 others: Consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T172350#3551866 (10Trizek-WMF) >>! In T172350#3550780, @Johan wrote: > @Trizek-WMF Wa... [07:25:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/373772 (owner: 10L10n-bot) [07:27:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373777 (owner: 10L10n-bot) [07:28:12] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Epic, and 2 others: Consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T172350#3551870 (10Trizek-WMF) >>! In T172350#3550780, @Johan wrote: > @Trizek-WMF Wa... [08:19:11] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Performance, and 2 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 artic... - https://phabricator.wikimedia.org/T171027#3551936 [08:52:11] 10Collaboration-Team-Triage, 10Flow: Rename Flow - https://phabricator.wikimedia.org/T174137#3551973 (10Trizek-WMF) [08:52:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3349982 (10Trizek-WMF) [09:05:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes: Blank spaces in the 'Other review tools' box (MediaWiki:Recentchangestext box) - https://phabricator.wikimedia.org/T173079#3518016 (10Trizek-WMF) The gap is less important on... [09:11:07] 10MediaWiki-Watchlist, 10Wikidata: Wikidata wbremoveclaims/wbcreateclaims errors in Wikipedia watchlists - https://phabricator.wikimedia.org/T170573#3552047 (10matej_suchanek) [09:11:27] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Support namespace aliases - https://phabricator.wikimedia.org/T174020#3552051 (10Trizek-WMF) https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces - (Main) 0 - User 2 - Project 4 - File 6 - MediaWiki 8 - Temp... [09:21:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review, 10Regression: [Regression] Pagination doesn't work (there's no automatic load of previous threads on sc... - https://phabricator.wikimedia.org/T173807#3552073 [09:28:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes: Blank spaces in the 'Other review tools' box (MediaWiki:Recentchangestext box) - https://phabricator.wikimedia.org/T173079#3552077 (10Pginer-WMF) >>! In T173079#3552024, @Tri... [09:45:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review, and 2 others: [Regression] Pagination doesn't work (there's no automatic load of previous threads on scro... - https://phabricator.wikimedia.org/T173807#3552110 [09:48:20] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Watchlist ... - https://phabricator.wikimedia.org/T171030#3552117 [09:54:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice: Announce and follow up with communities about the New Filte... - https://phabricator.wikimedia.org/T171030#3552122 [10:13:35] 10Collaboration-Team-Triage, 10Flow, 10Accessibility, 10Easy: {CTRL} + {ENTER} should post a post in flow - https://phabricator.wikimedia.org/T158779#3552223 (10Trizek-WMF) [10:13:37] 10Collaboration-Team-Triage, 10Flow, 10Tracking: Flow's keyboard-shortcuts / access-keys / hotkeys (tracking) - https://phabricator.wikimedia.org/T108739#3552222 (10Trizek-WMF) [10:14:13] 10Collaboration-Team-Triage, 10Flow, 10Accessibility, 10Easy: {CTRL} + {ENTER} should post a post in flow - https://phabricator.wikimedia.org/T158779#3047032 (10Trizek-WMF) >>! In T158779#3142476, @MtDu wrote: > I'll try to fix this. If urgent, feel free to do it. Any updates? I have [[ https://fr.wikiped... [10:19:07] 10Collaboration-Team-Triage, 10Flow: Warn people who left ~~~~ on a Flow message - https://phabricator.wikimedia.org/T112239#3552234 (10Trizek-WMF) [10:20:02] 10Collaboration-Team-Triage, 10Flow, 10Tracking: Improve Flow input tools (toolbars, shortcuts...) - https://phabricator.wikimedia.org/T174144#3552238 (10Trizek-WMF) [10:23:37] 10Collaboration-Team-Triage, 10Flow, 10Accessibility, 10Easy: {CTRL} + {ENTER} should post a post in flow - https://phabricator.wikimedia.org/T158779#3552259 (10Trizek-WMF) [10:23:42] 10Collaboration-Team-Triage, 10Flow: Flow editing toolbar should be at the top of the edit window - https://phabricator.wikimedia.org/T128088#3552260 (10Trizek-WMF) [10:23:44] 10Collaboration-Team-Triage, 10Flow: Allow middle+click and CTRL+click on "Edit description" - https://phabricator.wikimedia.org/T119502#3552261 (10Trizek-WMF) [10:23:46] 10Collaboration-Team-Triage, 10Flow: Warn people who left ~~~~ on a Flow message - https://phabricator.wikimedia.org/T112239#3552262 (10Trizek-WMF) [10:23:48] 10Collaboration-Team-Triage, 10Flow, 10Regression: Unable to resize the edit area on Flow talk pages - https://phabricator.wikimedia.org/T101859#3552263 (10Trizek-WMF) [10:23:50] 10Collaboration-Team-Triage, 10Flow: Limit reply area max-height when using VE editor on Flow - https://phabricator.wikimedia.org/T100968#3552264 (10Trizek-WMF) [10:23:52] 10Collaboration-Team-Triage, 10Flow: Flow should provide an easy way to quote other user comments - https://phabricator.wikimedia.org/T94644#3552265 (10Trizek-WMF) [10:23:54] 10Collaboration-Team-Triage, 10Flow, 10Tracking: Improve Flow input tools (toolbars, shortcuts...) - https://phabricator.wikimedia.org/T174144#3552258 (10Trizek-WMF) [10:23:56] 10Collaboration-Team-Triage, 10Flow, 10Design: Wikitext editing toolbar for Flow - https://phabricator.wikimedia.org/T78346#3552267 (10Trizek-WMF) [10:24:00] 10Collaboration-Team-Triage, 10Flow, 10Community-Liaisons, 10User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#3552266 (10Trizek-WMF) [11:30:10] 10Collaboration-Team-Triage, 10Flow, 10Accessibility, 10Easy: {CTRL} + {ENTER} should post a post in flow - https://phabricator.wikimedia.org/T158779#3552461 (10MtDu) a:05MtDu>03None Yeah sorry, I don't think I have time to do this right now. School started, and I am applying to university. @Trizek-WMF [12:00:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, and 3 others: [Story] record wikibase recent change entries attributed as non-anon - https://phabricator.wikimedia.org/T51315#3552588 (10daniel) @aude can you h... [12:16:35] 10Collaboration-Team-Triage, 10Flow, 10Accessibility, 10Easy: {CTRL} + {ENTER} should post a post in flow - https://phabricator.wikimedia.org/T158779#3552599 (10Trizek-WMF) >>! In T158779#3552461, @MtDu wrote: > Yeah sorry, I don't think I have time to do this right now. School started, and I am applying t... [12:55:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Watchlist: watchlistactivity=seen does not display seen changes - https://phabricator.wikimedia.org/T174100#3552795 (10SBisson) [12:55:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), 10Patch-For-Review: Adapt 'Watchlisted pages' filter group (o... - https://phabricator.wikimedia.org/T171127#3552797 [13:43:02] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3552976 (10Reception123) [13:43:41] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3552990 (10Reception123) [13:59:14] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3552976 (10Trizek-WMF) On which wiki have you done that change? [14:01:36] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3553034 (10Reception123) @Trizek-WMF It's not a WMF wiki, but you can observe the change here: https://test1.miraheze.org/wiki/MediaWiki:Flow-terms-of-use-edit [14:06:37] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3553050 (10Reception123) Also note that standard wiki-markup such as ''' for bold also doesn't work, only wiki links ([[Page]]) work. [14:07:32] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3553051 (10Trizek-WMF) Ok, thanks! @Etonkovidova, can you have a look at it? I can't test on test wiki. [14:21:09] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3553074 (10Reception123) @Trizek-WMF I asked @AlvaroMolina since they are an administrator there, and they have edited the page on test.wikipedia.org, see https://... [14:22:36] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' does not work - https://phabricator.wikimedia.org/T174165#3553076 (10Trizek-WMF) Thanks! The result is `

By saving your changes, you agree to the [[terms of use]] for this wiki.

` {F9173709} [14:22:51] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' displays raw HTML - https://phabricator.wikimedia.org/T174165#3553077 (10Trizek-WMF) [14:28:11] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' displays raw HTML - https://phabricator.wikimedia.org/T174165#3553105 (10AlvaroMolina) @Trizek-WMF: I have given you the administrator permission in Test Wikipedia so that you can work more comfortably with the resolution... [14:35:05] 10Collaboration-Team-Triage, 10Flow: Editing Flow system message 'Flow-terms-of-use-edit' displays raw HTML - https://phabricator.wikimedia.org/T174165#3553121 (10Trizek-WMF) >>! In T174165#3553105, @AlvaroMolina wrote: > @Trizek-WMF: I have given you the administrator permission in Test Wikipedia so that you... [14:37:03] 10Collaboration-Team-Triage, 10Flow: When edited, Flow system message 'Flow-terms-of-use-edit' displays raw text. - https://phabricator.wikimedia.org/T174165#3553123 (10Trizek-WMF) [14:38:43] 10Collaboration-Team-Triage, 10Flow: When edited, Flow system message 'Flow-terms-of-use-edit' displays raw text. - https://phabricator.wikimedia.org/T174165#3552976 (10Trizek-WMF) [15:04:35] 10Collaboration-Team-Triage, 10Flow: Too much left padding in Flow - https://phabricator.wikimedia.org/T174169#3553200 (10Esanders) [15:05:53] (03PS1) 10Esanders: Fix left padding of root comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) [15:13:03] (03PS1) 10Esanders: build: Update eslint-config-wikimedia 0.4->0.5, eslint 19->20 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373907 [15:13:45] (03CR) 10jerkins-bot: [V: 04-1] Fix left padding of root comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) (owner: 10Esanders) [15:16:05] (03PS2) 10Esanders: build: Update eslint-config-wikimedia 0.4->0.5, eslint 19->20 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373907 [15:25:17] (03PS3) 10Esanders: build: Update eslint-config-wikimedia 0.4->0.5, eslint 19->20 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373907 [15:26:25] (03PS2) 10Esanders: Fix left padding of root comments [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373905 (https://phabricator.wikimedia.org/T174169) [15:34:28] (03CR) 10Jforrester: [C: 032] build: Update eslint-config-wikimedia 0.4->0.5, eslint 19->20 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373907 (owner: 10Esanders) [15:45:21] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia 0.4->0.5, eslint 19->20 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373907 (owner: 10Esanders) [15:53:33] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia 0.4->0.5, eslint 19->20 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373907 (owner: 10Esanders) [16:04:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3553362 (10jmatazzoni) @Etonkovidova, what is the behavior now? I looked on beta,... [16:22:39] 10MediaWiki-Watchlist: Contributions should indicate which are in watchlist - https://phabricator.wikimedia.org/T174176#3553423 (10Jidanni) [16:27:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3553446 (10Etonkovidova) @jmatazzoni RC page "Group by page" setting is basicall... [16:42:09] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Performance, and 2 others: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 artic... - https://phabricator.wikimedia.org/T171027#3553476 [17:16:24] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Saved query names displayed shifted up - https://phabricator.wikimedia.org/T174111#3553580 (10Mattflaschen-WMF) [17:24:39] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3553599 (10TBolliger) [17:30:06] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3553605 (10S... [17:36:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Scoring-platform-team: Reduce very long search times on RC Page when using ORES for rare combos - https://phabricator.wikimedia.org/T164796#3553635 (10SBisson) >>! In T164796#354741... [17:54:54] 10MediaWiki-Watchlist, 10MediaWiki-Special-pages: Special:Contributions should indicate which items are already on your watchlist - https://phabricator.wikimedia.org/T174176#3553703 (10Aklapper) [17:55:17] 10MediaWiki-Watchlist, 10MediaWiki-Special-pages: Special:Contributions should indicate which items are already on your watchlist - https://phabricator.wikimedia.org/T174176#3553707 (10Aklapper) {T42661} feels like the other way round... [17:56:24] 10Collaboration-Team-Triage, 10Thanks, 10MediaWiki-Special-pages, 10Patch-For-Review: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#3553709 (10Aklapper) @darthbhyrava: This issue has been assigned to you a while ago. Could you please share a stat... [17:57:51] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [minor] RC page - a filter's name that spans several lines needs vertical adjustment - https://phabricator.wikimedia.org/T171901#3553713 (10Etonkovidova) Checked in be... [17:58:14] stephanebisson, remind me how to force-load rcfilters on watchlist? [18:06:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3553754 (10E... [18:09:22] mooeypoo: ?rcfilters=1 [18:19:54] ... I tried that, why didn't that work [18:20:00] -- oh. I seem to have mispelled 'rcfilters' with 'rcfliters' [18:20:19] You'd think after writing it so much I'd be able to spell it by pure finger-muscle memory [18:28:24] stephanebisson, the "mark all pages as visited" button -- we should probably style it the way we do in Special:Notifications so it looks the same with/without JS and doesn't "jump" when loading [18:28:54] mooeypoo: or hide the old one while the new app is loading [18:29:23] stephanebisson, sure, but no-js experience will still have it, no? [18:29:30] yes [18:29:40] It's not urgent, just an idea since we do that in Notifications page [18:29:42] nojs version [18:29:49] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3553879 (10TBolliger) [18:30:28] 10Collaboration-Team-Triage, 10Anti-Harassment, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3392756 (10TBolliger) Yes, @Legoktm, this is a very interesting case study for the #anti-harassment... [18:34:59] stephanebisson, I run the script but all pages are "watched"... is there a trick to make at least one of them unwatched? :\ [18:35:03] err seen [18:35:54] could you rephrase your question? [18:35:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3553900 (10jmatazzoni) In T172580#3553446, @Etonkovidova wrote: >..."Group by page... [18:36:39] Sorry, I'm running the script to add notifications in vagrant to populate my watchlist. I watch Moai and Moai2, they're not currently open or anything -- I'm looking at Special:Watchlist?rcfilters=1 and I am running the notif script in the background, once with -t and once without [18:36:50] I get content, but all content is "seen" -- I have no content that is unseen [18:37:01] the "Mark all changes as seen" is greyed out [18:37:14] https://gerrit.wikimedia.org/r/#/c/373881/ [18:37:37] wait, I just ran it again and it sorted, but that only sorted without the -t piece [18:38:27] sorted? what are you sorting? [18:40:12] mooeypoo: the fix to seen/unseen is here: https://gerrit.wikimedia.org/r/#/c/373881/ I'm afraid you'll have to review it before you can make progress on your task ;) [18:41:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [minor] RC page - a filter's name that spans several lines needs vertical adjustment - https://phabricator.wikimedia.org/T171901#3553932 (10jmatazzoni) 05Open>03Res... [18:52:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: The names of new Saved Filters don't appear as expected in the Active Filter area - https://phabricator.wikimedia.org/T174193#3553963 (10jmatazzoni) [19:23:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Tweaks to the pushpin icon design and functionality - https://phabricator.wikimedia.org/T173264#3522476 (10Etonkovidova) @Pgine... [19:31:39] (03Abandoned) 10Seb35: Fix warnings and bugs in generateForwardedCookieForCli() [extensions/Flow] (REL1_28) - 10https://gerrit.wikimedia.org/r/355088 (https://phabricator.wikimedia.org/T149579) (owner: 10Seb35) [19:32:25] stephanebisson, seen/unseen works now for me.. I am going over the patch now anyways :P [19:33:13] mooeypoo: yes, it can work without considering the NULL cases [19:33:52] stephanebisson, you're also removing ShowUpdateMarker config and a 'rollback' check [19:34:00] is that intentional? I'm a little fresh with this codebase [19:34:36] Seems you're not just removing the $usePage usage, but also the other condition of whether a rollback is allowed [19:34:41] seems a bit unrelated? [19:36:07] mooeypoo: I'm always joining with page and adding a wl_ field to support filters and highlight [19:36:41] I'm not changing whether rollback is possible or not [19:36:45] page_latest was only added if rollback is allowed [19:36:50] now it is added indiscriminantly [19:36:56] yes [19:36:58] I'm not 100% sure i fthat does anything, but I want to verify [19:37:19] now it's needed for highlight [19:37:23] Gotcha [19:37:46] I was a little concerned with "isAllowed" going away, sounded like it was about permission stuff (like adding a field that only should be seen if you are allowed to rollback) [19:37:50] but seems like that's not the case [19:37:55] at the same time, you shouldn't take my works for it [19:38:13] we can ask Matt to take a look as well [19:38:19] *words [19:38:31] Yeah I wanted to save it from his plate [19:38:52] This is the only section that made me raise an eyebrow [19:39:13] you can also compare with specialrecentchanges.php, it's doing basically the same [19:40:03] Yeah also these are fields to show, not results to filter out, I see what this means now [19:40:18] There seem to not really have been much of a reason to "gate" this before, honestly, other than maybe not bother [19:41:20] I was also worried that adding those fields would result in enabling actions that are indirectly controlled by those permission checks... but I did not find it to be the case [19:41:41] you can grep for those fields to see if they control anything [19:41:45] * mooeypoo nods [19:42:39] Category.php seems to include it in selections regardless of permissions [19:43:44] Yeah it doesn't seem like they need to be hidden from non-authorized users [19:43:53] Just verifying that part, otherwise looks good [19:46:51] stephanebisson, ok, I'm convinced that it's fine; I checked the fields just in case and tested twice - with and without rcfilters on. +2'ed. [19:47:25] thanks [19:47:26] (fingers crossed) [19:55:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Reduce vertical whitespace in the RC page with the New Filters - https://phabricator.wikimedia.org/T173265#3522543 (10Etonkovido... [19:56:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Reduce vertical whitespace in the RC page with the New Filters - https://phabricator.wikimedia.org/T173265#3554133 (10jmatazzoni... [20:31:25] (03PS1) 10MaxSem: Title::getSquidURLs() is deprecated [extensions/Flow] - 10https://gerrit.wikimedia.org/r/373964 [20:50:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3455031 (10Etonkovidova) Checked in betalabs (... [20:54:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3554372 (10j... [21:32:04] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'Oldest first' option to the 'Number of changes selector' - https://phabricator.wikimedia.org/T172240#3554490 (10jmatazzoni) [21:34:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3554502 (10j... [21:41:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3554573 (10j... [22:08:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [wmf.15] RC - Saved filter name will not be displayed in 'Active filters' area unless RC page is reload - https://phabricator.wikimedia.org/T174217#3554647 (10Etonkovidova) [22:11:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Reduce vertical whitespace in the RC page with the New Filters - https://phabricator.wikimedia.org/T173265#3554664 (10Deskana)... [22:19:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Regression: [regression - wmf.12] RC page - Fatal exception of type "Wikimedia\Rdbms\DBQueryError" - https://phabricator.wikimedia.org/T172816#3510442 (10Mattflaschen-WMF) This is similar to both {T164796} and {T... [22:19:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Integrate standard Watchlist management links and info into the new UX - https://phabricator.wikimedia.org/T172030#3554687 (10jmatazzoni) [22:20:37] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3554691 (10jmatazzoni) [22:21:30] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3226569 (10jmatazzoni) [22:40:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Integrate Watchlist-management links and page info into the new UX - https://phabricator.wikimedia.org/T172030#3554726 (10jmatazzoni) [22:42:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), 10Patch-For-Review: Separate the user's 'Saved filters' on ... - https://phabricator.wikimedia.org/T171218#3457879 [22:52:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3554762 (10jmatazzoni) ! In T171132#3554355, @... [23:00:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3554793 (10jmatazzoni) In T171132#3554355, @Et... [23:18:14] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3554818 (10jmatazzoni) In T171132#3554355, @Et... [23:33:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Adapt 'Watchlisted pages' filter group (o... - https://phabricator.wikimedia.org/T171127#3554884 [23:34:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), 10Patch-For-Review: Adapt 'Watchlisted pages' filter group (o... - https://phabricator.wikimedia.org/T171127#3454884 [23:42:05] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3554901 (10Etonkovidova) @jmattazoni - yes, the separate ticket about "Group by p... [23:43:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3554902 (10Etonkovidova) Closing this ticket as a just a specific bug which has b... [23:43:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review, 10User-notice-collaboration: Enable 'Group results by page' preference on the RC page itself - https://phabricator.wikimedia.org/T168513#3554904 (10Etonkov... [23:43:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3554903 (10Etonkovidova) 05Open>03Resolved [23:49:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Integrate Watchlist-management links and page info into the new UX - https://phabricator.wikimedia.org/T172030#3554910 (10jmatazzoni) [23:50:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3554912 (10jmatazzoni) ! In T171132#3554355, @... [23:55:26] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3554916 (10jmatazzoni) [23:55:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10MW-1.30-release-notes, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3554914 (10jmatazzoni) 05Open>03Resolved A... [23:58:29] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Audit all notification types to see if any more should be exceptions - https://phabricator.wikimedia.org/T166835#3554918 (10TBolliger) I've looked at Special:Preferences#mw-prefsection-echo and the spreadsheet Joe shared... [23:58:35] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Audit all notification types to see if any more should be exceptions - https://phabricator.wikimedia.org/T166835#3554920 (10TBolliger) 05Open>03Resolved [23:58:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3554921 (10TBolliger) [23:58:46] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3): Audit all notification types to see if any more should be exceptions - https://phabricator.wikimedia.org/T166835#3309218 (10TBolliger)