[02:20:27] (03PS4) 10Happy5214: [WIP] Proof-of-concept of logging on Thanks setting changes [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/372493 (https://phabricator.wikimedia.org/T120753) [08:05:46] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Make system for indicating 'seen changes' on en.wiki Watchlist compatible with New Filters highlighting - https://phabricator.wikimedia.org/T171235#3536749 (10Pginer-WMF) >>! In T1... [08:24:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Introduce the New Filters to users upon beta graduation - https://phabricator.wikimedia.org/T169613#3536768 (10Pginer-WMF) >>! In T169613#3534447, @jmatazzoni wrote: > @Pginer-wmf, I rewrote this to make i... [10:22:38] 10Collab-Notifications-Page, 10Collaboration-Team-Triage, 10Easy, 10Patch-For-Review, 10User-notice-collaboration: Add a "Mark all as read" button at Special:Notifications for no-JS users - https://phabricator.wikimedia.org/T96061#3536965 (10Trizek-WMF) [11:24:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Design for Integrating 'Related Changes' tool into new UX - https://phabricator.wikimedia.org/T172161#3537125 (10Pginer-WMF) The general direction described by @jmatazzoni makes sense. I illustrated a prop... [11:35:57] 10Collaboration-Team-Triage, 10Flow, 10I18n: [[MediaWiki:Notification-body-flow-summary-edited/en]] i18n issue - https://phabricator.wikimedia.org/T128268#3537186 (10Trizek-WMF) 05Open>03Resolved a:03Trizek-WMF LGTM, thanks MarcoAurelio! [13:10:43] 10Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Wikimedia-Site-requests, 10User-MarcoAurelio: Maintenance script run to convert Flow boards to Wikitext prior to remove Flow from Meta-Wiki - https://phabricator.wikimedia.org/T156113#3537443 (10MarcoAurelio) [13:20:50] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences: Get some community input about the plan to consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T173716#3537655 (10Trizek-WMF) [13:21:03] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Epic, and 2 others: Consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T172350#3495829 (10Trizek-WMF) >>! In T172350#3534665, @jmatazzoni wrote: > @Trizek-W... [13:21:15] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences: Get some community input about the plan to consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T173716#3537655 (10Trizek-WMF) [13:21:17] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences, 10Epic, and 2 others: Consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T172350#3537678 (10Trizek-WMF) [13:21:41] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences: Get some community input about the plan to consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T173716#3537655 (10Trizek-WMF) [13:37:12] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-User-preferences: Get some community input about the plan to consolidate preferences for all 'Change Monitoring' pages - https://phabricator.wikimedia.org/T173716#3537728 (10Trizek-WMF) p:05Triage>03Normal [13:37:59] 10Collaboration-Team-Triage, 10Flow, 10User-Urbanecm: Localize flow namespaces in ba - https://phabricator.wikimedia.org/T173719#3537731 (10Urbanecm) [13:39:47] (03PS1) 10Urbanecm: Localize namespaces in ba [extensions/Flow] - 10https://gerrit.wikimedia.org/r/372835 (https://phabricator.wikimedia.org/T173719) [14:28:14] (03CR) 10Jforrester: [C: 032] Localize namespaces in ba [extensions/Flow] - 10https://gerrit.wikimedia.org/r/372835 (https://phabricator.wikimedia.org/T173719) (owner: 10Urbanecm) [14:28:43] 10Collaboration-Team-Triage, 10Flow, 10User-Urbanecm: Localize flow namespaces in ba - https://phabricator.wikimedia.org/T173719#3537882 (10Jdforrester-WMF) 05Open>03Resolved [14:38:30] (03Merged) 10jenkins-bot: Localize namespaces in ba [extensions/Flow] - 10https://gerrit.wikimedia.org/r/372835 (https://phabricator.wikimedia.org/T173719) (owner: 10Urbanecm) [14:38:48] (03CR) 10jenkins-bot: Localize namespaces in ba [extensions/Flow] - 10https://gerrit.wikimedia.org/r/372835 (https://phabricator.wikimedia.org/T173719) (owner: 10Urbanecm) [15:16:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Watchlist ... - https://phabricator.wikimedia.org/T171030#3538023 [15:16:14] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3538027 (10Trizek-WMF... [16:17:23] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Investigate making Mute cross-wiki - https://phabricator.wikimedia.org/T171624#3538394 (10dbarratt) >>! In T171624#3535437, @Legoktm wrote:... [16:24:10] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-Gallery, 10Multimedia, 10Parsoid: Flow doesn't render correctly - https://phabricator.wikimedia.org/T124876#1969230 (10dr0ptp4kt) @ssastry @QuimGil is this fixed and if so, would you please close? [16:25:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Make system for indicating 'seen changes' on en.wiki Watchlist compatible with New Filters highlighting - https://phabricator.wikimedia.org/T171235#3538452 (10Trizek-WMF) >>! In T1... [16:33:46] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-Gallery, 10Multimedia, 10Parsoid: Flow doesn't render correctly - https://phabricator.wikimedia.org/T124876#3538489 (10Trizek-WMF) 05Open>03Resolved Tested and it looks good. If there is still a problem, please reopen. [18:08:32] stephanebisson, can you rereview/merge https://gerrit.wikimedia.org/r/#/c/372590/ ? RoanKattouw +2'ed it, but it failed on !important. I changed it to just be overly specific instead. [18:10:18] stephanebisson, could also use your review on the migration of the saved queries to params https://gerrit.wikimedia.org/r/#/c/372572/ [18:16:21] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Investigate making Mute cross-wiki - https://phabricator.wikimedia.org/T171624#3539049 (10MGChecker) >>! In T171624#3538394, @dbarratt wrot... [18:22:34] (03PS1) 10Mooeypoo: Fix 'unread' dot top padding regression [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372865 (https://phabricator.wikimedia.org/T173059) [18:22:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10Patch-For-Review, 10Regression: [regression-wmf.13] Notification panel - misaligned blue dot - https://phabricator.wikimedia.org/T173059#3539100 (10Mooeypoo) a:03Mooeypoo [18:56:58] (03CR) 10Jforrester: [C: 032] Update Red50 'destructive' color [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372172 (owner: 10VolkerE) [19:01:25] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Investigate making Mute cross-wiki - https://phabricator.wikimedia.org/T171624#3539279 (10Niharika) > I don't think this is a good idea, be... [19:05:52] (03CR) 10jerkins-bot: [V: 04-1] Update Red50 'destructive' color [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372172 (owner: 10VolkerE) [19:08:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3539318 (10Mooeypoo) a:03Mooeypoo [19:42:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review: Set default filters for beta users of Watchlist - https://phabricator.wikimedia.org/T171134#3539447 (10SBisson) > * Page edits: active > * Page creations: act... [19:45:59] (03CR) 10Sbisson: [C: 032] Fix 'unread' dot top padding regression [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372865 (https://phabricator.wikimedia.org/T173059) (owner: 10Mooeypoo) [19:55:35] (03Merged) 10jenkins-bot: Fix 'unread' dot top padding regression [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372865 (https://phabricator.wikimedia.org/T173059) (owner: 10Mooeypoo) [19:56:40] (03CR) 10jenkins-bot: Fix 'unread' dot top padding regression [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372865 (https://phabricator.wikimedia.org/T173059) (owner: 10Mooeypoo) [20:46:24] great. 'onGroupByPageModelUpdate' method exists, but there's no actual listener to evoke it. [20:46:33] And I was wondering WHY IT DOESN'T WORK [20:50:14] ^ stephanebisson [20:50:35] stephanebisson, sorry, was expecting the Gerrit to go here, but it doesn't since it's core. [20:50:47] stephanebisson, I put a comment on https://gerrit.wikimedia.org/r/#/c/372187/ [20:51:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Patch-For-Review: Initial setup of watchlist to use new UI - https://phabricator.wikimedia.org/T171132#3539580 (10Mattflaschen-WMF) Minor fix needed for areFiltersInConflict [21:04:46] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: 'Group results by page' option is sticky - https://phabricator.wikimedia.org/T172580#3539631 (10Mooeypoo) a:05Mooeypoo>03None [21:05:20] (03PS1) 10Legoktm: Use namespaced ScopedCallback [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372892 [21:05:21] matt_flaschen, speaking of core and comments, can you see my response on https://gerrit.wikimedia.org/r/#/c/372573/ [21:06:17] matt_flaschen, I think we should either define "sticky" params in the backend, or we might have to manually specify them. Going over the grouped params isn't really enough, because if I have namespace=xx then we shouldn't load defaults -- but it won't appear in the group filter definitions [21:08:01] mooeypoo, good point. Those should also be defined in the new parameter system ChangesList*Filter.php. Not sure if we want to do that now, or workaround it for now. [21:08:21] mooeypoo, meaning namespace shouldn't be a special case, since it should be in the structured param system. [21:09:49] Yeah but for now they're not, the UI collects them [21:10:05] And the tags (they're BUILT in the backend, but then sent to the JS as "filters" thing) [21:10:11] in short, we either need to find a workaround-for-now [21:10:24] or we need to consider how to redo this so the backend does the entire definition? [21:10:40] PRobably #1 temporarily and then prep + submit a ticket for a better solution for #2 [21:15:00] mooeypoo, yeah, I'm filing a ticket for #2 then I'll look at your comment. But this is a valid reason to do it beyond just being nice in theory (it would let us neatly track everything, including what is sticky) [21:46:16] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Port remaining kinds of ChangesList filters and parameters to structured filters - https://phabricator.wikimedia.org/T173785#3539718 (10Mattflaschen-WMF) [21:55:10] mooeypoo, so I do think isSticky makes sense. As a workaround for now, there's basically two options: [21:55:19] a. Go by group and add the missing ones (e.g. namespace). [21:55:49] b. Look at all parameters then exclude the sticky ones [21:56:53] mooeypoo, the problem with b. is that you have to also exclude a few general ones like useskin, uselang, debug (and then they might add more general ones) [22:08:33] matt_flaschen, no that's why we went by the recognized $opts [22:08:53] isn't it? I mean, isn't the $opts thing already sifting out all the general GET vars to only things that pertain to the page? [22:13:04] mooeypoo, oh, yeah, that would be c. I forgot about that (as you noted, those general ones are not in FormOptions). But in the latest patch set, you're doing b. without excluding anything. [22:13:20] mooeypoo, you did array_keys( $opts->getAllValues() ) [22:13:38] mooeypoo, oh, never mind. [22:14:21] mooeypoo, so you're only looking at page-specific ones, but not excluding the sticky ones yet. [22:17:44] matt_flaschen, that's right, I'm looking at only the ones that are page-specific but not removing stickies [22:18:03] so as a workaround temporarily we can just *manually* say "except these filters" and then long-term we can have the entire definition in the backend [22:18:17] including sticky and namespaces etc ec --- what the controller is doing right now [22:21:06] mooeypoo, yeah, or you can go the other way, and have a temporary explicit list to add (a.) (adding namespaces, tags). But just excluding the stickies for now is simpler. [22:21:30] Task is T173785 [22:21:30] T173785: Port remaining kinds of ChangesList filters and parameters to structured filters - https://phabricator.wikimedia.org/T173785 [22:22:18] Yeah I'd like to do it right with that task ^ but it won't be an easy quick solution; we'll need to make sure we build the entire definition in a way that the Watchlist can do the same for its separate stuff, and make sure the controller now reads that definition rather than creates some of it itself [22:22:30] and there are issues with making sure numbers are validated in custom values [22:22:41] nothing insane, but it would require a little more strategic thinking. [22:23:24] So I'll just exclude the stickies for now. BTW -- they're not ACTUALLY stick for the moment, either :\ days and limit were meant to be sticky but aren't while the preference is weird [22:23:33] but I'll ignore them for the defaults anyways [22:28:13] mooeypoo, yeah, back when I implemented the backend, I set it up so SpecialWatchlist and SpecialRecentChanges both separately override ChangesListSpecialPage (it was already necessary due to different preferences). [22:28:40] mooeypoo, now stephanebisson has added custom watchlist structured filters, and we can do the same for anything different for these other filters (tags or whatever). [22:29:09] yup [22:29:13] And we're already doing validation for string options, it would just be a different validation function. So it's not too complicated, but there's some work to do. [22:30:15] I mean override re the structured filters (e.g. they call setDefault), they were already subclasses of course. [22:32:08] Yeah, none of it is super hard, it just requires a more focused approach, probably not thorugh this task, but a separate one taht you created. But yeah, I think overall what you're saying is also a better solution [22:37:10] (03CR) 10MaxSem: [C: 032] Use namespaced ScopedCallback [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372892 (owner: 10Legoktm) [22:47:15] (03Merged) 10jenkins-bot: Use namespaced ScopedCallback [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372892 (owner: 10Legoktm) [22:48:24] 10Collaboration-Team-Triage, 10Notifications, 10Support-and-Safety, 10Anti-Harassment (AHT Sprint 3), 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Investigate making Mute cross-wiki - https://phabricator.wikimedia.org/T171624#3539892 (10dbarratt) [22:50:16] (03CR) 10jenkins-bot: Use namespaced ScopedCallback [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372892 (owner: 10Legoktm) [23:06:31] (03PS2) 10VolkerE: Update Red50 'destructive' color [extensions/Echo] - 10https://gerrit.wikimedia.org/r/372172 [23:21:35] array_splice is the most confusing method ever [23:22:00] "If offset is positive then the start of removed portion is at that offset from the beginning of the input array." [23:22:13] so if it's positive, it's just the index [23:22:26] if it's negative, it's length-index ('cause it starts from the end) right?! [23:22:33] why does it have to be so confusing [23:22:39] matt_flaschen, ^ meh [23:47:47] matt_flaschen, I fixed it up and moved the operation to another method: https://gerrit.wikimedia.org/r/#/c/372573/ [23:47:53] matt_flaschen, I hope this makes sense as a temporary hack [23:54:44] mooeypoo, substr and other methods do the same. Not sure if that helps... [23:57:42] mooeypoo, actually, array operations are the one thing PHP Is good at. [23:58:06] mooeypoo, good rule of thumb is to assume there's a specific function for it (there usually is), then eventually get annoyed at the obscure corner case that doesn't have a function. [23:58:10] In this case, it's just array_diff. [23:58:27] var_export( array_diff( [ 'blah', 'hideminor', 'days', 'hidebyothers' ], [ 'limit', 'days', 'enhanced', 'from', 'invert' ] ) );