[00:20:54] (03CR) 10Umherirrender: build: Replace jshint and jscs with eslint; drop csslint (034 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/370114 (owner: 10Jforrester) [00:24:44] (03PS2) 10Jforrester: build: Replace jshint and jscs with eslint; drop csslint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/370114 [00:50:03] (03CR) 10Catrope: [C: 032] build: Replace jshint and jscs with eslint; drop csslint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/370114 (owner: 10Jforrester) [01:30:23] 10Collaboration-Team-Triage, 10Regression: [betalabs-regression] Noticeable delay when a Flow post opens for edit - https://phabricator.wikimedia.org/T172469#3499523 (10Etonkovidova) [01:35:11] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [wmf.11] "Number of edits to show in recent changes ..." form accepts invalid numbers - https://phabricator.wikimedia.org/T172026#3499576 (10Catrope) >>! In T172026#34... [01:37:19] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Wikimedia-log-errors: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3499577 (10Catrope) None of those changes deal with *saving* RecentChan... [02:05:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [wmf.11] "Number of edits to show in recent changes ..." form accepts invalid numbers - https://phabricator.wikimedia.org/T172026#3499613 (10jmatazzoni) 05Open>03Re... [02:05:36] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 10Patch-For-Review, 10User-notice-collaboration: Allow users to save their filter selections for... - https://phabricator.wikimedia.org/T164128#3499615 [02:05:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Add 'Make this the default' option to bookmarks action menu - https://phabricator.wikimedia.org/T171922#3499614 (10jmatazzoni)... [02:07:32] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3499617 (10jmatazzoni) [02:07:33] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Tracking: 'Integrated filters'—add all RC Page filters into the new UI along with selected new functions - https://phabricator.wikimedia.org/T162675#3499619 (10jmatazzoni) [02:07:36] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3499618 (10jmatazzoni) 05Open... [02:07:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Scroll back to top when users click buttons at bottom of the main filter panel to switch to an Advanced pa... - https://phabricator.wikimedia.org/T170651#3499616 [04:29:27] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Wikimedia-log-errors: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3499791 (10mmodell) It might be wikidata, since I haven't seen more ins... [04:30:00] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Wikimedia-log-errors: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3499793 (10mmodell) [04:30:33] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Wikimedia-log-errors: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3498471 (10mmodell) p:05Triage>03Normal I'll keep an eye out for th... [05:45:30] 10Collaboration-Team-Triage, 10Flow: Flow stores redundant entries in External Store - https://phabricator.wikimedia.org/T172484#3499846 (10Mattflaschen-WMF) [05:46:03] 10Collaboration-Team-Triage, 10Flow: Flow stores redundant entries in External Store - https://phabricator.wikimedia.org/T172484#3499862 (10Mattflaschen-WMF) [05:46:20] 10Collaboration-Team-Triage, 10Flow: Flow stores redundant entries in External Store - https://phabricator.wikimedia.org/T172484#3499846 (10Mattflaschen-WMF) [05:46:33] 10Collaboration-Team-Triage, 10Flow: Flow stores redundant entries in External Store - https://phabricator.wikimedia.org/T172484#3499846 (10Mattflaschen-WMF) p:05Triage>03Low [05:54:09] 10Collaboration-Team-Triage, 10Flow: Flow stores redundant entries in External Store - https://phabricator.wikimedia.org/T172484#3499868 (10Mattflaschen-WMF) [07:35:03] (03PS1) 10Mattflaschen: WIP: Allow loading revisions without content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/370154 (https://phabricator.wikimedia.org/T172025) [07:38:02] (03CR) 10jerkins-bot: [V: 04-1] WIP: Allow loading revisions without content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/370154 (https://phabricator.wikimedia.org/T172025) (owner: 10Mattflaschen) [07:49:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10Patch-For-Review: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3499978 (10Pginer-WM... [08:01:11] 10Collaboration-Team-Triage, 10Notifications: Back-end infrastructure for timed notifications in Echo - https://phabricator.wikimedia.org/T156808#3499996 (10Mattflaschen-WMF) [08:02:08] 10Collaboration-Team-Triage, 10Notifications: Back-end infrastructure for timed notifications in Echo - https://phabricator.wikimedia.org/T156808#2986533 (10Mattflaschen-WMF) [08:07:14] (03CR) 10Mattflaschen: "Okay, the proposal (by TTO with modifications by me) is at T156808 ." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350500 (https://phabricator.wikimedia.org/T153817) (owner: 10MaxSem) [08:21:30] 10Collaboration-Team-Triage, 10Flow: Flow: Personal feed v1 (design) - https://phabricator.wikimedia.org/T100858#3500027 (10Trizek-WMF) FYI, [[https://meta.wikimedia.org/wiki/Grants:Project/ClemFlip/Wikifab/Various_types_of_transclusions_of_Flow_discussion_boards|this Grant proposal]] from @ClemFlip. [11:07:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3500517 (10T... [11:23:45] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10User-notice-collaboration: Special:Notifications is too slow to open - https://phabricator.wikimedia.org/T153011#3500539 (10Aklapper) 05Open>03declined > jmatazzoni moved this task from Untriaged to Ready for Pickup on the Coll... [11:52:41] 10MediaWiki-Recent-changes: Special:RecentChanges no longer displays a list of languages on wikis that have added interwiki links to MediaWiki:Recentchangestext - https://phabricator.wikimedia.org/T172461#3499317 (10Candalua) I also noticed the same behaviour since today. Also T102888 (show interwikis from Wikid... [11:53:36] 10MediaWiki-Recent-changes, 10MediaWiki-Special-pages, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Regression: [Bug] Recent changes pages doesn't have anymore the interlingual wikilinks on the sidebar on some projects - https://phabricator.wikimedia.org/T102888#1376178 (10Candalua) [11:56:35] 10MediaWiki-Recent-changes: Special:RecentChanges no longer displays a list of languages on wikis that have added interwiki links to MediaWiki:Recentchangestext - https://phabricator.wikimedia.org/T172461#3499317 (10Reedy) I blame #mw1.30.0-wmf.12 [12:11:11] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3451391 (10Iniquity) >>! In T171027#3484334, @Reedy wrote: > This is cau... [12:36:26] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3451391 (10jcrespo) This is the explain of such a query- if it has a LIM... [12:49:20] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3500734 (10jcrespo) I do not think ores is the problem here, it just add... [12:57:05] 10MediaWiki-Recent-changes, 10Regression: Special:RecentChanges no longer displays a list of languages on wikis that have added interwiki links to MediaWiki:Recentchangestext - https://phabricator.wikimedia.org/T172461#3500752 (10Aklapper) [14:29:42] (03PS67) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [14:43:06] (03PS68) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [15:04:12] 10MediaWiki-Recent-changes, 10Regression: Special:RecentChanges no longer displays interwiki links on wikis that have added them to MediaWiki:Recentchangestext - https://phabricator.wikimedia.org/T172461#3501362 (10Srdjan_m) [16:26:31] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10Patch-For-Review: Article Reminder API - https://phabricator.wikimedia.org/T166973#3501539 (10Mattflaschen-WMF) [16:26:35] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications: Figure out the correct way to trigger the Article Reminder event for all notification types - https://phabricator.wikimedia.org/T167451#3501538 (10Mattflaschen-WMF) 05Open>03Invalid [16:34:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10Patch-For-Review: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3501567 (10Etonkovid... [16:36:21] 10Collaboration-Team-Triage, 10Notifications: Internal API for scheduled events - https://phabricator.wikimedia.org/T172541#3501584 (10Mattflaschen-WMF) [16:36:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Put community-defined 'related links' into a collapsible panel - https://phabricator.wikimedia.org/T166919#3501598 (1... [16:36:36] 10Collaboration-Team-Triage, 10Notifications: Back-end infrastructure for timed notifications in Echo - https://phabricator.wikimedia.org/T156808#2986533 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Eee888 [16:36:45] 10Collaboration-Team-Triage, 10Notifications: Internal API for scheduled events - https://phabricator.wikimedia.org/T172541#3501584 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Eee888 [16:37:42] 10Collaboration-Team-Triage, 10Notifications: Maintenance script to look for scheduled events and fire them - https://phabricator.wikimedia.org/T172542#3501603 (10Mattflaschen-WMF) [16:38:49] 10Collaboration-Team-Triage, 10Notifications: Method API for scheduled events - https://phabricator.wikimedia.org/T172541#3501619 (10Mattflaschen-WMF) [16:39:58] 10Collaboration-Team-Triage, 10Notifications: Maintenance script to look for scheduled events and fire them - https://phabricator.wikimedia.org/T172542#3501623 (10Mattflaschen-WMF) [16:40:14] 10Collaboration-Team-Triage, 10Notifications: Maintenance script to look for scheduled events and fire them - https://phabricator.wikimedia.org/T172542#3501603 (10Mattflaschen-WMF) [16:40:16] 10Collaboration-Team-Triage, 10Notifications: Method API for scheduled events - https://phabricator.wikimedia.org/T172541#3501584 (10Mattflaschen-WMF) [16:40:51] 10Collaboration-Team-Triage, 10Notifications: WMF production cron job configuration for scheduled events - https://phabricator.wikimedia.org/T172543#3501628 (10Mattflaschen-WMF) [16:41:06] 10Collaboration-Team-Triage, 10Notifications: WMF Beta Cluster cron job configuration for scheduled events - https://phabricator.wikimedia.org/T172544#3501642 (10Mattflaschen-WMF) [16:44:27] 10Collaboration-Team-Triage, 10Notifications: Vagrant and WMF Beta Cluster cron job configuration for scheduled events - https://phabricator.wikimedia.org/T172544#3501655 (10Mattflaschen-WMF) [16:47:58] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Tracking: 'Integrated filters'—add all RC Page filters into the new UI along with selected new functions - https://phabricator.wikimedia.org/T162675#3501660 (10jmatazzoni) [16:48:01] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10Patch-For-Review: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3501659 (10jmatazzon... [18:06:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)): Add GENDER variants to MediaWiki:Flow-dialog-cancelconfirm-message and MediaWiki:Flow-dialog-cancelconfirm-title - https://phabricator.wikimedia.org/T169191#3390062 (10Etonkovido... [18:10:06] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review, 10Regression: [betalabs-regression] The names of Saved filters are not disp... - https://phabricator.wikimedia.org/T172427#3501889 [18:18:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review, 10Regression: [betalabs-regression] The names of Saved filters are not disp... - https://phabricator.wikimedia.org/T172427#3501899 [18:18:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review, 10Regression: [betalabs-regression] The names of Saved filters are not disp... - https://phabricator.wikimedia.org/T172427#3501900 [18:42:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502003 (10j... [18:42:35] 10MediaWiki-Recent-changes, 10Regression: Special:RecentChanges no longer displays interwiki links on wikis that have added them to MediaWiki:Recentchangestext - https://phabricator.wikimedia.org/T172461#3502004 (10Lsanabria) This is also happening in the Spanish projects (eswiki, eswikiversity, etc.) [18:44:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502006 (10j... [18:54:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Regression: [betalabs-regression] 'Show last changes' does not display number 1 - https://phabricator.wikimedia.org/T172557#3502011 (10Etonkovidova) [19:01:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502026 (10S... [19:22:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3502058 (10jmatazzoni) >>!... [19:43:42] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502100 (10j... [19:48:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502101 (10S... [20:11:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3502140 (10SBisson) >>! In... [20:15:17] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502147 (10j... [20:34:43] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3502259 (10Etonkovidova) [20:36:11] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3369419 (10Etonkovidova) -... [20:59:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3502309 (10E... [21:11:11] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3502359 (10Etonkovidova) [21:12:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/370270 (owner: 10L10n-bot) [21:15:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Put community-defined 'related links' into a collapsible panel - https://phabricator.wikimedia.org/T166919#3502361 (1... [21:18:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review, 10Regression: [betalabs-regression] 'Other review tools' arrow placed too low - https://phabricator.wikimedia.org/T172237#3502374 (10Etonkovidova) 05Open>03Resolved [21:29:05] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Tweaks to 'Previously viewed changes' marker of Live Update - https://phabricator.wikimedia.org/T172213#3502392 (10jmatazzoni) In T172213... [21:30:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3502393 (10jmatazzoni) ! I... [21:33:51] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3502401 (10jmatazzoni) In... [21:36:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Tweaks to 'Previously viewed changes' marker of Live Update and View Newest Changes - https://phabricator.wikimedia.org/T172213#3502403 (1... [21:37:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Tweaks to 'Previously viewed changes' marker of Live Update and View Newest Changes - https://phabricator.wikimedia.org/T172213#3490318 (1... [21:39:31] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Tweaks to 'Previously viewed changes' marker of Live Update and View Newest Changes - https://phabricator.wikimedia.org/T172213#3502436 (1... [21:41:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Put community-defined 'related links' into a collapsible panel - https://phabricator.wikimedia.org/T166919#3502451 (1... [21:54:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MW-1.30-release-notes, 10Patch-For-Review: [minor] Trim leading/trailing white spaces when searching for RC filters, Namespaces, Tags and Main menus - https://phabricator.wikimedia.org/T168225#3502541 (10Etonkovidova) Re-checked - all cases are wor... [21:54:11] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MW-1.30-release-notes, 10Patch-For-Review: [minor] Trim leading/trailing white spaces when searching for RC filters, Namespaces, Tags and Main menus - https://phabricator.wikimedia.org/T168225#3502542 (10Etonkovidova) 05Open>03Resolved [22:20:42] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3502593 (10Vicpeters) 05Open>03Resolved a:03Vicpeters I was happy... [22:21:05] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3502597 (10Vicpeters) 05Resolved>03Open [22:24:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3502607... [22:45:10] RoanKattouw, come for the docblock memoir, stay for the exception fix (and *maybe* fixing the Beta issue): https://gerrit.wikimedia.org/r/370290 [22:46:32] matt_flaschen: +2ed but which docblock should I be looking at? [22:46:44] RoanKattouw, top of the file. [22:46:51] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3502636 (10Mattflaschen-WMF) a:05Vicpeters>03None [22:47:05] Ha nice [22:47:59] BTW if you want to see some crazy and depressing code, look at IndexPager.php lines 144-148 and the function called from there, WebRequest::getLimitOffset() [22:48:18] And you'll see why supporting the wllimit preference required a bit of hackery [22:49:46] Actually, due to the combination of that and FormOptions, I haven't actually settled on what hackery to use [22:58:04] RoanKattouw, I was wondering where that 5000 was. I grepped for it at one point. [22:58:29] Yeah I also didn't realize that that's where it was until just now [22:58:44] I knew IndexPager had 'rclimit' hard-coded as a pref name but I didn't realize WebRequest did too [22:59:00] RoanKattouw, I like how it ignores the default limit *immediately* after getting it, when the next method has $deflimit as the first parameter (wouldn't be surprised if that signature changed in an unexpected order, though). [22:59:26] It does use mDefaultLimit later [22:59:27] Very un-DI also. [22:59:31] haha no shit [22:59:33] global $wgUser; [22:59:35] Yeah, I figured. :( [23:02:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), 10Patch-For-Review: Put community-defined 'related links' into a collapsible panel - https://phabricator.wikimedia.org/T166919#3502664 (1... [23:09:49] matt_flaschen: Also, embarrassing diff: [23:09:55] public function shouldHighlightAsWatched( $row ) { [23:09:55] return $this->getConfig()->get( 'ShowUpdatedMarker' ) && [23:09:55] - ( !isset( $row->wl_user ) || $row->wl_user === null ); [23:09:55] + isset( $row->wl_user ) && $row->wl_user !== null; [23:09:55] } [23:10:26] Turns out I was bolding every page except watched ones [23:13:17] * matt_flaschen nods [23:13:25] RoanKattouw, isset includes !== null [23:13:37] .... of course it does [23:13:40] Thanks PHP [23:13:51] Oh right, so empty() is really just @!isset() [23:14:02] Yeah, that's the kind of thing I still have to check sometimes. [23:14:31] That's why we have http://php.net/manual/en/function.array-key-exists.php which is obviously totally different despite sounding the same. [23:15:50] RoanKattouw, nope. isset *only* excludes null, not all falsy. [23:16:10] Oh right [23:16:17] empty() is more like @!count() [23:16:54] According to our conventions, "empty( $var ) essentially does !isset( $var ) || !$var." [23:17:07] RoanKattouw, which I think (but not sure) is basically the same except for what I previously said about count. [23:17:33] Right, it seems that count() returning 0 isn't actually documented anywhere [23:20:43] RoanKattouw, so turns out you were right before, but not above. [23:20:51] php > var_export( !count( false ) ); [23:20:52] false [23:20:54] php > var_export( empty( false ) ); [23:20:55] true [23:21:11] But count() is documented to accept non-arrays-or-countables, kind of... [23:21:42] "When the parameter is neither an array nor an object with implemented Countable interface, 1 will be returned. There is one exception, if array_or_countable is NULL, 0 will be returned." [23:21:44] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3502681 (10Aklapper) To quote Krinkle from duplicate task T171366#346265... [23:23:33] So if it's not an array or countable, count() returns (int) isset. [23:42:32] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Performance: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3502714 (10Catrope) >>! In T171027#3500706, @jcrespo wrote: > This is th... [23:47:05] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 10MW-1.29-release-notes, 10Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3502723 (... [23:47:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3502721... [23:51:13] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown, 10Patch-For-Review, 10Performance, 10Russian-Sites: "2062 Read timeout is reached" DBQueryError when trying to load specific users' watchlists (with +1000 articles) on ruwiki - https://phabricator.wikimedia.org/T171027#3502725 (10Liuxinyu970226) [23:55:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Restore default filters' and 'Clear all filters' will display ungrouped changes with 'Group results by page' option checked - https://phabricator.wikimedia.org/T172580#3502741 (10Etonkovidova) [23:56:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Restore default filters' and 'Clear all filters' will display ungrouped changes with 'Group results by page' option checked - https://phabricator.wikimedia.org/T172580#3502772 (10Etonkovidova) [23:56:27] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review, 10User-notice-collaboration: Enable 'Group results by page' preference on the RC page itself - https://phabricator.wikimedia.org/T168513#3366847 (10Etonkov...