[01:03:13] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Wikimedia-Site-requests, 10Patch-For-Review: Set $wgEnotifMinorEdits true throughout WMF, and instead use $wgDefaultUserOptions['enotifminoredits'] - https://phabricator.wikimedia.org/T142727#2544545 (10Etonkovidova) Checked in betalabs (for wikite... [01:28:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Easy: Small language tweak in 'Changes to show' menu - https://phabricator.wikimedia.org/T172031#3495896 (10jmatazzoni) >>! In T172031#3495635, @Mooeypoo wrote: > Is this ready... [01:38:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Wikimedia-Site-requests, 10Patch-For-Review: Set $wgEnotifMinorEdits true throughout WMF, and instead use $wgDefaultUserOptions['enotifminoredits'] - https://phabricator.wikimedia.org/T142727#3495920 (10jmatazzoni) 05Open>03Resolved [03:02:12] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)): Hide ORES review letter from the change list legend. - https://phabricator.wikimedia.org/T172338#3496022 (10Catrope) > @Catrope:... [06:06:56] (03CR) 10Foxy brown: Create UI for submitting article reminder (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [08:01:41] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10User-notice-collaboration: Changes in the legend expanded/collapsed status are not persistent while in Live Updates mode - https://phabricator.wikimedia.org/T172363#3496264 (10Pginer-WMF) [08:48:27] (03PS60) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [08:48:47] (03CR) 10Foxy brown: Create UI for submitting article reminder (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [08:54:55] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [09:23:54] (03PS61) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [09:24:18] (03PS62) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [09:30:49] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [09:37:19] (03PS63) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [09:43:26] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [09:46:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'Oldest first' option to the 'Number of changes selector' - https://phabricator.wikimedia.org/T172240#3496447 (10Pginer-WMF) >>! In T172240#3494568, @jmatazzoni wrote: > @Pginer-WMF Thanks. I knew it w... [09:47:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review, 10User-notice-collaboration: Enable 'Group results by page' preference on the RC page itself - https://phabricator.wikimedia.org/T168513#3496456 (10Pginer-... [09:49:27] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'Oldest first' option to the 'Number of changes selector' - https://phabricator.wikimedia.org/T172240#3496460 (10Pginer-WMF) [09:54:30] 10Collaboration-Team-Triage, 10Flow: Error when run maintenance/FlowSearchConfig.php - https://phabricator.wikimedia.org/T172369#3496468 (10Pastakhov) [10:03:40] (03PS64) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [10:10:11] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [10:16:07] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-General-or-Unknown, 10Wikimedia-log-errors: unable to undelete a page in the MediaWiki namespace in din.wikipedia.org (due to system user ID being 0 or negative?) - https://phabricator.wikimedia.org/T171842#3496537 (10Aklapper) [10:36:00] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Create or edit the documentation to reflect what is included in T157642 and what remains as a Beta feature - https://phabricator.wikimedia.org/T172282#3492995 (10Elitre... [10:44:42] (03PS65) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [10:51:13] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [10:57:30] 10Collaboration-Team-Triage, 10Flow, 10Browser-Tests-Infrastructure, 10Release-Engineering-Team (Kanban): Flow reply_moderation browser test has erroneous selector for "3rd comment on the topic" - https://phabricator.wikimedia.org/T85201#3496658 (10Liuxinyu970226) [11:01:07] (03PS66) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [11:28:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Consult en.wiki community re. how to adapt indicato... - https://phabricator.wikimedia.org/T171233#3496702 [11:28:55] ^ matt_flaschen, the message about Watchlists has been posted to the Technical VP: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#New_filters_for_edit_review_Beta_feature:_how_to_show_new_edits_on_watchlists.3F [12:39:50] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3496843 (10S... [12:42:13] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3496846 (10S... [13:05:55] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Create or edit the documentation to reflect what is included in T157642 and what remains as a Beta feature - https://phabricator.wikimedia.org/T172282#3496893 (10Trizek... [13:24:15] 10Collaboration-Team-Triage, 10Flow: Error when run maintenance/FlowSearchConfig.php - https://phabricator.wikimedia.org/T172369#3496468 (10Reedy) > Should I run maintenance/FlowSearchConfig.php or why the bug was not caught so much time? I guess the script hasn't been run by anyone recently, and as such, has... [13:48:48] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10User-notice-collaboration: Changes in the legend expanded/collapsed status are not persistent while in Live Updates mode - https://phabricator.wikimedia.org/T172363#3497007 (10SBisson) I can see this on frwiki but not locally. My... [14:01:01] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Cannot set my default to see all results (no filters) - https://phabricator.wikimedia.org/T172387#3497067 (10SBisson) [14:02:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3497081 (10SBisson) a:03MSchottlender-WMF [14:03:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3445726 (10SBisson) a:05MSchottlender-WMF>03Mooe... [14:12:13] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Cannot set my default to see all results (no filters) - https://phabricator.wikimedia.org/T172387#3497136 (10SBisson) Of course I can do it by using a "no effect" filter combination or any number of highlights but I'm gaming the system. [16:30:42] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [wmf.11] "Number of edits to show in recent changes ..." form accepts invalid numbers - https://phabricator.wikimedia.org/T172026#3497802 (10Etonkovidova) Checked the... [16:55:21] mooeypoo: tooltips for https://phabricator.wikimedia.org/T166919? [17:43:08] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/369969/ por favor [17:52:56] (03CR) 10Mooeypoo: [C: 04-1] Create UI for submitting article reminder (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [18:35:05] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Tweak Advanced Filters navigation UI during the interim period of 2 Advanced Filters only - https://phabricator.wikimedia.org/T171894#3479506 (10Etonkovidova... [18:59:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3498306... [19:12:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Regression: [betalabs-regression] The names of Saved filters are not displayed - https://phabricator.wikimedia.org/T172427#3498360 (10Etonkovidova) [19:13:41] mooeypoo: stephanebisson there is a regression bug in betalabs - maybe the result of the new way to define default filters? https://phabricator.wikimedia.org/T172427 [19:24:23] meh, I think it's because we enabled/disable dthe sticky limit [19:24:35] let me see about a fix [19:28:37] hm i can't reproduce it locally [19:28:57] oh, here it is [19:30:51] mooeypoo: :) [19:43:34] stephanebisson: are we going to do something with those numerous "Failed to load resource: the server responded with a status of 404 (Not Found)" ? I remember that you mentioned it in the chat ... [19:43:51] wait... RoanKattouw now that limit and days are non-sticky, do we exclude them from the saved results (easiest, got a patch waiting) or do we still include them in the saved results, in which case the comparison of whether a saved query exists will fail fi everything is the same except limit or days [19:43:55] just verifying herre [19:43:56] here [19:44:06] limit/days behavior is temporary anyways right now [19:44:22] Let's just not change it [19:44:27] Since it's temporary anyway [19:44:40] I can't NOT change it, it's failing on comparison [19:44:48] because the code removes sticky values and they're not sticky anymore [19:44:57] ... ok I'm abot to push a fix, see if you like it? [19:45:42] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/369995/ [19:46:25] RoanKattouw, this will mean backwards compatibility AND forwards compatibility, since we won't be **saving** those states either [19:46:27] Oh I meant don't change the behavior for the user [19:46:30] Which it looks like that patch does [19:46:34] yeah [19:46:38] etonkovidova: I would love to. This was put in place specifically for Special:RCL/ to return 404 so search engines dont index it. It should not have been done for a case like ours where a certain combination of filters happen to return no data at the moment but it's been like that for so long that it may be seen as a "feature" by some people or bots. See T69182 [19:46:38] T69182: Send 404 status code for special pages without contents - https://phabricator.wikimedia.org/T69182 [19:46:43] I'm not 100% happy with telling the view model about the saved queries model [19:46:46] but ... [19:47:03] I couldn't find a better name for this config that actually describes what it's doing properly [19:47:14] because the UriProcess still only ignores sticky, so it's not for it [19:47:21] stephanebisson: yes, it's been like that for a long time :) [19:47:22] maybe it should be. I dunno. [19:48:19] RoanKattouw, ^ [19:48:37] etonkovidova: Short of changing it and waiting for complaints, I have no idea how to find out if anybody relies on it. [19:48:56] stephanebisson: In my pagination patch (which I plan to polish on my flight tomorrow), that would return a 400 instead, but we can reevaluate that [19:49:16] (I made any invalid/conflicting filter combination return 400, and an invalid title for RCL is also in that category) [19:49:58] stephanebisson: yes, it's not that important - just annoying to see sooo many of them [19:50:51] RoanKattouw: We're not talking about invalid/conflicting here but just no data atm (i.e. log entries from 1 minute ago) [19:51:00] Yes, no data is 404 [19:51:19] It's just that you mentioned RCL with invalid titles as an example and I wanted to point out that I'm proposing making that a 400 [19:51:26] (Although I don't really care about status codes) [19:51:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review: Add 'Make this the default' option to bookmarks action menu - https://phabricator.wikimedia.org/T171922#3498673 (10Etonkovidova... [19:52:42] RoanKattouw: this was done for a very specific reason (T69182) but having "no data" return 200 would prevent massive console spam now that we have live update and view newest changes [19:52:42] T69182: Send 404 status code for special pages without contents - https://phabricator.wikimedia.org/T69182 [19:53:18] stephanebisson: So mooeypoo and I were talking about live update last night and we discussed the wastefulness of fetching the entire page every 3s [19:53:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review, 10Regression: [betalabs-regression] The names of Saved filters are not displayed - https://phabricator.wikimedia.org/T172427#3498694 (10Mooeypoo) a:03Mooeypoo [19:53:41] RoanKattouw: we're not [19:53:51] Ideally we'd have an API (which with the ChangesList class and my upcoming pager might be reasonably easy) but at least we could add a ?raw=1 param or something to Special:Recentchnages [19:54:01] So that it only returns the changes list and none of the chrome [19:54:09] That param could also change the 404 vs 200 behavior [19:54:30] stephanebisson: We're not updating it in the DOM every 3s, but we are pulling it down over the network every 3s right? [19:54:43] not the entire changeslist [19:54:58] the page with from= and limit=1, I think [19:55:12] but all the chrome, yes [19:55:54] having an API would obviously be much better, for this feature and others, but it would have to support all the same parameters in exactly the same way to be reliable [19:57:15] alternatively, the HEAD verb on the page would tell us if there's anything worth fetching, but I don't think we support that either [19:59:42] at least we're pulling it via ajax so it doesn't try to load the millions of linked resources like the browser does [20:08:39] Yeah I think the real annoyance is all that console-spam [20:09:03] if we can kill 2 birds with one parameter, maybe it's worth it. Not urgent, but perhaps worth it for some near term todo [20:09:37] if raw=1 can return sensible responses (non 404 for no-results, for example) PLUS have no-chrome it might be worth it [20:10:39] I'm not sure how much work it is to do that, though, considering SpecialRecentchanges extends ChangesListSpecialPage [20:17:01] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10Patch-For-Review: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3386103 (10Etonkovid... [20:42:21] 10MediaWiki-Recent-changes, 10Wikimedia-log-errors: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3498892 (10Aklapper) [20:48:08] 10Collaboration-Team-Triage, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3498901 (10Krinkle) [20:50:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/370044 (owner: 10L10n-bot) [20:51:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/370047 (owner: 10L10n-bot) [20:53:07] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 10Wikimedia-log-errors: Undefined index: rc_logid in includes/changes/RecentChange.php on line 338 - https://phabricator.wikimedia.org/T172433#3498913 (10Krinkle) Given all files that use `rc_login` in MediaWiki co... [20:54:23] 10Collaboration-Team-Triage, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3498545 (10SBisson) Any chance that can be related to the previous blocker about how wikibase inserts RC records? {T172320} Is there also a trace i... [21:09:02] 10Collaboration-Team-Triage, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3498963 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [21:10:32] 10Collaboration-Team-Triage, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3498545 (10Krinkle) Relevant code (from current version of wmf.12): 10Collaboration-Team-Triage, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3498971 (10Mattflaschen-WMF) >>! In T172438#3498919, @SBisson wrote: > Any chance that can be related to the previous blocker about how wikibase ins... [21:12:33] 10Collaboration-Team-Triage, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3498972 (10Krinkle) >>! In T172438#3498919, @SBisson wrote: > Any chance that can be related to the previous blocker about how wikibase inserts RC r... [21:22:45] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [wmf.5] The invite opt-in popup does not accommodate some languages - https://phabricator.wikimedia.org/T168413#3498998 (10Etonkovidova) [21:31:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [wmf.12] plwiki RC page shows standalone 'Hide reviewed edits' link - https://phabricator.wikimedia.org/T172451#3499008 (10Etonkovidova) [21:34:08] RoanKattouw: if you have a sec - please take a look at https://phabricator.wikimedia.org/T172451. So, if there is a old filter option that does not match with new filters options, it will be displayed as an additional link?! [21:46:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Patch-For-Review, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3499049 (10Mattflaschen-WMF) [21:48:04] etonkovidova, yes, this is known. That's the only way you can have backwards-compatibility for third parties. We should integrate it soon, though. [21:48:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Create new RC Filters group for 'Flagged Revisions', based on the old 'Hide reviewed edits' function - https://phabricator.wikimedia.org/T159791#3499058 (10Mattflaschen-WMF) [21:50:55] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Create new RC Filters group for 'Flagged Revisions', based on the old 'Hide reviewed edits' function - https://phabricator.wikimedia.org/T159791#3499067 (10Mattflaschen-WMF) Repl... [21:53:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team, and 3 others: ORES: Don't highlight changes propagated from Wikidata - https://phabricator.wikimedia.org/T168487#3366057 (10Etonkovidova) Checked the fix in production (wmf.12). W... [21:53:47] RoanKattouw, stephanebisson, mooey|lunch, there is an API (https://www.mediawiki.org/wiki/API:Usercontribs), but there would be some blockers with using it (where to render, Flow) [22:15:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Scroll back to top when users click buttons at bottom of the main filter panel to switch to an Advanced pa... - https://phabricator.wikimedia.org/T170651#3499109 [22:16:13] matt_flaschen: thx! [22:35:17] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team, and 3 others: ORES: Don't highlight changes propagated from Wikidata - https://phabricator.wikimedia.org/T168487#3499151 (10jmatazzoni) 05Open>03Resolved [22:39:14] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Epic: Graduate New Filters for Edit Review on RC page out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3499184 (10jmatazzoni) [22:39:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Tweak Advanced Filters navigation UI during the interim period of 2 Advanced Filters only - https://phabricator.wikimedia.org/T171894#3499181 (10jmatazzoni)... [23:03:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review, 10User-notice-collaboration: Reduce the separation between saved filters and active filters - https://phabricator.wikimedia.org/T171822#3477225 (10Etonkovi... [23:04:13] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10User-notice-collaboration: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3499266 (10jmatazzoni) [23:04:15] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review, 10User-notice-collaboration: Reduce the separation between saved filters and active filters - https://phabricator.wikimedia.org/T171822#3499265 (10jmatazzo... [23:07:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review, 10User-notice-collaboration: Number of results and time selector... - https://phabricator.wikimedia.org/T171968#3481704 [23:07:54] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10User-notice-collaboration: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3499308 (10jmatazzoni) [23:07:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), 10Patch-For-Review, 10User-notice-collaboration: Number of results and time selector... - https://phabricator.wikimedia.org/T171968#3499307 [23:08:53] (03PS1) 10Jforrester: build: Replace jshint and jscs with eslint; drop csslint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/370114 [23:09:36] (03CR) 10Jforrester: "This is the last Wikimedia-deployed extension with csslint in it, AFAICT." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/370114 (owner: 10Jforrester) [23:28:11] RoanKattouw, okay, I am starting to give up on the less tricks. [23:28:25] tr:first-child, [23:28:25] td:not( :nth-child( -n+3 ) ) { [23:28:25] .mw-rcfilters-highlight-color-c1 & { [23:28:25] ... [23:28:25] } [23:28:29] not working [23:28:31] >.< [23:29:27] RoanKattouw, I could use your help. The irony is that now *more than 1* works. 1 color only doesn't. IT'S THE SAME RULE! [23:31:09] mooeypoo: I'm on my way back to the office, I'll be able to help in half an hour or so [23:31:27] And yeah I'm super confused by that top [23:32:25] One trick I recommend is use debug mode, then find the CSS that applies to the 2 color ones so that you can find the CSS that less generated for the 1-color rules, then feed those selectors into jQuery [23:33:56] I tried [23:33:58] but I'll try again [23:34:05] I think I have the positioning of the highlights sorted, at least [23:37:37] RoanKattouw, well, the positioning of the highlights work for both li and enhanced + the nested stuff [23:37:46] but the **actual** highlights are only applied when there's more than one [23:37:52] that is, only in the mixin [23:37:54] ironically [23:49:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MediaWiki-Special-pages, 10Patch-For-Review, 10Wikimedia-log-errors: Multiple: undefined index in SpecialContributions.php on line 203 - https://phabricator.wikimedia.org/T172438#3499436 (10Reedy) [23:53:03] 10MediaWiki-Recent-changes: Special:RecentChanges no longer displays a list of languages on wikis that have added interwiki links to MediaWiki:Recentchangestext - https://phabricator.wikimedia.org/T172461#3499438 (10Reedy) [23:58:34] mooeypoo: I'm back at my desk now BTW if you wanna debug more deeply [23:58:41] hang on I'll call