[06:44:30] mooeypoo, grouped (enhanced) RC doesn't work for me locally. It doesn't expand when you click the arrow. Known issue? [06:44:40] It works on MediaWiki.org [06:45:10] With Beta feature enabled, didn't check otherwise. [06:54:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Enhanced (grouped) RC arrow doesn't work - https://phabricator.wikimedia.org/T171428#3464598 (10Mattflaschen-WMF) [06:54:44] ^ [07:06:41] matt_flaschen: She wrote a fix for that on Friday but I forgot to review it [07:07:16] Same bug as T171085, I've just +2ed the patch for it [07:07:16] T171085: [betalabs-regression] the Legend does not collapse/expand on RC page with 'New filters for edit review' beta feature enabled - https://phabricator.wikimedia.org/T171085 [07:08:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Enhanced (grouped) RC arrow doesn't work - https://phabricator.wikimedia.org/T171428#3464636 (10Catrope) [07:08:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: [betalabs-regression] the Legend does not collapse/expand on RC page with 'New filters for edit review' beta feature enabled - https://phabricator.wikimedia.org/T171085#3453610 (10Catrope) [07:10:13] RoanKattouw, thanks, I searched, but it didn't find anything about enhanced RC, and I didn't realize that was the same bug. [07:13:16] RoanKattouw, TIL: [07:13:46] 1. String access by character: http://php.net/manual/en/language.types.string.php#language.types.string.substr (note you can also *write* the string like that). (I did know you could do ++ on strings, but not that). [07:14:07] 2. You can use {} instead of [] to dereference either strings or arrays. [07:14:14] 3. "The behaviour of an automatic conversion to array is currently undefined." [07:28:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}" - https://phabricator.wikimedia.org/T170917#3464688 (10Sjoerddebruin) [07:49:28] I knew about {} for strings but not arrays [07:50:35] And yeah I knew you could do $str[42] = 'x'; , I didn't realize you could do $str[42]++; though [07:52:05] I came to PHP from C so I guess I wasn't as surprised by these things as I perhaps should have been [09:06:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3465030 (10Pginer-WMF) >>! In T163426#3462316, @Catrope wrote: > After reading... [09:51:47] 10Collaboration-Team-Triage, 10Notifications, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10Patch-For-Review, 10User-notice: Notifications flyout footer has an unwanted margin - https://phabricator.wikimedia.org/T171302#3465303 (10Trizek-WMF) [13:09:06] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Watchlist: Separate the user's 'Saved filters' on Watchlist from the user's 'Saved filters' on RC page - https://phabricator.wikimedia.org/T171218#3465816 (10Pginer-WMF) >>! In T171218#34610... [13:14:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 3 others: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3465837 (10Trizek-WMF) I'v... [15:25:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}" - https://phabricator.wikimedia.org/T170917#3466377 (10Jdlrobson) [16:02:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}" - https://phabricator.wikimedia.org/T170917#3466587 (10ovasileva) looked at this... [16:03:23] (03PS36) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [16:12:57] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [16:24:13] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3466686 (10Etonkovidova) Thx, @Mooeypoo. I think the... [16:35:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}" - https://phabricator.wikimedia.org/T170917#3466727 (10pmiazga) @ovasileva butto... [16:39:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}" - https://phabricator.wikimedia.org/T170917#3466732 (10Jdlrobson) See https://ph... [16:54:35] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RC page - default selection of '50 changes in 7 days' is sticky - https://phabricator.wikimedia.org/T171368#3466784 (10Etonkovidova) [17:45:31] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement: Enable users to opt out of the New Filters once they graduate out of beta - https://phabricator.wikimedia.org/T168376#3466949 (10jmatazzoni) [17:45:42] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Collaboration-Community-Engagement: Consider to provide a fallback option to the original page setup/layout for pages that will receive the new RC Filters - https://phabricator.wikimedia.org/T168376#3466951 (10Mattflaschen-WMF) [17:46:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Collaboration-Community-Engagement: Consider to provide a fallback option to the original page setup/layout for pages that will receive the new RC Filters - https://phabricator.wikimedia.org/T168376#3466953 (10jmatazzoni) [17:46:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Collaboration-Community-Engagement: Enable users to opt out of the New Filters once they graduate out of beta - https://phabricator.wikimedia.org/T168376#3362622 (10jmatazzoni) a:03jmatazzoni [17:46:54] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements, 10Collaboration-Community-Engagement: Enable users to opt out of the New Filters once they graduate out of beta - https://phabricator.wikimedia.org/T168376#3466956 (10Mattflaschen-WMF) a:05jmatazzoni>03None [17:52:15] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Remove opt out for New Filters Beta - https://phabricator.wikimedia.org/T171499#3467006 (10Mattflaschen-WMF) [17:52:29] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Remove opt out for New Filters Beta - https://phabricator.wikimedia.org/T171499#3467021 (10Mattflaschen-WMF) [17:54:12] jmatazzoni_, mooeypoo, T171499 [17:54:12] T171499: Remove opt out for New Filters Beta - https://phabricator.wikimedia.org/T171499 [17:54:25] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Remove opt out for New RC Filters - https://phabricator.wikimedia.org/T171499#3467006 (10Mattflaschen-WMF) [17:54:42] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Remove opt out for New RC Filters - https://phabricator.wikimedia.org/T171499#3467043 (10Mattflaschen-WMF) [18:01:59] (03CR) 10Reedy: [C: 032] Add missing jQueryMsg dependency for mobile diff view [extensions/Thanks] (wmf/1.30.0-wmf.10) - 10https://gerrit.wikimedia.org/r/366899 (https://phabricator.wikimedia.org/T170917) (owner: 10Mattflaschen) [18:02:01] (03CR) 10Reedy: [C: 032] Fix layout regression in notification popup footer [extensions/Echo] (wmf/1.30.0-wmf.10) - 10https://gerrit.wikimedia.org/r/366952 (https://phabricator.wikimedia.org/T171302) (owner: 10Jforrester) [18:10:46] (03Merged) 10jenkins-bot: Add missing jQueryMsg dependency for mobile diff view [extensions/Thanks] (wmf/1.30.0-wmf.10) - 10https://gerrit.wikimedia.org/r/366899 (https://phabricator.wikimedia.org/T170917) (owner: 10Mattflaschen) [18:12:57] (03Merged) 10jenkins-bot: Fix layout regression in notification popup footer [extensions/Echo] (wmf/1.30.0-wmf.10) - 10https://gerrit.wikimedia.org/r/366952 (https://phabricator.wikimedia.org/T171302) (owner: 10Jforrester) [18:19:01] stephanebisson, unifying RC and WL internally more makes sense. But product-wise, for the reasons I mentioned, I think they should be separate (separate default filters, separate saved filters). [18:19:04] Since the use cases are different. [18:20:11] matt_flaschen: different entry points, different default filters, same app [18:20:45] stephanebisson, yeah, I would add "different saved filters" (IMHO, but depending what we decide right now), but otherwise I agree. [18:28:19] (03CR) 10jenkins-bot: Fix layout regression in notification popup footer [extensions/Echo] (wmf/1.30.0-wmf.10) - 10https://gerrit.wikimedia.org/r/366952 (https://phabricator.wikimedia.org/T171302) (owner: 10Jforrester) [18:29:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Thanks, 10MobileFrontend, 10Reading-Web-Backlog, and 4 others: Thank button broken on mobilefrontend - displays "{{GENDER:[object Object]|{{GENDER:unknown|Thank}}}}" - https://phabricator.wikimedia.org/T170917#3467258 (10Catrope) 05Open>03Reso... [18:30:11] 10Collaboration-Team-Triage, 10Notifications, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), 10Patch-For-Review, 10User-notice: Notifications flyout footer has an unwanted margin - https://phabricator.wikimedia.org/T171302#3467260 (10Catrope) 05Open>03Resolved a:03Catrope [18:35:40] mooeypoo, RoanKattouw, re changing how saved filters work due to things moving between groups, I might have misunderstood the proposed tech change, but I just wanted to note that filters (e.g. verygood) inside different groups can have the same name. [18:36:20] matt_flaschen: Yeah, internally in the frontend they are prefixed with the group name though [18:36:31] We needed to do that to make the goodfaith group work [18:36:59] Early on, there was a bug where if you clicked the checkbox for "likely good faith", the checkbox for "likely good quality" would be checked [18:37:13] And for a week or two we renamed one of them to likelygood2 [18:37:31] RoanKattouw, yeah, I remember. [18:37:43] I don't get the proposed solution to things moving between groups, though. [18:38:28] Oh; no that wasn't clear to me either [18:41:38] RoanKattouw: I see in the travel manifest that you're flying into BOS. Are you driving up, or running across the border during the night? [18:41:49] haha [18:42:08] in search of political asylum, perhaps [18:42:15] What's the name of the town in upstate NY where people jump over the little stream and get arrested, but because of a loophole are able to apply for asylum [18:42:18] I will not be doing that [18:42:56] I'm meeting Ed and Thal at BOS, Ed's renting a car there and we'll drive to Trevor's house in NH, then up to Montreal on Tuesday [18:43:07] Trevor & family are driving up separately on Thursday [18:45:34] that's gonna be a nice drive, but cross the border very early in the morning or fill up, pack a lunch, and enjoy the wait ;) [18:45:58] Oh dear [18:47:44] We'll have to keep an eye on https://travel.gc.ca/returning/border-times [18:48:02] (which surprisingly says "no delay" at St-Armand right now) [18:48:18] 8/5 is the last day of "vacances de la construction" where every construction worker in the province comes back from vacation, mostly in the US [18:50:48] RoanKattouw, matt_flaschen we could change this by having saved filters save the **parameters** rathre than the state of the filter model [18:51:00] not a huge change, but it will be an annoying change to backwards-compat. [18:51:12] Oooh [18:51:19] We could do that fairly easily by changing the (hidden) preference name and checking if the old one exists, then migrate [18:51:24] We have that in NL too [18:51:37] We're driving up on the 8th though, not the 5th [18:52:16] mooeypoo: How would that solve anything? When we change filter names/groups we often change the param representation too [18:52:22] RoanKattouw, matt_flaschen if you think that's a good idea, we can do it later too, especially if we migrate from an old name to a new pref name, that shouldn't be too horrible [18:52:25] That's what happened in the registered/unregistered change [18:52:30] RoanKattouw, params don't change if you shift groups [18:52:33] the NAME of filter does [18:52:42] We went from hideliu=1 to userExpLevel=unregistered [18:52:46] oh [18:52:46] well [18:52:49] that won't work either way [18:52:52] Exactly [18:53:03] I guess for the watched-ness thing you are right though [18:53:03] but if we look between RecentChanges and Watchlist, that WOULD help [18:53:17] Although --- no that's a string_options group so the name of the group is the name of the parameter [18:53:20] if we want to unify or let people switch between saved filters here and there [18:53:37] RoanKattouw, yeah but then it would be something like userExpLevel__unregistered [18:53:44] Yes that's what it is now [18:53:49] vs userExpLevel__hideliu [18:53:58] but in watchlist, the name of groups might be different [18:54:12] so you might end up having group1__filter1 in RC but group3__filter1 in watchlist [18:54:23] if we want saved filters to be unified, we should save params in that case [18:54:34] and let the system translate that to model state/name [18:55:32] ok I'm going to drop what I'm doing and implement sticky limit/days since right now the "sticky" is hard coded which is bad [18:56:12] Then I'll need to set it up so saved filters **ignore** those, and fetch them from default/current value when you reload a query [18:57:15] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3228852 (10Alsee) It would be rare for someone to deliberately sea... [19:02:17] RoanKattouw, so, the 'limit' default isn't just for RCFilters, is it? I need to create a new hidden preference that is initialized from the other general pref but is then updated separately... per product, too, yes? or... [19:02:37] mooeypoo: Hold on [19:02:45] First, T171368 [19:02:45] T171368: RC page - default selection of '50 changes in 7 days' is sticky - https://phabricator.wikimedia.org/T171368 [19:03:05] Confusingly, that bug title is using "sticky" as a bad thing [19:03:06] RoanKattouw, that **is** what i'm doing [19:03:26] RoanKattouw, I'm changing it to use the default preference + sticky'ing it when you change selection [19:03:36] According to Elena choosing a different # of days/results simply does not work at all right now [19:03:40] 'rcdays' is the preference [19:03:58] oh, I though tthis was about going **back** to 50/7 [19:04:18] No no, this is a serious bug and it needs to be fixed today [19:04:53] RoanKattouw, I can't reproduce this [19:04:59] works for me perfectly. [19:05:07] Checking on beta now [19:05:47] hm [19:06:12] ok it changes the url but doesn't work in the backend it seems [19:07:50] RoanKattouw, [19:07:52] hidebots:1 [19:07:52] hidecategorization:1 [19:07:52] hideWikibase:1 [19:07:52] limit:250 [19:07:52] days:30 [19:07:53] urlversion:2 [19:07:57] ^ that's the network request [19:08:04] but I'm **getting back** only what I have in my preference [19:08:10] wtf [19:08:20] yeah [19:08:32] Also, on **load** the ui doesn't read the preference -- but that's known [19:08:52] bt the changing of the values works for changing the URL **and** sending the request but beta backend seems to ignore it? [19:08:57] It seems o work for me in vagrant though [19:08:59] it's confusing [19:09:31] Yeah I can't reproduce it either [19:09:42] RoanKattouw, hold on -- it only does that with limit [19:09:44] err [19:09:47] Hmm wait the limit doens't work [19:09:49] That's weird [19:09:56] yeah [19:10:01] days / hours seem to be okay [19:10:03] nm it does [19:10:08] Also hours doesn't work but we knew that [19:10:14] yeah days work [19:10:19] We should fix that though, or hide the hours for now [19:10:19] * mooeypoo nods [19:10:24] Hmm days and limit both WFM [19:10:43] RoanKattouw, go to your preferences. Fix limit to be 500 or something [19:10:46] go back to RC [19:10:55] limit will load incorrectly (known) [19:10:59] but then change limit to 50 [19:11:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RC page - default selection of '50 changes in 7 days' is sticky - https://phabricator.wikimedia.org/T171368#3467451 (10Catrope) This is working for me now; perhaps it was the same issue as {T171081} ? [19:11:02] ... does that work? [19:11:13] I guess maybe this was the same issue as the other bug that you fixed on Friday [19:11:15] wait, yes, it just worked for me [19:11:21] OK cool so this all works [19:11:24] Forget I said anythin [19:11:27] I am confused. I can't reproduce Elena's bug [19:11:39] yeah the only thing that is completely broken is not loading preference [19:11:41] Yeah I can't either [19:11:45] so "lying to you" in the beginning [19:11:47] I think that it was fixed by your other patch [19:11:49] + not being sticky [19:11:58] hm maybe [19:11:59] The fix for T171081 [19:11:59] T171081: Trash can button (reset to defaults) resets days and limit in model but not UI - https://phabricator.wikimedia.org/T171081 [19:12:05] oh yeah [19:12:06] Also: [19:12:09] $opts->add( 'days', $user->getIntOption( 'rcdays' ) ); [19:12:19] Maybe that's why hours doesn't work :D [19:12:28] ouch [19:12:28] Or... no wait [19:12:34] The int part is about reading the preference, so that should be OK [19:12:37] Well, is it casting to an int? [19:12:52] RoanKattouw, it also infers the type of the parameter from the default IIRC. [19:13:03] I think we saw something was wrong with the sql query though [19:13:05] Yeah [19:13:24] Also if ( preg_match( '/^days=(\d+)$/', $bit, $m ) ) { [19:13:41] So even if we make days=0.25 work in other places, it won't work in parseParameters [19:13:50] We might just have to bite the bullet and put in an hours param [19:14:02] that would suck [19:14:03] RoanKattouw, you can just change parseParameters. [19:14:09] Right that too [19:14:09] it would be a problem to convert between the two, too [19:14:10] Nothing will break if you allow period. [19:14:11] Good point [19:14:19] RoanKattouw, but you also need to change ->add to explicitly set FLOAT. [19:14:22] Rather than implicit AUTO. [19:14:42] Right, I'll try that [19:14:58] ok so now going back to my original question -- RoanKattouw matt_flaschen you both mentioned something about "limit" preference being more than just for RC [19:15:05] or am I misremembering? [19:15:07] mooeypoo, when you say parameter what do you mean? E.g. if I have goodfaith=verylikely, userExpLevel=learner;newcomer what are you calling a parameter? [19:15:20] mooeypoo, I think just RoanKattouw, I think he said it checks the pref at a low level in IndexPager. [19:15:44] days=X is a parameter [19:15:44] Yes [19:15:52] The rclimit pref is used all over the place [19:16:00] mooeypoo, right, this is re the earlier discussion about saved queries. [19:16:02] Basically any special page that uses pagination uses it [19:16:02] so I'm trying to understand -- do I update the 'rcdays' preference or do I take its initial value into a new one for RC only [19:16:04] or rclimit [19:16:10] rcdays is not used anywhere but RC [19:16:16] rclimit is though [19:16:20] Yes :/ [19:16:32] so I should have a new hidden pref for RCFilters on RC page only [19:16:38] and take the initial value from rclimit [19:16:47] but then take from it if it exists and update IT instead [19:16:48] yes? [19:17:02] Uggghhh [19:17:10] mooeypoo, in the pref draft they're still combined if you don't have RC filters. [19:17:15] https://docs.google.com/document/d/18N_aYioaDBXI83LUw9eqeEOUDoQHbr-riMZqniZMCto/edit#heading=h.vhf40h6ljjxb [19:17:21] Here's another reason why fractional days currently don't work: the cutoff timestamp is rounded down to 00:00 UTC [19:17:23] The problem with that is that while we still have that preference in RecentChanges it will basically be bunk to RecentChanges except no one will know it, but it will affect everything ELSE and no one will know it [19:17:37] Not sure what is intended for the sticky version. [19:17:45] $cutoff_unixtime = time() - ( $opts['days'] * 86400 ); [19:17:46] $cutoff_unixtime = $cutoff_unixtime - ( $cutoff_unixtime % 86400 ); [19:17:46] $cutoff = $dbr->timestamp( $cutoff_unixtime ); [19:17:59] matt_flaschen, if the sticky is separate between RC and Watchlist it might be good to have a separate pref anyways [19:18:10] but that would mean we might want to do that to both days and limit [19:18:11] I guess I could change that behavior to be modulo 3600 instead [19:18:23] But at that point I'm wondering if we shouldn't rename the whole param from days to hours [19:18:33] RoanKattouw, choose a sufficiently large number and you can use it for cryptography! \o/ [19:18:45] haha [19:19:11] RoanKattouw, what happens right now in non-RCFilters if you do days=1.5 ? [19:19:15] does it give you 1 or 2? [19:19:37] Probably 1, because the param type is integer [19:19:43] ha [19:19:47] BUT [19:19:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3467478 (10jmatazzoni) ! In T164292#3467408, @Alsee wrote: > I ca... [19:19:54] "1 day" doesn't mean what you think it means [19:20:04] It doesn't mean "the last 24 hours" [19:20:20] Instead, it means "go back 24 hours, and then go back some more until you hit 00:00 UTC" [19:20:45] So in other words, "1 day" means "today up to now, and all of yesterday" [19:20:46] So it changes between when you ask it [19:21:02] No, it doesn't unless you're right at the midnight boundary [19:21:03] if you ask it right before 5pm PST ... [19:21:07] Right yes [19:21:13] And then it changes by 24h suddenly [19:21:19] Yeah [19:21:21] Instead of gradually over time at a rate of 1 second per second [19:21:24] Well, ideally, it would take 24 hours [19:23:58] So -- here's how I think we should handle this [19:24:06] 1) Remove hours temporarily until they work [19:24:39] Well, hmmm, wait [19:24:42] We have several options [19:24:53] We could change the modulus from 86400 to 3600 and keep the same behavior [19:25:14] Or we could say that days=N means the cutoff is exactly N*86400 seconds ago without weird rounding crap [19:26:17] As long as you don't split to two params days/hours I'm good with whatever [19:28:12] No I'm instead suggesting we replace the days param with an hours param [19:28:27] I guess this might break b/c for some things though, parseParams in particular [19:28:36] matt_flaschen: What do you think about this idea? ---^^ [19:29:02] mooeypoo: Also I think doing this properly will take more than the ~20h we have before the cut, so perhaps we should remove/hide hours from the UI for now [19:29:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10User-notice: Notifications flyout footer has an unwanted margin - https://phabricator.wikimedia.org/T171302#3467523 (10Jdforrester-WMF) [19:29:42] We can, but if someone goes "0.5" days, they'll see nothing [19:32:47] What do you mean? [19:33:08] the entire operation checks days<1 [19:33:22] so if we hide the ui, and someone goes days=0.5 in the URL.... [19:35:09] RoanKattouw, I'm fixing it up, hang on [19:35:21] Ooh I see [19:35:25] It'll add it to the hidden area [19:35:26] OK, thanks [19:35:44] I'll get some lunch and go into the office but then I'll work on migrating the days param to an hours param [19:38:13] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/367469/ [19:38:59] Thanks [19:40:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Make number of days and number of changes settings sticky - https://phabricator.wikimedia.org/T171514#3467593 (10jmatazzoni) [19:47:40] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Epic: Graduate New Filters for Edit Review on RC page out of beta on Recent Changes - https://phabricator.wikimedia.org/T157642#3467664 (10jmatazzoni) [19:49:13] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Make number of days and number of changes settings sticky - https://phabricator.wikimedia.org/T171514#3467671 (10jmatazzoni) [19:49:15] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Design, 10MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), and 2 others: Integrate 'Number of Changes Selector' in the new filters for ... - https://phabricator.wikimedia.org/T162786#3467670 [19:51:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Make number of days and number of changes settings sticky - https://phabricator.wikimedia.org/T171514#3467700 (10jmatazzoni) [19:51:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Integrate 'Time Period Selector' into the new filters for edit review - https://phabricator.wikimedia.org/T162784#3467699 (10jmatazzoni) [19:51:36] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] Preferences-Recent changes "Number of edits to show in recent changes, page histories..." allows to save a number bigger than the limit - https://phabricator.wikimedia.org/T171518#3467701 (10Etonkovidova) [19:52:29] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] Preferences-Recent changes "Number of edits to show in recent changes, page histories..." option allows to save a number bigger than the limit - https://phabricator.wikimedia.org/T171518#3467719 (10Etonkovidova) [19:55:46] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [betalabs-regression] the Legend does not collapse/expand on RC page with 'New filters for edit review' beta feature ... - https://phabricator.wikimedia.org/T171085#3467727 [19:55:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: [betalabs-regression] the Legend does not collapse/expand on RC page with 'New filters for edit review' beta feature ... - https://phabricator.wikimedia.org/T171085#3467728 [20:52:48] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Ping Johan and Translators mailing list about Echo Notifications blacklist strings - https://phabricator.wikimedia.org/T168902#3467931 (10TBolliger) 05Open>03stalled [20:52:54] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3467932 (10TBolliger) [20:54:27] 10Collaboration-Team-Triage, 10Notifications, 10Refreshed: Echo badges don’t appear on mobile on MediaWiki 1.29+ - https://phabricator.wikimedia.org/T170773#3467935 (10SamanthaNguyen) 05Open>03Invalid See T163616#3467929 for more information on how to proceed on writing a proper bug report. I'm closing t... [20:55:48] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 3 others: Update message copy for Mute feature - https://phabricator.wikimedia.org/T166626#3467942 (10TBolliger) [20:57:06] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 2 others: Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS - https://phabricator.wikimedia.org/T166836#3467957 (10TBolliger) @Etonkovidova — so can this ticket... [20:57:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/367520 (owner: 10L10n-bot) [20:58:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/367527 (owner: 10L10n-bot) [21:12:55] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 2 others: Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS - https://phabricator.wikimedia.org/T166836#3468015 (10Etonkovidova) @TBolliger - yes, the ticket ca... [21:14:19] RoanKattouw, I don't support breaking compatibility to the extent of dropping days= entirely. We could make it a redirect to hours. [21:14:20] But why not just drop the weird "changes by 24h suddenly" and make days= float? I realize that is still a slight b/c break, but people should deal I think. [21:14:52] Yeah we could do that too [21:15:15] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3468020 (10TBolliger) [21:15:17] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 2 others: Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS - https://phabricator.wikimedia.org/T166836#3468018 (10TBolliger) 05Open>03Resolved [21:15:19] 10Collaboration-Team-Triage, 10Notifications, 10Refreshed: Echo badges don’t appear on mobile on MediaWiki 1.29+ - https://phabricator.wikimedia.org/T170773#3468021 (10MacFan4000) 05Invalid>03Open Echo is on the latest REL1_29 tarball Btw I can see them when logging in on brickipedia but not on my test i... [21:15:25] 10Collaboration-Team-Triage, 10Notifications, 10Refreshed: Echo badges don’t appear on mobile on MediaWiki 1.29+ - https://phabricator.wikimedia.org/T170773#3468027 (10MacFan4000) MediaWiki 1.29 [21:15:27] If I dropped days in favor of hours I would leave some b/c code anyway (interpreting days=N as hours=24N or something) [21:18:05] RoanKattouw, okay, cool. [21:18:47] RoanKattouw, should apply to parseParameters too. [21:19:16] Making it float and dropping the weird modulus crap is the easiest way to fix it, but the use fractional values for the days param bothers me because the decimal representation of 1/24 is infinitely long (recurring fraction) [21:21:27] There are ways to work around that but I feel like it'd get messy and it'd be better to use integer numbers of hours [21:23:00] RoanKattouw, yeah, you can just round to 3 places in the URL (it's not like money where the exact value matters), but I take your point. As long as there's b/c. [21:26:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [minor] Watchlist: when "Expand watchlist to show all changes ..." option is not enabled, but the counter for last changes still counts all changes - https://phabricator.wikimedia.org/T171527#3468048 (10Etonkovidova) [21:34:31] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment: Evaluate and decide if we need to capture any usage data for post-release analysis of Mute feature - https://phabricator.wikimedia.org/T168489#3468123 (10Niharika) [21:46:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Patch-For-Review, 10User-notice-collaboration: Deploy ORES Review Tool & ORES-based RCFilters for Romanian & Albanian Wikipedia - https://phabricator.wikimedia.org/T170723#3468172 (10Catrope) This will be deployed today around 23:00 UTC (a little o... [21:52:33] mooey|away: IIRC, during the Jerusalem hackathon you made a tool/script to generate the boilerplate for an extension, given some parameters. Is it still up? I was looking for the link to add to https://www.mediawiki.org/wiki/Manual:Developing_extensions [21:56:00] Niharika, aye, MWStew [21:56:22] http://tools.wmflabs.org/mwstew/ [21:56:26] Niharika, ^ [21:56:29] Aha! I knew it had something to do with cooking. :P [21:56:30] Might need updating [21:56:33] Thanks mooeypoo! [21:56:35] np! [21:56:40] also, i made another thing over the weekend [21:56:59] Hmm? [21:57:03] Niharika, https://www.mediawiki.org/wiki/User:Mooeypoo/User_script_demos [21:57:26] For next time we have anyone wanting to get into Wikimedia Dev with user scripts [21:57:42] Nice! This will be handy. [21:59:03] Yup, I'm hoping to get a nice collection from beginner up in there [21:59:18] there are examples we can show with things like adding stuff to VE or whatever. [22:57:15] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Split off ORES front end and back-end functions, so the Rev Scoring team can switch on a model without displaying the UI to users - https://phabricator.wikimedia.org/T171544#3468370 (10jmatazzoni) [22:58:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Split off ORES front end and back-end functions, so the Rev Scoring team can switch on a model without displaying the UI to users - https://phabricator.wikimedia.org/T171544#3468370 (10jmatazzoni) @Catrope, should th... [22:58:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Split off ORES front end and back-end functions, so the Rev Scoring team can switch on a model without displaying the UI to users - https://phabricator.wikimedia.org/T171544#3468370 (10jmatazzoni) [22:59:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Split off ORES front end and back-end functions, so the Rev Scoring team can switch on a model without displaying the UI to users - https://phabricator.wikimedia.org/T171544#3468388 (10Catrope) >>! In T171544#3468370... [23:00:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Split off ORES front end and back-end functions, so the Rev Scoring team can switch on a model without displaying the UI to users - https://phabricator.wikimedia.org/T171544#3468390 (10Catrope) [23:00:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3468394 (10Catrope) [23:03:10] OK, let me repeat this in the correct channel [23:03:16] 16:02:48  mooeypoo: When poking around in the RC code to deal with days/hours, I randomly discovered this: https://github.com/wikimedia/mediawiki/blob/master/includes/DefaultSettings.php#L6678 [23:03:24] Apparently in MediaWiki, EVERYTHING is configurable [23:05:16] .... [23:05:19] * mooeypoo mutters [23:05:29] but but [23:05:32] we're adding hours [23:05:33] and [23:05:39] ... meh [23:13:47] Yeah... [23:14:09] Also we're hard-coding those values in the client while /technically/ we should export those config vars [23:14:47] I'm still on the fence about whether we should use fractional days values or move to an hours param [23:14:59] Maybe as a first stab at making it work we should just do the former [23:24:23] but then use hours for everything, yes? [23:24:28] not use both params [23:26:19] Eventually that is what I'd like to do, yes [23:26:43] But now I'm thinking that would be a nontrivial amount of work and we might be better off making &hours=0.25 work first ,at least to start with [23:27:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Patch-For-Review, 10User-notice-collaboration: Deploy ORES Review Tool & ORES-based RCFilters for Romanian & Albanian Wikipedia - https://phabricator.wikimedia.org/T170723#3468463 (10Catrope) 05Open>03Resolved a:03Catrope [23:50:30] mooeypoo matt_flaschen: https://gerrit.wikimedia.org/r/367626 [23:53:21] And on top of that https://gerrit.wikimedia.org/r/#/c/367628/ [23:53:41] will look in a bit [23:53:47] matt_flaschen: Also, I updated https://gerrit.wikimedia.org/r/#/c/364251/ per your review [23:53:51] I'm still trying to get sticky to work