[11:11:27] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3443168 (10Pginer-WMF) >>! In T159896#3439939, @jmatazzoni wrote: > @Pginer-WMF, it looks like... [13:21:53] (03PS24) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [13:29:41] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [14:49:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3443880 (10SBisson) a:03SBisson [14:53:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3443895 (10SBisson) > Hovering the separator will turn it grey (base30: #72777d) , and clicking on i... [15:28:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3444040 (10jmatazzoni) I think that looks great. I have to questions/comments: - We need to... [15:49:28] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3444165 (10Pginer-WMF) >>! In T163426#3443895, @SBisson wrote: >> Hovering the separator will turn i... [16:12:33] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3444407 (10Pginer-WMF) >>! In T159896#3444040, @jmatazzoni wrote: > I think that looks great. I... [16:49:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017): [betalabs-regression] Watchlist setting ' Show only likely problem edits (and hide probably good edits)' does not propagate to Watchlist - https://phabricator.wikimedia.org/T170848#3444635 (10Etonkovidova) [16:52:48] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Metrics: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3444689 (10jmatazzoni) [17:09:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10TemplateStyles: Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3245507 (10Esanders) > This should also be verified to be true when creating a Flow post; T164790: Add c... [17:17:05] (03PS1) 10Esanders: Add mw-parser-output class to flow posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365656 (https://phabricator.wikimedia.org/T164791) [18:51:57] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Explore how to improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3445521 (10jmatazzoni) [19:01:31] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Scoring-platform-team, and 2 others: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3445603 (10Etonkovidova) Re-tested with the ORES scoring ranges... [19:05:30] (03CR) 10Mattflaschen: "> > I was hoping that someone who understands Flow would merge this. I am not sure if removed multiline:false are going to cause problems." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364670 (https://phabricator.wikimedia.org/T170275) (owner: 10Prtksxna) [19:08:50] (03CR) 10Catrope: [C: 032] Add mw-parser-output class to flow posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365656 (https://phabricator.wikimedia.org/T164791) (owner: 10Esanders) [19:09:13] (03CR) 10Catrope: [C: 032] "Thank you!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365656 (https://phabricator.wikimedia.org/T164791) (owner: 10Esanders) [19:24:40] (03Merged) 10jenkins-bot: Add mw-parser-output class to flow posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365656 (https://phabricator.wikimedia.org/T164791) (owner: 10Esanders) [19:26:08] (03CR) 10jenkins-bot: Add mw-parser-output class to flow posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365656 (https://phabricator.wikimedia.org/T164791) (owner: 10Esanders) [19:28:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10TemplateStyles, 10VisualEditor: Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3445718 (10Jdforrester-WMF) a:03Esanders [19:29:14] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/365651/ [19:29:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3445726 (10jmatazzoni) [19:31:37] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Explore how to improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3445757 (10jmatazzoni) [19:31:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3445726 (10jmatazzoni) [19:32:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Explore how to improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3082636 (10jmatazzoni) I've defined this as a design task ("Explore how to ...")... [19:33:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3445726 (10jmatazzoni) [19:33:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Explore how to improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3445762 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [19:33:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3445726 (10jmatazzoni) [19:37:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Improve highlighting display so it's compatible with 'Group results by page" preference - https://phabricator.wikimedia.org/T170875#3445770 (10jmatazzoni) a:03Pginer-WMF Pau, can you please add an illust... [19:52:36] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10TemplateStyles, 10VisualEditor: Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3445809 (10Anomie) I note https://gerrit.wikimedia.org/r/365656 seems to have missed t... [19:53:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: Enhanced RC expand/collapse arrows are not shown when starting from a conflict state - https://phabricator.wikimedia.org/T169835#3445810 (10Etonkovidova) Hmm... there... [19:53:36] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: Enhanced RC expand/collapse arrows are not shown when starting from a conflict state - https://phabricator.wikimedia.org/T169835#3445811 (10Etonkovidova) 05Open>03R... [20:46:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/365740 (owner: 10L10n-bot) [20:46:32] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), 10Patch-For-Review: Scroll back to top when users click buttons at bottom of the main ... - https://phabricator.wikimedia.org/T170651#3445962 [20:47:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/365749 (owner: 10L10n-bot) [21:01:35] 10Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Epic, 10Tracking: Graduate 'New filters for edit review' out of beta, making it standard on all wikis - https://phabricator.wikimedia.org/T170501#3446095 (10jmatazzoni) 05Open>03Invalid I've moved this list to the [[ https://phabricator.wikime... [21:12:35] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3446136 (10jmatazzoni) @Mooeypoo, if you do this bit with Exclude / Excluding, I can close this ticket.... [21:14:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation, 10Wikimedia-CentralNotice-Administration (Q1-2018): Write help documentation for Namespace filtering of Recent Changes. - https://phabricator.wikimedia.org/T167741#3446143 (10jmatazzoni) [21:15:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3311655 (10jmatazzoni) [21:15:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3311655 (10jmatazzoni) I moved the requirement to add a help link to T167741 [21:19:06] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation, 10Wikimedia-CentralNotice-Administration (Q1-2018): Write help doc for Namespace filtering of Recent Changes, and link to it from Name... - https://phabricator.wikimedia.org/T167741#3446173 [21:26:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3446291 (10jmatazzoni) [21:28:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3311730 (10jmatazzoni) 05Open>03Resolved [21:31:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, and 2 others: Edits to Flow are marked as Wikidata edits in enhanced RC - https://phabricator.wikimedia.org/T169181#3446320 (10Etonkovidova) @Mattflaschen-WMF I was checking the fix in me... [21:40:52] RoanKattouw: https://www.mediawiki.org/wiki/Special:RecentChanges?urlversion=2&namespace=13&associated=&tagfilter=&translations=filter&limit=500&days=30&from=&invert= [21:47:50] RoanKattouw: "empty days' happen only for Namespace filtering; Tags filter as other filters will display just days with records [21:53:35] Interesting [22:03:38] (03CR) 10Mooeypoo: [C: 04-1] Create UI for submitting article reminder (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [22:14:19] (03CR) 10Mooeypoo: [C: 04-1] Create UI for submitting article reminder (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [22:29:17] (03CR) 10Mooeypoo: [C: 04-1] Create UI for submitting article reminder (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [22:43:41] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10TemplateStyles, 10VisualEditor, 10MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)): Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3245507 (10Etonkovid... [23:22:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed as a conflict - https://phabricator.wikimedia.org/T162630#3446746 (10Eton... [23:37:41] 10Collaboration-Team-Triage, 10Notifications, 10MinervaNeue: Notification overlay in mobile has a mysterious indent for heading - https://phabricator.wikimedia.org/T170903#3446763 (10Jdlrobson) [23:55:34] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: 'Wikidata edits' filter with 'Contribution quality prediction' or 'User intent prediction' returns results but the filter selection displayed ... - https://phabricator.wikimedia.org/T162630#3446831 [23:57:37] matt_flaschen: I found another THIS IS PHP situation when reviewing Stephane's code, see https://gerrit.wikimedia.org/r/#/c/365234/1/includes/specialpage/ChangesListSpecialPage.php@1406 [23:58:00] Specifically, if you do $a = ['foo', 'bar', 'baz']; then remove 'bar', you expect $a === ['foo', 'baz'] to be true [23:58:05] But it depends on how you remove 'bar' [23:58:15] If you do $a = array_diff( $a, ['bar'] ); then it works fine [23:58:39] But if you do $idx = array_search( 'bar', $a ); unset( $a[$idx] ); then $a === ['foo', 'baz'] will be false [23:58:59] Because $a = [ 0 => 'foo', 2 => 'baz' ] and the right-hand side is [ 0 => 'foo', 1 => 'baz' ] [23:59:38] I don't know if I should be proud or concerned that I suspected something like this would happen and tested it in a console [23:59:44] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), 10Patch-For-Review: For some languages (here French), the label to save a set of filters is not al... - https://phabricator.wikimedia.org/T169110#3446849