[05:05:34] (03PS2) 10Catrope: Don't mess with $wgHooks in DeletedContributionsLineEnding hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364096 (owner: 10Legoktm) [05:06:41] (03CR) 10Catrope: [C: 032] Don't mess with $wgHooks in DeletedContributionsLineEnding hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364096 (owner: 10Legoktm) [05:17:15] (03Merged) 10jenkins-bot: Don't mess with $wgHooks in DeletedContributionsLineEnding hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364096 (owner: 10Legoktm) [05:17:48] (03CR) 10jenkins-bot: Don't mess with $wgHooks in DeletedContributionsLineEnding hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364096 (owner: 10Legoktm) [08:34:10] 10Collaboration-Team-Triage, 10Flow: external link does not work in topic title - https://phabricator.wikimedia.org/T170086#3419653 (10Aklapper) Note my unanswered questions. [08:59:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017), 10User-notice-collaboration: Announce to communities the change for RecentChangesText... - https://phabricator.wikimedia.org/T167945#3419827 [09:02:29] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3419846 (10Pginer-WMF) [09:04:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3419862 (10Pginer-WMF) >>! In T167944#3416005, @jmatazzoni wrote: > @Pginer-wmf p... [10:03:31] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make the initial state of saved filters more actionable - https://phabricator.wikimedia.org/T169055#3420080 (10Pginer-WMF) Based on @jmatazzoni comment in T167944#3409721 and the idea to make the action to save the filters more promine... [10:29:36] 10Collaboration-Team-Triage, 10Flow: external link does not work in topic title - https://phabricator.wikimedia.org/T170086#3420114 (10Bugreporter) external links will be displayed like the content of the post. [10:33:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3420118 (10Pginer-WMF) [11:03:17] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3420190 (10Pginer-WMF) [11:42:39] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3420289 (10Urbanecm) a:05Urbanecm>03None I can't do anything else, next things are discussed on... [14:45:54] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3420931 (10Mooeypoo) >>! In T168043#3415898, @jmatazzoni wrote: > @Mooe... [14:52:09] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3420968 (10Pginer-WMF) >>! In T168043#3420931, @Mooeypoo wrote: > In ot... [14:56:07] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3421010 (10Trizek-WMF) Any update? [15:01:57] (03PS47) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [15:02:11] (03PS20) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [15:02:15] (03PS6) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [15:03:32] (03PS48) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [15:04:07] (03PS49) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [15:04:24] (03PS21) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [15:04:28] (03PS7) 10Foxy brown: Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) [15:09:26] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3421057 (10Mooeypoo) >>! In T168043#3401249, @jmatazzoni wrote: > There... [15:11:51] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3421068 (10jmatazzoni) It's fine to do this all for the beta only. As y... [15:17:33] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [15:19:22] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [15:22:26] (03CR) 10jerkins-bot: [V: 04-1] Create UI for submitting article reminder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363540 (https://phabricator.wikimedia.org/T168388) (owner: 10Foxy brown) [15:24:42] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: RCFilters shows 'no filters' message even when filters are shown in the menu - https://phabricator.wikimedia.org/T170161#3421148 (10Mooeypoo) [15:25:43] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: RCFilters shows 'no filters' message even when filters are shown in the menu - https://phabricator.wikimedia.org/T170161#3421164 (10Mooeypoo) a:03Mooeypoo [15:37:16] (03PS22) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [15:38:10] (03CR) 10Foxy brown: Article Reminder UI button (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [15:44:10] (03PS50) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [15:44:23] (03PS23) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [15:50:49] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [15:51:17] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [15:59:08] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3421356 (10Mooeypoo) The above fix is for the message. I'm still trying... [16:36:21] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3386372 (10Deskana) @matmarex Can you take a look at this when you get a chance? Thanks! [16:37:38] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3421500 (10matmarex) a:03matmarex [17:14:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: When querying for multiple tags, and more than one is in the edit, duplicate results - https://phabricator.wikimedia.org/T168501#3421660 (10Catrope) a:03Catrope [17:26:45] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3421751 (10Mattflaschen-WMF) [17:52:22] (03CR) 10Esanders: [C: 04-1] Use Sanitizer::stripAllTags( $x ) instead of html_entity_decode( strip_tags( $x ) ) (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363994 (owner: 10Catrope) [18:50:44] legoktm, I see, didn't realize it was de-coupled. [19:08:38] (03CR) 10Catrope: Use Sanitizer::stripAllTags( $x ) instead of html_entity_decode( strip_tags( $x ) ) (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363994 (owner: 10Catrope) [19:09:07] (03PS2) 10Catrope: Use Sanitizer::stripAllTags( $x ) instead of html_entity_decode( strip_tags( $x ) ) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363994 [19:09:39] (03CR) 10Esanders: [C: 031] Use Sanitizer::stripAllTags( $x ) instead of html_entity_decode( strip_tags( $x ) ) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363994 (owner: 10Catrope) [19:18:54] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3422339 (10matmarex) This is actually more difficult than it looks like, since inspectors are in the same z-index "layer" as e.g. surface highlights and context menus. If... [19:26:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Improve the language of the "What's this?" links in the filters panel on Recent Changes - https://phabricator.wikimedia.org/T169053#3422370 (10jmatazzoni) [19:27:52] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3422372 (10matmarex) Generally, the more I think about this, the more I feel that bottom-positioned toolbars are just fundamentally a bad idea. Consider the case in the t... [19:28:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Easy: Improve the language of the "What's this?" links in the filters panel on Recent Changes - https://phabricator.wikimedia.org/T169053#3422376 (10jmatazzoni) [19:34:04] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422400 (10Etonkovidova) [19:47:45] 10Collaboration-Team-Triage, 10Flow, 10Tracking: Flow mentions (tracking) - https://phabricator.wikimedia.org/T108400#3422464 (10matmarex) [19:47:47] 10Collaboration-Team-Triage, 10Flow: Mention inspector box is not fully displayed in text placeholder for a new topic - https://phabricator.wikimedia.org/T107345#3422460 (10matmarex) 05Open>03Resolved This is no longer an issue. The mention inspector is now forced to be within the editing area. Instead, th... [19:49:10] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3422467 (10jmatazzoni) [19:49:12] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422466 (10jmatazzoni) [19:49:56] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422400 (10jmatazzoni) a:03Mooeypoo [19:51:36] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422487 (10Catrope) a:05Mooeypoo>03None [19:53:38] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3422519 (10matmarex) Actually, as far as I can tell, the broken behavior I described above is what was happening before my changes from T167616, and apparently everyone w... [20:07:36] i just tried installing Flow on a local test wiki, and when running update.php got this: [20:07:39] Function: Wikimedia\Rdbms\Database::sourceFile( /var/www/html/w/extensions/Flow/db_patches/patch-88bit_uuids.sql ) [20:07:39] Error: 1171 All parts of a PRIMARY KEY must be NOT NULL; if you need NULL in a key, use UNIQUE instead (localhost) [20:07:44] anyone seen it before? [20:08:42] MatmaRex, RoanKattouw ^^ [20:08:48] (Query: ALTER TABLE `flow_topic_list`.......) [20:08:58] meh [20:09:04] that was supposed to be matt_flaschen [20:09:07] but hi MatmaRex ! [20:09:23] hello [20:09:36] Sorry, I hit tab too soon and didn't notice it autocompleted wrong [20:10:43] mooeypoo: no worries, i regularly ping matany.a when trying to ping matt_flaschen :) [20:11:16] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422558 (10Mooeypoo) I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in? [20:11:30] haha yeah that happens too [20:17:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422565 (10Etonkovidova) Both Chrome and FF 54 (on Mac)display the issue. How it's displayed in Ub... [20:24:56] (my connection died for a moment, please repeat anything you said to me in the last 10 minutes) [20:33:35] (03PS1) 10Bartosz Dziewoński: Fix 'flow_topic_list' table to use non-nullable fields in the primary key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364289 [20:34:05] mooeypoo: so, i'm pretty sure that having nullable fields in a primary key is actually impossible, so that change ^ fixes flow not to try to do that [20:36:08] I'm going to defer to matt_flaschen and RoanKattouw on that one. It sounds logical to me, but I am quite far removed from the Flow table layout, I'm not sure if there was a reason or an implication for the change. [20:37:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364294 (owner: 10L10n-bot) [20:40:01] (03PS1) 10Umherirrender: Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364299 [20:40:03] (03PS1) 10Umherirrender: Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364300 [20:40:05] (03PS1) 10Umherirrender: Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364301 [20:40:08] (03PS1) 10Umherirrender: Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364302 [20:43:05] 10MediaWiki-Watchlist: Wrong namespace localization for comments on Wikidata changes in Wikipedia watchlist - https://phabricator.wikimedia.org/T170202#3422686 (10Fomafix) [20:44:30] 10Collab-Notifications-Page, 10Collaboration-Team-Triage, 10Design: Pagination direction widget should scroll users to top of page - https://phabricator.wikimedia.org/T170203#3422702 (10Quiddity) [20:45:58] (03CR) 10jerkins-bot: [V: 04-1] Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364299 (owner: 10Umherirrender) [20:46:06] (03CR) 10jerkins-bot: [V: 04-1] Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364300 (owner: 10Umherirrender) [20:46:33] (03CR) 10jerkins-bot: [V: 04-1] Break long lines [extensions/Echo] - 10https://gerrit.wikimedia.org/r/364301 (owner: 10Umherirrender) [20:56:54] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10Patch-For-Review: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3422738 (10matmarex) >>! In T169076#3422519, @matmarex wrote: > I don't have Flow set up locally, so I'd appreciate if someone could verify that it... [20:58:33] MatmaRex, mooeypoo, RoanKattouw, weird. Adding a primary key implicitly converts existing columns in that key to be not-null(!) [20:58:47] I was like, where are we setting that to be not null (not in flow.sql, not in any of the patches). [20:59:08] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Context anchor not aligned correctly when page is zoomed in/out - https://phabricator.wikimedia.org/T98800#1277885 (10matmarex) I can't reproduce this today. [20:59:40] MatmaRex, mooeypoo, RoanKattouw, P5712 [21:01:15] MatmaRex, that doesn't really explain your error, though. Something is apparently happening out of order for you. Are you using SQLite, or did you do anything manually? [21:05:41] matt_flaschen: yeah. as far as i can tell, the field is indeed "not null" [21:06:01] matt_flaschen: i did nothing out of ordinary. i cloned the repo, added wfLoadExtension(), ran update.php, and got that [21:07:07] matt_flaschen: the problem for me was definitely in the `ALTER TABLE /*_*/flow_topic_list` from patch-88bit_uuids.sql. can you try running that locally too? [21:07:32] perhaps something changed in some version where that will fail with that error, instead of magically adding NOT NULL (or failing quietly) [21:08:20] (it's not `ALTER TABLE /*_*/blah2 ADD PRIMARY KEY`, but rather `ALTER TABLE /*_*/blah2 CHANGE blah2_id blah2_id binary(11);` i think) [21:08:30] matt_flaschen: ^ [21:08:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422780 (10jmatazzoni) I see it in Chrome. See below. {F8695817} [21:08:55] MatmaRex, you can see from my paste adding the primary key will make it not null. [21:09:17] MatmaRex, I don't think a change will, I'll check though. [21:10:21] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422400 (10Catrope) >>! In T170190#3422558, @Mooeypoo wrote: > I don't see this in Chrome or Firefox... [21:10:29] matt_flaschen: yes. i mean, after there is a primary key, you can't alter the field to be nullable again, and patch-88bit_uuids.sql tries to do that [21:11:30] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422803 (10jmatazzoni) Actually, also in Safari. {F8695913} Second issue: do you see the misaligne... [21:19:27] MatmaRex, yeah, for me it just ignores the NULL (with explicit NULL clause or not). So it was probably broken by the primary-key file in some but not all configs/versions of MySQL: https://phabricator.wikimedia.org/P5713 [21:21:31] aha [21:21:33] 10MediaWiki-Watchlist, 10Wikidata: Wrong relation to Wikidata changes on enhanced watchlist - https://phabricator.wikimedia.org/T169689#3422820 (10JAnD) >>! In T169689#3418890, @matej_suchanek wrote: >>>! In T169689#3415271, @JAnD wrote: >> Wrong is, that this change is **not on watched page** nor in page's it... [21:21:36] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422822 (10Mooeypoo) >>! In T170190#3422803, @jmatazzoni wrote: > Actually, also in Safari. > > {F8... [21:22:22] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: RC Legend - the highlight color is displayed over the Legend - https://phabricator.wikimedia.org/T170190#3422824 (10Mooeypoo) >>! In T170190#3422783, @Catrope wrote: >>>! In T170190#3422558, @Mooeypoo wrot... [21:24:35] matt_flaschen, RoanKattouw does ?enhanced=0 load no-js no enhanced/beta feature? [21:24:39] because if so, it doesn't work for me [21:25:53] No [21:25:54] I get really weird stuff going on. I get the JS version of the filters, but the highlights are only partially displayed (no dots at the end, highlight dots seem to not be appended) and the highlight is running over the legend [21:26:00] It loads the non-"enhanced" RC [21:26:01] mooeypoo, that's for grouped/ungrouped. [21:26:07] oh [21:26:07] "Enhanced" refers to the grouping thing [21:26:09] well [21:26:09] I.E. enhanced RecentChanges. [21:26:12] crap [21:26:16] also, super bad naming [21:26:17] But it's an entirely separate rendering backend for the items [21:26:21] It's totally broken [21:26:37] The highlight wrapper isn't there! [21:26:51] What adds the highlight wrapper? JS or PHP? [21:26:56] JS [21:27:51] Right [21:27:55] This seems to be a regression [21:27:57] I'm checking [21:28:14] mw.rcfilters.ui.ChangesListWrapperWidget.prototype.setupHighlightContainers <-- adds to either enhanced and non-enhanced view [21:28:49] .... RoanKattouw I found the issue [21:28:54] (BTW the backends are OldChangesList.php and EnhancedChangesList.php) [21:29:07] if ( Number( mw.user.options.get( 'usenewrc' ) ) ) { [21:29:25] ^ that returns a different answer when I do ?enhanced=0 in the URL [21:29:53] So I get "yep, you're in enhanced!" but I'm not by the URL but then the code doesn't find the right li's to push to [21:30:11] How many people use the url imperative rather than changing the settings? [21:30:15] Aaaah [21:30:16] Hah [21:30:31] I guess you could test with the real pref then [21:30:33] I'm fixingit to read the URL unless there's a way to read current setting? [21:30:37] In practice, probably almost nobody [21:30:47] But can't we learn from the DOM which one is in use? [21:31:44] Hmm not easily it looks like ... the s do have class="mw-enhanced-rc [21:31:44] (03CR) 10Mattflaschen: [C: 04-1] "I think it is really caused by the patch-primary-keys.sql patch. However, this should be fine as an alternate solution since nothing reli" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364289 (owner: 10Bartosz Dziewoński) [21:33:07] So I guess if there are are >0 results then you can check if there is a td.mw-enhanced-rc in there somewhere [21:33:30] Oh and the s do too [21:33:52] Confusingly we have both table.mw-enhanced-rc td and td.mw-enhanced-rc CSS rules [21:34:07] mooeypoo, can you just read the URL, but default to preferences? [21:34:28] Sounds like it could be done by DOM if the table has it though, though. Not sure which is better. [21:35:20] 10Collaboration-Team-Triage, 10Flow, 10OOjs-UI, 10VisualEditor: Inspector's popup handle misplaced when close to edge of surface in Flow+VE - https://phabricator.wikimedia.org/T166217#3288578 (10matmarex) If I had to guess, I would guess that somewhere, a `$container` config option for this PopupWidget is... [21:39:26] RoanKattouw, matt_flaschen (PS1) Mooeypoo: RCFilters: Respect ?enhanced=0 url regardless of preference [core] - https://gerrit.wikimedia.org/r/364328 [21:41:41] mooeypoo, looks good, testing now. [21:42:38] RoanKattouw, ok, so this is annoying DOM thing. non-enhanced is a
  • ..
and that stretches all the way across and covers the legend with color. The enhanced is a
...
...
which even though it's stretching across, the text stops and so the highlight wraps [21:42:53] I can give the legend a white background, which seems to fix it, but it doesn't actually look the same [21:42:58] I don't think we can make it wrap [21:45:04] The non-enhanced is a div that wraps table [21:45:24] so the table stops its flow before the floating div of the legend [21:45:29] I don't think we can do this for the
  • s [21:46:52] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Restore all default settings' starts the invite tour and highlight count on RC page - https://phabricator.wikimedia.org/T170210#3422907 (10Etonkovidova) [21:47:02] 10Collaboration-Team-Triage, 10Flow, 10OOjs-UI, 10VisualEditor: Inspector's popup handle misplaced when close to edge of surface in Flow+VE - https://phabricator.wikimedia.org/T166217#3422921 (10matmarex) This is `ve.ui.DesktopContext#popup`, I think. Setting a breakpoint in `OO.ui.PopupWidget.prototype.c... [21:47:14] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Inspector's popup handle misplaced when close to edge of surface in Flow+VE - https://phabricator.wikimedia.org/T166217#3422922 (10matmarex) [21:51:00] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10Patch-For-Review: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3422940 (10matmarex) (See also T128088 about moving the toolbar to the top.) [21:54:50] 10Collaboration-Team-Triage, 10Flow: Flow editing toolbar should be at the top of the edit window - https://phabricator.wikimedia.org/T128088#2063576 (10matmarex) I also think that bottom-positioned toolbars are a bad idea when combined with context menus that can't be closed. Consider this case, with a contex... [22:04:29] ha, we don't do color: white; in CSS? I thought white/black was acceptable [22:11:34] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3423018 (10Etonkovidova) Apparently, there is **a betalabs regression i... [22:31:50] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423056 (10jmatazzoni) [22:32:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: Shorten the label of "Saved filter settings" in the New filters for edit revie... - https://phabricator.wikimedia.org/T167876#3347786 [22:32:14] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423056 (10jmatazzoni) ===Questions/Issues - How can the tool usage numbers best be expressed? One nice way mi... [22:34:58] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Restore all default settings' starts the invite tour and highlight count on RC page - https://phabricator.wikimedia.org/T170210#3422907 (10Mattflaschen-WMF) Can be solved with UserResetAllOptions hook, and copying... [22:35:17] RoanKattouw, you might want to weigh in at T170210 . [22:35:17] T170210: 'Restore all default settings' starts the invite tour and highlight count on RC page - https://phabricator.wikimedia.org/T170210 [22:36:09] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3423100 (10matmarex) 05Open>03Resolved a:03Urbanecm The patch for the underlying bug was just deployed and I verifie... [22:36:14] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423106 (10jmatazzoni) [22:44:54] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423144 (10jmatazzoni) [22:50:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423159 (10jmatazzoni) a:03Catrope [22:58:06] (03PS1) 10Mattflaschen: Do not override other flags on enhanced recent changes [extensions/Flow] (wmf/1.30.0-wmf.7) - 10https://gerrit.wikimedia.org/r/364337 (https://phabricator.wikimedia.org/T169181) [23:02:52] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Flow] (wmf/1.30.0-wmf.7) - 10https://gerrit.wikimedia.org/r/364337 (https://phabricator.wikimedia.org/T169181) (owner: 10Mattflaschen) [23:04:53] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: 'Restore all default settings' starts the invite tour and highlight count on RC page - https://phabricator.wikimedia.org/T170210#3422907 (10Catrope) I agree there should definitely be a more general solution for unr... [23:08:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423194 (10jmatazzoni) [23:08:09] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3423193 (10jmatazzoni) [23:11:08] (03Merged) 10jenkins-bot: Do not override other flags on enhanced recent changes [extensions/Flow] (wmf/1.30.0-wmf.7) - 10https://gerrit.wikimedia.org/r/364337 (https://phabricator.wikimedia.org/T169181) (owner: 10Mattflaschen) [23:11:18] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10User-Ryasmeen: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3423219 (10Jdforrester-WMF) 05Open>03Resolved [23:11:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3423227 (10jmatazzoni) [23:11:40] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Get numbers for New Filters usage (and compare to baseline) - https://phabricator.wikimedia.org/T170214#3423226 (10jmatazzoni) [23:11:51] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3037306 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [23:19:30] mooeypoo, RoanKattouw, re https://gerrit.wikimedia.org/r/#/c/363103/: [23:19:45] 1. Does it affect behavior in production now with current feature flag values? [23:19:57] 2. Is there a prospect we'll turn on that feature flag before it rolls out normally? [23:20:39] I think we didn't enable namespaces in production yet because of the problem with double-results for tags [23:20:44] (and they're combined, namespaces+tags) [23:20:56] That's right [23:21:05] I have a WIP patch for that but that bug isn't fixed yet [23:21:10] So no we won't turn it on [23:21:19] mooeypoo: Then 363103 doesn't need SWATting right? [23:21:27] Probably not [23:21:32] mooeypoo: Also matt_flaschen thought you said something needed to be SWATted on Friday but we both forgot what it was [23:21:34] I mean, it's not enabled anywhere but beta [23:21:41] I wasn't there on Friday [23:22:17] But it's nice to know I was so missed! :D [23:22:45] The only thing I was talking about code-wise through the conference is the RTL/LTR css-issue and that isn't ready with a patch yet to SWAT anyways [23:22:54] I don't remember talking about anything else? [23:25:48] RoanKattouw, I said I thought you said it, I just can't remember what it was. [23:31:11] RoanKattouw, etonkovidova, separately, I'm seeing weird things with enhanced RC, Flow, and description (header). https://www.mediawiki.org/wiki/Special:RecentChanges?enhanced=1&hideliu=1&namespace=1 has Talk:Reading/Web/PDF Functionality with 1 change (so why is it even grouped) that lists 4 IPs (also a contradiction) [23:32:17] matt_flaschen: yeah ... Looking [23:33:02] WTF [23:33:07] And why are there empty headings [23:33:15] Is it failing to format a whole bunch of rows maybe? [23:33:22] O.o [23:39:38] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-Recent-changes: Enhanced (grouped) RecentChanges inconsistent for Flow header - https://phabricator.wikimedia.org/T170220#3423337 (10Mattflaschen-WMF) [23:40:00] matt_flaschen: Can you check in the DB if those edits are revdeleted or to deleted things or something? [23:40:29] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-Recent-changes: Enhanced (grouped) RecentChanges inconsistent for Flow header - https://phabricator.wikimedia.org/T170220#3423352 (10Mattflaschen-WMF) [23:40:52] ^ etonkovidova T170220 [23:40:53] T170220: Enhanced (grouped) RecentChanges inconsistent for Flow header - https://phabricator.wikimedia.org/T170220 [23:43:28] RoanKattouw, looking at all actions for the IPv6 user (since it's the second)