[06:37:32] (03PS36) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [06:37:59] (03PS14) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [06:38:15] (03PS2) 10Foxy brown: Due to team discussion - there is a need to keep the singular-plurale [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363175 [06:44:45] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [06:46:37] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [07:00:44] 10MediaWiki-Watchlist: Wrong relation to Wikidata changes on enhanced watchlist - https://phabricator.wikimedia.org/T169689#3405945 (10Fomafix) [07:05:32] (03PS37) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [07:05:48] 10MediaWiki-Watchlist: Wrong relation to Wikidata changes on enhanced watchlist - https://phabricator.wikimedia.org/T169689#3405969 (10Catrope) Hmm, @Mattflaschen-WMF and I noticed a bug on mw.org yesterday where groups of Flow edits had a `D` even though none of them were Wikidata edits, but it looks like this... [07:05:50] (03PS15) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [07:06:05] matt_flaschen: For when you wake up, https://phabricator.wikimedia.org/T169689#3405969 is interesting/weird [07:06:12] In a "the plot thickens" sort of way [07:07:08] Also we need a task for the mw.org version of the problem if we don't have one already [07:07:15] I didn't look too hard because it's midnight and I should go to sleep [07:15:59] 10MediaWiki-Watchlist: Wrong relation to Wikidata changes on enhanced watchlist - https://phabricator.wikimedia.org/T169689#3405990 (10Fomafix) [08:21:14] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter edits by languages in recent changes - https://phabricator.wikimedia.org/T164063#3406149 (10Pginer-WMF) Our model for advanced filters (T167384) allows to be extended. We can do the following: - Provide a "Languages" option in the advanced... [08:22:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter edits by languages in recent changes - https://phabricator.wikimedia.org/T164063#3406151 (10Pginer-WMF) [08:29:41] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: ?action=info incorrectly states that a new page is indexed when not - https://phabricator.wikimedia.org/T157747#3015151 (10TheDJ) I suspect the same problem might occur with blocked users btw. since we have {T13443}. [08:45:38] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review: Edits to Flow are marked as Wikidata edits in enhanced RC - https://phabricator.wikimedia.org/T169181#3406220 (10matej_suchanek) >>! In T169689#3405969, @Catrope wrote: > Hmm, @Mattflaschen-WMF and... [10:02:26] (03PS38) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [10:02:51] (03PS16) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [12:45:55] 10MediaWiki-Watchlist, 10Wikidata: Wrong relation to Wikidata changes on enhanced watchlist - https://phabricator.wikimedia.org/T169689#3407184 (10matej_suchanek) > The two changes on one Wikidata item are wrong related to two Wikipedia entries. What's //wrong//? Both pages are watching changes to [[ https://... [12:46:58] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter edits by languages in recent changes - https://phabricator.wikimedia.org/T164063#3407187 (10Trizek-WMF) >>! In T164063#3406149, @Pginer-WMF wrote: > Our model for advanced filters (T167384) allows to be extended. We can do the following: >... [13:40:45] 10Collaboration-Team-Triage, 10Wikimedia-Site-requests, 10User-Ladsgroup: Add WikiLove to CKB Wikipedia - https://phabricator.wikimedia.org/T169563#3407299 (10Ladsgroup) 05Open>03Resolved p:05Triage>03Low [15:10:19] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3407615 (10jmatazzoni) Making the current filter setting more prominent is a good idea. But I don't support getting rid of the label "Acti... [15:10:46] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3407621 (10jmatazzoni) a:03Pginer-WMF [15:11:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3386103 (10jmatazzoni) [15:16:44] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 10Patch-For-Review, 10User-notice-collaboration: Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3407644 (10jm... [15:19:21] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 10Patch-For-Review, 10User-notice-collaboration: Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3407649 (10jm... [17:04:38] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: "Group changes by page in recent changes and watchlist" and "Show Wikidata edits in recent changes" don't work when you use the Ne... - https://phabricator.wikimedia.org/T168643#3408254 [17:54:07] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Namespace filters do not work - https://phabricator.wikimedia.org/T169579#3408428 (10Etonkovidova) Checked the fix in betalabs. [18:01:54] RoanKattouw, matej_suchanek put up a patch for the Wikidata issue. I'll review and test after lunch: T169181 [18:01:55] T169181: Edits to Flow are marked as Wikidata edits in enhanced RC - https://phabricator.wikimedia.org/T169181 [18:02:40] (03CR) 10Catrope: [C: 031] Do not override other flags on enhanced recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362164 (https://phabricator.wikimedia.org/T169181) (owner: 10Matěj Suchánek) [18:02:44] aha [18:02:49] OK that looks totally plausible [18:02:56] And also unrelated to the other bug that I mentioned last night [18:03:41] Oh which turns out to not be a bug I guess [18:07:09] RoanKattouw, yeah, the other one just looks like arbitrary access (a Wikipedia article explicitly referencing a particular Wikidata item, not/in addition to its own item). I didn't actually check, but it's plausible. [18:34:15] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Namespace filters do not work - https://phabricator.wikimedia.org/T169579#3408581 (10jmatazzoni) 05Open>03Resolved [18:34:57] > You have been unsubscribed from the E2 mailing list [18:35:00] goodbye :( [18:51:27] Sorry :/ [18:51:49] I did some long-overdue membership cleanup on that list as part of making it into the team list for the new Global Collaboration team [19:37:02] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3408934 (10Etonkovidova) **QA Recommendation: Resolve** [19:43:22] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Integrate namespace and tag selectors into the filter menu - https://phabricator.wikimedia.org/T164130#3408966 (10Etonkovidova) [19:43:37] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Integrate namespace and tag selectors into the filter menu - https://phabricator.wikimedia.org/T164130#3222902 (10Etonkovidova) **QA Recommendation: Resolve** [19:53:31] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: When querying for multiple tags, and more than one is in the edit, duplicate results - https://phabricator.wikimedia.org/T168501#3409037 (10Mattflaschen-WMF) [19:53:34] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes, 10Patch-For-Review: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3409036 (10Mattflaschen-WMF) [19:53:36] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: When querying for multiple tags, and more than one is in the edit, duplicate results - https://phabricator.wikimedia.org/T168501#3366505 (10Mattflaschen-WMF) [19:53:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3409038 (10Mattflaschen-WMF) [19:54:05] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3311730 (10Mattflaschen-WMF) I added {T168501} as a blocker. This shouldn't... [20:18:13] 10MediaWiki-Recent-changes: [betalabs-regression] FF only - Delay in displaying highlight buttons - https://phabricator.wikimedia.org/T169799#3409141 (10Reedy) [20:26:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363422 (owner: 10L10n-bot) [20:27:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363428 (owner: 10L10n-bot) [20:35:22] (03PS2) 10Mattflaschen: Do not override other flags on enhanced recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362164 (https://phabricator.wikimedia.org/T169181) (owner: 10Matěj Suchánek) [20:45:20] (03CR) 10Catrope: [C: 032] Change "article" to "page" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363114 (owner: 10Amire80) [20:57:59] (03Merged) 10jenkins-bot: Change "article" to "page" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363114 (owner: 10Amire80) [20:58:22] (03CR) 10jenkins-bot: Change "article" to "page" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363114 (owner: 10Amire80) [21:09:01] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: When querying for multiple tags, and more than one is in the edit, duplicate results - https://phabricator.wikimedia.org/T168501#3366505 (10Etonkovidova) For testing after the fix: - One tag is selected... [21:10:03] I was getting a weird exception about our CategoryViewer::generateLink hook getting the wrong parameter (RevisionActionPermissions instead of Title). Can't reproduce anymroe. [21:22:16] (03CR) 10Mattflaschen: [C: 032] "Thanks, works locally." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362164 (https://phabricator.wikimedia.org/T169181) (owner: 10Matěj Suchánek) [21:24:00] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Flow, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review: Edits to Flow are marked as Wikidata edits in enhanced RC - https://phabricator.wikimedia.org/T169181#3409436 (10Mattflaschen-WMF) >>! In T169181#3406220, @matej_sucha... [21:30:23] YAy [21:32:04] (03Merged) 10jenkins-bot: Do not override other flags on enhanced recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362164 (https://phabricator.wikimedia.org/T169181) (owner: 10Matěj Suchánek) [21:34:35] (03CR) 10jenkins-bot: Do not override other flags on enhanced recent changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362164 (https://phabricator.wikimedia.org/T169181) (owner: 10Matěj Suchánek) [21:56:23] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10MediaWiki-General-or-Unknown, and 6 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3409537 (10Mattflaschen-WMF) [21:59:05] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10MediaWiki-General-or-Unknown, and 6 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3409560 (10Mattflaschen-WMF) I cleaned up the milestone formatting and dates without actually changing... [22:02:35] RoanKattouw, I noticed you have to hard-refresh (or refresh more than once) sometimes to test that. Not sure why. [22:04:25] To test what? [22:20:11] Ha I found a bug [22:20:22] I always feel so accomplished when I find a bug that etonkovidova didn't find :D [22:20:36] RoanKattouw: what?! [22:21:10] 1) Enable enhanced RC [22:21:13] 2) Go to Special:Recentchanges using a URL that returns zero results, e.g. https://www.mediawiki.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&urlversion=2&hideliu=1&userExpLevel=newcomer [22:21:26] 3) Change your filters so you do get results (e.g. by removing the "newcomer" filter) [22:21:35] 4) Expand/collapse arrows don't appear [22:21:49] RoanKattouw: hmm.... [22:21:51] But if you go to https://www.mediawiki.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&urlversion=2&hideliu=1 directly, they do appear [22:22:01] So it has to do with there being no results on the page when you first load the page [22:23:32] RoanKattouw: this Enhanced RC is such murky water... I would not be surprised that something else is lurking there [22:23:37] Yeah... [22:24:06] The Wikidata/enhanced interaction had a bug too, Matt and I found it last week and Matej fixed it today [22:24:59] RoanKattouw: right [22:27:46] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: [regression wmf.21] Safari only - filter capsules with highlight displayed misalgned - https://phabricator.wikimedia.org/T164308#3409649 (10Etonkovidova) Checked https://gerrit.wikimedia.org/r/... [22:47:46] I found it [22:48:56] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Provide default bookmarks for the most used sets of filters - https://phabricator.wikimedia.org/T167944#3409721 (10jmatazzoni) We need to accommodate the current "without saved filters"... [23:05:56] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech: PageTriageUtil::getTopTriagers() is not accurate - https://phabricator.wikimedia.org/T168335#3409782 (10DannyH) [23:16:56] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Category' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T163433#3409872 (10jmatazzoni) [23:16:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes: Explore how to make a category search that includes sub-categories. - https://phabricator.wikimedia.org/T158572#3409869 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni S... [23:32:55] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3409972 (10Mattflaschen-WMF) [23:33:51] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3409991 (10Mattflaschen-WMF) [23:34:44] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3409972 (10Mattflaschen-WMF) [23:34:57] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3409972 (10Mattflaschen-WMF) [23:35:25] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3409972 (10Mattflaschen-WMF) [23:36:22] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3410000 (10Mattflaschen-WMF) [23:37:02] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Enhanced RC expand/collapse arrows are not shown when starting from a conflict state - https://phabricator.wikimedia.org/T169835#3410005 (10Catrope) [23:37:05] 10Collaboration-Team-Triage, 10Notifications, 10Easy: Change EchoEvent->create to return Status or throw exceptions, never false - https://phabricator.wikimedia.org/T169834#3409972 (10Mattflaschen-WMF) [23:37:12] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Enhanced RC expand/collapse arrows are not shown when starting from a conflict state - https://phabricator.wikimedia.org/T169835#3410023 (10Catrope) a:03Catrope [23:38:20] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications: Article Reminder: Length validation for comment - https://phabricator.wikimedia.org/T169021#3410035 (10Mattflaschen-WMF) [23:39:12] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: Enhanced RC expand/collapse arrows are not shown when starting from a conflict state - https://phabricator.wikimedia.org/T169835#3410005 (10Catrope) [23:45:18] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: Enhanced RC expand/collapse arrows are not shown when starting from a conflict state - https://phabricator.wikimedia.org/T169835#3410048 (10Catrope) This was an interesting bug and I found it pr... [23:53:46] RoanKattouw, the enhanced RC thing (refreshing) [23:54:03] Great bug, right? [23:54:20] I facepalmed quite a bit when I realized why it wasn't working, but then I realized it was quite easy to fix in master [23:54:28] Less easy to fix in my pagination branch, working on that now [23:54:46] I found a way to do it that will make other things nicer actually [23:59:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MediaWiki-Recent-changes: Explore how to make a category search that includes sub-categories. - https://phabricator.wikimedia.org/T158572#3410082 (10Mattflaschen-WMF) Yes, I would say doable, but there...