[04:35:00] #trello [04:35:26] $ git status [04:35:36] $ set log [04:36:01] $ rtm.connect [04:36:18] $ status_text [06:14:37] (03PS9) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [06:23:19] (03CR) 10Foxy brown: [V: 031 C: 031] [WIP] Improve messages about page reminders [extensions/Echo] - 10https://gerrit.wikimedia.org/r/362798 (owner: 10Amire80) [06:24:14] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [06:44:35] (03PS10) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [08:53:32] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Epic, 10Tracking: [Epic] Wikidata watchlist improvements (client) - https://phabricator.wikimedia.org/T90435#3399928 (10Lydia_Pintscher) [15:03:34] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Blacklist UsersMultiselectWidget UI needs improvements - https://phabricator.wikimedia.org/T169384#3401155 (10TBolliger) [15:03:36] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3401156 (10TBolliger) [15:03:55] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401157 (10matmarex) Either the configuration is not being applied the way we expect, or the 'newbie... [15:06:46] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Change magnifying glass icon to hamburger in RC Filters search bar - https://phabricator.wikimedia.org/T166917#3401161 (10jmatazzoni) 05Open>03Resolved [15:08:34] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: RC filters - extra space/padding for previous 'Namespace' and 'Tag filter' opt... - https://phabricator.wikimedia.org/T168325#3401164 [15:11:45] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3401191 (10jmatazzoni) [15:11:47] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: Going back from "tagged edits" filter results in the filters panel ... - https://phabricator.wikimedia.org/T168855#3401190 [15:14:58] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401217 (10Dereckson) To debug the configuration, I'd apply two limits, one for user, the one we wan... [15:28:53] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401242 (10matmarex) I've read the code and it looks like the 'newbie' limit is totally ignored if a... [15:30:01] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401248 (10matmarex) >>! In T169268#3401217, @Dereckson wrote: > To debug the configuration, I'd app... [15:30:44] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3401249 (10jmatazzoni) There's something about this that I've been unco... [15:34:25] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401256 (10Urbanecm) >>! In T169268#3401251, @gerritbot wrote: > Change 363011 had a related patch s... [15:40:36] (03PS30) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [15:43:45] (03CR) 10Foxy brown: New Article Reminder API (0313 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [15:44:32] (03PS11) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [15:44:43] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [15:45:04] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Blacklist UsersMultiselectWidget UI needs improvements - https://phabricator.wikimedia.org/T169384#3401296 (10TBolliger) Should be done in conjunction with T166626 [15:46:04] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Audit all notification types to see if any more should be exceptions - https://phabricator.wikimedia.org/T166835#3401304 (10TBolliger) a:03TBolliger [15:48:23] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Audit all notification types to see if any more should be exceptions - https://phabricator.wikimedia.org/T166835#3401313 (10TBolliger) @Etonkovidova performed a full QA on all notifications types, and documented her find... [15:49:59] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3222818 (10TBolliger) Thanks, @Catrope and @Etonkovidova ! Can we enable t... [15:50:15] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401317 (10matmarex) Actually, that wil not work either, because 'autoconfirmed' is apparently speci... [15:51:21] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [15:54:34] (03PS31) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [16:03:47] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [16:06:33] (03PS32) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [16:08:42] (03PS12) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [16:32:41] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401582 (10Urbanecm) And is there better way how to do it? For example unsetting the user limit temp... [16:38:25] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3401619 (10matmarex) I think the only workaround is to lower the limit for all users. I proposed a p... [16:39:25] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page curation adds text to first deletion discussion page if it already exists - https://phabricator.wikimedia.org/T169441#3401622 (10GeoffreyT2000) [16:53:19] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 3 others: The language in MediaWiki:Echo-pref-notifications-blacklist could be improved - https://phabricator.wikimedia.org/T166626#3302346 (10Etonkovidova) Presently, it's: **Block list** **List of usernames that a... [16:54:36] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3401719 (10Etonkovidova) @Catrope - the functionality is working fine, howev... [17:06:27] mooeypoo: https://phabricator.wikimedia.org/T169384 -- Blacklist UsersMultiselectWidget UI needs improvements [17:14:09] (03CR) 10Mooeypoo: [C: 031] "@Amire80 if you remove "WIP" I'll +2. Thanks!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/362798 (owner: 10Amire80) [17:21:51] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/363037/ [17:26:12] RoanKattouw: Hi Roan [17:26:23] Hello [17:26:46] RoanKattouw: How're you doing? [17:27:08] Good! You? [17:27:20] I'm doing fine too [17:27:29] I wanted to enquire about: https://phabricator.wikimedia.org/T161732 [17:27:48] aha [17:28:05] 10Collaboration-Team-Triage, 10WikiLove, 10User-Ladsgroup: Add WikiLove to CKB Wikipedia - https://phabricator.wikimedia.org/T169563#3401831 (10Epine) [17:31:41] (03PS2) 10Amire80: Improve messages about page reminders [extensions/Echo] - 10https://gerrit.wikimedia.org/r/362798 [17:37:27] (03CR) 10Mooeypoo: [C: 032] "lgtm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/362798 (owner: 10Amire80) [17:47:53] etonkovidova, the fix for reverse tags should be on Beta in a few minutes [17:48:07] mooeypoo: thx! [17:50:37] 10Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Edit-Review-Improvements-ReviewStream, 10Scoring-platform-team, and 4 others: Automatically adjust ORES threshold settings when ORES models are updated - https://phabricator.wikimedia.org/T152161#3401935 (10awig... [17:51:05] 10Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Edit-Review-Improvements, 10Scoring-platform-team, 10editquality-modeling, 10artificial-intelligence: Research how to present ORES scores to users in a way that is understandable and meets their... - https://phabricator.wikimedia.org/T146333#3401945 [17:51:41] (03Merged) 10jenkins-bot: Improve messages about page reminders [extensions/Echo] - 10https://gerrit.wikimedia.org/r/362798 (owner: 10Amire80) [17:52:03] (03CR) 10Jdlrobson: [C: 032] "This was trying to remove a module that is now removed" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362469 (owner: 10Krinkle) [17:52:54] (03CR) 10jenkins-bot: Improve messages about page reminders [extensions/Echo] - 10https://gerrit.wikimedia.org/r/362798 (owner: 10Amire80) [17:55:02] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Nominating page at AfD does account for previous nominations - https://phabricator.wikimedia.org/T169567#3401987 (10MusikAnimal) [17:57:34] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Nominating page at AfD does account for previous nominations - https://phabricator.wikimedia.org/T169567#3401987 (10GeoffreyT2000) This was already filed as T169441, so I'm going to close this as a duplicate. [18:03:11] (03Merged) 10jenkins-bot: Remove no-op onSkinMinervaDefaultModules hook logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362469 (owner: 10Krinkle) [18:03:13] (03CR) 10jenkins-bot: Remove no-op onSkinMinervaDefaultModules hook logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362469 (owner: 10Krinkle) [18:07:17] TheDiscoverer: I'm in the middle of a complex patch right now, but I've downloaded moment 2.18.1 and I'll work on putting up a patch for it later today [18:07:43] We don't have a deployment train this week though, so the earliest it could be out is July 12th [18:08:47] RoanKattouw: No problem, thanks a lot, mate! :) [18:11:16] RoanKattouw: Actually, I was wondering whether Flow had moved on to using CLDR, and thats why moment wasn't updated [18:11:28] No :/ [18:11:30] But we should [18:11:41] Let me file a task for that if there isn't one already [18:11:44] No, please don't [18:12:12] I dont have the energy to localise it again [18:12:21] :D [18:18:33] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3402104 (10Catrope) [18:20:01] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3349982 (10Catrope) [18:27:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: "Mark all as read" button appears misplaced in Notifications panel - https://phabricator.wikimedia.org/T169019#3402116 (10Etonkovidova) 05Open>0... [18:30:31] RoanKattouw: Have you'll considered this: https://phabricator.wikimedia.org/T132027 ? [18:31:28] TheDiscoverer: Will add to the list [18:32:16] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3402122 (10Catrope) [18:42:39] RoanKattouw: Thanks, goodbye and have a nice day! [18:49:57] matt_flaschen: re using Blacklist UsersMultiselectWidget with no-JS - multiple user names for the Block list should be entered with what delimiter? [18:56:50] matt_flaschen: never mind [19:01:09] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 2 others: Blacklist UsersMultiselectWidget in preferences saves, loads, and renders properly with both no-JS and JS - https://phabricator.wikimedia.org/T166836#3309245 (10Etonkovidova) C... [19:06:18] 10Collaboration-Team-Triage, 10WikiLove, 10User-Ladsgroup: Add WikiLove to CKB Wikipedia - https://phabricator.wikimedia.org/T169563#3402221 (10Ladsgroup) Permanent link for the record: https://ckb.wikipedia.org/w/index.php?title=%D9%88%DB%8C%DA%A9%DB%8C%D9%BE%DB%8C%D8%AF%DB%8C%D8%A7:%D8%AF%DB%8C%D9%88%DB%95... [19:30:04] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3402273 (10Etonkovidova) @TBolliger Just a question: Restricting notificatio... [19:59:48] 10Collaboration-Team-Triage, 10WikiLove, 10Patch-For-Review, 10User-Ladsgroup: Add WikiLove to CKB Wikipedia - https://phabricator.wikimedia.org/T169563#3402329 (10Calak) Thank you @Ladsgroup. [20:00:33] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3402331 (10Catrope) >>! In T150419#3401314, @TBolliger wrote: > Thanks, @Cat... [20:13:39] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Namespace filters do not work - https://phabricator.wikimedia.org/T169579#3402407 (10Etonkovidova) [20:30:07] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3402454 (10Etonkovidova) [20:31:25] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3311730 (10Etonkovidova) [20:32:07] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3402461 (10Etonkovidova) The sorting order for Tags has been fixed. >The men... [20:33:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/363070 (owner: 10L10n-bot) [20:34:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/363074 (owner: 10L10n-bot) [20:39:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review, 10Regression: [betalabs-regression] RC page - blank names for filter selection can be saved - https://phabricator.wikimedia.org/T169273#3402497 (10Etonkovidova) Checked the fix in betalabs - e... [20:39:54] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review, 10Regression: [betalabs-regression] RC page - blank names for filter selection can be saved - https://phabricator.wikimedia.org/T169273#3402498 (10Etonkovidova) 05Open>03Resolved p:05Tria... [20:49:03] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3402514 (10Etonkovidova) [20:50:23] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3331374 (10Etonkovidova) - The tooltips have been implemented.... [20:55:43] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3402548 (10TBolliger) >>! In T150419#3402273, @Etonkovidova wrote: > @TBolli... [21:00:26] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: Don't make the advanced filters to float at the bottom of the filte... - https://phabricator.wikimedia.org/T168851#3378525 [21:06:01] 10Collaboration-Team-Triage, 10Thanks, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Mobile, 10Patch-For-Review: Thanks says "received your thanks", but there is no way to know - https://phabricator.wikimedia.org/T168589#3402590 (10Mattflaschen-WMF) >>! In T168589#3369402, @Mattflasch... [21:29:23] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3402638 (10Mattflaschen-WMF) >>! In T169108#3395016, @Lea_Lacroix_WMDE wrote: > Discussion on fr.wp that could be related to this problem (poke @Trizek-WMF )... [22:36:48] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10User-notice-collaboration: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3402720 (10jmatazzoni) [22:36:51] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: Don't make the advanced filters to float at the bottom of the filte... - https://phabricator.wikimedia.org/T168851#3402719 [23:11:55] 10Collaboration-Team-Triage: Preferences -Recent changes option "Group changes by page in recent changes..." should be updated - https://phabricator.wikimedia.org/T169589#3402773 (10Etonkovidova) [23:13:37] matt_flaschen: So I'm looking at a bug James_F reported where &hideWikibase=1 is ignored if &enhanced=1 but works if &enhanced=0 [23:13:55] It seems "obvious" that this should be related to https://gerrit.wikimedia.org/r/#/c/355799/ [23:14:06] Except now I'm reading the Wikibase RCF code and I don't understand it [23:14:32] For example, it creates $wikidataFilter = new ChangesListBooleanFilter( [ .... ] ); but then doesn't actually add $wikidataFilter anywhere, it only uses it for conflict registration [23:14:42] Does the constructor or the conflict stuff have side effects that end up registering the filter?! [23:14:52] The filter still appears, so something must be working there [23:15:09] But I can't figure out how [23:15:36] Similarly, they did a good job of abstracting the way enhanced is checked for such that their patch to remove it should have just worked, but it didn't [23:15:40] "Does the constructor or the conflict stuff have side effects that end up registering the filter?!" [23:15:41] Yes [23:15:47] Aha OK [23:15:53] So that explains that part of the mystery [23:16:06] Originally I didn't even require the group to construct the filter, then when I did I decided to auto-register it. [23:18:12] Hmm hold on a minute [23:18:15] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10MobileFrontend, 10I18n, and 2 others: the "Filter" message on notifications in mobile is not translatable - https://phabricator.wikimedia.org/T166860#3402791 (10jmatazzoni) 05Open>03Resolved [23:18:20] I think maybe the hiding works but the "D" flags are wrong [23:19:45] Hmm, no, that's not it either [23:20:42] RoanKattouw, before they just didn't register any Wikidata filters if enhanced was enabled. I agree it should work. Are you testing in prod/beta? [23:21:30] mw.org [23:22:10] OK so this is weird [23:22:15] hideWikibase does do /something/ [23:22:38] See https://www.mediawiki.org/wiki/Special:RecentChanges?hidebots=1&urlversion=2&highlight=1&hidenewpages=1&hidecategorization=1&hidelog=1&enhanced=1&changeType__hideWikibase_color=c5&hideWikibase=1 [23:23:00] It's hiding WB, and not highlighting anything, but there are rows with Ds [23:23:08] Not sure if the appearance of those Ds is a bug [23:23:27] If you set hideWikibase=0 more stuff appears that does get highlighted [23:23:46] RoanKattouw, I notice that patch also changed how Wikidata rows are highlighted. [23:23:51] Let me look at that part. [23:23:54] Oh and both of the false positives are Flow (!!) [23:24:16] How do you even get a D for a Flow edit/event [23:24:17] RoanKattouw, yeah, the new one is probably just wrong. [23:24:27] RecentChangeFactory::isWikibaseChange [23:24:40] Looking at the same edits in n non-enhanced mode, the Ds don't appear [23:25:00] + return $rc->getAttribute( 'rc_source' ) === self::SRC_WIKIBASE; [23:27:03] Hmm, yeah [23:28:49] RoanKattouw: https://phabricator.wikimedia.org/T169579 [23:29:16] RoanKattouw, only the groups are wrong, right? [23:29:24] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3402801 (10jmatazzoni) @Mooeypoo, pease fix the following: - In the Invert state, the button label c... [23:29:25] I.E. in enhanced it never wrongly shows D on a single row? [23:31:30] Exactly [23:31:39] It only shows D for groups of Flow changes [23:31:50] Which is obviously wrong and crazy [23:32:16] RoanKattouw, yeah, there's some code that changed how those rollups work, trying to find that patch and the current status. [23:32:59] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Namespace filters do not work - https://phabricator.wikimedia.org/T169579#3402805 (10Catrope) Not sure why @gerritbot didn't pick this up: https://gerrit.wikimedia.org/r/#/c/363103/ [23:33:20] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3402808 (10Catrope) >>! In T166912#3402801, @jmatazzoni wrote: > - The Namespaces filters don't work... [23:33:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), 10Patch-For-Review, 10User-notice-collaboration: Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3402810 (10jm... [23:34:09] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Namespace filters do not work - https://phabricator.wikimedia.org/T169579#3402812 (10Jdforrester-WMF) a:03Catrope [23:34:32] RoanKattouw, $wgRecentChangesFlags. It's supposed to just be set so the group shows D if all rows have it (this is configurable) (see WikibaseClient) [23:34:45] RoanKattouw, so either the general roll-up logic is wrong, or wikibase-edit is being wrongly set. [23:34:49] I think the second. [23:34:53] The second makes more sense [23:35:07] But why would that be happening, and why only in enhanced mode, and why for Flow changes <_< [23:36:42] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3402819 (10jmatazzoni) Re. the item above to change the button label, Moriel suggests we make it: -... [23:39:00] Also urrggh RecentchangesLinked uses a UNION query and that doesn't fit with the IndexPager / getQueryInfo() model [23:39:51] So I can either build support into Pager.php for getQueryInfo() to return an array of arrays, or override doMainQuery() in RecentChangesLinkedPager and do it there [23:40:03] I guess I'll go with the latter for now [23:40:52] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), 10Patch-For-Review: The 'back' button should go out of RCFilters and to the previous pa... - https://phabricator.wikimedia.org/T167919#3402836 [23:41:05] RoanKattouw, re the first, probably something about formatCommonDataForEnhancedLine (which contrary to suggesting only formatting also sets $data['recentChangesFlags']['wikibase-edit'] = true;) [23:41:12] Haven't found the wrong part yet, but still looking [23:41:15] WTF [23:41:28] Thanks for digging into that [23:42:56] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3402842 (10jmatazzoni) [23:42:58] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Explore designs for including filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3402843 (10jmatazzoni) [23:43:00] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: Replace "Tag filter" input with a dropdown+lookup widget in RCFilters - https://phabricator.wikimedia.org/T161650#3402841 (10jmatazzoni) 05Open>03Resolved [23:45:02] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Documentation: Write help documentation for Tagged Edits filtering of Recent Changes. - https://phabricator.wikimedia.org/T167740#3402858 (10jmatazzoni) [23:45:26] RoanKattouw, it's not as wrong as it looks (i.e. maybe not at all) since ChangesList/OldChangesList/EnhancedChangesList in core does both formatting and assignment (assignment in EnhancedChangesList->getLineData). [23:45:47] Which is also not great. [23:45:57] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3402860 (10jmatazzoni) [23:46:10] OK... as long as it happens conditionally with the right conditions I suppose [23:46:40] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3311730 (10jmatazzoni) I deleted the requirement in the Description to add t... [23:46:47] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint: PageTriageUtil::getTopTriagers() is not accurate - https://phabricator.wikimedia.org/T168335#3402865 (10DannyH) p:05High>03Normal [23:48:44] RoanKattouw, I'm just going to debug through and put breakpoints where wikibase-edit is set to true.