[00:02:14] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3349982 (10jeblad) Could it be possible to add a task for adding a topic to two or more flow boards? [00:29:55] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Regression: [betalabs-regression] RC page - blank names for filter selection can be saved - https://phabricator.wikimedia.org/T169273#3393106 (10Mooeypoo) This shouldn't happen anymore, can you re-check? The "App... [00:31:13] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: [wmf.7] RC filers - the loudspeaker icon is missing in RTL wikis - https://phabricator.wikimedia.org/T169271#3393550 (10Mooeypoo) a:03Catrope [02:04:40] (03PS5) 10Catrope: Improve UI for blacklist preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/354695 (https://phabricator.wikimedia.org/T150419) (owner: 10MtDu) [02:04:46] (03CR) 10Catrope: [C: 032] Improve UI for blacklist preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/354695 (https://phabricator.wikimedia.org/T150419) (owner: 10MtDu) [02:42:34] 10Collaboration-Team-Triage, 10Notifications, 10OOjs-UI: Clarify appropriate use of 'pending' background texture - https://phabricator.wikimedia.org/T168760#3393711 (10Volker_E) p:05Triage>03Low [04:43:55] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3393795 (10Urbanecm) p:05Triage>03High [05:43:53] (03PS18) 10Foxy brown: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [05:59:18] (03PS28) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [06:16:38] (03PS29) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [06:26:28] (03PS7) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [06:35:25] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [09:05:23] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3394126 (10Elitre) From description: "If some improvements are done to fit demands expressed by users concerning"... then what? [12:09:44] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-General-or-Unknown, 10MediaWiki-Platform-Team, and 3 others: Drop requirement to define a talk namespace for every subject namespace - https://phabricator.wikimedia.org/T165149#3394683 (10daniel) This RFC has been approved for implementation after the final... [12:44:12] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3394859 (10Urbanecm) a:03Urbanecm I'll create a patch and schedule it for deployment, it looks reasonable. [12:50:38] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3394914 (10Urbanecm) The patch would restrict thanking to 3 thanks per one day. The value can be edi... [12:55:19] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3394920 (10Urbanecm) The patch can be deployed this Wednesday between 15:00-16:00 CEST (13:00-14:00... [13:23:56] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3395016 (10Lea_Lacroix_WMDE) Discussion on fr.wp that could be related to this problem (poke @Trizek-WMF ) https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bis... [14:17:21] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks like this should have gotten merged? It has a dependency, but it is merged already. Let's try agian." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/354695 (https://phabricator.wikimedia.org/T150419) (owner: 10MtDu) [14:31:15] (03Merged) 10jenkins-bot: Improve UI for blacklist preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/354695 (https://phabricator.wikimedia.org/T150419) (owner: 10MtDu) [14:36:23] (03CR) 10jenkins-bot: Improve UI for blacklist preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/354695 (https://phabricator.wikimedia.org/T150419) (owner: 10MtDu) [16:31:14] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: [wmf.7] RC filers - the loudspeaker icon is missing in RTL wikis - https://phabricator.wikimedia.org/T169271#3395502 (10Etonkovid... [16:37:17] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Regression: [betalabs-regression] RC page - blank names for filter selection can be saved - https://phabricator.wikimedia.org/T169273#3395522 (10Etonkovidova) @Mooeypoo Re-checked -the issue is still present in b... [16:42:04] (03PS8) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [16:45:49] (03PS19) 10Foxy brown: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [16:47:31] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3395542 (10Wpedzich) Highly appreciated. We've been facing various Wikinger-activity, of which thank... [16:50:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review, 10Regression: [betalabs-regression] RC page - blank names for filter selection can be saved - https://phabricator.wikimedia.org/T169273#3395552 (10Mooeypoo) a:03Mooeypoo Oy, sorry, when we c... [16:51:44] (03CR) 10Mattflaschen: [C: 032] "Congratulations on getting your first Gerrit patch merged!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [16:52:36] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [16:58:09] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3392756 (10Framawiki) @Wpedzich Note that if you absolutely wants to deploy this change quickly, bef... [17:00:26] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3395576 (10Urbanecm) For record: I've asked for emergency deploy at #wikimedia-operations. [17:01:17] (03Merged) 10jenkins-bot: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [17:01:19] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3395580 (10Wpedzich) I do not want to put pressure on things, but having the change deployed earlier... [17:01:29] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3395583 (10Urbanecm) Sorry, I've misread the last commend. I'll add it to the regular calendar inste... [17:02:33] (03CR) 10jenkins-bot: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [17:13:45] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3395600 (10Catrope) This is now ready, except that @Mattflaschen-WMF points... [17:23:11] (03PS8) 10Catrope: generate metadata dumps as first pass, rev text as second pass dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) (owner: 10ArielGlenn) [17:23:13] (03PS3) 10Catrope: Clean up illegal chars in revision text retrieved during flow content dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362173 (https://phabricator.wikimedia.org/T167456) (owner: 10ArielGlenn) [17:23:39] (03CR) 10Catrope: "PS8: Resolved rebase conflict" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) (owner: 10ArielGlenn) [17:24:07] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications: Create the API skeleton and properly define it - https://phabricator.wikimedia.org/T167450#3395645 (10Mattflaschen-WMF) [17:25:12] (03CR) 10Catrope: [C: 04-1] "-1 for [WIP] in the commit summary and dependency on an unmerged commit in core." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) (owner: 10ArielGlenn) [17:27:34] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10Patch-For-Review, and 2 others: create a gater for this feature (feature flag) - https://phabricator.wikimedia.org/T165755#3395646 (10Mattflaschen-WMF) 05Open>03Resolved [17:31:31] (03PS9) 10Catrope: generate metadata dumps as first pass, rev text as second pass dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) (owner: 10ArielGlenn) [17:33:28] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10MediaWiki-General-or-Unknown, and 6 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3395651 (10Mattflaschen-WMF) [17:34:34] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications, 10Patch-For-Review, and 2 others: create new notification type for the article reminder - https://phabricator.wikimedia.org/T165754#3395649 (10Mattflaschen-WMF) 05Open>03Resolved >>! In T165754#3299234, @Mattflaschen-WMF wr... [17:39:52] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3395657 (10Mattflaschen-WMF) [17:40:40] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3362850 (10Mattflaschen-WMF) [17:44:55] 10Collaboration-Team-Triage, 10Flow, 10Dumps-Generation, 10Patch-For-Review: Make flow dumps run faster - https://phabricator.wikimedia.org/T164262#3395676 (10Mattflaschen-WMF) >>! In T164262#3307998, @ArielGlenn wrote: > While I sort out that sort of post id stack I'm going to need to keep in order to mak... [17:45:02] 10Collaboration-Team-Triage, 10Flow, 10Dumps-Generation, 10Patch-For-Review: Make flow dumps run faster - https://phabricator.wikimedia.org/T164262#3395693 (10ArielGlenn) >>! In T164262#3395676, @Mattflaschen-WMF wrote: >>>! In T164262#3307998, @ArielGlenn wrote: >> While I sort out that sort of post id st... [17:54:15] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10OOjs-UI, 10Design: RC filters doesn't look so good outside of Vector/WikimediaUI - https://phabricator.wikimedia.org/T168761#3376063 (10Etonkovidova) There were some updates to design the screenshots are from betalabs: Chrome 59... [18:01:36] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 4 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3395766 (10Mattflaschen-WMF) >>! In T150419#3395600, @Catrope wrote: > This... [18:55:52] 10Collaboration-Team-Triage, 10Flow: Disable or hide reply form for anonymous users when the thread is resolved - https://phabricator.wikimedia.org/T168709#3374330 (10Etonkovidova) For a logged in user, no reply form will be displayed: Compare - a logged in user {F8582136} Anon user: {F8582139} [19:24:38] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: "Mark all as read" button appears misplaced in Notifications panel - https://phabricator.wikimedia.org/T169019#3384546 (10Etonkovidova) Checked the... [19:34:51] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3395967 (10Urbanecm) I'll talk with the others and we'll see if it would be deployed. Watch the task! [20:02:06] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/362318/ <-- i copied the text from the task... [20:02:26] RoanKattouw, also, https://gerrit.wikimedia.org/r/#/c/362436 oops [20:18:00] (03Merged) 10jenkins-bot: Fix Thanks messages not say "received your thanks" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/360785 (https://phabricator.wikimedia.org/T168589) (owner: 10Mattflaschen) [20:49:08] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.8)), 10Patch-For-Review: For some languages (here French), the label to save a set of filters is not al... - https://phabricator.wikimedia.org/T169110#3396098 [21:00:16] (03PS1) 10Krinkle: Remove no-op onSkinMinervaDefaultModules hook logic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362469 [21:27:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362515 (owner: 10L10n-bot) [22:10:00] (03CR) 10Catrope: [C: 031] "LGTM but I don't know anything about the MF/Minerva side of this" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/362469 (owner: 10Krinkle) [22:27:16] meh, I have some sort of race condition in uriProcessor preventing the initial state of limit= to be registered. Frustrating... but I think I'll leave that part to Monday so I can harassutilize RoanKattouw's debugging skills. [22:27:37] I'm going to implement days= first too, since it's almost the same as limit= and will suffer the same race condition [22:28:00] RoanKattouw, however, this makes me worry there's another issue with the way I initialized/loaded the defaults in the controller [22:28:02] AGAIN. [22:28:04] * mooeypoo cries [22:29:07] To be fair, it's a completely different group type ('hidden') so it's not surprising ,but it's definitely frustrating. I think I need to split the hidden defaults from the "regular" defaults, if only because I have load pathways that don't use defaults because we assumed "defaults" only involve "regular" filters (no namespace/tags/hidden/etc) [22:31:52] * RoanKattouw catches up [22:32:22] I share your concern that there's something wrong if you're getting bugs like these [22:34:31] But yes, these defaults are also a different kind of defaults so maybe the issue is that that distinction isn't fleshed out well enough yet [22:44:58] Yeah I think the assumption that we only need the "base" defaults is the cause here, it influenced a bunch of "where we load defaults" decisions [22:48:15] 10Collaboration-Team-Triage, 10Flow, 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-Scribunto: Error: invalid magic word 'invoke' when running rebuildLocalisationCache.php with Scribunto and Flow installed - https://phabricator.wikimedia.org/T169373#3396447 (10Florian) [22:53:38] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety: Blacklist UsersMultiselectWidget UI needs improvements - https://phabricator.wikimedia.org/T169384#3396478 (10Etonkovidova) [22:59:26] 10Collaboration-Team-Triage, 10Support-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Urbanecm: Limiting thanks for new users at pl.wikipedia - https://phabricator.wikimedia.org/T169268#3396494 (10Legoktm) I'm deploying the rate limit patch with the expectation that this is a temporary... [23:54:45] RoanKattouw, can you remind me of the terminal command to validate php files? I get a mysterious "syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ']'" and I suspect it's Resources.php but I can't find it [23:54:58] php -l filename [23:55:07] I mean, it really can't be any other file, seeing as the only other files I edited are JS or .json [23:55:07] Does not take multiple files sadly [23:56:36] got it. Thanks!