[00:29:06] jdlrobson, you have no equivalent in a button group, you need to aggregate yourself, so if you had this.buttonGroup = new OO.ui.ButtonGroupWidget( ... ); [00:29:20] you do this.buttonGroup.aggregate( { click: 'buttonClick' } ); [00:29:21] and then [00:29:35] this.buttonGroup.connect( this, { buttonClick: 'onButtonClick' } ); [00:29:50] The ButtonSelectWidget does this for you, but you need to aggregate on your own if you switch to a group [00:31:02] jdlrobson, also, if you want a single-selection on click, you'll have to create the logic of setting button.setActive( ... ) on your own with the button group -- these are the things you get for "free" with buttonSelectWidget [05:19:58] (03PS15) 10Foxy brown: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [08:15:02] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: RC filters broken on beta: Property "onPopupToggle" is not a function - https://phabricator.wikimedia.org/T169037#3385281 (10Schnark) [08:41:02] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make icons size more consistent for Recent Changes filters - https://phabricator.wikimedia.org/T168835#3385356 (10Pginer-WMF) >>! In T168835#3380738, @Catrope wrote: > (Please confirm the icons fit in 17.5px boxes; if they do, we can c... [09:30:48] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: The dialog to save filters on Recent Changes needs adjustments to better communicate the initial status - https://phabricator.wikimedia.org/T169042#3385552 (10Pginer-WMF) [09:44:38] (03PS1) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [09:44:48] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [09:50:51] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Allow to view only one "what's this" popup at a time on the filters panel - https://phabricator.wikimedia.org/T169047#3385652 (10Pginer-WMF) [09:52:59] (03PS16) 10Foxy brown: new notification type was added and works with feature flag (enables=false) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [09:53:02] (03PS23) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [09:54:47] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [09:56:59] (03CR) 10jerkins-bot: [V: 04-1] new notification type was added and works with feature flag (enables=false) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [09:57:57] (03PS24) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [10:04:32] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [10:09:47] (03PS25) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [10:10:43] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10Tracking: 'Integrated filters'—add all RC Page filters into the new UI along with selected new functions - https://phabricator.wikimedia.org/T162675#3385723 (10Pginer-WMF) [10:10:45] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3385722 (10Pginer-WMF) [10:17:05] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [10:19:10] (03PS26) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [10:23:32] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Improve the language of the "What's this?" links in the filters panel on Recent Changes - https://phabricator.wikimedia.org/T169053#3385768 (10Pginer-WMF) [10:34:52] (03PS17) 10Foxy brown: new notification type was added and works with feature flag (enables=false) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [10:34:54] (03PS27) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [10:34:57] (03PS2) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [10:36:49] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [10:39:46] (03CR) 10jerkins-bot: [V: 04-1] new notification type was added and works with feature flag (enables=false) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [10:40:49] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [10:44:26] (03PS3) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [10:45:24] (03PS4) 10Foxy brown: Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) [10:49:03] (03CR) 10jerkins-bot: [V: 04-1] Article Reminder UI button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361840 (https://phabricator.wikimedia.org/T168387) (owner: 10Foxy brown) [11:11:01] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make the initial state of saved filters more actionable - https://phabricator.wikimedia.org/T169055#3385842 (10Pginer-WMF) [12:04:08] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3386103 (10Pginer-WMF) [12:04:38] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make saved filters title more prominent when applied - https://phabricator.wikimedia.org/T169063#3386103 (10Pginer-WMF) [13:06:42] 10Collaboration-Team-Triage, 10Flow: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3386372 (10Trizek-WMF) [13:06:54] 10Collaboration-Team-Triage, 10Flow: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3386385 (10Trizek-WMF) p:05Triage>03High [14:40:08] 10Collaboration-Team-Triage, 10Flow: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3386372 (10Etonkovidova) Yes, betalabs displays the same issuse for the link and mention inspectors. {F8547935} [14:48:33] 10Collaboration-Team-Triage, 10Flow: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3386372 (10matmarex) Probably my changes from T167616 caused this :( [15:12:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: RC filters broken on beta: Property "onPopupToggle" is not a function - https://phabricator.wikimedia.org/T169037#3387121 (10Trizek-WMF) 05Open>03Resolved a:03Mooeypoo It has been fixed: https://gerrit.wikimedia.org/r/#/c/361823/ [15:15:08] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic, 10User-notice-collaboration: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3387148 (10Trizek-WMF) I'm adding #user-notice-collaboration to let people know we did those a... [15:46:45] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: [regression] Can't remove a saved filter - https://phabricator.wikimedia.org/T169107#3387291 (10Trizek-WMF) [15:48:53] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make the initial state of saved filters more actionable - https://phabricator.wikimedia.org/T169055#3385842 (10Trizek-WMF) What about opening the saving form instead? [16:01:19] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3387353 (10Trizek-WMF) [16:09:00] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: FOr some languages (here French), the label to save a set of filters is not aligned with the icons - https://phabricator.wikimedia.org/T169110#3387410 (10Trizek-WMF) [16:09:08] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: For some languages (here French), the label to save a set of filters is not aligned with the icons - https://phabricator.wikimedia.org/T169110#3387423 (10Trizek-WMF) [17:18:48] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: The dialog to save filters on Recent Changes needs adjustments to better communicate the initial status - https://phabricator.wikimedia.org/T169042#3387696 (10Pginer-WMF) [17:19:21] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3387699 (10Trizek-WMF) [17:20:44] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Allow filtering by date range in page curation - https://phabricator.wikimedia.org/T167475#3387703 (10TonyBallioni) Putting this in here, but @MrX has requested that "please make it easy to use, with a slider or at least a calendar widget. It sh... [17:25:09] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3387725 (10Trizek-WMF) [17:25:12] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Allow filtering by no citations in page curation - https://phabricator.wikimedia.org/T169120#3387726 (10TonyBallioni) [17:25:23] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3387353 (10Mattflaschen-WMF) It only has that one checkbox in Type of change? That URL ( https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Modifications_r%C3%A9cent... [17:27:21] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3387746 (10Trizek-WMF) I've been editing the task while you were replying, to add: if the "Wikidata edits" option is not selected, I expect to have no Wikidat... [17:45:03] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: The dialog to save filters on Recent Changes needs adjustments to better communicate the initial status - https://phabricator.wikimedia.org/T169042#3387807 (10Mooeypoo) a:03Mooeypoo [17:49:42] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: For some languages (here French), the label to save a set of filters is not aligned with the icons - https://phabricator.wikimedia.org/T169110#3387829 (10Mooeypoo) a:03Mooeypoo [18:13:38] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3387889 (10thiemowmde) p:05Triage>03Normal [18:47:45] 10MediaWiki-Recent-changes, 10Wikidata: Wikidata items are always visible in Recent Changes, filtered or not - https://phabricator.wikimedia.org/T169108#3388021 (10Mattflaschen-WMF) We discussed this in detail as a team. For the specific issue, I suspect that a setup with "Show Wikidata" (and showing all type... [19:01:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Clarify the deprecation of RC-related settings to affected users - https://phabricator.wikimedia.org/T168620#3370112 (10Mattflaschen-WMF) We may not want to remove them entirely as long as the new RC filters can be off. We can also hi... [19:17:27] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Clarify the deprecation of RC-related settings to affected users - https://phabricator.wikimedia.org/T168620#3388144 (10Mattflaschen-WMF) p:05Triage>03High The current state is confusing for users. See e.g. (I think) {T169108} [19:20:58] 10Collaboration-Team-Triage, 10Flow, 10TextExtracts, 10Patch-For-Review, and 3 others: Flow: Data Model JavaScript, including tokens, appears in TextExtracts and HoverCards - https://phabricator.wikimedia.org/T107170#3388184 (10Mattflaschen-WMF) [19:33:12] 10Collaboration-Team-Triage, 10Flow: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3388235 (10Etonkovidova) To check after the fix: since it's possible to do VE insert in Flow via cmd+?, the following needs to be checked. (1) In Flow post, do additional checking for some... [19:35:47] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Possibly confusing to show isolated unchecked checkbox, even though those edits are shown - https://phabricator.wikimedia.org/T169131#3388249 (10Mattflaschen-WMF) [19:50:51] 10MediaWiki-Recent-changes, 10Documentation: Update documentation about enhanced changes - https://phabricator.wikimedia.org/T169119#3388335 (10matej_suchanek) a:05matej_suchanek>03None [19:51:06] 10MediaWiki-Recent-changes, 10Documentation: Update documentation about enhanced changes - https://phabricator.wikimedia.org/T169119#3387708 (10matej_suchanek) p:05High>03Triage [20:22:09] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-LoginNotify, 10MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), and 3 others: Fatal error: Class undefined: LoginNotifyPresentationModel in extensions/Echo/includes/formatters... - https://phabricator.wikimedia.org/T168899#3388428 [20:22:24] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-LoginNotify, 10MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), and 3 others: Fatal error: Class undefined: LoginNotifyPresentationModel in extensions/Echo/includes/formatters... - https://phabricator.wikimedia.org/T168899#3388434 [20:34:07] RoanKattouw, https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP#.40var:_documenting_class_members apparently stopped being a bug (the thing with repeating $fieldName). [20:34:10] Weird. [20:34:17] I don't even remember updating Doxygen. [20:49:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361978 (owner: 10L10n-bot) [20:50:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361983 (owner: 10L10n-bot) [21:14:14] mooeypoo, VE apparently messed up the conflict markers again. [21:14:52] (03CR) 10Kaldari: Add user right expiry notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350500 (https://phabricator.wikimedia.org/T153817) (owner: 10MaxSem) [21:14:55] VisualStudio I mean [21:15:05] Somehow the changes don't actually save to the file. I think this happened last time too: https://gerrit.wikimedia.org/r/#/c/357847/27/extension.json [21:17:25] meh [21:17:52] Yesterday we were searching for those at the end on purpose [21:18:03] I think VisualStudio ignores it on 'find' though, unhelpfully [21:22:10] Yeah [21:23:21] mooeypoo, yeah, I don't know why it doesn't work, it's not like we're doing anything weird. There are other better diff tools like kdiff3, though. [21:33:37] Yeah [21:33:49] I personally do these manually, especially when they're so straight-forward, but yeah [21:42:05] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: For some languages (here French), the label to save a set of filters is not aligned with the icons - https://phabricator.wikimedia.org/T169110#3387410 (10Etonkovidova) Related to {T168413}. [21:44:59] mooeypoo, maybe VisualStudio requires you to commit through their UI for it to work. I'm not sure we tried that. It should work fine in theory. [22:13:54] matt_flaschen, the annoying thing is that we searched through the files after we did it :\ [22:14:42] matt_flaschen, also, I think part of the issues we're seeing with her git stuff is that she's not pulling from gerrit at all -- she always works locally, and while that's usually fine, I think in some cases there's potential to make weird commit mistakes that then don't fit gerrit's commit IDs, etc [22:15:22] mooeypoo, yeah, I'm not surprised. I saw the UI earlier. It's pretty heavily, "don't worry, we'll handle this part", not just syntax-highlighting. [22:16:36] mooeypoo, shouldn't happen. I've done that sometimes (amending the original branch, instead of the review/mattflaschen/whatever one, and not always updating). It might cause you to clobber someone's work if you're not careful, don't see how it would cause these git issues. [22:16:56] mooeypoo, I think it's just she's used to a different git workflow. It's understandable, ours is pretty weird. [22:18:39] mooeypoo, there aren't that many weird issues. Mostly I know what happened, and the past ones are solved (e.g. committing instead of amending). [23:32:34] On Preferences > Notifications, there's a bunch of notifications with either Web or Email checkboxes disabled. Where can I set that in my extension for a notification I am creating? I did a lot of searching but didn't find anything relevant. [23:33:10] mooeypoo: is it intentional that testwiki and cawiki wmf.7 display non-functional Tag and Namespace filters options? And the previous (and functioning) filter options are present there too [23:37:02] Niharika: AFAICT it comes from the "NotifyTypeAvailabilityByCategory" setting [23:37:45] Niharika: Also, you might find https://en.wikipedia.org/wiki/Special:DisplayNotificationsConfiguration helpful [23:38:37] etonkovidova: No that is not intentional, looking [23:38:52] RoanKattouw: ok [23:39:23] Oh the footer buttons [23:39:29] mooeypoo just cursed a bunch, she's going to fix it nwo [23:40:07] RoanKattouw: Thank you. [23:40:40] RoanKattouw: Do you know if the "failed mention" and "successful mention" notifications are created in Echo itself or some other extension? [23:41:04] 10Collaboration-Team-Triage, 10Flow, 10VisualEditor: Flow toolbar overlaps with mention search - https://phabricator.wikimedia.org/T169076#3389182 (10Catrope) Looks like this is a bug with VisualEditor's bottom toolbar support [23:41:13] I believe they're in Echo but behind a config setting [23:41:13] Just to be clear, I'm not going to fix it *just* by cursing a bunch. [23:41:18] I do have a strategy. [23:41:25] ... That involves actual code. [23:41:28] "EchoMentionStatusNotifications": { [23:41:28] "value": false [23:41:37] Gotcha. [23:45:55] etonkovidova, is there a bug for that? [23:46:05] mooeypoo: a sec [23:46:30] * mooeypoo has a patch ready [23:46:52] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [wmf.7] The new advanced filters 'Namespaces' and 'Tagged edits' displayed with old filter options - https://phabricator.wikimedia.org/T169163#3389192 (10Etonkovidova) [23:47:03] mooeypoo: https://phabricator.wikimedia.org/T169163v [23:47:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: [wmf.7] The new advanced filters 'Namespaces' and 'Tagged edits' displayed with old filter options - https://phabricator.wikimedia.org/T169163#3389209 (10Mooeypoo) a:03Mooeypoo Whoops. Sorry...