[00:00:32] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Shorten the label of "Saved filter settings" in the New filters for edit review - https://phabricator.wikimedia.org/T167876#3380961 (10Catrope) a:03Catrope >Is confusing about the scope of what is saved, since view options such as the paginatio... [00:02:08] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: Shorten the label of "Saved filter settings" in the New filters for edit review - https://phabricator.wikimedia.org/T167876#3380968 (10Catrope) [00:04:19] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Use standard round corners for advanced filters buttons on the filters panel - https://phabricator.wikimedia.org/T168849#3380971 (10Catrope) This is because these buttons are in a ButtonGroup, which normal... [00:09:03] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Connect better the advanced filters with the main filter entry point on Recent Changes - https://phabricator.wikimedia.org/T168845#3380975 (10Catrope) [00:11:25] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Don't make the advanced filters to float at the bottom of the filters panel - https://phabricator.wikimedia.org/T168851#3380978 (10Catrope) [00:18:49] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters: Don't make the advanced filters to float at the bottom of the filters panel - https://phabricator.wikimedia.org/T168851#3380982 (10Mooeypoo) a:03Mooeypoo [00:23:42] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [wmf.5] The invite opt-in popup does not accommodate some languages - https://phabricator.wikimedia.org/T168413#3363843 (10Catrope) It took me a while to spot this: the buttons overflow out of the dialog because of h... [00:29:32] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC filters - extra space/padding for previous 'Namespace' and 'Tag filter' options is preserved - https://phabricator.wikimedia.org/T168325#3361215 (10Mooeypoo) Just to verify something -- those two lines may actual... [00:30:21] 10Collaboration-Team-Triage, 10Notifications, 10MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), 10Patch-For-Review: Echo uses FloatingMenuSelectWidget which is deprecated - https://phabricator.wikimedia.org/T168679#3381005 (10Catrope) 05Open>03Resolved a:03Catrope [00:37:58] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Patch-For-Review: RC filters - extra space/padding for previous 'Namespace' and 'Tag filter' options is preserved - https://phabricator.wikimedia.org/T168325#3381012 (10Mooeypoo) a:03Mooeypoo [00:41:25] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3354065 (10Mooeypoo) @Pginer-WMF question that will affect implementation: What happens if there are no results? Can we... [00:44:00] Hey! I'm gonna bug someone here with a frontend question. I can't understand what Jenkins is complaining about on https://gerrit.wikimedia.org/r/#/c/361600/. I'm adding some simple JS & CSS. It seems to not be able to find the element IDs somehow. [00:47:05] (03CR) 10Mattflaschen: [C: 04-1] "Unfortunately, I missed an important issue with the feature flag earlier. Sorry about that." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [00:57:15] Niharika, I believe ID selectors are just banned from the CSS (IDs are problematic both since you might later want more than one per page, and because they're so specific they can be hard to override) [00:57:31] Niharika, you can use class selectors instead, though you may need to add them to the DOM. [00:58:58] See also https://github.com/CSSLint/csslint/wiki/disallow-ids-in-selectors . [00:59:14] And https://specificity.keegan.st/ is a good reference for CSS specificity. [01:03:21] matt_flaschen: Thanks! [01:09:23] Niharika: We turn off the disallow-ids-in-selectors rule in a lot of repos because you often do need ID selectors when touching MediaWiki skin stuff; but generally, you should prefer classes over IDs [01:10:19] Gotcha. I was thrown off by this because I had seen ID selectors before in a bunch of places. [01:10:26] Certainly, if you do have a reason for having an ID for the popup, you should use one ID and have everything else descend from that, so like #codemirror-popup .foo-bar { ... } instead of #codemirror-popup-foo-bar { ... } [01:10:52] Won't it still give me an error? [01:11:10] Yes, but you can either disable the rule repo-wide or put in a comment that disables that rule for one line [01:11:23] Got it. Thank you! [01:11:57] Also, you should prefix your class names with mw- or codemirror- or something. popup-top isn't a great class name because it's very easy for someone else to (legitimately) write code that uses that class name for something completely different [01:12:26] Yeah, good point. I'll change that. [01:12:32] Scoping like #codemirror-popup .popup-top helps, but only if the other party does it too. Prefixing is more robust [01:12:42] Also if you use LESS that makes a lot of this stuff easier [01:13:40] Because it'll let you write stuff like .foo { .bar { ... } .baz { ... } } instead of .foo .bar { ... } .foo .baz { ... } as well as .codemirror-popup { &-top { ... } &-bottom { ... } } instead of .codemirror-popup-top { ... } .codemirror-popup-bottom { ... } [01:14:02] I believe this is fully integrated into MW now to the point where you just have to give the file a .less extension instead of .css and it should magically start working [01:14:44] Nice. I'll try that. :) [01:15:10] Niharika: I'm still confused as I don't see any ID selectors in your CSS [01:15:17] kaldari: The previous patchset had them [01:15:25] Yeah. [01:15:45] Ah, I guess I was looking at the wrong one [01:15:48] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 3 others: Ping Johan and Translators mailing list about Echo Notifications blacklist strings - https://phabricator.wikimedia.org/T168902#3381066 (10Johan) Ready to be pinged. (: [01:16:01] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, 10MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)): Ping Johan and Translators mailing list about Echo Notifications blacklist... - https://phabricator.wikimedia.org/T168902#3381067 [01:17:08] I was confused about that at first too [01:17:13] Oh also, this reminds me [01:17:24] mooeypoo wrote this wonderful (ab)use of LESS last week: https://gerrit.wikimedia.org/r/#/c/359083/6/resources/src/mediawiki.rcfilters/styles/mw.rcfilters.ui.MenuSelectWidget.less@30 [01:18:55] :D Ha [01:19:13] I'll look into using Less tomorrow. Should be fun. [02:59:15] (03CR) 10Mattflaschen: [C: 04-1] Adding the first step in order to enable the visualization of the Article Reminder feature. (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [07:19:01] 10Collaboration-Team-Triage, 10Notifications, 10MediaWiki-extensions-LoginNotify, 10Wikimedia-log-errors: Fatal error: Class undefined: LoginNotifyPresentationModel in extensions/Echo/includes/formatters/EventPresentationModel.php on line 99 - https://phabricator.wikimedia.org/T168899#3381255 (10matej_sucha... [08:23:56] (03CR) 10Foxy brown: Adding the first step in order to enable the visualization of the Article Reminder feature. (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [08:26:32] (03PS13) 10Foxy brown: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [08:26:39] (03CR) 10jerkins-bot: [V: 04-1] Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [08:29:04] (03CR) 10Foxy brown: "Matt - I found a different way to disable the category if it's set to false (just like all other internal Echo features) - please see Hook" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [08:33:14] (03PS14) 10Foxy brown: Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) [08:33:20] (03CR) 10jerkins-bot: [V: 04-1] Adding the first step in order to enable the visualization of the Article Reminder feature. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (https://phabricator.wikimedia.org/T165755) (owner: 10Foxy brown) [09:04:24] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Use filled bookmark icon for saving - https://phabricator.wikimedia.org/T168828#3381484 (10Pginer-WMF) >>! In T168828#3380947, @Catrope wrote: > An earlier prototype or design must ha... [09:08:03] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3381499 (10Pginer-WMF) >>! In T168043#3381014, @Mooeypoo wrote: > @Pginer-WMF question that will affect implementation:... [09:15:12] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10User-Urbanecm: autorefresh extension on beta RC altering window position - https://phabricator.wikimedia.org/T168907#3381531 (10Pginer-WMF) [10:20:59] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3381691 (10Eee888) [13:17:07] 10Collaboration-Team-Triage, 10Edit-Review-Improvements: Tag/parser function to create a notify bubble - https://phabricator.wikimedia.org/T168947#3382125 (10jeblad) [13:17:37] 10Collaboration-Team-Triage, 10Edit-Review-Improvements: Tag/parser function to create a notify bubble - https://phabricator.wikimedia.org/T168947#3382128 (10jeblad) Not quite sure where this belongs... [13:46:14] (03PS1) 10Fomafix: Fix module dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/361667 [17:00:13] 10Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, 10Parsoid, and 3 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3116336 (10Amire80) Is this really related t... [17:01:19] 10Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, 10Parsoid, and 3 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3383343 (10ssastry) >>! In T160960#3383324,... [17:05:02] 10Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, 10Parsoid, and 3 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3383370 (10Amire80) Oh, OK, missed it someho... [17:14:06] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10User-Urbanecm: autorefresh extension on beta RC altering window position - https://phabricator.wikimedia.org/T168907#3383494 (10Urbanecm) [18:20:56] 10Collaboration-Team-Triage, 10Edit-Review-Improvements: Tag/parser function to create a notify bubble - https://phabricator.wikimedia.org/T168947#3382113 (10Mattflaschen-WMF) You mean instead of seeing a fixed colored box at the top of the article "The neutrality of this article is disputed. [...]" you would... [18:22:09] 10Collaboration-Team-Triage, 10MediaWiki-extension-requests: Tag/parser function to create a notify bubble - https://phabricator.wikimedia.org/T168947#3383897 (10Mattflaschen-WMF) [18:29:13] 10Collaboration-Team-Triage, 10Notifications, 10Analytics, 10Analytics-EventLogging, and 5 others: Multiple MediaWiki hooks are not documented on mediawiki.org - https://phabricator.wikimedia.org/T157757#3383914 (10Nuria) [18:50:48] (03CR) 10Catrope: [C: 032] Fix module dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/361667 (owner: 10Fomafix) [19:01:05] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Adjust the legend on Recent Changes page - https://phabricator.wikimedia.org/T168043#3384057 (10Mooeypoo) a:03Mooeypoo [19:08:58] (03Merged) 10jenkins-bot: Fix module dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/361667 (owner: 10Fomafix) [21:09:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361759 (owner: 10L10n-bot) [21:15:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361764 (owner: 10L10n-bot) [21:34:22] "Mark all as read" in the Notifications panel/popup appears misplaced in prod. Is this the intended positioning? https://usercontent.irccloud-cdn.com/file/VTr9nFRO/Screen%20Shot%202017-06-27%20at%202.33.28%20PM.png [21:36:19] Hmm no that looks wrong [21:36:29] Niharika: Is that testwiki/mediawikiwiki or somewhere else? [21:37:10] RoanKattouw: I checked on the only wiki I had any notifications on https://wikisource.org/wiki/Main_Page [21:37:53] Yup, I see it. Broken on enwiki too [21:38:02] As well as mediawikiwiki [21:38:28] Want me to file a bug? [21:39:31] Yes please [21:39:47] Not sure what changed here, maybe OOUI changed the amount of padding on buttons [21:40:03] Or they're using padding where they previously used margin? The margin-top on the "Mark as read" button is suspiciously high [21:42:02] 10Collaboration-Team-Triage, 10Notifications: "Mark all as read" button appears misplaced in Notifications panel - https://phabricator.wikimedia.org/T169019#3384546 (10Niharika) [21:46:39] (03PS1) 10Catrope: Fix alignment of the "Mark all read" button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361791 (https://phabricator.wikimedia.org/T169019) [21:47:01] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10Patch-For-Review: "Mark all as read" button appears misplaced in Notifications panel - https://phabricator.wikimedia.org/T169019#3384567 (10Catrope) [21:47:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Notifications, 10Patch-For-Review: "Mark all as read" button appears misplaced in Notifications panel - https://phabricator.wikimedia.org/T169019#3384546 (10Catrope) a:03Catrope [23:11:39] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications: Length validation for comment - https://phabricator.wikimedia.org/T169021#3384673 (10Mattflaschen-WMF) [23:19:54] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3384692 (10Mattflaschen-WMF) >>! In T168385#3373672, @Mattflaschen-WMF wrote: > @Eee888 Can you put the current pla... [23:20:17] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3384693 (10Mattflaschen-WMF) [23:26:36] (03CR) 10Mooeypoo: [C: 032] Fix alignment of the "Mark all read" button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361791 (https://phabricator.wikimedia.org/T169019) (owner: 10Catrope) [23:32:09] mooeypoo: ooui question since i cant find any documentation.. :) [23:32:58] I'm switching from ButtonSelectWidget to ButtonGroupWidget. Previously I connected the choose event of ButtonSelectWidget to an action but that no longer exists. What's the ButtonGroupWidget event equivalent [23:33:05] (i should really be able to get this via a google but i cant) [23:42:42] (03Merged) 10jenkins-bot: Fix alignment of the "Mark all read" button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361791 (https://phabricator.wikimedia.org/T169019) (owner: 10Catrope) [23:43:57] (03CR) 10jenkins-bot: Fix alignment of the "Mark all read" button [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361791 (https://phabricator.wikimedia.org/T169019) (owner: 10Catrope)