[06:41:01] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), 10Patch-For-Review: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#3377566 (10Kudpung... [06:43:53] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), 10Patch-For-Review: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#3377577 (10Kudpung... [08:35:46] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3377835 (10Pginer-WMF) [09:10:11] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Use filled bookmark icon for saving - https://phabricator.wikimedia.org/T168828#3377931 (10Pginer-WMF) [09:10:57] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3377835 (10Pginer-WMF) [09:47:42] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make icons size more consistent for Recent Changes icons - https://phabricator.wikimedia.org/T168835#3378101 (10Pginer-WMF) [09:58:17] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make icons size more consistent for Recent Changes filters - https://phabricator.wikimedia.org/T168835#3378126 (10Pginer-WMF) [10:21:57] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Adjust color of some filter actions to make them less prominent - https://phabricator.wikimedia.org/T168841#3378227 (10Pginer-WMF) [10:24:02] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Adjust color of some filter actions to make them less prominent - https://phabricator.wikimedia.org/T168841#3378255 (10Pginer-WMF) [10:27:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Epic: Styling adjustments for the New filters for edit review - https://phabricator.wikimedia.org/T168826#3378267 (10Pginer-WMF) [10:27:47] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Shorten the label of "Saved filter settings" in the New filters for edit review - https://phabricator.wikimedia.org/T167876#3378268 (10Pginer-WMF) [10:44:45] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Connect better the advanced filters with the main filter entry point on Recent Changes - https://phabricator.wikimedia.org/T168845#3378302 (10Pginer-WMF) [10:48:44] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3378325 (10Pginer-WMF) >>! In T167384#3374945, @Etonkovidova wr... [11:19:55] 10Collaboration-Team-Triage, 10Flow, 10I18n: [[MediaWiki:Apihelp-flow+undo-edit-post-summary/fr]] i18n issue - https://phabricator.wikimedia.org/T168844#3378415 (10Liuxinyu970226) [11:51:36] 10Collaboration-Team-Triage, 10Flow, 10Easy: Typo in English string [[MediaWiki:Apihelp-flow+undo-edit-post-summary]]: "necesary" - https://phabricator.wikimedia.org/T168844#3378467 (10Aklapper) [11:51:49] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Use standard round corners for advanced filters buttons on the filters panel - https://phabricator.wikimedia.org/T168849#3378471 (10Pginer-WMF) [12:03:50] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Don't make the advanced filters to float at the bottom of the filters panel - https://phabricator.wikimedia.org/T168851#3378525 (10Pginer-WMF) [12:06:08] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Don't make the advanced filters to float at the bottom of the filters panel - https://phabricator.wikimedia.org/T168851#3378550 (10Pginer-WMF) [12:07:53] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3378582 (10Pginer-WMF) >>! In T167384#3350280, @Mooeypoo wrote:... [12:16:13] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Going back from "tagged edits" filter results in the filters panel losing the title - https://phabricator.wikimedia.org/T168855#3378604 (10Pginer-WMF) [12:17:45] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Implement navigation UI for the Advanced filters - https://phabricator.wikimedia.org/T167384#3331374 (10Pginer-WMF) @Mooeypoo I also discovered a strange gl... [15:50:43] (03PS1) 10Addshore: Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 [16:08:39] (03CR) 10WMDE-Fisch: [C: 031] Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [16:23:54] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Filter users' edits by status - https://phabricator.wikimedia.org/T168887#3379589 (10Trizek-WMF) [16:24:21] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Filter blocked users' edits - https://phabricator.wikimedia.org/T167698#3379603 (10Trizek-WMF) [16:24:24] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Filter users' edits by status - https://phabricator.wikimedia.org/T168887#3379602 (10Trizek-WMF) [16:43:58] 10Collaboration-Team-Triage, 10Flow, 10Easy: Typo in English string [[MediaWiki:Apihelp-flow+undo-edit-post-summary]]: "necesary" - https://phabricator.wikimedia.org/T168844#3379732 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [16:46:14] (03PS1) 10Umherirrender: Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) [17:02:27] 10Collaboration-Team-Triage, 10Flow: Add ability to reduce visibility of certain comments - https://phabricator.wikimedia.org/T168895#3379844 (10Elitre) [17:35:41] (03CR) 10Catrope: [C: 032] Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [17:35:55] (03CR) 10Catrope: [C: 032] Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [17:36:07] 10Collaboration-Team-Triage, 10Flow, 10Easy, 10Patch-For-Review: Typo in English string [[MediaWiki:Apihelp-flow+undo-edit-post-summary]]: "necesary" - https://phabricator.wikimedia.org/T168844#3379941 (10Catrope) 05Open>03Resolved [17:43:47] (03CR) 10jerkins-bot: [V: 04-1] Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [17:48:11] (03CR) 10jerkins-bot: [V: 04-1] Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [17:52:28] (03CR) 10Catrope: "17:43:07 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [17:52:31] (03CR) 10Catrope: [C: 032] Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [17:52:53] (03CR) 10Catrope: "17:38:04 ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [17:52:56] (03CR) 10Catrope: [C: 032] Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [17:57:55] 10Collaboration-Team-Triage, 10Notifications, 10Wikimedia-log-errors: Fatal error: Class undefined: LoginNotifyPresentationModel in extensions/Echo/includes/formatters/EventPresentationModel.php on line 99 - https://phabricator.wikimedia.org/T168899#3380022 (10mmodell) [17:58:16] 10Collaboration-Team-Triage, 10Notifications, 10Wikimedia-log-errors: Fatal error: Class undefined: LoginNotifyPresentationModel in extensions/Echo/includes/formatters/EventPresentationModel.php on line 99 - https://phabricator.wikimedia.org/T168899#3380035 (10mmodell) p:05Triage>03High [17:58:49] 10Collaboration-Team-Triage, 10Notifications, 10Wikimedia-log-errors: Fatal error: Class undefined: LoginNotifyPresentationModel in extensions/Echo/includes/formatters/EventPresentationModel.php on line 99 - https://phabricator.wikimedia.org/T168899#3380022 (10mmodell) [18:00:25] (03CR) 10jerkins-bot: [V: 04-1] Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [18:03:37] (03PS1) 10Catrope: Follow-up 2dfb4511e9: call parent constructor in gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361493 [18:04:02] (03CR) 10Catrope: "I think https://gerrit.wikimedia.org/r/#/c/361493/ might fix this, testing" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [18:04:17] (03PS2) 10Catrope: Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [18:06:53] (03CR) 10jerkins-bot: [V: 04-1] Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [18:55:19] (03PS3) 10Catrope: Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [18:55:43] (03CR) 10Catrope: "PS2 proves that that fixes it; reverting so we can merge the Echo change, then this change" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [18:56:00] matt_flaschen: Could you merge https://gerrit.wikimedia.org/r/#/c/361493/ ? It unbreaks Jenkins for Flow [19:04:46] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), 10Patch-For-Review: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#3380148 (10Quiddit... [19:05:40] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 3 others: Ping Johan and Translators mailing list about Echo Notifications blacklist strings - https://phabricator.wikimedia.org/T168902#3380151 (10TBolliger) [19:23:21] (03CR) 10Mooeypoo: [C: 032] Migrate from FloatingMenuSelectWidget (deprecated) to MenuSelectWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361102 (https://phabricator.wikimedia.org/T168679) (owner: 10Catrope) [19:25:52] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Special:NewPagesFeed unreviewed filter is also including pages nominated for deletion - https://phabricator.wikimedia.org/T165365#3380237 (10kaldari) @jmatazzoni: The new page reviewers are currently [[ https://en.wikipedia.org/wiki/User_talk:Ku... [19:26:38] kaldari: FYI Joe is on vacation until Friday [19:35:36] (03Merged) 10jenkins-bot: Migrate from FloatingMenuSelectWidget (deprecated) to MenuSelectWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361102 (https://phabricator.wikimedia.org/T168679) (owner: 10Catrope) [19:37:00] (03CR) 10jenkins-bot: Migrate from FloatingMenuSelectWidget (deprecated) to MenuSelectWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361102 (https://phabricator.wikimedia.org/T168679) (owner: 10Catrope) [19:39:43] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: autorefresh extension on beta RC altering window position - https://phabricator.wikimedia.org/T168907#3380293 (10dchen) [20:25:23] (03CR) 10Mattflaschen: [C: 032] Follow-up 2dfb4511e9: call parent constructor in gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361493 (owner: 10Catrope) [20:29:17] (03PS1) 10Mattflaschen: GenerateFlowAutoload: Call parent constructor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361515 [20:30:19] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10User-Urbanecm: autorefresh extension on beta RC altering window position - https://phabricator.wikimedia.org/T168907#3380419 (10Urbanecm) Screenshot are below (I've just pressed F5 before making the screenshot with improved RC enabled, the ex... [20:30:50] RoanKattouw, thanks. I put up the same for Flow: https://gerrit.wikimedia.org/r/361515 . Weird that both original patches passed Jenkins. [20:31:19] (03CR) 10Catrope: [C: 032] GenerateFlowAutoload: Call parent constructor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361515 (owner: 10Mattflaschen) [20:31:38] (03CR) 10Catrope: Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [20:31:42] (03CR) 10Catrope: [C: 032] Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [20:31:46] (03CR) 10Catrope: [C: 032] Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [20:32:06] Yeah... I guess it only gets used in other extensions' test builds somehow?! [20:32:46] RoanKattouw, where's the failure? [20:33:42] matt_flaschen: The two unrelated Flow patches that I just re-+2ed [20:37:13] 10Collaboration-Team-Triage, 10Flow: Investigate what to do with WikiLinkFixer now that Parsoid supports red links - https://phabricator.wikimedia.org/T168555#3380431 (10Mattflaschen-WMF) [20:37:35] (03Merged) 10jenkins-bot: Follow-up 2dfb4511e9: call parent constructor in gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361493 (owner: 10Catrope) [20:44:32] (03CR) 10jenkins-bot: Follow-up 2dfb4511e9: call parent constructor in gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361493 (owner: 10Catrope) [20:45:38] (03Merged) 10jenkins-bot: GenerateFlowAutoload: Call parent constructor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361515 (owner: 10Mattflaschen) [20:46:47] (03CR) 10jenkins-bot: GenerateFlowAutoload: Call parent constructor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361515 (owner: 10Mattflaschen) [20:47:18] (03Merged) 10jenkins-bot: Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [20:47:20] (03Merged) 10jenkins-bot: Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [20:49:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/361542 (owner: 10L10n-bot) [20:49:47] (03CR) 10jenkins-bot: Fix typo in word 'necessary' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361485 (https://phabricator.wikimedia.org/T168844) (owner: 10Umherirrender) [20:49:58] (03CR) 10jenkins-bot: Call parent::__construct() in TalkpageManagerTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361477 (owner: 10Addshore) [20:51:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/361549 (owner: 10L10n-bot) [22:26:16] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint, 10MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), 10Patch-For-Review: Remove the "Possible issues" section from PageTriage, if it is empty - https://phabricator.wikimedia.org/T147220#3380699 (10kaldari... [22:46:34] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Make icons size more consistent for Recent Changes filters - https://phabricator.wikimedia.org/T168835#3378101 (10Catrope) As far as I can tell, this is a direct consequence of {T97631}. I checked and the outer boxes for the icons are... [23:31:44] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Adjust color of some filter actions to make them less prominent - https://phabricator.wikimedia.org/T168841#3378227 (10Catrope) They're not pure black currently: all iconed OOUI buttons have `opacity: 0.87` to make the icons look like... [23:52:23] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Use filled bookmark icon for saving - https://phabricator.wikimedia.org/T168828#3377931 (10Catrope) An earlier prototype or design must have made the distinction between the filled and unfilled versions of this ic... [23:52:47] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Adjust color of some filter actions to make them less prominent - https://phabricator.wikimedia.org/T168841#3380950 (10Catrope) [23:53:10] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Use filled bookmark icon for saving - https://phabricator.wikimedia.org/T168828#3380952 (10Catrope) [23:53:23] 10Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Patch-For-Review: Use filled bookmark icon for saving - https://phabricator.wikimedia.org/T168828#3377931 (10Catrope) a:03Catrope