[01:23:07] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page curation marking pages with citations as having no citations - https://phabricator.wikimedia.org/T168350#3361829 (10TonyBallioni) [01:56:22] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page curation marking pages with citations as having no citations - https://phabricator.wikimedia.org/T168350#3361829 (10MusikAnimal) Yup, the `{{sfn}}` format is what's throwing it off. Page Cuartion specifically looks for `` tags. From t... [02:41:33] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/360147 [02:57:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/360147 (owner: 10Legoktm) [03:02:36] (03CR) 10Legoktm: [C: 04-1] "The auto-fixing here has a bug." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/360147 (owner: 10Legoktm) [03:04:26] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech: PageTriageUtil::getTopTriagers() is not accurate - https://phabricator.wikimedia.org/T168335#3361876 (10kaldari) @MusikAnimal: If querying only for pagetriage-curation reviews in the logging table is relatively fast, let's do... [03:05:29] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech: PageTriageUtil::getTopTriagers() is not accurate - https://phabricator.wikimedia.org/T168335#3361877 (10MusikAnimal) >>! In T168335#3361876, @kaldari wrote: > How about we restrict the API to only querying for the past day or... [07:18:00] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/360233 [07:23:15] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/360266 [07:33:39] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/360285 [10:06:06] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement: Consider to provide a fallback option to the original page setup/layout for pages that will receive Integrated Filters - https://phabricator.wikimedia.org/T168376#3362622 (10Trizek-WMF) [10:08:20] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3362639 (10Trizek-WMF) [10:08:22] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement: Consider to provide a fallback option to the original page setup/layout for pages that will receive Integrated Filters - https://phabricator.wikimedia.org/T168376#3362638 (10Trizek-WMF) [10:08:58] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 10Community-Liaisons (Jul-Sep 2017): Announce and follow up with communities about the New Filters for Recent changes by default deployment - https://phabricator.wikimedia.org/T164489#3235320 (10Trizek-WMF) [10:35:55] (03PS4) 10ArielGlenn: generate metadata dumps as first pass, rev text as second pass dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) [10:39:10] (03PS9) 10Foxy brown: new notification type was added and works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 [10:42:30] (03CR) 10jerkins-bot: [V: 04-1] generate metadata dumps as first pass, rev text as second pass dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) (owner: 10ArielGlenn) [10:50:33] (03PS5) 10ArielGlenn: generate metadata dumps as first pass, rev text as second pass dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) [10:51:30] (03PS5) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [10:54:48] (03CR) 10jerkins-bot: [V: 04-1] new notification type was added and works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (owner: 10Foxy brown) [11:03:26] (03CR) 10jerkins-bot: [V: 04-1] generate metadata dumps as first pass, rev text as second pass dumps [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355080 (https://phabricator.wikimedia.org/T164262) (owner: 10ArielGlenn) [11:04:17] 10Collaboration-Team-Triage, 10Article-Reminder-Notifications: make a decision about the text in the notification - https://phabricator.wikimedia.org/T168385#3362850 (10Eee888) [11:06:16] 10Collaboration-Team-Triage, 10Article-Reminder-Notifications, 10Reading-Web-Planning: Rate limit for API performance - https://phabricator.wikimedia.org/T168386#3362869 (10Eee888) [11:07:07] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications: Create the UI button that opened up the Adding Reminder menu - https://phabricator.wikimedia.org/T168387#3362882 (10Eee888) [11:07:42] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [11:07:58] 10Collaboration-Team-Triage, 10Notifications, 10Article-Reminder-Notifications: Create UI for submitting article reminder - https://phabricator.wikimedia.org/T168388#3362895 (10Eee888) [11:17:46] (03PS6) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [11:22:58] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [11:28:44] 10Collaboration-Team-Triage, 10Flow: Create a maintenance script in Flow to rename a wiki - https://phabricator.wikimedia.org/T168389#3362910 (10Seb35) [11:43:32] 10Collaboration-Team-Triage, 10Flow: Create a maintenance script in Flow to rename a wiki - https://phabricator.wikimedia.org/T168389#3362928 (10Seb35) p:05Triage>03Low I did the following operations in database in a wiki and it globally works (*): ``` UPDATE flow_ext_ref SET ref_src_wiki = 'newWikiID' WHE... [11:46:38] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3311730 (10Etonkovidova) @Mooeypoo Selecting a tag filter in betalabs RC page with enabled filter... [11:55:37] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3362939 (10Etonkovidova) [11:57:58] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3362940 (10Etonkovidova) [12:05:22] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Namespace drop-down filter menu does not scrolls automatically when selected Namespace (Tag) filter capsule is clicked - https://phabricator.wikimedia.org/T168220#3362944 (10Etonkovidova) [12:06:13] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3362946 (10Etonkovidova) Checked in betalabs. The summary of what's not done yet (1) >The menu... [12:26:32] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Tagged edits' filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166914#3363058 (10Pginer-WMF) >>! In T166914#3362946, @Etonkovidova wrote: >>A "?" icon (help link) leads... [12:41:49] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10User-notice-collaboration: Announce to communities the change for RecentChangesText for the new filters Beta feature - https://phabricator.wikimedia.org/T167945#3363125 (10Trizek-WMF) This has been put in the newt Collaboration team newslette... [12:42:04] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Community-Liaisons (Apr-Jun 2017), 10User-notice-collaboration: Announce to communities the change for RecentChangesText for the new filters Beta feature - https://phabricator.wikimedia.org/T167945#3363126 (10Trizek-WMF) [13:11:28] (03PS7) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [13:16:30] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [13:20:55] (03PS8) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [13:26:11] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [13:32:45] (03PS9) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [13:36:57] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [13:40:43] (03PS10) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [13:48:12] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [13:52:54] 10Collaboration-Team-Triage, 10Article-Reminder-Notifications: make a decision about the text in the notification - https://phabricator.wikimedia.org/T168385#3363377 (10Trizek-WMF) What are the choices about this text? [14:19:20] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3363474 (10Pginer-WMF) >>! In T166912#3361181, @Etonkovidova wrote: > (2) What is the purpose of Highli... [14:20:09] (03CR) 10Hashar: "recheck" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/360285 (owner: 10Legoktm) [14:32:02] (03PS11) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [14:47:06] (03CR) 10Jforrester: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/360285 (owner: 10Legoktm) [14:59:46] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3363638 (10Etonkovidova) @Pginer-WMF Using your example with **selecting both **"Registered" and "Unreg... [15:02:10] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [15:06:18] FoxyBrown, mooeypoo, how's it going? [15:08:07] @matt_flaschen - all good, trying to fix the branch build :/ [15:12:52] FoxyBrown, great, I'm looking at the first patch now: https://gerrit.wikimedia.org/r/#/c/355797/ [15:13:01] FoxyBrown, any specific questions at the moment? [15:14:07] mmm... would LOVE to recall how to ran all tasks locally :/ [15:17:08] FoxyBrown, for the JS and i18n issues: [15:17:13] vagrant ssh [15:17:19] cd /vagrant/mediawiki/extensions/Echo [15:17:23] npm install [15:17:26] (above is one-time only) [15:17:42] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/360285 (owner: 10Legoktm) [15:17:42] matt_flaschen, not the JS, the PHP validations... [15:17:56] grunt (still for front-end) [15:18:23] FoxyBrown: [15:18:25] composer test [15:18:29] (03PS12) 10Foxy brown: New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) [15:18:31] Same directory [15:18:48] FoxyBrown, that doesn't include PHPUnit, though. I said how to do tat in an email. [15:19:33] matt_flaschen, yep - the UT I know, thanks [15:19:58] FoxyBrown, but composer test will run lint (checking for syntax errors) and phpcs (code style) [15:21:05] FoxyBrown, the error on https://gerrit.wikimedia.org/r/#/c/355797/7 is about i18n: https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-jessie/9836/console [15:21:11] 10:42:41 Running "banana:Echo" (banana) task [15:21:12] 10:42:41 >> 1 message lacks documentation. [15:21:14] 10:42:41 >> Message "notification-header-article-reminder" lacks documentation. [15:21:15] 10:42:41 >> 1 documented message is undefined. [15:21:17] 10:42:41 >> Message "notification-article-reminder-email-subject" is documented but undefined. [15:21:37] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement Namespace filters and filter menu in the new UI - https://phabricator.wikimedia.org/T166912#3363738 (10Pginer-WMF) >>! In T166912#3363638, @Etonkovidova wrote: > @Pginer-WMF Using your example wi... [15:22:36] FoxyBrown, on the API patch, there are some final style issues causing it to fail Jenkins: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/16125/console [15:36:06] FoxyBrown, looks like you accidentally removed AllowArticleReminderNotification from https://gerrit.wikimedia.org/r/#/c/355797/ [15:38:36] (03CR) 10jerkins-bot: [V: 04-1] New Article Reminder API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/357847 (https://phabricator.wikimedia.org/T166973) (owner: 10Foxy brown) [15:44:42] FoxyBrown, what do you think about the bundling? Do you understand what that is? [15:50:16] FoxyBrown, are you there? [15:50:26] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [wmf.5] The invite opt-in popup does not accommodate some languages - https://phabricator.wikimedia.org/T168413#3363843 (10Etonkovidova) [15:52:29] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement 'Live Updates' feature for RC page filters - https://phabricator.wikimedia.org/T167743#3363860 (10Pginer-WMF) >>! In T167743#3355416, @Trizek-WMF wrote: >>>! In T167743#3354654, @Pginer-WMF wrote... [16:08:18] (03CR) 10Mattflaschen: new notification type was added and works (038 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (owner: 10Foxy brown) [16:08:26] (03CR) 10Mattflaschen: [C: 04-1] new notification type was added and works [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355797 (owner: 10Foxy brown) [17:02:16] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10MW-1.30-release-notes, 10Patch-For-Review: Integrate namespace and tag selectors into the filter menu - https://phabricator.wikimedia.org/T164130#3364155 (10Etonkovidova) [17:21:05] etonkovidova, https://phabricator.wikimedia.org/maniphest/query/JPibTGPx.XcC/ [17:31:53] 10Collaboration-Team-Triage, 10Flow, 10Technical-Debt: Create base class for editor-containing widgets to de-duplicate code - https://phabricator.wikimedia.org/T158584#3364410 (10Mattflaschen-WMF) This might be a duplicate, but not sure. [17:32:32] 10Collaboration-Team-Triage, 10Notifications: Double notification on the same text during section splitting - https://phabricator.wikimedia.org/T168435#3364415 (10IKhitron) [17:32:55] 10Collaboration-Team-Triage, 10Flow, 10Easy: The 'Wikitext "uses markup"' link doesn't work if the mw: interwiki is not configured - https://phabricator.wikimedia.org/T158585#3364431 (10Mattflaschen-WMF) [17:37:06] matt_flaschen: https://phabricator.wikimedia.org/maniphest/query/N3QoU4RK0Ok_/#R [17:38:33] matt_flaschen: https://phabricator.wikimedia.org/T167853 [17:44:12] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Values in MediaWiki:rcfilters-filter-user-experience-level-newcomer-description - https://phabricator.wikimedia.org/T167853#3364534 (10Mattflaschen-WMF) It is configurable (wgLearnerEdits, wgExperiencedUserEdits, wgLearnerMemberSince, wgExperienc... [17:44:54] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 10Collaboration-Community-Engagement, 10Documentation, 10Goal: 'Integrated filters'— document all new implementations defined on T162675 - https://phabricator.wikimedia.org/T167855#3364538 (10Mattflas... [17:47:22] 10Collaboration-Team-Triage, 10Notifications, 10Anti-Harassment, 10Support-and-Safety, and 3 others: Extend the Echo notifications blacklist to cover cross-wiki notifications - https://phabricator.wikimedia.org/T167902#3364547 (10Mattflaschen-WMF) [17:47:59] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Patch-For-Review: Summarize what it will take to separate product and platform for ORES Extension - https://phabricator.wikimedia.org/T167908#3364563 (10Mattflaschen-WMF) [17:51:41] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3364569 (10Mattflaschen-WMF) [17:53:27] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Community-Liaisons (Apr-Jun 2017), 10User-notice-collaboration: Announce to communities the change for RecentChangesText for the new filters Beta feature - https://phabricator.wikimedia.org/T167945#3364579 (10Ma... [17:58:14] etonkovidova, https://phabricator.wikimedia.org/T2582 [18:00:16] 10Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: RC filters - extra space/padding for previous 'Namespace' and 'Tag filter' options is preserved - https://phabricator.wikimedia.org/T168325#3364637 (10Mattflaschen-WMF) [18:03:23] 10Collaboration-Team-Triage, 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3364644 (10Mattflaschen-WMF) [18:04:24] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Article-Reminder-Notifications: Determine language/i18n for Article Reminder notifications - https://phabricator.wikimedia.org/T168385#3362850 (10Mattflaschen-WMF) We'd like @jmatazzoni to come up with text for this. [18:06:04] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Article-Reminder-Notifications: Create the UI button that opened up the Adding Reminder menu - https://phabricator.wikimedia.org/T168387#3364650 (10Mattflaschen-WMF) [18:06:15] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Article-Reminder-Notifications: Create UI for submitting article reminder - https://phabricator.wikimedia.org/T168388#3364651 (10Mattflaschen-WMF) [18:11:07] 10Collaboration-Team-Triage, 10Flow: Adding [[Category:Foo]] in Flow board header or Flow topic summary should add it to category. - https://phabricator.wikimedia.org/T62510#3364682 (10Mattflaschen-WMF) [18:13:17] 10Collaboration-Team-Triage, 10Flow: Adding [[Category:Foo]] in Flow board header or Flow topic summary should add it to category. - https://phabricator.wikimedia.org/T62510#679799 (10Mattflaschen-WMF) As stated in the description, this (still) works. It should have been closed back then. [18:13:27] 10Collaboration-Team-Triage, 10Flow: Handle categories on Flow - https://phabricator.wikimedia.org/T167979#3364691 (10Mattflaschen-WMF) [18:13:29] 10Collaboration-Team-Triage, 10Flow: Adding [[Category:Foo]] in Flow board header or Flow topic summary should add it to category. - https://phabricator.wikimedia.org/T62510#3364690 (10Mattflaschen-WMF) 05Open>03Resolved [18:14:30] 10Collaboration-Team-Triage, 10Flow: Decide how to handle categories in regular posts - https://phabricator.wikimedia.org/T94617#3364693 (10Mattflaschen-WMF) [18:14:32] 10Collaboration-Team-Triage, 10Flow: Adding [[Category:Foo]] in Flow board header or Flow topic summary should add it to category. - https://phabricator.wikimedia.org/T62510#679799 (10Mattflaschen-WMF) [18:14:55] 10Collaboration-Team-Triage, 10Flow: Flow category improvements (tracking) - https://phabricator.wikimedia.org/T167979#3351866 (10Mattflaschen-WMF) [18:17:09] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3364714 (10Mattflaschen-WMF) [18:18:32] 10Collaboration-Team-Triage, 10Flow, 10Epic: Proposed changes to Flow to be done in FY2017–18 - https://phabricator.wikimedia.org/T167928#3349982 (10Mattflaschen-WMF) [19:15:48] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10Patch-For-Review, 10Regression: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardles... - https://phabricator.wikimedia.org/T167922#3365061 [19:16:33] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10Patch-For-Review, 10Regression: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardles... - https://phabricator.wikimedia.org/T167922#3349679 [19:18:51] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10Patch-For-Review, 10Regression: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardles... - https://phabricator.wikimedia.org/T167922#3365081 [19:22:52] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10VisualEditor, 10Regression: [1.30.0-wmf.2 regression] 'TypeError: Cannot read property 'model' of undefined' displayed on Flow pages when saving content with open oo-ui-clippableElement-c... - https://phabricator.wikimedia.org/T166634#3365097 [19:24:19] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Article-Reminder-Notifications: Create the UI button that opened up the Adding Reminder menu - https://phabricator.wikimedia.org/T168387#3365100 (10Mooeypoo) A couple of questions we should ask to prepare for this: * Where should... [19:27:50] 10Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Watchlist, 10MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), 10Patch-For-Review, 10Regression: [Regression wmf.5] On enhanced watchlists, boldness styling shows regardles... - https://phabricator.wikimedia.org/T167922#3365123 [19:29:59] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/360147 [21:01:34] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/360233 (owner: 10Legoktm) [21:03:47] (03CR) 10Umherirrender: [C: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/360233 (owner: 10Legoktm) [21:16:34] (03CR) 10Umherirrender: [C: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/360266 (owner: 10Legoktm) [21:25:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/360453 (owner: 10L10n-bot) [21:26:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/360466 (owner: 10L10n-bot) [21:57:57] (03CR) 10Umherirrender: [C: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 0.9.0 (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/360147 (owner: 10Legoktm) [22:02:11] 10Collaboration-Team-Triage, 10Notifications: Back-end infrastructure for timed notifications in Echo - https://phabricator.wikimedia.org/T156808#3365573 (10Mattflaschen-WMF) It doesn't look like there's a clean way to delete existing jobs. We might be able to edit them with deduplicateRootJob, but I don't se... [22:38:56] RoanKattouw, could use a review on https://gerrit.wikimedia.org/r/#/c/197315/ . [23:12:14] matt_flaschen, RoanKattouw brainstorming -- I'm adjusting the controller+model to accept a structure of views rathre than individually namespaces with individually tags with then individually whatever-else-we-have (from/limit/days/etc) -- so that means i need to process and massage the data a little bit before the model goes over it (namespaces for example have a different structure from the wg) [23:12:32] So up until now I made it hard-coded; the model knew that namespaces need to be massaged this way and tags that way [23:12:54] but I want the model to be more general so we can add from/to/days and also invert/highlghts in a general way that the model just adjusts filters->params and vise versa [23:13:15] So now the question: Where do I "massage" and prepare the data? In the init before I give it to the controller, or in the controller before I give it to the model? [23:14:58] I can see how it can be a controller thing, but then the controller will also need a specific namespace and tags literal params that it then knows how to manipulate [23:15:19] I can't decide if it's a "pre processing" thing (so maybe in init?) or if it's a pre-processing as in pre-model, so then it's the controller [23:15:44] It's not that crucial, but ... yeah [23:17:23] mooeypoo, seems okay for the controller to know this business logic (params and how to manipulate). [23:17:41] mooeypoo, probably easier to test that way too? Since rcfilters.init doesn't return anything and isn't very unit-y? [23:17:51] Though I guess you could restructure the init to be more unit-y. [23:18:19] That's my thought as of now, but could be convinced otherwise. [23:19:02] mooeypoo, do you remember which of our tours was sticking around from page to page? [23:21:09] Hmm [23:21:28] Oh, hm, I think the "welcome to RCFilters beta" one? [23:21:51] matt_flaschen, and yeah, I think I'll put it in the controller. Init should also be minimal... shouldn't have a lot of manipulations going on there [23:21:59] good point about the unit tests, too [23:23:20] mooeypoo, "Introducing: New Filters for Edit Review (beta)"? [23:23:34] What's weird is they all have isSinglePage true so this shouldn't happen. [23:25:40] Yeah, and I can't reproduce it right now [23:25:45] * mooeypoo tries again [23:26:27] Me neither [23:26:32] 10Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Community-Tech-Sprint: PageTriageUtil::getTopTriagers() is not accurate - https://phabricator.wikimedia.org/T168335#3365821 (10kaldari) [23:30:40] matt_flaschen, yeh, I can't reproduce... I assume it was a one-time thing? [23:30:46] or mysteriously solved? [23:32:27] mooeypoo, I think Elena brought it up a couple times in standup. I emailed you both. I guess if it's server-launched (which at least a couple are) then there was a hypothetical JS error on the first load (hopefully solved by now, if not needs to be), then the cookie wouldn't get cleared and it would show up for the first time elsewhere.