[00:00:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07Regression: [betalabs-regression] Highlighting is not preserved for saved filters - https://phabricator.wikimedia.org/T165437#3295891 (10jmatazzoni) 05Open>03Re... [00:00:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3295892 (10jmatazzoni) [00:01:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 07User-notice-collaboration: Add owner title variable for Flow AbuseFilter - https://phabricator.wikimedia.org/T161774#3295893 (10jmatazzoni) 05Open>03Resolved [00:02:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3295908 (10jmatazzoni) [00:02:53] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Add filter group for 'Last revision' to the RC Filters - https://phabricator.wikimedia.org/T163561#3295907 (10jmatazzoni) 05Open>03Re... [00:03:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review, 07Regression: [regression] Refreshing the page makes filters vanish - https://phabricator.wikimedia.org/T165230#3295910 (10jmatazzoni) 05Open>03Resolved [00:03:31] RoanKattouw, also, apparently they're serious that you need the full comparable function (-1, 0, 1) even though the function doesn't do any sorting (just checking which values in arr1 are also in arr2). [00:03:39] Yeah I noticed that [00:03:46] I looked at the docs because I was curious about your use of ? 0 : 1 [00:04:10] RoanKattouw, that was fun figuring out, especially because Zend (maintenance script) and HHVM (shell) behave differently. [00:04:26] RoanKattouw, yeah, I was kind of reluctant to believe that was the issue especially because it worked in the shell. [00:04:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: 'Quick links' - blank names for saved filters - https://phabricator.wikimedia.org/T165113#3295912 (10jmatazzoni) 05Open>03Res... [00:05:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: Highlighted items in a default saved query always appear on refresh - https://phabricator.wikimedia.org/T165231#3295914 (10jmataz... [00:05:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Do not rebind and blindly override onMenuToggle in FilterTagMultiselectWidget - https://phabricator.wikimedia.org/T164228#3295915... [00:05:59] I'm used the HHVM being the "buggy" one, and I thought they were both running HHVM. [00:06:01] P5490 [00:06:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: [betalabs-regression] Saved filter name not displayed and the bookmark icon di... - https://phabricator.wikimedia.org/T165381#3295916 [00:07:02] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, and 2 others: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3295918 (10jmatazzon... [00:07:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Redirect when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#3295917 (10jmatazzoni) 05Open>03Resolv... [01:20:39] RoanKattouw, so we definitely don't want AbuseFilter to be able to use all software-defined tag names, since there are some reserved ones, like the OAuth ones. That raises the question of whether it should be a whitelist or blacklist. [01:20:54] Naturally I prefer whitelist, but I wanted to see if that was going to be a mess since there were a bunch already used. [01:21:31] I wrote a script to check all of them, and it turns out there is only one wiki using one tag (visualeditor-needcheck) [01:21:41] Much better than I expected (array_diff aside) [01:21:51] T92956 [01:21:52] T92956: AbuseFilter needs better tag name validation - https://phabricator.wikimedia.org/T92956 [01:22:49] matt_flaschen: If this had been thought out properly, we'd have prefixed them all with abusefilter- [01:22:59] But that ship has probably sailed [01:23:25] In the case of OAuth you need to be able to reserve prefixes I think [01:26:56] RoanKattouw, technically I still can. I have to grandfather existing tags, but I'm already doing that (partly because it's the easiest way to avoid "can't create the tag because it already exists" blocking existing AF tags from being used). [01:26:57] But I'm not sure how useful it would be at this point. I'm open to being convinced, though. [01:27:35] I think it would be confusing if we started now [01:29:12] RoanKattouw, OAuth blocks user tags from being *created* matching oauth cid: (which will work once my patch is in). But that still leaves existing real OAuth tags, which leads back to the whitelist/blacklist for re-using real software-defined tags. [01:29:24] Whitelist seems fine. [10:42:56] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Back button not letting me back away from RC Page - https://phabricator.wikimedia.org/T166347#3296032 (10Mooeypoo) a:03Mooeypoo