[00:23:22] (03CR) 10Catrope: [C: 04-1] "DROP INDEX IF EXISTS would be good, yes. Chad figured out why this is failing: updatelog was truncated in beta labs at some point." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (owner: 10Paladox) [00:27:08] (03PS3) 10Catrope: Only drop flow_ext_ref_idx_v2 index if it exists. This should fix problems in beta labs arising from truncating updatelog. (modifyExtensionField() relies on updatelog to avoid repeating schema changes, and generally expects changes to be idempotent. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [00:36:22] 06Collaboration-Team-Triage, 10Flow, 10Beta-Cluster-Infrastructure, 10MediaWiki-Database, 13Patch-For-Review: Beta update.php fails with Can't DROP 'flow_ext_ref_idx_v2'; - https://phabricator.wikimedia.org/T166266#3290883 (10Paladox) Fails at nWarning: fopen(/tmp/mw-UIDGenerator-UID-88): failed to open... [00:39:39] RoanKattouw, never heard anything about MySQL DB changes being idempotent. That doesn't match the docs (https://www.mediawiki.org/wiki/Manual:Coding_conventions/Database#MySQL.2FMariaDB) or other patches. [00:39:58] RoanKattouw, i don't even think there is a way to do idempotent ADD COLUMN, other than laboriously checking INFORMATION_SCHEMA. [00:40:12] I mean MediaWiki DB changes being idempotent. [00:40:38] I'm glad this particular issue seems fixed, but worried truncating updatelog is going to cause a lot of issues. [00:41:12] 06Collaboration-Team-Triage, 10Flow, 10Beta-Cluster-Infrastructure, 10MediaWiki-Database, 13Patch-For-Review: Beta update.php fails with Can't DROP 'flow_ext_ref_idx_v2'; - https://phabricator.wikimedia.org/T166266#3290885 (10demon) So that's unrelated, and I'm fixing it ^ [00:42:03] 06Collaboration-Team-Triage, 10Flow, 10Beta-Cluster-Infrastructure, 10MediaWiki-Database, 13Patch-For-Review: Beta update.php fails with Can't DROP 'flow_ext_ref_idx_v2'; - https://phabricator.wikimedia.org/T166266#3290886 (10Mattflaschen-WMF) >>! In T166266#3290883, @Paladox wrote: > Fails at > > Warni... [00:54:46] matt_flaschen: addField doesn't have to be idempotent because it checks for the field's presence before running the patch file. I was talking specifically about modify[Extension]Field [00:54:52] Where it cannot perform such checks [00:57:58] RoanKattouw, I see, thanks. [00:58:14] I may have been unclear about that in the commit msg though [00:58:51] (03PS4) 10Catrope: Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [10:04:20] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Add 'View Newest Changes' option into the Integrated Filters - https://phabricator.wikimedia.org/T163426#3291348 (10Pginer-WMF) [10:36:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate time period selection in the new filters for edit review - https://phabricator.wikimedia.org/T162784#3291450 (10Pginer-WMF) [10:57:31] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate result size selection in the new filters for edit review - https://phabricator.wikimedia.org/T162786#3291491 (10Pginer-WMF) [12:12:05] (03CR) 10Fomafix: "Do you mean no closure because the resource loader already makes a closure around and "mw" is a local variable?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355530 (owner: 10Fomafix) [12:31:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Regression: [betalabs-regression] monobook: cannot de-select a selected filter - https://phabricator.wikimedia.org/T165446#3291665 (10Mholloway) [12:32:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Regression: [betalabs-regression] monobook: cannot de-select a selected filter - https://phabricator.wikimedia.org/T165446#3266071 (10Mholloway) ^Sorry, Phab tagging error. [12:39:24] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Possible-Tech-Projects, and 2 others: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#3291673 (10MGChecker) Yes, but Notifications are private as well. [12:50:14] (03CR) 10Krinkle: "Yeah, I'd say keep the closures that exist but don't add new ones. And those that use mediaWiki->mw can be stripped from the closure and u" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355530 (owner: 10Fomafix) [12:58:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 07User-notice-collaboration: Add owner title variable for Flow AbuseFilter - https://phabricator.wikimedia.org/T161774#3291713 (10Krinkle) [13:02:33] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Scoring-platform-team, 05MW-1.29-release-notes: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3291743 (10Krinkle) [13:20:08] 06Collaboration-Team-Triage, 10Flow, 05MW-1.29-release-notes: Workflow ID null for some user talk pages on gomwiki - https://phabricator.wikimedia.org/T154623#3291778 (10Krinkle) Is this resolved? [13:31:56] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: ERI Metrics: Measure click-through actions from RC page and create 'Productivi... - https://phabricator.wikimedia.org/T158458#3291799 [13:33:57] 10MediaWiki-Recent-changes, 10MediaWiki-General-or-Unknown, 05MW-1.29-release-notes, 13Patch-For-Review: Non-anchored popups don't align correctly - https://phabricator.wikimedia.org/T159906#3291815 (10Krinkle) [14:10:17] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Possible-Tech-Projects, and 2 others: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#3291960 (10Stevietheman) >>! In T123866#3291673, @MGChecker wrote: > Yes,... [14:15:57] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 13Patch-For-Review: pagetriagelist API does not list any pages - https://phabricator.wikimedia.org/T154115#3291996 (10Krinkle) [14:16:00] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 13Patch-For-Review: Transwiki (within a farm) support for Flow dumps/imports - https://phabricator.wikimedia.org/T154830#3291993 (10Krinkle) [14:16:18] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: Simultaneous edits to posts can cause an exception for the losing party - https://phabricator.wikimedia.org/T150430#3292004 (10Krinkle) [14:16:24] 06Collaboration-Team-Triage, 10Flow, 10DBA, 13Patch-For-Review, 07Schema-change: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#3292006 (10Krinkle) [14:16:37] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Vagrant, 13Patch-For-Review: Import PageTriage dumps into MediaWiki-Vagrant - https://phabricator.wikimedia.org/T145891#3292010 (10Krinkle) [15:06:14] 10MediaWiki-Recent-changes, 10DBA, 10MediaWiki-Database: Special:RecentChanges can show recently created page as red link - https://phabricator.wikimedia.org/T129399#3292197 (10Krinkle) 05Open>03Invalid Closing for now until we can reproduce this again. [15:14:18] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): Audit Collaboration Team schemas and see if we want to request different purging policies for any - https://phabricator.wikimedia.org/T166245#3289659 (10Nuria) Our deadline to have all data in compliance is this quarter, now, you can off course set up wh... [15:27:38] 06Collaboration-Team-Triage, 10Flow: There's no interface to add an image to a Flow post - https://phabricator.wikimedia.org/T166315#3292284 (10Amire80) [16:19:33] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [16:20:12] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348768 (owner: 10Zfilipin) [16:26:03] (03PS2) 10Zfilipin: Echo should notify a user who watches a Flow board when another user creates a new topic there [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348774 (https://phabricator.wikimedia.org/T146916) [16:26:29] (03PS2) 10Zfilipin: Echo should notify an author of a Flow topic when another user posts a reply [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348769 (https://phabricator.wikimedia.org/T146916) [16:26:58] (03PS3) 10Zfilipin: Echo should notify new user about Flow mention on Flow talk page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348764 (https://phabricator.wikimedia.org/T146916) [16:31:16] (03CR) 10Zfilipin: "@Mattflaschen oops, looks like I have somehow missed the last number in the phabricator task, I have fixed it in a several commits. Thanks" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [19:25:36] (03CR) 10Chad: [C: 031] Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [20:16:05] RoanKattouw, I'll do the Deployment planning unless you started it. I was going to yesterday (before I got sick), and I'm trying to get in the habit of doing it anyway for Scrum of Scrums. Just let me know. [20:16:17] Go for it [20:21:20] Getting a *really* weird git error: [20:21:23] matthew@matthew-zenbook: ~/Code/Wikimedia/vagrant-latest/mediawiki (master↓78|…)% git pull [20:21:24] Killed [20:21:30] That's it, it just says "Killed" [20:27:42] mooeypoo, I think the only problem is you're using 'nsinvert', when it should be 'invert'. [20:27:56] Let me know if that works, otherwise I'll confirm after my meeting with Roan. [20:36:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/355674 (owner: 10L10n-bot) [20:36:44] matt_flaschen, ... really? but.. I... could've sworn I checked [20:37:33] matt_flaschen, omg you're right [20:37:51] you know, I had it as invert= and for some reason I went and purposefully CHANGED IT... I could've sworn.... [20:37:57] where did i see nsinvert... [20:38:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355677 (owner: 10L10n-bot) [20:39:12] matt_flaschen, it's annoying, though. "invert" sounds like it should be general, while it really is only for namespaces. If we ever decide to add an "invert" method to *any* of the other groups, we'll have to add another parameter that will be confusing :\ but not a lot we can do about this [20:45:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Consider unifying the "user registration" and "experience level" groups - https://phabricator.wikimedia.org/T165160#3293280 (10jmatazzoni) [20:47:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Unify the "user registration" and "experience level" groups - https://phabricator.wikimedia.org/T165160#3258637 (10jmatazzoni) [20:47:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Unify the "user registration" and "experience level" groups - https://phabricator.wikimedia.org/T165160#3293292 (10jmatazzoni) a:03jmatazzoni Moving this to Product Design and assigning myself to think through any... [20:49:35] mooeypoo, it's the ID... [20:49:38] (nsinvert) [20:49:44] matt_flaschen, ... it is :\ [20:50:11] matt_flaschen, .... I feel silly, but at least with SOME justification :P [20:50:23] I fixed it in the code now, but I'm also adding unit tests -- will push in a few [21:07:53] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Unify the "user registration" and "experience level" groups - https://phabricator.wikimedia.org/T165160#3258637 (10Mattflaschen-WMF) If we do this, we will probably want to deprecate the old parameters (hideanons and... [21:08:18] mooeypoo, no, it's silly that a. they're different b. the ID is the good one (but ID probably came later). [21:13:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Back button not letting me back away from RC Page - https://phabricator.wikimedia.org/T166347#3293361 (10jmatazzoni) [21:21:44] mooeypoo, oh, yeah, I forgot. Try: [21:21:48] pushd /tmp [21:21:53] pushd /var/ [21:21:56] pushd ~ [21:21:57] popd [21:22:08] Works for any depth. [21:31:43] What's that for? [21:32:09] .... are you laughing at my 'push in a few' reference? [21:34:33] (03CR) 10Chad: [C: 032] Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [21:41:31] (03CR) 10jerkins-bot: [V: 04-1] Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:08:59] (03PS5) 10Paladox: Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) [22:09:57] (03CR) 10Reedy: [C: 04-1] "File should have .sql extension" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:10:39] (03PS6) 10Paladox: Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) [22:10:53] (03CR) 10Paladox: "> File should have .sql extension" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:12:35] (03CR) 10jerkins-bot: [V: 04-1] Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:13:10] (03PS7) 10Paladox: Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) [22:15:10] (03CR) 10Reedy: [C: 04-1] Only drop flow_ext_ref_idx_v2 index if it exists. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:16:18] (03PS8) 10Paladox: Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) [22:16:30] (03CR) 10Paladox: Only drop flow_ext_ref_idx_v2 index if it exists. (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:28:28] (03PS9) 10Paladox: Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) [22:41:30] RoanKattouw, matt_flaschen https://gerrit.wikimedia.org/r/353201 <-- namespaces! It's not gated yet, but it also depends on the url fix. If we agree to gate this, I'll do that tomorrow - but i could use review on it, and since it's a large commit, we should probably start on both (this and the dependent URL commit) [22:41:43] Also, it works now that I fixed the ... 'typo'... for nsinvert (thanks matt_flaschen ;) [22:52:41] Yay [22:52:49] Also it's 2am, go to bed mooey|away [22:53:55] (03CR) 10Catrope: [C: 031] Only drop flow_ext_ref_idx_v2 index if it exists. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [22:54:39] matt_flaschen: Could you review --^^ ? It's been touched by a bunch of people, so I figured I'd ask an uninvolved person to review [22:59:36] RoanKattouw, that looks more in the spirit of how it's supposed to work. Looks good, testing now. [23:13:33] (03CR) 10Mattflaschen: [C: 04-1] "First, the commit message needs to be updated." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/355448 (https://phabricator.wikimedia.org/T166266) (owner: 10Paladox) [23:14:49] RoanKattouw, it's deleting the new correct flow_ext_ref_idx_v2 and then not re-creating it. [23:15:01] See cover comment for explanation [23:15:13] oooh [23:15:33] I see [23:15:37] And I like your v3 idea [23:16:40] 06Collaboration-Team-Triage, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 03Google-Summer-of-Code (2017): Implement Thanks support in Pywikibot - https://phabricator.wikimedia.org/T161426#3293607 (10happy5214)