[08:01:43] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266430 (10Marostegui) s3 in codfw is done - small example ``` root@db2018:/tmp# for i in `mysql --skip-ssl -e "select table_schema... [08:02:06] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266431 (10Marostegui) [08:08:18] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266440 (10Marostegui) [08:29:52] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266472 (10Marostegui) 05Open>03Resolved Everything is looking good. The only host which still doesn't have the new column is d... [08:29:57] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266480 (10Marostegui) [09:08:58] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, and 2 others: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error"... - https://phabricator.wikimedia.org/T165209#3266563 [09:38:16] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266637 (10Addshore) >>! In T130067#3266472, @Marostegui wrote: > Everything is looking good. > The only host which still doesn't h... [09:47:34] 22:47:36 <+mooeypoo> RoanKattouw, is there a way to fake mw.Uri for unit tests? [09:47:51] I actually don't know, but that would be quite useful [10:02:13] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3266799 (10Marostegui) >>! In T130067#3266637, @Addshore wrote: >>>! In T130067#3266472, @Marostegui wrote: >> Everything is lookin... [10:04:25] (03CR) 10Catrope: [C: 032] Avoid DB_MASTER queries on HTTP GET in ArticleMetadata->getMetadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/353824 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [10:05:14] 06Collaboration-Team-Triage, 10Flow: When the relative time indicator of a Flow post is longer that the date, the date link blinks when hovered - https://phabricator.wikimedia.org/T165471#3266814 (10Trizek-WMF) [10:06:23] (03Merged) 10jenkins-bot: Avoid DB_MASTER queries on HTTP GET in ArticleMetadata->getMetadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/353824 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [10:24:02] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-fron... - https://phabricator.wikimedia.org/T165209#3266888 [10:25:58] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog: SkinMinerva shouldn't know about Echo service - https://phabricator.wikimedia.org/T165190#3266907 (10Jdlrobson) p:05Triage>03Normal [10:38:02] (03PS1) 10Catrope: TalkpageManager: Add non-master mode to checkIfCreationIsPossible() for API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/353966 (https://phabricator.wikimedia.org/T165251) [10:48:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3267036 (10Catrope) >>! In T164997#3254587, @Pginer-WMF wrote: > I also assume that the "[Low]... [10:54:49] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Actions done on RC filters and what is stored in browser history doesn't match - https://phabricator.wikimedia.org/T165168#3267064 (10Catrope) @Mooeypoo , do you think this is a duplicate of {T165230} ? [10:56:47] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: ?action=info incorrectly states that a new page is indexed when not - https://phabricator.wikimedia.org/T157747#3267075 (10Catrope) [10:56:49] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page information claims indexing allowed when PageTriage causes noindex on new articles - https://phabricator.wikimedia.org/T165204#3267077 (10Catrope) [11:01:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Consider unifying the "user registration" and "experience level" grups - https://phabricator.wikimedia.org/T165160#3267102 (10Catrope) Interesting! Yes, that would work. Each of the experience-related filters would be a subset of the "Registered"... [13:41:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: wikipage.content is fired twice on RC load with new filters - https://phabricator.wikimedia.org/T165350#3267585 (10Catrope) [14:01:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 13Patch-For-Review: Find a way to minimize the RCFilters URL - https://phabricator.wikimedia.org/T165445#3266050 (10Catrope) Re #1: ignoring highlight/nsinvert seems fine, but I also wouldn't object too much if you didn't ignore them. Re #2: OK, so th... [14:09:04] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 07User-notice-collaboration: Enable Flow on all talk pages on Catalan Wikipedia - https://phabricator.wikimedia.org/T165497#3267661 (10Trizek-WMF) [14:33:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Anti-Harassment, 06Support-and-Safety, and 3 others: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3267731 (10Nemo_bis) [15:23:38] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 13Patch-For-Review, 07Wikimedia-log-errors: Class undefined: LoggerFactory in Event.php - https://phabricator.wikimedia.org/T161837#3144805 (10greg) [15:23:38] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 13Patch-For-Review, 07Wikimedia-log-errors: Class undefined: LoggerFactory in Event.php - https://phabricator.wikimedia.org/T161837#3267878 (10greg) [17:14:42] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Provide links to other projects' Recent Changes pages in the same language - https://phabricator.wikimedia.org/T164952#3268494 (10Catrope) [17:26:08] 06Collaboration-Team-Triage, 10Flow: Change Flow Beta activation message to emphase page archiving - https://phabricator.wikimedia.org/T165140#3268703 (10Trizek-WMF) p:05Triage>03Low a:03Trizek-WMF I'll draft something. [17:27:22] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Consider unifying the "user registration" and "experience level" groups - https://phabricator.wikimedia.org/T165160#3268721 (10Trizek-WMF) [17:59:34] 06Collaboration-Team-Triage, 10Flow, 10Wikimedia-Site-requests, 07User-notice-collaboration: Enable Flow on all talk pages on Catalan Wikiquote - https://phabricator.wikimedia.org/T165497#3268800 (10Catrope) [18:45:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] When all saved filters removed form 'Quick links' - the empty placeholder is displayed - https://phabricator.wikimedia.org/T165102#3268922 (10Etonkovidova) [18:50:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] When all saved filters removed form 'Quick links' - the empty placeholder is displayed - https://phabricator.wikimedia.org/T165102#3268935 (10Etonkovidova) Fixed with adding "Save your favorite tool settings..." {F8101109} **QA Recomme... [18:53:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [minor] When all saved filters removed form 'Quick links' - the empty placeholder is displayed - https://phabricator.wikimedia.org/T165102#3268943 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Low [18:59:42] (03CR) 10Aaron Schulz: [C: 032] TalkpageManager: Add non-master mode to checkIfCreationIsPossible() for API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/353966 (https://phabricator.wikimedia.org/T165251) (owner: 10Catrope) [19:00:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: Highlighted items in a default saved query always appear on refresh - https://phabricator.wikimedia.org/T165231#3260700 (10Etonko... [19:04:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 13Patch-For-Review: Find a way to minimize the RCFilters URL - https://phabricator.wikimedia.org/T165445#3269008 (10Mooeypoo) >>! In T165445#3267633, @Catrope wrote: > Re #1: ignoring highlight/nsinvert seems fine, but I also wouldn't object too much i... [19:11:46] (03Merged) 10jenkins-bot: TalkpageManager: Add non-master mode to checkIfCreationIsPossible() for API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/353966 (https://phabricator.wikimedia.org/T165251) (owner: 10Catrope) [19:12:06] (03CR) 10jenkins-bot: TalkpageManager: Add non-master mode to checkIfCreationIsPossible() for API [extensions/Flow] - 10https://gerrit.wikimedia.org/r/353966 (https://phabricator.wikimedia.org/T165251) (owner: 10Catrope) [19:14:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: 'Quick links' - blank names for saved filters - https://phabricator.wikimedia.org/T165113#3269019 (10Etonkovidova) Check in beta... [19:39:18] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: RC filters bookmarks issues - https://phabricator.wikimedia.org/T165206#3269084 (10Etonkovidova) [19:41:02] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review, 07Regression: [regression] Refreshing the page makes filters vanish - https://phabricator.wikimedia.org/T165230#3260682 (10Etonkovidova) The issue seems to be relat... [20:41:05] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 13Patch-For-Review: Find a way to minimize the RCFilters URL - https://phabricator.wikimedia.org/T165445#3269239 (10Mooeypoo) I removed 'WIP' tag from the patch and fixed the 'highlight' parameter to be ignored when looking for emptiness. [20:41:09] stephanebisson, fyi https://gerrit.wikimedia.org/r/#/c/353925/ [20:41:28] mooeypoo: on it [20:41:31] Plus the above task for info/discussion on potential challenges [20:41:57] stephanebisson, the URL looks so much nicer when it's not insanely long... [20:42:47] mooeypoo: I bet. It's been bothering me for a while. Even more so now that I'm trying to do pagination by working mostly with the URL. [20:43:18] stephanebisson, yeah and when I added namespaces, it's a huge amount of more params + their highlights [20:43:21] gotten insane [20:43:51] Ad we were saying that we might pre-load tags (about 100 more params + highlights!?) [20:43:56] it was time to re-examine [20:44:28] oh wait, namespaces and tags are "string_options" - the isue wasn't their params, it was just the highlight param_color thing [20:46:54] stephanebisson, also, I wanted to add a bunch of param-to-URI and vise versa tests, seeing as "highlight=1" issue was coming back up again and again -- but I couldn't find a way to mock mw.Uri properly [20:47:18] there are other things that could use more direct unit tests but are a little hard to test directly... may need some creative solutions [21:54:02] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: ?action=info incorrectly states that a new page is indexed when not - https://phabricator.wikimedia.org/T157747#3269424 (10Xaosflux) [22:32:00] 10MediaWiki-Recent-changes, 05MW-1.29-release: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php - https://phabricator.wikimedia.org/T163154#3269537 (10Legoktm) a:03Legoktm The bug appears to be that even if the cache is corrupt, we don't invalidate t... [22:38:26] 10MediaWiki-Recent-changes, 05MW-1.29-release: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php - https://phabricator.wikimedia.org/T163154#3269544 (10Legoktm) Also there's another problem that because a new TemplateParser instance is created every tim... [22:45:31] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Add filter group for 'Last revision' to the RC Filters - https://phabricator.wikimedia.org/T163561#3201674 (10Etonkovidova) **QA Recommendation: Resolve** @jmatazzoni... [23:40:53] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [minor] Bookmarking no-effect filters results in 'No active filters. All contributions are shown" - https://phabricator.wikimedia.org/T165550#3269674 (10Etonkovidova) [23:41:55] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: RC filters bookmarks issues - https://phabricator.wikimedia.org/T165206#3259967 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Normal [23:43:46] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: RC filters bookmarks issues - https://phabricator.wikimedia.org/T165206#3269694 (10Etonkovidova) (1) and (2) are resolved (with the fix in {T165231}); (3) is split into {T165550}.