[00:16:14] 06Collaboration-Team-Triage, 10Flow: ApiFlow master queries on HTTP GET - https://phabricator.wikimedia.org/T165251#3261297 (10aaron) [04:58:18] 06Collaboration-Team-Triage, 10Notifications: Echo email notifications not being sent - https://phabricator.wikimedia.org/T165248#3261384 (10Reception123) @Aklapper Yes, the email server (as well as the jobs) are running and working perfectly. The email server works with Special:EmailUser and any other email s... [08:34:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Explore more subtle way to indicate filter loading status - https://phabricator.wikimedia.org/T165286#3261971 (10Pginer-WMF) [08:51:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Consider unifying the "user registration" and "experience level" grups - https://phabricator.wikimedia.org/T165289#3262023 (10Pginer-WMF) [08:58:18] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Consider unifying the "user registration" and "experience level" grups - https://phabricator.wikimedia.org/T165289#3262041 (10Trizek-WMF) [08:58:20] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Patrol IP edits and newcomers edits at the same time is not possible - https://phabricator.wikimedia.org/T165160#3262044 (10Trizek-WMF) [08:59:31] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Consider unifying the "user registration" and "experience level" grups - https://phabricator.wikimedia.org/T165160#3258637 (10Trizek-WMF) [09:01:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3262076 (10Pginer-WMF) [09:06:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Consider unifying the "user registration" and "experience level" grups - https://phabricator.wikimedia.org/T165160#3262097 (10Pginer-WMF) >>! In T165160#3260494, @Catrope wrote: > I can think of two ways to address this, but they both have issues... [09:27:33] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Explore more subtle way to indicate filter loading status - https://phabricator.wikimedia.org/T165286#3261971 (10Trizek-WMF) Why don't we use the visual editor loading bar? It may be too much. {F8081584} [09:29:33] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message - https://phabricator.wikimedia.org/T165209#3262164 (10Jdlrobson) p:05Triage>03Unbreak! Urg. I can als... [09:39:21] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message - https://phabricator.wikimedia.org/T165209#3260043 (10Jdlrobson) @greg is there any... [10:16:53] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message - https://phabricator.wikimedia.org/T165209#3262360 (10Jdlr... [10:31:46] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Stewards-and-global-tools, and 2 others: Define a process to attribute Flow creator rights to (a group of) users on wikis where Flow is deployed - https://phabricator.wikimedia.org/T165305#3262425 (10Trizek-WMF) [10:32:24] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Stewards-and-global-tools, and 2 others: Define a process to attribute Flow creator rights to (a group of) users on wikis where Flow is deployed - https://phabricator.wikimedia.org/T165305#3262425 (10Trizek-WMF) p:05Triage>03No... [10:47:21] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Stewards-and-global-tools, and 2 others: Define a process to attribute Flow creator rights to (a group of) users on wikis where Flow is deployed - https://phabricator.wikimedia.org/T165305#3262477 (10Trizek-WMF) [13:01:21] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Installer: Echo DB Bug - https://phabricator.wikimedia.org/T165317#3262866 (10Mainframe98) [13:19:37] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement, 06Stewards-and-global-tools, and 2 others: Define a process to attribute Flow creator rights to (a group of) users on wikis where Flow is deployed - https://phabricator.wikimedia.org/T165305#3262425 (10MarcoAurelio) The flow-bot rig... [13:21:33] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Installer: Echo DB Bug - https://phabricator.wikimedia.org/T165317#3262955 (10Aklapper) Thanks for taking the time to report this. Unfortunately this report lacks some information. If you have time and can still reproduce the problem, please [[ https:... [13:22:12] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Installer: When installing Echo and running the web updater, Echo's DB tables do not get created - https://phabricator.wikimedia.org/T165317#3262956 (10Aklapper) [13:42:04] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Installer: When installing Echo and running the web updater, Echo's DB tables do not get created - https://phabricator.wikimedia.org/T165317#3263056 (10LegoFan4000) [14:45:07] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 13Patch-For-Review, 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message - https://phabricator.wikimedia.org/T165209#3263276 (10greg... [14:57:03] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error" popup message - https://phabricator.wikimedia.org/T165209#3263361 (10Jdlrobson) Facepalm. Thou... [16:34:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: wikipage.content is fired twice on RC load with new filters - https://phabricator.wikimedia.org/T165350#3263860 (10eranroz) [16:51:32] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-fron... - https://phabricator.wikimedia.org/T165209#3260043 [16:51:56] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-fron... - https://phabricator.wikimedia.org/T165209#3260043 [17:13:47] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 03Reading-Web-Kanban-Board, 07Unplanned-Sprint-Work: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-fron... - https://phabricator.wikimedia.org/T165209#3264123 [17:54:49] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Special:NewPagesFeed unreviewed filter is also including pages nominated for deletion - https://phabricator.wikimedia.org/T165365#3264211 (10kaldari) [18:25:11] 06Collaboration-Team-Triage, 10Notifications, 10Timeless: Timeless + echo results in exception for logged in users - https://phabricator.wikimedia.org/T141894#3264480 (10matmarex) a:05Isarra>03Bawolff Looks like it has been fixed in {9613a9d4bc094c83238ae9aaa93158c19ab9e908} by @Bawolff. [18:33:50] etonkovidova, I just realized something... the bug about not recognizing existing bookmark -- can you try it with a fresh user that didn't have saved queries yet ? Save new queries, see if that happens again? [18:34:13] mooeypoo: sure - a very good idea [18:34:17] I think I may have changed something that if you had a previously saved query it won't recognize it anymore, but it should recognize new [18:34:54] (likely the spelling of 'highlight'/'highlights' [18:34:56] ) [18:36:50] mooeypoo: sigh - nope, the same behavior for a totally new user [18:38:35] damnit [18:38:54] I'm testing to see if I get it on master [18:39:12] ... when vagrant cooperates [18:43:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Saved filter name not displayed and the bookmark icon displayed all the time - https://phabricator.wikimedia.org/T165381#3264571 (10Etonkovidova) [18:43:54] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review, and 2 others: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error"... - https://phabricator.wikimedia.org/T165209#3264583 [18:52:57] etonkovidova, can you test if it recognizes your default saved query on first-load? It does for me? [18:53:39] It seems to be selective in what it recognizes. Meh. It recognizes some of my saved queries nd not all. [18:53:46] mooeypoo: "recognizes" - meaning that the bookmark icon is not displayed anymore? [18:53:58] mooeypoo: hmm... [18:54:02] And the name of the query is after "Active filters" [18:54:51] mooeypoo: I do not see the name of the query - ever [18:55:51] hm [18:56:36] mooeypoo: aha! I see the *first* query name! [18:56:55] Hm, only the first? [18:57:07] mooeypoo: does not matter how long time ago \ it was saved or anything else [18:57:22] hm [18:57:30] I have some that work and some don't, not just the first [18:57:35] this is weird. I'm looking into the comparisons [18:58:19] Bingo [18:58:29] Found it [18:58:38] mooeypoo: you're right - I found a user whose all queries display a name [18:58:42] * mooeypoo mutters [18:58:55] Yeah, it's due to the typo/string-storage fixes [18:59:03] I'm fixing now [18:59:09] mooeypoo: great! [19:00:14] I seemed to have stored highlight="1" instead of highlight=true (it's filter storage, not params) [19:00:22] went a bit too zealously on the "make sure we store strings" bit [19:00:33] I'm fixing + providing back-compat [19:05:13] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, and 2 others: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error"... - https://phabricator.wikimedia.org/T165209#3264714 [19:08:16] RoanKattouw, matt_flaschen what's the problem with this: normalizedData.highlights.highlight = !!Number( normalizedData.highlights ); [19:08:33] Hint: I just removed all the highlights in my saved queries [19:08:36] * mooeypoo mutters about spelling [19:14:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: [betalabs-regression] Saved filter name not displayed and the bookmark icon displayed all the time - https://phabricator.wikimedia.org/T165381#3264795 (10Mooeypoo) a:03Mooeypoo [19:15:10] RoanKattouw, can you review https://gerrit.wikimedia.org/r/#/c/353911/ ? [19:15:19] or add to your reviewing queue or whatever [19:17:45] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, and 2 others: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error"... - https://phabricator.wikimedia.org/T165209#3264821 [19:25:32] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog: SkinMinerva shouldn't know about Echo service - https://phabricator.wikimedia.org/T165190#3264911 (10Jdlrobson) Ideally all the code in mobilefrontend should be in the Echo extension. [19:44:46] 10MediaWiki-Watchlist, 06Reading-Web-Backlog, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, and 2 others: Watchstar feature broken: Tapping the watchlist star while logged in results in "mobile-frontend-watchlist-error"... - https://phabricator.wikimedia.org/T165209#3264986 [20:23:51] etonkovidova, the fix is merged, it should be on beta soon [20:24:22] etonkovidova, it was merged 15 minutes ago or so, so it might actually be on beta already [20:24:59] mooey|lunch: ok, thx [20:25:19] Saved queries should be recognized now.... hopefully.... [20:38:22] mooey|lunch: yup - all seems to be fixed [20:41:36] \o/ [20:47:36] RoanKattouw, is there a way to fake mw.Uri for unit tests? [20:49:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), 13Patch-For-Review: [betalabs-regression] Saved filter name not displayed and the bookmark icon di... - https://phabricator.wikimedia.org/T165381#3265147 [21:01:10] 06Collaboration-Team-Triage, 10Flow, 10ArchCom-RfC, 10MediaWiki-General-or-Unknown, 06MediaWiki-Platform-Team: Drop requirement to define a talk namespace for every subject namespace - https://phabricator.wikimedia.org/T165149#3265161 (10daniel) Hm... what should getPrefixedText() return for a title with... [21:13:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): [betalabs] TypeError: Morebits.userIsInGroup is not a function for certain users - https://phabricator.wikimedia.org/T165402#3265213 (10Etonkovidova) [21:14:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): [betalabs] 'TypeError: Morebits.userIsInGroup is not a function' error displayed for certain users - https://phabricator.wikimedia.org/T165402#3265227 (10Etonkovidova) [21:16:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Do not rebind and blindly override onMenuToggle in FilterTagMultiselectWidget - https://phabricator.wikimedia.org/T164228#3226449... [21:31:58] 06Collaboration-Team-Triage, 10Notifications, 10MobileFrontend, 06Reading-Web-Backlog: SkinMinerva shouldn't know about Echo service - https://phabricator.wikimedia.org/T165190#3265271 (10pmiazga) @Jdlrobson and this approach will allow that - we just need some DI with tagging and we will be able to defin... [22:05:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): [betalabs] 'TypeError: Morebits.userIsInGroup is not a function' error displayed for certain users - https://phabricator.wikimedia.org/T165402#3265505 (10Aklapper) Similar to T164630 (which welcomes an update): Someone needs to fix https://en.wikipedia.b... [22:14:04] mooeypoo: ahh.... highlighting is acting out again: re-load the page preserves highlighting; navigating away from RC page or reload from Quick links the filter with highlighting - highlighting will be gone. Very weird - how navigating away is different from a page reload? [22:18:35] hm [22:18:37] shouldn't be [22:20:32] mooeypoo: exactly - argh [22:20:51] :\ [22:21:15] mooeypoo: but technically https://phabricator.wikimedia.org/T165231 is, in fact, fixed [22:26:33] etonkovidova, can you submit a task with exactly when the highlights fail to load? With or without default saved query, or just URL, etc? [22:26:53] mooeypoo: yes, will do [22:32:50] I think I came up with a way to minimize our insane URLs [22:41:52] Pretty sure I have, but it will require some massive testing. [22:42:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Regression: [betalabs-regression] Highlighting is not preserved for saved filters - https://phabricator.wikimedia.org/T165437#3265906 (10Etonkovidova) [22:43:08] mooeypoo: https://phabricator.wikimedia.org/T165437 - highlighting is not preserved [22:44:20] AGAIN... ? meh [22:44:33] ok, wait, this is just for saved filters [22:44:40] it's not for "normal" workflow...? [22:44:49] mooeypoo: it's a different scenario [22:44:58] ok phew, I was afraid this means the SWAT we're doing is meaningless [22:45:00] mooeypoo: reloading the page is fine [22:45:07] ok great [22:45:13] I am probably once again not saving things right [22:45:19] I'll take a look [22:45:30] mooeypoo: thx [22:46:34] etonkovidova, I am prepping for the swat, just wanted to make sure that I can see the bug so I can test it when the swat happens, and I can't see the bug------ then I realized "oh, right, I'm on Beta." [22:50:05] mooeypoo: :) [23:40:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Regression: [betalabs-regression] monobook: Highlight button displays checkmark - https://phabricator.wikimedia.org/T165444#3266038 (10Etonkovidova) [23:41:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): Find a way to minimize the RCFilters URL - https://phabricator.wikimedia.org/T165445#3266050 (10Mooeypoo) [23:42:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Regression: [betalabs-regression] monobook: cannot de-select a selected filter - https://phabricator.wikimedia.org/T165446#3266071 (10Etonkovidova)