[00:01:45] How come PHP supports + for arrays, but you have to use array_diff for subtraction? [00:01:47] #AskTheQuestion [00:04:11] haha [00:21:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 05MW-1.30-release-notes, 13Patch-For-Review: Support multiple values for the namespace parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164132#3253839 (10Etonkovidova) Re-check... [00:59:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Get stats on how frequently RC Page related links (at page top) are clicked - https://phabricator.wikimedia.org/T164617#3253876 (... [02:45:31] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" b... - https://phabricator.wikimedia.org/T158458#3037669 [03:37:22] RoanKattouw, do you know how I fix https://gerrit.wikimedia.org/r/#/c/353212/ ? Should I commit to mediawiki/vendor? [03:38:04] Let me remind myself of how OOUI does this [03:39:14] It looks like you update vendor, then make the core commit depend on the vendor commit [03:40:18] Not sure if Depends-On doesn't work or if the OOUI process just doesn't use it [03:40:53] Aha! [03:40:58] Depends-On does work [03:41:01] matt_flaschen: See https://gerrit.wikimedia.org/r/#/c/348880/ for a model [03:42:35] RoanKattouw, thanks. Something is being weird with my vendor clone, but I think I'll figure that out. [03:43:08] matt_flaschen: While you're here, can I sign you up to SWAT https://gerrit.wikimedia.org/r/#/c/353211/ tomorrow during a SWAT window of your choice? [03:44:41] Krinkle pinged me at 4am his local time (of course) asking me to SWAT that patch tomorrow, but I'll be on planes all day [03:46:41] RoanKattouw, yep, I can do the 11 AM. I'll only be on a train part of *one* of the SWAT windows (the 4 PM). [03:46:45] 11 AM your time. [03:46:54] OK I'll sign you up for that one then [03:47:11] RoanKattouw, apparently I don't change vendor very often: https://github.com/wikimedia/mediawiki-vendor/commit/886ccf446e775fafe5d279484981b041e3d4c5d6 [03:47:13] That was breaking it. [03:47:31] Wow [03:47:35] That's a long time to not touch a repo [03:48:09] Technically I have two trees, so it's possible I used the other more recently. [05:57:35] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3254102 (10Marostegui) s1 in codfw is done: ``` root@neodymium:~# mysql --skip-ssl -hdb2016.codfw.wmnet enwiki -e "show create tab... [05:58:07] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3254103 (10Marostegui) [08:51:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3254387 (10Trizek-WMF) > Likely have problems [Low] > Likely have problems [High] After a fir... [10:15:37] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, and 3 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3254567 (10Trizek-WMF) >>! In T165011#3254561, @Ladsgroup wrote: > I... [10:24:44] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, and 3 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3254577 (10Trizek-WMF) Maybe a side effect: it is not possible to ch... [10:34:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3254587 (10Pginer-WMF) > Roan suggested one way to solve the problem: we can create "new" filt... [11:43:20] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3254729 (10Pginer-WMF) [11:56:00] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3254742 (10Pginer-WMF) [11:56:54] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, and 3 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3254756 (10Lea_Lacroix_WMDE) >>! In T165011#3254577, @Trizek-WMF wro... [12:02:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3254767 (10Trizek-WMF) > always... [14:18:46] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 3 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255190 (10Halfak) [14:28:47] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 3 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3254155 (10Etonkovidova) wikidata1.30.0-wmf.1 Special:Preferences - [WRR0Dg... [14:37:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Scoring-platform-team: Define a process for adding ORES filters to new wikis when ORES is enabled on those wikis - https://phabricator.wikimedia.org/T164331#3255260 (10Halfak) [15:08:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Click on "no thanks" on the invitation to enable the New filters doesn't work on Wikidata - https://phabricator.wikimedia.org/T165048#3255342 (10Trizek-WMF) [15:09:32] stephanebisson, you may vouloir to have a look at this last bug. [15:11:03] Trizek: most likely a consequence of T165011. API calls to set preferences problably fail the same way as the page. [15:11:03] T165011: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011 [15:11:19] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 3 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255363 (10Catrope) a:05Ladsgroup>03Catrope [15:11:28] Like I guessed. Thanks stephanebisson. [15:17:28] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255414 (10Ladsgroup) Well, I was working on it but I will happy to help and... [15:17:41] stephanebisson, matt_flaschen: https://gerrit.wikimedia.org/r/353311 [15:19:39] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255420 (10Catrope) >>! In T165011#3255414, @Ladsgroup wrote: > Well, I was... [15:21:39] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255438 (10Ladsgroup) Okay, I get your patch deployed ASAP. [15:36:45] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255498 (10Ladsgroup) I deployed Roan's patch and everything seems fine. Fe... [15:38:53] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255499 (10Ladsgroup) 05Open>03Resolved [15:41:22] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3255523 (10Ladsgroup) [16:30:14] (03PS2) 10Etonkovidova: Echo should notify user about new edits on user talk page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [16:31:40] (03PS3) 10Etonkovidova: Echo should notify new user about wikitext mention on Flow talk page 'flow-mention' notification Bug:T146916 Change-Id: I7b84d57a97b995ce8518223a3a429d783399209c [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348768 (owner: 10Zfilipin) [16:34:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Click on "no thanks" on the invitation to enable the New filters doesn't work on Wikidata - https://phabricator.wikimedia.org/T165048#3255831 (10Trizek-WMF) 05Open>03Resolved a:03Trizek-WMF Apparently, it is solved because of {T165011}. [16:37:22] (03CR) 10jerkins-bot: [V: 04-1] Echo should notify user about new edits on user talk page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [16:39:05] (03CR) 10jerkins-bot: [V: 04-1] Echo should notify new user about wikitext mention on Flow talk page 'flow-mention' notification Bug:T146916 Change-Id: I7b84d57a97b995ce8518223a3a429d783399209c [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348768 (owner: 10Zfilipin) [16:46:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: [betalabs] ERR_TOO_MANY_REDIRECTS when RC preference option "Show only likely... - https://phabricator.wikimedia.org/T164625#3255891 [18:04:50] Correction to what I said in the meeting, looks like Wikidata used to be the only soft, not the only hard. [18:27:08] matt_flaschen, in a wonderful display of good timing (not) my computer refused to recognize wifi, and I had to reboot -- just checking in to see if you need anything or pinged me [18:27:38] mooeypoo, I think I'm almost done. Will ping you soon if not. [18:27:43] * mooeypoo nods [18:28:06] 06Collaboration-Team-Triage, 10MediaWiki-User-preferences, 10MediaWiki-extensions-ORES, 06Scoring-platform-team, and 4 others: Global default 'hard' is invalid for field oresDamagingPref - https://phabricator.wikimedia.org/T165011#3256323 (10Ladsgroup) This new config is causing a huge logspam of "Notice:... [18:28:12] mooeypoo, multi-tasking since I also have to monitor the other SWAT (for top links tracking) and they were talking about the bug from this morning which was causing followup log spam. [18:28:16] ^ [18:28:26] eh [18:28:36] today's theme seems to be "Good Timing" [18:28:44] (Bad) [18:29:00] mooeypoo, apparently, "good" timing is also the cause of the logspam issue at a lower-level too. [18:29:16] hah. At least we're consistent.... [18:40:08] matt_flaschen, isn't there also a 4pm PST window? If we need more time, I can be here for that. [18:41:47] mooeypoo, yes, I'm done, but looks like we may need that. [18:43:22] mooeypoo, https://gerrit.wikimedia.org/r/353336 [18:46:21] matt_flaschen, code looks good, testing now [18:47:57] * mooeypoo curses vagrant [18:48:53] mooeypoo, yeah, it froze for me today too. [18:49:10] It's not loading ... ssh crap again. This is frustrating. [18:50:07] https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/13122/console looks like a bogus Jenkins error too. [18:51:05] matt_flaschen, ok, if someone HAD set up a default in the quick links, they won't be able to change their defaults now [18:52:59] mooeypoo, yeah, we should ignore the quick links default, I'll do that. [18:53:10] matt_flaschen, sorry, I forgot about the controller [18:53:13] T165064 [18:53:14] T165064: Segmentation fault in mwext-testextension-hhvm-composer-jessie builds - https://phabricator.wikimedia.org/T165064 [18:53:39] You can just add mw.config.get( 'wgStructuredChangeFiltersEnableSaving' ) to the if statement on line 506 [18:54:19] matt_flaschen, you can let it initialize etc, it's fine for now, don't bother wrapping those things up [18:56:51] matt_flaschen, and I just tested with and without the var -> works [18:56:59] mooeypoo, okay, just ignored it on that line. [18:57:07] Yeah, I tested as well except the default. [18:57:25] mooeypoo, I did see one glitch with removing, then it worked the second time, but I think it may have been pre-existing. [18:57:39] Yeah RoanKattouw has a fix for the removing [18:57:50] he said something yesteday night [18:59:27] I don't know if I fixed a bug but I did clean up that code [19:00:45] matt_flaschen, +2'ed [19:01:18] It's less clean than we'd do it if we weren't rushing but it looks fine and it works. We can clean it up later... and it's temporary anyways. [19:01:36] I just tested, hopefully I didn't miss anything. I tested with =true and =false on that var + testing going back and forth on the defaults [19:01:43] mooeypoo, we'll see if Jenkins cooperates. I doubt it. I fixed the style ones, but there is also a segfault on PHPUnit [19:01:56] crap :\ [19:02:06] well, worse case, I'm here at 4pm [19:02:14] We're missing the window anyways, aren't we? [19:02:15] 18:46:21 /srv/deployment/integration/slave-scripts/bin/mw-phpunit.sh: line 42: 1389 Segmentation fault (core dumped) php -d zend.enable_gc=0 phpunit.php --log-junit "$JUNIT_DEST" "${phpunit_args[@]:-}" [19:02:20] it's 12pm already [19:02:21] mooeypoo, yeah [19:02:31] ok, well, that at least means we don't need to rush as much [19:02:54] RoanKattouw, are you in the air yet? [19:03:34] Reedy is working on the segfaults. [19:03:46] Trying and failing [19:04:00] Hmm [19:04:08] Has my vagrant vm upgraded to newer hhvm? [19:04:09] * Reedy tests [19:05:18] Reedy, how bad is it that I'm slightly amused that you're testing the tests [19:05:36] :( [19:05:38] who tests the tester of the tests? [19:05:45] I'm trying to work out to run phpunit under the right hhvm version.. [19:06:07] I think I saw greg reporting crashes in CI with new HHVM in some channel [19:07:23] bd808: vagrant (ignoring how fscked mine tends to be) should just have the same hhvm as newest in wmf apt repo, right? [19:08:12] yeah, I don't remember if we still force upgrade or not, but we do use the prod hhvm build [19:08:14] ==> default: Notice: /Stage[main]/Hhvm/Package[hhvm]/ensure: ensure changed '3.12.14+dfsg-1+wmf1' to '3.18.2+dfsg-1+wmf2' [19:08:22] looks like it's doing what I hoped it would [19:19:00] mooeypoo, bd808: T165074 [19:19:01] T165074: CI tests failing with segfault - https://phabricator.wikimedia.org/T165074 [19:31:16] James_F: *nod* I think our superhero Reedy is trying to get a backtrace :) [19:31:28] He is, because he's awesome. [19:32:21] true story. I mean he can also be a right git and should not let this praise go to his head, but he is awesome. [19:32:45] I mean, of course it had to happen when we have an urgent patch to add to swat [19:33:10] are we already running that hhvm in prod? [19:33:15] * bd808 checks [19:34:06] 3.12.14+dfsg-1+wmf1 on mw1222. [19:34:31] so it looks like CI is doing its job and catching it before going to prod [19:34:44] etonkovi_, I can't reproduce the bug you talked about [19:34:57] could get ops to roll the apt package back [19:35:11] etonkovidova, if you have a minute for a hangout, you can show me? [19:35:20] There's also a handful of boxes in prod running newer hhvm [19:35:23] mooeypoo: sure [20:00:23] is 'reuse' not a word? Do we need re-use? [20:09:55] mooeypoo: "Re-use" in British English and maybe Canadian English. I think in American English it's not-wrong but seems odd. [20:12:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC page 'Quick links' button placed too close to top links - https://phabricator.wikimedia.org/T165095#3256696 (10Etonkovidova) [20:33:59] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Scoring-platform-team: ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems" - https://phabricator.wikimedia.org/T163757#3208414 (10Etonkovidova) The filter comb... [21:04:55] James_F, my spell-check says reuse is fine. [21:05:23] ARE YOU ARGUING WITH SPELL CHECKE--- wait, sorry, sorry, I forgot who I was talking to. You **are** spell check. [21:05:24] mooeypoo: Yes, that's what I said. [21:05:43] No, I'm arguing with your ability to parse my sentence. :-) [21:05:59] It's not-wrong but seems odd - why would spell check allow me to use a word that seems wrong? [21:06:03] odd [21:06:04] seems odd [21:06:09] No, that's not what I said. [21:06:22] * James_F substs his sentence. [21:06:26] " I think in American English it's not-wrong but seems odd." [21:06:30] ? [21:06:34] "Re-use" in British English and maybe Canadian English. I think in American English "Re-use" is not-wrong but seems odd. [21:06:41] OH [21:06:50] Oh, okay [21:06:56] Isn't English a terrible language? [21:07:01] hahaha [21:07:21] The irony here is that for me to understand, you had to re-use the word re-use [21:07:32] <3 [21:09:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3222751 (10Etonkovidova) Checked... [21:10:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353413 (owner: 10L10n-bot) [21:13:21] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3256858 (10Mattflaschen-WMF) Pat... [21:15:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/353419 (owner: 10L10n-bot) [21:32:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] When all saved filters removed form 'Quick links' - the empty placeholder is displayed - https://phabricator.wikimedia.org/T165102#3256932 (10Etonkovidova) [22:56:19] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Highlight settings contained in RC Page URLs fail to load - https://phabricator.wikimedia.org/T165107#3257168 (10jmatazzoni) [22:58:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Highlight settings contained in RC Page URLs fail to load - https://phabricator.wikimedia.org/T165107#3257183 (10jmatazzoni) [23:57:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: 'Quick links' - blank names for saved filters - https://phabricator.wikimedia.org/T165113#3257321 (10Etonkovidova)