[00:09:54] 06Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 07Regression: [regression] Popup triangle not positioned correctly - https://phabricator.wikimedia.org/T163993#3250175 (10Volker_E) [00:12:59] 06Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 07Regression: [regression] Popup triangle not positioned correctly - https://phabricator.wikimedia.org/T163993#3250179 (10Catrope) 05Open>03Resolved a:03Catrope [01:31:44] (03CR) 10TerraCodes: [C: 031] "recheck" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348405 (https://phabricator.wikimedia.org/T139089) (owner: 10Gerrit Patch Uploader) [05:57:48] 10MediaWiki-Recent-changes, 10DBA, 10MediaWiki-Database: Special:RecentChanges can show recently created page as red link - https://phabricator.wikimedia.org/T129399#2104435 (10Marostegui) So checking the rc slaves for enwiki (db1051 and db1055) there was no lag so probably this is not due to lag on the rece... [07:03:13] 06Collaboration-Team-Triage, 10Flow: Flow is broken on frwikiquote: Error: Module site has failed dependencies - https://phabricator.wikimedia.org/T164908#3250643 (10Framawiki) [07:06:08] 06Collaboration-Team-Triage, 10Flow: Flow is broken on frwikiquote: Error: Module site has failed dependencies - https://phabricator.wikimedia.org/T164908#3250660 (10Framawiki) [07:12:37] 06Collaboration-Team-Triage, 10Flow: Pencil icon missing in Flow comment textarea - https://phabricator.wikimedia.org/T134477#3250668 (10QuimGil) OK, yes, the UI is clear now even if the solution is not the one I suggested (the current approach is better). Thank you! [08:54:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3250898 (10Pginer-WMF) Thanks for compiling those @jmatazzoni, I did [[ https://etherpad.wikimedia.o... [09:30:12] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3250925 (10elukey) >>! In T163337#3249410, @aaron wrote: > What do you think of https://gith... [09:33:15] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3250927 (10elukey) Couple of notes from https://raw.githubusercontent.com/antirez/redis/2.8/... [09:35:08] 10MediaWiki-Watchlist, 10MediaWiki-Email: Email notifications not being sent for minor or bot edits - https://phabricator.wikimedia.org/T159066#3250935 (10Aklapper) As this is about a WMF wiki I am going to merge this into T142727. [09:35:16] 10MediaWiki-Watchlist, 10MediaWiki-Email: Email notifications not being sent for minor or bot edits - https://phabricator.wikimedia.org/T159066#3250937 (10Aklapper) [09:49:34] (03CR) 10Hashar: [C: 032] Add php-parallel-lint [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/352344 (owner: 10Umherirrender) [10:16:28] (03Merged) 10jenkins-bot: Add php-parallel-lint [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/352344 (owner: 10Umherirrender) [10:30:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3251047 (10Pginer-WMF) [10:36:03] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3251055 (10Marostegui) s2 in codfw is done: ``` root@neodymium:/home/marostegui/git/software/dbtools# for i in `cat /home/marostegu... [10:36:11] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3251056 (10Marostegui) [11:16:03] 10MediaWiki-Watchlist, 10ProofreadPage, 06Wikisource: You should be able to easily add all Index: derived "Pages" at once to your watchlist on Wikisource - https://phabricator.wikimedia.org/T100233#3251130 (10Billinghurst) @Ninovolador of course you can just scoop the pages from the index page (edit mode or... [11:34:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3251137 (10SBisson) It looks like this was fixed by {rMWdbfbbf9cb887b868... [11:35:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3251138 (10SBisson) 05Open>03Resolved [11:47:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Move links at top of Recent Changes to a Quick Links menu - https://phabricator.wikimedia.org/T164548#3251164 (10Pginer-WMF) When presenting both user-defined and community-defined links int a single menu,... [12:54:47] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3251340 (10Marostegui) s7 in codfw is done: ``` root@neodymium:~# for i in `cat /home/marostegui/s2_dbs`; do echo $i; mysql --skip-... [12:55:04] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3251343 (10Marostegui) [13:06:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, 07User-notice-collaboration: Invite users to opt in to the RC Filters beta f... - https://phabricator.wikimedia.org/T144457#3251356 [13:12:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Scoring-platform-team, and 3 others: Tweak ORES-Related Preferences for Watchlist and RC Page ahead of next release - https://phabricator.wikimedia.org/T162831#3251378 (10Trizek-WMF) [14:58:02] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3251822 (10Pginer-WMF) [15:06:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10TemplateStyles: Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3251889 (10Anomie) It may be that {T164792} solves this. [15:07:59] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3251892 (10Pginer-WMF) [15:44:38] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3252049 (10Pginer-WMF) [15:52:44] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10ORES, 06Scoring-platform-team, 10rsaas-draftquality: Display ORES draftquality model prediction in PageCuration feed - https://phabricator.wikimedia.org/T157130#3252112 (10kaldari) [15:52:46] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10ORES, 10Scoring-platform-team-Backlog: Add ORES draftquality warnings to Special:NewPagesFeed - https://phabricator.wikimedia.org/T164873#3252114 (10kaldari) [16:10:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10TemplateStyles: Add class mw-parser-output to Flow comment- or content- containing elements - https://phabricator.wikimedia.org/T164791#3252206 (10Anomie) >>! In T164791#3251889, @Anomie wrote: > It may be that {T164792} solves this. Parso... [16:12:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Provide links to other projects Recent Chances pages in the same language - https://phabricator.wikimedia.org/T164952#3252218 (10Trizek-WMF) [16:47:30] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic: Provide RC Filters to all users - https://phabricator.wikimedia.org/T157642#3252349 (10Jdforrester-WMF) [16:47:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#3252347 (10Jdforrester-WMF) 05Open>03Resolved Huzzah. [17:03:49] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Add 'Reverted' filter to RC Filters - https://phabricator.wikimedia.org/T164307#3252429 (10Trizek-WMF) [17:21:54] (03PS2) 10Etonkovidova: Echo should notify new user about wikitext mention on Flow talk page 'flow-mention' notification Bug: T14691 Change-Id: I7b84d57a97b995ce8518223a3a429d783399209c [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348768 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [17:26:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3252538 (10Mattflaschen-WMF) a:05Mattflasch... [17:31:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 4 about the New Filters for... - https://phabricator.wikimedia.org/T158335#3252576 [17:53:40] stephanebisson, I agree with you that "everything is a filter" (namespaces are namespace-filters, tags are tag-filters ,etc) but I am thinking of keeping the nomenclature "filters" as "system-defined filters for the filter list" vs namespaces and tgs as distinct naming in the code and system still - does that sound ok or am I missing something we should discuss? [17:54:08] It will also fit the labels in the popup... the filters have "Filters" header and namespaces/tags have "Namespaces" / "Tags" header [17:54:32] *but* the full widget with all tags included is also called "Filters" ("Active filters") so it might be confusing, but that's the only place... [17:55:09] Either we keep that, or we need to find another name for them, and that sounds like unnecessary work. [17:55:15] mooeypoo: I'm not sure what you are proposing... [17:56:08] NS and tags are filters in the sense that they allow users to filter the data [17:56:52] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Wikimedia-Blog-Content: Write blog post about New Filters for Edit Review beta - https://phabricator.wikimedia.org/T164423#3252703 (10EdErhart-WMF) https://blog.wikimedia.org/2017/05/10/new-filters-edit-review/ [17:57:03] stephanebisson, well, up until now we only had one type of filters in the filter list, so the whole code went with "Filters" as if it's the only thing -- getFiltersFromParameters, getParametersFromFilters, etc etc. When we add namespaces and tags, some of those will include more than just the 'filter filters' -- getParametersFromFilters for example, would have to give you all parameters (also, it should give you the highlight params, [17:57:03] not have it separate) for all lists - filters and namespaces and tags, etc [17:57:23] In headers, the term "Filters" is used for most filters unless we are in a mode where we see only a specific filter (NS or Tag), in which case we show the name of that filter in the header. [17:58:02] I want to keep the naming of those methods because they make sense, *but* that means that if the view model manages 2 (or more) lists then the fact that "everything is a filter" in terms of "getFiltersFromParameters" is not qiute true anymore, because now you have filters list AND namespace list etc [17:58:32] mooeypoo: I don't see why they would change... [17:58:39] so do we need to rename the filter list to something other than "filter" list, so that "Filter" is *general* all-filter-state... or is it okay to keep filters sometimes as all-general-state and sometimes as distinct filter list [17:58:49] NS and Tag are represented in url like any "string_options" filter [17:59:03] stephanebisson, yes, but the view model will have "modes" in it s oit can display the menus [17:59:13] mode "namespaces", mode "tags" and.... mode "filters" ? [17:59:19] do you see the confusion? [17:59:22] or potential confusion [17:59:22] yes, I see [17:59:42] I mean, we already call them filters, so that might be fine, but that also may produce confusion with existing **general** methods [17:59:54] like getFiltersFromParameters that should give you more thn just the things inside the 'filters' mode [17:59:57] that makes sense? [18:00:35] So either we change the way we name the filter-things (the items that are in the'filter' mode) or we don't, but we understand it might be confusing at times, so we try to name methods more generally [18:01:35] Another example would be that he widget will ask for all models from the certain type to change its modes and start its item widgets. Something like getItemModels( param) where param will be the mode - 'namespace', 'tags' 'filters' [18:02:29] if we put the mode in the ViewModel then widgets should look at "availableFilters" of something, which is popupated by the ViewModel with only the filters that exist in this mode [18:02:30] So... getFilters may have a different mental meaning ... while toggleFilterSelected should encompass all such items - filters, namespaces, tags [18:02:57] stephanebisson, yes, but then what do I call the type of the filter-filters so that the code can go "these are the available ones on default" ? [18:03:18] make something up ;) [18:03:27] Foolters. [18:03:42] It was meant to be from the root "foo" but I guess "Fool" also works [18:04:07] Anyways, yes. Okay. I'll... try to come up with something. stephanebisson RoanKattouw matt_flaschen ideas are welcome. [18:05:25] stephanebisson, I'm just concerned with confusion here. We'll have the "Foo" list and the "bar" list and the "baz" list and they're all actually filters, but act *slightly* differently enough to require slightly different handling (tags may have to be API-able, users in the future will be for sure) [18:09:10] There's 2 things here that don't need to be coupled: behaviour and visibility [18:09:24] for behavior, could we add the the "types" we already support? "if_any_selected", "string_options", "from_fixed_list", "from_api"... [18:11:42] for visibility: changing the content of the "visibleFilters" list based on calls or search strings should be done in 1 place (ViewModel ideally, but could also be UI) and will work regardless of filters storage [18:13:30] About the behavior that is common to all filters (transfer to and from URL, saved queries, capsule widget display, ... ) I don't think NS and tag are special cases [18:13:33] Hm. [18:52:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Analytics, 10Analytics-EventLogging: [betalabs] eventlogging does not record raw count for RecentChangesTopLinks e - https://phabricator.wikimedia.org/T164976#3252928 (10Etonkovidova) [18:53:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10Analytics, 10Analytics-EventLogging: [betalabs] eventlogging does not record raw count for RecentChangesTopLinks - https://phabricator.wikimedia.org/T164976#3252943 (10Etonkovidova) [18:54:20] Could someone review https://gerrit.wikimedia.org/r/353152 please? I'd like to SWAT it later today [18:55:53] RoanKattouw, wait, the script wasn't included before? [18:56:02] mooeypoo: It was in the .loggedIn module [18:56:04] oh, you're moving it, missed that [18:56:24] +2'ed [18:57:47] stephanebisson, ns and tags aren't special cases in those aspects, the only difference, really, is that "filters" have conflicts (but we can generalize it and just not define conflicts for ns/tags) and where they're displayed. [18:58:00] Thanks mooeypoo [18:58:41] (03PS2) 10Umherirrender: git.wikimedia.org -> phab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348405 (https://phabricator.wikimedia.org/T139089) (owner: 10Gerrit Patch Uploader) [18:58:46] (03CR) 10Umherirrender: [C: 032] git.wikimedia.org -> phab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348405 (https://phabricator.wikimedia.org/T139089) (owner: 10Gerrit Patch Uploader) [18:58:56] stephanebisson, I was thinking originally to split the lists; that is, the view model will still ahve all items in one big list, but just like t also has "filter groups" as a separate concept with its own references to each group's filters, I thought it would be good to do the same for filters/ns/tags [18:59:22] (03CR) 10Mattflaschen: [C: 04-1] "Wrong task in commit message" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [18:59:50] but that might be confusing. I need to think about it. In any case, I'll continue with the current refactor .. this affects the followup refactor of where I change the model from being a list to having a (or multiple) list(s) [19:03:51] (03Merged) 10jenkins-bot: git.wikimedia.org -> phab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348405 (https://phabricator.wikimedia.org/T139089) (owner: 10Gerrit Patch Uploader) [19:03:58] mooeypoo, I agree with stephanebisson. They're all filters, so e.g. it's natural that getFiltersFromParameters returns all. [19:04:06] mooeypoo, and there are actually now four types: [19:04:13] 1. hide_unselected_if_any [19:04:16] 2. string_options [19:04:26] 3. (unnamed) integer_union [19:04:37] 4. (unnamed) string_api_union (tags) [19:05:31] The backend also anticipates that there will eventually be more ChangesListFilter (beyond just ChangesListBooleanFilter.php and ChangesListStringOptionsFilter.php), though currently tag and namespace aren't part of that. [19:06:00] mooeypoo, you could call the existing mode checkbox_filters. [19:06:46] They're all checkbox [19:07:20] matt_flaschen, 'integer_union' ? Isn't that the same as string_options ? [19:07:30] except the strings are incidentally numbers [19:07:42] You're right, they're still checkboxes, just work differently. [19:07:53] I mean, at this point, it's arbitrary naming either way [19:08:07] mooeypoo, it's not the same internally, and there are behavior differences, e.g. associated namespace/invert. [19:08:07] But in that case, maybe "Foolters" works better :P [19:08:19] matt_flaschen, ahh [19:08:23] mooeypoo, but maybe it should be its own type (ChangesListNamespaceFilter). I was thinking that earlier. [19:08:30] Hm. [19:09:19] mooeypoo, dropdown_groups? [19:21:58] hm maybe, yeah [20:05:15] RoanKattouw, stephanebisson, matt_flaschen, I'm working on the unit tests and I have one case I actually want to *change* and I need to see if you agree/disagree.. "getFiltersFromParameters", up until now, always merged the state you gave it with the defaults. I think that's wrong in general, but it's even more wrong now that we can have the defaults set up from "quick links". If we want to have getFiltersFromParameters give us [20:05:15] params+defaults, we can **give it** a param list that is already merged with defaults. [20:05:31] Does that sound okay? [20:05:33] The test: [20:05:34] assert.deepEqual( [20:05:34] model.getFiltersFromParameters( {} ), [20:05:34] defaultFilterRepresentation, [20:05:34] 'Empty parameter query results in filters in initial default state' [20:05:35] ); [20:05:49] ^^ I will change it to getting back all filters set to false, rather than default. [20:06:16] It doesn't really make much sense with saved queries, either, now. [20:06:44] And i checked through the code, whenever we actually need the defaults, we pull them and merge them into whatever param representation we have (from the URL usually) **before** sending it to this method anyways [20:06:54] so I am mostly just trying to make sure I am not missing anything. [20:08:40] (It's also true for the rest of the unit tests for that method, they all merge with defaults. Going to remove all of that) [20:16:33] Sounds reasonable to me; but I don't know this code as well as the others do [20:35:45] mooeypoo, I agree with you (default-merging and param->filter are two different things), but I didn't check to see if it will cause issues. [20:39:57] It shouldn't cause issues, I checked to make sure we only send merged-defaults in [20:40:06] *but* if it does create issues, we should fix it where we call the function [20:40:25] I will verify. I just wanted to make sure it sounds okay before I change the method and all tests [21:05:43] James_F, Firefox keeps showing the "Unresponsive script" dialog. I clicked "Review your changes" (once) after editing the hotel table. Should I file it? [21:06:11] matt_flaschen: We've got a fix in master for that, sorry. [21:06:15] No problem [21:25:20] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Scoring-platform-team, and 2 others: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3253489 (10Etonkovidova) @jmatazzoni I've tested four edits w... [21:31:42] (03PS1) 10Anomie: Fix usage of $db->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353183 (https://phabricator.wikimedia.org/T164900) [21:39:28] (03CR) 10jerkins-bot: [V: 04-1] Fix usage of $db->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353183 (https://phabricator.wikimedia.org/T164900) (owner: 10Anomie) [21:46:15] (03PS2) 10Anomie: Fix usage of $db->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353183 (https://phabricator.wikimedia.org/T164900) [21:48:51] 06Collaboration-Team-Triage, 10Notifications: Echo failed to load with wfLoadExtension( 'Echo' ); under MW 1.28 - https://phabricator.wikimedia.org/T156992#3253558 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Paladox [21:54:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: [betalabs] ERR_TOO_MANY_REDIRECTS when RC preference option "Show only likely... - https://phabricator.wikimedia.org/T164625#3253568 [22:10:24] (03CR) 10Catrope: [C: 032] Fix usage of $db->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353183 (https://phabricator.wikimedia.org/T164900) (owner: 10Anomie) [22:16:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, 13Patch-For-Review: Deploy ORES Review Tool to Finnish Wikipedia - https://phabricator.wikimedia.org/T163011#3183232 (10Etonkovidova) Checked flwiki (wmf.21) - all ORES related featur... [22:19:45] (03Merged) 10jenkins-bot: Fix usage of $db->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353183 (https://phabricator.wikimedia.org/T164900) (owner: 10Anomie) [22:26:27] (03CR) 10jenkins-bot: Fix usage of $db->nextSequenceValue() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/353183 (https://phabricator.wikimedia.org/T164900) (owner: 10Anomie) [22:45:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3253669 (10Etonkovidova) Checked in enwiki b... [22:48:31] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10ORES, 06Scoring-platform-team, 10rsaas-draftquality: Display ORES draftquality model prediction in PageCuration feed - https://phabricator.wikimedia.org/T157130#3253685 (10kaldari) >The reasons are actually quite clear... @Kudpung: Would... [22:59:07] I keep forgetting to reset my nick [22:59:19] Anyways, unit tests pass **except** for.... you guessed it.... CONFLICTS. [22:59:30] They will haunt me until the day I die [23:08:12] STOP EVERYTHING. MY TESTS PASS. CELEBRATIONS UNDERWAY. [23:08:13] Resume. [23:10:52] RoanKattouw, in a way, it seems you're lucky I wfh today - I just emitted a high pitched celebratory "eeeeeeeeee!" sound, that was only abruptly ended when grunt failed. [23:11:58] That's OK, jmatazzoni_ has been swearing enough to compensate for you not being here [23:12:20] It ended up being a sort of donkey-sound... "eeeeeeee-aww." [23:12:32] Software problems. Sigh. [23:12:36] haha [23:12:55] ... not **our** software.... [23:17:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Change language describing "Likely" filters to avoid mentioning "May" filters - https://phabricator.wikimedia.org/T164997#3253755 (10jmatazzoni) [23:17:46] mooeypoo, so that's why everyone thought it was noon Tuesday. [23:18:06] matt_flaschen, haha it took me a moment [23:28:55] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Scoring-platform-team-Backlog, 13Patch-For-Review: Deploy ORES Review Tool to Finnish Wikipedia - https://phabricator.wikimedia.org/T163011#3253785 (10jmatazzoni) 05Open>03Resolved [23:29:22] uhm [23:29:26] RoanKattouw, .... http://i.imgur.com/vJuCC7f.png [23:29:27] O.O [23:29:35] How did I manage to do **that** [23:29:41] lol [23:29:56] Did you try to $.extend() an array and an object togethre [23:29:57] ? [23:30:16] ... maybe [23:30:29] I put the 'true' in the wrong place again [23:30:32] but that's weird [23:30:38] result = $.extend( true, {}, result, model.getDefaultParams() ); [23:30:41] ^ that should be right [23:31:19] Found it. [23:31:33] I was storing an object and a string inconsistently