[00:00:30] etonkovidova: Yes, James_F put in a fix already [00:00:43] And I +2ed it [00:00:50] It was merged a minute after your comment [00:01:23] etonkovidova: I live to break things hours before the train, y'see. :-) [00:02:32] etonkovidova is like the Engineering version of the canary in the mine. You take her into your code base, and as long as she's alive and well, you're fine. The second she starts looking into edge cases, you know you should run before the entire codebase collapses on top of you and everyone dies of asphyxiation. [00:05:23] mooeypoo: hmm... a canary should warn *before* something bad is about to happen :)) [00:09:38] etonkovidova, you are - before it's in production adn all of our users go mad [00:10:06] mooeypoo: you're right :) [00:15:01] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/352732/ [00:18:25] RoanKattouw: what else has been merged? :) RC with filters displays TypeError: Cannot read property 'length' of undefined TypeError and won't load ... [00:28:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrate namespace and tag selectors into the filter menu - https://phabricator.wikimedia.org/T164130#3246153 (10jmatazzoni) [00:29:07] etonkovidova: Moriel's saved filters thing, mostyl [00:29:31] RoanKattouw: ok ... [00:29:41] etonkovidova: Can you link me to the URL where that fails? [00:30:10] RoanKattouw: https://en.wikipedia.beta.wmflabs.org/wiki/Special:RecentChanges :))) [00:30:33] RoanKattouw: and RC filters should be enabled [00:31:30] Got it [00:31:32] It's Moriel's change [00:35:13] Patch: https://gerrit.wikimedia.org/r/352734 [00:41:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3246156 (10Mattflaschen-WMF) @SBisson noted... [00:50:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: [wmf.21] RC filters - Monobook UI issues with highlights - https://phabricator.wikimedia.org/T164550#3237414 (10Catrope) With my patches it looks a lot better: {F7989745} There's still a discr... [01:00:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3246181... [01:05:40] RoanKattouw, so of course there is 1 change in a tag with semi-colon (there is another tag, but that one doesn't have changes, and can't get any changes if we merge https://gerrit.wikimedia.org/r/352733 ). [01:05:49] RoanKattouw, but that one will still break later if we do Special:Contributions. [01:06:34] I'm going to look up which AF it is. Could you edit it? You should have rights. [01:06:38] Sure [01:07:01] I'm not at my computer right now but I should be able to do it in ~2h [01:15:11] RoanKattouw, we would also have to change the actual tag (change_tag table). [01:15:21] The AbuseFilter part is so it's consistent. I guess I could look for another delimiter that is unused (/ also has problems, comma is out), but this way it would be consistent since we're using ; elsewhere. [01:15:46] RoanKattouw, the mr one is https://mr.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%B6%E0%A5%87%E0%A4%B7:%E0%A4%B8%E0%A4%82%E0%A4%AA%E0%A4%BE%E0%A4%A6%E0%A4%A8_%E0%A4%97%E0%A4%BE%E0%A4%B3%E0%A4%A3%E0%A5%80/27 . [01:15:57] (AbuseFilter uses the actual filters to determine the list of a wiki's valid tags). [01:16:38] Ping me when you're back. I am going to get some food, but I should be back well before that. [01:26:37] RoanKattouw, starting to lean more towards picking a new delimiter (despite being inconsistent) if I can find one. [02:53:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3246243... [02:57:58] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3246246 (10aaron) I'd assume you could get them from JobQueueRedis.php, since it's just the... [03:05:01] matt_flaschen: Back now, where did you land on the delimiter thing? [03:05:58] Oh, pipe [03:07:02] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3246251 (10aaron) I wonder if the script replication works fully correctly (implemented in h... [03:07:15] RoanKattouw, yeah, not thrilled with it being inconsistent, but I don't really want to fiddle with the DB (it's not enough to change the filter, that just prevents future cases and changes whether the tag is defined). [03:07:47] Re pipe being clean: no wonder. Over at https://gerrit.wikimedia.org/r/#/c/352733/1/Views/AbuseFilterViewEdit.php , the line before the one you changed ensures that tags are valid titles [03:07:56] Or rather, that MediaWiki:tag-tagname is a valid title [03:08:18] So this means that tags can't contain pipes or be longer than 251 characters, among other things [03:09:09] I guess it would be hard to ascertain that that code has always been there, so it's still good to check that no such tags exist in the DB [03:09:20] RoanKattouw, yeah, I noticed that as well. And no other software (not surprisingly) or users did it, luckily. [03:09:56] Users would probably be scared away by the fact that making an MW page for the human-readable name and description doesn't work [03:10:08] But if it's not explicitly enforced in software it'd still be good to [03:10:19] RoanKattouw, oh, I just saw that ChangeTags also does the title check. [03:10:36] RoanKattouw, the MW page thing didn't stop 15 people from creating AbuseFilter tags with no proper description (due to /). [03:10:56] BTW https://gerrit.wikimedia.org/r/#/c/337565/6 is semi-relevant but probably not really [03:11:02] hah [03:11:11] Oh because slash means a language code is coming? [03:11:31] RoanKattouw, yeah, I didn't actually check that it doesn't work, but the comment says that. [03:11:54] RoanKattouw, yeah, I checked all the characters with ChangeTags::listDefinedTags which includes both user ones and software-defined (but "software-defined" includes the user-defined AbuseFilter ones). [03:12:05] "the comment says that" re slash [03:12:50] RoanKattouw, yeah, I'm aware of the https://gerrit.wikimedia.org/r/#/c/337565/ feature. I checked those, and that's where I'm banning '| (I now see it's done in the Title anyway, but it's more clear like that). [03:14:52] RoanKattouw, never mind, I thought https://gerrit.wikimedia.org/r/#/c/337565/6 was the old feature. [03:20:31] RoanKattouw, okay, read through that. The only issue (not related to that change) is that it never actually checks the characters for extensions. I don't think any extension would actually use them, but might as well fix that. [03:20:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3246254 (10Mooeypoo) >>! In T164128#3238340, @Pginer-WMF wrote:... [03:28:41] RoanKattouw, never mind, I can't do that, since it will break the existing ones with /. [03:29:08] Since they're defined by AbuseFilter as software-defined but are really user input. [03:29:15] Right [03:29:30] So we have to go with pipe, right? [03:30:03] RoanKattouw, yeah, I was already going with pipe, but I was going to do a followup to enforce the 3 banned characters (and the other char-based restrictions) on extensions as well (currently they're only enforced on user tags and AF *on edit*). [03:30:13] RoanKattouw, but that causes AF to blow up on existing invalid tags even when not being edited. [03:30:44] Oh I didn't realize / and ; were already banned [03:31:12] RoanKattouw, / and , [03:31:33] Ah [03:33:15] I was going to enforce it here ( https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/changetags/ChangeTags.php;776ebaaad16f1bc4b15f76363e6310650380dfed$1256 ), but then it blew up on my own local test ( 'abcde;suspicious/alphabet' ). [03:33:28] (From AF) [03:34:59] RoanKattouw, so everything is ready for review, and we should get this out before the cut so we don't break back-compat. [03:35:21] (Even though the front-end isn't ready, so hopefully no one would be using it) [03:36:42] OK cool [03:37:01] If you send me Gerrit links then I'll review+merge in 20 [03:37:07] Just walking home now [03:39:14] RoanKattouw, remaining one is https://gerrit.wikimedia.org/r/#/c/352542/ . Thanks for reviewing the other one. [03:39:33] I'm heading out. [07:37:15] 10MediaWiki-Watchlist, 13Patch-For-Review, 07User-notice, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3246454 (10matej_suchanek) @Nirmos You can try "... [08:04:52] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 07I18n, 03Wikidata-Sprint: [Task] improve Wikidata Echo notification text - https://phabricator.wikimedia.org/T164375#3246523 (10matej_suchanek) [08:07:07] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3246539 (10Marostegui) [09:00:24] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3246625 (10Marostegui) s6 codfw is done: ``` root@neodymium:/home/marostegui/git/software/dbtools# for i in frwiki jawiki ruwiki; d... [09:00:34] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3246626 (10Marostegui) [10:30:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice-collaboration: Announce and follow up with community group 1 about the ... - https://phabricator.wikimedia.org/T158336#3247489 [10:30:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017): Explore the different quick links chosen by communities and displayed on Recentchangestext - https://phabricator.wikimedia.org/T164001#3247485 (10Trizek-WMF) p:05Norm... [10:30:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3247487 (10Trizek-... [10:30:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice-collaboration: Announce and follow up with community group 1 about the ... - https://phabricator.wikimedia.org/T158336#3033782 [10:30:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Scoring-platform-team, 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (instead o... - https://phabricator.wikimedia.org/T158225#3247491 [10:30:55] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice: Announce and follow up with communities about the New Filters for Rece... - https://phabricator.wikimedia.org/T146972#3247492 [10:53:17] (03PS7) 10WMDE-Fisch: DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) [11:01:14] (03CR) 10jerkins-bot: [V: 04-1] DNM Test diffs of similar looking comments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/305491 (https://phabricator.wikimedia.org/T143313) (owner: 10WMDE-Fisch) [11:20:32] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3247666 (10Marostegui) s6 in codfw is done: ``` root@neodymium:/home/marostegui/git/software/dbtools# mysql --skip-ssl -hdb2019.co... [11:20:56] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3247680 (10Marostegui) [11:22:48] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3247684 (10elukey) >>! In T163337#3246251, @aaron wrote: > I'm not sure why the ack() scrip... [11:32:56] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3247708 (10elukey) Other test that I did today: since I noticed a lot of RPUSH on the Redis... [11:38:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review, 07User-notice-collaboration: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3247714 (10Trizek-WMF) [11:42:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design, 13Patch-For-Review: Facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3247719 (10Pginer-WMF) >>! In T151994#3240108, @Mooeypoo wrote: > Since we so... [11:45:42] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design, 13Patch-For-Review: Facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3247729 (10Pginer-WMF) @Mooeypoo I went to the current status of the feature... [11:48:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): [betalabs] Watchlist displays "Uncaught ReferenceError: getElementsByClassName is not defined" - https://phabricator.wikimedia.org/T164630#3247743 (10Aklapper) Which betalabs? enwp? The line in https://en.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Common.... [13:03:33] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): [betalabs] Watchlist displays "Uncaught ReferenceError: getElementsByClassName is not defined" - https://phabricator.wikimedia.org/T164630#3240537 (10TheDJ) they are all rather outdated. I have updated them to be aligned with current production versions. [13:06:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): [betalabs] Watchlist displays "Uncaught ReferenceError: getElementsByClassName is not defined" - https://phabricator.wikimedia.org/T164630#3247891 (10TheDJ) Likely the gadgets are also rather outdated, but this would be quite a bit of work to resync all... [13:26:44] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3247998 (10elukey) The only RPUSH that I found is in the JobChron: https://github.com/wikim... [14:26:22] 10MediaWiki-Watchlist, 10ProofreadPage, 06Wikisource: You should be able to easily add all Index: derived "Pages" at once to your watchlist on Wikisource - https://phabricator.wikimedia.org/T100233#3248164 (10Ninovolador) 05Open>03declined [15:16:16] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3248415 (10Marostegui) s5 in codfw is done: ``` root@neodymium:/home/marostegui/git/software/dbtools# for i in dewiki wikidatawiki;... [15:16:45] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 4 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3248416 (10Marostegui) [17:31:50] RoanKattouw, I realized I was probably misunderstanding you. ORES and Wikidata are a conflict ( https://gerrit.wikimedia.org/r/#/c/342294/12/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php ) and with bypass DB on conflicts, that should work regardless. [17:32:22] Right [17:32:25] RoanKattouw, but now I'm thinking you meant highlighting (either ORES built-in, or ours (if highlight but not filter)). [17:32:46] I thought that the highlights (and pre-conflict results) were caused by rc_this_oldid referring to a WD oldid [17:32:57] But are you saying it instead refers to the page's latest revid or somtehing? [17:33:38] So I'll look at the latter (highlighthing, along with user experience level thing) after the user ID patch (which may partly resolve the user experience level). [17:34:42] RoanKattouw, yeah: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/client/includes/RecentChanges/RecentChangeFactory.php;61687b1067afd5c449c05d51a6524d9aa0b88308$150 . [17:35:24] RoanKattouw, yeah, during the meeting I was thinking, "wait, if it's the local ID, wouldn't that be the RC_EXTERNAL entry itself", but it's the highest rev ID while that entry is being generated, and thus a real but unrelated entry. [17:37:00] We just need to exclude RC_EXTERNAL from the highlighting. [17:37:35] Thanks for putting up the deployment planning. [17:37:44] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 07I18n, 03Wikidata-Sprint: [Task] improve Wikidata Echo notification text - https://phabricator.wikimedia.org/T164375#3231592 (10Catrope) > If we can then it would be great if we can link "a bar item" to the actual item. You can't have links insi... [17:39:41] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 07I18n, 03Wikidata-Sprint: [Task] improve Wikidata Echo notification text - https://phabricator.wikimedia.org/T164375#3231592 (10Mattflaschen-WMF) Or reverse it, and have the primary link go to Wikidata and a secondary link go to the local page.... [17:41:04] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Wikimedia-Blog-Content: Write blog post about New Filters for Edit Review beta - https://phabricator.wikimedia.org/T164423#3248914 (10jmatazzoni) 05Open>03Resolved [17:45:55] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Read queries detected on the x1 master by Echo extension - https://phabricator.wikimedia.org/T164505#3248942 (10jmatazzoni) a:03Catrope [17:52:47] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 07I18n, 03Wikidata-Sprint: [Task] improve Wikidata Echo notification text - https://phabricator.wikimedia.org/T164375#3231592 (10jmatazzoni) > The new text should be: "The page foo was connected to a bar item. It holds additional data about the to... [17:53:38] AbuseFilter patch was reverted since I failed to check the happy path (saving an edit to a filter that used a valid, in-use tag). [17:53:48] Doesn't impact us since we ended up with pipe and that is already enforced by AbuseFilter itself. [18:16:40] Hah oops [18:18:07] 06Collaboration-Team-Triage, 10Flow, 05MW-1.27-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), 13Patch-For-Review: Investigate write mode flag cleanup for Flow API modules - https://phabricator.wikimedia.org/T120543#3249030 (10Catrope) 05Open>03Resolved a:03Catrope (This was fixed months ago, but nev... [18:22:24] 06Collaboration-Team-Triage, 10Notifications: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860#3249039 (10Catrope) [18:23:04] 06Collaboration-Team-Triage, 10Notifications: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860#3249054 (10Catrope) @aaron Do I understand correctly that Echo's current strategy, which is to overwrite (as opposed to purge) entries in WANObjectCache, needs to... [18:23:19] 06Collaboration-Team-Triage, 10Notifications: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860#3249057 (10Catrope) [18:24:43] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Read queries detected on the x1 master by Echo extension - https://phabricator.wikimedia.org/T164505#3249065 (10Catrope) I'm going to close this task since I believe we've addre... [18:41:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249126 (10jmatazzoni) [18:46:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249149 (10jmatazzoni) [18:55:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Make it so filter groups are hidden from those who can't use them - https://phabricator.wikimedia.org/T164122#3249166 (10jmatazzoni) 05Open>03Resolved [18:56:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3249168 (10jmatazzoni) [18:56:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Make filter panel header sticky on new filters for edit review - https://phabricator.wikimedia.org/T163431#3249167 (10jmatazzoni... [18:56:31] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 13Patch-For-Review: [minor] frwiki - RC page with filters displays extra dot on a new line - https://phabricator.wikimedia.org/T162844#3249184 (10jmatazzoni) 05Open>03Resolved [19:05:42] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249208 (10jmatazzoni) @Mooeypoo I just noticed something else, which prompts a question: it s... [19:16:17] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Make mobile-friendly version of the Notifications page left nav - https://phabricator.wikimedia.org/T139525#3249226 (10Catrope) 05Open>03Resolved a:03KMuthu [19:18:36] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Read queries detected on the x1 master by Echo extension - https://phabricator.wikimedia.org/T164505#3249229 (10Catrope) 05Open>03Resolved [19:20:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249235 (10Mooeypoo) Answering some: > ===Down-facing arrow > Pau's design on the prototype s... [19:23:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249243 (10Mooeypoo) >>! In T164861#3249208, @jmatazzoni wrote: > @Mooeypoo I just noticed som... [19:26:25] 06Collaboration-Team-Triage, 10Flow, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: flow-ui-navigationWidget displays 'Browse t...' - https://phabricator.wikimedia.org/T162837#3249254 (10Catrope) 05Open>03Resolved [19:27:55] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: Clicking on Notices/Alerts issues a banner over the other icon - https://phabricator.wikimedia.org/T162173#3249256 (10Catrope) 05Open>03Resolved a:03Catrope [19:36:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Get stats on how frequently RC Page related links (at page top) are clicked - https://phabricator.wikimedia.org/T164617#3240043 (10Etonkovidova) @Catrope The anon us... [19:38:56] 06Collaboration-Team-Triage, 10Notifications: Notifications not updated across languages - https://phabricator.wikimedia.org/T139454#3249287 (10Catrope) [19:38:58] 10Collaboration-Team-Archive-2015-2016, 06Collaboration-Team-Triage, 10Notifications, 05MW-1.27-release (WMF-deploy-2016-01-19_(1.27.0-wmf.11)), 07User-notice: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#3249290 (10Catrope) [19:41:28] 06Collaboration-Team-Triage, 10Notifications: Nowiki'd templates in Flow notification excerpts are parsed in emails and special page - https://phabricator.wikimedia.org/T143807#3249301 (10Catrope) [19:41:30] 06Collaboration-Team-Triage, 10Flow, 10Notifications: Email notification including a template quoting a template is not rendered correctly - https://phabricator.wikimedia.org/T136354#3249298 (10Catrope) [19:42:10] 06Collaboration-Team-Triage, 10Notifications: Nowiki'd templates in Flow notification excerpts are parsed in emails and special page - https://phabricator.wikimedia.org/T143807#2579636 (10Catrope) {T136354} shows that things like `{{tl|citation needed}}` are also broken, but I think that's caused by the same u... [19:43:05] 06Collaboration-Team-Triage, 10Flow: Pencil icon missing in Flow comment textarea - https://phabricator.wikimedia.org/T134477#3249308 (10Catrope) 05Open>03Resolved [19:43:12] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 6 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3249309 (10Catrope) [19:44:31] 06Collaboration-Team-Triage, 10Notifications: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860#3249316 (10Catrope) Potentially related: {T138341} [19:56:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3249359 (10Krinkle) [20:06:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249386 (10jmatazzoni) [20:08:26] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Job queue corruption after codfw switch over (Queue worth, duplicate runs) - https://phabricator.wikimedia.org/T163337#3249410 (10aaron) What do you think of https://github.com/antirez/redis/issues/2999 ? I wond... [20:14:39] 06Collaboration-Team-Triage, 10Notifications: Update Echo's caching strategy for multi-dc compatibility - https://phabricator.wikimedia.org/T164860#3249436 (10aaron) Sounds correct to me. [20:22:38] 10MediaWiki-Recent-changes, 10DBA, 10MediaWiki-Database: Special:RecentChanges can show recently created page as red link - https://phabricator.wikimedia.org/T129399#3249506 (10Krinkle) [20:38:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: [minor] RC page with Group changes by page...' option misaligns Legend letters - https://phabricator.wikimedia.org/T163739#3249593 (10jmatazzoni) [20:39:55] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: [minor] RC filters - during reload conflicting filters "No changes during the given period match these criteria" is displayed - https://phabricator.wikimedia.org/T163577#3249601 (10jmatazzoni) [20:41:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Scoring-platform-team: Lack of intersection between damaging & goodfaith for English Wikipedia - https://phabricator.wikimedia.org/T163995#3249617 (10jmatazzoni) [20:43:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications: UI rendering issue when no notifications - https://phabricator.wikimedia.org/T164112#3249621 (10jmatazzoni) [20:44:03] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3249626 (10jmatazzoni) [20:49:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/352916 (owner: 10L10n-bot) [20:49:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/352921 (owner: 10L10n-bot) [20:51:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Move links at top of Recent Changes to a Quick Links menu - https://phabricator.wikimedia.org/T164548#3249657 (10jmatazzoni) [20:54:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Move links at top of Recent Changes to a Quick Links menu - https://phabricator.wikimedia.org/T164548#3249662 (10jmatazzoni) [21:05:50] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10ORES, 10Scoring-platform-team-Backlog: Add ORES draftquality warnings to Special:NewPagesFeed - https://phabricator.wikimedia.org/T164873#3249707 (10kaldari) [21:12:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Get stats on how frequently RC Page related links (at page top) are clicked - https://phabricator.wikimedia.org/T164617#3249745 (10Etonkovidova) @Catrope It seems tha... [21:12:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249746 (10jmatazzoni) [21:13:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Minor Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249126 (10jmatazzoni) @Mooeypoo , I added a new item to the "Tweaks" above: **No disappearing... [21:17:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07User-notice-collaboration: Tweaks to Quick Links design & functions - https://phabricator.wikimedia.org/T164861#3249755 (10jmatazzoni) [22:09:38] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Scoring-platform-team: Lack of intersection between damaging & goodfaith for English Wikipedia - https://phabricator.wikimedia.org/T163995#3249937 (10jmatazzoni) We are getting inte... [22:09:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Scoring-platform-team: ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems" - https://phabricator.wikimedia.org/T163757#3249941 (10jmatazzoni) [22:09:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Scoring-platform-team: Lack of intersection between damaging & goodfaith for English Wikipedia - https://phabricator.wikimedia.org/T163995#3249940 (10jmatazzoni) 05Open>03Resolved [23:35:53] Will be back on about 7 Pacific.