[00:01:47] (03CR) 10jenkins-bot: Add test case names for SpamFilter, to make which fails obvious [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351218 (owner: 10Mattflaschen) [00:07:07] (03CR) 10Mattflaschen: [C: 04-1] "I don't think this is necessary. We're already adding both oojs-ui.styles.icons (the core one, I assume) and oojs-ui.styles.icons-interac" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [00:08:00] (03CR) 10Jforrester: [C: 031] "oojs-ui.styles.icons is getting deleted very soon…" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [00:10:01] James_F, not sure if your icon comment is in response to mine, or you didn't see it (conflict). But my point was we're already adding oojs-ui.styles.icons-interactions with addModuleStyles, so it doesn't need to *also* be a dependency. [00:10:10] James_F, RoanKattouw, but I guess it's a no-op if T87871 is working now. [00:10:10] T87871: Loading with addModuleStyles() should set module state to "ready" - https://phabricator.wikimedia.org/T87871 [00:10:28] Yeah I need to fix that patch [00:10:36] And do what Matt said in his comment [00:10:48] matt_flaschen: It was a reply, yeah. [00:11:31] I guess there's no harm in adding it as a dependency (I didn't think of T87871 right away), but you should at least remove core from addModuleStyles. [00:12:08] Yes. [00:12:29] And if that breaks things (icons don't show up) shout loudly because it means I probably screwed up and didn't notice. :-) [00:14:27] (03PS2) 10Catrope: Stop loading deprecated OOUI core icon pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 [00:14:31] Read the new diff and be amused [00:17:22] RoanKattouw: Don't you use oojs-ui.styles.icons-layout for the layout icon? [00:18:09] Specifically, "stripeToC" is used on the left of "Browse topics" [00:19:20] https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow [00:24:59] 06Collaboration-Team-Triage, 10Flow: flow-ui-navigationWidget displays 'Browse t...' - https://phabricator.wikimedia.org/T162837#3226687 (10Catrope) [00:25:08] 06Collaboration-Team-Triage, 10Flow: flow-ui-navigationWidget displays 'Browse t...' - https://phabricator.wikimedia.org/T162837#3176557 (10Catrope) a:03Catrope [00:28:21] (03CR) 10Jforrester: "Oh dear. :-)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [00:29:50] (03PS1) 10Catrope: Fix truncation of "Browse topics" button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351227 (https://phabricator.wikimedia.org/T162837) [00:32:05] (03CR) 10Mooeypoo: [C: 032] "Ooh, neat!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351227 (https://phabricator.wikimedia.org/T162837) (owner: 10Catrope) [00:33:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3226708 [00:37:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3226710 [00:40:42] (03Merged) 10jenkins-bot: Fix truncation of "Browse topics" button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351227 (https://phabricator.wikimedia.org/T162837) (owner: 10Catrope) [00:50:08] (03CR) 10jenkins-bot: Fix truncation of "Browse topics" button [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351227 (https://phabricator.wikimedia.org/T162837) (owner: 10Catrope) [01:04:36] ^ RoanKattouw, greg-g, there are some people upset about the FlaggedRevs fix not going through until May 8, and one person asking for sooner (T164049) [01:04:37] T164049: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is not checked) - https://phabricator.wikimedia.org/T164049 [01:04:45] I'm not sure it justifies an exception, since there's a good workaround, but making you aware. [01:04:53] Yeah I pinged him in -releng already [01:05:03] But I think it's probably too late to grab Greg today [01:05:09] Oh, okay, thanks. [01:06:16] I can do it if he gives the go-ahead. There is also T164096 which is hopefully just a fluke, but one person thinks it is related (without any reason I see). I'm grepping through the logs nonetheless. [01:06:17] T164096: 503 "Service Unavailable" error on Special:RevisionReview - https://phabricator.wikimedia.org/T164096 [01:22:55] RoanKattouw, doh, yeah, I reviewed it (and fixed it): https://gerrit.wikimedia.org/r/#/c/348156/1 [01:23:42] How is that related? [01:24:34] Wha [01:24:38] Just saw your patch [01:29:25] RoanKattouw, now maybe we have a better case to do a deploy of both (even though they're unrelated). [01:30:05] Agreed [01:49:27] matt_flaschen: Chad says just do it. I'm not at a computer though, are you? [02:44:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3226853 [02:51:00] RoanKattouw, yeah, I am. I'll do it now. [02:51:11] RoanKattouw, both of them, right? [02:51:43] Yeah [02:51:49] Thanks [02:52:24] No problem [02:59:43] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Documentation: Technical documentation - https://phabricator.wikimedia.org/T163069#3226856 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [03:14:43] RoanKattouw, done, and confirmed the filter fix for production. I don't think I can really test the fatal one without having rights/doing something. [03:15:20] Awesome, thanks [03:29:41] RoanKattouw, unrelated to the deploy, but another thing that might be confusing with the reviewed/patrolled group is that it's different from patrolled (where everything is either "needs to be patrolled" or "already marked patrolled" (e.g. log entries don't need to be patrolled, so they are just marked pre-patrolled))) [03:30:00] RoanKattouw, but for 'reviewed', it can neither need review nor be reviewed, in which case hideReviewed won't hide it. [03:35:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3226918 (10Mattflaschen-WMF) Another thing to consider: For a wiki with RC patrol, an edit is ei... [03:39:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3226919 [03:40:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: 503 "Service Unavailable" error on Special:R... - https://phabricator.wikimedia.org/T164096#3226920 [06:57:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Invite users to opt in to the RC Filters beta from the RC page, and educate t... - https://phabricator.wikimedia.org/T144457#3227090 [11:12:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Figure out whether unusable filter groups should be hidden or grayed out - https://phabricator.wikimedia.org/T164122#3227528 (10Pginer-WMF) >>! In T164122#3225209, @jmatazzoni wrote: > Do you think it ill be confusin... [12:38:55] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 3 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3227653 [12:38:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Chinese-Sites, and 3 others: Announce and follow up with communities group 3 about the New Filters for Recent changes Beta... - https://phabricator.wikimedia.org/T158333#3227651 [12:50:35] 06Collaboration-Team-Triage, 10Flow, 10Dumps-Generation: Make flow dumps run faster - https://phabricator.wikimedia.org/T164262#3227664 (10ArielGlenn) [13:04:02] 06Collaboration-Team-Triage, 10Flow, 10Dumps-Generation: Make flow dumps run faster - https://phabricator.wikimedia.org/T164262#3227722 (10ArielGlenn) See also https://phabricator.wikimedia.org/T89398 where it was thought that T138306 (now T105859) was the problem. I have done some investigating, and it loo... [14:30:05] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3227904 (10Zache) //That also raises the question of whether we should have a filter to show only... [14:36:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Do not rebind and blindly override onMenuToggle in FilterTagMultiselectWidget - https://phabricator.wikimedia.org/T164228#3227940 (10SBisson) a:03SBisson [15:02:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Don't create a TagItemWidget when deleting a highlight-only tag - https://phabricator.wikimedia.org/T164131#3222945 (10SBisson) I do the steps above and `createTagItemWidget` doesn't seem to get called. Anything else... [15:04:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-WikimediaEvents: Consider not hardcoding filter names in RC Filters tracking - https://phabricator.wikimedia.org/T159786#3228077 (10SBisson) The patch was for an aspect of this task (usage of... [15:20:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Support multiple values for the namespace parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164132#3228111 (10SBisson) a:03SBisson [16:23:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter translations by languages in recent changes - https://phabricator.wikimedia.org/T164063#3228280 (10Trizek-WMF) >>! In T164063#3226068, @Catrope wrote: > - French Wiktionary?! "The Wiktionaire:Actualités is a monthly magazine about French... [17:34:16] stephanebisson: Could you review https://gerrit.wikimedia.org/r/350896 ? [17:34:37] sure [17:42:37] 06Collaboration-Team-Triage, 10Flow, 10OOjs-UI: [regression] Popup widget misaligned near border after OOUI update - https://phabricator.wikimedia.org/T163543#3201037 (10Catrope) It's periodically been broken like that before, so I'm not sure if this is due to the OOUI update or something else. We should sti... [17:45:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017): Explore the different quick links chosen by communities and displayed on Recentchangestext - https://phabricator.wikimedia.org/T164001#3217806 (10Trizek-WMF) [17:50:42] (03PS1) 10Catrope: Don't truncate notification header messages in bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351348 (https://phabricator.wikimedia.org/T163518) [17:55:05] (03PS1) 10Catrope: Follow-up 739847c20: don't adjust the popup anchor position [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351349 (https://phabricator.wikimedia.org/T163993) [17:55:53] 06Collaboration-Team-Triage, 10Notifications: UI rendering issue when no notifications - https://phabricator.wikimedia.org/T164112#3222028 (10Catrope) The name of the current wiki should appear in that box, it shouldn't be empty [17:56:05] 06Collaboration-Team-Triage, 10Notifications: UI rendering issue when no notifications - https://phabricator.wikimedia.org/T164112#3222028 (10Trizek-WMF) I don't have this on my computer, @Jdlrobson. What is your browser? [18:00:35] 06Collaboration-Team-Triage, 10Notifications, 10Analytics, 10Analytics-EventLogging, and 5 others: Multiple MediaWiki hooks are not documented on mediawiki.org - https://phabricator.wikimedia.org/T157757#3015493 (10Mainframe98) Another list of missing hooks can be found on https://www.mediawiki.org/wiki/Ma... [18:02:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filtered views of RecentChanges?) - https://phabricator.wikimedia.org/T164232#3228685 (10jma... [18:03:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filte... - https://phabricator.wikimedia.org/T164232#3226538 [18:04:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, and 2 others: Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filte... - https://phabricator.wikimedia.org/T164232#3226538 [18:11:15] 06Collaboration-Team-Triage, 10Notifications: UI rendering issue when no notifications - https://phabricator.wikimedia.org/T164112#3228698 (10Jdlrobson) >The name of the current wiki should appear in that box, it shouldn't be empty How is that configured? I'm seeing this locally on all browsers so maybe this i... [18:13:25] (03CR) 10Sbisson: [C: 032] Stop loading deprecated OOUI core icon pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [18:20:49] 06Collaboration-Team-Triage, 10Notifications, 10Analytics, 10Analytics-EventLogging, and 5 others: Multiple MediaWiki hooks are not documented on mediawiki.org - https://phabricator.wikimedia.org/T157757#3228717 (10Smalyshev) Good task for T126500. [18:21:51] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3228721 (10jmatazzoni) [18:22:10] (03Merged) 10jenkins-bot: Stop loading deprecated OOUI core icon pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [18:22:27] (03CR) 10jenkins-bot: Stop loading deprecated OOUI core icon pack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [18:28:53] (03CR) 10Sbisson: [C: 032] Don't truncate notification header messages in bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351348 (https://phabricator.wikimedia.org/T163518) (owner: 10Catrope) [18:30:18] 06Collaboration-Team-Triage, 10Notifications: UI rendering issue when no notifications - https://phabricator.wikimedia.org/T164112#3222028 (10Etonkovidova) The issue is present on http://cx2.wmflabs.org/index.php/Special:Notifications - is this actually a bug that needs to be fixed? {F7873885} [18:31:03] (03CR) 10Sbisson: [C: 032] Follow-up 739847c20: don't adjust the popup anchor position [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351349 (https://phabricator.wikimedia.org/T163993) (owner: 10Catrope) [18:34:14] RoanKattouw: re userExpLevelTest with coverage. While they don't fix the problem, I think those 2 patches are improvements and could be merged: https://gerrit.wikimedia.org/r/#/c/349951/ https://gerrit.wikimedia.org/r/#/c/349456/ [18:34:54] OK will do [18:35:30] thanks [18:37:02] (03Merged) 10jenkins-bot: Don't truncate notification header messages in bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351348 (https://phabricator.wikimedia.org/T163518) (owner: 10Catrope) [18:39:03] (03Merged) 10jenkins-bot: Follow-up 739847c20: don't adjust the popup anchor position [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351349 (https://phabricator.wikimedia.org/T163993) (owner: 10Catrope) [18:39:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3228794 (10SBisson) a:03SBisson [18:41:15] (03CR) 10jenkins-bot: Don't truncate notification header messages in bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351348 (https://phabricator.wikimedia.org/T163518) (owner: 10Catrope) [18:43:22] (03CR) 10jenkins-bot: Follow-up 739847c20: don't adjust the popup anchor position [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351349 (https://phabricator.wikimedia.org/T163993) (owner: 10Catrope) [18:59:33] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3228852 (10jmatazzoni) [18:59:56] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3228852 (10jmatazzoni) a:05Mooeypoo>03None [19:04:37] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3228721 (10Niharika) We've updated the notification to be: There have been 6 failed attempts to log in to your account from a new devi... [19:06:03] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3228915 (10jmatazzoni) Great! It's definitely better. Do I take it you don't want to split the message up between header and body? [19:11:49] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3228977 (10Niharika) >>! In T164286#3228915, @jmatazzoni wrote: > Great! It's definitely better. Do I take it you don't want to split th... [19:17:33] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3229013 (10jmatazzoni) > Hmm, I'm not clear what you mean by header message and body message. There are two possible parts to any noti... [19:21:49] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3229042 (10Niharika) What it looks like now: {F7875237} [19:23:10] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki, and 2 others: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3229049 (10Niharika) 05Open>03Resolved a:03Niharika Thanks for working on this, @Catrope. [19:24:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Technical documentation - https://phabricator.wikimedia.org/T163069#3229061 (10jmatazzoni) [19:25:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [mobile-wmf.20] RC page - UI issues - https://phabricator.wikimedia.org/T163164#3229071 (10jmatazzoni) [19:51:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3229113 (10Catrope) @Etonkovidova showed me that this was broken someh... [20:09:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes, 13Patch-For-Review: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3229173 (10SBisson) >>! In T163964#3229113, @Catrope wrote: > @Etonkov... [20:17:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3229189 (10Mattflaschen-WMF) My understanding is that these models... [20:37:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3229243 (10jmatazzoni) Yes, as Matt says, good-faith edits can def... [20:46:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "New Watchlist changes" filter does not count users' own edits as visits to Watched pages - https://phabricator.wikimedia.org/T164301#3229259 (10Etonkovidova) [20:55:48] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Short circuit searches for combo of “Very likely good” + (“Likely bad faith” OR "V. likely bad faith") - https://phabricator.wikimedia.org/T164292#3229300 (10Mattflaschen-WMF) >>! In T164292#3229243, @jmatazzoni w... [21:06:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351424 (owner: 10L10n-bot) [21:07:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351417 (owner: 10L10n-bot) [21:15:34] matt_flaschen: hey [21:15:54] I think i spotted a problematic issue in flow [21:15:59] Hey [21:16:39] matanya, what's happening? [21:17:01] I had a user script calling mw.util [21:17:26] it ofc failed to load. but it blocked flow from loading as well with no clear error [21:17:43] i guessed it from the console [21:17:53] can reproduce if you want [21:19:21] matt_flaschen: i think user scripts should not prevent flow from loading [21:21:29] matanya, it's a known issue with multiple extensions that a user script error can prevent extensions from loading. It's more of a ResourceLoader issue. [21:21:40] matanya, what helps now is to use ?safemode=1 (if not question marks already in URL) or &safemode=1 (if there already is a ?) [21:21:53] matanya, that will prevent user scripts from loading so you can see if that's the cause. [21:22:06] yes, i tried that, thanks. it helped [21:26:46] RoanKattouw might be able to comment in more detail, but I think this is considered unfixable/a won't fix. See Krinkle at T72772: "Broken code should not be silenced. There's a 1001 ways for gadgets and user scripts to break unrelated modules. That's the DOM for you." [21:26:48] T72772: Errors in one module can affect other modules via $.ready - https://phabricator.wikimedia.org/T72772 [21:27:07] * RoanKattouw disclaims all knowledge [21:27:29] Krinkle has made enough changed to ResourceLoader that I don't know all that much about it any more [21:27:51] (And he knows more about browsers and web standards than I ever have or will) [21:28:01] If he says it's unfixable, I believe him [21:30:10] RoanKattouw, I was more asking you to (optionally) comment on the general issue (whether it's worth trying to fix user scripts/gadgets breaking extension JS) than the specific task (because I don't know if that specific task is the cause of this specific interaction) [21:30:50] But whenever this has happened in the past, we've always just told people to turn the gadget off or fix it, rather than filed a bug against ResourceLoader about bad isolation (it is a valid point, though, the question is whether it's reasonably fixable) [21:31:35] IIRC the bad isolation extends into jQuery, as well [21:31:40] I did disable the gadget, the problem is finding which one is the offensive one, and even more so for less technical users [21:31:57] So I think we'd have to replace $.ready [21:32:39] Which is doable, but potentially messy, and reasonable people can disagree about whether that's worth it [21:36:20] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 10Edit-Review-Improvements-RC-Page: Add 'Reverted' filter to RC Filters - https://phabricator.wikimedia.org/T164307#3229431 (10jmatazzoni) [21:45:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 06Scoring-platform-team, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: Create a preference for 'classic' ORES shading on RC Pa... - https://phabricator.wikimedia.org/T163025#3229470 [21:59:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [regression wmf.21] Safari only - filter capsules with highlight displayed misalgned - https://phabricator.wikimedia.org/T164308#3229506 (10Etonkovidova) [22:00:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [regression wmf.21] Safari only - filter capsules with highlight displayed misalgned - https://phabricator.wikimedia.org/T164308#3229523 (10Etonkovidova) [22:26:27] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Shorten and break up the LoginNotify notification - https://phabricator.wikimedia.org/T164286#3229631 (10jmatazzoni) much better. Thanks. [22:32:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "Fatal exception of type "Wikimedia\Rdbms\DBQueryError" when url with Watchedlisted filters is used - https://phabricator.wikimedia.org/T164314#3229663 (10Etonkovidova) [22:38:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3229724 (10Etonkovidova) Checke... [22:42:11] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "Fatal exception of type "Wikimedia\Rdbms\DBQueryError" when url with Watchedlisted filters is used - https://phabricator.wikimedia.org/T164314#3229795 (10Etonkovidova) [22:42:31] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 06Scoring-platform-team, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: Create a preference for 'classic' ORES shading on RC Pa... - https://phabricator.wikimedia.org/T163025#3229796 [22:46:21] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "Fatal exception of type "Wikimedia\Rdbms\DBQueryError" when url with Watchedlisted filters is used - https://phabricator.wikimedia.org/T164314#3229817 (10Etonkovidova) [22:46:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3229816 (10Etonkovidova) [22:48:35] Doxygen locally seems to behave totally differently from https://doc.wikimedia.org/mediawiki-core/master/php/ , and I can't figure out why. The doc.wikimedia.org is a lot more useful. [22:48:41] The local one only has a file list and annotated source code. [22:50:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3229834 (10jmatazzoni) [22:57:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3229854 (10jmatazzoni) Let's make a plan to do this. The process would be to do something like... [23:20:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "New Watchlist changes" filter does not count users' own edits as visits to Watched pages - https://phabricator.wikimedia.org/T164301#3229259 (10Catrope) Re #4, all those rows are highlighted with both green and yel... [23:34:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "Fatal exception of type "Wikimedia\Rdbms\DBQueryError" when url with Watchedlisted filters is used - https://phabricator.wikimedia.org/T164314#3229663 (10Catrope) ``` SELECT rc_id,rc_timestamp,rc_user,rc_user_text,... [23:34:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: "Fatal exception of type "Wikimedia\Rdbms\DBQueryError" when url with Watchedlisted filters is used - https://phabricator.wikimedia.org/T164314#3230026 (10Catrope) a:03Catrope [23:45:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement arrow keys in the Dropdown Filter Panel for results found by filter search - https://phabricator.wikimedia.org/T159768#3230075 (10Mooeypoo) This fix corrects the highlight color to ove... [23:48:44] mooeypoo: https://gerrit.wikimedia.org/r/351541 and upwards