[02:15:50] (03CR) 10EddieGP: "recheck" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348639 (https://phabricator.wikimedia.org/T139089) (owner: 10TerraCodes) [02:15:56] (03CR) 10EddieGP: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/348449 (https://phabricator.wikimedia.org/T139089) (owner: 10TerraCodes) [03:33:19] (03CR) 10TerraCodes: "recheck" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348405 (https://phabricator.wikimedia.org/T139089) (owner: 10Gerrit Patch Uploader) [03:33:53] (03CR) 10TerraCodes: [C: 031] git.wikimedia.org -> phab [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/348405 (https://phabricator.wikimedia.org/T139089) (owner: 10Gerrit Patch Uploader) [07:01:53] 10MediaWiki-Watchlist, 13Patch-For-Review, 07User-notice, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3224705 (10Billinghurst) Explicitly noting thre... [07:45:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3224709 (10Pginer-WMF) [07:48:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3224710 (10Pginer-WMF) [07:48:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2834562 (10Pginer-WMF) [08:01:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate result size selection in the new filters for edit review - https://phabricator.wikimedia.org/T162786#3224716 (10Pginer-WMF) >>! In T162786#3223075, @Catrope wrote: > This shouldn't be... [08:50:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter translations by languages in recent changes - https://phabricator.wikimedia.org/T164063#3224732 (10Pginer-WMF) >>! In T164063#3221541, @jmatazzoni wrote: > Sorry, I'm not understanding how this would work or what the use case is. @Trizek-W... [11:43:02] (03PS1) 10Thiemo Mättig (WMDE): Fix a lot of non-standard @var and @param PHPDoc lines [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351139 [11:43:32] (03PS1) 10Thiemo Mättig (WMDE): Remove unused imports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351140 [11:48:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Figure out whether unusable filter groups should be hidden or grayed out - https://phabricator.wikimedia.org/T164122#3224890 (10Pginer-WMF) I think we want to find the right balance among the following aspects: - Mak... [12:47:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests, 13Patch-For-Review: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3224911 (10SBisson) ``` User Newcomer1, registrati... [14:15:45] (03CR) 10Esanders: "Shame CodeSniffer doesn't support this yet - we should add a task to include this rule when this is merged: https://github.com/squizlabs/P" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351140 (owner: 10Thiemo Mättig (WMDE)) [14:18:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'no-effect' states displayed as not muted - https://phabricator.wikimedia.org/T163843#3212039 (10SBisson) I'm not sure what's wrong in the screenshot. Those 3 filters DO have an effect since they filter... [14:31:05] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Make filter panel header sticky on new filters for edit review - https://phabricator.wikimedia.org/T163431#3225095 (10SBisson) a:03SBisson [14:40:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter group for 'Last revision' to the RC Filters - https://phabricator.wikimedia.org/T163561#3225115 (10SBisson) a:03SBisson [15:05:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'no-effect' states displayed as not muted - https://phabricator.wikimedia.org/T163843#3212039 (10jmatazzoni) 'Likely' and "Very likely" have no effect because they are subsets of "May." So they're alread... [15:14:18] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Figure out whether unusable filter groups should be hidden or grayed out - https://phabricator.wikimedia.org/T164122#3225209 (10jmatazzoni) Do you think it ill be confusing to users that the filters move around when... [15:22:03] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3225235 [16:00:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3225333 [16:00:58] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Beta-Cluster-Infrastructure, 10ORES, and 4 others: ORES errors on beta sites (dewp; zhwp) - https://phabricator.wikimedia.org/T163873#3225336 (10Etonkovidova) Re-checked the case when the beta feature "New filt... [17:44:03] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3225628 (10Mattflaschen-WMF) There was discussion at today's meeting about having patrol being a... [19:18:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'no-effect' states displayed as not muted - https://phabricator.wikimedia.org/T163843#3226011 (10SBisson) a:03SBisson [19:26:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3226023 (10SBisson) a:03SBisson [19:26:36] RoanKattouw, I'm going to a meeeting in about 5 mins, but can you please tell me how the f* this makes any sense? I have 2 objects, 'baseState' that has a bunch of key:null and minimalValues that has a subset with key:actualValue ... I $.extend( {}, baseState, minimalValues ) and my result is the minimalValues. See http://imgur.com/a/zkn2o [19:26:39] what the hell!? [19:27:05] RoanKattouw, I only expanded 'highlights' in there, but 'param' key is the same [19:27:25] ... RoanKattouw quack. [19:27:30] I forgot "true" for deep extend [19:27:33] goddamnit [19:48:20] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 5 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3226053 (10Etonkovidova) Checked in betalabs - the mention limit failure notification is s... [19:55:31] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter translations by languages in recent changes - https://phabricator.wikimedia.org/T164063#3220438 (10Catrope) Yes, this filter is only available on wikis where the Translate extension is installed. TLDR the only ones with substantial traffic... [19:57:43] 06Collaboration-Team-Triage, 10MediaWiki-extensions-Nuke, 07Easy, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found - https://phabricator.wikimedia.org/T163494#3226071 (10Catrope)... [20:02:31] (03CR) 10Catrope: [C: 032] Remove unused imports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351140 (owner: 10Thiemo Mättig (WMDE)) [20:05:20] (03CR) 10Catrope: [C: 032] Fix a lot of non-standard @var and @param PHPDoc lines [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351139 (owner: 10Thiemo Mättig (WMDE)) [20:11:55] (03Merged) 10jenkins-bot: Remove unused imports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351140 (owner: 10Thiemo Mättig (WMDE)) [20:12:11] (03CR) 10jenkins-bot: Remove unused imports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351140 (owner: 10Thiemo Mättig (WMDE)) [20:14:34] (03Merged) 10jenkins-bot: Fix a lot of non-standard @var and @param PHPDoc lines [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351139 (owner: 10Thiemo Mättig (WMDE)) [20:14:50] (03CR) 10jenkins-bot: Fix a lot of non-standard @var and @param PHPDoc lines [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351139 (owner: 10Thiemo Mättig (WMDE)) [20:25:44] 06Collaboration-Team-Triage, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 03Google-Summer-of-Code (2016): Pywikibot Support for Thanks (GSoC Proposal) - https://phabricator.wikimedia.org/T130585#3226154 (10srishakatux) [20:28:13] 06Collaboration-Team-Triage, 10Flow: Case-insensitive autocomplete for Flow mentions - https://phabricator.wikimedia.org/T101254#1333604 (10ksmith) Just a +1 that this is really frustrating. I recently tried to @ mention Stillwell, and it took me several tries to figure out the right combination of letters to... [21:10:04] (03PS1) 10Jforrester: extension.json: Drop no-op dependency on deprecated es5-shim module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351199 [21:11:12] RoanKattouw: Couple of quick merges? https://gerrit.wikimedia.org/r/#/q/status:open+branch:master+topic:es5-shim-dead [21:11:27] matt_flaschen: Good job using the word "re-scheduling" in a way that doesn't mean the same thing as "rescheduling" :) [21:12:17] :) [22:24:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Do not rebind and blindly override onMenuToggle in FilterTagMultiselectWidget - https://phabricator.wikimedia.org/T164228#3226449 (10Catrope) [22:29:43] RoanKattouw: mooeypoo are you around? Could you review some code hygiene relating to kavitha's changes? [22:34:39] jdlrobson: Yeah I'm here [22:34:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: Invite users to opt in to the RC Filters beta from the RC page, and educate t... - https://phabricator.wikimedia.org/T144457#2631427 [22:34:48] What do you want me to look at? [22:35:06] RoanKattouw: ill poke you in about 30 mins.. got pulled into a meeting [22:35:16] OK I'll be aroudn [22:38:29] (03CR) 10Catrope: [C: 032] extension.json: Drop no-op dependency on deprecated es5-shim module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351199 (owner: 10Jforrester) [22:46:45] (03Merged) 10jenkins-bot: extension.json: Drop no-op dependency on deprecated es5-shim module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351199 (owner: 10Jforrester) [22:47:02] (03CR) 10jenkins-bot: extension.json: Drop no-op dependency on deprecated es5-shim module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351199 (owner: 10Jforrester) [22:47:45] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filtered views of RecentChanges?) - https://phabricator.wikimedia.org/T164232#3226538 (10Jdf... [22:48:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#3226551 (10Jdforrester-WMF) [22:48:35] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filtered views of RecentChanges?) - https://phabricator.wikimedia.org/T164232#3226550 (10Jdf... [22:51:36] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review: RC filters - 'no-effect' states displayed as not muted - https://phabricator.wikimedia.org/T163843#3226552 (10Etonkovidova) Chec... [22:52:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3226553 [22:56:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3226569 (10Jdforrester-WMF) [22:56:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#3226583 (10Jdforrester-WMF) [22:56:31] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3226569 (10Jdforrester-WMF) [22:56:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#2621630 (10Jdforrester-WMF) [22:56:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on all pages that show sets of changes (or consolidate them as filtered views of RecentChanges?) - https://phabricator.wikimedia.org/T164232#3226538 (10Jdf... [22:57:00] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-Watchlist, 07Epic: Provide "RC Filters" functionality on the watchlist - https://phabricator.wikimedia.org/T164234#3226569 (10Jdforrester-WMF) [22:57:03] how many "_" after "wikibugs" must I put in my exception to block the pings? [22:57:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Explore adding ORES filters and new filtering system to Watchlist, Related Changes and other pages - https://phabricator.wikimedia.org/T145155#2621630 (10Jdforrester-WMF) [22:57:04] lol [22:57:05] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 13Patch-For-Review: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3226587 (10Jdforrester-WMF) [23:05:29] https://gerrit.wikimedia.org/r/351211 Hygiene: Notification filter < mooeypoo RoanKattouw [23:29:53] (03PS1) 10Mattflaschen: Add test case names for SpamFilter, to make which fails obvious [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351218 [23:30:16] ^ RoanKattouw, trivial test change, when have a second: https://gerrit.wikimedia.org/r/351218 [23:31:27] (03CR) 10Catrope: [C: 032] Add test case names for SpamFilter, to make which fails obvious [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351218 (owner: 10Mattflaschen) [23:33:38] And there's also, https://gerrit.wikimedia.org/r/#/c/351216/1 (mostly the same tests for SpamBlacklist itself, so it doesn't have 0 tests), when you have a chance. [23:45:19] Looking [23:45:28] matt_flaschen: Meanwhile here's a quick one for you: https://gerrit.wikimedia.org/r/350896 [23:48:06] (03Merged) 10jenkins-bot: Add test case names for SpamFilter, to make which fails obvious [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351218 (owner: 10Mattflaschen) [23:52:10] RoanKattouw: also noticed another problem - on Special page the icon in top right disappears [23:52:13] https://gerrit.wikimedia.org/r/348795 Hygiene: Refactor Notification code - add NotificationBadge class fixes it [23:52:16] but that's a little meaty [23:52:33] but... TESTS! [23:53:09] Nice [23:53:23] Also, correct me if I'm wrong, but I feel like I've heard that bug before [23:53:30] You're talking about the bell icon thing on the special page? [23:54:15] I think either there was something about how the right module wasn't loaded for its icon or something that I swear I fixed earlier, or we decided that it makes no sense to open a panel with a list of notifications when you're already on the list of notificatoins [23:54:36] Or maybe neither of those things is true and this is just a total accident [23:55:28] yup [23:55:37] I believe it's because loadModuleScript is being used unnecessarily [23:56:13] Oh and the spinner stuff that it does breaks the icon somehow? [23:57:22] https://gerrit.wikimedia.org/r/351220 Hygiene: Don't unnecessarily use loadModuleScript [23:57:29] simple fix [23:58:19] I'm somewhat surprised that that fixes it, but it's a totally reasonable change, so +2 :) [23:59:14] it puts a spinner icon in the top right unnecessarily which is a bit jarring :) [23:59:26] Oh I think I may have seen that