[00:39:42] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Replace "Tag filter" input with a dropdown+lookup widget in RCFilters - https://phabricator.wikimedia.org/T161650#3222901 (10Catrope) [00:40:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Integrate namespace and tag selectors into the filter menu - https://phabricator.wikimedia.org/T164130#3222902 (10Catrope) [01:11:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Don't create a TagItemWidget when deleting a highlight-only tag - https://phabricator.wikimedia.org/T164131#3222945 (10Catrope) [01:12:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3222959 (10Mooeypoo) Just a note here - as part of the testing, I wanted to see how many quick links the user se... [01:12:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Support multiple values for the namespace parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164132#3222960 (10Catrope) [01:15:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Support multiple values for the tagfilter parameter in the ChangesList backend - https://phabricator.wikimedia.org/T164133#3222982 (10Catrope) [01:19:08] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement pagination in ChangesList backend - https://phabricator.wikimedia.org/T164134#3222999 (10Catrope) [01:26:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Add a sticky header with filter and pagination controls - https://phabricator.wikimedia.org/T164135#3223020 (10Catrope) [01:30:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: Create a preference for 'classic' ORES shading ... - https://phabricator.wikimedia.org/T163025#3223035 [01:31:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Add AJAXy pagination controls - https://phabricator.wikimedia.org/T164136#3223036 (10Catrope) [01:40:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Access the new changes that happened after the user started filtering contributions in the new filters for edit review - https://phabricator.wikimedia.org/T163426#3223066 (10Catrope) Implementation thoughts: - To det... [01:42:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement pagination in ChangesList backend - https://phabricator.wikimedia.org/T164134#3223071 (10Catrope) [01:44:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate result size selection in the new filters for edit review - https://phabricator.wikimedia.org/T162786#3174591 (10Catrope) This shouldn't be too much work, but note that the "Sort by" f... [01:46:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Implement pagination in ChangesList backend - https://phabricator.wikimedia.org/T164134#3223081 (10Catrope) [01:47:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate time period selection in the new filters for edit review - https://phabricator.wikimedia.org/T162784#3174531 (10Catrope) Note that setting a "to" timestamp is not currently supported... [01:49:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Make filter panel header sticky on new filters for edit review - https://phabricator.wikimedia.org/T163431#3223089 (10Catrope) [01:52:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3223095 (10Catrope) Yes, that's right. {T164128} is for allowing people to save filter selections for their own reuse, whe... [01:58:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [wmf.17] RC page - 'Fatal exception of type "DBQueryError"' - https://phabricator.wikimedia.org/T162714#3223114 (10Catrope) 05Open>03declined It says "a connection error occurred". This can occasionally happen in... [04:13:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3222751 (10Mattflaschen-WMF) >>! In T164128#3222959, @Mooeypoo wrote: > Just a note here - as part of the testin... [04:20:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3223205 (10Catrope) >>! In T164128#3223198, @Mattflaschen-WMF wrote: > Also, this storage is shared with other f... [04:25:12] Slightly weird, Russian Wikipedia has user styling for the FlaggedRevs rows: [04:25:16] https://ru.wikipedia.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%9D%D0%BE%D0%B2%D1%8B%D0%B5_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D1%8B [04:25:19] https://ru.wikipedia.org/wiki/%D0%A1%D0%BB%D1%83%D0%B6%D0%B5%D0%B1%D0%BD%D0%B0%D1%8F:%D0%9D%D0%BE%D0%B2%D1%8B%D0%B5_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B8%D1%86%D1%8B?safemode=1 [04:42:27] RoanKattouw, okay, if https://gerrit.wikimedia.org/r/#/c/350968/ doesn't work, we'll have to set up meta-FlaggedRevs. [04:43:31] I've only read the commit message so far, but I take it FR was also mixing filters and side effects? [04:44:20] RoanKattouw, yeah, sorry. Technically they weren't really doing anything odd before (since it used to be totally separated), I just missed it when quick-refactoring it due to the 'deprecated' log spam. [04:45:16] Gotcha [04:48:38] RoanKattouw, luckily the workaround isn't terrible (you can still hide reviewed edits in order to review *un*reviewed edits). We should still SWAT it out, though. [04:50:08] I'll schedule that. [06:54:20] 10MediaWiki-Watchlist, 13Patch-For-Review, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3223261 (10Billinghurst) >>! In T164059#3221756, @Darkdadaah wrot... [07:42:05] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3223273 (10Joe) An additional case I'm going to study in more detail: ``` # Current master redisc -h rdb2003.codfw.wmnet -p... [08:16:58] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3223282 (10aaron) Note that the only keys that use a TTL are the root job de-duplication hash/timestamp keys. Everything els... [10:24:15] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 07Regression, 07Wikimedia-log-errors: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3223380 (10matej_suchanek) [10:24:15] 10MediaWiki-Watchlist, 13Patch-For-Review, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3223384 (10matej_suchanek) [10:27:33] 10MediaWiki-Watchlist, 13Patch-For-Review, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3223385 (10matej_suchanek) https://www.wikidata.org/w/index.php?t... [11:25:03] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3223430 (10Joe) >>! In T163337#3223282, @aaron wrote: > Note that the only keys that use a TTL are the root job de-duplicati... [11:33:14] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Can't access large watchlist on nlwiki: 503 error - https://phabricator.wikimedia.org/T142329#3223440 (10Aklapper) [11:33:44] 10MediaWiki-Watchlist, 10Wikidata, 10Wikidata.org, 10Wikimedia-General-or-Unknown: User i18n@wikidata getting 503 when viewing filtered watchlist - https://phabricator.wikimedia.org/T123213#1923781 (10Aklapper) [11:38:58] 10MediaWiki-Watchlist, 13Patch-For-Review, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3223470 (10Darkdadaah) >>! In T164059#3223261, @Billinghurst wrot... [11:53:20] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Can't access large watchlist on nlwiki: 503 error - https://phabricator.wikimedia.org/T142329#3223481 (10Mbch331) The last few days this issue is back. I usually get a blank page, but sometimes it changes to a 503 Service Unavailable. A few hours later the... [12:04:51] (03CR) 10Matěj Suchánek: WIP: Add user right expiry notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350500 (https://phabricator.wikimedia.org/T153817) (owner: 10MaxSem) [13:30:53] (03Draft2) 10Matěj Suchánek: Fix missing number in message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351005 [17:59:38] (03CR) 10Catrope: [C: 032] Fix missing number in message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351005 (owner: 10Matěj Suchánek) [18:07:51] (03Merged) 10jenkins-bot: Fix missing number in message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351005 (owner: 10Matěj Suchánek) [18:08:55] (03CR) 10jenkins-bot: Fix missing number in message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351005 (owner: 10Matěj Suchánek) [20:24:53] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3219994 [20:38:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 4 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3219994 [21:09:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/351056 (owner: 10L10n-bot) [21:10:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/351060 (owner: 10L10n-bot) [22:22:57] 10MediaWiki-Watchlist, 13Patch-For-Review, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3220312 (10Strainu) I had the same issues in RecentChanges. Do no...