[01:27:45] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Possible-Tech-Projects, 10Wikimedia-Hackathon-2017, 07Community-Wishlist-Survey-2016: New User Landing Page - Article Creation Workflow - https://phabricator.wikimedia.org/T156442#3219874 (10Kudpung) >>! In T156442#3060088, @srishakatux... [06:28:06] 10MediaWiki-Recent-changes, 10MediaWiki-extensions-FlaggedRevs, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3219994 (10Raymond) [07:53:48] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 05MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), 13Patch-For-Review, 15User-zeljkofilipin: RSpec tests for Echo Mention notification - https://phabricator.wikimedia.org/T146916#3220063 (10zeljkofilipin) p:05Normal>03Low a:05Eton... [09:00:08] 06Collaboration-Team-Triage, 10Flow: Recognize signature with tildes and remove it? - https://phabricator.wikimedia.org/T164055#3220169 (10Elitre) [10:15:49] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3220346 (10Zache) [10:16:34] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3219994 (10Zache) Confirmed in finnish Wikipedia too. Same regression exists in watchlist and Recen... [10:17:27] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3220352 (10Vito-Genovese) Also apparent in trwiki and enwikibooks. [10:33:12] 06Collaboration-Team-Triage, 10Flow: Recognize signature with tildes and remove it? - https://phabricator.wikimedia.org/T164055#3220169 (10Trizek-WMF) I think removing the signature would be perceived as a bug. A warning would be better: {T112239} [11:22:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter translations by languages in recent changes - https://phabricator.wikimedia.org/T164063#3220438 (10Trizek-WMF) [11:44:40] (03CR) 10Aleksey Bekh-Ivanov (WMDE): "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296201 (owner: 10Paladox) [11:44:52] (03CR) 10jerkins-bot: [V: 04-1] Update extension to be compatible with zordius/lightncandy 0.90 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/296201 (owner: 10Paladox) [11:51:31] 10MediaWiki-Watchlist: Viewing my watchlist returns a blank page or a Wikimedia error - https://phabricator.wikimedia.org/T164059#3220478 (10Thibaut120094) [13:07:29] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error - https://phabricator.wikimedia.org/T164059#3220649 (10Aklapper) [13:56:18] 10MediaWiki-Recent-changes: Pending edits are not visible in recent changes page in ar.wiki - https://phabricator.wikimedia.org/T164068#3220795 (10Aklapper) Hi @alanajjar, thanks for taking the time to report this! Is this the same problem as T164049? [13:56:30] 10MediaWiki-Recent-changes, 07Regression: Pending edits are not visible in recent changes page in ar.wiki - https://phabricator.wikimedia.org/T164068#3220800 (10Aklapper) [13:57:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3220801 (10Pginer-WMF) >>! In T151994#3219648, @Mooeypoo wrote: > @Pginer-WMF can yo... [14:01:39] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3220809 (10Paladox) [14:03:58] 10MediaWiki-Recent-changes, 07Regression: Pending edits are not visible in recent changes page in ar.wiki - https://phabricator.wikimedia.org/T164068#3220818 (10alanajjar) @Aklapper , Yes almost the same with addition of that when user use Firefox to refuse a change the page stops loading and nothing happened!... [14:04:58] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3220825 (10Paladox) p:05Triage>03High If something breaks on... [14:06:47] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error - https://phabricator.wikimedia.org/T164059#3220312 (10Paladox) I wonder if this is because of codfw or a mw deploy? [14:06:50] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available - https://phabricator.wikimedia.org/T164049#3220830 (10alanajjar) Also in Arabic wiki! [14:07:48] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is checked) - https://phabricator.wikimedia.org/T164049#3220833 (10Aklapper) [14:07:58] 10MediaWiki-Recent-changes, 07Regression: Pending edits are not visible in recent changes page in ar.wiki - https://phabricator.wikimedia.org/T164068#3220835 (10Aklapper) [14:08:00] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is checked) - https://phabricator.wikimedia.org/T164049#3219994 (10Aklapper) [14:08:32] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error - https://phabricator.wikimedia.org/T164059#3220838 (10Paladox) This could have been caused by https://phabricator.wikimedia.org/rEFLRad612350b61786b00897f1dec44bdfac5c8ab349 [14:08:38] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is checked) - https://phabricator.wikimedia.org/T164049#3220839 (10Paladox... [14:08:44] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is checked) - https://phabricator.wikimedia.org/T164049#3220840 (10Aklapper... [14:52:06] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 07Blocked-on-schema-change, 07Schema-change: Drop ptrl_comment in production - https://phabricator.wikimedia.org/T157762#3221003 (10Umherirrender) [15:04:16] 06Collaboration-Team-Triage, 10Flow, 10DBA, 07Blocked-on-schema-change, and 3 others: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#3221045 (10Umherirrender) [15:08:25] 06Collaboration-Team-Triage, 10Flow, 10DBA, 05MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), and 2 others: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#3221097 (10jcrespo) Those are not considered schema changes for us, at least not for now. We use tracking task T54921... [15:18:08] 06Collaboration-Team-Triage, 10Flow, 10DBA, 05MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), and 2 others: Drop flow_subscription table - https://phabricator.wikimedia.org/T149936#3221143 (10jcrespo) p:05Triage>03Low > It's unused [15:29:58] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error - https://phabricator.wikimedia.org/T164059#3221191 (10Darkdadaah) If I deactivate "Hide page categorisation" in my watchlist preferences, the page is correctly displayed. It go... [15:46:42] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 4 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3221261 (10SBisson) **re (1)** I'll rework the message. @jmatazzoni any suggestion about ho... [16:06:32] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error when "Hide: Page categorisation" is activated - https://phabricator.wikimedia.org/T164059#3221319 (10Aklapper) [16:13:30] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3221355 (10elukey) Joe is going to add a more precise update but there is an interesting thing that we discovered today that... [16:29:03] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error when "Hide: Page categorisation" is activated - https://phabricator.wikimedia.org/T164059#3220312 (10Billinghurst) Happened for me at English Wikisource on Tuesday following co... [16:33:12] (03PS1) 10Sbisson: Remove arbitrary limit of 20 mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350877 (https://phabricator.wikimedia.org/T144614) [16:51:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Beta-Cluster-Infrastructure, 10ORES, and 4 others: ORES errors on beta sites (dewp; zhwp) - https://phabricator.wikimedia.org/T163873#3221530 (10Etonkovidova) Checked in betalabs - dewiki, zhwiki, cawiki - Con... [16:53:49] stephanebisson: thanks for fixing https://phabricator.wikimedia.org/T144614 - it was such a mystery... [16:55:53] etonkovidova: it still needs to be reviewed and merged but yes, quite unexpected! [16:57:49] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter translations by languages in recent changes - https://phabricator.wikimedia.org/T164063#3220438 (10jmatazzoni) Sorry, I'm not understanding how this would work or what the use case is. @Trizek-WMF, can you please flesh that out a little? [17:00:39] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Filter translations by languages in recent changes - https://phabricator.wikimedia.org/T164063#3221546 (10Trizek-WMF) [17:00:59] ^ jmatazzoni_, done. [17:11:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 4 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3221572 (10jmatazzoni) How about this for language: You tried to mention more than 100 use... [17:25:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 4 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3221616 (10Trizek-WMF) Let's limit the mention to 50 users for consistency with the other m... [17:49:58] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-General-or-Unknown, 07Regression: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is not checked) - https://phabricator.wikimedia.org/T164049#3221651 (10Frie... [17:51:21] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 4 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3221654 (10SBisson) >>! In T144614#3221572, @jmatazzoni wrote: > How about this for languag... [17:53:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 4 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3221660 (10jmatazzoni) It would be good to make the messaging and functionality consistent... [17:54:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 4 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3221663 (10SBisson) It's actually //less// effort. I'll change it in Echo and let Flow use... [17:56:06] (03PS1) 10Sbisson: Set max mention count to 50 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350886 (https://phabricator.wikimedia.org/T144614) [18:00:28] (03PS1) 10Sbisson: Rephrase notification-header-mention-failure-too-many [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350887 (https://phabricator.wikimedia.org/T144614) [18:00:41] (03CR) 10Catrope: [C: 032] Remove arbitrary limit of 20 mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350877 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:00:58] (03CR) 10Catrope: [C: 032] Set max mention count to 50 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350886 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:01:29] (03CR) 10Catrope: [C: 032] Rephrase notification-header-mention-failure-too-many [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350887 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:05:43] matt_flaschen: Are you aware of T164049 and T164059 ? The former sounds like it might be fallout from your FlaggedRevs hook changes, and the latter also sounds like it could possibly be related to structured filters although I'm more skeptical of that one [18:05:44] T164059: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error when "Hide: Page categorisation" is activated - https://phabricator.wikimedia.org/T164059 [18:05:44] T164049: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits" is not checked) - https://phabricator.wikimedia.org/T164049 [18:05:58] (Unhelpfully stashbot flipped the order there) [18:09:02] (03Merged) 10jenkins-bot: Remove arbitrary limit of 20 mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350877 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:10:26] (03CR) 10jenkins-bot: Remove arbitrary limit of 20 mentions [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350877 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:11:08] (03Merged) 10jenkins-bot: Set max mention count to 50 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350886 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:12:10] (03CR) 10jenkins-bot: Set max mention count to 50 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350886 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:13:22] (03Merged) 10jenkins-bot: Rephrase notification-header-mention-failure-too-many [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350887 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:14:25] (03CR) 10jenkins-bot: Rephrase notification-header-mention-failure-too-many [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350887 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [18:21:02] RoanKattouw, thanks, will take a look later today. [18:22:45] matt_flaschen: BTW I was talking to Tilman about Wikidata RC stuff yesterday, and he said that it would be useful to filter out delivery of things like "the Kazakh description was changed" to the English WIkipedia, and other irrelevant things [18:25:29] Apparently enwiki asked for editing of (or displaying of? I forget) WD descriptions on mobile to be disabled because they get vandalized and they feel they can't patrol them. The noisiness (as in amount of irrelevant things) of WD RC as replicated to enwiki was mentioned as a factor there (though I'm sure it's not the only one) [18:26:12] I don't know how hard these things are to address nor have I even thought much about how in-our-purview they are, but I figured I'd mention them to you before I forgot and while your brain is still in that space [18:28:57] RoanKattouw, thanks, will make a note on that as well. BTW, you probably saw, but I got a good review on the change. [18:29:05] Yeah I just saw that [18:29:29] Hmm, also, random other question, is there a GuidedTour method for "just launch this tour, I know what I'm doing" that doesn't set a cookie? [18:29:43] I'm reviewing https://gerrit.wikimedia.org/r/#/c/350553/2/WikimediaMessages.hooks.php and suddenly getting concerned about how many cookies we're setting [18:29:45] RoanKattouw, it's defined at the tour level, not at launch time. isSinglePage. [18:30:16] I mean an alternative to GuidedTourLauncher::launchTourByCookie() [18:30:53] I guess we could call GuidedTourHooks::addTour directly without going through the cookie code? [18:31:11] RoanKattouw, mw.guidedTour.launcher.launchTour (that also allows lazy-loading, so you don't need to load the real GuidedTour code until it's really launched) [18:31:31] isSinglePage prevents the tour itself from setting a cookie to track progress between pages. [18:31:44] OH I see [18:31:51] No I'm only talking about the PHP side of things [18:32:08] Oh, whoops, should have read more closely. [18:32:26] I'll do this as a follow-up patch on top of Stephane's and let you review [18:32:41] 10MediaWiki-Watchlist, 10Wikimedia-General-or-Unknown: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error when "Hide: Page categorisation" is activated - https://phabricator.wikimedia.org/T164059#3221756 (10Darkdadaah) I did the same and the one category that failed was "Catégorie:... [18:32:47] I think it might be best to illustrate what I'm talking about by just writing the patch and letting you possibly shoot it down [18:33:12] RoanKattouw, you can redirect to a URL containing a ?. I see what you mean I think (setting it with a wg JS variable (beware of caching for anons, though)). [18:33:23] I acknowledge the ? thing isn't ideal but it will work reasonably well, I think. [18:33:28] ?tour=whatever [18:33:43] But the wg would also work for logged in users or uncached pages I think. [18:33:49] Well the tours in question only appear for logged-in users, and we ensure that they're only shown once using an API preference [18:34:10] RoanKattouw, right, but we need to make sure the infrastructure handles it properly. [18:38:21] RoanKattouw, yeah, you're right. You can just use addTour here. [18:39:18] In one place we do use addModule directly, which is basically what addTour does (except in special cases that don't apply) [18:39:36] I'll ask Stephane why some of the code uses launchTourByCookie and other places use addModule [18:42:10] $out->addModules( 'ext.guidedTour.tour.RcFiltersHighlight' ); doesn't actually start the tour [18:42:42] in the case of highlight, we make the tour available in case the user clicks on the blue dot and we decide launch it [18:42:48] Oh right [18:43:20] That also addresses my other concern of having two tours at the same time [18:43:53] What I don't understand though -- launchTourByCookie() seems to be just an elaborate wrapper around addModules() with some logic for cookies and strange kinds of tours [18:45:14] I didn't consider the problem with having many cookies (http://img.pandawhale.com/post-55818-IT-Tech-Support-Pug-is-here-to-amUp.jpeg) [18:46:58] it does add the tour module but also sets the cookie [18:47:34] on the client side, there's something like "startTourFromEnvironement" that looks at the url and cookies and maybe more to know if it should start a tour [18:48:22] Hmm OK [18:48:37] So I guess we do need the cookie, now I understand Matt's protestations [18:49:12] the url would work just the same with ?tour=foo&step=bar but we do re-write the url on the RC page and I didn't really want to deal with that [18:49:18] I thought this would be a simple opportunity to cut down on some cookie usage and avoid the wrath of #wikimedia-perf , but it looks like it's more complicated than I thought [18:49:43] So now I understand his wg var suggestion [18:50:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3221828 (10SPoore) Hi all, the Support and Safety team and the Anti-Harassment Tools team... [18:50:07] We could ship a wg var to the client that tells it which tours to run [18:50:27] But that requires touching GuidedTour infra. Not that that's terrible, but I hadn't realized that my proposal involved that [18:50:29] yep, we could have the tour definitions decide if they should launch themselves based on some vars [18:52:13] or they could always launch if included, the server decides to addModule('tour-bla'), therefore it runs on the client [18:53:10] Anyway, I can now see many ways to make it work. [18:53:43] If it's important enough. [19:01:50] stephanebisson, I'm reworking the controller with private/public-api methods. We don't really do that anywhere, but what do you think of using _prefix for internal methods, just to make things clearer? either that, or maybe something like 'doX' or something that immediately tells the reader of the code that the method is API-facing or internal, beyond just tagging @private ? [19:02:04] stephanebisson: Shrug, not a big deal but would be nice to fix [19:02:06] I'll file a task [19:02:08] We sometimes have a "doX" methods in OOUI, though not often [19:05:03] stephanebisson: BTW I just found https://gerrit.wikimedia.org/r/350892 lying around uncommitted in my local copy, oops [19:05:28] RoanKattouw: I think we can do a nicely encapsulated GuidedTour::startTourByUsingWgVar or something [19:05:33] Yeah [19:05:36] That'd be nice [19:06:03] You wouldn't even need multiple wg vars, you could just have wgGuidedToursStartTheseToursNow = [ 'tour1', 'tour2' ] [19:06:31] yep [19:07:42] mooeypoo: I don't mind using something that really start out like "_" for controller private to further distinguish from top-level (user actions). It can help clarify that concept. [19:07:49] stand out* [19:07:53] * mooeypoo nods [19:08:47] RoanKattouw: it would also be nice to encapsule it with the user preference that controls it [19:08:55] Oh yeah, good idea [19:09:31] maybe even in the tour description [19:24:44] * mooeypoo cheers at the new controller [19:24:57] stephanebisson, it's so much clearer now... I'll push a WIP in a minute [19:25:17] aaand unsurprisingly -- EVERYTHING WORKS NOW [19:25:19] \o/ [19:25:50] never underestimate the value of readable code [19:25:54] https://gerrit.wikimedia.org/r/#/c/350763/2/resources/src/mediawiki.rcfilters/mw.rcfilters.Controller.js [19:25:55] ^ [19:26:09] stephanebisson, the diff might be a bit annoying, since I moved all public methods up and private methods to the bottom [19:26:13] but I think it's a lot clearer now [19:36:19] 06Collaboration-Team-Triage, 10Notifications: UI rendering issue when no notifications - https://phabricator.wikimedia.org/T164112#3222028 (10Jdlrobson) [19:48:57] RoanKattouw: can you easily trigger a coverage run for: https://gerrit.wikimedia.org/r/#/c/350894/ ? [19:49:27] Yes, will do that now [19:49:33] thanks [19:50:03] RoanKattouw, mooeypoo: https://gerrit.wikimedia.org/r/#/c/341294/ [19:51:13] stephanebisson: https://integration.wikimedia.org/ci/job/mediawiki-core-code-coverage-jessie/18/console [19:53:53] RoanKattouw, sorry for not being as clear as I should have been before about the GuidedTour before (and eventually confusing myself into thinking addTour would work). GuidedTour is not as close to working memory for me as it once was. [19:54:11] But yeah, I think we're on the right track with the wg. [19:58:12] (03PS1) 10Catrope: Load OOUI interactions icon pack to prepare for core icon pack deprecation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 [20:01:05] James_F: ---^^ [20:01:23] Thanks. [20:03:35] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: Viewing my watchlist (~5000 entries) returns a blank page or an HTTP 503 error when "Hide: Page categorisation" is activated - https://phabricator.wikimedia.org/T164059#3222124 (10Dereckson) [20:04:14] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3220312 (10Dereckson) [20:04:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3222136 (10BethNaught) @SPoore I wasn't under the impression that "the current configurat... [20:06:32] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3220312 (10Dereckson) [20:08:28] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3220312 (10Dereckson) >>! In T164059#3220838, @Paladox wrote: > This could have been ca... [20:09:16] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3222161 (10Dereckson) [20:35:30] ^ RoanKattouw, doesn't look related to structured filters (seems to be an issue with rendering of particular CatWatch categories, so not a filter issue per se, except of course hiding categories "works around" the issue). [20:36:25] Also reportedly months old. [20:36:29] (The hidecat one) [20:37:34] hah OK [20:42:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3222220 (10Catrope) >>! In T150419#3221828, @SPoore wrote: > As we understand it, the cur... [20:43:29] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3222226 (10Dereckson) [20:55:40] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: MediaWiki\Linker\LinkRenderer::makeKnownLink() must implement interface MediaWiki\Linker\LinkTarget, null given on Special:Watchlist - https://phabricator.wikimedia.org/T164059#3222277 (10Dereckson) [20:57:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 2 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3222283 [21:06:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3222348 (10Catrope) >>! In T150419#3222136, @BethNaught wrote: > @SPoore I wasn't under t... [21:06:59] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222349 (10jeblad) [21:12:03] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10MediaWiki-extensions-FlaggedRevs, and 2 others: [Regression] Sight links in RecentChanges not longer available (when option "Hide reviewed edits"... - https://phabricator.wikimedia.org/T164049#3219994 [21:14:35] LOL [21:14:46] "why doesn't this work?! Ugh I'll just go eat lunch" [21:14:51] It helps if I test against my localhost, not production [21:17:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3222384 (10Stevietheman) I might be the person who said it should work like a watchlist (... [21:23:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 06Support-and-Safety, 13Patch-For-Review: Allow users to restrict who can send them notifications - https://phabricator.wikimedia.org/T150419#3222399 (10Catrope) >>! In T150419#3222384, @Stevietheman wrote: > I might be the person... [21:40:20] 06Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 07Regression: [regression] Popup triangle not positioned correctly - https://phabricator.wikimedia.org/T163993#3222439 (10Volker_E) [21:40:35] matt_flaschen: https://gerrit.wikimedia.org/r/#/c/350914/ might fix, FWIW. [21:40:57] (03CR) 10Jforrester: [C: 031] Load OOUI interactions icon pack to prepare for core icon pack deprecation [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350896 (owner: 10Catrope) [21:42:09] RoanKattouw: https://phabricator.wikimedia.org/T164116#3222440 [21:42:16] James_F, looking [21:42:18] And https://phabricator.wikimedia.org/T164118 [21:42:23] matt_flaschen: Awesome, thank you. [21:44:02] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222349 (10Catrope) I'm able to turn it off just fine. I'd normally suggest that there might be something wrong with user scripts / site sc... [21:45:12] I can't reproduce that, BTW [21:46:07] It sounds like there might have been some gadget / user script code at nowiki that seriously messed with people's cookies; perhaps to the point of breaking their MW auth cookies? [21:47:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222480 (10jeblad) I still can't turn this feature off in Firefox. [21:50:33] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222499 (10jeblad) Can it be … a Heisenbug? [21:54:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222507 (10Catrope) You said on T164116 that clearing your cookies helped. Does it / did it help for this bug? Perhaps there is a broken us... [21:55:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350923 (owner: 10L10n-bot) [21:56:17] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222516 (10Catrope) @jeblad Are there any other reports of this not being able to be turned off, or is it just you? Are you able to change/... [21:56:44] That's really weird. When I make edits, nothing is going into RecentChanges. [21:57:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350927 (owner: 10L10n-bot) [22:01:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3222528 (10Catrope) I suggest we keep things consistent, and that we either use the grayed out treatment for both this... [22:01:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222529 (10jeblad) I have deleted the cookies but it did not fix the problem. I'll check on another machine. [22:01:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3222530 (10Catrope) [22:10:15] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222553 (10jeblad) Same problem on Firefox on a Win10 laptop. [22:11:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222554 (10Catrope) Very strange! I'll go in and manually turn it off for you. Can you then try turning it on again, to see 1) if that work... [22:13:42] I ran out of disk space in the Vagrant guest. Fun times. [22:13:55] ^ bd808, any suggestions where I should check? [22:14:08] redis? [22:14:16] or /var/log ? [22:14:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222557 (10Catrope) I just turned it off on the server side, can you try now? [22:14:34] what are you running in there matt_flaschen? [22:15:40] 06Collaboration-Team-Triage, 10MediaWiki-Patrolling: Unpatrolled edits not removable from patrollable list when page is deleted - https://phabricator.wikimedia.org/T53189#3222563 (10Nirmos) svwiki is now using https://sv.wikipedia.org/wiki/MediaWiki:Gadget-PatrolAndDelete.js as a temporary workaround until thi... [22:15:45] bd808, https://phabricator.wikimedia.org/P5349 . [22:17:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Figure out whether unusable filter groups should be hidden or grayed out - https://phabricator.wikimedia.org/T164122#3222575 (10Catrope) [22:18:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3216354 (10Catrope) >>! In T163964#3222528, @Catrope wrote: > I suggest we keep things consistent, and that we either u... [22:19:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Patrolled changes are shown as unpatrolled in RC Filters results - https://phabricator.wikimedia.org/T162020#3222610 (10Catrope) 05Open>03stalled Stalled while we await details and a screenshot. [22:19:55] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222615 (10jeblad) Logged in with another account in a private Firefox window and it worked as expected. Logged in with my usual account in... [22:20:42] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222616 (10jeblad) It has been on for my account "jeblad" the whole time. [22:21:44] 06Collaboration-Team-Triage, 10MediaWiki-Patrolling: Unpatrolled edits not removable from patrollable list when page is deleted - https://phabricator.wikimedia.org/T53189#3222619 (10Mattflaschen-WMF) >>! In T53189#3216604, @Nirmos wrote: > Here's an example: https://sv.wikipedia.org/w/index.php?title=Sofia_Haa... [22:22:07] RoanKattouw, does the ! directly relate to FlaggedRevisions? My understanding is not directly, but that we recently made a change to the "review implies patrol" behavior. [22:22:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222625 (10jeblad) I'll wipe my commons.js, vector.js, and global.js, and see whjats happen. [22:22:39] RoanKattouw, asking because of https://phabricator.wikimedia.org/T164049#3222368 . [22:23:02] Jeez: [22:23:04] root@mediawiki-vagrant:/var/log# du -sh /var/log/ [22:23:06] 4.6G /var/log/ [22:23:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222628 (10Catrope) Maybe you are running some JS code somewhere that turns it back on for you? I turned it off and saw that the `rcenhance... [22:23:57] matt_flaschen: AFAIK those are for review not patrol, but it's FlaggedRevs so who knows [22:24:15] Sorry, patrol not review [22:24:20] AFAIK ! reflects rc_patrolled and nothing else [22:24:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222349 (10Mattflaschen-WMF) @jeblad Do you have "Automatically enable all new beta features" checked? [22:27:04] 06Collaboration-Team-Triage, 10MediaWiki-Patrolling: Unpatrolled edits not removable from patrollable list when page is deleted - https://phabricator.wikimedia.org/T53189#3222637 (10Nirmos) Ah, well. In that case I have reported a valid problem, but on the wrong task. I think I can live with that =) [22:29:51] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222640 (10Catrope) >>! In T164118#3222629, @Mattflaschen-WMF wrote: > @jeblad Do you have "Automatically enable all new beta features" che... [22:30:18] 06Collaboration-Team-Triage, 10MediaWiki-Patrolling: Unpatrolled edits not removable from patrollable list when page is deleted - https://phabricator.wikimedia.org/T53189#3222642 (10Mattflaschen-WMF) >>! In T53189#3222637, @Nirmos wrote: > Ah, well. In that case I have reported a valid problem, but on the wron... [22:30:38] 06Collaboration-Team-Triage, 10MediaWiki-Patrolling: Unpatrolled edits not removable from patrollable list when page is deleted - https://phabricator.wikimedia.org/T53189#3222643 (10Mattflaschen-WMF) [22:30:43] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222644 (10jeblad) Still stuck. [22:33:34] RoanKattouw, yeah, for a while now I have had Views on how "Automatically enable all new beta features" should be implemented (actually track when it was added to a particular wiki in config, then something like setting the default to true dynamically if preferences were last saved before that). [22:34:09] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222649 (10jeblad) Bah! Turned off auto-enroll and now I can turn "New filters for edit review" off. I have turned "Hovercards" on and off... [22:36:34] matt_flaschen: I'm sure James_F would welcome someone fixing that long-broken feature [22:36:59] RoanKattouw, yeah. I'll add it to my TODO list: T64815 [22:37:00] T64815: BetaFeatures: "Automatically enable ..." should actually automatically enable, not require visiting Special:Preferences - https://phabricator.wikimedia.org/T64815 [22:37:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" - https://phabricator.wikimedia.org/T164118#3222653 (10jeblad) But nice catch @Mattflaschen-WMF and @Catrope, then the culprit is sloppy code for Betafeatures! =) [22:38:12] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Beta-Feature: Can't turn off "New filters for edit review" if "Automatically enable all new beta features" is on - https://phabricator.wikimedia.org/T164118#3222672 (10Catrope) [22:41:38] 06Collaboration-Team-Triage, 10MediaWiki-Patrolling: Unpatrolled edits not removable from patrollable list when page is deleted - https://phabricator.wikimedia.org/T53189#3222685 (10Nirmos) The discrepancy is between Special:NewPages (or more specifically Special:NewPages&hidepatrolled=1) and the API. Sometime... [22:41:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3222686 (10Catrope) [22:57:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3222720 (10Catrope) >>! In T159791#3215632, @Mattflaschen-WMF wrote: > @Catrope said in today's m... [23:02:31] bd808, T164126 [23:02:32] T164126: More aggressive log rotation for daemon.log and syslog to save disk space - https://phabricator.wikimedia.org/T164126 [23:04:05] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3222751 (10Catrope) [23:04:58] Will be back on to review https://gerrit.wikimedia.org/r/#/c/350914/ and finish the FlaggedRevs later tonight. [23:13:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Allow users to save their filter selections for later reuse - https://phabricator.wikimedia.org/T164128#3222783 (10Catrope) a:05MSchottlender-WMF>03Mooeypoo [23:52:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Replace "Tag filter" input with a dropdown+lookup widget in RCFilters - https://phabricator.wikimedia.org/T161650#3222821 (10Catrope)