[00:12:34] (03Merged) 10jenkins-bot: Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/350334 (https://phabricator.wikimedia.org/T163749) (owner: 10Catrope) [00:33:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode - https://phabricator.wikimedia.org/T163749#3212673 (10Catrop... [01:06:40] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-User-blocking: [ wmf.8] mediawiki anon user warning has wikitext - https://phabricator.wikimedia.org/T155652#3212714 (10Krinkle) [01:07:10] 06Collaboration-Team-Triage, 10Flow: [ wmf.8] mediawiki anon user warning has wikitext - https://phabricator.wikimedia.org/T155652#3212718 (10Krinkle) [01:07:12] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Possible-Tech-Projects, and 2 others: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#1939819 (10srishakatux) [01:07:53] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 06TCB-Team, and 3 others: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#3212720 (10srishakatux) [01:09:04] (03PS2) 10Jforrester: FlowThanksPresentationModel: Use NS_TOPIC directly instead of obsolete &workflow= parameter [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249359 (owner: 10Catrope) [01:09:34] (03CR) 10Jforrester: "PS2: Manual re-application based on chatting with Roan. Untested." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249359 (owner: 10Catrope) [01:43:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: [betalabs-regression] RC filters - UI changes in display... - https://phabricator.wikimedia.org/T163522#3212757 [01:44:45] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 07Epic, 07Tracking: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#3212759 (10jmatazzoni) [01:44:47] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 07User-notice-collaboration: Set the default for Special:Notifications to "Unread" (at l... - https://phabricator.wikimedia.org/T162927#3212758 [01:45:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: For Conflict States, short-circuit the fruitless searche... - https://phabricator.wikimedia.org/T160220#3212760 [01:45:53] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10BetaFeatures, 10MediaWiki-User-preferences, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), and 2 others: 'Beta' link redirects to the section on 'Preferences' where the most recent cha... - https://phabricator.wikimedia.org/T162938#3212761 [01:46:19] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: Blue dot gets de-attached on scrolling - https://phabricator.wikimedia.org/T162971#3212762 (10jmatazzoni)... [01:46:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3212763 (10jmatazzoni) 05Open... [01:47:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3212766 (... [01:47:15] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, and 2 others: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3212767 (10jmatazzon... [01:47:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 07Design, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)): Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#3212768 (10jmatazzoni) 05Open>03Resolved [01:48:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications: [minor] White outline is displayed around some elements - https://phabricator.wikimedia.org/T163266#3212769 (10jmatazzoni) 05Open>03Resolved [03:40:59] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3212849 (10Volker_E) @Etonkovi... [03:52:49] matt_flaschen, if you're still around, can you remind me how to remove ores from vagrant again? Do I have to reprovision? [03:52:58] these internal errors are impossible to work with [03:59:30] mooeypoo, sure, quick fix is: [03:59:45] mv puppet-managed/10-ORES.php puppet-managed/10-ORES.php.disabled [03:59:56] ^ mooeypoo, in your settings.d directory (in either guest or host). [04:00:39] mooeypoo, note if you re-provision it will come back. You can also disable for real with disable-role (if you do both, then you don't have to wait, but it won't come back). [04:00:46] matt_flaschen, I already removed the role, but it wll be good to maybe do it like that with the role on so I can quickly (without provisioning again) enable/disable it [04:00:51] that bug is annoying as hell [04:01:50] mooeypoo, yeah, and I am suspicious that it is affecting real production requests as well, just not as obviously. [04:01:57] But I don't know that. [04:02:28] Yeah [04:12:18] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Interface: To create a new message displayed in reading mode for article's talk pages - https://phabricator.wikimedia.org/T19163#3212900 (10Shizhao) 05Open>03Resolved a:03Shizhao see https://www.mediawiki.org/wiki/Manual:Interface/Talkpageheader [05:31:12] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: Invalid parameter for message "parentheses" - https://phabricator.wikimedia.org/T61124#3212967 (10TTO) @demon, is this still in WMF logs? If not, we should close this. [06:05:40] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3212981 (10Marostegui) I have double checked all the shards now and the wikis that contain that table, they all have the PRIMARY ke... [08:28:26] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke categorization changes - https://phabricator.wikimedia.org/T163874#3213060 (10matej_suchanek) [08:29:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 13Patch-For-Review: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3213076 (10Pginer-WMF) >>! In T159942#3210689, @Mooeypoo wrote: > Yes, I opened a ch... [08:29:19] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke categorization changes - https://phabricator.wikimedia.org/T163874#3213077 (10matej_suchanek) p:05Triage>03Unbreak! [08:32:56] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke categorization changes - https://phabricator.wikimedia.org/T163874#3213094 (10matej_suchanek) Doesn't happen when logged out or without sysop rights. Request from 89.177.50.85 via cp2013 cp2013, Varnish XID 671981055 Error... [08:49:08] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke categorization changes - https://phabricator.wikimedia.org/T163874#3213107 (10matej_suchanek) When I deleted that page, all changes to it should have been deleted from recentchanges which didn't happen. This is already trac... [09:00:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Support viewing only the last revisions done on a page in the new filters for edit review - https://phabricator.wikimedia.org/T163561#3213111 (10Pginer-WMF) [09:01:19] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Support viewing only the last revisions done on a page in the new filters for edit review - https://phabricator.wikimedia.org/T163561#3201674 (10Pginer-WMF) [09:01:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3213113 (10Pginer-WMF) [09:01:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3170940 (10Pginer-WMF) [09:06:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Support viewing only the last revisions done on a page in the new filters for edit review - https://phabricator.wikimedia.org/T163561#3213123 (10Pginer-WMF) >>! In T163561#3207180, @Trizek-WMF wrote: > While seeing y... [09:07:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Support viewing only the last revisions done on a page in the new filters for edit review - https://phabricator.wikimedia.org/T163561#3213125 (10Trizek-WMF) >>! In T163561#3213123, @Pginer-WMF wrote: >Having it as a... [09:16:20] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke categorization changes - https://phabricator.wikimedia.org/T163874#3213060 (10Addshore) Nothing seems to break for me as 1) an anon user 2) a regular logged in user 3) a sysop. I am guessing you mean when you deleted Talk:... [09:20:04] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke categorization changes - https://phabricator.wikimedia.org/T163874#3213150 (10matej_suchanek) 1), 2) same by me but not 3). It either doesn't load for me, or shows "Wikimedia Error" screen. And the difference it (not) havin... [09:21:32] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213060 (10matej_suchanek) [09:31:32] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213179 (10Addshore) When loading https://www.wikidata.org/w/index.php?title=Special:RecentChangesLinked&hidecategorization=0&hidepatrolled=0&targ... [09:34:16] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 07Wikimedia-log-errors: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213196 (10Addshore) [09:34:23] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 07Regression, 07Wikimedia-log-errors: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213060 (10Addshore) [10:03:55] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 13Patch-For-Review, and 2 others: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213229 (10matej_suchanek) https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/changes/E... [10:18:44] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 13Patch-For-Review, and 2 others: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213257 (10Addshore) Stacktrace: ``` 2017-04-26 10:16:14 [WQBzbgpAIHwAAEJQzc8AAAAK] mwdebug1002 wikidatawiki... [10:23:58] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 13Patch-For-Review, and 2 others: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213282 (10matej_suchanek) @Addshore I think this is mistake, see my comment in gerrit. [11:01:14] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3213364 (10David_Hedlund) @Mattflaschen-WMF > That is just a list of revisions, but it... [11:07:05] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3213373 (10David_Hedlund) I don't see what I Thanked for @Mattflaschen-WMF * Thanks lo... [11:28:08] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3213408 (10David_Hedlund) @MZMcBride Can you please copy my concrete example to the top... [11:53:42] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 07Regression, 07Wikimedia-log-errors: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213448 (10Addshore) [13:09:22] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 07Regression, 07Wikimedia-log-errors: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213692 (10Addshore) ``` 2017-04-26 13:08:41 [WQCb2QpAIHwAAEJQ3q8AAAAG] mwdebug1002 wikidatawiki 1.29.0-... [13:38:45] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 - https://phabricator.wikimedia.org/T163896#3213751 (10aude) [13:54:52] 10MediaWiki-Recent-changes, 10CatWatch, 06TCB-Team, 07Regression, 07Wikimedia-log-errors: Deleting a page on Wikidata broke related changes with enhanced rc - https://phabricator.wikimedia.org/T163874#3213924 (10Addshore) So it looks like this was caused by https://gerrit.wikimedia.org/r/#/c/288579/24/in... [14:46:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3214087 (10SBisson) I use this command in the js console to reset the s... [14:58:44] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Possible-Tech-Projects, and 2 others: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#3214125 (10jmatazzoni) [14:59:57] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Possible-Tech-Projects, and 2 others: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#1939819 (10jmatazzoni) I've pasted the New Notification Request Form into... [15:46:16] (03CR) 10Zfilipin: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [15:52:47] 10MediaWiki-Watchlist, 07Wikimedia-log-errors: Invalid parameter for message "parentheses" - https://phabricator.wikimedia.org/T61124#3214438 (10demon) Not to my knowledge [15:53:49] (03CR) 10Zfilipin: [C: 031] Echo should notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348721 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [15:58:28] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3214458 (10matmarex) [16:00:12] (03CR) 10Etonkovidova: [C: 032] Echo should notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348721 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [16:05:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (i... - https://phabricator.wikimedia.org/T158225#3214512 [16:05:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice: Announce and follow up with communities about the New Filters for Rece... - https://phabricator.wikimedia.org/T146972#3214513 [16:05:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 3 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3214510 [16:07:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 4 about the New Filters for... - https://phabricator.wikimedia.org/T158335#3214521 [16:08:18] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 4 about the New Filters for... - https://phabricator.wikimedia.org/T158335#3033763 [16:11:03] (03Merged) 10jenkins-bot: Echo should notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348721 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [16:12:37] (03CR) 10jenkins-bot: Echo should notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348721 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [16:35:31] (03Abandoned) 10Zfilipin: [WIP] RSpec tests for mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/313221 (https://phabricator.wikimedia.org/T146916) (owner: 10Etonkovidova) [17:12:11] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3214827 (10kaldari) @David_Hedlund: Are you describing the behavior with or without the... [17:16:57] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3214837 (10Krinkle) >>! In T163337#3203234, @Krinkle wrote: >>>! In T163337#3200616, @Joe wrote: >>>>! In T163337#3196493, @... [17:41:20] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3193929 (10elukey) Checked very quickly replication status and db keys stored for the rdbs 2003 / 1003 / 2004: ``` elukey@r... [17:45:01] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 4 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3177639 (10Esanders) Having tools relabel based on state vio... [18:07:49] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 4 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3215045 (10Jdforrester-WMF) >>! In T162864#3214981, @Esander... [18:18:04] 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 06Collaboration-Team-Triage, 10Flow, 07Performance: Some Flow topics are not being created properly in core page and revision tables - https://phabricator.wikimedia.org/T105859#3215052 (10Aklapper) [18:23:59] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200259 (10DannyH) @Catrope This bug is going to block the LoginNotify release. Do you think you'll be able to pick this up in an upcoming... [18:26:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3215093 (10Catrope) Note that {T161888} changed the interaction between reviewing and patrolling... [18:39:14] 06Collaboration-Team-Triage, 10Notifications: InvalidArgumentException from line 85 of ResourceLoaderImage.php: Invalid file type for image files of 'edit' (valid: svg, png, gif, jpg) - https://phabricator.wikimedia.org/T161419#3215147 (10Aklapper) 05Open>03stalled @Paladox: Could you please answer the las... [18:42:17] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215156 (10Mattflaschen-WMF) [18:48:30] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3215216 (10David_Hedlund) @kaldari As Wikipedia is right now, without the patch I guess. [18:52:07] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 5 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3215234 (10Jdforrester-WMF) 05Open>03Resolved [19:42:13] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 6 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3215358 (10Dvorapa) If missing "switch to" would be more con... [19:42:35] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 - https://phabricator.wikimedia.org/T163896#3215367 (10mmodell) [19:43:43] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 - https://phabricator.wikimedia.org/T163896#3213751 (10mmodell) p:05Triage>03High... [19:44:29] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 - https://phabricator.wikimedia.org/T163896#3215377 (10mmodell) I'm still trying to... [19:51:23] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [mobile-wmf.20] RC page - UI issues - https://phabricator.wikimedia.org/T163164#3215395 (10Jdlrobson) The mediawiki ui checkbox doesn't seem to have a disabled implementation so this will need to be added. The dropdown works for me, it's just c... [19:54:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3215413 (10SBisson) @Pginer-WMF do you have the graphic for the confirm... [19:56:44] Hey folks. I'm just about to do a new deploy of ORES. [19:56:57] There was some deeper code changes that went out to beta last night. [19:57:07] Any weirdness you want to make me aware of before I deploy to prod? [19:57:40] halfak: We have noticed that prod intermittently 400s when requesting filter stats for testwiki goodfaith [19:57:46] There's a task about that somewhere [19:57:55] But that's already broken, so not a reason to not deploy I suppose [19:57:58] 400s!? [19:58:05] Yes(!) [19:58:38] Hmm maybe that was only in beta? [19:58:41] T157790 [19:58:42] T157790: On beta cluster, ORESFetchScoreJob got a HTTP 400 bad request from ores-beta - https://phabricator.wikimedia.org/T157790 [19:59:14] Hmm...I can replicate it. WTF!? [19:59:34] So, one theory [19:59:48] Only happens with goodfaith. I bet it's cached. [19:59:49] Amir quoted some config that he thinks proves that the goodfaith model is disabled everywhere on beta [20:00:01] But it must not be, because you can see good faith-related filters in RCFilters on beta wikis [20:00:07] right. [20:00:18] So either he's wrong or that's coming from a separate config [20:01:07] It might be that it's legitimately the case that the fake testwiki model doesn't support goodfaith (if so, we should probably fix that, goodfaith is a first-class citizen now, like damaging) [20:01:17] But I also get the feeling that something else might be up due to the intermittence [20:02:12] RoanKattouw, halfak, it's not just Beta. Happens on production too: T163764 [20:02:13] T163764: Bad Request (400) on testwiki test models - https://phabricator.wikimedia.org/T163764 [20:02:21] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 - https://phabricator.wikimedia.org/T163896#3215427 (10SBisson) a:03SBisson `inclu... [20:02:25] yeah. s eeing that now. [20:02:58] Yeah but only for testwiki, right? [20:03:08] So it won't get in the way of "real" production usage [20:04:16] Yeah, but I didn't really try the others. RoanKattouw, halfak, with production testwiki, it's very intermittent (refreshes randomly cause it or not), so I doubt it's a config issue. [20:05:08] I mean it could be an unupdated backend issue, but that wouldn't happen both in prod and in labs, reasonably speaking [20:05:15] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Warning: onEnhancedChangesListModifyBlockLineData() expects exactly 4 parameters, 3 given in /srv/mediawiki/php-1.29.0-wmf.21/extensions/Flow/Hooks.php on line 538 - https://phabricator.wikimedia.org/T163896#3215440 (10mmodell) I guess this is rela... [20:08:49] halfak, also, could you post at T163764 (or just here) about how to check the logs in case we have to troubleshoot the service in the future? [20:08:50] T163764: Prod: Bad Request (400) on testwiki test models - https://phabricator.wikimedia.org/T163764 [20:09:02] doing a deployment. [20:09:05] Wil;l get it it soon [20:09:10] Thanks [20:09:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215462 (10Mattflaschen-WMF) a:05Pginer-WMF>03None [20:17:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215497 (10jmatazzoni) The description is a little abbreviated here. What is the purpose of this task? [20:20:12] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Flow: Score vorbis content doesn't roundtrip (html/wikitext) properly - https://phabricator.wikimedia.org/T74912#3215503 (10Jdforrester-WMF) 05Open>03Resolved This appears now fixed: https://en.wikipedia.beta.wmflabs.org/wiki/Topic:Tii48db27pj86dzd [20:20:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215505 (10Mattflaschen-WMF) [20:20:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215156 (10Mattflaschen-WMF) [20:21:17] (03PS1) 10Sbisson: Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350477 (https://phabricator.wikimedia.org/T163896) [20:21:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215156 (10Mattflaschen-WMF) [20:21:42] ^ jmatazzoni_, I tried to clarify T163930 . [20:21:43] T163930: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930 [20:23:18] (03CR) 10Catrope: [C: 032] Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350477 (https://phabricator.wikimedia.org/T163896) (owner: 10Sbisson) [20:32:08] RoanKattouw, set up a meeting for T163712 at 3 PM your time. [20:32:09] T163712: " Highlight likely problem edits with colors and an "r" for "needs review"" shows up even with RC Filters beta feature enabled - https://phabricator.wikimedia.org/T163712 [20:32:21] Thanks [20:34:02] (03Merged) 10jenkins-bot: Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350477 (https://phabricator.wikimedia.org/T163896) (owner: 10Sbisson) [20:34:17] (03CR) 10jenkins-bot: Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350477 (https://phabricator.wikimedia.org/T163896) (owner: 10Sbisson) [20:37:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 13Patch-For-Review: Ask Arabic Wikipedia about Flow beta activation - https://phabricator.wikimedia.org/T155720#3215600 (10Catrope) Scheduled for 23:00 UTC today (... [20:38:04] BTW, we now have advanced support for finnish wikipedia in ORES. [20:38:22] So you could enable ORES/filters/whatever there ^_^ [20:39:10] Nice [20:39:18] Oh that model was deployed just now? [20:39:47] We'll have to glance at the model stats and set some stuff up in the config [20:39:59] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Community-curated list of quick links - https://phabricator.wikimedia.org/T163930#3215611 (10Halfak) Seems like this is about allowing people to define filter-combinations to share with each other. [20:40:03] damaging/goodfaith [20:40:05] RoanKattouw, ^ [20:40:06] I can schedule this for the week after next (because next week there's a deployment freeze) [20:40:09] (03PS1) 1020after4: Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/350481 (https://phabricator.wikimedia.org/T163896) [20:40:24] RoanKattouw, should we stop doing "Deploy ORES Review Tool" tasks now? [20:40:28] we = ORES team [20:40:36] halfak: Awesome. Did you also just deploy new versions of existing models? Would the test_stats have changed for any of them? [20:40:47] No change to current test_stats [20:40:51] Excellent [20:41:01] So just new ones for fiwiki [20:41:06] That won't happen for a couple weeks at best and it'll come with the new "thresholds" thingie. [20:41:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3215632 (10Mattflaschen-WMF) @Catrope said in today's meeting we should start by just porting it... [20:41:35] OK, cool, then we don't have to worry about coordinating deployment of that, because we'll already be coordinating because of the thresholds stuff [20:46:06] (03CR) 1020after4: [C: 032] Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/350481 (https://phabricator.wikimedia.org/T163896) (owner: 1020after4) [20:51:07] halfak: Anyway re fiwiki, I'll confer with Joe and Benoît but my general idea is to enable ORES there (RCF is already enabled there) into our already-scheduled May 9th RCF release. Does that sound good? Or do you not care very much? [20:51:43] Sounds good. [20:51:47] Cool [20:51:55] I'll set it up and inform the others [20:55:12] (03Merged) 10jenkins-bot: Make onEnhancedChangesListModifyBlockLineData expect 3 args [extensions/Flow] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/350481 (https://phabricator.wikimedia.org/T163896) (owner: 1020after4) [20:55:59] 06Collaboration-Team-Triage, 10Notifications: InvalidArgumentException from line 85 of ResourceLoaderImage.php: Invalid file type for image files of 'edit' (valid: svg, png, gif, jpg) - https://phabricator.wikimedia.org/T161419#3215683 (10Paladox) Woop sorrys, didn't see comment. Nope, i didn't have the thanks... [21:35:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Deploy ORES Review Tool to Finnish Wikipedia - https://phabricator.wikimedia.org/T163011#3215809 (10Catrope) a:03Catrope [21:36:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: Deploy ORES Review Tool to Finnish Wikipedia - https://phabricator.wikimedia.org/T163011#3183232 (10Catrope) [21:42:48] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php - https://phabricator.wikimedia.org/T163154#3215843 (10mwjames) Given the following message [0], are we goin... [21:49:35] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 05MW-1.29-release: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php - https://phabricator.wikimedia.org/T163154#3215896 (10Krinkle) [21:49:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 05MW-1.29-release: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php - https://phabricator.wikimedia.org/T163154#3187891 (10Krinkle) p:05Triage>03High [22:20:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: " Highlight likely problem edits with colors an... - https://phabricator.wikimedia.org/T163712#3216038 [23:19:48] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Documentation, 07Documentation: Update Notifications/Developer guide - https://phabricator.wikimedia.org/T162314#3158958 (10jmatazzoni) There are definitely too many pages here that overlap one another. And the sections are unclear/mixed. I'd propo... [23:20:02] 10MediaWiki-Recent-changes, 05MW-1.29-release: 1.29.0-alpha / Template failed integrity check on "EnhancedChangesListGroup.mustache" in TemplateParser.php - https://phabricator.wikimedia.org/T163154#3216264 (10Catrope) [23:35:38] (03PS1) 10MaxSem: WIP: Add user right expiry notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350500 (https://phabricator.wikimedia.org/T153817) [23:41:31] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add user right expiry notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350500 (https://phabricator.wikimedia.org/T153817) (owner: 10MaxSem) [23:45:08] RoanKattouw: betalabs cawiki, dewiki, zhwiki - display Internal error "Global default 'soft' is invalid for field oresDamagingPref" [23:45:18] .... [23:45:22] I thought we'd merged the fix for that [23:45:39] RoanKattouw: enwiki, ruwiki, hewiki are fine ... [23:47:14] Ooooh I think I get it [23:47:21] Those wikis don't have that model [23:47:43] 'soft' corresponds to 'likelybad' [23:47:52] But some wikis are configured to not have a likelybad filter [23:48:00] Those ones should be fine though.... hmm.... [23:48:29] RoanKattouw: interesting I was trying to see the pattern and could not :) [23:48:38] I think it's wikis that have ORES in prod vs not [23:49:54] RoanKattouw: yeah... seems so [23:50:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for ' - https://phabricator.wikimedia.org/T163964#3216354 (10jmatazzoni) [23:51:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3216354 (10jmatazzoni) [23:52:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Add filter set for 'Watchlisted pages' to RC Filters - https://phabricator.wikimedia.org/T163964#3216384 (10jmatazzoni) @Pginer-WMF, the functionality re. the filters being displayed but grayed out was suggested by J...