[00:08:32] They'll have worse problems if they do that [00:08:42] Remember that the page view UI also knows about namespace grouping [00:08:52] Through the "Article | Talk" tabs [00:09:11] That uses stuff like MWNamespace::isTalk() which is implemented as, you guessed it, $ns % 2 === 1 [00:14:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems" - https://phabricator.wikimedia.org/T163757#3208414 (10jmatazzoni) [00:53:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 10Revision-Scoring-As-A-Service-Backlog: ORES on en.wiki chokes on "V. likely good faith" + "Likely have problems" - https://phabricator.wikimedia.org/T163757#3208481 (10Catrope) The... [01:00:59] RoanKattouw, ha.. that's... not... what I'd consider good but I guess it is reassuring for this specific case [01:04:33] mooeypoo: Read more of MWNamespace.php if you want to encourage yourself to use that liquor collection of yours [01:04:55] (Seriously though, it's not all bad, and does provide some insight in how namespace management works) [01:05:52] I'll add it to my reading list [01:05:58] is there an Audible version/ [01:13:13] lol [02:01:02] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests, 13Patch-For-Review: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3208596 (10Catrope) >>! In T161041#3205804, @gerri... [02:12:51] 10MediaWiki-Recent-changes, 10Wikidata: More flexible and modernized Recent Changes code - https://phabricator.wikimedia.org/T114474#3208609 (10Mattflaschen-WMF) Although the focus of {aa063f4c5a19e2a267e694e3614af1c3ce4498da} was the filter system, there was some overlap at the edges, regarding isRowApplicabl... [02:15:58] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817#3208611 (10MaxSem) Next question: what to do if the right was assi... [02:17:09] RoanKattouw, mooeypoo, my favorite is MWNamespace->equals: "It's possible that in the future we may start using something other than just namespace indexes." On the one hand, it seems incredibly optimistic (if we improve the rest of MW to the point where integer namespace indices are the problem, that's pretty impressive). On the other hand, it turns out this is an actual problem (there is a wikitech-l thread somewhere, [02:17:11] but basically namespace collisions are a non-trivial mess in some cases with our current model), and clearly no one is actually using this equals method even in core... [02:18:14] Also, whether NS_TOPIC complies with this %2 convention is left as an exercise for the reader. [02:18:31] You may recall the bugs caused by there being no wiki column in some flow tables [02:19:01] That code only crashed because it tried to use a namespace ID from one wiki that didn't exist on another [02:22:07] I thought it was not querying on it (I could be wrong though), but yeah. [02:22:59] Or was it the *Reference ones? Maybe I'm wrong and those were missing it in the table too. [02:29:19] Yeah, the fact we register namespaces WITH IDs seems to be an issue [02:29:29] wouldn't have been better to register a new namespace, and have the system pick its ID [02:29:37] then have a map if you want to connect it back....? [02:37:49] RoanKattouw, matt_flaschen meh, I've been getting intermittent "Internal error" in vagrant for RecentChanges [02:37:50] RuntimeException from line 53 of /vagrant/mediawiki/extensions/ORES/includes/Api.php: Failed to make ORES request to [https://ores.wikimedia.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json], There was a problem during the HTTP request: 400 BAD REQUEST [02:37:57] It happens A LOT now [02:38:05] mooeypoo, yeah, me too. I think it's probably on their end, though. [02:38:06] Refreshing a couple of times solves it, but it's really annoying [02:38:14] It's not local? [02:38:14] Let me look if there's a task. [02:38:36] mooeypoo, I don't think so. It's requesting to the production service (just using a test model and wiki) [02:38:43] yeah I just noticed it does that [02:38:59] Maybe we should localize/fake the vagrant one? the point is to make things local, no? [02:39:08] well, it should be fixed anyways, but regardless [02:41:09] mrr it's seems to be completely down now [02:41:10] mooeypoo, yeah, if you go down that road too far, it eventually it takes over 20 minutes to provision (not an exaggeration, I know this from experience), and right now you're not actually working on the ORES service. [02:41:14] This may fall on the localize side of the line, but in the meantime I'll file. [02:41:25] yeah [02:41:51] mooeypoo, I just got it in the browser, on the exact same URL. Definitely on their side: [02:41:53] https://ores.wikimedia.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json [02:41:56] {"error": {"code": "bad request", "message": "Model 'goodfaith' not available for testwiki."}} [02:42:44] :\ [02:43:49] mooeypoo, T163764 [02:43:50] T163764: Bad Request (400) on testwiki test models - https://phabricator.wikimedia.org/T163764 [02:44:05] Awesome, thanks matt_flaschen [02:44:19] We should probably get access to the ORES service logs, though, for a lot of reasons (first this, but also if there are production problems we'll probably be a point of contact a lot). [02:44:30] mooeypoo, RoanKattouw, do you know how to access those logs? [02:46:35] No clue :\ [02:46:39] this is super frustrating, though [02:47:17] mooeypoo, it's now going back and forth. [02:47:18] No idea [02:47:40] You guys should complain / seek help in #wikimedia-ai [02:47:44] You can disable ORES by moving /vagrant/settings.d/puppet-managed/10-ORES.php to /vagrant/settings.d/puppet-managed/10-ORES.php.disabled if you're not actively working on that part. [02:48:38] Pinged there. [02:49:37] RoanKattouw, TIL you can do: [02:49:39] sudo service jobrunner status [02:49:50] and see why the job failed. [02:49:59] Not sure if you have to stop it first (probably not, but I happened to this time) [02:51:03] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817#3208656 (10MaxSem) a:03MaxSem [02:56:14] Interesting! [02:56:49] But ahm, don't we have caching of ORES thresholds in Stats.php? [02:57:08] I can't really reconcile the frequency of this happening with the supposed caching in the code [03:02:27] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817#3208682 (10TTO) >>! In T153817#3208611, @MaxSem wrote: > Next ques... [03:13:53] Fixed the issue that was causing the job to fail. Will continue (debugging through by running jobs manually) tomorrow. [03:14:01] (This is for the Wikidata stuff) [03:14:12] Have a good night, see you tomorrow. [03:14:35] RoanKattouw, ... "blanknamespace" is (Main) **with** the parentheses. [03:14:41] ... great. [03:14:45] Yes, that's correct [03:14:54] As you might have noticed, that is what's used //everywhere// [03:14:56] It looks bad [03:15:13] But... all the other namespaces aren't- oh, I guess it's not really a namespace [03:15:16] eh ok [03:15:16] Yes [03:15:24] It's not [[Main:Foo bar]] [03:15:29] * mooeypoo anticipates joe and pau wanting to change that for the tag display [03:15:32] :(Main) [03:15:36] hah [03:15:38] and :not (Main) [03:15:43] The answer to that is "no" [03:15:50] I mean, we can remove the colon if they want [03:15:51] we could have our own message [03:15:53] But the parentheses aren't going anywhere [03:15:58] We *could*... [03:15:59] But no [03:16:06] no the colon is symbolizing 'namespace' in tags [03:16:08] so... [03:16:13] Let's make things consistent with how they're already done in MW for once [03:16:23] ... [03:16:28] Oh, yes [03:16:41] It's kind of on the wrong side but I see where it's coming from [03:16:50] Consistency ...... user understanding ..... consistency...... user understanding.... [03:17:04] Wanna bet which of those wins in a Pau-Joe battle? [03:17:41] Pau and Joe vs RoanKattouw on the consistency of parentheses on the (Main) namespace -- I'm getting popcorn for that one. [03:18:07] Seriously though -- I am not sure which side I'd land on that one. With respect to MW, there are consistency things that make no sense [03:18:14] That's true [03:19:09] I think the main arguments are 1) you need to somehow represent that it's a special kind of namespace (more accurately, its name is the empty string) and 2) a wiki can have a namespace called "Main" that is not the same as the "(main)" namespace [03:19:20] We're already changing a bunch of the core-concepts in RCFilters to make them more clear to users... I can see the argument to doing the same to (Main) [03:19:33] Oh, you can put the label as "General article namespace" [03:19:34] or something [03:19:52] Just something that explains it [03:36:09] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/350114/ [03:36:42] Yeah, Article namespace works [03:36:59] I think (Article) does appear in some namespace selectors somewhere maybe? [03:37:12] mooeypoo: You have a Bug: and a Big: in there [03:37:16] Either side of the Change-Id:, even [03:37:33] I'll look later, David is having me read about monoids and category theory right now [03:40:48] ha [03:41:41] RoanKattouw, I'm not entirely happy with all of it, but it is a start to the rest [07:17:35] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3208863 (10Marostegui) Thanks @jcrespo for testing it! I have altered all **s3** wikis (that have watchlist table) now on the maste... [08:40:27] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3208992 (10Marostegui) s6 is done. db1093 already had the correct schema in all the databases so it failed. I skipped that transact... [09:08:29] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209057 (10Addshore) >>! In T130067#3208863, @Marostegui wrote: > Thanks @jcrespo for testing it! > I have altered all **s3** wikis... [09:09:31] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209058 (10Marostegui) >>! In T130067#3209057, @Addshore wrote: >>>! In T130067#3208863, @Marostegui wrote: >> Thanks @jcrespo for... [09:38:01] 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Provide a way to filter Wikidata's recent changes for language-dependent content in specific languages - https://phabricator.wikimedia.org/T141866#3209104 (10ChristianKl) From a privacy standpoint, I don't see why the language... [09:38:58] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209105 (10Marostegui) db1093 watchlist table from frwiki, jawiki and ruwiki has been re-imported. [09:41:51] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209108 (10Marostegui) s4 is done db1091 had the schema already there, so I will reimport its table once the other slaves have caug... [09:57:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 13Patch-For-Review: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3209133 (10Pginer-WMF) >>! In T159942#3208374, @Catrope wrote: > About the exclude b... [10:01:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 13Patch-For-Review: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3209134 (10Pginer-WMF) >>! In T159942#3208697, @gerritbot wrote: > Change 350114 had... [10:12:54] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209143 (10Marostegui) >>! In T130067#3209108, @Marostegui wrote: > s4 is done > db1091 had the schema already there, so I will rei... [10:33:24] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209228 (10Marostegui) s2 is done. db1090 needs to get the table reimported. [10:49:27] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_timestamp to the watchlist table - https://phabricator.wikimedia.org/T125991#2002327 (10daniel) I think we want this field, but I'm worried that the intended semantics is still unclear. In the patch by addshore, the... [11:11:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests, 13Patch-For-Review: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3209301 (10SBisson) >>! In T161041#3208596, @Catro... [11:14:13] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209302 (10Marostegui) db1090 has been reimported from db1076 [12:24:00] 06Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, 10Parsoid, and 3 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3209440 (10NHarateh_WMF) [12:31:23] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209591 (10Marostegui) s5 is done. db1092 needs its table reimported. [13:06:25] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209756 (10Marostegui) >>! In T130067#3209591, @Marostegui wrote: > s5 is done. db1092 needs its table reimported. table reimporte... [13:11:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3209761 (10SBisson) a:03SBisson [13:19:33] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209783 (10Marostegui) I have altered labstestweb2001 and silver too to avoid the issues encountered at: T155605 yesterday (column... [13:32:55] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348721 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [13:33:00] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348761 (https://phabricator.wikimedia.org/T146916) (owner: 10Zfilipin) [13:33:03] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348764 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [13:33:08] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348768 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [13:33:11] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348769 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [13:33:16] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348774 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [13:33:20] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348775 (https://phabricator.wikimedia.org/T14691) (owner: 10Zfilipin) [13:33:38] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209823 (10Marostegui) s1 is done. db1089 needs its table reimported, I will do so once the slaves have caught up [14:06:54] 06Collaboration-Team-Triage, 10Flow, 10Parsoid: Flow: Score vorbis content doesn't roundtrip (html/wikitext) properly - https://phabricator.wikimedia.org/T74912#3209924 (10Liuxinyu970226) [14:38:44] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3209993 (10Marostegui) dbstore1001 just got the change for etwiki fine (which was done yesterday). So tomorrow I will expect all th... [15:01:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: English Wikipedia got the "no ORES" version of the beta opt in - https://phabricator.wikimedia.org/T163790#3210060 (10jmatazzoni) [15:03:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: English Wikipedia got the "no ORES" version of the beta opt in - https://phabricator.wikimedia.org/T163790#3210074 (10jmatazzoni) 05Open>03Invalid [15:42:11] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3210283 (10Marostegui) s7 is done. db1094 needs the table reimported [16:10:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10MediaWiki-extensions-Nuke, 05Security: Flow Nuke integration is broken for non-existent users - https://phabricator.wikimedia.org/T162621#3210377 (10dpatrick) 05Open>03Resolved [16:14:43] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3210387 (10Marostegui) >>! In T130067#3210283, @Marostegui wrote: > s7 is done. db1094 needs the table reimported db1094 tables ha... [16:19:40] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3210420 (10jcrespo) As a note for @Addshore - the field should not be used or depend on it until tables are reimported on codfw, wh... [16:23:36] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3210425 (10Addshore) >>! In T130067#3210420, @jcrespo wrote: > As a note for @Addshore - the field should not be used or depend on... [16:36:03] mooeypoo, RoanKattouw, we also had a whole thing where the i18n people didn't want us to call main-namespace pages articles on all wikis (which is technically right, since e.g. they're 'entries' in Wiktionary). [16:36:16] We ended up making it 'page' then overriding it in WikimediaMessages only for Wikipedias. [17:16:42] 06Collaboration-Team-Triage, 10Notifications, 10OOjs-UI: Alignment issues in Echo popover - https://phabricator.wikimedia.org/T163802#3210674 (10Nirzar) [17:18:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters, 13Patch-For-Review: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3210689 (10Mooeypoo) >>! In T159942#3209134, @Pginer-WMF wrote: > @Mooeypoo, since t... [17:41:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 13Patch-For-Review: Create a preference for 'classic' ORES shading ... - https://phabricator.wikimedia.org/T163025#3210810 [17:48:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES, 06Revision-Scoring-As-A-Service: Let ERI order based on ORES scores - https://phabricator.wikimedia.org/T163040#3184283 (10jmatazzoni) Amir, it sounds like you'd like to have a reverted filter. Why not just request that we mark edits as Reve... [17:59:24] 06Collaboration-Team-Triage, 10Flow: Flow: It's impossible hide/delete the title of topic - https://phabricator.wikimedia.org/T163061#3210867 (10Catrope) >>! In T163061#3187345, @ValterVB wrote: > Why oversighter? The [[https://www.mediawiki.org/wiki/Help:RevisionDelete|RevDel]] normally is managed by administ... [18:00:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES, 06Revision-Scoring-As-A-Service: Let ERI order based on ORES scores - https://phabricator.wikimedia.org/T163040#3210868 (10jmatazzoni) So, we did a little more research, and it turns out that Rollback is marked as patrolled, but Undo is not.... [18:03:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10ORES, 06Revision-Scoring-As-A-Service: Let ERI order based on ORES scores - https://phabricator.wikimedia.org/T163040#3210871 (10jmatazzoni) As to enabling you to sort the results page, that would be amazing but would require redesign of the result... [18:08:38] 06Collaboration-Team-Triage, 10Notifications, 10OOjs-UI: Alignment issues in Echo popover - https://phabricator.wikimedia.org/T163802#3210896 (10Volker_E) Related to T147221. Patch needs to be updated at https://gerrit.wikimedia.org/r/#/c/317984/ [18:09:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 07Documentation: Technical documentation - https://phabricator.wikimedia.org/T163069#3185078 (10jmatazzoni) I would think it would be nice to include info about how to add a filter to the menu. I bet volunteers would do that. [18:10:25] 06Collaboration-Team-Triage, 10Flow: Flow: It's impossible hide/delete the title of topic - https://phabricator.wikimedia.org/T163061#3210902 (10Catrope) >>! In T163061#3210867, @Catrope wrote: >>>! In T163061#3187345, @ValterVB wrote: >> Why oversighter? The [[https://www.mediawiki.org/wiki/Help:RevisionDelet... [18:15:06] 06Collaboration-Team-Triage: [minor] Preferences page - zooming out makes tab dividing lines disappear - https://phabricator.wikimedia.org/T163264#3210910 (10Etonkovidova) [18:16:01] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [mobile-wmf.20] RC page - UI issues - https://phabricator.wikimedia.org/T163164#3210912 (10Catrope) The grey blobs that merge together are because that's what disabled `mw-ui-checkbox`es look like. (@Volker_E ? @Jdlrobson ?) They become un-disab... [18:19:44] 06Collaboration-Team-Triage, 10Thanks: No reference for Thanks - https://phabricator.wikimedia.org/T163299#3210924 (10Catrope) [18:19:50] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3210927 (10Catrope) [18:20:40] I just got a console error with something "(actually undefined)" ... is there a case of something only half undefined that I'm missing? [18:22:54] 06Collaboration-Team-Triage, 10Flow: Add a "user contributions" link on Topics pages attached to a Talk page - https://phabricator.wikimedia.org/T163419#3196754 (10Catrope) If you're on a topic page associated with a user talk page, the sidebar should contain the "user contributions" link (and other user-relev... [18:25:10] 06Collaboration-Team-Triage, 10MediaWiki-extensions-Nuke, 07Easy: [minor] Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found - https://phabricator.wikimedia.org/T163494#3210982 (10Catrope) [18:25:20] 06Collaboration-Team-Triage, 10MediaWiki-extensions-Nuke, 07Easy: Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found - https://phabricator.wikimedia.org/T163494#3210984 (10Catrope) [18:49:20] RoanKattouw: [WP@ZzQpEE4AAAF54rKUAAAAa] in betalabs cawiki [18:54:02] mooeypoo: Looks like it's from T145315 [18:54:02] T145315: Exception in module-execute in module mediawiki.Upload.BookletLayout - https://phabricator.wikimedia.org/T145315 [19:14:12] Aha, it's a bug in LoginNotify [19:20:16] Niharika: kaldari: T163816 [19:20:17] T163816: LoginNotify fatals on Special:Notifications in beta labs for certain users - https://phabricator.wikimedia.org/T163816 [19:20:33] Niharika: kaldari: Unbreak Now bug in LoginNotify [19:21:40] RoanKattouw: Thanks for reporting. [19:23:41] RoanKattouw, eton: Do you know the steps to reproduce this? [19:24:05] Niharika: For now it seems the only way to do it is visit Special:Notifications on cawiki with one of Elena's test accounts [19:24:10] (She just stepped out for lunch :/ ) [19:24:21] So I could look in the DB to see what those notifs look like [19:25:17] No worries. I can catch her when she's back. [19:27:31] Hmm, ET2 and ET13 have a bunch of login-fail-new notifications [19:27:52] But those look like they should be fine [19:28:58] I'm wondering what case that function doesn't catch. login-success notifications shouldn't be caused at all since those are off in the config. [19:29:04] Hmm, login-success isn't handled [19:29:10] But you're right, those should be off [19:29:44] Ahm, oops [19:29:50] catrope@deployment-tin:~$ mwscript eval.php cawiki [19:29:50] > var_dump($wgLoginNotifyEnableOnSuccess); [19:29:50] bool(true) [19:30:06] Gah. [19:30:17] * Niharika makes a patch [19:30:39] Yup [19:30:53] There is precisely one login-success notification in the whole cawiki database: [19:30:56] | Etonkovidova | 1556 | login-success | a:1:{s:11:"notifyAgent";b:1;} | [19:31:11] And OF COURSE it belongs to Elena [19:31:32] Elena must have gone to some drastic lengths to cause that. [19:31:45] She's very talented [19:32:09] :) [19:34:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests, 13Patch-For-Review: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3211353 (10Catrope) ...and it still failed. [19:34:53] RoanKattouw: That option is turned off in "DefaultUserOptions" in the hooks, ""echo-subscriptions-web-login-success": false" but I don't know if echo uses that anywhere. It's not used elsewhere in the extension. [19:35:10] It might be that she turned it on in her preferences [19:35:49] Ah, right. [19:36:42] https://ca.wikipedia.beta.wmflabs.org/wiki/Especial:Prefer%C3%A8ncies?uselang=en#mw-prefsection-echo --> Login from new computer [19:37:06] I understand that you might not have expected people to find obscure preferences you've introduced on obscure test wikis, but as I said, Elena is good [19:37:08] ;) [19:37:09] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3211358 (10David_Hedlund) @Catrope Thanks! [19:42:13] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3211361 (10David_Hedlund) Links to the revisions for Thanks are currently in * Special:... [19:47:28] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3211387 (10MGChecker) As I know dewiki, to deploy this there without community consensu... [20:19:29] 06Collaboration-Team-Triage, 10Notifications, 10UI-Standardization, 03UI-Standardization-Kanban: Alignment issues in Echo popover - https://phabricator.wikimedia.org/T163802#3211481 (10Volker_E) [20:58:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 07Design, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)): Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#1752583 (10Etonkovidova) Checked in betalabs - the gap is present for the anon warning for... [21:21:33] 06Collaboration-Team-Triage, 10Notifications: [minor] White outline is displayed around some elements - https://phabricator.wikimedia.org/T163266#3211858 (10Etonkovidova) Checked in betalabs - a white outline is not displayed. **QA Recommendation: Resolve** [21:23:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications: [minor] White outline is displayed around some elements - https://phabricator.wikimedia.org/T163266#3211866 (10Etonkovidova) p:05Triage>03Lowest [21:42:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'no-effect' states displayed as not muted - https://phabricator.wikimedia.org/T163843#3212039 (10Etonkovidova) [21:45:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: [betalabs-regression] RC filters - UI changes in display... - https://phabricator.wikimedia.org/T163522#3212118 [22:07:14] matt_flaschen: 15:06:28  (PS1) Catrope: Follow-up c047cd54d69ed: rename oresDamagingPref values back [extensions/ORES] - https://gerrit.wikimedia.org/r/350316 (https://phabricator.wikimedia.org/T160575) [22:09:29] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/346188/7/includes/Hooks.php says, soft == likelybad, but your change changes likelybad to hard (https://gerrit.wikimedia.org/r/#/c/350316/1/extension.json). Is that intentional? [22:10:19] Oh, whoops [22:10:23] Will look later [22:15:25] 06Collaboration-Team-Triage, 10Thanks, 13Patch-For-Review: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake, if configured to do so - https://phabricator.wikimedia.org/T51087#3212252 (10Mattflaschen-WMF) >>! In T51087#3211361, @David_Hedlund wrote: Can you clar... [22:26:44] RoanKattouw, fixed CR https://gerrit.wikimedia.org/r/#/c/350268/ [22:56:09] 06Collaboration-Team-Triage: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode - https://phabricator.wikimedia.org/T163749#3212364 (10Etonkovidova) [22:56:40] 06Collaboration-Team-Triage: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode - https://phabricator.wikimedia.org/T163749#3208166 (10Etonkovidova) [23:21:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3212437 (10Mooeypoo) >>! In T151994#3205574, @Pginer-WMF wrote: > I'm not sure I und... [23:26:14] 06Collaboration-Team-Triage: [wmf.21-regression] Posting a reply to Flow topics with multiple posts redirects users to no-js mode - https://phabricator.wikimedia.org/T163749#3208166 (10Catrope) Caused by a JS error: `Cannot read property 'append' of undefined` in `mw.flow.ui.ReplyWidget.prototype.intializeEditor... [23:44:56] (03PS1) 10Catrope: Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350331 (https://phabricator.wikimedia.org/T163749) [23:45:02] mooeypoo: ---^^ [23:46:05] (03CR) 10Mooeypoo: [C: 032] Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350331 (https://phabricator.wikimedia.org/T163749) (owner: 10Catrope) [23:55:54] matt_flaschen: Good catch on the hard vs soft thing. I just undid Stephane's change to that setting, I didn't realize that he had changed what the default value meant [23:56:35] Setting the default to 'soft' makes sense though because that's what it is on every single production wiki except wikidata [23:56:50] (03Merged) 10jenkins-bot: Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350331 (https://phabricator.wikimedia.org/T163749) (owner: 10Catrope) [23:57:04] (03CR) 10jenkins-bot: Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350331 (https://phabricator.wikimedia.org/T163749) (owner: 10Catrope) [23:57:15] (03PS1) 10Catrope: Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/350334 (https://phabricator.wikimedia.org/T163749) [23:59:10] (03CR) 10Catrope: "Actually a follow-up to 5a0ce3d merged last week, not a commit from 2015, sorry." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350331 (https://phabricator.wikimedia.org/T163749) (owner: 10Catrope) [23:59:54] (03CR) 10Catrope: [C: 032] Follow-up c1beac48: fix JS error when clicking reply link [extensions/Flow] (wmf/1.29.0-wmf.21) - 10https://gerrit.wikimedia.org/r/350334 (https://phabricator.wikimedia.org/T163749) (owner: 10Catrope)