[08:30:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Chinese-Sites, and 3 others: Announce and follow up with communities group 3 about the New Filters for Recent changes Beta... - https://phabricator.wikimedia.org/T158333#3204990 [08:35:42] 06Collaboration-Team-Triage, 10Flow: Validate which Flow moves are allowed? - https://phabricator.wikimedia.org/T96304#3205009 (10Trizek-WMF) [08:35:44] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for bureaucrats?, global renamers? stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#3205010 (10Trizek-WMF) [08:56:17] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3205160 (10Trizek-WMF) [09:05:59] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3205185 (10Trizek-WMF) What is the correct status for this task? What will be the impact of deploying ORES by default on Eng... [09:06:23] ^ matt_flaschen [09:54:45] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3205279 (10Ladsgroup) >>! In T163337#3205185, @Trizek-WMF wrote: > What is the correct status for this task? What will be th... [10:54:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Integrate topOnly=1, to show only last edits done on a page - https://phabricator.wikimedia.org/T163561#3201674 (10Pginer-WMF) As part of T159444, I noticed this kind of functionality on "user contributions" page. As... [11:35:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3205574 (10Pginer-WMF) >>! In T151994#3201736, @jmatazzoni wrote: > @Mooeypoo and @P... [11:46:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3205593 (10Pginer-WMF) >>! In T144457#3201835, @SBisson wrote: > I can... [12:23:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3205703 (10Pginer-WMF) >>! In T147054#3144318, @Trizek-WMF wrote: >>>! In T14... [12:30:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3205727 (10Trizek-WMF) Thank you :) [12:59:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests, 13Patch-For-Review: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3205807 (10SBisson) >>! In T161041#3203227, @Krink... [13:04:36] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 07User-notice-collaboration: Make ORES prediction disappear when the edit is revi... - https://phabricator.wikimedia.org/T161888#3205836 [14:02:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3206045 (10Trizek-WMF) https://meta.wikimedia.org/wiki/Help:Recent_changes up... [14:43:45] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3206224 (10Marostegui) We have done the first test deploying this directly on the master in eqiad. What we have done: - Remove rep... [14:55:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3023193 (10matej_suchanek) https://cs.wikipedia.org/wiki/Speciální:Poslední_změny (cswiki RC) down for me... [15:21:58] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Special:RecentChanges in wikidata/cs/etwiki displays error due to config screwup - https://phabricator.wikimedia.org/T163696#3206417 (10Jdforrester-WMF) a:03Mattflaschen-WMF [15:22:27] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Special:RecentChanges in wikidata/cs/etwiki displays error due to config screwup - https://phabricator.wikimedia.org/T163696#3206338 (10Jdforrester-WMF) Should be fixed by https://gerrit.wikime... [15:32:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Special:RecentChanges in wikidata/cs/etwiki displays error due to config screwup - https://phabricator.wikimedia.org/T163696#3206468 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Dereckson [15:46:47] RoanKattouw, do you know why I might be seeing "Highlight likely problem edits with colors and an "r" for "needs review"" on Farsi Wikipedia even though the beta feature is enabled? Looking now. [15:47:50] matt_flaschen: perhaps the config overrides, rather than adding to, $wgHiddenPrefs? [15:59:22] RoanKattouw, we don't just set wgHiddenPrefs to a fixed list anywhere in mediawiki-config. [16:00:01] RoanKattouw, there are multiple "$wgHiddenPrefs[] = ", plus one "$wgHiddenPrefs = array_diff ( $wgHiddenPrefs ", both of which should be fine. [16:00:28] Hmm [16:00:37] You could use eval.php to check what the value of $wgHiddenPrefs is [16:02:41] RoanKattouw, I did, but not inside the hook, so as expected they weren't there. [16:03:58] RoanKattouw, I didn't give this part a lot of thought when reviewing (partly because it was already doing the same thing for a different pref), but are we sure it's allowed to change $wgHiddenPrefs dynamically? [16:12:07] T163712 [16:12:08] T163712: " Highlight likely problem edits with colors and an "r" for "needs review"" shows up even with RC Filters beta feature enabled - https://phabricator.wikimedia.org/T163712 [17:03:24] matt_flaschen: Sorry, was in the QCI meeting [17:03:31] It was already doing that for another pref... [17:03:57] Also does that bug happen on all wikis, not just Farsi? [17:05:27] RoanKattouw, I think so. I saw it on English too. [17:08:44] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3207030 (10Trizek-WMF) @matej_suchanek, it works for me. Maybe a gadget or script conflict: what about th... [17:09:49] matt_flaschen: But Joe did NOT see it... [17:10:04] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3207033 (10matej_suchanek) Already fixed in T163696, sorry for having bug reports spread. [17:11:26] Yeah..., it might be caching/race condition. [17:11:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3207047 (10Trizek-WMF) >>! In T158004#3207033, @matej_suchanek wrote: > Already fixed in T163696, sorry f... [17:26:09] RoanKattouw, darn, I just realized I forgot to scap. That doesn't really explain the bugs, though. [17:26:27] In theory that should only explain missing i18n [17:26:41] But it would be good to do I suppose [17:29:40] greg-g, can I do a scap at 11:30? I don't currently have anything else to deploy (but we might by then), but I realized I forgot to do a scap (though somehow to seems to have worked anyway). [17:29:57] I'm now starting to think that 1) maybe there's caching in the User object and 2) maybe some of the code paths that ask about preference values run before the $wgHiddenPrefs[] thing happens. But I'll investigate after the meeting [17:33:36] Aha: the GetPreferences hook appears to only run on the preferences page, so the preferences aren't actually hidden otherwise [17:34:02] Simple patch that should address some symptoms incoming [17:42:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Integrate topOnly=1, to show only last edits done on a page - https://phabricator.wikimedia.org/T163561#3207180 (10Trizek-WMF) While seeing your prototype demo, I was thinking that this option should be in the "Show... [17:43:39] matt_flaschen: https://gerrit.wikimedia.org/r/349987 [17:44:12] Doesn't address the bug as reported, exactly, but does address a related bug [18:36:01] RoanKattouw, it doesn't work for me even on the preferences page. I think you're aware of that, just double-checking. [18:45:35] greg-g, updated request. Can I get a window for scap at 12:15 PM, now including https://gerrit.wikimedia.org/r/#/c/349987/ ? [19:02:06] matt_flaschen: Yeah I know that, I just haven't been able to repro that yet [19:02:18] It worked for me locally and for Elena in beta [19:03:32] WFM on enwiki too [19:03:39] Checking fawiki now [19:04:08] WFM on fawiki [19:04:26] matt_flaschen: On which wiki and with which account did you reproduce this? I can't get it to break for me [19:06:44] matt_flaschen: sure [19:19:16] RoanKattouw, enwiki and Mattflaschen-WMF for one. [19:21:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3207540 (10jmatazzoni) [19:22:19] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#2600312 (10jmatazzoni) [19:24:03] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_timestamp to the watchlist table - https://phabricator.wikimedia.org/T125991#2002327 (10jcrespo) How stable is this? Stable enough to deploy the schema on WMF before merging, or are there people that doesn't agree th... [20:00:34] RoanKattouw, I deployed your latest patch, but with the RCFilters beta feature off, I see the r but it's not highlighted. [20:00:49] Hah that's weird [20:00:56] Because they're supposed to be controlled by the same code! [20:01:09] isHighlighingEnabled is just return isDamagingFlagEnabled [20:01:47] Yeah [20:08:26] RoanKattouw, it's only non-highlighted on grouped RC (but even if that particular row is not grouped). I thought that bug was only on watchlist [20:08:51] Weird [20:09:06] But it works correctly in non-grouped RC? [20:09:26] If so then I think this is probably a separate bug (and probably unfiled as yet) [20:09:50] Also is the "r"/highlight preference still failing to disappear for yo? [20:09:53] *you [20:09:55] highlight in enhanced rc: https://gerrit.wikimedia.org/r/#/c/333493/ [20:10:11] Ooh nice [20:10:21] don't know if it's supposed to work at all atm [20:11:04] RoanKattouw, T155903 . [20:11:04] T155903: Some bad changes are not highlighted in enhanced recent changes or watchlist - https://phabricator.wikimedia.org/T155903 [20:11:18] Filed a duplicate of that a while back, but that's apparently the original. [20:11:51] So the deploy worked. [20:12:01] (For what the patch was intended for) [20:17:32] RoanKattouw, but yeah, the r/highlight (colors and an "r") is still there when RCFilters beta feature is enabled. [20:22:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 07User-notice-collaboration: Make ORES prediction disappear when the edit is revi... - https://phabricator.wikimedia.org/T161888#3207801 [20:31:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3207827 (10Etonkovidova) Check... [20:35:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: Blue dot gets de-attached on scrolling - https://phabricator.wikimedia.org/T162971#3207832 (10Etonkovidova... [20:42:08] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: [betalabs-regression] RC filters - UI changes in display... - https://phabricator.wikimedia.org/T163522#3207860 [20:46:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/350036 (owner: 10L10n-bot) [20:47:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/350041 (owner: 10L10n-bot) [20:59:39] RoanKattouw, stephanebisson matt_flaschen Speaking of highlights - are we going to highlight namespaces? [20:59:44] and tags and users, for that matter [21:00:15] I'm working on it as if we aren't, but the UI is ready, I think? The only question is (a) how to represent in the URL and (b) can we do it in the backend. [21:00:18] and is it worth it [21:05:55] mooeypoo, playing devil's advocate on all of them, they're all written directly out in text. [21:06:31] If we were going to do it, it would be more useful to do it as groups (e.g. all talk namespaces, or a particular group of users) [21:06:43] But we can easily do it too. [21:06:55] I'm taking a break, will be available on Hangouts and back on later. [21:07:34] Easily do a class for each (not the group thing) [21:08:14] I dunno... if you allow for multiple namespaces, I can see having to highlight some and not others [21:08:28] But yeah, we should discuss this [21:09:37] I guess users can do the group thing just by choosing the same color repeatedly. [21:14:26] We could do groups, but then it would require a UI representation [21:14:32] so far we represent highlighting per-item [21:14:42] we need to see how that would look like to do per-type or something like that [21:19:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 07Design, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)): Touching fields with rounded corners - https://phabricator.wikimedia.org/T116573#3207997 (10Jdforrester-WMF) [22:02:33] 06Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, 10Parsoid, and 2 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3208159 (10ssastry) p:05Triage>03Normal [22:03:10] RoanKattouw, btw, does everyone (including extension developers) know that new namespaces are supposed to be even, and their talk pages odd? [22:03:20] Just wondering if it's a convention by luck or by actual convention [22:03:27] didn't see it actually written anywhere [23:15:22] mooey|lunch: I think so [23:15:36] mooey|lunch: There are docs about that somewhere, and it's been like that since The Dawn Of Time (TM) [23:46:59] RoanKattouw, yeah I'm just saying since our entire strategy depends on that fact [23:47:19] I mean, worse case, someone will have their custom namespaces showing slightly off in the "grouping" [23:47:21] not that bad