[00:01:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: dewiki - GuidedTour for no ORES models displays the title as cutoff - https://phabricator.wikimedia.org/T163245#3200323 (10Mooeypoo) I @Volker_E'ed the CSS, except I used `600px` rather than `60... [00:01:37] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3200325 (10jmatazzoni) I like this idea. I need to hear a clear statement of the use case. What is the user trying to do? My guess is... [00:01:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3200326 (10jmatazzoni) [00:03:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3078657 (10jmatazzoni) [00:04:19] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200332 (10kaldari) I like it. The extra context helps me know if the notification needs attention or not. For example, I can probably ign... [00:07:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3200337 (10Catrope) Without the RCFilters beta feature enabled, you'd see two separate filters, b... [00:08:14] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200338 (10Catrope) And a simulation of what it would look like with the current (long) text for the LoginNotify notification: {F7674622} [00:08:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Invite users to opt in to the RC Filters beta from the RC page, and educate them about its features - https://phabricator.wikimedia.org/T144457#3200339 (10jmatazzoni) [00:12:10] RoanKattouw: I'm curious, did you create https://phabricator.wikimedia.org/F7674622 by editing the DOM? [00:12:20] Yes [00:12:23] That's why the icon is wrong :) [00:12:35] Ah, yeah. [00:13:34] Yeah I was too lazy to figure out how to trigger one, or if this code was even in production yet, etc [00:14:14] The image is also highlighted in the screenshot (which is how you can tell my inspector was open), and that was because I was trying to change it to the correct one, but that one isn't in the standard Echo set, so I gave up [00:15:44] You were going to change that image so it would show up correctly in a screenshot that only needs to show the text/length of text. That's an impressive amount of attention to detail. :P [00:16:20] mooeypoo: the background of conflicting filters capsule is not red anymore? I see it beta Or it's regression? [00:19:22] it should be red... [00:19:24] Niharika: I mean, it seemed easy :D [00:19:25] i didn't change anything [00:24:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10BetaFeatures, 10MediaWiki-User-preferences, 13Patch-For-Review: 'Beta' link redirects to the section on 'Preferences' where the most recent changes were made - https://phabricator.wikimedia.org/T162938#3200357 (10Mooeypoo) a:03Mooeypoo [00:28:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Replace "Namespace" widget in RCFilters with a user-friendly OOUI version - https://phabricator.wikimedia.org/T163521#3200366 (10Mooeypoo) [00:28:28] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Replace "Namespace" widget in RCFilters with a user-friendly OOUI version - https://phabricator.wikimedia.org/T163521#3200380 (10Mooeypoo) [00:28:30] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3200379 (10Mooeypoo) [00:44:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters - https://phabricator.wikimedia.org/T163522#3200391 (10Etonkovidova) [01:24:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3200487 (10Zache) @Catrope ''(it sounds to me like all reviewed edits are also patrolled, but som... [02:08:16] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters - https://phabricator.wikimedia.org/T163522#3200530 (10Mooeypoo) We didn't change anything in the styling, but I thi... [02:44:54] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3200560 (10Krinkle) While it's possible the underlying cause for this bug is specific to ORES (T163337#3196493 mentions a fe... [02:49:12] 06Collaboration-Team-Triage, 10Flow: FOUC: Content is narrow first and then reflows to wide - https://phabricator.wikimedia.org/T163528#3200564 (10Krinkle) [02:52:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#2834562 (10Mooeypoo) I know this is still in design, but just a couple of quick questions to consider -- The Pet... [04:29:12] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3200617 (10Joe) >>! In T163337#3200560, @Krinkle wrote: > While it's possible the underlying cause for this bug is specific... [05:45:20] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#3200663 (10Nikerabbit) [08:38:46] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3200903 (10jcrespo) [10:27:56] (03PS1) 10Esanders: MetionInspector: Use surface fragment instead of building transction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349403 [11:04:57] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Chinese-Sites, and 3 others: Announce and follow up with communities group 3 about the New Filters for Recent changes Beta... - https://phabricator.wikimedia.org/T158333#3201086 [11:25:54] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3201110 (10Pginer-WMF) >>! In T151994#3200581, @Mooeypoo wrote: > I know this is still in design, but just a coup... [12:27:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 07Chinese-Sites, and 3 others: Announce and follow up with communities group 3 about the New Filters for Recent changes Beta... - https://phabricator.wikimedia.org/T158333#3201221 [13:03:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 4 about the New Filters for... - https://phabricator.wikimedia.org/T158335#3201333 [14:08:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: [minor] RC filters - bullet points displayed blank if 'H... - https://phabricator.wikimedia.org/T163387#3201475 [14:16:24] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate result size selection in the new filters for edit review - https://phabricator.wikimedia.org/T162786#3201481 (10Pginer-WMF) >>! In T162786#3175937, @Trizek-WMF wrote: > Is it on this ticket that you will explore t... [14:55:20] (03CR) 10Sbisson: [C: 031] "LGTM and works well but I would prefer the Core patch to be merged before this one." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/330587 (https://phabricator.wikimedia.org/T154263) (owner: 10Cen.temp) [15:40:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate result size selection in the new filters for edit review - https://phabricator.wikimedia.org/T162786#3201658 (10jmatazzoni) @Trizek, I love that option. Can you write up a ticket to make this a new filter option?... [15:41:24] I've lost the thread of this discussion. Let's please take it to the ticket. [15:45:28] jmatazzoni_: which thread? [17:04:02] RoanKattouw, mooeypoo: standup? [17:16:49] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3201932 (10Whatamidoing-WMF) Related: {T158004} is scheduled for 14:00 UTC this Monday, which will deploy Ores (by default/... [17:52:39] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow: New editor switcher stays enabled during save - https://phabricator.wikimedia.org/T161552#3202082 (10SBisson) a:03SBisson [18:00:08] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters - https://phabricator.wikimedia.org/T163522#3202097 (10Mooeypoo) I actually misunderstood; by "no-effect" filters, I... [18:19:03] matt_flaschen: i just happened to run into https://phabricator.wikimedia.org/tag/ladies-that-foss-mediawiki/ – that should probably be a "tag" project (like e.g. https://phabricator.wikimedia.org/tag/easy/), rather than a "component" project? https://www.mediawiki.org/wiki/Phabricator/Project_management#Types_of_Projects [18:20:03] (03PS2) 10Catrope: MentionInspector: Use surface fragment instead of building transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349403 (owner: 10Esanders) [18:20:44] (03CR) 10Catrope: [C: 032] MentionInspector: Use surface fragment instead of building transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349403 (owner: 10Esanders) [18:30:06] (03Merged) 10jenkins-bot: MentionInspector: Use surface fragment instead of building transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349403 (owner: 10Esanders) [18:33:48] 06Collaboration-Team-Triage, 10Flow: FOUC: Content is narrow first and then reflows to wide - https://phabricator.wikimedia.org/T163528#3202175 (10Catrope) [18:33:51] 06Collaboration-Team-Triage, 10Flow, 07Easy, 07JavaScript: On page-load, a flash of expanded Flow Board Description is seen before it collapses - https://phabricator.wikimedia.org/T102648#3202178 (10Catrope) [18:35:50] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 5 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3202184 (10Catrope) >>! In T163337#3201932, @Whatamidoing-WMF wrote: > Related: {T158004} is scheduled for 14:00 UTC this M... [18:35:55] (03CR) 10jenkins-bot: MentionInspector: Use surface fragment instead of building transaction [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349403 (owner: 10Esanders) [18:46:16] matt_flaschen: What are your thoughts about including https://gerrit.wikimedia.org/r/#/c/349354/ in Monday's deployment window? [18:46:42] One the one hand, it would reduce disruption for people who have the ORES beta feature enabled and don't choose to enable the RCFilters beta feature, which will be like >10k people [18:46:51] On the other hand, it'll require a scap [18:47:37] FWIW, I feel like it's great that it'll get out. I don't think it's a huge rush. [19:03:12] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: [betalabs-regression] RC filters - UI changes in displaying conflict states and 'no-effect' filters - https://phabricator.wikimedia.org/T163522#3202268 (10Volker_E) >>! In T163522#3202214, @Mooe... [19:11:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: For Conflict States, short-circuit the fruitless searche... - https://phabricator.wikimedia.org/T160220#3202294 [19:26:58] RoanKattouw, yep, I'll add it. [19:27:06] RoanKattouw, that means we don't need the line: [19:27:08] mwscript initUserPreference.php enwiki -s ores-enabled -t oresHighlight [19:27:09] right? [19:27:37] Anyone seeing weird issues where the left pane of Gerrit disappears? [19:27:52] It flashes for a second, then goes white. [19:28:22] No, we do [19:28:34] Yes, that happens sometimes, I usually just refresh the tab [19:29:02] The new(ish) thing that Gerrit switched to a while (year+?) ago for rendering diffs is terrible [19:29:22] I was reviewing a patch recently and it wouldn't let me add comments below line ~600, every time I tried to focus the comment box it'd scroll up and blur the box [19:29:30] So I had to open the box, disable JS, write in it, reenable JS, submit [19:30:47] DOM editing to add text to the box sounds easier. :P [19:31:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements: [minor] RC filters - during reloading page for conflicting filter states "No changes during the given period match these criteria" is displayed - https://phabricator.wikimedia.org/T163577#3202333 (10Etonkovidova) [19:32:14] RoanKattouw, okay, so: [19:32:32] 1. If it's a beta feature, it should always show both flag and highlighting [19:33:15] 2. Otherwise, both are based on ores-damaging-flag-rc for RC, and oresHighlight for non-RC [19:33:19] Yes [19:33:57] Which is a bit weird and imperfect but since this is like the fifth time it's changed, I'll take it [19:36:00] RoanKattouw, the only weird thing I see is that there are no defaults for either ores-damaging-flag-rc or oresHighlight. [19:36:23] RoanKattouw, and ores-damaging-flag-rc can be hidden which means it's forced to default. [19:36:46] It seems to function as if the default is false [19:36:54] But you make a good point, that should be explicit [19:37:43] RoanKattouw, okay, I'll upload. [19:40:12] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/349534/ . [19:43:17] +2ed [19:43:23] MatmaRex, I think I made it Component because it's an event, one of the options listed. [19:45:09] matt_flaschen: oh, hm. okay! :) i just thought it was overlooked [19:54:54] RoanKattouw, can you review https://gerrit.wikimedia.org/r/#/c/349349/ ? [20:07:19] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 06Stewards-and-global-tools (Temporary-UserRights): Notify users when their user group membership is about to expire, or has expired - https://phabricator.wikimedia.org/T153817#2892002 (10MaxSem) I think a maintenance script should be the way... [20:37:18] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10BetaFeatures, 10MediaWiki-User-preferences, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), and 2 others: 'Beta' link redirects to the section on 'Preferences' where the most recent cha... - https://phabricator.wikimedia.org/T162938#3202621 [20:46:48] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 05MW-1.29-release-notes, 13Patch-For-Review: [minor] RC filters - bullet points displayed blank if 'H... - https://phabricator.wikimedia.org/T163387#3202696 [21:01:55] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#3202720 (10Etonkovidova) Checked in betal... [21:05:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349568 (owner: 10L10n-bot) [22:26:09] (03PS1) 10Hashar: build: add grunt-contrib-jshint [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/349713 [22:43:10] RoanKattouw: re https://phabricator.wikimedia.org/T161888 -- hmm, the title is about FlaggedRevs review and ORES 'r', and the fix is about patrolling... [22:43:27] Yeah [22:43:33] There was already a link between patrolling and the 'r' [22:43:56] RoanKattouw: what about 'r' and 'pending change' ? [22:43:58] And a link between FlaggedRevs and patrolling, but not always, so we strengthened that link [22:44:11] So now it's FlaggedRevs <-> patrolling <-> 'r' [22:44:27] RoanKattouw: just as I thought :) - yes [22:56:55] Sorry I'm hogging all the CI time, BTW. [22:57:02] I blame Antoine.