[00:10:15] Also since it's got nothing better to do, my brain came up with "‪I noted a note in a note on a Note." [00:20:23] re: no ORES filters on betalabs, very likely caused by my patch [00:21:21] the wiki model configured there (testwiki) returns no stats so no levels can be configured [00:21:46] we would need to override the config with numerical values instead of stats [00:44:06] 10Collab-Notifications-Page, 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 07Accessibility, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review: Special:Notifications doesn't use actual headers for headers in its lis... - https://phabricator.wikimedia.org/T149955#2770078 [03:19:17] Aha, good catch [04:01:11] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3196493 (10Krinkle) >>! In T163337#3194686, @Krinkle wrote: >>>! In T163337#3194508, @Anomie wrote: >> The earliest recent e... [07:07:15] (03PS2) 10Gergő Tisza: Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 [07:08:26] (03PS2) 10Gergő Tisza: Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 [07:12:34] (03CR) 10jerkins-bot: [V: 04-1] Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (owner: 10Gergő Tisza) [07:21:48] (03CR) 10jerkins-bot: [V: 04-1] Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (owner: 10Gergő Tisza) [07:24:28] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3196624 (10Pginer-WMF) [08:04:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Design: Design ways to facilitate repetitive use for the new Recent Changes filters - https://phabricator.wikimedia.org/T151994#3196675 (10Pginer-WMF) [08:31:33] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice-collaboration: Ask communities which have allowed Flow trials with manual enabling to switch to Bet... - https://phabricator.wikimedia.org/T143470#3196727 [08:31:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 13Patch-For-Review: Activate Flow as a Beta feature on French Wikiversity - https://phabricator.wikimedia.org/T162022#3196726 (10Trizek-WMF) [08:31:38] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 10Wikimedia-Site-requests, 05Goal: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#3196725 (10Trizek-WMF) [08:40:45] 06Collaboration-Team-Triage, 10Flow: Add a "user contributions" link on Topics pages attached to a Talk page - https://phabricator.wikimedia.org/T163419#3196754 (10Trizek-WMF) [08:41:57] 06Collaboration-Team-Triage, 10Flow: Flow's usage of the page name magic words is different from wikitext talk pages - https://phabricator.wikimedia.org/T109373#3196771 (10Trizek-WMF) [[https://www.wikidata.org/w/index.php?title=Wikidata:Project_chat&oldid=476364434#How_do_we_know_the_page_to_which_a_flow_topi... [08:48:00] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 07User-notice-collaboration: Make ORES prediction disappear when the edit is revi... - https://phabricator.wikimedia.org/T161888#3196813 [08:49:07] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 3 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3196814 (10Trizek-WMF) [08:53:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 4 about the New Filters for... - https://phabricator.wikimedia.org/T158335#3196853 [08:55:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 3 about the New Filters for... - https://phabricator.wikimedia.org/T158333#3196858 [09:11:57] 06Collaboration-Team-Triage, 10Flow, 06Support-and-Safety: Give the right to bureaucrats to move Flow boards - https://phabricator.wikimedia.org/T163424#3196892 (10Trizek-WMF) [09:21:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Access the new changes that happened after the user started filtering contributions - https://phabricator.wikimedia.org/T163426#3196931 (10Pginer-WMF) [09:22:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3170940 (10Pginer-WMF) [09:22:43] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Access the new changes that happened after the user started filtering contributions in the new filters for edit review - https://phabricator.wikimedia.org/T163426#3196931 (10Pginer-WMF) [09:43:22] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, and 2 others: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3197011 (10Trizek-WM... [10:07:29] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic, 07Tracking: Provide navigation controls to move though the results of the new filters for edit review - https://phabricator.wikimedia.org/T163429#3197072 (10Pginer-WMF) [10:21:13] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Provide navigation controls to move though the results of the new filters for edit review - https://phabricator.wikimedia.org/T163429#3197105 (10Pginer-WMF) [10:21:36] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3197107 (10Pginer-WMF) [10:40:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make filter panel header sticky on new filters for edit review - https://phabricator.wikimedia.org/T163431#3197146 (10Pginer-WMF) [10:40:22] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3170940 (10Pginer-WMF) [11:13:39] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Support filtering for categories in the new filters for edit review - https://phabricator.wikimedia.org/T163433#3197209 (10Pginer-WMF) [11:14:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3170940 (10Pginer-WMF) [11:17:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), 13Patch-For-Review, 07User-notice-collaboration: Add owner title variable for Flow AbuseFilter - https://phabricator.wikimedia.org/T161774#3197234 (10SBisson) a:03Mattflaschen-WMF [11:21:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3197237 (10Pginer-WMF) [11:22:47] (03PS3) 10Gergő Tisza: Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 [11:25:04] (03PS3) 10Gergő Tisza: Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 [11:32:28] (03CR) 10jerkins-bot: [V: 04-1] Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (owner: 10Gergő Tisza) [11:35:31] (03PS4) 10Gergő Tisza: Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) [11:35:49] (03PS4) 10Gergő Tisza: Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (https://phabricator.wikimedia.org/T163434) [11:36:01] (03CR) 10jerkins-bot: [V: 04-1] Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [11:50:26] (03CR) 10jerkins-bot: [V: 04-1] Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [13:11:09] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service: Fix i18n documentation - https://phabricator.wikimedia.org/T161452#3197511 (10Tgr) 05Open>03Resolved a:03Tgr Looks like this was fixed at some point. [13:12:05] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 3 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3177639 (10Johan) Do you know when this will be deployed? (... [13:16:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking, 07User-notice: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#2600352 (10Johan) @Trizek-WMF: For Tech News purposes, is th... [13:24:07] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3197545 (10Pginer-WMF) [13:24:23] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3197549 (10Addshore) [13:24:29] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 2 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3087424 (10Addshore) 05Open>03declined [13:25:08] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 2 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3087424 (10Addshore) Looks like we are not going to do this, as it will not be needed as wl_id should be added d... [13:26:07] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 2 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3197568 (10Marostegui) I still think it would be nice to have that feature there if needed [13:27:23] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3197573 (10Addshore) [13:27:28] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 2 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3197571 (10Addshore) 05declined>03Open >>! In T160062#3197568, @Marostegui wrote: > I still think it would b... [13:29:58] (03CR) 10Gergő Tisza: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [13:32:02] (03CR) 10Gergő Tisza: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [13:40:06] 10Collab-Notifications-Page, 06Collaboration-Team-Triage, 10Wikimedia-Hackathon-2017: Make it easy to filter notifications by type - https://phabricator.wikimedia.org/T162930#3197605 (10Pginer-WMF) Filtering by type makes perfect sense. This was among the ideas we considered to help users to deal with a high... [13:48:50] (03CR) 10jerkins-bot: [V: 04-1] Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [14:03:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Tracking: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#3197667 (10Trizek-WMF) >>! In T144458#3197520, @Johan wrote: > @Trizek-WMF: F... [14:19:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 06Revision-Scoring-As-A-Service: ORES highlights are completely disabled even when ERI is disabled - https://phabricator.wikimedia.org/T163025#3183746 (10Halfak) I don't think it's OK that we take away functionality from ORES users unless they opt in t... [14:19:42] 06Collaboration-Team-Triage, 10Flow, 06Community-Tech, 10Tool-Labs-tools-Xtools: Add Flow contributions to Xtools - https://phabricator.wikimedia.org/T136950#3197711 (10Matthewrbowker) a:05Matthewrbowker>03Samwilson [14:50:48] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3197822 (10Anomie) >>! In T163337#3196493, @Krinkle wrote: > It would help to know whether any revisions from April 13 to Ap... [15:27:12] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3193929 (10jcrespo) Just a bit of a side comment- I do not disagree with the uniqueness, that should be deployed- I only ask... [15:27:24] stephanebisson: Re https://phabricator.wikimedia.org/T161888 - the ORES based filters are missing from cawiki betalabs. RoanKattouw mentioned yesterday that it's because of the fix in the ticket ... [15:27:59] stephanebisson: but I do not see any comments on the ticket -- a different cause? [15:39:15] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3198009 (10Ladsgroup) >>! In T163337#3197822, @Anomie wrote: > It looks like many of the duplicate rows have been cleaned up... [15:39:27] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3198010 (10Ladsgroup) p:05Unbreak!>03High [15:40:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3198017 (10Zache) Fiwiki uses Flagged revs and there is also patrolling for patrol flag support in API. Setup is that the autopatroller... [15:42:24] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3198023 (10Anomie) >>! In T163337#3197960, @jcrespo wrote: > Also, if only ores are duplicated but not the "real" revision o... [15:45:06] etonkovidova: that's not related with that ticket [15:45:18] stephanebisson: ok then [15:45:42] etonkovidova: probably related to T162760 [15:45:43] T162760: Make presence and targets of ORES filters configurable - https://phabricator.wikimedia.org/T162760 [15:47:23] stephanebisson: reading T162760 - interesting :) [15:48:09] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3198056 (10jcrespo) We can try, if not group by, something like DISTINCT can at times short-cut execution and be even faster... [15:48:56] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3198060 (10Zache) Flagged revs [[ https://www.mediawiki.org/wiki/Extension:FlaggedRevs#Notes_2 | documentation ]]: "$wgUseRCPatrol is e... [15:51:25] etonkovidova: is ORES available on cawiki? The stats page doesn't seem to work (https://ores.wikimedia.org/scores/cawiki?model_info=test_stats) [15:52:09] stephanebisson: I was talking about betalabs cawiki [15:52:33] for the record, we do not have anyone who has requested support for cawiki yet [15:53:12] halfak: Thanks for the info. [15:53:52] etonkovidova: Since no stats are produced for cawiki, the filters thresholds can't be configured and won't show up in the list. [15:54:00] If anyone knows someone from cawiki who would like to help us build language support for Catalan, please direct them for me. [15:54:03] :) [15:54:13] or https://meta.wikimedia.org/wiki/Objective_Revision_Evaluation_Service/Get_support [15:55:10] stephanebisson: so what you are saying is - in beta we are matching present production state of the same wiki? [15:55:25] stephanebisson: despite the fact that cawiki betlabs has ores tables? [15:57:02] stephanebisson: and the fact that enwiki betalabs does have ORES filters? [15:57:25] etonkovidova: We were not really doing that before. I think it was enabled everywhere in betalabs. But with the way we auto-configure the thresholds now, yes, if no stats are available for a wiki, we can't show the filters. [15:57:39] etonkovidova: There IS stats for enwiki. [15:58:07] stephanebisson: well, it makes sense ... [15:58:35] 10MediaWiki-Watchlist, 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10ORES, and 4 others: Watchlist entries duplicated several times - https://phabricator.wikimedia.org/T163337#3198103 (10Ladsgroup) Gerrit-bot doesn't make comment when I make a patch (T161525) - [mediawiki/extensions/ORES] Use DISTI... [16:15:35] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#2008070 (10Trizek-WMF) See also {T163424}. [16:29:13] (03PS1) 10Sbisson: MentionStatus: prefer failure-type [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349251 (https://phabricator.wikimedia.org/T144614) [16:29:19] (03PS8) 10Sbisson: Add mention failure notifications to Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308555 (https://phabricator.wikimedia.org/T144614) (owner: 10Addshore) [16:47:48] (03CR) 10jerkins-bot: [V: 04-1] MentionStatus: prefer failure-type [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349251 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [17:03:54] (03CR) 10Mooeypoo: [C: 032] "This works and, more importantly, it fixes the CI failures that we have in Echo right now that fail every commit." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348006 (https://phabricator.wikimedia.org/T161941) (owner: 10Bartosz Dziewoński) [17:10:40] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Browser-Support-Internet-Explorer: Rc filters - IE11 filters display issues - https://phabricator.wikimedia.org/T162957#3181448 (10Catrope) [17:14:49] (03Merged) 10jenkins-bot: Fix browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348006 (https://phabricator.wikimedia.org/T161941) (owner: 10Bartosz Dziewoński) [17:15:56] (03CR) 10jenkins-bot: Fix browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/348006 (https://phabricator.wikimedia.org/T161941) (owner: 10Bartosz Dziewoński) [18:07:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Unchecking category leads to more results on plwiki - https://phabricator.wikimedia.org/T161756#3198881 (10Catrope) a:05Catrope>03None [18:43:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RC filters - 'Highlight results' button is still active even with 'No filters found' - https://phabricator.wikimedia.org/T163275#3199090 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni I... [18:48:07] matt_flaschen: regarding Special:Nuke - in betalabs (at least) it's not possible to get matching pages using SQL wildcards. Is it known or it's only in beta, or I am using incorrect pattern, like Mavetuna74% ? :) [18:53:52] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service: ORES highlights are completely disabled even when ERI is disabled - https://phabricator.wikimedia.org/T163025#3199120 (10jmatazzoni) [18:54:58] 06Collaboration-Team-Triage, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki, and 3 others: Show a different label for the current mode in the editor mode selector (not "switch to…", as it's confusing) - https://phabricator.wikimedia.org/T162864#3199122 (10Catrope) >>! In T162864#3197514, @Johan wrote: >... [18:57:52] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service: ORES highlights are completely disabled even when ERI is disabled - https://phabricator.wikimedia.org/T163025#3199132 (10jmatazzoni) >>! In T163025#3197709, @Halfak wrote: > I don't think it's OK that we take aw... [19:00:10] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10MediaWiki-extensions-Nuke, 05Security: Flow Nuke integration is broken for non-existent users - https://phabricator.wikimedia.org/T162621#3199136 (10Etonkovidova) Checked in enwiki betalabs - when non-existing username is entered on Spec... [19:02:36] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Failure is unrelated." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [19:03:46] etonkovidova, looking. [19:04:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service: ORES highlights are completely disabled even when ERI is disabled - https://phabricator.wikimedia.org/T163025#3199147 (10Halfak) I don't remember making the decision to remove highlighting for people who would l... [19:05:41] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [19:05:48] o/ jmatazzoni_ [19:06:02] hello [19:06:06] if you're around, maybe we could have a quick chat about ORES highlighting here rather than going back and forth in phab :) [19:09:50] ]Sure. Call me on hangouts. I'm not against changing the setup. I'm just against changing it before release. Let's see what people say. Regarding that previous decision, here's what I wrote to users 5 months ago on the ORES page: "Here's what we're thinking: when this new filtering system rolls out as part of the beta, it will replace the current ORES [19:09:51] display on the Recent Changes page. That means the automatic color coding, the red “r” symbol and the “hide probably good edits” filter will go away, to be replaced by the new, more nuanced set of filters and user-defined color coding." So we've been talking about "replacing" for a long time.... [19:12:20] jmatazzoni_, I guess that the "replace" interpretation up in the air. I think that it's clear that enabling the filters *does* replace the "r" + highlighting. [19:12:32] But it also removes the "r" + highlighting for people who do not enable the filters. [19:13:00] At the time we posted that, it wasn't clear how we'd allow users to negotiate the deployment of new filters as a beta feature. [19:13:51] Amir1 is telling me that he'd like to not lose the ORES highlighting option while ERI is in beta. [19:14:04] So I don't think anyone is out for "indefinite" continued support. [19:14:25] But I can understand if there's some big technical hurdles to having both forms of highlighting available to users. [19:19:00] 06Collaboration-Team-Triage, 10MediaWiki-extensions-LiquidThreads, 07Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#3199194 (10demon) [19:24:52] jmatazzoni_, ^ [19:25:03] yes? [19:25:29] see my response above :) [19:28:12] (03Merged) 10jenkins-bot: Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [19:29:04] matt_flaschen: there is even a bug for page pattern matching :) https://phabricator.wikimedia.org/T123449 [19:29:06] Oh, I see. Um, no, I don't think creating a preference for this is a big deal technically. (As long as your lot continues to support the actual shading and ORES service.) But it's already too late to get such a change into the next release. And the next release after that won't be for two weeks. So in effect, the features as planned will go live, including [19:29:07] on en.wiki (but not fa.wiki, for what that's worth). [19:30:04] Tell me more about what you think the negative fallout will be? If ORES users wake up and don't have shading, then enable the feature and have issues, that will be very useful.... But of course, I don't want a s---storm. [19:30:14] jmatazzoni_, hmm... that's an interesting response to what, from a user's point of view, was reported as a bug. [19:30:33] What is the bug? [19:30:35] I'm not sure there'll be a storm so much as a documented request. [19:30:51] https://phabricator.wikimedia.org/T163025 [19:30:55] etonkovidova, just found it, https://gerrit.wikimedia.org/r/#/c/255985/1 . [19:33:23] matt_flaschen: so it should work? hmm... [19:33:51] Sorry, I'm wrong about fa.wiki. Forgot that was our already. [19:34:25] etonkovidova, yes. I'm doing one more test, then reverting. [19:34:39] matt_flaschen: ok, thx [19:36:49] 06Collaboration-Team-Triage, 10Flow: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#3199312 (10Etonkovidova) Rechecked in betalabs - the issue is still present: enteirng 'Mavetuna74%' does not return any results although there are new pag... [19:37:03] (03Merged) 10jenkins-bot: Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [19:39:33] etonkovidova, sorry I didn't investigate more earlier. It's been broken well over a year now, and you caught it almost immediately. [19:40:04] RoanKattouw, how is your SQL-injection-fu? Does https://gerrit.wikimedia.org/r/#/c/349278/ present any issues besides ew? [19:40:34] matt_flaschen: ha! :) Ok, nobody else complained about it - so it's fine [19:40:59] matt_flaschen: My eyes.... [19:41:08] RoanKattouw, yeah. [19:41:16] I can't think of anything offhand though [19:41:30] I mean it uses addQuotes so you can't break out and do insane tihngs [19:42:26] It doesn't seem like you can do anything scary [19:42:42] Other than create potential performance problems by using non-prefix LIKEs [19:43:26] RoanKattouw, even prefix LIKEs if you don't specify a namespace. [19:44:32] RoanKattouw, but it's limited to privileged users. [19:45:22] Also https://www.mediawiki.org/w/index.php?title=Extension:Nuke&diff=585131&oldid=573141 , but Reedy is the one who broke it (years later) [19:46:05] * halfak mumbles something about being "proactive" vs. "reactive" and gets back to work [19:48:04] 06Collaboration-Team-Triage: [minor] Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found - https://phabricator.wikimedia.org/T163494#3199410 (10Etonkovidova) [19:48:24] (03CR) 10jenkins-bot: Switch TestingAccessWrapper to librarized version [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349104 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [19:51:33] (03CR) 10jenkins-bot: Switch TestingAccessWrapper to librarized version [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349088 (https://phabricator.wikimedia.org/T163434) (owner: 10Gergő Tisza) [19:52:57] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#3199440 (10Mattflaschen-WMF) [19:52:59] 06Collaboration-Team-Triage, 10Flow, 06Support-and-Safety: Give the right to bureaucrats to move Flow boards - https://phabricator.wikimedia.org/T163424#3199442 (10Mattflaschen-WMF) [19:53:16] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#2008070 (10Mattflaschen-WMF) [19:53:42] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for bureaucrats?, global renamers? stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#2008070 (10Mattflaschen-WMF) [19:57:54] 06Collaboration-Team-Triage, 10Flow, 06Stewards-and-global-tools: flow-create-board for bureaucrats?, global renamers? stewards (done) (and "Global rename script" ?) - https://phabricator.wikimedia.org/T126229#3199473 (10Mattflaschen-WMF) I don't remember why we didn't give flow-create-board to global rename... [19:59:09] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, and 2 others: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3199474 (10Mattflaschen-WMF) See also {T126229} again. [20:00:18] 06Collaboration-Team-Triage, 10Flow, 13Patch-For-Review: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#3199477 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [20:00:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 13Patch-For-Review: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#1930074 (10Mattflaschen-WMF) [20:03:07] (03PS1) 10Catrope: WikitextEditorWidget: Update toolbar state when switching back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349283 [20:06:26] (03CR) 10Esanders: [C: 032] WikitextEditorWidget: Update toolbar state when switching back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349283 (owner: 10Catrope) [20:15:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed (or WMF-planned) filter functionality that does not fit in current RC Filters UI - https://phabricator.wikimedia.org/T163497#3199515 (10Mattflaschen-WMF) [20:15:10] (03Merged) 10jenkins-bot: WikitextEditorWidget: Update toolbar state when switching back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349283 (owner: 10Catrope) [20:15:29] (03CR) 10jenkins-bot: WikitextEditorWidget: Update toolbar state when switching back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349283 (owner: 10Catrope) [20:16:29] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed (or WMF-planned) filter functionality that does not fit in current RC Filters UI - https://phabricator.wikimedia.org/T163497#3199535 (10Mattflaschen-WMF) [20:16:31] 10MediaWiki-Recent-changes, 07Design: Core-ify the CleanChanges extension's intent (to filter and declutter RecentChanges) - https://phabricator.wikimedia.org/T56203#3199536 (10Mattflaschen-WMF) [20:17:00] (03CR) 10Catrope: [C: 032] MentionStatus: prefer failure-type [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349251 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [20:18:18] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WMF-deployed (or WMF-planned) filter functionality that does not fit in current RC Filters UI - https://phabricator.wikimedia.org/T163497#3199515 (10Mattflaschen-WMF) [20:19:07] (03CR) 10Catrope: [C: 032] Add mention failure notifications to Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308555 (https://phabricator.wikimedia.org/T144614) (owner: 10Addshore) [20:21:51] 06Collaboration-Team-Triage, 10Notifications, 07Easy: Kill the edit threshold notifications (other than 1st) - https://phabricator.wikimedia.org/T160446#3199551 (10kaldari) [20:26:23] (03Merged) 10jenkins-bot: MentionStatus: prefer failure-type [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349251 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [20:28:44] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Update WikimediaIncubator for RC Filters - https://phabricator.wikimedia.org/T163498#3199574 (10Mattflaschen-WMF) [20:28:56] (03Merged) 10jenkins-bot: Add mention failure notifications to Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308555 (https://phabricator.wikimedia.org/T144614) (owner: 10Addshore) [20:29:01] (03CR) 10jenkins-bot: MentionStatus: prefer failure-type [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349251 (https://phabricator.wikimedia.org/T144614) (owner: 10Sbisson) [20:29:12] (03CR) 10jenkins-bot: Add mention failure notifications to Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/308555 (https://phabricator.wikimedia.org/T144614) (owner: 10Addshore) [20:30:42] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3199609 (10Mattflaschen-WMF) [20:31:31] mooeypoo, see my edit to the description of T162675 . [20:31:31] T162675: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675 [20:31:53] I organized the existing filters that need to be (eventually) migrated to RC Filters. [20:38:43] 06Collaboration-Team-Triage, 10MediaWiki-extensions-Nuke: [minor] Special:Nuke - "There are no new pages in recent changes." is displayed if no matches found - https://phabricator.wikimedia.org/T163494#3199639 (10Aklapper) [20:39:01] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 13Patch-For-Review: [minor] frwiki - RC page with filters displays extra dot on a new line - https://phabricator.wikimedia.org/T162844#3199640 (10Etonkovidova) [20:50:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 13Patch-For-Review: [minor] frwiki - RC page with filters displays extra dot on a new line - https://phabricator.wikimedia.org/T162844#3199715 (10Etonkovidova) Since the mentioned lang wikis do not exist in betalabs, I will check it after deployment. [20:55:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/349300 (owner: 10L10n-bot) [20:56:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/349303 (owner: 10L10n-bot) [21:35:24] matt_flaschen: FYI https://wikitech.wikimedia.org/w/index.php?title=Deployments&action=historysubmit&type=revision&diff=1757060&oldid=1756959 [21:36:15] Not that it's that easy to miss those patches or deploy them in the wrong order, because I deliberately rebased them so that the main one depends on the other ones, but I thought I should tell you explicitly [21:37:24] RoanKattouw, isn't that forwards-compatibility? :) [21:37:29] But yeah, noted. [21:37:32] I guess so :) [21:38:06] It was b/c in my mind because I wrote it after writing https://gerrit.wikimedia.org/r/#/c/349146/ [21:38:23] But the latter can't be deployed until wmf.21 finishes rolling out [21:38:31] I'll schedule it for the Thursday afternoon SWAT [21:39:31] mooeypoo: btw, the blue highlighting with scrolling works perfectly in monobook [21:40:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Migrate RCFilters to the new OO.ui.TagMultiselectWidget - https://phabricator.wikimedia.org/T162829#3176126 (10Etonkovidova) Checked for regression in betalabs - no new issue were found. [21:42:27] etonkovidova, wow, working immediately on monobook and "perfectly"? This must be a new record! [21:43:32] mooeypoo: well, still there is no blue highlighting with scrolling in Vector - so I was happy to see it working in monobook [21:43:55] Working in better in Monobook! [21:44:06] That's not just a new record, that's a new way of life [21:44:24] yes, it's sensational! [21:45:10] mooeypoo: : are we going to do something with https://phabricator.wikimedia.org/T159768 ? Basically to make Vector to work as monobook regarding blue highlighting? [21:51:21] matt_flaschen: oh, I am totally lost with FlaggedRevs in en betalabs - Special:PendingChanges lists very old articles. I was reading all Help on FlaggedRevs but cannot figure out how to flag (or add) article edits [22:00:14] etonkovidova, are you trying to set a page to use flagged revisions, or approve an existing page? [22:00:21] etonkovidova, BTW, flagged revisions varies by configuration. [22:02:48] etonkovidova, to set a page to use flagged revisions on enwiki beta, it's an option under protection. E.g. https://en.wikipedia.beta.wmflabs.org/w/index.php?title=May30thchrome&action=protect . [22:02:51] See 'Pending changes'. [22:03:04] (Already set that one just now) [22:03:48] etonkovidova, once you've done that (or found such a page), it's pretty self explanatory. E.g. https://en.wikipedia.beta.wmflabs.org/wiki/May30thchrome . [22:04:07] First click '1 pending revision' (on page), or "pending review" on history. [22:04:16] Then "Accept revision" [22:04:28] etonkovidova, if you're talking about deferred changes that's a whole other thing (almost) [22:04:47] matt_flaschen: not deferred changes, pending :) [22:05:33] Just asking since it's also part of Flagged Revisions. [22:05:49] matt_flaschen: yeah, I remember vaguely now that pending relates to protection level... Thanks, I am looking now at the links [22:27:02] RoanKattouw, see jmatazzoni_'s email about integrated filters. Let me know if you're okay with that name. [23:07:57] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service: Create a preference for 'classic' ORES shading on RC Page - https://phabricator.wikimedia.org/T163025#3200113 (10jmatazzoni) a:03Catrope [23:08:11] mooeypoo: Conflicting filters state looks different - is it a deliberate change? [23:12:04] matt_flaschen: LGTM [23:13:20] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service: Create a preference for 'classic' ORES shading on RC Page - https://phabricator.wikimedia.org/T163025#3200150 (10jmatazzoni) [23:13:24] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 06Revision-Scoring-As-A-Service: Create a preference for 'classic' ORES shading on RC Page - https://phabricator.wikimedia.org/T163025#3183746 (10jmatazzoni) OK, @Ladsgroup and @Halfak, we'll add this back in while the beta is still a beta.Bec... [23:14:58] halfak: OK, you got it. See the renamed and rewritten https://phabricator.wikimedia.org/T163025 [23:16:19] Thanks jmatazzoni_! :))) [23:19:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Epic, 07Tracking: Extend the filter capabilities for edit review - https://phabricator.wikimedia.org/T162675#3200165 (10jmatazzoni) [23:19:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-Integrated-Filters: Support filtering for users, edit tags, and namespaces - https://phabricator.wikimedia.org/T159942#3200167 (10jmatazzoni) [23:20:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate time period selection in the new filters for edit review - https://phabricator.wikimedia.org/T162784#3200168 (10jmatazzoni) [23:21:00] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters, 07Design: Integrate result size selection in the new filters for edit review - https://phabricator.wikimedia.org/T162786#3200170 (10jmatazzoni) [23:21:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Provide navigation controls to move though the results of the new filters for edit review - https://phabricator.wikimedia.org/T163429#3200177 (10jmatazzoni) [23:21:38] matt_flaschen: Who would be good to talk to about an issue we're running into with global notifications? [23:21:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-Integrated-Filters: Support filtering for categories in the new filters for edit review - https://phabricator.wikimedia.org/T163433#3200178 (10jmatazzoni) [23:22:46] kaldari, me, stephanebisson, or RoanKattouw. [23:22:57] kaldari, what's the issue? [23:23:03] Is this the counting issue? [23:23:24] No, different issue [23:27:09] matt_flaschen: We're working on the new LoginNotify extension which let's a user know when there was an unsuccessful attempt to login into their account. The notification itself doesn't link to anything. I know Echo expects all notifications to have a primary link, but it seems to work OK without it, except for the case of global notifications. See [23:27:09] https://phabricator.wikimedia.org/T162104#3165203. My question is, do you think this is a legitimate use case and we should move ahead without a primary link and see about modifying Echo to support this use case, or do you think we should make all of our notifications have a primary link? [23:28:08] See the last screenshot on that comment [23:28:42] kaldari, oh, since it's a product question, it's more jmatazzoni_ or pginer. But IMHO I would make it a link. If they just want to mark it as read, There's A Button For That TM. [23:28:51] kaldari, there's several meaningful things you could link it to: [23:29:14] * Information about the feature [23:29:31] Yeah, we were thinking maybe a page about securing your account. [23:29:35] * Preferences for the feature [23:29:39] Yeah, that would be good too. [23:29:53] But yeah, it's product and I don't have a strong view on this particular question. [23:30:20] Ooh right, this is the issue with having a very long notification header that gets truncated, and nowhere to link to where the user could also view that information [23:30:27] kaldari: Having a primary link is not actually required. There are notifications that don't have one. So if that feels right, it is fine. [23:30:50] jmatazzoni_: The issue is that their notification text is very long, and when it's a cross-wiki notification that gets truncated with no way to view the whole text [23:30:52] T162104 [23:30:53] T162104: Fix multiple/repetitive notifications with LoginNotify - https://phabricator.wikimedia.org/T162104 [23:31:13] Or rather, https://phabricator.wikimedia.org/T162104#3165203 [23:31:31] kaldari, jmatazzoni_, if you don't make it a link, you could consider marking it as read on click. [23:31:32] https://phabricator.wikimedia.org/F7355286 [23:31:37] jmatazzoni_: The other issue is that it changes the cursor to a clicky-finger even if there is no link. [23:31:44] Ha oops [23:31:48] but that should be easy to fix [23:31:53] I think that doesn't happen for normal notifs actually [23:31:54] The orange box is not accurate. If you click on "English Wikipedia", you go to Special:Notifications on enwiki and see the dispersed notifications and not the full text. [23:32:05] That may be an issue specific to cross-wiki non-primary-link notifs [23:33:55] jmatazzoni_, matt_flaschen: When I was talking about this with Niharika earlier, she appeared to expect that clicking the notification would expand it; we could consider doing that too [23:34:24] But then you'd only have that functionality for non-primary-link notifs [23:34:28] jmatazzoni_: it's tricky because then you have 2 different behaviors on click [23:34:32] Maybe we just shouldn't brower-truncate XWNs? [23:34:42] *browser [23:34:43] RoanKattouw: Expand on hover? [23:34:59] that's an idea [23:35:04] Niharika: Then the height changes on hover, specifically on mouseout, which would make the interface pretty jerky [23:35:33] Yeah. [23:35:35] Like, if you try to hover from the first notif to the second one, upon exiting the first notif it collapses again, and now you're over the fourth notif [23:35:46] Also, mobile doesn't have hover (except Samsung actually does...). [23:36:06] matt_flaschen: does it detect what you're looking at? :) [23:36:24] kaldari, no, it literally has hover support for your finger. [23:36:33] RoanKattouw: Well, I'd expect the whole panel to expand/collapse but I can see how that's not gonna be easy. [23:36:34] kaldari, no one believes me until I show it to them, but it's true. [23:36:36] But, why not just not truncate? I think we should still truncate notifs inside local bundles (those use get*Compact*HeaderMessage after all), but in cross-wiki bundles it seems harmful to truncatre [23:37:18] Yeah, otherwise you might never get to read the full bundled notification message [23:38:19] Sounds good to me. (Our notification text is only 40 words long, I swear :) [23:38:30] matt_flaschen, as the guru of GuidedTour -- I'm looking to change the style of guider_title class - but I can't seem to find that definition at all in GuidedTour -- do you know where I might find it? [23:38:55] Also, since the global notifications are already collapsed by default (into the "More alert from another wiki"), it doesn't seem like it hurts anything if they are more than 1 line. [23:39:43] "only" [23:41:23] jmatazzoni_, matt_flaschen, RoanKattouw: Do you think we have consensus to not truncate the cross-wiki bundles? [23:41:31] mooeypoo, eh, that's weird, sorry. It's the only h1, so it's selected as that. [23:41:42] Don't know how that got that way. :) [23:42:08] i.e. should I make a task for this? [23:42:27] I don't object to the truncation, sounds reasonable. [23:42:27] I'll ask jmatazzoni_ what he thinks when he's back at his desk [23:42:29] But yeah, file it [23:42:35] matt_flaschen: untruncation ;) [23:43:11] I don't think Wikimedians have ever objected to having too much information ;) [23:43:15] haha [23:43:20] Designers, OTOH... [23:46:31] Anyway, file a task and we'll discuss [23:47:07] matt_flaschen, sorry, apparently it's under guider_content { ... h1 {..} } [23:47:09] found it [23:47:32] kaldari: Your notification text is also probably the longest I've ever seen; perhaps you could consider moving the "If this is you, don't worry, etc" text to a documentation/explanation page and linking to that from the notification? [23:48:29] RoanKattouw: good suggestion. I'll run it by Danny [23:49:21] 06Collaboration-Team-Triage, 10Notifications, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200259 (10kaldari) [23:49:22] I mean, if it needs to be four lines long, then it needs to be; it's just that four lines is long enough that it triggers my "surely there must be a better way" shudders [23:49:29] 06Collaboration-Team-Triage, 10Notifications, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200272 (10kaldari) [23:51:06] Thanks for the suggestions, everyone! [23:51:34] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200275 (10kaldari) [23:54:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements, 10MediaWiki-extensions-FlaggedRevs: Port FlaggedRevs to new RCFilters UI - https://phabricator.wikimedia.org/T159791#3200281 (10Zache) If user have //autoreview// user right for FlaggedRevs but not //autopatrol// for patrolling then his/her edits will... [23:55:32] 06Collaboration-Team-Triage, 10Notifications, 06Community-Tech, 07Crosswiki: Don't truncate bundled cross-wiki notifications - https://phabricator.wikimedia.org/T163518#3200259 (10Catrope) Here's what truncated vs untruncated would look like: {F7674591} {F7674593} [23:56:46] Heading out, may be back on later. [23:58:46] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: dewiki - GuidedTour for no ORES models displays the title as cutoff - https://phabricator.wikimedia.org/T163245#3200319 (10Mooeypoo) a:03Mooeypoo