[00:00:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), 05MW-1.29-release (WMF-deploy-2017-02-28_(1.29.0-wmf.14)), 13Patch-For-Review: Transwiki (within a farm) support for Flow dumps/i... - https://phabricator.wikimedia.org/T154830#2925084 [00:11:50] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 05MW-1.29-release-notes: IE11 - checkboxes for RC filters cannot be checked - https://phabricator.wikimedia.org/T162098#3159381 (10Volker_E) 05Open>03Resolved [00:44:22] Is there a way to output debug stuff from echo? My bundle doesn't appear as a bundle. Not sure what's wrong. :( [07:58:26] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 3 about the New Filters for... - https://phabricator.wikimedia.org/T158333#3159686 [08:02:52] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice: Announce and follow up with communities about the New Filters for Rece... - https://phabricator.wikimedia.org/T146972#3159702 [08:14:40] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3159781 (10Dmgdeepak) These points i founded on given link of idea and after working on them , i have mentioned the ways (Miles... [08:59:45] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3159842 (10Aklapper) @Dmgdeepak: I'm sorry but I neither know what your last comment should imply nor what exactly you are aski... [10:39:59] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3160013 (10Dmgdeepak) I had mentioned in project overview and milestones tab in the document. Milestones represents tasks in m... [13:24:41] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3160291 (10Aklapper) I'm still not sure what this conversation is about, so let me try to rephrase: Do you have a [[ https://ww... [15:40:31] 10MediaWiki-Watchlist: Watchlist in Wikipedia to also report changes to related Wikidata item - https://phabricator.wikimedia.org/T162238#3156428 (10matej_suchanek) Works for me: https://en.wikipedia.org/w/index.php?title=Special%3AWatchlist&hideWikibase=0 [16:35:24] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ORES thresholds and overlaps optimization - https://phabricator.wikimedia.org/T161275#3160835 (10Halfak) [18:03:03] 10MediaWiki-Watchlist, 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Watchlist in Wikipedia to also report changes to related Wikidata item - https://phabricator.wikimedia.org/T162238#3161135 (10matej_suchanek) [18:05:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 05MW-1.29-release-notes, 13Patch-For-Review: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3161148 (10Etonkovidova) Ch... [18:16:19] Is there a way to output debug stuff from echo? My bundle doesn't appear as a bundle and I'm trying to figure out where's the error. It issues individual notifications instead of bundling it. [18:16:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 05MW-1.29-release-notes, 13Patch-For-Review: Educate users about the highlight option and encourage t... - https://phabricator.wikimedia.org/T151006#3161305 [18:17:58] Niharika: Hmm not offhand but I'll come to your desk and debug with you in person [18:18:38] Cool. Thanks. :) [18:53:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3161423 (10Etonkovidova) @jmatazzoni I am moving the ti... [19:05:37] RoanKattouw: I added some info here https://www.mediawiki.org/wiki/Extension:Echo/Creating_a_new_notification_type#Bundling_notifications I might have missed something. [19:07:27] Thanks! [19:08:38] Niharika: Also I think getCompactHeaderMessage() is something you might want to use [19:08:50] It looks like that's the one that's used for notifs inside a bundle [19:09:56] Ah, okay, gotcha. RoanKattouw would you know what the $bundleString we're setting in the hook is? [19:10:20] It's for if you want to group bundles [19:10:35] So for example, we bundle page-linked notifications for the same page [19:10:45] The bundle header is something like "5 new pages now link to Foo" [19:11:07] But if there are also two page-linked events for Bar, then you want that to be a separate bundle, not bundled in with the Foo onese [19:11:34] The way that's supported is that only events with the same $bundleString get bundled together [19:11:43] So in this example you would set $bundleString to the page name (Foo or Bar) [19:11:45] Does that make sense? [19:11:49] Ah, okay. Got it. [19:11:51] Yup. [19:12:02] In your case, you probably want to bundle all notifs of your type together anyway, so you can just use a constant [19:43:23] Niharika: Thanks again for writing those docs! I just tweaked them a bit and added getCompactHeaderMessage [19:50:16] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3161595 (10srishakatux) As mentors will soon be reviewing applications, if your proposal is complete, move it to the submitted column. T... [19:52:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" b... - https://phabricator.wikimedia.org/T158458#3161610 [20:35:41] "How to make a notification bundled" I have some grammatical issues with that. :P [20:37:28] Niharika: "Notification bundlability enablement" ;-) [20:38:50] James_F gets a cookie for coining "bundlability" :P [20:39:24] Niharika: Of course, in German it'd be almost the same but without the spaces. [20:39:47] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3147988 (10Mooeypoo) To save everyone some time - the deadline has passed. There's no need to continue back-and-forth as even... [20:40:50] :D [20:41:11] Don't remind me about having to write out German addresses in the visa form for my Austrian visa. [20:41:23] Or German street names, rather. [20:44:35] ha [20:44:50] I imagine writing/typing ß is interesting too [20:45:46] Thanks for fixing my weird section title [20:49:21] Oh, hah, I hadn't looked at the street name for the Vienna venue. Mautner-Markhof-Gasse 50 [20:51:06] RoanKattouw: Imagine having a 1"x2" box for writing the entire address. Thrice. [20:51:14] Argh [20:51:30] And then, of course, my form was outdated by 6 months so they gave me a new one. :P [20:56:44] 10MediaWiki-Watchlist, 05MW-1.23-release, 05MW-1.27-release, 13Patch-For-Review, 05Security: "Mark all pages visited" on the watchlist does not require a CSRF token - https://phabricator.wikimedia.org/T150044#3161816 (10Reedy) [21:04:25] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes, 06Editing-Department, 07JavaScript: Make Special:RecentChanges auto-updating - https://phabricator.wikimedia.org/T7560#101255 (10Zppix) @Krinkle created this script on meta, https://meta.wikimedia.org/wiki/User:... [21:12:00] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-11_(1.29.0-wmf.20)), 05MW-1.29-release-notes, 13Patch-For-Review: Create a way to clear the "Show new changes starting fro... - https://phabricator.wikimedia.org/T160028#3161864 [21:27:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" b... - https://phabricator.wikimedia.org/T158458#3037669 [22:00:57] RoanKattouw: Is it expected for a bundle to vanish after marking it as read? And for bundled stuff to show up as not bundled in Special:Notifications? [22:01:14] Yeah bundles work a bit strangely :/ [22:01:27] I feel like this made more sense when I worked on it :) [22:01:46] But yeah only unread notifs are bundled [22:02:00] And on the special page, I think nothing is bundled? [22:02:29] Hmm, so having my bundle not be expandable is not a very clean solution after all. [22:02:50] Right because it would still break up into pieces once it's marked as read [22:05:00] Bundles used to work closer to the way you seem to be expecting to, but this had issues, because things would either join an existing bundle or form a new one depending on whether there was an unread bundle at the time (which got awkward once we introduced mark-as-unread), and the implementation relied on each bundle having a "leader" (the bundle_base) which [22:05:00] got awkward when we started supporting deletion/suppression of individual notifications [22:05:11] *expecting them to [22:05:29] Right. [22:05:42] So now bundles are formed dynamically from all unread notifs that have the same bundle_hash [22:05:54] So if you mark things as unread and refresh, your bundle will grow [22:06:44] RoanKattouw: are we ok with having edits simultaneously 'Very likely good' and 'Likely bad faith'? :) looks strange ... [22:07:10] etonkovidova: On which wiki? [22:07:45] RoanKattouw: Does opening/closing the panel have any effect on the notifications? [22:08:59] Closing and reopening the panel reloads its contents, but it doesn't have any direct effect on the notifications themselves, apart from seen-ness (the very first time you see a notification, it'll be blue, then the blue background will animate away after 2s; any subsequent time you view it, it won't be blue) [22:09:40] IOW, unseen notifications get the animated blue background thingy, seen ones don't, and once a notif becomes seen it never becomes unseen again [22:10:23] Got it. Thanks! [22:11:40] Niharika: Also how are you planning for this to work in a cross-wiki world? Does the notification appear on the wiki where the login attempt occurred, or does it appear on loginwiki? [22:11:53] * RoanKattouw thinks there are downsides to both approaches but the former might be better [22:14:32] RoanKattouw: Wait, you mean where is the notification "Issued" from? [22:14:38] Yeah [22:15:08] The problem with latter is we don't want to direct people to loginwiki because it's obscure, nobody uses it except stewards. [22:15:18] Yeah I was just thinking the same thing [22:15:25] Some developers don't even know what loginwiki is [22:15:28] So for now we're going with the wiki the login was attempted on. [22:15:45] Joe Reader and Jane Editor will certainly be confused if they see "New notification from Login Wikimedia" [22:15:58] Makes sense [22:16:06] Ideally we were hoping we could have the notification not be tied to a wiki but since that's not an option. [22:16:36] RoanKattouw: You said it's not supported "currently" the other day. Is it going to be, at some point? [22:16:44] I think it might be possible to support something like that in Echo at some point [22:16:49] We've never really had a use case for it before [22:17:13] Yeah. [22:17:18] Most notifs are about pages (which are always on a wiki) or activity (which happened on a wiki) [22:17:31] This is the first notification that's about your SUL account [22:17:36] True. [22:18:52] I think it's doable, but it would require some new infrastructure (new tables in a shared DB) and the existing schema wouldn't quite work because you can't tie these notifs to page IDs [22:19:18] I don't think it's worth the effort. You're probably not get many use cases for it. [22:19:25] not gonna get* [22:22:43] Yeah I agree [23:07:27] 06Collaboration-Team-Triage, 10Thanks, 07Browser-Support-Apple-Safari, 07Browser-Support-Internet-Explorer, 07JavaScript: On Safari and IE9 the thanks confirmation is not hidden correctly - https://phabricator.wikimedia.org/T117309#3162127 (10Jdforrester-WMF) 05Open>03stalled Moving to "Stalled" as i... [23:07:49] 06Collaboration-Team-Triage, 10Thanks, 07Browser-Support-Apple-Safari, 07JavaScript: On Safari the thanks confirmation is not hidden correctly - https://phabricator.wikimedia.org/T117309#3162129 (10Jdforrester-WMF) [23:08:02] 06Collaboration-Team-Triage, 10Thanks, 07Browser-Support-Apple-Safari, 07JavaScript: On Safari the thanks confirmation is not hidden correctly - https://phabricator.wikimedia.org/T117309#1771054 (10Jdforrester-WMF) Dropped IE references as IE9 no longer gets JavaScript. [23:10:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'No Filters found' produces 'TypeError: undefined is not an object (evaluating 'filterItem.isSelected')' - https://phabricator.wikimedia.org/T162417#3162145 (10Etonkovidova) [23:17:31] mooeypoo: https://phabricator.wikimedia.org/T162417#3162145 [23:43:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346892 (owner: 10L10n-bot)