[00:00:45] Heading out. Will be back on late tonight. [01:32:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - remind me this article in X days - https://phabricator.wikimedia.org/T161823#3152871 (10Mattflaschen-WMF) [01:34:29] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: GSOC 2017 Article Reminder Notification - https://phabricator.wikimedia.org/T161967#3152879 (10Mattflaschen-WMF) [01:36:44] 06Collaboration-Team-Triage, 10Notifications, 10Outreach-Programs-Projects, 03Google-Summer-of-Code (2017): Notify User about articles - https://phabricator.wikimedia.org/T162052#3152892 (10Mattflaschen-WMF) [01:40:00] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Outreach-Programs-Projects, 03Google-Summer-of-Code (2017): Implement a feature for MediaWiki's Notifications tool: Make it possible for a logged-in user to get a reminder of an a... - https://phabricator.wikimedia.org/T162048#3152894 [01:44:34] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3152899 (10Mattflaschen-WMF) [01:45:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - remind me this article in X days - https://phabricator.wikimedia.org/T161823#3152901 (10Mattflaschen-WMF) [01:50:44] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: GSOC 2017 Article Reminder Notification - https://phabricator.wikimedia.org/T161967#3152903 (10Mattflaschen-WMF) [01:50:48] 06Collaboration-Team-Triage, 10Notifications, 10Outreach-Programs-Projects, 03Google-Summer-of-Code (2017): Notify User about articles - https://phabricator.wikimedia.org/T162052#3152904 (10Mattflaschen-WMF) [01:51:05] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Outreach-Programs-Projects, 03Google-Summer-of-Code (2017): Implement a feature for MediaWiki's Notifications tool: Make it possible for a logged-in user to get a reminder of an a... - https://phabricator.wikimedia.org/T162048#3152905 [01:51:23] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3152907 (10Mattflaschen-WMF) [04:44:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Unchecking category leads to more results on plwiki - https://phabricator.wikimedia.org/T161756#3142080 (10Etonkovidova) (1) "Group changes by page in recent changes and watchlist" is not required to reproduce the is... [04:49:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Unchecking category leads to more results on plwiki - https://phabricator.wikimedia.org/T161756#3152962 (10Etonkovidova) Another interesting example: 'Logged action' - 50, 'Category changes' - 5; 'Logged action' and... [05:27:21] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3152981 (10Mattflaschen-WMF) There does not seem to be a microtask attached to your proposal. If one was completed before the deadline,... [05:27:56] 06Collaboration-Team-Triage, 10Notifications, 10Outreach-Programs-Projects, 03Google-Summer-of-Code (2017): Notify User about articles - https://phabricator.wikimedia.org/T162052#3152982 (10Mattflaschen-WMF) There does not seem to be a microtask attached to your proposal. If one was completed before the d... [05:28:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10Outreach-Programs-Projects, 03Google-Summer-of-Code (2017): Implement a feature for MediaWiki's Notifications tool: Make it possible for a logged-in user to get a reminder of an a... - https://phabricator.wikimedia.org/T162048#3152983 [05:28:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3152984 (10Mattflaschen-WMF) There does not seem to be a microtask attached to your proposal. If one was completed before the... [06:43:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3153065 (10Dmgdeepak) @Aklapper @Mattflaschen-WMF Hi, I got to know about the microtask from given link and hence i mentioned... [08:52:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Turn off 'classic' ORES highlighting on the RC page - https://phabricator.wikimedia.org/T159300#3063387 (10Trizek-WMF) >>! In T159300#3152586, @Etonkovidova wrote: > @jmatazzoni - So, every time you log in to ptwiki... [09:29:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 03Google-Summer-of-Code (2017): MediaWiki's Notification tool - https://phabricator.wikimedia.org/T161947#3153267 (10Aklapper) I don't see anything related to a [[ https://www.mediawiki.org/wiki/Outreach_programs/Life_of_a_successful... [12:52:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Patrolled changes are shown as unpatrolled in RC Filters results - https://phabricator.wikimedia.org/T162020#3153624 (10Trizek-WMF) I've asked for IDs and a screenshot. [14:03:23] 06Collaboration-Team-Triage, 06Editing-Department, 10MediaWiki-Interface, 10MediaWiki-Page-editing, and 5 others: Add method to Revision to check if it was a revert - https://phabricator.wikimedia.org/T152434#3153869 (10Halfak) It might be a good fit for #edit-review-improvements too since they are working... [14:13:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Damaging levels on Polish Wikipedia overlap too much - https://phabricator.wikimedia.org/T161655#3153878 (10Halfak) > I think ["Likely bad"] should be more strongl... [14:14:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Add more values to test_stats - https://phabricator.wikimedia.org/T161767#3153879 (10Halfak) OK. This can be done. Adding a precision_at_recall metric would be a... [15:06:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Category changes' with 'Very likely have problems' are not marked with 'r' - https://phabricator.wikimedia.org/T161363#3129934 (10SBisson) Is it possible that these changes are (auto-)patrolled? In w... [15:08:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3126737 (10SBisson) >>! In T161258#3152124, @Mattflaschen-WMF wrote: > Reported [upstream](https://www.genome.gov/10001772/all-about-the... [15:21:35] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Unstructured filters replaced by Structured filters may still affect the results - https://phabricator.wikimedia.org/T162158#3154056 (10SBisson) [15:28:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Turn off 'classic' ORES highlighting on the RC page - https://phabricator.wikimedia.org/T159300#3154081 (10SBisson) @jmatazzoni Can you reproduce this problem or did it happen on your first visit to both wikis and th... [15:30:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3154100 (10jmatazzoni) I'm not sure what you mean by an optical illusion. I measured the spaces between dots by zooming in on the screens... [16:07:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3154197 (10SBisson) If you zoom in //with the browser// before taking your screenshot you get different results, hence the idea of a brow... [16:12:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3154215 (10Mooeypoo) >>! In T161258#3154197, @SBisson wrote: > If you zoom in //with the browser// before taking your screenshot you get... [17:15:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Unstructured filters replaced by Structured filters may still affect the results - https://phabricator.wikimedia.org/T162158#3154056 (10Catrope) The field is used to export a data attribute that causes the client-side JS to hide the filter. You'r... [17:18:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Unstructured filters replaced by Structured filters may still affect the results - https://phabricator.wikimedia.org/T162158#3154337 (10Mattflaschen-WMF) I think the solution here is to set all the defaults to not-hide for legacy filters, if the... [17:22:50] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Unstructured filters replaced by Structured filters may still affect the results - https://phabricator.wikimedia.org/T162158#3154342 (10Mattflaschen-WMF) This can be done by core itself based on a getter for isReplacedInStructuredUi. [17:48:20] With Echo installed, when I load a page for the first time and click on the Notices icon, I see a quick flash of "Notice()" over the icon. I see it on Beta cluster and my local install but not enwiki. Is this a known bug? [18:05:34] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 3 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3154456 [18:06:38] Niharika: that sounds related to my recent changes (https://gerrit.wikimedia.org/r/#/c/345969/) :( but i can't reproduce it. can you file it? (also, can you take a screenshot or video of what happens?) [18:07:44] MatmaRex: https://usercontent.irccloud-cdn.com/file/VBw39U5U/Screen%20Shot%202017-04-04%20at%2010.55.36%20AM.png [18:07:58] Hides the "Talk" link. [18:08:29] It sticks sometimes and doesn't vanish until I click it again. [18:09:18] Niharika: hm, it only happens with "Notices"? not with the other one? [18:09:41] MatmaRex: Yeah. Just with Notices. [18:13:47] Niharika: file a task please? i'll look into it [18:14:31] Sure thing. [18:16:39] MatmaRex: I was wrong. Happens with both tabs. [18:20:20] 06Collaboration-Team-Triage, 10Notifications: Clicking on Notices/Alerts issues a banner over the other icon - https://phabricator.wikimedia.org/T162173#3154480 (10Niharika) [18:30:50] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: IE11 RC filters - 'x' icon for discarding filters displayed as cut off - https://phabricator.wikimedia.org/T162176#3154542 (10Etonkovidova) [18:39:16] mooeypoo: https://phabricator.wikimedia.org/T162173 [18:40:11] (03PS1) 10Mooeypoo: Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346334 (https://phabricator.wikimedia.org/T162173) [18:40:57] (03CR) 10Mooeypoo: [C: 032] "Per Roan" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346334 (https://phabricator.wikimedia.org/T162173) (owner: 10Mooeypoo) [18:41:21] Niharika: Thanks for reporting that [18:41:45] MatmaRex: I told mooeypoo to revert your most recent patch, then investigate [18:42:02] RoanKattouw: yeah ok [18:42:05] sorry :( [18:42:09] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: IE11 RC filters - 'x' icon for discarding filters not fully displayed - https://phabricator.wikimedia.org/T162176#3154611 (10Etonkovidova) [18:42:13] Since the branch cut is like now-ish :/ [18:42:14] i'll look at it later. in a meeting now [18:42:16] No worries [18:42:23] Moriel is also looking at it [18:42:29] RoanKattouw: it was cut already, you'll need to backport :/ [18:42:36] OK, will do [18:42:43] I'm trying to figure out why it would even touch vector [18:42:52] the changes are for cologne blue and modern [18:43:18] the only change that's "global" for all is changing the label but from first pass I don't see how that would do anything, since the CSS in vector would've overrode the text anyways [18:43:19] Yeah but you did change something in the JS code that sets the label of the wiget [18:43:34] yeah but the CSS hides the label anyways [18:43:39] looking now, it might be differently-wrapped [18:47:42] (03CR) 10jerkins-bot: [V: 04-1] Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346334 (https://phabricator.wikimedia.org/T162173) (owner: 10Mooeypoo) [18:48:14] :( [18:49:23] MatmaRex, why did you replace the label initially? It's the cause of the issue, and I am planning to revert only that part and see if things go back to being okay - but I don't want to miss anything if you had a reason to do that? [18:50:36] MatmaRex, the JS shouldn't use the 'Alerts' and 'Notices' label because it formats the number-box with it [18:50:42] so it has to stay a number [18:50:55] But then it seems like it might not work for cologne-blue and modern [18:51:37] Either we conditionally set that in the js based on themes (yuck) or I need to get into the CSS and see if I can force it to output the data attribute [18:54:46] ok I think I got it [18:55:47] 06Collaboration-Team-Triage, 10Notifications, 07I18n: Notification controls spill over in RTL wikis - https://phabricator.wikimedia.org/T161728#3141162 (10Etonkovidova) Checked the both scenarios in hewiki (and ptwiki) with wmf.18 (on Chrome and IE11). It seems that the fix from {T161302} is in place. [18:56:15] 06Collaboration-Team-Triage, 10Notifications, 07I18n: Notification controls spill over in RTL wikis - https://phabricator.wikimedia.org/T161728#3154694 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Normal [18:56:56] ok thi sis actually going to be a challenge... MatmaRex we're updating the number through the 'data-counter-text' attribute (the css class uses content: attr(data-counter-text)) [18:57:02] In vector it should be a formatted number [18:57:15] in Cologne blue and Moden it should be both the number and the type label [18:57:51] So I guess I can add another data attribute and change cologne-blue and modern's content to read from THAT attribute [19:06:18] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Patrolled changes are shown as unpatrolled in RC Filters results - https://phabricator.wikimedia.org/T162020#3154752 (10Etonkovidova) [19:07:06] Got it. Now I just need to wait for the revert to go through so I can submit a clean patch [19:09:50] (03Merged) 10jenkins-bot: Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346334 (https://phabricator.wikimedia.org/T162173) (owner: 10Mooeypoo) [19:17:21] (03PS1) 10Catrope: Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] (wmf/1.29.0-wmf.19) - 10https://gerrit.wikimedia.org/r/346341 (https://phabricator.wikimedia.org/T162173) [19:23:13] (03CR) 10Catrope: [C: 032] Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] (wmf/1.29.0-wmf.19) - 10https://gerrit.wikimedia.org/r/346341 (https://phabricator.wikimedia.org/T162173) (owner: 10Catrope) [19:24:03] (03PS1) 10Mooeypoo: Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:24:15] (03PS2) 10Mooeypoo: Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:24:47] (03PS3) 10Mooeypoo: Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:25:04] (03PS4) 10Mooeypoo: Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:25:12] MatmaRex, ^ [19:25:15] RoanKattouw, ^ [19:25:42] 4 patchsets in 61 seconds, that must be some kind of record [19:26:01] MatmaRex, I do have a small bug I can't manage to figure out... the number box **moves** [19:26:12] when you click the badge, it moves to the left a bit, then adjusts back to the right [19:26:16] Ican't figure out why [19:26:52] on first click only [19:32:50] (03PS5) 10Mooeypoo: Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:33:46] (03PS6) 10Mooeypoo: Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:35:13] (03PS7) 10Mooeypoo: [wip] Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) [19:36:47] (03CR) 10Mooeypoo: [C: 04-1] "This commit has a bug, where the number-box (in ALL skins!) moves slightly to the left and then back to the right again." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) (owner: 10Mooeypoo) [19:40:59] (03CR) 10jenkins-bot: Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346334 (https://phabricator.wikimedia.org/T162173) (owner: 10Mooeypoo) [19:42:30] (03Merged) 10jenkins-bot: Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] (wmf/1.29.0-wmf.19) - 10https://gerrit.wikimedia.org/r/346341 (https://phabricator.wikimedia.org/T162173) (owner: 10Catrope) [19:54:16] (03CR) 10jerkins-bot: [V: 04-1] [wip] Use formatted text label for echo badge icons in different skins [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346343 (https://phabricator.wikimedia.org/T162173) (owner: 10Mooeypoo) [19:59:12] (03CR) 10jenkins-bot: Revert "Do not use fancy styled badge on Modern and CologneBlue" [extensions/Echo] (wmf/1.29.0-wmf.19) - 10https://gerrit.wikimedia.org/r/346341 (https://phabricator.wikimedia.org/T162173) (owner: 10Catrope) [20:07:16] mooeypoo: dunno, i didn't notice it before. i'll look into it, just not today [20:10:14] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3154996 (10Reedy) [20:10:35] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#1892090 (10Reedy) 1.1.0 seems to break at least core and Flow for starters [20:29:29] 06Collaboration-Team-Triage, 10Flow, 10Beta-Cluster-Infrastructure, 07Chinese-Sites, 15User-Luke081515: Request for "Flow"ing pages on zhwp Beta-cluster - https://phabricator.wikimedia.org/T162131#3155052 (10hashar) @Trizek-WMF @Danny_B Chinese projects seems to have an interest in #flow :-] [20:39:26] if ( !class_exists( 'LightnCandy' ) ) { [20:39:26] throw new RuntimeException( 'LightnCandy class not defined' ); [20:39:26] } [20:39:30] Anyone know why we have that in core? [20:39:43] When the vendory stuff should be enough to make sure it's in place? [20:40:56] sanity check? [20:41:01] * Reedy swaps for some PHP 5.5-ness [20:41:03] if ( !class_exists( LightnCandy::class ) ) { [20:41:51] Apparnetly that works with namespace use statements [20:45:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/346396 (owner: 10L10n-bot) [20:47:56] MatmaRex, whenever you have time and only if you find the inclination for it, https://gerrit.wikimedia.org/r/#/c/346343/ [20:50:07] i'll check it out… eventually :) [20:55:29] mooeypoo: https://phabricator.wikimedia.org/T151006 - blue dot [20:55:33] stephanebisson, do ou know about the .rcfilters-tour-highlight-stillDot looking off in RTL? I think I know why, but I don't want to step on toes if you're dealing with it [20:56:56] also, where's the code for it [20:56:59] I can't find it [20:57:29] ah, WikimediaMessages [20:59:31] mooeypoo: I had no idea [20:59:41] mooeypoo: how off? [21:02:20] stephanebisson, the dot looks squished [21:02:29] stephanebisson, it's because it's in ems. I am fixing it to be pixels [21:02:32] that fixes it [21:02:44] fantastic [21:03:19] I have no idea why it only happens in RTL, but it probably has something to do with whatever is done to the sizing/positioing/etc [21:03:28] the browser then "helpfully" rounds things [21:05:05] stephanebisson, https://gerrit.wikimedia.org/r/#/c/346439/ [21:09:09] stephanebisson, from inside rcfilters-highlight-tour-hooks, I can assume the code already absolutely definitely has rcfilters loaded, right? [21:09:42] I want to put the dot inside the overlay instead so it isn't hidden by the bottom part of the header div [21:11:25] I mean, it's calling rcfilter stuff, so I assume so, but it's calling jQuery elements so it won't actually break -- I am wondering if I am safe using things like mw.echo.blah [21:11:26] err [21:11:30] mw.rcfilters.blah [21:11:33] (mindmelt) [21:18:20] "There is no 'resolve from file' feature in handlebars.js nor in lightncandy" [21:30:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 05MW-1.29-release-notes, 13Patch-For-Review: Educate users about the highlight option and encourage t... - https://phabricator.wikimedia.org/T151006#2804422 [21:37:04] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3155340 (10Reedy) @kaldari Do you remember much about this code? It seems, something has changed with the partial... [21:41:29] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3155352 (10Reedy) And FWIW, I suspect similar issues will break Flow, so not even attempting to fixup any of Flow u... [21:42:28] ^ If anyone has any bright ideas... [21:50:16] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3155367 (10kaldari) It's been a long time since I've looked at it. There is a some documentation at https://www.med... [21:52:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Add more values to test_stats - https://phabricator.wikimedia.org/T161767#3155375 (10Catrope) [21:53:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Add more values to test_stats - https://phabricator.wikimedia.org/T161767#3142283 (10Catrope) I've removed the recall asks for now because it doesn't look like we'... [22:20:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Add more values to test_stats - https://phabricator.wikimedia.org/T161767#3155441 (10Catrope) [22:42:13] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3155530 (10Reedy) Any help appreciated. Even more so if we can get someone else invested because they can use bug f... [23:08:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Add more values to test_stats - https://phabricator.wikimedia.org/T161767#3155623 (10Catrope) https://github.com/wiki-ai/editquality/pull/63 [23:18:10] 06Collaboration-Team-Triage, 10Flow, 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 13Patch-For-Review: Update zordius/lightncandy - https://phabricator.wikimedia.org/T121947#3155661 (10Reedy) [23:28:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3155769 [23:28:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Remove Category Changs vs. ORES from list of Conflict States - https://phabricator.wikimedia.org/T161325#3155768 (10jmatazzoni) 05Open>03Resolved [23:29:09] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Unstructured filters replaced by Structured filters may still affect the results - https://phabricator.wikimedia.org/T162158#3155770 (10Catrope) I think that's a good approach, because we do need the params to still work (for no-JS).