[00:22:49] mooeypoo, that remaining selenium error at https://gerrit.wikimedia.org/r/#/c/345779/ is pretty weird. [01:55:04] (03CR) 10Mooeypoo: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [02:02:00] (03CR) 10jerkins-bot: [V: 04-1] Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [02:56:37] 10MediaWiki-Watchlist, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#56845 (10Techman224) I would be interested in doing a GSOC 2017 project for adding multiple watchlists. Any possible mentors who would be willing to mentor me? [02:56:57] 10MediaWiki-Watchlist, 10Possible-Tech-Projects, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#3145667 (10Techman224) [06:11:45] (03CR) 10Mooeypoo: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [06:18:36] (03CR) 10jerkins-bot: [V: 04-1] Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [07:15:51] 06Collaboration-Team-Triage, 10Notifications: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3145760 (10Schnark) [08:22:09] 10MediaWiki-Watchlist, 10Possible-Tech-Projects, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#3145905 (10srishakatux) @Techman129 As the deadline for GSOC is fast approaching; it might be hard to recruit mentors. You could... [09:59:39] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Internet-Explorer: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3146206 (10Aklapper) [10:02:50] 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Remind me of this article in X days with the changes occured during the time period - https://phabricator.wikimedia.org/T161738#3146208 (10Trizek-WMF) >>! In T161738#3144259, @Ritwiksharma wrote: > @srisha... [10:08:41] 10MediaWiki-Watchlist, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#3146213 (10Aklapper) [10:51:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146278 (10tarlocesilion) [10:52:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3146292 (10tarloce... [10:52:07] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146291 (10tarlocesilion) [11:23:14] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3146330 (10Samwalton9) Actually - would it be possib... [11:27:39] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146278 (10Trizek-WMF) The idea would be then to use Patrolled edits and FlaggedRevisions validation systems. [11:30:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146351 (10tarlocesilion) Generally speaking, yes, although on Polish Wikipedia, it's about the FlaggedRevs only. We don't use Patrolled edits at... [12:01:43] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Internet-Explorer: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3145760 (10Aklapper) [12:03:46] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Internet-Explorer: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3146411 (10Hammersfan) Actually, this is also the case in Firefox [13:33:57] 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Remind me of this article in X days with the changes occured during the time period - https://phabricator.wikimedia.org/T161738#3146551 (10Ritwiksharma) @srishakatux Yes you are right.. Thanks for the help [13:34:15] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3146552 (10Hammersfan) [13:42:01] 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Create an ID of change when user asks for reminder of an article - https://phabricator.wikimedia.org/T161738#3146563 (10Ritwiksharma) [15:52:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 05MW-1.29-release-notes, 13Patch-For-Review: Special:RecentChangesLinked page does not have "No chang... - https://phabricator.wikimedia.org/T160482#3146844 [15:58:55] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: a "full" Echo flyout is too tall, has no space at bottom - https://phabricator.wikimedia.org/T71986#3146870 (10Aklapper) Hi @Rammanojpotla! Thanks a lot for your interest! Please see [[ https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_... [16:04:42] 06Collaboration-Team-Triage, 10Notifications: Notification list height shouldn't be hardcoded - https://phabricator.wikimedia.org/T73205#3146895 (10Aklapper) I assume so. [16:04:52] 06Collaboration-Team-Triage, 10Notifications: Notification list height shouldn't be hardcoded - https://phabricator.wikimedia.org/T73205#3146897 (10Aklapper) [16:04:55] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: a "full" Echo flyout is too tall, has no space at bottom - https://phabricator.wikimedia.org/T71986#3146900 (10Aklapper) [16:07:59] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: a "full" Echo flyout is too tall, has no space at bottom - https://phabricator.wikimedia.org/T71986#3146914 (10Aklapper) I cannot reproduce that problem in Firefox 51 anymore. Can anyone else? If yes, screenshot welcome (if no confidential da... [16:08:05] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146917 (10jmatazzoni) @Catrope, can this be done? If it can, why don't we, for example, let people know which edits had been reverted, which wou... [16:17:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146926 (10Trizek-WMF) I was thinking again on it. If someone reviews the edit and approves it, it is gone. What about the case when others don... [16:33:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement conflict state between Non-Minor Edits and Wikidata (and remove conflict between Minor Edits and Wikidata) - https://phabricator.wikimedia.org/T161665#3146988 (10SBisson) a:03SBisson [16:43:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3147027 (10Etonkovidova) @jmatazzoni Please confirm that... [17:29:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3147163 (10Trizek-WMF) >>! In T161888#3146926, @Trizek-W... [17:54:03] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147233 (10matmarex) [17:57:03] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, 07Browser-Support-Internet-Explorer: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147239 (10matmarex) Please upload a screenshot of the... [18:06:56] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 2 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147247 (10FriedhelmW) [18:10:29] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 2 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147257 (10matmarex) Okay, nevermind, I see it now. Please, always include a scr... [18:11:06] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 2 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147258 (10matmarex) All links between the two circled area seem unclickable. [18:12:42] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 2 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147261 (10matmarex) Similar problem in Firefox 3.6. The icons don't appear at a... [18:29:22] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 2 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147305 (10matmarex) It seems that the problem is caused by positioning with neg... [18:44:12] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 2 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147341 (10matmarex) p:05Triage>03Unbreak! a:03matmarex [18:44:21] (03PS1) 10Bartosz Dziewoński: Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) [18:51:03] (03CR) 10jerkins-bot: [V: 04-1] Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [18:54:41] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 3 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147350 (10matmarex) I'm still testing https://gerrit.wikimedia.org/r/345871 on... [18:58:01] (03CR) 10Bartosz Dziewoński: "That doesn't look like a real failure…" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [18:58:10] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:02:05] anyone of you folks around to help me get a fix for https://phabricator.wikimedia.org/T161869 deployed today? Echo badges are breaking the entire page on MonoBook on IE11. RoanKattouw? [19:03:58] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration, 06English-Wikipedia-New-Pages-Patrol: Page curation A11 speedy notification bug - https://phabricator.wikimedia.org/T161900#3147370 (10TonyBallioni) [19:04:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Damaging levels on Polish Wikipedia overlap too much - https://phabricator.wikimedia.org/T161655#3147372 (10Pginer-WMF) >>! In T161655#3141159, @jmatazzoni wrote:... [19:06:21] (03CR) 10jerkins-bot: [V: 04-1] Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:12:17] (03CR) 10Bartosz Dziewoński: "The mwext-mw-selenium-jessie job has been failing for a while. It also failed in e.g. these recent/pending changes: https://gerrit.wikimed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:12:45] (03CR) 10Bartosz Dziewoński: "I verified that this fixes the issue on IE 11 and Firefox 3.6, and doesn't introduce new issues in Edge, Chromium and modern Firefox." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:24:24] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147385 (10Adedayomatt) @Aklapper and @Mooeypoo please kindly take a second to review my draft proposal here https://docs.google.com/doc... [19:25:14] mooeypoo: anyone of you folks around to help me get a fix for https://phabricator.wikimedia.org/T161869 deployed today? Echo badges are breaking the entire page on MonoBook on IE11. [19:25:41] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147388 (10Mooeypoo) @Adedayomatt please post your proposal in the ticket itself. Please see https://www.mediawiki.org/wiki/Google_Summe... [19:26:17] O.o [19:26:29] MatmaRex, looking [19:27:13] (03PS1) 10Reedy: Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345874 (https://phabricator.wikimedia.org/T161869) [19:27:19] (03CR) 10Reedy: [C: 032] Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345874 (https://phabricator.wikimedia.org/T161869) (owner: 10Reedy) [19:28:27] mooeypoo: i was also taking to Reedy in #-releng before you responded. so it looks like he's doing it [19:28:34] mooeypoo: i'd still appreciate a review on it [19:28:55] Yeah, for the master part definitely [19:29:44] MatmaRex, I'm going to see if I can look at this patch through my windows machine, but I don't have vagrant there... can you remind me of that tool to create a temporary "tunnel" from my laptop? I forgot what that is [19:30:23] mooeypoo: http://localtunnel.me ? [19:30:38] that's the one [19:30:38] thanks [19:31:02] MatmaRex, that's a weird browser bug :\ [19:31:25] browsers got a lot better. only the weirdest bugs remain, heh. [19:31:33] the positioning of the badge + counter was a nightmare as it is... it's using ::before and ::after but needs to hide the rendered number but not display:none; it [19:31:50] but yeah, i always love it when a simple combinations of seemingly simple things doesn't work :/ [19:33:19] (03CR) 10jerkins-bot: [V: 04-1] Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345874 (https://phabricator.wikimedia.org/T161869) (owner: 10Reedy) [19:33:36] jerkins says no [19:33:42] Reedy: nevermind the tests, there's a broken non-blocking job in Echo [19:33:55] the gate-and-submit should pass [19:34:11] (that was the test) [19:34:54] wtf [19:36:47] (03Merged) 10jenkins-bot: Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345874 (https://phabricator.wikimedia.org/T161869) (owner: 10Reedy) [19:37:11] Reedy: see, it passed [19:37:18] h4x [19:37:23] magic [19:38:24] Fine to deploy then? [19:39:20] I'm confused -- should I merge the original? [19:39:41] I just tested - it works. Weirdest bug ever, but fix works... you cherry picked, but I should also merge the original? Or is the cherry pick enough? [19:40:13] Well, it needs fixing in master too [19:40:28] I was more interested in fixing production... Because it's not really a change I'm particularly qualified to review [19:40:35] * mooeypoo nods [19:40:44] +2ing now the master one [19:40:47] (03CR) 10jenkins-bot: Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345874 (https://phabricator.wikimedia.org/T161869) (owner: 10Reedy) [19:40:48] cool [19:41:11] (03CR) 10Mooeypoo: [C: 032] Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:46:49] 06Collaboration-Team-Triage, 10Notifications, 10MonoBook, 07Browser-Support-Firefox, and 3 others: Notifications overlap large area of content in Monobook skin with Internet Explorer - https://phabricator.wikimedia.org/T161869#3147412 (10matmarex) The fix should be live on all wikis now. I would appreciate... [19:50:56] (03Merged) 10jenkins-bot: Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:54:27] stephanebisson, can you tell me what setup caused the item={} to happen? [19:54:31] I can't manage to reproduce it [19:54:33] (03CR) 10jenkins-bot: Stop badge hacks from messing up the entire page on IE 11 on MonoBook [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345871 (https://phabricator.wikimedia.org/T161869) (owner: 10Bartosz Dziewoński) [19:54:46] mooeypoo: the wikidata-major conflict patch [19:54:55] stephanebisson, also, if the issue is conflict.item==={} then you should go with $.isEmptyObject() rather than !conflict.item ? [19:54:56] mooeypoo: https://gerrit.wikimedia.org/r/#/c/344451/ [19:55:15] meh, I don't have wikidata in vagrant. Is it just adding a role? [19:55:18] mooeypoo: you have to be setup to run wikibase [19:55:27] role 'wikidata' [19:55:48] just that ? RoanKattouw was complaining that it was a mess [19:55:50] I also have the role 'wikibase_repo' but I don't know if it's required [19:56:13] it is a bit of a mess, messages don't load for me now [19:59:54] ok, vagrant provision is taking forever [19:59:59] I'm going to go get lunch [20:00:00] bbiab [20:00:23] stephanebisson, before I go -- I want to investigate the root cause, but if this is dealing with an immediate bug, we should merge it as a fix [20:01:06] stephanebisson, my only concern is that if you're seeing conflict.filter as {} then !conflict.filter check won't help, you will need to check $.isEmptyObject() or instanceof or something -- butI can't reproduce so I am not sure [20:01:07] mooeypoo: yeah, but I think item was actually undefined, not {} [20:01:12] +1 just checking [20:01:14] MatmaRex: thanks for fixing that IE regression [20:01:42] stephanebisson, it looks like a good sanity test to have anyways, but I just want to make sure the result works right [20:02:14] mooeypoo: it does work, I couldn't do anything before this fix, but let me re-test [20:02:38] * mooeypoo nods [20:02:51] stephanebisson, if it works, then please just change the commit message [20:03:12] Handle conflict.item === {} should be Handle conflict.item === undefined [20:03:13] will do, right after I re-test [20:03:16] * mooeypoo nods [20:03:27] I'll +2 after you verify -- and then I'll check into the root cause [20:03:37] sounds good [20:03:46] bbiab [20:07:41] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147490 (10Adedayomatt) >>! In T161364#3147388, @Mooeypoo wrote: > @Adedayomatt please post your proposal in the ticket itself (here, ed... [20:09:38] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147505 (10Mooeypoo) You should be able to upload them here by drag/dropping the image into the editor. It'll produce a '{reference}' th... [20:13:09] mooey|lunch: nevermind, I can't reproduce it now [20:21:53] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147535 (10Adedayomatt) PROPOSAL FOR TASK “ARTICLE REMINDER” ON MEDIAWIKI Phabricator Task Link: https://phabricator.wikimedia.org/T1613... [20:25:44] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147538 (10Adedayomatt) p:05Lowest>03High [20:30:29] stephanebisson, O.o I'm actually a bit *more* worried now... [20:30:40] I'll see if I can reproduce and find the underlying cause [20:31:13] but if this is a risk or if it depends on some edge case that might occasionally happen, then adding the 'if exists' condition as sanity check might not be a bad idea [20:36:06] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147570 (10Adedayomatt) @Mooeypoo how is it now? [20:38:59] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147587 (10Aklapper) Feel free to click "Edit task" and improve readability by using [[ https://www.mediawiki.org/wiki/Phabricator/Help#... [20:39:47] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147588 (10Mooeypoo) @Adedayomatt awesome, thank you. @Mattflaschen-WMF and I will go over the proposal. Please also be aware that ther... [20:43:14] 06Collaboration-Team-Triage, 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3147594 (10Mooeypoo) Courtesy note - Please be aware that there are other students interested in this project, who posted proposals as child-tasks to the original {T2582} [20:44:20] 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Create an ID of change when user asks for reminder of an article - https://phabricator.wikimedia.org/T161738#3147596 (10Mooeypoo) @Ritwiksharma is this task meant as a GSoC/Outreachy proposal? [20:48:36] eh vagrant is taking so long to provision and now failed. I think I am stuck having to upgrade (or redo my vm) [20:48:50] I delayed it but seems like no more delaying [20:52:06] matt_flaschen, i'm backing up my 99-LocalSettings.php from settings.d/ [20:52:28] but other than that, assuming the only "weird" thing I have is cross-wiki notifs ... anything else I should back up before i destroy/remake my vagrant vm? [20:54:51] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3147629 (10Mattflaschen-WMF) Thank you for your application. It's great to see people interested. Even better than uploading the code... [20:55:27] mooeypoo, destroying it won't delete that any way. It will delete your wiki DB, which is a pain. You can dump to XML then re-import if you want. [20:57:06] Pretty certain it doesn't touch settings.d, but doesn't hurt to back it up. [20:57:24] setting.d/puppet-managed will be erased by the new vagrant up, though;. [21:09:40] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make ORES prediction disappear when the edit is reviewed - https://phabricator.wikimedia.org/T161888#3146278 (10Etonkovidova) Two things should be taken into account for pros and cons: - not discouraging newbies (and others) by prominently broa... [21:15:56] hm I can't find the instructions on destroying/rebuliding vagrant properly [21:17:00] bd808, your email says "Follow the instructions given to delete and recreate your VM" but I can't see which instructions are given? The linked phab ticket about 'known issues' seems to re-clone as a 'test' .. am I missing something? [21:17:53] matt_flaschen, ^ [21:18:24] is it just vagrant destroy? [21:22:42] mooeypoo: are you hitting the big about bad vagrant plugins? [21:24:19] To start a fresh vm, just do vagrant destroy-f; vagrant up. But know that will get rid of anything you've done on the wiki (wipes db) [21:25:12] bd808, yeah I want to do the upgrade - I delayed it forever, but now that I need to reprovision and i'm running into issues, I think it's time I stop delaying the inevitable :P [21:25:55] yeah that's fine -- I also saved my .bashrc from inside vagrant ssh, so I can have my scripts up [21:27:00] alright, let's bite the bullet [21:27:03] * mooeypoo destroys [21:27:47] * mooeypoo pulls vagrant master [21:28:13] hm, I have a dirty commit now for some reason [21:28:25] modified: puppet/modules/nginx (new commits) [21:28:29] untracked: puppet/modules/mariadb/ [21:28:44] bd808, should i continue with vagrant-up or git reset ? [21:29:27] why would I have a dirty commit after running 'git pull' at all [21:30:03] mooeypoo: rm the mariadb dir and git reset [21:30:34] The submodule was deleted [21:30:53] hm I still have [21:30:54] modified: puppet/modules/nginx (new commits) [21:30:59] after 'git reset --hard' [21:31:20] isn't that weird? if it's a modified dir/file shouldn't git reset take it off? [21:32:12] It's a submodule so reset doesn't fix it [21:32:34] You have to rm the leftover module first [21:33:24] gotcha [21:34:09] okay, clean commit now [21:34:42] running vagrant up. [22:10:45] bd808, I'm running into a huge red-wall of errors https://pastebin.com/cyunbnsi [22:27:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Make the old parts of the new RC form work in the same, ... - https://phabricator.wikimedia.org/T157594#3147747 [23:04:03] meh bd808 matt_flaschen I am now getting an error when logging in Exception from line 79 of /vagrant/mediawiki/extensions/CentralAuth/includes/specials/SpecialCentralLogin.php: Global user 'Admin' does not exist. [23:04:13] in login.wiki.local.wmftest.net [23:04:26] I remember having this problem a while back but not entirely sure how it was fixed. Any ideas? [23:04:31] mooeypoo, that shouldn't happen, but I'll give you the workaround. [23:04:39] You probably had a provisioning error or something. One sec. [23:04:40] the initial provision failed to migrate the admin user :/ [23:04:43] I had a bunch [23:04:51] https://pastebin.com/cyunbnsi <-- errors [23:05:00] try running `vagrant provision` again? [23:05:02] should I reprovision? [23:05:04] ok [23:05:29] mooeypoo, you can run migrateAccount directly. [23:05:33] I'll give you the command in a sec. [23:05:36] it looks like the apt server barfed [23:06:01] Failed to fetch https://apt.wikimedia.org/wikimedia/pool/experimental/e/elasticsearch/elasticsearch_5.1.2_all.deb GnuTLS recv error (-9): A TLS packet with unexpected length was received. [23:06:27] Darn it, NSA, we talked about this. [23:06:45] mooeypoo: [23:06:46] mwscript extensions/CentralAuth/maintenance/migrateAccount.php --wiki=wiki --auto --username Admin [23:08:09] matt_flaschen, I'm already re-provisioning... if that doesn't work, I'll run that [23:08:42] Sounds good. I have to go, I'll be back on later. [23:08:53] see ya later [23:18:33] same error after vagrant provision :\ [23:19:30] but it works now after matt_flaschen's fix [23:19:32] hm