[00:03:43] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3142582 (10Adedayomatt) >>! In T161364#3142577, @Mooeypoo wrote: >>>! In T161364#3142567, @Adedayomatt wrote: >> @Aklapper Alright. I go... [00:13:44] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3142584 (10Adedayomatt) Let me make myself explicit enough. What I am planning as my deliverable is sample webpage coded with html, php,... [00:25:02] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3142586 (10Mooeypoo) >>! In T161364#3142584, @Adedayomatt wrote: > Let me make myself explicit enough. What I am planning as my delivera... [00:46:26] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3142603 (10Adedayomatt) @Mooeypoo But I can't see any microtask here. [01:05:06] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3142620 (10Mooeypoo) >>! In T161364#3142603, @Adedayomatt wrote: > @Mooeypoo But I can't see any microtask here. That's because this is... [01:30:28] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 03Google-Summer-of-Code (2017): Article Reminder - https://phabricator.wikimedia.org/T161364#3142649 (10Adedayomatt) @Mooeypoo Thank you I appreciate your time. [02:29:50] 06Collaboration-Team-Triage, 10Flow: Add owner title variable for Flow AbuseFilter - https://phabricator.wikimedia.org/T161774#3142685 (10Mattflaschen-WMF) [02:30:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow: Add owner title variable for Flow AbuseFilter - https://phabricator.wikimedia.org/T161774#3142711 (10Mattflaschen-WMF) [02:37:47] (03PS1) 10Mattflaschen: Add owner titles to abuse filters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) [02:42:41] (03PS2) 10Mattflaschen: Add owner titles to abuse filters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) [02:44:22] 06Collaboration-Team-Triage, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#3142718 (10jayvdb) a:05darthbhyrava>03None [02:49:21] (03CR) 10jerkins-bot: [V: 04-1] Add owner titles to abuse filters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) (owner: 10Mattflaschen) [03:08:14] (03PS3) 10Mattflaschen: Add owner titles to abuse filters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) [05:13:10] 06Collaboration-Team-Triage, 10Notifications, 07I18n: Notification controls spill over in RTL wikis - https://phabricator.wikimedia.org/T161728#3141162 (10YonaB) thank you Catrope it is fixed in hewiki [05:23:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3142784 (10Etonkovidova) @SBisson Tested on cawiki-beta... [05:47:14] Hi guys, I tried all day to install MeaidWiki localy, but couldn't get over this one: getting an 503 error on my 127.0.0.1:8080. [05:47:59] the VM is running, but when I put the command vagrant up --provision I'm getting: "default: Error: Could not run: Could not find file /vagrant/puppet/manifests/site.pp The SSH command responded with a non-zero exit status." [05:48:11] any idea please? [06:43:00] 06Collaboration-Team-Triage, 10Notifications, 07I18n: Notification controls spill over in RTL wikis - https://phabricator.wikimedia.org/T161728#3142841 (10YonaB) It in still not fix on hewiki. [07:08:51] 06Collaboration-Team-Triage, 10Flow: Flow should preserve editbox text - https://phabricator.wikimedia.org/T161780#3142869 (10Tgr) [08:17:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: Add owner title variable for Flow AbuseFilter - https://phabricator.wikimedia.org/T161774#3143029 (10Trizek-WMF) Thank you @Mattflaschen-WMF. [08:57:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Review ORES prediction visibility on wikis where they are enabled by default - https://phabricator.wikimedia.org/T161706#3143087 (10Trizek-WMF) [09:08:51] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3143096 [09:09:56] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3143100 [09:12:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Review ORES prediction visibility on wikis where they are enabled by default - https://phabricator.wikimedia.org/T161706#3143104 (10Trizek-WMF) p:05Triage>03High [09:30:09] 06Collaboration-Team-Triage, 10Flow, 10GlobalRename, 10MediaWiki-extensions-CentralAuth, and 2 others: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572#3143132 (10Shizhao) [09:32:00] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: The document title should be dynamically updated to include a (n) notifications count in the browser title bar. - https://phabricator.wikimedia.org/T75209#3143135 (10Eee888) a:03Eee888 [09:45:06] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3143158 [09:45:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3033701 [09:58:32] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3143209 [10:20:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017): Ask Arabic Wikipedia about Flow beta activation - https://phabricator.wikimedia.org/T155720#3143230 (10Trizek-WMF) [10:21:08] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017): Ask Arabic Wikipedia about Flow beta activation - https://phabricator.wikimedia.org/T155720#2952188 (10Trizek-WMF) [10:21:25] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017): Ask Hebrew Wikipedia about Flow beta activation - https://phabricator.wikimedia.org/T155719#3143232 (10Trizek-WMF) [10:22:42] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice-collaboration: Ask communities which have allowed Flow trials with manual enabling to switch to Bet... - https://phabricator.wikimedia.org/T143470#3143247 [10:56:47] 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Remind me of this article in X days with the changes occured during the time period - https://phabricator.wikimedia.org/T161738#3143312 (10Aklapper) a:03Ritwiksharma [12:30:21] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3143434 (10Nioana) Good afternoon, I would like to apply for this project as part of GSoC '17, but I need... [12:56:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3143457 (10SBisson) >>! In T160475#3142784, @Etonkovidov... [14:21:15] 06Collaboration-Team-Triage, 10Notifications, 07Design, 07Easy: a "full" Echo flyout is too tall, has no space at bottom - https://phabricator.wikimedia.org/T71986#3143614 (10Rammanojpotla) I want to solve this issue Can anyone say me how to proceed(i.e how could it be modified) ? [14:54:04] 06Collaboration-Team-Triage, 10Notifications, 07I18n: Notification controls spill over in RTL wikis - https://phabricator.wikimedia.org/T161728#3143693 (10Catrope) Looks like that deployment was rolled back. When https://tools.wmflabs.org/versions/ says group1 has wmf.18, it'll be fixed on hewiki. That was s... [14:56:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3143696 (10Catrope) >>! In T160475#3143457, @SBisson wro... [15:06:23] (03PS4) 10Catrope: Add owner titles to abuse filters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) (owner: 10Mattflaschen) [15:06:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07Documentation: Add a section concerning notifications on Flow documentation - https://phabricator.wikimedia.org/T156246#3143708 (10Trizek-WMF) 05Open>03Resolv... [15:44:43] (03PS5) 10Catrope: Add owner titles to abuse filters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) (owner: 10Mattflaschen) [15:46:24] (03CR) 10Catrope: [C: 031] "I had to add a hook to get this to work, otherwise AF rejects my filter as a syntax error because it doesn't recognize the variable. Code " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345492 (https://phabricator.wikimedia.org/T161774) (owner: 10Mattflaschen) [16:00:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" b... - https://phabricator.wikimedia.org/T158458#3143861 [16:27:55] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 3 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3143935 [16:34:40] (03PS1) 10Esanders: Fix focus when switching to wikitext editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345605 [16:57:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3144192 (10SBisson) a:03SBisson [16:59:01] RoanKattouw: do you know why cawiki, hewiki still have 1.29.0-wmf.17 instead of group1 to 1.29.0-wmf.18 which is on the deployment page [16:59:31] RoanKattouw: I do not see anything in Blockers ticket https://phabricator.wikimedia.org/T160550 [17:01:00] from https://wikitech.wikimedia.org/wiki/Server_Admin_Log: 19:10 thcipriani@tin: rebuilt wikiversions.php and synchronized wikiversions files: group1 back to 1.29.0-wmf.17 [17:01:10] etonkovi_: ask thcipriani, i guess [17:01:40] MatmaRex: ok [17:01:59] there don't seem to be any more details there [17:03:42] etonkovi_: It was rolled back within 5 mins of deployment but I can't find why [17:04:16] RoanKattouw, standup? [17:08:44] 06Collaboration-Team-Triage, 10Notifications, 03Google-Summer-of-Code (2017), 10Outreachy (Round-14): Remind me of this article in X days with the changes occured during the time period - https://phabricator.wikimedia.org/T161738#3144259 (10Ritwiksharma) @srishakatux Hi!! , It is an addition to the task *... [17:16:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3144318 (10Trizek-WMF) >>! In T147054#3049182, @Pginer-WMF wrote: > {F5788770... [17:16:50] (03PS1) 10Esanders: Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 [17:21:29] https://www.irccloud.com/pastebin/Rz4QHxvg/ [17:21:36] RoanKattouw: The two UBNs under https://phabricator.wikimedia.org/T160550 weren't Resolved when the train was reverted. [17:23:36] 06Collaboration-Team-Triage, 10Notifications: Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3144375 (10Eee888) [17:41:55] mooeypoo: 'reset to default' button seems to work just fine [17:43:52] (03CR) 10Mooeypoo: [C: 032] Fix JS error when closing notification popup while animating a moving notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345175 (owner: 10Catrope) [17:47:16] (03CR) 10Catrope: [C: 032] Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 (owner: 10Esanders) [17:47:38] (03PS2) 10Catrope: Fix focus when switching to wikitext editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345605 (owner: 10Esanders) [17:47:44] (03CR) 10Catrope: [C: 032] Fix focus when switching to wikitext editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345605 (owner: 10Esanders) [17:47:51] (03PS2) 10Catrope: Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 (owner: 10Esanders) [17:48:10] (03CR) 10Catrope: Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 (owner: 10Esanders) [17:48:12] (03CR) 10Catrope: [C: 032] Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 (owner: 10Esanders) [17:53:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: userExpLevel=all doesn't work (logic assuming STRING_OPTIONS groups are full coverage) - https://phabricator.wikimedia.org/T161746#3144501 (10SBisson) [17:53:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, 13Patch-For-Review: Client should handle default for 'string_options' groups - https://phabricator.wikimedia.org/T160092#3144499... [17:55:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Make the old parts of the new RC form work in the same, ... - https://phabricator.wikimedia.org/T157594#3144505 [17:56:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: For Conflict States, short-circuit the fruitless searches so as to save processing effort - https://phabricator.wikimedia.org/T160220#3144507 (10jmatazzoni) p:05Triage>03High [17:56:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters - the highlight color selection box is not fully displayed at the bottom of viewport - https://phabricator.wikimedia.org/T160001#3144508 (10jmatazzoni) p:05Triage>03High [17:57:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Conflicting filters with 'Logged actions' load results extremely slow - https://phabricator.wikimedia.org/T161562#3144509 (10jmatazzoni) p:05Triage>03High [17:57:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Category changes' with 'Very likely have problems' are not marked with 'r' - https://phabricator.wikimedia.org/T161363#3144513 (10jmatazzoni) p:05Triage>03High [17:58:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Wikidata, 13Patch-For-Review: Add Wikidata to new RC Filters UI - https://phabricator.wikimedia.org/T159787#3144515 (10jmatazzoni) p:05Triage>03High [17:59:32] (03Merged) 10jenkins-bot: Fix JS error when closing notification popup while animating a moving notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345175 (owner: 10Catrope) [17:59:36] (03Merged) 10jenkins-bot: Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 (owner: 10Esanders) [17:59:37] (03Merged) 10jenkins-bot: Fix focus when switching to wikitext editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345605 (owner: 10Esanders) [17:59:51] (03CR) 10jenkins-bot: Fix focus when switching to wikitext editor [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345605 (owner: 10Esanders) [18:00:05] (03CR) 10jenkins-bot: Fix wikitext editor mini-toolbar to not use narrow mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345614 (owner: 10Esanders) [18:03:13] (03CR) 10jenkins-bot: Fix JS error when closing notification popup while animating a moving notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345175 (owner: 10Catrope) [18:08:49] My laptop won't recognize my HDMI monitor. It worked yesterday... [18:09:04] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3144563 (10Eee888) [18:09:06] 06Collaboration-Team-Triage, 10Notifications: Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3144562 (10Eee888) [18:26:53] matt_flaschen, RoanKattouw does mw.Api load automatically for gadgets or do we need to use mw.loader.using() ? [18:27:04] You have to depend on it [18:27:13] You can also list dependencies in the gadget definition [18:27:24] But using works just as well and also works in user scripts [18:27:28] well, it's in the user space, so it's not quite a gadget yet [18:30:03] Right, so use using for now [19:04:10] RoanKattouw, ignore on close for the popups is driving me mad. MAAAAD. [19:04:35] I'm going to have to reboot for a minute, but I could use a little help with it. All the popups are going fooey. [19:06:08] mooeypoo: OK call me when you're back [19:59:16] Getting lunch and going to try to buy a new HDMI cable. [20:08:33] have fun [20:08:40] Getting lunch too [20:42:36] 06Collaboration-Team-Triage, 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3145243 (10srishakatux) [20:43:56] 06Collaboration-Team-Triage, 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3144375 (10srishakatux) @Eee888 Thanks for your proposal! Could you change the title of this task to something which is more project-related? [21:01:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Add more values to test_stats - https://phabricator.wikimedia.org/T161767#3145294 (10Catrope) It looks like filter_rate is not the same as precision. Is there a wa... [21:02:00] (03CR) 10jerkins-bot: [V: 04-1] LoggerFactory is now namespaced, reference it properly [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345678 (https://phabricator.wikimedia.org/T161837) (owner: 10Chad) [21:02:10] (03Merged) 10jenkins-bot: LoggerFactory is now namespaced, reference it properly [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345678 (https://phabricator.wikimedia.org/T161837) (owner: 10Chad) [21:02:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345695 (owner: 10L10n-bot) [21:07:28] (03CR) 10jenkins-bot: LoggerFactory is now namespaced, reference it properly [extensions/Echo] (wmf/1.29.0-wmf.18) - 10https://gerrit.wikimedia.org/r/345678 (https://phabricator.wikimedia.org/T161837) (owner: 10Chad) [21:07:46] 06Collaboration-Team-Triage, 10Notifications, 05MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), 13Patch-For-Review, and 2 others: Class undefined: LoggerFactory in Event.php - https://phabricator.wikimedia.org/T161837#3145324 (10demon) 05Open>03Resolved a:03demon [21:12:44] 06Collaboration-Team-Triage, 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3145336 (10srishakatux) a:05Mooeypoo>03Eee888 [21:20:44] RoanKattouw, I have the weirdest annoying bug that you're going to LOVE [21:22:01] And by LOVE I really do mean <3 [21:22:53] RoanKattouw, so get this: You know how when we focus on the input, the widget scrolls up? well, when you click the *widget* itself (minus [x] on the items) then the input gets focused automatically and-- yes -- the entire widget goes up [21:23:10] Okay so far... except guess where the trash/reset-to-default icon is.... [21:23:27] * mooeypoo is thinking she needs to stopPropagation on mousedown for that button too [21:23:37] RoanKattouw, here's the part you're going to love [21:25:02] Since the 'reset' button is in the widget area, when you click it, it triggers the focus on the input which moves the widget up. That seems to run immediately before the click handler is called (understandably) so it scrolls the page ... but then the mouse is no longer in the position of the button, so now it seems like (at least 90% of the times - because sometimes it does work) the "mouseup" event that is part of the clicking [21:25:02] process is not ON that button [21:25:06] ... so the click isn't intercepted [21:25:22] so you click the trash, the widget scrolls up, but you need to then click the trash AGAIN to actually reset [21:25:52] stopPropagation for mousedown will probably work, but I found it an amusing bug that's right up your alley [21:30:13] RoanKattouw, I am running into a more relevant issue with clippable and the menu, though. (a) It doesn't seem to work at all now, and (b) the side scroll causes a button right-left scroll to show O.o [21:59:58] 06Collaboration-Team-Triage, 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3145454 (10Mooeypoo) Thank you for the proposal, @Eee888 ! The code looks good! After testing, I have tiny comments to add. I sent them to you, but here they are a little more... [22:06:55] (03PS1) 10Mooeypoo: Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 [22:07:20] matt_flaschen, RoanKattouw discovered due to Outreachy microtask ^ oopsies [22:08:23] (03PS2) 10Mooeypoo: Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 [22:16:43] (03CR) 10jerkins-bot: [V: 04-1] Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [22:17:34] 06Collaboration-Team-Triage, 10Notifications, 10Outreachy (Round-14): Outreachy Proposal - https://phabricator.wikimedia.org/T161823#3145498 (10Mooeypoo) Just as an FYI, this caused me to submit the fix to make sure the hook fires **after** the DOM actually changes: https://gerrit.wikimedia.org/r/#/c/345779/... [22:17:37] O.o what [22:22:08] (03PS3) 10Mooeypoo: Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 [22:28:32] (03CR) 10jerkins-bot: [V: 04-1] Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [22:34:52] what the hell, Jenkins [22:35:16] RoanKattouw, matt_flaschen any ideas if this is a valid failure!? it seems so weird that it would fail over this change and I can't figure out *what* is failing https://gerrit.wikimedia.org/r/#/c/345779/ [22:47:33] 06Collaboration-Team-Triage, 10Thanks, 10Pywikibot-Thanks, 10Pywikibot-core, 03Google-Summer-of-Code (2017): Implement Thanks support in Pywikibot - https://phabricator.wikimedia.org/T161426#3145538 (10happy5214) [23:00:55] RoanKattouw, \o/ got the clippable to work... had to specify a different $clippable and $clippableContainer which seemsto not be described well in the docs [23:06:09] mooeypoo, yeah, there are several bogus (unrelated) errors, there, looks like: [23:06:12] 22:25:49 oojs/oojs-ui: 0.20.2 installed, 0.20.1 required. [23:06:14] 22:25:49 Error: your composer.lock file is not up to date. Run "composer update" to install newer dependencies [23:06:33] IIRC this happens every week, maybe you got the wrong time. [23:07:18] (03CR) 10Mattflaschen: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [23:07:31] mooeypoo, that's from https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm-jessie/9541/console . [23:07:42] I figured it might be temporary, but it happened again after I submitted another tiny fix [23:07:52] hm there was also sometihing with unable to load something [23:13:06] Yeah that failure will be because Volker is doing an OOUI releaes [23:14:24] ahh [23:14:28] okay, that explains it [23:14:57] RoanKattouw, read the scrollback re the bug - you'll be amused [23:15:14] Yeah :D [23:15:27] (03CR) 10jerkins-bot: [V: 04-1] Fire 'ext.echo.badge.countChange' after DOM changes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345779 (owner: 10Mooeypoo) [23:17:45] It's always fun when your click runs away from you :P [23:18:11] RoanKattouw, as for the other clippable bug -- I am not sure if clippable and clippableContainer are supposed to be so distinctly given, but that solved it. [23:18:26] Sometimes they do [23:18:45] Three's a different issue, sorry, let me be more precise - $clippableContainer is supposedly what you give it in config OR this.$element [23:19:04] One is the thing that needs to be made scrollable and have its height limited, and the other is the thing that needs to not go out of the screen/container [23:19:14] The latter being equal to or an ancestor of the former [23:19:20] right [23:19:27] but it sets itself to either the config or this.$element [23:19:28] I forget which is which but I think the former is $clippableContainer and the latter is $clippable [23:19:37] Yes [23:19:40] in the constructor of ClippableElement: this.setClippableElement( config.$clippable || this.$element ); [23:19:41] right [23:20:28] err sory, the $clippableContainer in the constructor is set to nothing, but then clip() either takes it OR the $clippable [23:21:11] ok, I understand my bug now. Anyways, I do this.setClippableElement( this.$group ); so we can have a header/footer in the menu [23:21:19] what I needed to add was also this.setClippableContainer( this.$element ); [23:21:24] Right [23:21:28] That fixed it. [23:21:33] Cause $clippableContainer defaults to $clippable [23:21:37] * mooeypoo nods [23:21:47] I can actually just pass it to the container, now that I think about it [23:21:47] You only need them to be different if you have a header/footer-style setup [23:21:56] I can't the $clippable, because that is overridden [23:22:01] yeah [23:37:44] RoanKattouw, hm, gerrit recognized some of the files as renames (yay) but some not (boo) so the review might be confusing https://gerrit.wikimedia.org/r/#/c/344997/