[01:05:08] 06Collaboration-Team-Triage, 10Flow, 07Performance: Reduce time to first byte - https://phabricator.wikimedia.org/T63694#659143 (10Krinkle) Seems like this should be closed given it cannot reasonably be resolved? Note that: # Browsers do stream-parse, which means as long as the HTML is fast to generate, the... [01:05:37] 06Collaboration-Team-Triage, 10Flow, 06Performance-Team: Reduce time to first byte - https://phabricator.wikimedia.org/T63694#3136030 (10Krinkle) [02:28:44] (03CR) 10Krinkle: [C: 031] Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [02:39:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab - https://phabricator.wikimedia.org/T159763#3136107... [07:45:13] (03CR) 10WMDE-leszek: "Thanks Sbisson!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [07:45:56] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 03Wikidata-Sprint: Edits in WikibaseLexeme cause odd failures in MWEchoThankYouEditTest::testFirstEdit - https://phabricator.wikimedia.org/T161087#3136288 (10WMDE-leszek) 05Open>03Resol... [08:12:43] 06Collaboration-Team-Triage, 10MediaWiki-ContentHandler, 07Schema-change: Add index to page.page_content_model - https://phabricator.wikimedia.org/T103389#3136334 (10jcrespo) > A large amount (much more than 30%) have 'wikitext' content model. Then an index there will not be useful in most cases (it will no... [09:19:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): Consider how to best inform anonymous users that their edit has been actively deferred - https://phabricator.wikimedia.org/T156083#3136449 (10MGChecker) I really like this feature especially for wikis which have unreviewed changes by default, because it... [09:42:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3136505 (10Trizek-WMF) [09:42:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Add screenshots to the help pages for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3136503 (10Trizek-WMF) 05Open>03Resolved >>! In T161015#3134550, @jmatazzon... [09:52:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Schema-change: hidebyothers extremely slow for logged in users - https://phabricator.wikimedia.org/T161557#3136508 (10jcrespo) > What do you think about adding an index to recentchanges on r... [10:35:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3136576 (10SBisson) [11:14:08] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3136649 (10TheDJ) I'm pretty sure I remember that @Volker_E has created a mixin specifically for these kinds of strings. [11:23:53] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3136669 (10matmarex) Yes, we have `.mixin-screen-reader-text()`, but that won't work well here. To elaborate, we have a structure like this (which wou... [13:19:39] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Notice: Undefined index: time in extensions/Flow/includes/Formatter/AbstractFormatter.php - https://phabricator.wikimedia.org/T161594#3136783 (10Aklapper) -> #Flow [13:23:00] (03CR) 10Catrope: [C: 032] Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [13:32:02] 06Collaboration-Team-Triage: Broken style for mobile - https://phabricator.wikimedia.org/T161604#3136807 (10Ejb1123) [13:32:58] (03Merged) 10jenkins-bot: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [13:35:06] (03CR) 10jenkins-bot: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [13:36:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Portuguese Wikipedia about testing ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T156157#3136838 (10Trizek-W... [13:37:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3136839 (10Trizek-... [13:53:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice: Announce and follow up with communities about the New Filters for Rece... - https://phabricator.wikimedia.org/T146972#3136873 [13:54:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Announce and follow up with community group 1 about the ... - https://phabricator.wikimedia.org/T158336#3136874 [13:54:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3136875 [13:54:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Announce and follow up with communities group 3 about th... - https://phabricator.wikimedia.org/T158333#3136876 [13:54:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Announce and follow up with communities group 4 about t... - https://phabricator.wikimedia.org/T158335#3136877 [13:58:27] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice-collaboration: Announce and follow up with communities group 4 about th... - https://phabricator.wikimedia.org/T158335#3136883 [13:58:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), 07User-notice-collaboration: Announce and follow up with communities group 3 about th... - https://phabricator.wikimedia.org/T158333#3136884 [13:59:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Apr-Jun 2017), and 2 others: Announce and follow up with communities group 2 about the New Filters for... - https://phabricator.wikimedia.org/T158332#3136885 [16:14:18] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3127964 (10Etonkovidova) Note: For testing after the fix - the both tooltips are presently visible depending on the position of the pointer (the tool... [16:16:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225#3137460 (10Jdforrester-WMF) 05Open>03Resolved [16:16:53] 06Collaboration-Team-Triage, 10Flow: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#3137462 (10Jdforrester-WMF) a:05Catrope>03None [16:17:41] 06Collaboration-Team-Triage, 10Flow, 07Chinese-Sites, 05Goal: Track more wikis in the Edit Beta enables graph for Flow - https://phabricator.wikimedia.org/T142083#3137463 (10Jdforrester-WMF) [16:19:28] 06Collaboration-Team-Triage, 10Flow, 07Chinese-Sites, 05Goal: Track more wikis in the Edit Beta enables graph for Flow - https://phabricator.wikimedia.org/T142083#2522066 (10Jdforrester-WMF) 05Open>03Resolved This has been done for a while now: https://edit-analysis.wmflabs.org/beta-enables/#empty [16:20:28] 06Collaboration-Team-Triage, 10Flow: Remove usernames blocked at will from the mention search on Flow. - https://phabricator.wikimedia.org/T114467#3137480 (10Jdforrester-WMF) a:05Catrope>03None [16:21:34] (03PS1) 10Catrope: Position badge text off-screen instead of making it transparent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345173 (https://phabricator.wikimedia.org/T161302) [16:23:01] 06Collaboration-Team-Triage, 10Flow: Allow config of archive page title formats for LQT conversion using MediaWiki namespace config page - https://phabricator.wikimedia.org/T117616#3137503 (10Jdforrester-WMF) a:05Catrope>03None [16:23:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07Documentation: Document technical aspects of cross-wiki notifications (for non MediaWiki-Vagrant users) - https://phabricator.wikimedia.org/T125728#3137507 (10Jdforrester-WMF) a:05Catrope>03None [16:24:18] 06Collaboration-Team-Triage, 10Notifications: Scrolling on the Echo survey's popup/tooltip - https://phabricator.wikimedia.org/T132384#3137511 (10Jdforrester-WMF) a:05Catrope>03None [16:24:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Thanks: ApiRevThankIntegrationTest broken - https://phabricator.wikimedia.org/T151878#3137512 (10Jdforrester-WMF) a:05Catrope>03None [16:25:14] (03PS1) 10Catrope: Fix JS error when closing notification popup while animating a moving notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345175 [16:25:35] 06Collaboration-Team-Triage, 10Flow, 06Community-Liaisons, 07User-notice: Flow's VE toolbar v2 - https://phabricator.wikimedia.org/T93243#3137514 (10Jdforrester-WMF) a:05Catrope>03None [16:26:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3137517 (10Catrope) a:03Catrope [16:29:12] (03CR) 10jerkins-bot: [V: 04-1] Position badge text off-screen instead of making it transparent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345173 (https://phabricator.wikimedia.org/T161302) (owner: 10Catrope) [16:29:37] (03PS1) 10Bartosz Dziewoński: Make the invisible text in badges really invisible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345176 (https://phabricator.wikimedia.org/T161302) [16:30:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3137556 (10matmarex) Uh, whoops, apparently I decided to work on this at exactly the same time. Pl... [16:31:27] (03Abandoned) 10Bartosz Dziewoński: Make the invisible text in badges really invisible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345176 (https://phabricator.wikimedia.org/T161302) (owner: 10Bartosz Dziewoński) [16:32:00] (03CR) 10Bartosz Dziewoński: Position badge text off-screen instead of making it transparent (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345173 (https://phabricator.wikimedia.org/T161302) (owner: 10Catrope) [16:32:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab - https://phabricator.wikimedia.org/T159763#3137565... [16:38:32] (03CR) 10Catrope: Position badge text off-screen instead of making it transparent (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345173 (https://phabricator.wikimedia.org/T161302) (owner: 10Catrope) [16:38:36] (03Restored) 10Catrope: Make the invisible text in badges really invisible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345176 (https://phabricator.wikimedia.org/T161302) (owner: 10Bartosz Dziewoński) [16:39:10] (03Abandoned) 10Catrope: Position badge text off-screen instead of making it transparent [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345173 (https://phabricator.wikimedia.org/T161302) (owner: 10Catrope) [16:39:29] (03CR) 10Catrope: [C: 032] Make the invisible text in badges really invisible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345176 (https://phabricator.wikimedia.org/T161302) (owner: 10Bartosz Dziewoński) [16:40:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 13Patch-For-Review: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3137641 (10Catrope) >>! In T161302#3137556, @matmarex wrote: > Uh, whoops, apparently I decided to... [16:49:16] (03Merged) 10jenkins-bot: Make the invisible text in badges really invisible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345176 (https://phabricator.wikimedia.org/T161302) (owner: 10Bartosz Dziewoński) [16:55:59] (03CR) 10jenkins-bot: Make the invisible text in badges really invisible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345176 (https://phabricator.wikimedia.org/T161302) (owner: 10Bartosz Dziewoński) [17:14:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Schema-change: hidebyothers extremely slow for logged in users - https://phabricator.wikimedia.org/T161557#3137796 (10Catrope) Also note that this only works because the index is on `(rc_use... [17:36:47] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] All rclinks have the same tooltip 'Special:RecentChanges' - https://phabricator.wikimedia.org/T161176#3137852 (10Catrope) [17:38:30] 06Collaboration-Team-Triage, 10Notifications: Use oojs-ui - https://phabricator.wikimedia.org/T161353#3129503 (10Catrope) Could you be more specific? Which widgets are non-standard? Which ones would you suggest be used instead? [17:43:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] All rclinks have the same tooltip 'Special:RecentChanges' - https://phabricator.wikimedia.org/T161176#3123697 (10jmatazzoni) Let's figure out if we broke this. If we did, let's fix. If we didn't, maybe just get rid of all the tooltips. [17:45:01] 06Collaboration-Team-Triage, 10Notifications: InvalidArgumentException from line 85 of ResourceLoaderImage.php: Invalid file type for image files of 'edit' (valid: svg, png, gif, jpg) - https://phabricator.wikimedia.org/T161419#3137889 (10Catrope) Did you also upgrade the Thanks extension? [17:46:14] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-ResourceLoader, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), and 2 others: Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45 - https://phabricator.wikimedia.org/T161420#3137894 (10Catrope) 05Open>03Resolved... [17:51:01] etonkovi_, RoanKattouw, yeah, I tried to get the dispatch working on Beta Cluster. You're supposed to be able to use dispatchChanges.php (from the Wikibase extension), but it didn't work. [17:54:53] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: ORES thresholds and overlaps optimization - https://phabricator.wikimedia.org/T161275#3137937 (10jmatazzoni) [17:56:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC page filters show incorrect results if user terminates the session in different tab - https://phabricator.wikimedia.org/T161021#3137942 (10Catrope) 05Open>03declined [17:57:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Category changes' with 'Very likely have problems' are not marked with 'r' - https://phabricator.wikimedia.org/T161363#3137947 (10Catrope) [17:57:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3137948 (10Catrope) [17:57:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - 'Category changes' with 'Very likely have problems' are not marked with 'r' - https://phabricator.wikimedia.org/T161363#3129934 (10Catrope) [17:57:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104020 (10Catrope) [18:19:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3138046 [18:28:07] Well done, team: https://www.mediawiki.org/w/index.php?title=Wikimedia_Engineering/2016-17_Q3_Goals&diff=2432753&oldid=2432685 :-) [18:49:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC page filters show incorrect results if user terminates the session in different tab - https://phabricator.wikimedia.org/T161021#3138126 (10Etonkovidova) Re-checked on plwiki - as far as I could see, the user sess... [18:59:41] 06Collaboration-Team-Triage, 10Flow: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3138149 (10Catrope) It looks like this icon was deleted from oojs-ui in {f6a4b3c13793b087b7c2a8972d28d7de4b61c1c9} . I'll put it back in Flow f... [19:08:37] (03PS1) 10Catrope: Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) [19:09:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3138181 (10Catrope) [19:16:53] (03CR) 10jerkins-bot: [V: 04-1] Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [19:17:24] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] All rclinks have the same tooltip 'Special:RecentChanges' - https://phabricator.wikimedia.org/T161176#3123697 (10Catrope) It looks like this has always been this way, or if it's a recent change it might have been caused by the LinkRender... [19:19:35] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Notice: Undefined index: time in extensions/Flow/includes/Formatter/AbstractFormatter.php - https://phabricator.wikimedia.org/T161594#3136453 (10Catrope) I'd be happy to try to fix this, but do you by any chance have a backtrace? It looks like some... [19:22:01] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] All rclinks have the same tooltip 'Special:RecentChanges' - https://phabricator.wikimedia.org/T161176#3123697 (10Mattflaschen-WMF) We didn't change this; it's default behavior for all links. We could also add custom tooltips if we want. [19:29:14] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: [minor] All rclinks have the same tooltip 'Special:RecentChanges' - https://phabricator.wikimedia.org/T161176#3138216 (10Mattflaschen-WMF) >>! In T161176#3138205, @Catrope wrote: > It looks like this has always been this way, or if it's a recent... [19:42:07] mooey|lunch: https://gerrit.wikimedia.org/r/#/c/345175/ [19:44:11] (03PS2) 10Catrope: Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) [19:44:39] mooey|lunch: https://gerrit.wikimedia.org/r/#/c/345200/ [19:49:57] (03CR) 10jerkins-bot: [V: 04-1] Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [19:50:51] (03CR) 10Mattflaschen: Add icon for "Newest topics" back (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [19:51:25] (03PS3) 10Mattflaschen: Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [19:51:32] (03CR) 10Mattflaschen: [C: 032] Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [19:53:35] matt_flaschen: Thanks, I thought Jenkins was asking me to *remove* spaces. I originally had url( foo); or somtehing [19:54:37] No problem [20:00:48] (03Merged) 10jenkins-bot: Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [20:01:04] (03CR) 10jenkins-bot: Add icon for "Newest topics" back [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345200 (https://phabricator.wikimedia.org/T161233) (owner: 10Catrope) [20:05:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3125909 (10Volker_E) Eurgh, that's what T141801 was intended for to provide us broad overvi... [20:08:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3138306 (10Etonkovidova) I ran the final check on ptwiki... [20:45:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345230 (owner: 10L10n-bot) [21:05:17] (03CR) 10Paladox: "Thanks." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [21:34:03] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Make Tag filter usage user friendly - https://phabricator.wikimedia.org/T161650#3138497 (10Etonkovidova) [21:35:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Make the old parts of the new RC form work in the same, ... - https://phabricator.wikimedia.org/T157594#3138509 [21:45:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 13Patch-For-Review: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3138547 (10Etonkovidova) Checked the... [21:46:18] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-ResourceLoader, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 07Technical-Debt: Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45 - https://phabricator.wikimedia.org/T161420#3138549 (10Paladox) [22:08:46] RoanKattouw, I know what happens (my styles aren't loading!) I have no idea *why* it happens. the hell. [22:17:05] Sigh, the tagfilter input has class="mw-ui-input", but the style for that is in mediawiki.ui.input which is not loaded on RC, EXCEPT if your wiki has a gadget that depends on it in which case it does [22:18:58] Just more messes, nothing to see here [22:21:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Damaging levels on Polish Wikipedia overlap too much - https://phabricator.wikimedia.org/T161655#3138654 (10jmatazzoni) [22:29:17] RoanKattouw, I hereby officially wave the "help me" flag [22:29:22] I can't figure out why my styles aren't loading [22:29:37] the demos work, so it's not ooui messup [22:29:42] it's not *loading* [22:29:44] the hell [22:31:58] mooeypoo: OK, done with my meeting [22:32:13] Yeah it's weird that your styles aren't being loaded [22:32:28] You're on PS13 of your patch, right? [22:32:33] I'll download that and see what I get [22:32:58] no I'm on master [22:33:02] err not master -- latest [22:33:10] since it wasn't an ooui error, I went back to latest patch [22:33:12] the demos load fine [22:33:17] it's not the OOUI thing [22:33:48] ooui demos look good -- but the rcfilter patch shows the tagItemWidgets as display:block instead of inline-block and has zero styling [22:33:56] it seems to not load the styles at all! [22:34:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 10Revision-Scoring-As-A-Service-Backlog: Damaging levels on Polish Wikipedia overlap too much - https://phabricator.wikimedia.org/T161655#3138684 (10jmatazzoni) p:05Triage>03High [22:34:30] or rather, it loads a little of it or something... it styles some of the rcfilter-side stuff, no ooui styles [22:34:39] Ooh, a sneaky error while I ran grunt build: >> Local Npm module "grunt-string-replace" not found. Is it installed? [22:34:50] So you might want to try running npm install and then rebuilding [22:34:59] Not sure what impact missing that module has [22:35:13] ok, doing that now [22:35:28] that's weird though - why would that make things work in the demos and not in mw [22:35:56] Yeah I'm not saying that's it [22:36:00] RoanKattouw, still the same error [22:36:13] I finished building, now loading in the browser [22:36:16] this is so frustrating :\ I can't find why it won't load [22:36:19] And I'm on PS13 of the OOUI patch [22:36:49] I'm on latest, but ok [22:36:54] it doesn't seem to matte,r I had the error on either [22:37:11] also, it seems like it loads the rcfilter styles but not the ooui ones... I rebased the rcfilter patch, too [22:37:16] what in the hell. [22:37:36] It's not even showing those styles as being overridden in the console/inspector [22:37:39] they're just not *there* [22:37:53] It's working for me, not sure what's wrong on your end [22:38:20] can you try it with latest patch ooui ? [22:38:25] Will do that next [22:38:30] In the meantime, please do this as a sanity check: [22:38:36] It didn't for me on either ps13 or latest, but... [22:38:51] also, I rebooted since we talked (my computer was crawling) so it shouldn't even be cache or anything [22:38:59] cd path/to/mediawiki/core/resources/lib/oojs-ui ; git diff; type "/tagMulti" tell me if that takes you to a part of the diff where tagMultiSelect styles are being added [22:39:57] it takes me to the js [22:40:01] looking for the less files now [22:40:35] images.... [22:40:47] RoanKattouw, negative. no less files!!! [22:41:01] OK, well then your mwooui script is doing something weird [22:41:25] resources/lib/oojs-ui/oojs-ui-widgets-mediawiki.css should contain tagMulti styles [22:41:32] just now? it worked before [22:41:33] checking [22:41:35] So check if it does [22:41:45] nope [22:41:51] And then check if dist/oojs-ui-widgets-mediawiki.css in the OOUI repo contains them [22:41:53] but it exists! [22:42:44] RoanKattouw, indeed, that does include them [22:42:50] my mwooui failed me [22:42:53] Right, so copy the dist one to resources/lib [22:42:57] mwooui should have done that [22:43:25] that would be because I didn't even copy that [22:43:30] why is it failing just now though [22:43:34] this is what I've used for all this time [22:44:03] RoanKattouw, https://pastebin.com/H8PAyRF9 [22:44:26] ha [22:44:40] I guess you never modified src/themes/mediawiki/widgets.less much then [22:44:54] ... I... thought I did [22:45:04] actually, that's not good if I didn't [22:45:15] omg I didn't [22:45:26] no I mean the mediawiki/widgets.less is edited [22:45:36] but not the general styles/widgets.less [22:45:37] ha [22:47:33] RoanKattouw, I do run into a WEIRD problem with the menu [22:47:45] with the header, to be precise. [22:48:30] I mean, in order for you to not have noticed this bug in mwooui before, you must not often have made changes to the theme styles [22:49:07] Do you have a second for a quick (seriously, quick this time) hangout? [22:49:21] yeah i didn't [22:50:44] RoanKattouw, the clippable element in the menu is the group, but the header is outside the group, so it doesn't get the width of the popup of the menu [22:51:08] That's because the way you're setting width is broken anyway, as I said in my Gerrit comment [22:51:10] I am so confused about which part of the menu is the FloatableElement and which is clippable [22:51:15] oh [22:51:22] * mooeypoo looks again [22:51:34] The non-clippable part of the menu has full width, and has a border all the way along its bottom and blocks clicks (including click-to-dismiss because it's in $autoCloseIgnore) [22:52:01] clippable = the part that can adjust its width/height if there is not enough space [22:52:03] right, well, i can't set it as the clippable -- the "body" of the menu (the $group) needs to be [22:52:10] floatable = the part that needs to be positioned relative to something else [22:52:16] Sure [22:52:22] But then force the width on something higher [22:52:31] But the clippable has to know the width otherwise it overrides it [22:52:41] Or, /also/ force the width on something higher [22:52:44] The FloatingMenu* rather [22:52:46] hm [22:56:43] RoanKattouw, did you say what you thnk caused the indicator to appear weird? [22:56:50] Yes [22:56:51] I think it was during my frustration + not loading anything [22:57:04] I gave you two bits of CSS [22:57:15] One, you need to make the menu z-index: auto; to override z-index: 4; from MenuSelectWidget [22:57:41] That's done [22:58:02] something also in oo-ui-indicatorElement-indicator [22:58:06] in the highlight button [22:58:11] The other is, the indicator gets absolutely positioned because it's indirectly inside of a DecoratedOptionWidget, so you either need to fix that style in OOUI to use > , or set position: static; on .oo-ui-indicatorElement-indicator inside of the highlight button [22:58:35] oh that's right [23:18:21] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/345264/ [23:23:10] 06Collaboration-Team-Triage, 10Notifications: Use oojs-ui - https://phabricator.wikimedia.org/T161353#3138850 (10Isarra) [23:23:13] 06Collaboration-Team-Triage, 10Notifications, 10OOjs-UI, 07Technical-Debt: Kill badgeicons.json and use OOUI's icons-alerts.json instead - https://phabricator.wikimedia.org/T139779#3138853 (10Isarra) [23:23:21] 06Collaboration-Team-Triage, 10Notifications: Use oojs-ui - https://phabricator.wikimedia.org/T161353#3129503 (10Isarra) Sorry, forgot I also filed this one. [23:27:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Add session ID to filter usage and highlight usage data - https://phabricator.wikimedia.org/T160928#3115313... [23:34:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3138901 [23:59:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement conflict state between Non-Minor Edits and Wikidata (and remove conflict between Minor Edits and Wikidata) - https://phabricator.wikimedia.org/T161665#3138949 (10jmatazzoni) [23:59:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3111436