[07:23:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3132952 (10Trizek-WMF) Are the programs independents... [08:12:39] 06Collaboration-Team-Triage, 10Notifications: Provide notifications as RSS/Atom feed - https://phabricator.wikimedia.org/T161487#3133013 (10Schnark) [09:20:35] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3133134 (10Trizek-WMF) Okay. Then, have the same mes... [09:21:49] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3133136 (10Samwalton9) I think it would be preferabl... [09:25:36] 06Collaboration-Team-Triage, 10Notifications: Provide notifications as RSS/Atom feed - https://phabricator.wikimedia.org/T161487#3133141 (10Aklapper) p:05Triage>03Lowest [10:12:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: When pressing esc key the search field should lose the input focus - https://phabricator.wikimedia.org/T161493#3133264 (10Pginer-WMF) [10:14:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: When pressing esc key the search field should lose the input focus - https://phabricator.wikimedia.org/T161493#3133282 (10Pginer-WMF) a:05jmatazzoni>03None [14:02:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Release strategy for RC page improvements: what wikis get the new features when? - https://phabricator.wikimedia.org/T150715#3133966 (10Trizek-WMF) [14:02:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: banners for help pages directing users to either the beta help or the old RC Page help - https://phabricator.wikimedia.org/T147054#3133967 (10Trizek-WMF) [14:02:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 07Documentation, 05Goal: Create and maintain Edit Review Improvements documentation - https://phabricator.wikimedia.org/T145875#3133968 (10Trizek-WMF) [14:02:54] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Tracking: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#3133969 (10Trizek-WMF) [14:02:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3133964 (10Trizek-WMF) 05Open>0... [14:03:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3133970 (10Trizek-WMF) 05Open>03Resolved Joe's screenshots have been integrated. [14:03:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3133972 (10Trizek-WMF) [15:14:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Good faith test does not work properly - https://phabricator.wikimedia.org/T161250#3134106 (10jmatazzoni) 05Open>03Resolved [16:52:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3134550 (10jmatazzoni) [16:54:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118638 (10jmatazzoni) @Trizek-WMF, I see the illustrations on the Highlighting and ORES filte... [16:55:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3134573 (10jmatazzoni) [16:55:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3134572 (10jmatazzoni) 05Resolved>03Open [16:55:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Add screenshots to the help pages for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118638 (10jmatazzoni) [17:03:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Add screenshots to the help pages for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3134626 (10jmatazzoni) @Trizek-WMF, looking at the images on the page, they are... [18:36:51] matt_flaschen: I still do not see Tag filter working :( even in production Unless there is some trick, like entering in tags in parentheses, quotes or something ... [18:37:04] etonkovidova, checking now. [18:37:11] matt_flaschen: thx [18:40:04] etonkovidova, it's working for me: [18:40:06] E.g. https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=mobile+edit [18:40:13] You have to get the capitalization right. [18:41:36] matt_flaschen: hmm... [18:42:45] matt_flaschen: perfect - it works without capitalization, although the tag is, in fact 'Mobile edit'. [18:43:22] matt_flaschen: looks like a usability issue to me :) [18:43:45] etonkovidova, no, it's 'mobile edit', but I agree it's very confusing. [18:43:47] See https://en.wikipedia.org/w/index.php?title=Special:Tags . [18:43:57] I feel like it used to show the real tag name, but I could be wrong. [18:44:19] They're not even all lower-case. e.g. HHVM. [18:44:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Add screenshots to the help pages for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3134985 (10jmatazzoni) @Trizek-WMF, I figured out how to add the full-resolutio... [18:45:44] matt_flaschen: and Section blanking and Possible vandalism etc - and nobody complained about it! [18:46:35] etonkovidova, if you go to Special:Tags, there are links you can follow. So people are probably using those, or bookmarking them. [18:48:07] matt_flaschen: probably - yes. To me it looks like a standard practice to disregard capitalzation in search term (unlessuser specifically match case). Aand out Tag filter box de-facto - a search box [18:48:39] matt_flaschen: and user see Tag names in different case written by the edits displayed -argh [18:56:47] RoanKattouw, I noticed we're doing hidemyself/hidebyothers with rc_user for logged in, not sure if it's a problem in practice, though. [18:57:03] 06Collaboration-Team-Triage, 10Flow: Have Flow support __INDEX__ and __NOINDEX__ per-page directives - https://phabricator.wikimedia.org/T122252#1899561 (10Amire80) Not rushing, I'll just mention that this came up a couple of times in the Hebrew Wikipedia as a desired feature. [18:57:05] RoanKattouw, queries seem quick, but maybe it would be an issue combined with other filters. Think I should file a bug? [18:57:22] There is no index on rc_user. [18:58:00] ^ stephanebisson [19:02:38] RoanKattouw, your assistance will be appreciated (see hangout) [19:04:29] matt_flaschen: I think the anon/liu thing is fine because they each match ~50% of rows [19:04:40] So resolving that with the index is reasonably efficient [19:05:35] If you want to get 50 rows for anons, you only have to examine ~100 rows before you find 50 anons, you just discard the rest [19:09:05] 06Collaboration-Team-Triage, 10Flow: New editor switcher stays enabled during save - https://phabricator.wikimedia.org/T161552#3135029 (10SBisson) [19:09:34] But if you're looking for a single user, then it's not 50-50 at all [19:09:49] And you'd have to examine lots of rows before you find 50 that match that user [19:11:55] So indexes are only really needed when you have many values that each represent a small %age of the rows [20:31:46] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: hidebyothers extremely slow - https://phabricator.wikimedia.org/T161557#3135260 (10Mattflaschen-WMF) [20:32:11] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: hidebyothers extremely slow for logged in users - https://phabricator.wikimedia.org/T161557#3135274 (10Mattflaschen-WMF) [20:33:04] RoanKattouw, thanks, that helped. I was asking about hidemyself/hidebyothers (not anon/liu), but I forgot to test hidebyothers. [20:33:09] That shows the issue. [20:38:18] stephanebisson, RoanKattouw, what's the status on the blue dot? I'll take a look after I put up that hidemyself/hidebyother patch, if it's still open. [20:45:14] matt_flaschen: I was going to look at it but I haven't yet [20:45:22] Stephane says it's mispositioned [20:45:30] I did review the code and it looks fine [21:04:36] RoanKattouw, matt_flaschen: horizontal positioning doesn't work like I want it to. Probably not a big deal but I really need a few more eyes on this. [21:15:46] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Schema-change: hidebyothers extremely slow for logged in users - https://phabricator.wikimedia.org/T161557#3135390 (10Mattflaschen-WMF) @jcrespo What do you think about adding an index to recentchanges on rc_user? That... [21:16:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Schema-change: hidebyothers extremely slow for logged in users - https://phabricator.wikimedia.org/T161557#3135394 (10Mattflaschen-WMF) [21:25:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Conflicting filters with 'Logged actions' load results extremely slow - https://phabricator.wikimedia.org/T161562#3135411 (10Etonkovidova) [21:28:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345027 (owner: 10L10n-bot) [21:29:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/345031 (owner: 10L10n-bot) [21:32:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Conflicting filters with 'Logged actions' load results extremely slow - https://phabricator.wikimedia.org/T161562#3135444 (10Etonkovidova) [21:32:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: For Conflict States, short-circuit the fruitless searches so as to save processing effort - https://phabricator.wikimedia.org/T160220#3135443 (10Etonkovidova) [21:35:41] matt_flaschen: can you enable user Etonkovidova to be able to see RC filters on enwiki again? I accidentally change the preferences and lost filters :(( [21:47:45] RoanKattouw: can you re-enable user Etonkovidova on enwiki agian? I forgot and changed preferences and now I am blocked again :) [21:53:01] etonkovidova: OK I can do that in a minute [21:53:11] RoanKattouw: thx! [21:53:22] My computer is being used by Melissa to talk to Moriel :) [21:58:38] RoanKattouw: lol [22:00:40] OK she gave it back [22:03:41] etonkovidova: OK should be fixed now [22:03:49] Sorry for the dlay [22:05:34] RoanKattouw: works - thx! :)) [22:17:13] I plead the fifth [22:19:20] Ha, I found Stephane's problem [22:19:31] + left: calc(50% - 1.25em); [22:19:42] This ends up being left(48.75%) [22:19:43] Thanks LESS [22:29:27] mooeypoo: Could you review https://gerrit.wikimedia.org/r/#/c/344163 ? [22:37:05] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-ResourceLoader: Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45 - https://phabricator.wikimedia.org/T161420#3135558 (10Krinkle) 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-ResourceLoader, 07Technical-Debt: Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45 - https://phabricator.wikimedia.org/T161420#3135560 (10Krinkle) [22:40:02] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3135563 (10Catrope) The link was originally `visibility: hidden` but it was made `color: transparent` as part of a change @matmarex made. Both of them... [22:43:31] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3135580 (10matmarex) `color: transparent` is mine (de795bdbc5ee928d570c58ccb6d7b803dfa9504f), but previously it was `font-size: 0` (which didn't work... [22:44:44] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3135581 (10Catrope) Oh that's right, we used `font-size: 0`, I forget who came up with that but @Mooeypoo might remember. Not sure why we didn't go wi... [22:53:39] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3135611 (10matmarex) Actually, `visibility: hidden` probably wouldn't be okay, since it would hide the content from screen-readers. But we can probabl... [23:02:44] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3135637 (10Catrope) I considered positioning off-screen and rejected it because of the :before / :after thing, but I guess if we make the high numbers... [23:14:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3135677 [23:19:51] RoanKattouw: hmm... I do not see wikidata recorded in betalabs recentchanges: rc_source=wb is not there [23:20:22] etonkovidova: Not sure if it works there or not. I would ask matt_flaschen but he left for the day [23:21:00] RoanKattouw: yeah - sigh; Another question: Wikidat and minor conflict is not implemented yet? [23:21:21] Ah, let's see [23:21:30] I think Matt -1ed that and said we needed to change it [23:21:53] RoanKattouw: I see ... [23:22:20] See https://gerrit.wikimedia.org/r/#/c/344451/ [23:22:44] "Both major and minor edits exist in Wikidata, however, the propagated ones are actually all minor, so it should conflict with major edits." [23:23:16] RoanKattouw: ah! :)) ok then [23:24:20] RoanKattouw: but "However, the propagated ones are actually all minor " :) [23:24:41] Yeah that's a bit weird but I kinda see where they were coming from I guess? [23:24:50] But with the ability to filter WD changes separately that shouldn't be needed [23:24:58] Anyway we may or may not want to fix that [23:25:02] (The all-minor thing) [23:25:44] I'll change that patch later to conflict with major changes instead but the explanation message for it would be weird [23:26:01] RoanKattouw: right, yes. I kind of agree - we may not want to fix it [23:31:15] (03Draft1) 10Paladox: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) [23:31:18] (03PS2) 10Paladox: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) [23:33:01] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-ResourceLoader, 13Patch-For-Review, 07Technical-Debt: Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php on line 45 - https://phabricator.wikimedia.org/T161420#3135748 (10Paladox) >>! In T161420#3135558, @Krinkle wrote: > (03PS3) 10Paladox: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) [23:36:42] (03CR) 10Krinkle: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [23:36:50] (03CR) 10Krinkle: [C: 04-1] Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox) [23:38:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3135753 (10E... [23:46:51] (03PS4) 10Paladox: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) [23:47:46] (03CR) 10Paladox: Fix Illegal string offset 'ltr' in ResourceLoaderEchoImageModule.php (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/345070 (https://phabricator.wikimedia.org/T161420) (owner: 10Paladox)