[00:09:16] OK that worked but also generated changes I didn't want [00:09:22] I'll git add -p the ones I do want [00:11:03] Ugh I hate that different versions of composer apparently generated wildly different output [00:11:09] Lots of: [00:11:11] - "time": "2016-11-17 12:28:42", [00:11:11] + "time": "2016-11-17T12:28:42+00:00", [00:11:19] And the order changed in a JSON file [00:11:42] Finished the redirect patch. It's ready for review. [00:12:19] * RoanKattouw upgrades composer and tries again [00:14:44] Nope it generates the same crap, I'll just clean it up by hand then [00:18:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161279#3127255 (10Ladsgroup) [00:18:10] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161280#3127267 (10Ladsgroup) [00:26:19] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161280#3127289 (10JJMC89) [00:26:20] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161279#3127291 (10JJMC89) [00:31:26] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161279#3127293 (10Ladsgroup) 05Open>03Invalid [00:32:12] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161279#3127255 (10Ladsgroup) After talk with @Catrope and finding the ERI highlighting, it's not needed anymore. [00:40:45] RoanKattouw, we *really* need to dynamically generate the hooks pages (instead of on-wiki). Besides the extra work and out-of-sync-ness, it's not really possible to do it properly with a *single* wiki page. [00:41:06] E.g. SpecialRecentChangesFilters should be deprecated in favor of ChangesListSpecialPageFilters in old versions, and ChangesListSpecialPageStructuredFilters in new versions. [00:43:02] Right [00:43:36] matt_flaschen: Also Joe just found that Wikidata edits are somehow considered Unregistered instead of Registered (by both filters and highlights), but at the same time are correctly highlighted with user experience levels. Very strange [00:43:51] I'm also about to push an artisanally crafted Wikidata deployment commit [00:44:38] RoanKattouw, yeah, there's some weird stuff going on there. I saw something also weird with minor, but that's even weirder. I'm guessing dispatchChanges is doing something odd, will try to get to that soon. [01:13:21] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3127340 (10Mattflaschen-WMF) [01:14:46] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3078912 (10Mattflaschen-WMF) >>! In T159795#3087636, @Nikerabbit wrote: > I guess those are coming soon as per what @Mattflasc... [01:22:09] 06Collaboration-Team-Triage, 10Notifications, 10Outreach-Programs-Projects, 10Possible-Tech-Projects, 07Community-Wishlist-Survey-2015: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#3127342 (10Miriya52) [01:33:20] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3127346 (10Eugene233) Ok that's nice. please I wish to work on this project hence i plead we can have some... [01:42:19] Yay my Wikidata thing worked, it's in prod now [03:57:42] RoanKattouw, whoops, I manually tested the other one, but not NoLangLinkHandler. [03:58:46] Context: I broke prod, was reverted [03:59:36] Sorry. :( [03:59:58] I also think it probably started failing well after initial deployment because of pcache [04:03:35] RoanKattouw, so re https://gerrit.wikimedia.org/r/#/c/344564/ , do you update installed.json (to point to the cherry-pick), composer install, fix composer.lock dirty diff, commit, then deploy normally? [04:27:45] I ran the grunt branch command from the readme, then minimized the diff [04:27:50] ( matt_flaschen ) [04:30:48] Thanks [07:17:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-Translate, 15User-Nikerabbit: Port Translate to new RC Filters system - https://phabricator.wikimedia.org/T159795#3127494 (10Nikerabbit) [09:49:34] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 10MediaWiki-Recent-changes: Have a toogle button to enable "enhanced" RC (instead of appending "enhanced=1" to the URL) - https://phabricator.wikimedia.org/T137644#3127774 (10Aklapper) [10:18:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Eliminate the special tooltip for a 'No-Effect' filter when the user has also highlighted it - https://phabricator.wikimedia.org/T161273#3127851 (10Trizek-WMF) Why don't we wait for the first deployment, and ask peop... [10:38:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Eliminate the special tooltip for a 'No-Effect' filter when the user has also highlighted it - https://phabricator.wikimedia.org/T161273#3127883 (10Pginer-WMF) >>! In T161273#3127851, @Trizek-WMF wrote: > Why don't w... [11:24:36] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3127964 (10Schnark) [11:28:12] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3127990 (10Schnark) Also reproducible in Vector, though (at least with German localization) the overlapping area is much smaller (only parts of the "D... [12:48:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), and 2 others: Contact group 2 wikis concerning Filters for recent changes - https://phabricator.wikimedia.org/T158332#3128085 (10Trizek-WM... [13:18:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Calculate a custom blend color for yellow+blue - https://phabricator.wikimedia.org/T161267#3128117 (10Pginer-WMF) The initial colors for the highlight combinations (T149467) have been [[ http://codepen.io/pauginer/pe... [15:49:24] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: ORES highlighter javascript doesn't work when ERI is enabled - https://phabricator.wikimedia.org/T161280#3127267 (10jmatazzoni) You don't provide a picture, so I'm not sure, but it sounds like you're talking about there being interference from th... [15:54:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Eliminate the special tooltip for a 'No-Effect' filter when the user has also highlighted it - https://phabricator.wikimedia.org/T161273#3128416 (10jmatazzoni) Yeah, I don't think we need to wait on this one. I know... [15:57:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (i... - https://phabricator.wikimedia.org/T158225#3128429 [15:57:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 06Community-Liaisons (Jan-Mar 2017): Inform communities about the release of the ORES good faith and damaging UI by def... - https://phabricator.wikimedia.org/T159223#3128427 [17:21:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Eliminate the special tooltip for a 'No-Effect' filter when the user has also highlighted it - https://phabricator.wikimedia.org/T161273#3128627 (10Mooeypoo) a:03Mooeypoo [17:27:03] 06Collaboration-Team-Triage, 10Notifications: Invisible link to notifications can overlap link to personal talk page - https://phabricator.wikimedia.org/T161302#3128640 (10Esanders) Are they visibility:hidden or color:transparent? [17:53:12] etonkovidova, sorry, it should have been: [17:53:14] SELECT * FROM recentchanges WHERE rc_type = 6 AND rc_this_oldid = 0 LIMIT 1; [17:53:26] because it's NOT NULL default 0 (so rows without it will just be 0) [17:53:30] But it's the same result, just slower. [17:53:52] Still empty [17:53:58] matt_flaschen: yup, the same result [18:13:46] (03CR) 10EBernhardson: Get rid of global state (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/340452 (https://phabricator.wikimedia.org/T159299) (owner: 10MaxSem) [18:15:37] mooeypoo, your conflict changes look fine. [18:15:49] +1 [18:18:40] mooeypoo, except for the categorization thing (but even for that one the API usage is fine): [18:18:41] https://gerrit.wikimedia.org/r/#/c/344667/ [18:18:52] If I get the task before merge, I can add it, but we can always link it later. [18:19:02] So you can review now. [18:19:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3128838 (10Samwalton9) Quick question, which I assum... [18:19:35] It's not in production, so we should get it on Beta, but we don't have to worry about it being Friday. [18:23:23] matt_flaschen: a puzzle: in betalabs - select count(*) from recentchanges where rc_type=6; -->306; select * from ores_classification where oresc_rev in (select rc_this_oldid from recentchanges where rc_type=6); -->3 [18:25:51] etonkovidova, hmm, I'll look after lunch [18:26:05] matt_flaschen: ok -thank you! [18:26:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3128853 [18:32:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Remove Category Changs vs. ORES from list of Conflict States - https://phabricator.wikimedia.org/T161325#3128856 (10jmatazzoni) [18:35:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3128874 [18:38:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3128878 (10jmatazzoni) [18:54:37] matt_flaschen: it seems that the last ORES scored record was rc_timestamp: 20170314174237 :( [19:07:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Remove Category Changs vs. ORES from list of Conflict States - https://phabricator.wikimedia.org/T161325#3128856 (10jmatazzoni) a:05Mooeypoo>03None [19:07:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: RC filters - conflicting states for highlight-only filte... - https://phabricator.wikimedia.org/T161172#3128926 [19:30:57] 06Collaboration-Team-Triage, 10Notifications: [minor] Notification icons point to different directions - https://phabricator.wikimedia.org/T161330#3128964 (10Etonkovidova) [20:19:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Remove Category Changs vs. ORES from list of Conflict States - https://phabricator.wikimedia.org/T161325#3129144 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [20:40:17] mooeypoo, could you review the category revert? [20:40:18] https://gerrit.wikimedia.org/r/#/c/344667/ [21:03:35] matt_flaschen, are we removing all the ORES category ones? [21:04:19] matt_flaschen, .... there are double-spaces-after-period in the qqq! [21:04:21] ;) [21:04:37] That was amusing when I worked on it "oh, I know who wrote *that* originally" [21:05:46] matt_flaschen, anyways, it looks good to me since it's a revert -- I just wanted to make sure the revert is supposed to be the entire patch and not a part of it [21:14:02] mooeypoo, yeah, it turns out all RC_CATEGORIZE track their original revision ID. So basically the ORES should just follow that revision ID's ORES, per Hangouts. [21:14:08] So it is scored, and is not really a conflict. [21:14:33] mooeypoo, I'm investigating the categorization thing etonkovidova found on Beta now. [21:14:53] * mooeypoo nods [21:14:58] ko I'll +2 then [21:14:58] matt_flaschen: I was just typing to remind you about it :)) Thx! [21:15:34] matt_flaschen: it looks quite alarming to me - like ORES scoring stopped working at rc_timestamp: 2017031417423 [21:18:47] etonkovidova, thanks (all ORES scoring, not just category-related). Maybe it just happens all the categorizations are after that cut-off. [21:18:50] I was looking at the bugs. [21:19:37] halfak, any known issues with ORES on Beta? [21:19:48] enwiki Beta uses real models for both damaging and goodfaith, right? [21:19:54] http://ores-beta.wmflabs.org/v2/scores/enwiki/goodfaith/1 [21:20:04] Yeah. Returning errors. [21:20:16] https://phabricator.wikimedia.org/T160762 [21:46:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344700 (owner: 10L10n-bot) [21:49:21] 06Collaboration-Team-Triage, 10Notifications: svg icons should have png fallbacks - https://phabricator.wikimedia.org/T161348#3129380 (10Isarra) [22:09:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Good faith test does not work properly - https://phabricator.wikimedia.org/T161250#3129459 (10Etonkovidova) Checked on enwiki (wmf.17... [22:20:15] 06Collaboration-Team-Triage, 10Notifications: oo-ui-popupWidget-anchors point to left corner instead of middle of badge icons - https://phabricator.wikimedia.org/T161352#3129489 (10Isarra) [22:21:31] 06Collaboration-Team-Triage, 10Notifications: Use oojs-ui - https://phabricator.wikimedia.org/T161353#3129503 (10Isarra) [22:35:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225#3125540 (10Etonkovidova) RC page is fixed - no Internal error page is displayed. [23:49:49] matt_flaschen: Thanks for the chocolates! They were yummy. :) [23:50:27] Niharika, you're welcome. [23:50:29] :)