[00:04:39] matt_flaschen: ok then :) [00:35:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Make the generic "recentchanges-noresults" message bold - https://phabricator.wikimedia.org/T160935#3123934... [00:41:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: [monobook] RC filters UI needs adjustments - https://phabricator.wikimedia.org/T161033#3123966 (10Etonkovi... [00:56:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3123977 (10Etonkovidova) Checked the fix in betalabs. **QA Recommendation: Resolve** [02:00:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: ERI Metrics: Measure click-through actions from RC page and create 'Productivity" baseline - https://phabricator.wikimedia.org/T158458#3124086 (10Catrope) a:03Catrope [06:01:29] 10MediaWiki-Recent-changes: Recent changes email workflow is inefficient - https://phabricator.wikimedia.org/T56609#3124214 (10Molgreen) For the watchlist, I would wish me three options: * Page not on the watchlist * Page on the watchlist * Page permanently on the watch list (//new function//) [06:12:47] Yes I am inside the git repo all the git command works but I have downloded the code manually and haven't made a commit so it doesn't display the master branch but when I press git status it returns me that it is on branch master but git is working inside the core repo then why does git review -s returning the error mentioned above? [08:37:44] 10MediaWiki-Watchlist, 10MediaWiki-Unit-tests, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, and 3 others: WatchedItemStoreIntegrationTest fails when coverage is enabeld - https://phabricator.wikimedia.org/T160956#3124287 (10Addshore) [09:07:28] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3124309 (10jcrespo) > We (WMDE) will discuss the readonly side of things in our meeting on Tuesday What is the result of the meeti... [10:44:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Add technology so we'll be able to track usage of RC Pa... - https://phabricator.wikimedia.org/T158344#3124520 [14:03:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Gadget-LiveRC developers concerning ERI improvements - https://phabricator.wikimedia.org/T158855#3125081 (10Trizek-WMF) 05Open>03Resol... [14:06:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3125094 (10Trizek-WMF) @Samwalton9, when do you thin... [14:13:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3125119 (10Samwalton9) @Trizek-WMF We're aiming for... [14:14:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3125124 (10Trizek-WMF) >>! In T132084#3125119, @Samw... [14:17:31] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876#3125140 (10Trizek-WMF) Should it be proposed as a possible task for the next hackathon? [14:38:53] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3125233 (10Lea_WMDE) >>! In T130067#3124309, @jcrespo wrote: >> We (WMDE) will discuss the readonly side of things in our meeting o... [15:55:45] 06Collaboration-Team-Triage, 10Flow, 10Collaboration-Community-Engagement: Flow shortcuts panel is not up-to-date - https://phabricator.wikimedia.org/T134380#3125432 (10Trizek-WMF) [16:13:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements: Evaluate the differences of Recent Changes, Watchlist and User Contribution filters - https://phabricator.wikimedia.org/T159444#3125465 (10Pginer-WMF) [16:26:22] (03CR) 10Catrope: [C: 032] Use tabs to indent in json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344222 (owner: 10Umherirrender) [16:27:34] stephanebisson: Is https://gerrit.wikimedia.org/r/#/c/344095/8 ready for merge? [16:28:40] stephanebisson: I just realized (as you and Leszek surely have already) that the Echo tables are in a different and that that's why this is so hard [16:29:25] RoanKattouw: I'm not happy with it but it does seem to solve the wikidata problem. [16:29:35] OK [16:29:50] (03CR) 10Catrope: [C: 032] Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [16:29:58] although the tablesUsed[] are probably not needed [16:30:01] oups, too late [16:31:21] RoanKattouw: in https://gerrit.wikimedia.org/r/#/c/344291/, I don't see logs for the second level (pages with fromrc=1) [16:32:18] It only works for a few links such as the (edit) (undo) (thank) links on the diff page [16:32:30] Basically things that match the selectors in the JS file [16:32:38] RoanKattouw: is it possible that the js doesn't fully execute when we navigate away (but it works when I cmd+click) ? [16:33:00] It worked for me in Chrome, since the href modification is synchronous and the event is sent with sendBeacon() [16:33:09] RoanKattouw: undo link on the diff page not logging for me [16:33:18] Hmm interesting, will try locally [16:33:19] I'll try again to be sure [16:33:35] BTW I've found this useful for debugging: mw.trackSubscribe('event.', function( event, obj ) {console.log(event); console.log(obj); } ); [16:33:48] (Then check "Preserve log" in the console, and remember to rerun it after navigating) [16:36:25] It's working for me insofar as it logs to the console when I do that [16:36:36] I'll wait to see if it shows up in the log file, that's always a bit behind [16:37:25] https://www.irccloud.com/pastebin/1olYetdh/ [16:38:16] RoanKattouw: not sure how I ended up with event logging debug mode always enabled but it shows each event in a small popup on the top-right of the screen, clicking on it opens a larger popup with the entire event [16:38:24] Ooh interesting [16:38:55] from reading the code I thought ?debug=1 was responsible but now it's always on... [16:40:01] RoanKattouw: betalabs RC pages for anons gives /wiki/Special:RecentChanges MWException from line 257 of /srv/mediawiki/php-master/includes/changes/ChangesListFilter.php: You can only pass in a ChangesListFilterGroup or a ChangesListFilter [16:40:08] (03Merged) 10jenkins-bot: Use tabs to indent in json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344222 (owner: 10Umherirrender) [16:40:13] :O [16:40:20] Looking [16:40:28] RoanKattouw: testwiki is ok [16:40:36] Probably caused by the Wikidata change [16:41:11] Yup: #1 /srv/mediawiki/php-master/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php(241): ChangesListFilter->conflictsWith(NULL, string, string, string) [16:41:44] RoanKattouw: I confirm, the undo link on the diff page doesn't log anything for me [16:41:59] Huh [16:41:59] (03CR) 10jenkins-bot: Use tabs to indent in json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344222 (owner: 10Umherirrender) [16:42:31] (Un)fortunately I can't reproduce that [16:43:08] Same for undo on history page [16:43:15] (03Merged) 10jenkins-bot: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [16:43:25] they both open the change in an editor that I have to save [16:43:59] Yes, that is "expected" behavior [16:44:19] But that click/navigation on the undo link should be logged to the clicktracking schem [16:44:20] a [16:44:31] (03CR) 10jenkins-bot: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [16:45:12] etonkovidova: Is there a phab task for that error yeT? [16:45:46] RoanKattouw: it works for you, it doesn't work for me, we need a tie-breaker... [16:45:57] RoanKattouw: not yet [16:46:02] OK, I'll file one [16:48:13] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225#3125540 (10Catrope) [16:48:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225#3125555 (10Catrope) p:05Triage>03Unbreak! [16:51:04] matt_flaschen: T161225 [16:51:05] T161225: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225 [16:56:10] RoanKattouw: update: 'edit' link logs, as well as the first user talk link, the second user talk ((Undo revision 86 by (talk))) doesn't log, it doesn't have the same selector [17:02:04] Oh but that's a talk link inside an edit summary, right? [17:02:11] That probably doesn't have any kind of useful selector [17:12:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state - https://phabricator.wikimedia.org/T161172#3125630 (10Catrope) So it looks like filter capsules representing high... [17:17:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice: Contact communities for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T146972#3125655 (10Trizek... [17:22:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 13Patch-For-Review: Notification popup clippable area problem - not showing full area - https://phabricator.wikimedia.org/T159888#3125660 (10Catrope) 05Open>03Resolved... [17:27:32] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10Notifications, 05MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), 13Patch-For-Review, 07User-notice-collaboration: Sort out Notification categories to make them more logical for Preferen... - https://phabricator.wikimedia.org/T133220#3125673 [17:53:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Contact group 1 wikis concerning Filters for recent chan... - https://phabricator.wikimedia.org/T158336#3125760 [18:00:51] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 07Regression: Echo: Emailed Notifications for new usertalkpage messages should include more or all of the message - https://phabricator.wikimedia.org/T64661#3125775 (10OwenBlacker) I'm the Twitter user in question — the problem I'm complainin... [18:05:04] RoanKattouw, https://gerrit.wikimedia.org/r/344448 [18:08:37] RoanKattouw, whoops, I don't know why that didn't work. Will fix after metrics. [18:08:52] matt_flaschen: I have a patch up already [18:09:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225#3125795 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [18:09:21] Or, wait, I didn't submit it [18:09:32] Or assign it to yourself. [18:09:47] Sorry, I remember you said you were patching Wikibase but I didn't know for what. [18:09:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Wikidata RCFilters integration causes error on Recentchanges - https://phabricator.wikimedia.org/T161225#3125540 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03Catrope [18:11:06] Sorry, I thought I had submitted it but git-review failed apparently [18:12:20] It's in Gerrit now [18:22:40] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125839 (10Reception123) [18:26:27] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125839 (10Catrope) When do you get this error? When running update.php? When viewing a page? When doing something else? [18:27:34] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125881 (10Reception123) @Catrope when running sql.php [18:28:12] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125891 (10Catrope) Why are you running sql.php and what are you passing to it? Is this part of the extension setup process? [18:31:09] 06Collaboration-Team-Triage, 10Flow: [betalabs-regression] Flow: The icon for the sorting option 'Newest topics' is missing - https://phabricator.wikimedia.org/T161233#3125909 (10Etonkovidova) [18:31:29] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125921 (10Reception123) This issue has been persisting on our wiki farm (Miraheze) for some time, I now took the initiative of filing a task here. I am currently just running sql.php... [18:32:50] (03PS1) 10Umherirrender: Use tabs to indent in json [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/344469 [18:33:49] (03CR) 10Jforrester: [C: 032] Use tabs to indent in json [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/344469 (owner: 10Umherirrender) [18:34:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Add technology so we'll be able to track usage of RC Pa... - https://phabricator.wikimedia.org/T158344#3125927 [18:34:14] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125928 (10Catrope) Interesting. Could you paste the entire error message, with any backtraces and other information that appears alongside it? [18:36:30] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125932 (10Reception123) @Catrope Not exactly sure how to investigate that. When running I simply get that error. Is there any log that would show the full message or a query I could... [18:36:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 13Patch-For-Review, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3125933 (10E... [18:45:10] (03Merged) 10jenkins-bot: Use tabs to indent in json [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/344469 (owner: 10Umherirrender) [20:01:36] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3126149 (10Catrope) [20:02:26] 06Collaboration-Team-Triage, 10Notifications: Echo subscription table doesn't exist - https://phabricator.wikimedia.org/T161230#3125839 (10Catrope) After discussing this with @Reception123 on IRC and poking around in the code a bit, I suddenly remembered https://gerrit.wikimedia.org/r/#/c/340129/ , which shoul... [20:14:38] matt_flaschen, stephanebisson: Could either of you review+merge https://gerrit.wikimedia.org/r/#/c/344450/1 ? [20:16:02] That bug is causing RC to break completely with a PHP exception if ORES is enabled [20:19:17] Who needs RC? ;-) [20:19:38] Should the conflictWith code be more accepting? [20:21:53] James_F, I don't think so. Normally, if you're passing in a null group/filter that means you made a mistake (e.g. a typo in the group name). This is a special case since the groups are conditional. [20:22:01] +2'ed [20:23:24] Kk. [20:26:36] Hey eugene23 [20:27:10] <+matt_flaschen> Hey [20:27:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07Accessibility, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Notifications only outputs numbers in raw HTML - https://phabricator.wikimedia.org/T160277#3126259 (10jmatazzoni) 05Open>03Resolve... [20:27:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3126263 [20:27:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Make the generic "recentchanges-noresults" message bold - https://phabricator.wikimedia.org/T160935#3126262... [20:28:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: [monobook] RC filters UI needs adjustments - https://phabricator.wikimedia.org/T161033#3126264 (10jmatazzo... [20:28:51] I was wondering if i could have primary mentor assistance for a project from here [20:28:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 13Patch-For-Review, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3126265 (10j... [20:29:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3126270 (10jmatazzoni) 05Open>03Resolved a:03jmatazzoni [20:29:11] I actually just forwarded your email to matt_flaschen and mooeypoo so we could discuss it [20:31:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Add technology so we'll be able to track usage of RC Pa... - https://phabricator.wikimedia.org/T158344#3126312 [20:31:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3126314 (10jmatazzoni) [20:44:47] eugene23, we'll get back to you. I am already mentoring T88781 , but we'll see about different people's availability. [20:44:48] T88781: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781 [20:45:23] (No one has been accepted yet for the timer one, but I've listed myself as a mentor) [20:46:36] eugene23, in the mean time, you can follow the steps at https://www.mediawiki.org/wiki/Outreach_programs/Life_of_a_successful_project#Getting_there [20:48:10] Ok thanks [20:55:50] stephanebisson, did you remove testRcHidemyselfHidebyothersFilter and testRcHidepatrolledHideunpatrolledFilter in https://gerrit.wikimedia.org/r/#/c/325567/5/tests/phpunit/includes/specials/SpecialRecentchangesTest.php , or is that just a rebase issue? [20:57:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Good faith test does not work properly - https://phabricator.wikimedia.org/T161250#3126454 (10jmatazzoni) [21:03:58] matt_flaschen, are you mentoring T88781 for this year's Gsoc? [21:03:58] T88781: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781 [21:04:50] eugene23, sorry, I linked the wrong one. I'm actually available to mentor T2582 . [21:04:50] T2582: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582 [21:06:07] 06Collaboration-Team-Triage, 10Notifications, 10Possible-Tech-Projects, 07Community-Wishlist-Survey-2015: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#3126538 (10Mattflaschen-WMF) {T2582} is also now available as a GSOC and Outreachy project. [21:07:57] stephanebisson, never mind, I see. I didn't read the tests closely enough. [21:26:32] 06Collaboration-Team-Triage, 10Notifications, 10MassMessage: Echo: talkpage messages without a 4tilde signature, do not generate correct section links or summary - https://phabricator.wikimedia.org/T59152#3126685 (10Quiddity) Adding #massmessage, because it is the usual culprit these days. I.e. All messages... [21:27:08] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email, 07Regression: Echo: Emailed Notifications for new usertalkpage messages should include more or all of the message - https://phabricator.wikimedia.org/T64661#3126687 (10Quiddity) I believe {T59152} is the culprit for that. I've added another n... [21:35:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3126737 (10jmatazzoni) [21:35:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Redirect when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#3126749 (10Mattflaschen-WMF) [21:36:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3126737 (10jmatazzoni) [21:36:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Colored dots are not evenly spaced - https://phabricator.wikimedia.org/T161258#3126737 (10jmatazzoni) [21:44:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344516 (owner: 10L10n-bot) [21:44:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344521 (owner: 10L10n-bot) [21:45:59] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#31802 (10Eugene233) @Mattflaschen-WMF and @Mooeypoo. Will this project still be part of the GsoC '17 as was... [21:51:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Good faith test does not work properly - https://phabricator.wikimedia.org/T161250#3126860 (10Catrope) This is because we're extracting the thresholds incorrectly from the ORES API: the thresholds for "false" qualiti... [21:53:07] matt_flaschen: Wikidata+Minor edits currently is not marked as conflicting state. But it's mentioned as such in https://phabricator.wikimedia.org/T160803 [21:53:29] matt_flaschen: was it discussed and postponed to implement or discarded? [21:53:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3126869 (10E... [21:54:40] matt_flaschen: sorry, oops - there is a patch for it [22:05:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement corrected Conflict State tooltips and Results ... - https://phabricator.wikimedia.org/T160803#3126885 [22:14:38] matt_flaschen: Could you review https://gerrit.wikimedia.org/r/344553 ? I'd like to SWAT it today (in 45 mins) [22:14:48] (And otherwise we need to SWAT it on Monday, before the release) [22:16:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3126938 (10Etonkovidova) Checked in betalabs - all text labels seem to be in place. I saw no i... [22:18:18] RoanKattouw, yep. Please fix the tests, then will do. [22:18:51] matt_flaschen: Done, sorry, just noticed the failing tests myself right after pinging you [22:26:04] +2'ed [22:29:19] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3126979 (10Mattflaschen-WMF) >>! In T2582#3126801, @Eugene233 wrote: > @Mattflaschen-WMF and @Mooeypoo. Wil... [22:29:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Calculate a custom blend color for yellow+blue - https://phabricator.wikimedia.org/T161267#3126980 (10jmatazzoni) [22:32:03] Thanks [22:37:40] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3127016 (10jmatazzoni) [22:43:08] matt_flaschen: I see you cherry-picked the Wikidata patch and its core dependency, when were you planning on SWATting that? [22:43:18] I ask because my fix for the PHP fatal needs to be cherry-picked too [22:44:50] RoanKattouw, I was originally planning to do yesterday, but then I cancelled it, since I would have to bypass the Extension:Wikidata build system or cherry-pick the whole series (I guess, not sure how cherry-picks of submodules work). [22:45:04] Oh, yes, that's right [22:45:15] RoanKattouw, if you want, I could still try to do it, not sure how important it is. [22:45:22] But I thought you were okay cancelling it. [22:45:40] Yeah I was, I had just forgotten that conversation, I remember it now [22:45:45] Sorry for the confusion [22:45:51] No problem [22:46:02] I'll abandon your cherry-picks then, seeing them float around is what triggered my confusion [22:46:15] Thanks [22:51:58] 10MediaWiki-Recent-changes: Make it easier to toggle enhanced RC - https://phabricator.wikimedia.org/T137644#3127069 (10Aklapper) >>! In T137644#2998420, @matej_suchanek wrote: > You can append `enhanced=0`/`enhanced=1` to the url. @VictorPorton : Is that sufficient? [23:06:10] 10MediaWiki-Recent-changes: Make it easier to toggle enhanced RC - https://phabricator.wikimedia.org/T137644#3127086 (10VictorPorton) @Aklapper I want a link or a button switching the mode, without manually editing the URL (and remembering how to do it). [23:09:03] matt_flaschen: Happy belated Purim. :-) [23:09:14] Aka nom. [23:09:16] James_F, you too. :) [23:09:17] matt_flaschen: THANK you!! We are eating hammen taschen. Nice! [23:09:31] etonkovidova, welcome. :) [23:19:17] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Subset-conflicting filters shouldn't show as disabled and helpfully tell you to highlight them if they're highlit - https://phabricator.wikimedia.org/T161272#3127116 (10Jdforrester-WMF) [23:21:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Consider eliminating 'No-Effect' States—or maybe just the tooltips for them - https://phabricator.wikimedia.org/T161273#3127129 (10jmatazzoni) [23:27:41] matt_flaschen: I noticed in Joe's testing that not having the Wikidata patch makes it not filter out Wikidata changes when you'd think they would be filtered out, and James said that he thought that cherry-picking those patches should be fine, so I'm gonna try that now [23:28:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ORES thresholds and overlaps optimization - https://phabricator.wikimedia.org/T161275#3127158 (10Etonkovidova) [23:28:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ORES thresholds and overlaps optimization - https://phabricator.wikimedia.org/T161275#3127170 (10Etonkovidova) a:03Catrope [23:30:00] RoanKattouw, okay, thanks. I'll take a look afterwards to see how it works. [23:30:30] (The cherry-picking process I mean) [23:32:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: RC filters - conflicting states for highlight-only filte... - https://phabricator.wikimedia.org/T161172#3127177 [23:37:05] Supposedly it's just nested submodules like in VE and it should Just Work [23:37:06] But we'll see [23:37:34] matt_flaschen: Also because I misinterpreted "it" as the RCFilters feature, I set the rcenhancedfilters pref to true for you on enwiki [23:37:49] Note that if you change your prefs it'll get unset, but you can just set it again using eval.php if you like [23:39:22] Nope, James was wrong, it uses a build rather than a submodule [23:40:03] Oh, but composer.lock pegs each subdir to a git hash [23:42:36] I was also wrong, though I didn't really check properly before saying that. [23:42:39] The submodule thign. [23:43:59] I've found some docs that seem like they may indicate how to do this, so once Jenkins finishes merging the Wikibase changes I'll try it [23:45:11] RoanKattouw, did you see https://phabricator.wikimedia.org/diffusion/WDBR/browse/master/README.md ? [23:45:22] The good part is it won't get clobbered AFAICT, since it's not on master. [23:45:25] Yes that's what I was referring to [23:51:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Eliminate the special tooltip for 'No-Effect' filters when the user has also highlighted them - https://phabricator.wikimedia.org/T161273#3127188 (10jmatazzoni) a:05Mooeypoo>03None [23:52:32] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Subset-conflicting filters shouldn't show as disabled and helpfully tell you to highlight them if they're highlit - https://phabricator.wikimedia.org/T161272#3127196 (10jmatazzoni) [23:52:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Eliminate the special tooltip for 'No-Effect' filters when the user has also highlighted them - https://phabricator.wikimedia.org/T161273#3127129 (10jmatazzoni) [23:53:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Eliminate the special tooltip for a 'No-Effect' filter when the user has also highlighted it - https://phabricator.wikimedia.org/T161273#3127199 (10jmatazzoni) [23:55:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3100769 (10Etonkovidova) Checked on enwiki... [23:56:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3127204 (10jmatazzoni) 05Open>03Resolved...