[00:00:10] RoanKattouw, also, I thought https://gerrit.wikimedia.org/r/#/c/342294/5..6/client/tests/phpunit/includes/Hooks/ChangesListSpecialPageHookHandlersTest.php would fix that PHPUnit failure, but unfortunately no. It passes locally. [00:00:30] Hmm strange [00:00:32] I'll finish the jQueryMsg thing and try to figure that out. [00:00:47] This is for Timo's failure, right? [00:00:58] RoanKattouw, the code coverage thing? [00:01:02] Yeah [00:01:03] No, for https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-sqlite-hhvm-jessie/772/console [00:01:06] For Wikibase. [00:01:09] Oh, the Wikibase one, OK [00:02:27] RoanKattouw, so you get class-not-found errors locally? [00:02:32] Didn't see that on the Wikibase. [00:02:45] Yeah but I'm still poking at the FLow thing so I haven't tried it again recently [00:02:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07Accessibility, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Notifications only outputs numbers in raw HTML - https://phabricator.wikimedia.org/T160277#3120385 (10jmatazzoni) [00:05:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes: Handle default for 'string_options' groups - https://phabricator.wikimedia.org/T160092#3120395 (10jmatazzoni) [00:05:45] (03PS2) 10Mattflaschen: Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:05:51] (03CR) 10Mattflaschen: [C: 032] Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:05:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes: Handle default for 'string_options' groups - https://phabricator.wikimedia.org/T160092#3088442 (10jmatazzoni) a:05Mooeypoo>03... [00:06:13] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Flow, 10Notifications: Failed mention and Successful mention notifications don't work on Flow - https://phabricator.wikimedia.org/T160088#3120400 (10jmatazzoni) [00:08:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3120405 (10jmatazzoni) [00:08:56] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): It is unclear what the 'Hide patrolled pages from new page list' setting applies to - https://phabricator.wikimedia.org/T160682#3120411 (10jmatazzoni) [00:09:21] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017): It is unclear what the 'Hide patrolled pages from new page list' setting applies to - https://phabricator.wikimedia.org/T160682#3107568 (10jmatazzoni) a:03jmatazzoni [00:11:17] (03CR) 10Mattflaschen: [C: 04-2] Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:11:55] (03PS3) 10Mattflaschen: Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:12:24] (03CR) 10Mattflaschen: [C: 031] "Did the remaining two." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:27:37] (03CR) 10Catrope: [C: 032] Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:30:50] (03CR) 10Catrope: [C: 032] Simplify definition of 'ext.echo.badgeicons' module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343951 (owner: 10Bartosz Dziewoński) [00:39:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3120479 (10Etonkovidova) It seems that disabling cookies kicks a user out of the session, so the edits wi... [00:44:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 13Patch-For-Review: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3120485 (10Catrope) >>! In T160754#3120479, @Etonkovidova wrote: > It seems that disabling cookies kicks... [00:45:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3120486 (10Samwalton9) Wasn't expecting this to happ... [00:47:52] (03Merged) 10jenkins-bot: Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:47:55] (03Merged) 10jenkins-bot: Simplify definition of 'ext.echo.badgeicons' module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343951 (owner: 10Bartosz Dziewoński) [00:48:21] (03CR) 10jenkins-bot: Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 (owner: 10Reedy) [00:49:48] (03CR) 10jenkins-bot: Simplify definition of 'ext.echo.badgeicons' module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343951 (owner: 10Bartosz Dziewoński) [00:49:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3120500 (10Catrope) >>! In T132084#3120486, @Samwalt... [01:07:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3120508... [01:10:38] matt_flaschen: Hmm, so it looks like offset handling is only done by the indexes, not by the storage layer or anything? [01:11:18] matt_flaschen: I got submodule=view-topiclist&vtloffset-dir=rev to the point where it doesn't throw errors, but the output is probably wrong since it doesn't actually do any reversing [01:11:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3120522... [01:12:11] And the offset value appears to be completely ignored [01:12:28] So I could put this patch in, but then when the frontend does send rev requests, it wouldn't exactly get useful info [01:12:52] I suppose I can just remove the thing that attempts to query in reverse from the frontend for the time being, but still... [01:13:17] ebernhardson: Oh, you're back. Dereckson deployed your patch but I wasn't able to run the maintenance script because the train was reverted, so testwiki was not on wmf.17 [01:14:06] RoanKattouw, yeah, that sounds very familiar. [01:14:18] OK so we're screwed then [01:14:28] I'll still submit my fix because I think it's necessary [01:14:37] But we'll also have to remove reverse querying from the front-end [01:14:42] RoanKattouw: no worries, checking now. thanks! [01:14:48] RoanKattouw, although I said it works for offset-id: https://gerrit.wikimedia.org/r/#/c/245621/ . But I think you're doing timestamp offset since it's 'updated', right? [01:14:59] Yes it's a timestamp offset [01:15:11] Lemme test offset-id [01:15:42] My patch should have fixed that. [01:16:23] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Page curation G4 speedy deletion instructions create tag that doesn't work - https://phabricator.wikimedia.org/T161068#3120527 (10TonyBallioni) [01:48:23] matt_flaschen: Yes it does appear that offset-id makes it into the query somehow [01:50:50] matt_flaschen: Although reversing doesn't work there either, it keeps using topic_id < X with ORDER BY topic_id DESC, it doesn't change to > and ASC [01:51:15] Which means it also returns the same result for offset-dir=fwd and offset=dir=rev which is how I know it's wrong :) [01:52:21] (03PS1) 10Catrope: Make sure topiclist queries always join against workflow table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344073 (https://phabricator.wikimedia.org/T121644) [09:06:22] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Improve highlighting display so it's compatible with Enhanced Recent Changes - https://phabricator.wikimedia.org/T159896#3120963 (10Pginer-WMF) >>! In T159896#3116376, @jmatazzoni wrote: > It looks like I'm leaning t... [09:09:49] 10MediaWiki-Watchlist, 10MediaWiki-Unit-tests, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, and 2 others: WatchedItemStoreIntegrationTest fails when coverage is enabeld - https://phabricator.wikimedia.org/T160956#3116232 (10Addshore) a:03Addshore [09:57:02] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 03Wikidata-Sprint: Edits in WikibaseLexeme cause odd failures in MWEchoThankYouEditTest::testFirstEdit - https://phabricator.wikimedia.org/T161087#3121055 (10WMDE-leszek) [09:57:21] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 03Wikidata-Sprint: Edits in WikibaseLexeme cause odd failures in MWEchoThankYouEditTest::testFirstEdit - https://phabricator.wikimedia.org/T161087#3121068 (10WMDE-leszek) p:05Triage>03High [09:58:46] 06Collaboration-Team-Triage, 10Notifications, 10Wikidata, 03Wikidata-Sprint: Edits in WikibaseLexeme cause odd failures in MWEchoThankYouEditTest::testFirstEdit - https://phabricator.wikimedia.org/T161087#3121055 (10WMDE-leszek) So I thought cleaning up Echo tables before ThankYouEditTests would be a possi... [10:08:26] (03PS3) 10WMDE-leszek: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) [11:53:14] Hi! Any feeling like having a look at https://phabricator.wikimedia.org/T161087 ? TL;DR: there is a Wikibase patch that is red on Jenkins because of failures of Echo tests. I tried to figure out why it happens but basically failed and am now quite hopeless [12:26:18] leszek_wmde: I'll look at it today (it's morning for me). Mind if I ammend the patch to try things? [12:28:51] stephanebisson: thanks! please whatever you like with those patches [13:31:00] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3121771 (10Trizek-WMF) Drafted on the next Tech News (week 13). [13:33:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact communities for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T146972#3121775 (10Trizek-WMF) [13:40:42] 06Collaboration-Team-Triage, 10Flow, 07User-notice-collaboration: Have all VE sequences available on Flow - https://phabricator.wikimedia.org/T134167#3121809 (10Trizek-WMF) Removing user-notice: too specific. [13:41:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Contact group 1 wikis concerning Filters for recent chan... - https://phabricator.wikimedia.org/T158336#3121829 [13:41:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), and 2 others: Contact group 2 wikis concerning Filters for recent changes - https://phabricator.wikimedia.org/T158332#3121830 (10Trizek-WM... [13:42:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Contact group 3 wikis concerning Filters for recent chan... - https://phabricator.wikimedia.org/T158333#3121831 [13:42:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07User-notice-collaboration: Contact group 4 wikis concerning Filters for recent chan... - https://phabricator.wikimedia.org/T158335#3121832 [14:14:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3121981 (10Trizek-WMF) I like it. I've been confused first by the labels, believing this list was a sort of d... [14:24:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 13Patch-For-Review, and 2 others: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3122004 (10Samwalton9) >>! In T132084#3120500, @Catr... [14:31:51] I have installed git-review in my system using command sudo apt-get install git-review but when I type git review -s It displays an error saying No '.gitreview' file found in this repository. We don't know [14:31:51] where [14:31:51] your gerrit is. Please manually create a remote named "gerrit" and try [14:31:51] again [15:17:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), and 2 others: Contact group 2 wikis concerning Filters for recent changes - https://phabricator.wikimedia.org/T158332#3122116 (10Trizek-WM... [15:27:16] 06Collaboration-Team-Triage, 10Flow, 07I18n: flow-moderation* need explicit GENDER support - https://phabricator.wikimedia.org/T69969#3122124 (10Liuxinyu970226) [15:52:52] 06Collaboration-Team-Triage, 10MediaWiki-History-or-Diffs, 10Parsoid, 10VisualEditor, 07Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#3122182 (10Jdforrester-WMF) [16:02:37] rammanoj_: if you haven't made a commit yet, that might be indeed. [16:03:55] rammanoj_: are you actually inside of the git repo though ? [16:09:42] and is your useraccount setup ? [16:29:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC ORES filters do not force a changed state to 'r': it displayed black until page reloaded - https://phabricator.wikimedia.org/T161060#3122272 (10Etonkovidova) [16:40:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] testiwiki - wrong tooltip 'Clear all filters' is displayed for 'Restore default filters' - https://phabricator.wikimedia.org/T161123#3122298 (10Etonkovidova) [16:48:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3122340... [16:49:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3122341 (10... [16:54:37] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Tracking: Launch ERI RC page features as a Beta Feature to all wikis - https://phabricator.wikimedia.org/T144458#3122358 (10jmatazzoni) [16:55:18] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016): Set up test instance for Deferred Changes - https://phabricator.wikimedia.org/T152443#3122362 (10jmatazzoni) [16:55:20] 06Collaboration-Team-Triage (Collab-Team-Q2-Oct-Dec-2016), 10MediaWiki-extensions-FlaggedRevs: Add Vagrant role for FlaggedRevs - https://phabricator.wikimedia.org/T152584#3122361 (10jmatazzoni) 05Open>03Resolved [17:23:50] stephanebisson: For your information and/or amusement: https://phabricator.wikimedia.org/T121644#3120326 [17:28:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#3122456 (10SBisson) [17:46:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Unbalanced spacing above and below the active filters la... - https://phabricator.wikimedia.org/T159966#3122490 [18:04:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Unbalanced spacing above and below the active filters la... - https://phabricator.wikimedia.org/T159966#3122570 [18:04:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for Active Filter Display Area - https://phabricator.wikimedia.org/T149391#3122571 (10... [18:14:59] RoanKattouw, I reviewed it, but I forgot I disabled Flow (to speed up provisioning). [18:15:09] Since it's a blocker, did you regression-test it enough, or should I enable it and do some? [18:15:28] I did regression-test it a bit but not all that much [18:15:58] RoanKattouw, okay, I'll enable the regular 'flow' (not 'wikimediaflow') and see how fast that is. [18:16:28] OK [18:16:49] Meanwhile I'm re-re-reprovisioning to try and get Wikidata to work [18:16:57] I had accidentally enabled the repo role instead of the client one [18:17:22] And provisioning takes forever, even just compiling the catalog takes 5 minutes [18:17:34] It's worse if you have a lot of roles enabled. [18:18:11] Oh, okay. Yeah, I think Wikidata worked for me out of the box, except the main page error (even though I fixed that, I think it might have failed due to an unrelated issue) and RC proagation. [18:19:17] There are also still some kinks in the new Jessie Vagrant. [18:19:25] RoanKattouw, are you on that BTW, or still Trusty? [18:19:44] (03PS4) 10Sbisson: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [18:21:19] I'm on the old stuff still [18:29:04] I also had to re-enable Flow locally to test this but now when I try to create a topic, the editor fails with: "Error: Module ext.visualEditor.core has failed dependencies" [18:29:52] the VE role is enabled and it provisionned successfully [18:30:47] (03CR) 10jerkins-bot: [V: 04-1] Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [18:32:14] With just 'flow' (not 'wikimediaflow'), it only took 22.74 seconds to compile catalog, and 118 to urn. Not bad. [18:35:03] VE loads for me, but I get an unrelated parsoid error. [18:42:05] Weird, now it started working, after several attempts to restart that seemed to do nothing. [18:43:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 05MW-1.29-release-notes, and 2 others: [Regression] Watchlist filters set in Preferences can't be disabled on Watchl... - https://phabricator.wikimedia.org/T160734#3122782 [18:46:21] (03CR) 10Mattflaschen: [C: 032] "Looks good. I did basic regression testing including a normal (non-reverse) pagination." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344073 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [18:47:59] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-General-or-Unknown, 10Outreach-Programs-Projects, and 4 others: Remind me of this article in X days - https://phabricator.wikimedia.org/T2582#3122807 (10srishakatux) [18:58:04] (03Merged) 10jenkins-bot: Make sure topiclist queries always join against workflow table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344073 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [18:58:22] (03CR) 10jenkins-bot: Make sure topiclist queries always join against workflow table [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344073 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [19:02:45] (03PS5) 10Sbisson: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [19:17:53] (03PS6) 10Sbisson: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [19:19:14] Getting lunch and going into the coworking space. [19:24:55] 06Collaboration-Team-Triage, 10Notifications, 10MediaWiki-Email: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876#3122940 (10Quiddity) Fresh request for this feature [[https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Notifications&diff=0&oldid=76616... [19:31:12] (03PS1) 10Catrope: Make sure topiclist queries always join against workflow table [extensions/Flow] (wmf/1.29.0-wmf.17) - 10https://gerrit.wikimedia.org/r/344188 (https://phabricator.wikimedia.org/T121644) [19:33:59] (03CR) 10Thcipriani: [C: 032] Make sure topiclist queries always join against workflow table [extensions/Flow] (wmf/1.29.0-wmf.17) - 10https://gerrit.wikimedia.org/r/344188 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [19:45:12] (03PS1) 10Catrope: Don't attempt to do reverse pagination in flow-loadmore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344191 (https://phabricator.wikimedia.org/T121644) [19:51:22] (03Merged) 10jenkins-bot: Make sure topiclist queries always join against workflow table [extensions/Flow] (wmf/1.29.0-wmf.17) - 10https://gerrit.wikimedia.org/r/344188 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [20:02:44] (03PS7) 10Sbisson: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [20:23:05] (03CR) 10Sbisson: [C: 032] Don't attempt to do reverse pagination in flow-loadmore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344191 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [20:28:42] matt_flaschen: Hmm I'm getting Invalid callback \Wikibase\Client\Hooks\MagicWordHookHandlers::onMagicWordwgVariableIDs in hooks for MagicWordwgVariableIDs and I don't understand why [20:32:52] I think it's an autoload issue [20:32:58] (03PS8) 10Sbisson: Run MWEchoThankYouEditTest on clean DB tables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344095 (https://phabricator.wikimedia.org/T161087) (owner: 10WMDE-leszek) [20:34:31] Worked around it by editing the generated autoload file :/ [20:37:37] (03Merged) 10jenkins-bot: Don't attempt to do reverse pagination in flow-loadmore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344191 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [20:37:55] (03CR) 10jenkins-bot: Don't attempt to do reverse pagination in flow-loadmore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344191 (https://phabricator.wikimedia.org/T121644) (owner: 10Catrope) [20:56:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3123242 (10C... [21:02:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Add technology so we'll be able to track usage of RC Pa... - https://phabricator.wikimedia.org/T158344#3034135 [21:05:58] RoanKattouw, weird, it worked for me (I also did a manual test of {{WBREPONAME}}) without changing any autoloader settings. [21:06:23] Maybe you need to do composer install, just a guess. [21:07:36] I tried that or something like it before and it wiped out all the subrepos and reinstalled them from github :/ [21:07:47] Anyway, I got it working, tested it, looked fine, so I +2ed [21:08:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, 13Patch-For-Review: Add technology so we'll be able to track usage of RC Pa... - https://phabricator.wikimedia.org/T158344#3123272 [21:09:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), 05MW-1.29-release-notes, and 2 others: [Regression] Watchlist filters set in Preferences can't be disabled on Watchl... - https://phabricator.wikimedia.org/T160734#3123274 [21:19:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07Accessibility, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Notifications only outputs numbers in raw HTML - https://phabricator.wikimedia.org/T160277#3093864 (10Etonkovidova) Checked in testwi... [21:23:44] 10MediaWiki-Watchlist, 10MediaWiki-Unit-tests, 05MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), 05MW-1.29-release-notes, and 2 others: WatchedItemStoreIntegrationTest fails when coverage is enabeld - https://phabricator.wikimedia.org/T160956#3123317 (10Krinkle) 05Open>03Resolved (03PS1) 10Umherirrender: Use tabs to indent in json [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344222 [21:38:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 07Accessibility, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Notifications only outputs numbers in raw HTML - https://phabricator.wikimedia.org/T160277#3093864 (10Volker_E) Nice! [21:50:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344234 (owner: 10L10n-bot) [21:50:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/344232 (owner: 10L10n-bot) [21:51:06] mooey|away: https://gerrit.wikimedia.org/r/#/c/344121/ might be relevant to your work on Capsule widget maybe? [22:07:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add session ID to filter usage and highlight usage data - https://phabricator.wikimedia.org/T160928#3123460 (10Catrope) These session IDs are not available on the server, but since both the (filter) logging and the b... [22:17:24] 06Collaboration-Team-Triage, 10ContentTranslation, 10Mobile-Content-Service, 10Parsoid, and 2 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3123479 (10mobrovac) [22:37:12] 06Collaboration-Team-Triage, 10Wikimedia-Developer-Summit (2017): Tools for curating and organizing editing work: what has been done and where to go next - https://phabricator.wikimedia.org/T148088#3123562 (10Aklapper) 05Open>03Resolved >>! In T148088#3015944, @srishakatux wrote: > @Harej are there any act... [22:46:16] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state - https://phabricator.wikimedia.org/T161172#3123639 (10Aklapper) I assume this is about #edit-review-improvements-rc-page ? If not please correc... [22:49:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state - https://phabricator.wikimedia.org/T161172#3123647 (10Etonkovidova) [22:52:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state - https://phabricator.wikimedia.org/T161172#3123680 (10Etonkovidova) [22:56:32] RoanKattouw, do you want to do a SWAT for the Wikibase today or tomorrow? [22:57:02] Ooh [22:57:04] Ahm [22:57:06] No strong opinion [22:59:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC filters - conflicting states for highlight-only filters do not have the tooltip for Conflict state - https://phabricator.wikimedia.org/T161172#3123694 (10Catrope) Ahm, why are those even red? Isn't that wrong? @Mo... [23:00:14] 06Collaboration-Team-Triage: [minor] All rclinks have the same tooltip 'Special:RecentChanges' - https://phabricator.wikimedia.org/T161176#3123697 (10Etonkovidova) [23:01:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] testiwiki - wrong tooltip 'Clear all filters' is displayed for 'Restore default filters' - https://phabricator.wikimedia.org/T161123#3123714 (10Etonkovidova) Resolved when wmf.17 was deployed - checked in tes... [23:01:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] testiwiki - wrong tooltip 'Clear all filters' is displayed for 'Restore default filters' - https://phabricator.wikimedia.org/T161123#3123715 (10Etonkovidova) 05Open>03Resolved p:05Triage>03Lowest [23:15:28] RoanKattouw, okay, I'll schedule for morning SWAT (11 AM tomorrow) [23:18:32] etonkovidova, we're going to add the Wikidata stuff for RC Filters to 1.29.0-wmf.17 tomorrow at 11 AM Pacific. [23:18:35] It's on Beta right now. [23:32:08] matt_flaschen: hmm... I do nto see it [23:33:21] Looking [23:33:28] etonkovidova: Do you have enhanced RC enabled? For some strange reason Wikidata (deliberately) does not work with enhanced RC [23:33:51] RoanKattouw: checking - although it does not look so [23:33:59] I don't think it's deliberate so much as they just haven't implemented it yet. [23:34:05] But it's disabled for me, and still doesn't work. [23:34:08] Sorry, should have checked first. [23:35:19] matt_flaschen: so Wikidata is not there yet? [23:38:28] etonkovidova, correct, I'm checking why. [23:38:36] thx! [23:53:20] RoanKattouw, etonkovidova, apparently it uses Extension:Wikidata (essentially a bundle of various extensions, which is updated daily: https://phabricator.wikimedia.org/diffusion/EWDA/repository/master/ [23:53:28] Aha [23:53:41] So we just have to wait a day [23:53:48] That also suggests that cherry-picking might be complicated [23:55:36] RoanKattouw, yeah, good point. I guess we should cancel the SWAT.