[00:10:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: ERI Metrics: Establish baseline for RC page tool usage prior to beta release - https://phabricator.wikimedia.org/T158447#3116648 (10jmatazzoni) @Catrope explains: ... we lose the ability to compute new aggregates aft... [00:11:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: For Conflict States, short-circuit the fruitless searches so as to save processing effort - https://phabricator.wikimedia.org/T160220#3116649 (10jmatazzoni) [00:12:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] RC filters - the highlight color selection box is not fully displayed at the bottom of viewport - https://phabricator.wikimedia.org/T160001#3116650 (10jmatazzoni) [03:50:39] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3116852 (10Shizhao) [03:51:13] 06Collaboration-Team-Triage, 10Flow, 07User-notice: Have all VE sequences available on Flow - https://phabricator.wikimedia.org/T134167#3116853 (10Shizhao) [05:24:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07Russian-Sites: Contact group 2 wikis concerning Filters for recent changes - https://phabricator.wikimedia.org/T158332#3116913 (10Liux... [09:26:10] 10MediaWiki-Watchlist: Feature Request: Multiple Watchlists for Bookmarking Articles - https://phabricator.wikimedia.org/T160981#3117159 (10BaronBoehm) [09:35:14] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07Community-Wishlist-Survey-2015, and 3 others: Refactor watchlist related code to use WatchedItemStore - https://phabricator.wikimedia.org/T129478#3117200 (10Addshore) [09:36:05] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist, and 2 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508#3117208 (10Addshore) [09:36:07] 10MediaWiki-Watchlist: Show when pages were added to watchlist - https://phabricator.wikimedia.org/T67187#3117209 (10Addshore) [09:36:10] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_timestamp to the watchlist table - https://phabricator.wikimedia.org/T125991#3117206 (10Addshore) 05Open>03stalled [09:36:15] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07Community-Wishlist-Survey-2015, and 3 others: Refactor watchlist related code to use WatchedItemStore - https://phabricator.wikimedia.org/T129478#2106944 (10Addshore) 05Open>03stalled [09:36:19] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist, and 2 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508#1314442 (10Addshore) [10:10:50] 10MediaWiki-Watchlist: Feature Request: Multiple Watchlists for Bookmarking Articles - https://phabricator.wikimedia.org/T160981#3117320 (10Aklapper) [10:10:56] 10MediaWiki-Watchlist: Feature Request: Multiple Watchlists for Bookmarking Articles - https://phabricator.wikimedia.org/T160981#3117159 (10Aklapper) Hi @BaronBoehm, thanks for taking the time to report this! This particular problem has already been reported into our bug tracking system as T3492, but please feel... [10:10:58] 10MediaWiki-Watchlist, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#3117323 (10Aklapper) [10:23:30] 10MediaWiki-Watchlist: Feature Request: Multiple Watchlists for Bookmarking Articles - https://phabricator.wikimedia.org/T160981#3117378 (10BaronBoehm) Thanks! I noticed it isn't assigned to anyone. How does the assignment of tasks work? Can anyone contribute to the project or does it have to be some approved d... [10:35:03] 10MediaWiki-Recent-changes: RecentChanges has buggy function [numRows() with $wgAllowCategorizedRecentChanges] - https://phabricator.wikimedia.org/T85742#3117407 (10matmarex) 05Open>03Resolved a:03matmarex [10:48:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3117451 (10Pginer-WMF) I did an initial exploration for a more long-term solution. The user goals for these l... [11:50:12] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07Community-Wishlist-Survey-2015, and 3 others: Refactor watchlist related code to use WatchedItemStore - https://phabricator.wikimedia.org/T129478#3117539 (10Addshore) [11:50:14] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07German-Community-Wishlist: [Task] Refactor Special:RecentchangesLinked to use WatchedItemStore - https://phabricator.wikimedia.org/T132569#3117535 (10Addshore) 05Open>03stalled Stalled pending resuming work here once wl_id is deployed on... [11:50:19] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07Community-Wishlist-Survey-2015, and 3 others: Refactor watchlist related code to use WatchedItemStore - https://phabricator.wikimedia.org/T129478#2106944 (10Addshore) [11:50:22] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07German-Community-Wishlist, and 4 others: [Task] Refactor Special:Recentchanges to use WatchedItemStore - https://phabricator.wikimedia.org/T132568#3117540 (10Addshore) 05Open>03stalled Stalled pending resuming work here once wl_id is depl... [11:50:34] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07German-Community-Wishlist: Introduce watchlist_props table - https://phabricator.wikimedia.org/T129486#3117548 (10Addshore) 05Open>03stalled Stalled pending resuming work here once wl_id is deployed on wmf sites (T130067). [11:50:36] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist, and 2 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508#3117552 (10Addshore) [11:50:40] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07Community-Wishlist-Survey-2015, and 3 others: Refactor watchlist related code to use WatchedItemStore - https://phabricator.wikimedia.org/T129478#2106944 (10Addshore) Stalled pending resuming work here once wl_id is deployed on wmf sites (T13... [11:50:49] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist, and 2 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508#1315389 (10Addshore) [11:51:02] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist, and 2 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508#1316019 (10Addshore) [11:51:12] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07German-Community-Wishlist: Watch pages for a few days only (add an expiry time) - https://phabricator.wikimedia.org/T8964#3117566 (10Addshore) 05Open>03stalled Stalled pending resuming work here once wl_id is deployed on wmf sites (T130067). [11:51:18] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 06TCB-Team, 07German-Community-Wishlist: Watch pages for a few days only (add an expiry time) - https://phabricator.wikimedia.org/T8964#3117574 (10Addshore) [11:51:23] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 07Community-Wishlist-Survey-2015, 07German-Community-Wishlist, and 2 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508#1325849 (10Addshore) 05Open>03stalled Stalled pending resuming work... [12:37:52] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Tracking, 07User-notice: Release RC Page filtering to non-ORES wikis - https://phabricator.wikimedia.org/T158004#3117640 (10Trizek-WMF) [12:37:55] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (i... - https://phabricator.wikimedia.org/T158225#3117637 [13:31:14] 10MediaWiki-Watchlist: Feature Request: Multiple Watchlists for Bookmarking Articles - https://phabricator.wikimedia.org/T160981#3117739 (10Aklapper) >>! In T160981#3117378, @BaronBoehm wrote: > I noticed it isn't assigned to anyone. How does the assignment of tasks work? Can anyone contribute to the project or... [14:46:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3117950 (10Halfak) Damage patrollers need to catch most-all of the dam... [15:29:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3118057 (10jmatazzoni) OK. Thanks Aaron. Let's move forward as planned... [15:33:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform ORES sensitivity levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3118065 (10jmatazzoni) [15:59:48] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07Russian-Sites: Contact group 2 wikis concerning Filters for recent changes - https://phabricator.wikimedia.org/T158332#3118122 (10Triz... [15:59:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact communities for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T146972#3118126 (10Trizek-WMF) [15:59:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017), 07Russian-Sites: Contact group 2 wikis concerning Filters for recent changes - https://phabricator.wikimedia.org/T158332#3118124 (10Triz... [16:00:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 07User-notice: Enable the ORES good faith and damaging UI by default, on wikis that have these ORES models available (i... - https://phabricator.wikimedia.org/T158225#3118125 [16:07:10] stephanebisson: I am very puzzled by https://phabricator.wikimedia.org/T160493 -- betalabs simply does not have oresm_model for good faith and only 'damaging' has been used for scoring [16:10:36] etonkovidova, I believe there is a real goodfaith model on enwiki ( https://ores-beta.wmflabs.org/scores/enwiki/goodfaith/?model_info=test_stats&format=json ) which I think is in the database, but a fake one on the others ( https://ores-beta.wmflabs.org/scores/testwiki/goodfaith/?model_info=test_stats&format=json ) (just last two digits of rev_id, not really related to revision quality), second one not in the DB. [16:11:23] Fake one only for Beta, of course. [16:12:06] stephanebisson: matt_flaschen: yes, I was checking fake ones locally. Hmm... [16:12:42] matt_flaschen: stephanebisson; select * from ores_model; only 'damaging' and 'reverted' [16:12:52] matt_flaschen: select distinct(oresc_model) from ores_classification; only 'damaging' [16:13:03] Actually, though, I am not sure. Now that I think about it more, the fake one should still be cached in the wiki's table, I think. [16:13:49] etonkovidova, I'm working on the Wikidata right now, but I'll try to follow up later. Which wiki are those queries from? [16:13:59] I do not see it - when I was checking 'good-faith' I followed stephanebisson' instructions locally [16:14:32] etonkovidova, which wiki on Beta? [16:14:54] matt_flaschen: enwiki [16:15:04] Okay, thanks. [16:15:44] but do not get distracted - work on wikidata. I will look more into it when I sort out other stuff [16:37:33] etonkovidova: the ores server in beta labs doesn't support the goodfaith model [16:37:57] Wait... it should [16:38:05] stephanebisson, ^ [16:38:12] stephanebisson: that's right - and that's why I was surprised with https://phabricator.wikimedia.org/T160493 [16:38:51] halfak: it respond to damaging with a fake score (last digits of rev id) but errors out with "bad request" for goodfaith, last time I checked [16:40:02] Oh! looks like we're getting bit by https://phabricator.wikimedia.org/T160762 [16:40:25] It's preventing all models from working. [16:40:28] https://ores-beta.wmflabs.org/v2/scores/testwiki/damaging/10 [16:40:33] https://ores-beta.wmflabs.org/v2/scores/testwiki/goodfiath/10 [16:40:40] *https://ores-beta.wmflabs.org/v2/scores/testwiki/goodfaith/10 [16:42:49] I'm looking into a temporary fix now. [16:44:27] I thought beta labs was calling https://ores.wikimedia.org/v1/scores/testwiki/goodfaith/10 which seems to work now [16:44:47] 10MediaWiki-Watchlist, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#3118271 (10Jdlrobson) [16:45:04] hmm [16:45:12] Must be that something else freed up some disk [16:45:17] 10MediaWiki-Watchlist, 07Community-Wishlist-Survey-2015, 07Community-Wishlist-Survey-2016: Multiple watchlists - https://phabricator.wikimedia.org/T3492#56845 (10Jdlrobson) [16:47:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3118285 (10Trizek-... [16:47:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Portuguese Wikipedia about testing ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T156157#3118286 (10Trizek-W... [16:52:25] etonkovidova: So it looks like ores in betalabs responds to goodfaith but it's turned off on the mediawiki config side. It would be useful to have it on. [16:52:39] 10MediaWiki-Watchlist: Feature Request: Multiple Watchlists for Bookmarking Articles - https://phabricator.wikimedia.org/T160981#3117159 (10Jdlrobson) @BaronBoehm FWIW https://trending.wmflabs.org/ provides this functionality (although all lists are public) and there was a failed attempt to build this at https:/... [16:53:39] stephanebisson: ok What do you mean by 'ores in betalabs responds to goodfaith' since we do not have good-faith scored records in ores_classificaiton? [16:56:14] etonkovidova: There's two sides to this: 1) The mediawiki side with ores extension, which ores_classification is part of. It is currently disabled there, that's why it's not in the DB. 2) The ores server providing scores on revisions for various models. Goodfaith is up and running there. It just need to be consumed by mediawiki. [16:56:48] stephanebisson: ah! thanks a lot - understood now :)) [17:18:40] mooeypoo, did you say something about ORES conflicts? [17:23:39] matt_flaschen: https://gerrit.wikimedia.org/r/#/c/343783/ [17:24:32] Ah, good catch [17:25:15] RoanKattouw, I don't know of a similar analytics-oriented ID (like mw.user.sessionId()) on the server. [17:25:24] matt_flaschen: Also, re T160928, I suggested that we could add mw.user.sessionId() to client-side EventLogging events, but I don't think we can easily add it to server-side ones, unless there's a comparable server-side facility or we come up with a trick [17:25:24] T160928: Add session ID to filter usage and highlight usage data - https://phabricator.wikimedia.org/T160928 [17:25:26] Ah, jinx [17:26:11] RoanKattouw, there's the real session ID (MediaWiki\Session\Session->getId), but I don't know much about that. [17:26:56] That... seems a bit scary? [17:27:06] Maybe? [17:27:08] I really don't know. [17:27:27] I'll ask the analytics people [17:27:29] RoanKattouw, it definitely shouldn't be made public. [17:27:34] Well sure [17:28:06] RoanKattouw, and you could consider IP. The data is purged anyway, so using the IP temporarily may be simplest, if Analytics allows that. [17:28:24] Right [17:28:30] User name or IP if logged out [17:28:44] RoanKattouw, user ID is better. [17:28:48] I think that's allowed, subject to 90-day purging [17:28:56] Yes, user ID, good point [17:29:08] Maybe even global usre ID [17:41:41] I missed the branch cut. We'll have to evaluate if we want to SWAT the Wikidata. [17:45:52] Is it ready for review? [17:47:28] RoanKattouw, no, I should have it done in a few hours. [17:47:48] Ok, cool [18:00:53] 06Collaboration-Team-Triage, 10Flow: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3109833 (10Catrope) This happens because Flow tries to access `sessionStorage`, which throws an exception. The weird Storer module that Flow uses doesn't han... [18:06:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Educate users about the highlight option and encourage them to try it - https://phabricator.wikimedia.org/T151006#2804422 (10jmatazzoni) a:03SBisson [18:10:54] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118638 (10Trizek-WMF) [18:11:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) [18:11:16] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118653 (10Trizek-WMF) [18:11:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#2667891 (10Trizek-WMF) Update: ima... [18:15:07] matt_flaschen: Do you have any recollection of what StorageEngine (Storer) is/was used for in Flow? It appears to be unused in master but its initialization throws an exception breaking everything if sessionStorage is not available (T160754) [18:15:07] T160754: Posting a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754 [18:25:47] (03PS1) 10Catrope: Remove Storer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/343939 (https://phabricator.wikimedia.org/T160754) [18:45:33] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118770 (10jmatazzoni) [18:45:45] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118638 (10jmatazzoni) [18:57:30] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 6 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3118796 (10Jdforrester-WMF) VE/MF changed in... [18:58:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 07Documentation: Create screenshots for Recent Changes Filters Beta project - https://phabricator.wikimedia.org/T161015#3118799 (10jmatazzoni) [19:03:34] RoanKattouw, I think a backfill for old browsers missing one of them (e.g. localStorage or sessionStorage, don't remember exact details) [19:04:22] matt_flaschen: Sure, but I grepped the code base and nothing seems to actually be using the FlowStorage instance [19:04:46] RoanKattouw, probably replaced in the OOjs UI rewrite. [19:04:53] Maybe there are things calling it in a way that my grep missed? [19:04:54] Oh good point [19:05:10] RoanKattouw, and yeah, we have way too many of these storage backfills (across the Wikimedia world), so glad you're getting rid of it. [19:07:12] 06Collaboration-Team-Triage, 10ContentTranslation, 10Parsoid, 10VisualEditor, and 2 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3116336 (10Jdforrester-WMF) [19:16:58] RoanKattouw, used until 5e62ef2e961d77630725f68d46e1c52fc6846508 for tracking topic collapse states. Maybe other things, but now that I found that IIRC that was the main one. [19:17:10] Aaah interesting [19:25:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC page filters show incorrect results if user terminates the session in different tab - https://phabricator.wikimedia.org/T161021#3118942 (10Etonkovidova) [19:26:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC page filters show incorrect results if user terminates the session in different tab - https://phabricator.wikimedia.org/T161021#3118965 (10Etonkovidova) [19:27:17] (03CR) 10Mattflaschen: [C: 032] Remove Storer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/343939 (https://phabricator.wikimedia.org/T160754) (owner: 10Catrope) [19:27:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC page filters show incorrect results if user terminates the session in different tab - https://phabricator.wikimedia.org/T161021#3118942 (10SBisson) ORES filters will not be applied for anons (for the simple reaso... [19:31:47] 06Collaboration-Team-Triage, 10ContentTranslation, 10Parsoid, 10VisualEditor, and 2 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3119016 (10GWicke) I don't think the rendering differe... [19:33:25] (03PS1) 10Bartosz Dziewoński: Simplify definition of 'ext.echo.badgeicons' module [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343951 [19:34:18] (03CR) 10Bartosz Dziewoński: "This feature of ResourceLoaderImageModule used to be undocumented, but I just documented it here: https://www.mediawiki.org/wiki/ResourceL" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343951 (owner: 10Bartosz Dziewoński) [19:38:49] (03Merged) 10jenkins-bot: Remove Storer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/343939 (https://phabricator.wikimedia.org/T160754) (owner: 10Catrope) [19:41:00] (03CR) 10jenkins-bot: Remove Storer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/343939 (https://phabricator.wikimedia.org/T160754) (owner: 10Catrope) [19:58:09] 06Collaboration-Team-Triage, 10ContentTranslation, 10Parsoid, 10VisualEditor, and 2 others: Parsoid image output is (intentionally) missing the magnify links found in PHP parser output, leading to differences - https://phabricator.wikimedia.org/T160960#3119142 (10Jdforrester-WMF) It was intentionally not d... [20:03:23] RoanKattouw, up and working. [20:04:13] The Wikidata thing was simple (I'll Puppetize that next), though it's a bit of a mystery to me how the site links are configured. In this case, it matched the DB name. [20:04:32] I know the jQueryMsg thing is a bit ugly. [20:04:41] The alternatives are: [20:04:50] But it is dispatching changes now. [20:05:00] Alternatives to jQueryMsg thing: [20:05:32] 1. Make mw.jqueryMsg.setParserDefaults deep (breaking change that requires tweaking other code, though fairly simple). [20:05:38] 2. Add a $wg and put the rest in JS. [20:06:27] I like #2, because I think Wikidata shouldn't need to add such a complex RL module to get a magic word in [20:06:46] If core just supported $wgJSMagicWords or whatever, extensions could just add to that [20:07:42] RoanKattouw, okay, sounds good. [20:11:11] Will review your Wikidata patch after lunch [20:18:15] RoanKattouw, okay, I'm going to take a break, then finish the jQueryMsg change. [20:31:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [monobook] RC filters UI needs adjustments - https://phabricator.wikimedia.org/T161033#3119278 (10Etonkovidova) [21:03:17] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: DBQueryError line 1061 - https://phabricator.wikimedia.org/T161040#3119439 (10thcipriani) [21:03:59] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: DBQueryError line 1061 - https://phabricator.wikimedia.org/T161040#3119454 (10thcipriani) [21:05:09] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: DBQueryError line 1061 - https://phabricator.wikimedia.org/T161040#3119439 (10demon) Full stracktrace: ``` #0 /srv/mediawiki/php-1.29.0-wmf.17/includes/libs/rdbms/database/Database.php(919): Database->reportQueryError(string, integer, string, strin... [21:06:10] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T161040#3119460 (10demon) [21:09:23] 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3119483 (10Krinkle) [21:09:36] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T161040#3119439 (10Reedy) workflow_last_update_timestamp is in table flow_workflow, not flow_topic_list [21:10:31] 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3119508 (10Krinkle) [21:10:38] 10MediaWiki-Watchlist, 10MediaWiki-Unit-tests: WatchedItemStoreIntegrationTest fails when coverage is enabeld - https://phabricator.wikimedia.org/T160956#3119510 (10Krinkle) [21:14:30] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T161040#3119559 (10Reedy) Does anyone outside of Mobile/Zero have an account on zerowiki without creating one via createAndPromote? [21:15:49] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T161040#3119569 (10Catrope) [21:15:51] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3119572 (10Catrope) [21:18:05] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3119608 (10Reedy) [21:18:14] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T161040#3119610 (10Reedy) [21:19:37] 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3119634 (10Krinkle) [21:19:58] 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3119483 (10Krinkle) [21:29:11] matt_flaschen: Are you aware of / working on the Jenkins failures for the Wikidata change? [21:29:33] The qunit one is weird but the other three seem to be an actual test failure / PHP error [21:35:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344001 (owner: 10L10n-bot) [21:42:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343998 (owner: 10L10n-bot) [21:42:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC page filters show incorrect results if user terminates the session in different tab - https://phabricator.wikimedia.org/T161021#3118942 (10Mooeypoo) The highlight is also on the ORES filters, so it seems like it... [21:42:57] matt_flaschen: How do you get your Wikidata patch running without the weird WikidataBuildResources stuff? [21:50:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Make the generic "recentchanges-noresults" message bold - https://phabricator.wikimedia.org/T160935#3119818 (10Mooeypoo) a:03Mooeypoo [21:56:23] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3119834 (10Reedy) >>! In T161040#3119455, @demon wrote: > Full stracktrace: > ``` > #0 /srv/mediawiki/php-1.29.0-wmf.17/incl... [22:06:59] RoanKattouw, for my current patch to proprerly normalize font-size in the overlay, can I just say in the commit message Bug: Monobook ? [22:09:52] RoanKattouw: 'r' !='May have problems' ?! I see that a new page on beta cawiki was scored with damaging score=0.430 and yet, no 'r'? [22:10:32] etonkovidova: It depends on your sensitivity setting. There is a task to align the sensitivity levels to the may/likely/verylikely levels [22:10:47] The sensitivity settings are 0.50 (high), 0.70 (low) and 0.90 (lowest) IIRC [22:11:38] RoanKattouw: so, many records that are classified as 'May have problems' are not marked with 'r' hmm... [22:12:20] RoanKattouw: 'May have problems' - 16%-100% [22:14:17] 06Collaboration-Team-Triage, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 3 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#3119925 (10happy5214) I will write out an application for this project and post it later this week or this weekend. [22:41:38] Yeah, may have problems is >=0.16 but "r" with "high" is >=0.50 [22:48:59] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3120113 (10Catrope) I can reproduce this locally, it looks like it happens whenever `api.php?action=flow&submodule=view-topi... [23:12:18] (03PS1) 10Reedy: Fix space indenting to tabs in flow.sql [extensions/Flow] - 10https://gerrit.wikimedia.org/r/344052 [23:19:41] RoanKattouw, I'm using WikidataBuildResources, per the default Vagrant role. Wikibase is just a git repo inside of that, not too complicated. [23:20:00] extensions/WikidataBuildResources/extensions/Wikibase [23:20:08] And the git repo is right in there as normal. [23:20:35] I couldn't get the autoloader rebuild to work when git review -d ing your patch [23:22:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: [monobook] RC filters UI needs adjustments - https://phabricator.wikimedia.org/T161033#3120227 (10Mooeypoo) a:03Mooeypoo [23:25:29] RoanKattouw, now that you mention it, I never thought about how JQueryMsgModule.php was loaded. [23:25:45] RoanKattouw, apparently it's by directory (extensions/WikidataBuildResources/extensions/Wikibase/composer.json) [23:28:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: RC ORES filter do not force a changed state to 'r': it displayed black until page reloaded - https://phabricator.wikimedia.org/T161060#3120242 (10Etonkovidova) [23:39:00] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Provide ORES scores on hover for pages with RC Filters - https://phabricator.wikimedia.org/T159196#3120280 (10jmatazzoni) [23:41:06] Ugh I see [23:41:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Gadget-LiveRC developers concerning ERI improvements - https://phabricator.wikimedia.org/T158855#3120308 (10jmatazzoni) [23:41:46] matt_flaschen: BTW, phab comment inbound, but I found out what causes the Flow exception where it tries to ORDER BY a field from the wrong table, and in a weird twist it's your "fix history pagination" commit [23:44:12] RoanKattouw, yeah, I'm not shocked. There were different problems before that, though. [23:44:18] 06Collaboration-Team-Triage, 10Flow, 07Wikimedia-log-errors: Fail to load more topics above current topic due to pseudo-column being queried - https://phabricator.wikimedia.org/T121644#3120326 (10Catrope) This appears to have been caused by {699c5d86fcea91a30a449054aaefb8ab8495a943} which made `TopKIndex` ex... [23:44:20] 06Collaboration-Team-Triage, 10Flow, 07Accessibility, 07Easy: {CTRL} + {ENTER} should post a post in flow - https://phabricator.wikimedia.org/T158779#3120328 (10jmatazzoni) [23:44:25] Oh yes, and I'm not suggesting we revert it [23:44:48] https://phabricator.wikimedia.org/T121644#3120326 explains it. ebernhardson helped me find it by running the hhvm debugger in prod and generally knowing a lot about this code [23:45:01] 06Collaboration-Team-Triage, 10Notifications, 07Easy: More clearly described Notification options in Preferences - https://phabricator.wikimedia.org/T158756#3120335 (10jmatazzoni) [23:46:07] RoanKattouw, that's not quite the patch I thought you meant though. But it's been a while, so I don't really remember the different patches specifically. [23:46:37] RoanKattouw, TopKIndex is very limiting, it's not really just an optimization, some things only work(ed) within the index. [23:47:54] Yeah [23:48:19] The only thing I was focusing on there (a small change within your much larger one) is having TopKIndex reject reverse-sorting queries [23:48:27] Which is totally sensible, it's a TOP K Index [23:48:35] But it meant that the hack used for sorting by timestamp exploded [23:48:45] Like removing a piece from a Jenga tower [23:50:34] RoanKattouw, the Index layer is also like a Jenga tower in an additional way. It makes more and more sense if you think only about it. But the instant you think about anything else, the Jenga tower collapses. [23:51:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page: Update WMF-deployed filter-defining extensions that are not specifically targeted for initial Beta feature - https://phabricator.wikimedia.org/T159778#3120359 (10jmatazzoni) [23:52:04] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements: Support all parameters in ApiFeedRecentChanges - https://phabricator.wikimedia.org/T159773#3120360 (10jmatazzoni) [23:57:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 13Patch-For-Review, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3120367 (10jmatazzoni) [23:57:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 05MW-1.29-release (WMF-deploy-2017-03-07_(1.29.0-wmf.15)), 13Patch-For-Review, 07Wikimedia-log-errors: Flow: DateTimeZone::__construct(): Unknown or bad timezone (+00:00) - https://phabricator.wikimedia.org/T159372#3065627 (10jmatazzoni)... [23:57:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Recent-changes, 10MediaWiki-Unit-tests: ChangesListSpecialPageTest::testFilterUserExpLevel fails when coverage is enabled - https://phabricator.wikimedia.org/T161041#3120372 (10Mattflaschen-WMF) [23:58:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Thanks, 07User-notice-collaboration: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3120373 (10jmatazzoni) [23:59:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Thanks, 07User-notice-collaboration: Thanks confirmation message is confusing - https://phabricator.wikimedia.org/T159302#3063495 (10jmatazzoni) a:03jmatazzoni