[00:22:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3108754 (10Mooeypoo) a:03Mooeypoo [00:30:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3108778 (10jmatazzoni) There are various differences in the feature as implemented vs. as d... [02:13:27] 06Collaboration-Team-Triage, 10MediaWiki-extensions-PageCuration: Mainspace pages moved from other namespaces via the API should be added to the page curation queue - https://phabricator.wikimedia.org/T155289#3108892 (10GeoffreyT2000) [05:39:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3109050 (10Catrope) I think the description also misunde... [05:44:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3109052 (10Catrope) >>! In T15... [05:45:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Filters' background for selected filters always looks grey - https://phabricator.wikimedia.org/T160574#3103972 (10Catrope) To clarify, you are talking about the filter capsules, not the list en... [06:48:30] 06Collaboration-Team-Triage, 10Flow, 07Easy: Flow: Hiding, Restoring, or Closing a topic strikes out greys and italicizes the entry in feeds - https://phabricator.wikimedia.org/T67092#689945 (10Rammanojpotla) Can I work on this issue, and can anyone give me more details of it [08:35:05] 06Collaboration-Team-Triage, 10Flow, 07Easy: Edit description link should be grey by default, not blue - https://phabricator.wikimedia.org/T112872#3109169 (10Rammanojpotla) I want to start with this issue, Can anyone say me how to proceed [09:06:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3109199 (10Pginer-WMF) >>! In... [09:10:02] 10MediaWiki-Watchlist: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3109201 (10Schnark) [09:34:13] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3109242 (10Pginer-WMF) >>! In T159186#3108778, @jmatazzoni wrote: > There are various diffe... [09:46:19] 10MediaWiki-Watchlist, 07Regression: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3109289 (10Schnark) @Mattflaschen-WMF, @Catrope: Given that {rMWaa063f4c5a19e2a267e694e3614af1c3ce4498da} is a rather large change, that was deployed... [10:11:50] 06Collaboration-Team-Triage, 10Flow, 07Tracking: Flow mentions (tracking) - https://phabricator.wikimedia.org/T108400#3109322 (10matej_suchanek) [10:11:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 3 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3109321 (10matej_suchanek) [11:07:54] 10MediaWiki-Watchlist, 10MediaWiki-User-preferences: Show my edits in Special:Watchlist doesn't work - https://phabricator.wikimedia.org/T160742#3109400 (10Dvorapa) [11:08:43] 10MediaWiki-Watchlist, 10MediaWiki-User-preferences: Show my edits in Special:Watchlist doesn't work - https://phabricator.wikimedia.org/T160742#3109413 (10Dvorapa) [11:14:31] 10MediaWiki-Watchlist, 07Regression: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3109418 (10matmarex) [11:14:33] 10MediaWiki-Watchlist, 10MediaWiki-User-preferences: Show my edits in Special:Watchlist doesn't work - https://phabricator.wikimedia.org/T160742#3109420 (10matmarex) [11:16:54] (03PS1) 10WMDE-Fisch: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343278 [13:22:48] 06Collaboration-Team-Triage, 10Flow, 07Easy: Edit description link should be grey by default, not blue - https://phabricator.wikimedia.org/T112872#3109609 (10Aklapper) @Rammanojpotla: Please see the [[ https://gerrit.wikimedia.org/r/266336 | comments in the Gerrit link ]] for pointers, and [[ https://www.med... [13:24:11] 06Collaboration-Team-Triage, 10Flow, 07Easy: Flow: Hiding, Restoring, or Closing a topic strikes out greys and italicizes the entry in feeds - https://phabricator.wikimedia.org/T67092#3109610 (10Aklapper) @Rammanojpotla: Please see https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Feedback.2C_q... [14:38:03] 06Collaboration-Team-Triage, 10Flow: Post a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3109833 (10Trizek-WMF) [14:38:58] 06Collaboration-Team-Triage, 10Flow: Post a message on Flow is not possible when cookies are not activated - https://phabricator.wikimedia.org/T160754#3109846 (10Trizek-WMF) [15:53:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3110050 (10T... [16:01:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3110070 (10j... [16:06:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3110078 (10T... [16:07:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3110081 (10Trizek-WMF) Note concer... [17:00:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3110270 (10jmatazzoni) [17:01:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2853777 (10jmatazzoni) @Mooeypoo, I shortened the 'What's This' texts considerably (from 70 words down to about 50).... [17:08:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3110306 (10jmatazzoni) [17:38:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Implement 'What's This' Links on the dropdown filter panel - https://phabricator.wikimedia.org/T159186#3059541 (10Catrope) We can probably make the i18n messages wikitext messages and deliver th... [17:39:39] 10MediaWiki-Watchlist, 07Regression: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3110438 (10Catrope) a:03Catrope I have to go run an errand now, but when I get back (in 45-60 mins) I'll look into this. [18:39:59] RoanKattouw, I'm looking at the watchlist thing as well. [18:44:52] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Change the text of the 'What's This?' popups - https://phabricator.wikimedia.org/T160779#3110562 (10jmatazzoni) [19:04:15] I don't actually see the hidden fields in the form, even before my change. It's weird. [19:12:20] Hmm so bisect does point to your change [19:12:30] Interestingly your change also adds a bunch of filters to the watchlist that weren't there before [19:13:34] Before: minor - bots - anons - registered - mine - cats. After: registered - anons - mine - bots - minor - cats - Wikidata - probably good [19:14:05] Actually maybe that's just a reordering, and Wikidata+ORES going away in the "before" state because I didn't downgrade their extensions? [19:14:35] matt_flaschen: What hidden fields are you expecting? [19:16:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3110625 (10E... [19:17:21] Oh I see [19:17:30] RoanKattouw, there's some trickiness since unchecked checkboxes are not POSTed, and I'm trying to figure out how exactly it worked before. [19:17:32] But it did. [19:17:32] Hmm, showHideCheck() seems to expect a param by reference but doesn't get it [19:17:55] I figured it probably worked by deliberately not merging the defaults in with the query string [19:18:06] But I haven't found this code quite yet [19:18:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#2753136 (10E... [19:18:34] Anyway, $options[$name] = 1 - (int)$value; is very strange since $options is not passed by reference and is not used in the function after that [19:19:08] RoanKattouw, I didn't change the signature, and it doesn't take by reference. [19:19:22] Good call on the $options dead code, though. [19:19:31] Yeah I'm not saying that you broke that, I'm looking at the pre-you state [19:19:34] Just saying it's odd [19:19:39] Oh I found something interesting: [19:19:42] https://www.irccloud.com/pastebin/8tOauZto/ [19:20:09] This means that getDefaultOptions() doesn't actually return the defaults if action==submit (in the old code) [19:21:21] And in the new code, it looks like this: [19:21:25] https://www.irccloud.com/pastebin/yEa5xdGx/ [19:21:57] Which I should totally have caught in CR, having code like if ( foo ) { return $opts; } return $opts; is obviously silly [19:24:33] OK, I found it [19:24:47] The code for setting defaults based on filters moved up to ChangesListSpecialPage [19:25:24] But that means that SpecialWatchlist can't short-circuit it any more, and it's also not needed for subclasses that don't have form fields for filters like SpecialRecentchanges [19:25:36] ( matt_flaschen ) [19:26:30] I'll try separating out that code into a method that only Watchlist calls [19:27:16] RoanKattouw, still grok-ing. I see the old code you linked just uses the parent's defaults (which are all false), and doesn't set the watchlist defaults. [19:27:39] OK, so, Watchlist is the only CLSP subclass that uses form fields for filters [19:28:01] So previously, the code for setting defaults for filters in FormOptions only existed in Watchlist [19:28:11] And it short-circuited that part out of action=submit [19:28:27] In your change, the code setting defaults for filters into FormOptions moved up to CLSP [19:28:51] Which means that Recentchanges and RCLinked now run this code too (uselessly, because they don't have those form fields) and that Watchlist can't short-circuit it any more [19:29:12] RoanKattouw, well, kind of, CLSP set defaults, they were just all false. [19:29:26] Did it? Where? [19:29:36] RoanKattouw, getDefaultOptions [19:30:01] Oh! Yes I see [19:30:04] That's a bit confusing [19:30:20] It's very confusing, especially how SpecialWatchlist->getDefaultOptions doesn't do what it says at all on submit. [19:30:25] Oh and I guess the parameters are still parsed through FormOptions in RC< even though they're not really form field [19:30:37] RoanKattouw, GET is still considered a field by the server. [19:30:50] As far as it knows, you could even have used a form with method="GET" [19:31:33] Right, yes, it makes sense that it works [19:31:44] It's just mildly confusing to use FormOptions for things that aren't form fields [19:32:35] Well, they might be if it's a
with GET, server doesn't really know. [19:32:43] RoanKattouw, anyway, it would be good to fix this in a non-confusing way. [19:32:46] RoanKattouw, how about this: [19:33:13] 1. getDefaultOptions really does the default options. [19:33:28] There's a difference though between how RC and Watchlist interpret their query strings and that difference is caused by how checkboxes work [19:33:33] Yeah [19:33:39] OK, sorry, go on [19:33:57] 2. All the boolean fields are put at the beginning of the Watchlist as 0 (due to checkboxes not being submitted if unchecked). [19:34:25] 3. Checkboxes go next, based on the current value (respecting the defaults and the submitted field). [19:34:42] By #2 you mean a series of input type=hidden fields? [19:34:53] Yeah [19:35:01] I guess this would clutter the URL though [19:35:44] Yes, though no worse than RC [19:35:56] Open to other non-confusing ways to do it. [19:36:41] I liked the original code's notion of "if it's a submit, don't look at defaults, cause they'll have been baked into the form already", but I also recognize that's incompatible with the approach that RC uses [19:37:15] RoanKattouw, grokking better now. This is why the old code ignores the defaults. Since pretending the defaults are all false (despite this not being true) mimics the hidden field idea. [19:37:21] If we want to support that method, we could add a way for Watchlist to flag that it's a form-based subclass rather than a link-based one [19:37:30] Exactly [19:38:09] All the hidden field stuff in the Watchlist code is a red herring that doesn't work, possibly because of the missing pass-by-reference [19:39:29] RoanKattouw, how about this: [19:39:36] But yeah the idea behind short-circuiting is that once you've put the defaults in the form as initial state, you don't need to merge them in again (and in the case of checkboxes it's harmful to do so) [19:39:43] SpecialWatchlist->fetchOptionsFromRequest [19:39:51] First fetch from a FauxRequest filled with false. [19:39:58] Then re-fetch with the real values. [19:40:26] Whoa lemme try to grok that [19:40:55] I don't get it [19:40:59] It's basically the same as now, except we stop lying about the defaults, and just reflect how checkboxes work. [19:41:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [minor] Active filter display area - rows of filters do not have space between rows - https://phabricator.wikimedia.org/T160784#3110706 (10Etonkovidova) [19:41:18] RoanKattouw, unchecked checkboxes don't get sent. [19:41:29] So if you deliberately uncheck, you won't override the defaults (if defaults are really defaults) [19:41:52] Ooh [19:41:56] So instead, we "send" the unchecked checkboxes by coping hideminor=0, hideanon=0 into $opts. Finally, we handle the checked ones from the request, which are sent. [19:42:02] The first fetch filled with false is to wipe out the defaults? [19:42:14] Yep [19:42:18] Someone just called me, brb [19:42:18] I see [19:42:20] Nice trick [19:43:04] OK, in the meantime I'll go get lunch. The fetchOptionsFromRequest() strategy sounds good to me though [19:43:11] Yeah I should eat too. [19:43:31] RoanKattouw, I'll do it when I get back if that's okay. [19:43:40] Yeah for sure [19:43:43] I'll assign the task to you [19:44:17] 10MediaWiki-Watchlist, 07Regression: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3110727 (10Catrope) a:05Catrope>03Mattflaschen-WMF We found the cause, and Matt came up with a strategy for fixing it that I like. [19:48:24] RoanKattouw, this does mean the defaults are still not honored on-submit for Special:Watchlist, which a bit unintuitive, but I think there's no change there. [19:48:46] Yeah but I feel like that's inherent in how checkboxes work [19:48:55] The defaults are indirectly honored already because they were put in the form [19:49:19] If you share URLs between users with different pref settings then it'll be a bit confusing, yes, but I don't think you can avoid that without creating monstrously long URLs [19:50:04] RoanKattouw, I'll do it only for action=submit, like now. [19:50:13] Cool, yeah that'll be good [19:50:49] Possibly as a follow-up, you should also be able to take out a bunch of the hidden fields code, because I don't think it ever needs to generate (or in practice ever ends up generating) anything other than one hidden field for action=submit [19:51:32] So you can still craft your own personal URLs that just override preferences. [19:52:50] Right, yes, as long as you don't include &action=submit in them (and why would you), they'll work the intuitive way [19:56:14] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3110788 (10Catrope) >>! In T149385#3110270, @jmatazzoni wrote: > @Mooeypoo, I shortened the 'Wh... [19:56:40] OK, actual lunchtime now [20:22:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3110847 (10jmatazzoni) That looks good to me. Thanks Roan. [20:25:56] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, and 2 others: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3110858 (10jmatazzon... [20:25:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3110855 (10j... [20:26:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), 05MW-1.29-release-notes, 13Patch-For-Review: RCFilters UI: Implement 'conflicting' property - https://phabricator.wikimedia.org/T156861#3110860 (10Etonk... [21:11:05] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3111006 (10jmatazzoni) [21:31:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/343364 (owner: 10L10n-bot) [21:45:33] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Enable parts of ORES extension by default and manage impacts on the RC Page and the Recent Changes Preferen... - https://phabricator.wikimedia.org/T159763#3111150 [21:45:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab - https://phabricator.wikimedia.org/T159763#3077869... [21:49:34] (03CR) 10Catrope: [C: 032] Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343278 (owner: 10WMDE-Fisch) [21:50:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab - https://phabricator.wikimedia.org/T159763#3111156... [21:52:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Enable parts of ORES extension by default and manage impacts on the RC Page and the RC page Preferences tab - https://phabricator.wikimedia.org/T159763#3111157... [21:53:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3111158 (10Etonkovidova) The c... [21:55:57] milimetric: Could you review https://gerrit.wikimedia.org/r/343247 and https://gerrit.wikimedia.org/r/343246 [21:56:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3111161 (10jmatazzoni) [21:58:51] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3111170 (10jmatazzoni) @SBisson and @Etonkovidova, pleas... [22:00:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3111177 (10Mooeypoo) Bringing it back to 'needs review' for implementing the conflict/coverage... [22:01:52] RoanKattouw: just the abbreviation bothered me, the rest is good [22:02:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3111180 (10jmatazzoni) [22:04:15] milimetric: OK, happy to spell it out [22:04:40] unfortunately you need someone like otto to merge the puppet one, I got no power in their world [22:06:15] mooeypoo: https://gerrit.wikimedia.org/r/343329 https://gerrit.wikimedia.org/r/343225 https://gerrit.wikimedia.org/r/343343 [22:06:18] (03Merged) 10jenkins-bot: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343278 (owner: 10WMDE-Fisch) [22:09:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3111196 (10jmatazzoni) [22:11:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104020 (10jmatazzoni) [22:12:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3111203 (10jmatazzoni) Thanks for the suggestions... [22:13:15] RoanKattouw, tests are taking a little longer than expected, almost done though [22:13:49] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3111204 (10jmatazzoni) [22:14:41] (03CR) 10jenkins-bot: Replace deprecated Context::getStats() with MWServices::getStatsdDataFactory() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/343278 (owner: 10WMDE-Fisch) [22:15:40] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Add technology so we'll be able to track usage of RC Page highlighting - https://phabricator.wikimedia.org/T158344#3111205 (10Mooeypoo) I mentioned this before, but please note that the names of filters have changed... [22:35:58] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 13Patch-For-Review: Close small gap between top of the Dropdown Filter Panel and the bottom of the Filte... - https://phabricator.wikimedia.org/T160213#3111259 [22:38:23] RoanKattouw, https://phabricator.wikimedia.org/T160734 [22:38:33] Er, https://gerrit.wikimedia.org/r/343407 [22:40:54] RoanKattouw, I would deploy it after review, but it's Friday, and I have to go soon. [22:40:56] So if you want to do it today, you can coordinate with Greg. Otherwise, I can do morning SWAT on Monday. [22:41:05] Let's just do it on Monday [22:41:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 13Patch-For-Review, 07Regression: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3111285 (10Mattflaschen-WMF) [22:42:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: [minor] Active filter display area - rows of filters do not have space between rows - https://phabricator.wikimedia.org/T160784#3111289 (10Mooeypoo) a:03Mooeypoo [22:50:19] RoanKattouw, okay. FYI, I am leaving at 4:40 Pacific now. [22:53:21] OK cool [22:54:14] RoanKattouw, I'm a little worried it will annoy people over the weekend. But it is possible to get around it by going to preferences. [22:54:26] I'll do the 9 AM Monday my time to reduce the annoyance. [22:55:53] Grr I found a bug in Gerrit's "rebase edit" feature [22:55:57] It overwrites the commit message [22:57:16] RoanKattouw, I noticed the same time. Fixed. :) [22:57:33] RoanKattouw, except you also fixed it. [22:57:45] And we overwrote each other [23:00:03] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10MediaWiki-Watchlist, 13Patch-For-Review, 07Regression: [Regression] Watchlist filters set in Preferences can't be disabled on Watchlist - https://phabricator.wikimedia.org/T160734#3111344 (10Mattflaschen-WMF) @Etonkovidova See the commit message... [23:08:52] milimetric: Updated my patch, sorry for the delay [23:09:39] gotta cook dinner, but you got the rest, yea? [23:09:51] oh well, wait, your data won't be there till the puppet code merges [23:10:04] Yeah I realize that [23:10:13] I've already done the dashiki config changes on meta and they worked [23:10:20] And I reorganized the grouping there a bit too [23:10:28] k [23:10:33] good cool [23:10:38] So yeah the graph is still empty, I'll just wait for the puppet change to merge, and if it takes too long I'll poke Otto [23:17:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3111387 (10jmatazzoni) [23:34:29] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Put in corrected Conflict State tooltips and Results Area messages - https://phabricator.wikimedia.org/T160803#3111436 (10jmatazzoni) [23:34:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Put in corrected Conflict State tooltips and Results Area messages - https://phabricator.wikimedia.org/T160803#3111436 (10jmatazzoni) a:05jmatazzoni>03None [23:36:01] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement corrected Conflict State tooltips and Results Area messages - https://phabricator.wikimedia.org/T160803#3111436 (10jmatazzoni) [23:36:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3111480 (10jmatazzoni) [23:40:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Implement corrected Conflict State tooltips and Results Area messages - https://phabricator.wikimedia.org/T160803#3111515 (10jmatazzoni) [23:41:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#3111514 (10j... [23:42:32] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#2974309 (10j... [23:45:12] Heading out. Have a good weekend, everyone! [23:59:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 05MW-1.29-release-notes, 13Patch-For-Review: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427#2974309 (10C...