[00:00:00] Junit Tests [00:00:02] That's what James is [00:00:04] haha yes [00:00:07] Thank you. :-P [00:00:29] Also, is T156427 In Development given that it has a patch, rather than Ready for Pickup? [00:00:29] T156427: Implement the Conflict display states and messages - https://phabricator.wikimedia.org/T156427 [00:00:45] That patch is arguably mistagged [00:00:47] actually, it's at least partially "ready for review" [00:00:52] my part of it, at least [00:00:55] One of you is wrong. ;-) [00:00:55] wait [00:01:05] matt_flaschen, why is it assigned to yo? Are you working on it? [00:01:07] Possibly both. [00:01:18] I thought you were done with the backend, and I pick up the front, or are you still working on stuff? [00:01:21] FWIW https://phabricator.wikimedia.org/project/board/2415/query/nB1dI_Q1okw7/ is a very helpful view. [00:01:24] Should be T160453 [00:01:25] T160453: [betalabs-regression] The red highlighting for conflicting filter states is gone - https://phabricator.wikimedia.org/T160453 [00:01:39] RoanKattouw, also, both stephane and I -1'ed your patch. dun dun dunnnnnn [00:01:50] RoanKattouw, oh [00:02:03] mooeypoo, that doesn't block the front-end. You can keep going. [00:02:17] mooeypoo, that's about implementing the specific actual conflicts. I already did the one in core, today I'll do the ORES one. [00:02:21] oh oh [00:02:22] ok [00:02:40] RoanKattouw: {{sofixit}}. [00:03:02] I did say "arguably" [00:03:33] Uh-huh, Mr.-Boss-Man. [00:05:24] what tha [00:05:32] mooeypoo, T156861 is the front-end part. [00:05:33] T156861: RCFilters UI: Implement 'conflicting' property - https://phabricator.wikimedia.org/T156861 [00:05:51] hold everyting -- apparently my rebase of the second patch is not in gerrit [00:05:56] what the hell [00:06:05] To The Reflog! [00:06:26] i was going to redo [00:06:33] but... is there a way to salvage, git-masters? [00:06:37] mooeypoo, yes, reflog. [00:06:51] mooeypoo: [00:06:53] git reflog -10 [00:07:02] Take a look at that and see if it makes sense. We can do a screen share if that would help. [00:07:15] Basically you want to retrace your steps using reflog and figure out the right commit ID. [00:07:18] Then: [00:07:19] HEAD@{8}: rebase finished: returning to refs/heads/review/mooeypoo/separate-name-from-param [00:07:23] git branch someBranchName rightCommitId [00:07:27] That looks like it might be it [00:07:47] mooeypoo, probably, you can check with git show first. [00:07:48] commit ID is ad9c07f ? [00:07:57] mooeypoo, yes. [00:08:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3104656 (10jmatazzoni) [00:08:56] it looks right [00:09:32] matt_flaschen, ok, I did git checkout rerebasing ad9c07f [00:09:39] now just git review ? [00:09:44] or do I need to re-commit ? [00:09:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3100184 (10jmatazzoni) @SBisson, the spec for th... [00:10:24] mooeypoo, no, just git review if: [00:10:25] git show [00:10:27] looks right [00:10:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3104661 (10jmatazzoni) [00:11:09] yeah I looked at git show, and the fix for 'all' is there [00:11:11] so it should be it :P [00:11:19] * mooeypoo hopes [00:11:22] For future, you can also just do git reflog without a limit. It's a good way to get out of most git jams. [00:11:29] yeah [00:11:32] thanks for that! [00:11:39] Welcome. :) [00:11:48] I was all ready to re-rebase [00:16:18] matt_flaschen, re wikipage.content -- it's the only hook I saw that's running [00:16:23] and it's not just about collapsible stuff [00:16:40] but... wait, as I'm talking, I think I realized.... [00:16:49] (quick, someone quack) [00:17:17] quack [00:17:27] mooeypoo, yeah, I noticed. I find some of the stuff there odd, e.g. checkboxes. [00:17:43] I'm not sure about the placeholder part either, but there are some ways to generate forms with wikitext, so I could be wrong about the second. [00:17:44] matt_flaschen, I think it's the "original" recent changes JS [00:17:51] not having a proper dynamic selector [00:18:14] mooeypoo, but all that does is call makeCollapsible on jQuery ready. [00:18:33] Is T156164 (grabbing less variables from MWUI) still blocked? [00:18:33] T156164: RCFilters UI: Use mixins and variables in Less files - https://phabricator.wikimedia.org/T156164 [00:18:39] mooeypoo, your solution does work, because it triggers a wikipage.content listener also calling makeCollapsible, but all the legend stuff does is makeCollapsible. [00:18:59] mooeypoo, mediawiki.special.changeslist.legend.js . [00:19:08] Anyway, I didn't -1 it, just noting a slight concern. [00:19:31] hm [00:19:47] mediawiki.special.recentchanges.js [00:19:54] updateCheckboxes: ... [00:20:13] mooeypoo, oh yeah, now that you mention it, that's the other thing Elena found. [00:20:18] And wikipage.content won't help. [00:20:20] yeah [00:20:22] indeed [00:20:25] * mooeypoo mehs [00:20:28] mooeypoo, probably you should introduce your own hook both those listen to. [00:20:29] the selector is wrong [00:20:31] nah [00:20:37] $select = $( '#namespace' ); [00:20:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#2988170 (10Etonkovidova) **(1)** [WIP] testing for subset coverage - the following selections... [00:20:50] I can probably fix it to be dynamic [00:21:35] mooeypoo, it needs to also be done at AJAX load (note how it's done at regular load now). [00:21:42] Not just onchange [00:21:55] The .prop part. [00:22:07] well, I guess I can either pull this into our code [00:22:14] or I can call it directly [00:22:26] Or do the hook [00:22:31] hm I guess so [00:23:04] mooeypoo, but I do see the argument against the hook. It's all on one page, so it should really be able to manage itself. [00:23:21] mooeypoo, unlike e.g. wikipage.content, which is for several scenarios (normal page loads, previews, AJAX previews) on multiple kinds of pages. [00:23:31] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3104703 (10jmatazzoni) [00:23:54] It's also not quite hook-worthy imho [00:24:06] hook is where you plan for others to do something with your operation [00:24:22] This is more of a self-sustained system and this piece specifically will go away "soon" [00:24:33] Yeah [00:24:42] Anywyas, I actually need to rn for a bit -- I aded a comment on the patch to remind myself to look at the JS again [00:24:46] the JS is pretty small btw [00:24:57] I can just redo it in our system -- I'm just concerned there are others I'm missing [00:25:04] **or** [00:25:05] .... [00:25:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: RCFilters: Implement 'subset' property for filter items - https://phabricator.wikimedia.org/T156864#3104712 (10Etonkovidova) [00:26:21] I could try to fixitup to be something like $( '.rcfilters-head' ).on( '#namespace', 'change', rc.updateCheckboxes ); [00:27:49] or, well, the other way around [00:27:56] 'change', '#namespace' ... [00:28:42] mooeypoo, I think it also needs a server-side change to replace the "trigger once to set the initial state of the checkboxes" (or it has to be done on AJAX load as said before). [00:28:43] mooeypoo, one sec. [00:29:35] does it? [00:29:49] if I change the 'on' I think it'll just catch on all [00:29:58] I'm attaching it to rcfilters-head which isn't changing [00:30:30] mooeypoo, but you're using the result of the AJAX response, right? [00:30:35] For this UI? [00:30:48] but it's the same [00:30:56] mooeypoo, but the checkboxes themselves are being replaced, right? [00:30:57] I'm changing the content of the fieldset, but it has the same name [00:30:59] yes [00:31:04] but that's why the selector is general [00:31:07] mooeypoo, yeah, you need to run it on load. [00:31:17] mooeypoo, visit https://en.wikipedia.org/wiki/Special:RecentChanges with JavaScript turned off then turned on. [00:31:23] no, I know [00:31:29] but I'm saying it's already loading anyways on load [00:31:40] mooeypoo, only for real page load, not on the AJAX replace load. [00:31:43] if I change the selector to be dynamic, then I won't need to *also* load it on ajax call [00:31:44] it'll just apply automatically [00:32:04] mooeypoo, I don't mean to re-attach the change listener. [00:32:11] oh? [00:32:11] I mean to do the actual checkbox manipulation on load. [00:32:17] "trigger once to set the initial state of the checkboxes." [00:32:18] See comment. [00:32:19] oh! [00:32:37] mooeypoo, I considered doing it on server-side, but that won't work, since then for no-JS users the boxes are always disabled. [00:32:40] If we load the fieldset with 'all' in it, the checkboxes need to change [00:32:42] meh [00:32:45] yeah no no [00:32:54] I'll just move it into the form wrapper [00:32:56] it's small [00:40:42] matt_flaschen, where is the collapse coming from? my solution doesn't work [00:40:45] I mean, the checkboxes work [00:40:53] but not the hook / collapsible [00:40:57] so it seems I'll have to add it myself [00:41:42] mooeypoo, mediawiki.special.changeslist.legend.js [00:42:08] And now I confused myself with git. [00:42:59] found it yeah [00:43:07] now I need to make sure I depend on jquery.collapse, I assume. [00:43:11] matt_flaschen, oh no... what happened? [00:44:06] I realized the underscore tests should be testing the abstract class, so I set up separate test classes for that. But now the purpose of the commit entirely changed. [00:44:12] So I want abstract class, then underscore commit on that. [00:44:34] oh, git rebase -i ? [00:44:41] or is it commit -i [00:44:48] whatever it is, the -i part is adventurous [00:48:23] mooeypoo, I think I've got it, just checking it's right. [00:53:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3104776 (10jmatazzoni) [00:53:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform 'ORES Sensitivity' levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104774 (10jmatazzoni) 05Invalid>03Open [00:53:43] Yeah, it's done: https://gerrit.wikimedia.org/r/#/c/342789/ [00:54:16] I started that since the name check should also be testing the abstract class, not an arbitrary subclass. [00:54:25] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104020 (10jmatazzoni) [00:59:54] matt_flaschen, https://gerrit.wikimedia.org/r/342930 [01:00:53] matt_flaschen, why do you need @codingStandardsIgnoreStart [01:02:10] matt_flaschen, also, lgtm but I am not sure how to run php unit tests in mw [01:02:22] mooeypoo, you mean https://gerrit.wikimedia.org/r/#/c/342789 right ? [01:02:31] mooeypoo, RoanKattouw put that in to fix Jenkins complaining about the line length. [01:02:40] yeah [01:02:41] ahh [01:03:44] matt_flaschen, what's the proper way to run the tests? [01:03:47] I have phpunit installed [01:03:54] I just can't find the params for it in the docs [01:04:27] mooeypoo, sudo -u www-data -E php5 /vagrant/mediawiki/tests/phpunit/phpunit.php --wiki=wiki -v /vagrant/mediawiki/tests/phpunit/includes/changes/ [01:04:38] Also, something went wrong with the documentation on that page https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Installing_PHPUnit#Testing_your_installation [01:04:43] mooeypoo, the www-data thing is only really needed for Flow, but doesn't hurt. [01:05:16] matt_flaschen, I need to run this inside vagrant ssh, right? [01:05:59] oy [01:06:01] ...........PHP Warning: Uncaught require(/vagrant/mediawiki/tests/common/../phpunit/mocks/MockChangesListFilterGroup.php): failed to open stream: No such file or directory [01:06:06] and then tons of failures [01:06:23] composer install or something? [01:07:42] mooeypoo, sorry, I forgot to add that. [01:07:52] One sec [01:08:51] mooeypoo, there are also instructions at https://www.mediawiki.org/wiki/Manual:PHP_unit_testing/Running_the_unit_tests but they don't work, trying to fix. [01:10:06] I need to run [01:10:30] The code looks good in general, but I'll check the tests later -- and it fails jenkins [01:10:38] I'll see you later/tomorrow [01:11:07] mooeypoo, yeah, I'll fix them both for tomorrow. Just forgot to upload the files. Have a good night. [01:11:10] Also fixing the docs. [01:11:12] Simple version is: [01:11:15] vagrant@mediawiki-vagrant:/vagrant/mediawiki/tests/phpunit$ php phpunit.php --wiki=wiki includes/utils/MWCryptHashTest.php [01:11:29] +1 [01:11:35] will take another look tomorrow [01:11:38] night :) [01:22:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review, 07Regression: [betalabs-regression] The red highlighting for conflicting filter states is gone - https://phabricator.wikimedia.org/T160453#3104827 (10Jdforrester-WMF) p:05Triage>03Normal a... [01:27:39] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3104833 (10jmatazzoni) [01:29:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3104837 (10jmatazzoni) [01:31:07] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3104844 (10Catrope) >>! In T159010#3087444, @SBisson wrote: > This is what it looks like wi... [01:33:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Add ORES to RCFilters - https://phabricator.wikimedia.org/T158459#3104845 (10jmatazzoni) 05Open>03Resolved [01:41:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Small layout issue: Highlight button has moved all the way over to the right - https://phabricator.wikimedia.org/T160601#3104855 (10jmatazzoni) [01:41:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Small layout issue: Highlight button has moved all the way over to the right - https://phabricator.wikimedia.org/T160601#3104855 (10jmatazzoni) [01:42:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Small layout issue: Highlight button has moved all the way over to the right - https://phabricator.wikimedia.org/T160601#3104855 (10jmatazzoni) [01:46:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3104869 (10Jdforrester-WMF) a:03jmatazzoni [01:51:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3104877 (10jmatazzoni) [01:55:56] 10MediaWiki-Recent-changes, 10MediaWiki-Redirects, 13Patch-For-Review: Make redirect creation a separate recent changes event from moving a page - https://phabricator.wikimedia.org/T146601#3104878 (10GeoffreyT2000) 05Open>03declined Such log entries would unnecessarily duplicate move log entries and clut... [01:56:22] 10MediaWiki-Recent-changes, 10MediaWiki-Redirects: Make redirect creation a separate recent changes event from moving a page - https://phabricator.wikimedia.org/T146601#3104880 (10GeoffreyT2000) [04:12:17] (03PS1) 10Mattflaschen: Change Special:Version description to 'Discussion system' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342980 [04:17:18] (03CR) 10Mattflaschen: "To discuss" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342980 (owner: 10Mattflaschen) [05:02:17] mooey|away, the change on Feb 23 in T149385 requires a change to the parameters we agreed for the global (non-tooltip) messages. [05:02:17] T149385: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385 [05:02:55] matt_flaschen, what do you mean? [05:03:15] mooey|away, before the message was: [05:03:19] "The “Logged actions” filter is conflicting with one or more “Contribution quality” or “User intent” filters. Quality and Intent predictions are not available for logged actions. The conflicting filters are marked as inactive above." [05:03:24] and my understanding was there would be no parameters. [05:03:35] oh, crap, we're adding parameters now [05:03:44] "Moriel looked over the texts, so they should be appropriate technically." [05:03:45] :) [05:03:55] where [05:04:02] mooey|away, but seriously, my concern is how to does the front-end know which order to pass the parameters. [05:04:22] the front end can just create the list and pass 1 parameter [05:04:23] It's easy to pass two parameters, e.g. 'maybebad, likelybad' (for the ORES side) and 'hidelog' (for the change type side). [05:04:38] But the global message is bidirectional, and it's included in both sides of the conflict. [05:04:42] paramList = mw.msg( 'list-whatever-its-called', param1, param2, param3... ) [05:04:44] So how does it know which order to pass those two. [05:04:52] then mw.msg( 'the-key', paramList ) [05:05:06] it's just a lits [05:05:09] isn't it? [05:05:18] "Group includes" ... [05:05:54] a list* [05:05:55] mooey|away, did you see the new message at T149385? [05:05:59] " Contribution Quality and User Intent predictions are not available for certain types of change. One or more Quality or Intent filters are in conflict with the following Type of Change filters: "Filtername a"[, "Filtername b"]" [05:06:04] Sorry, I should have copied that earlier. [05:06:08] https://phabricator.wikimedia.org/T149385#3091711 [05:06:14] Yeah ^ a list at the end [05:06:20] Why does the order matter? [05:06:35] mooey|away, no, that's no-effect. [05:06:37] I mean, the view model will probably display it in-order of the view (because it's arrays now) [05:06:38] We're talking about conflicts. [05:07:04] eh, where, at the top? [05:07:19] mooey|away, "Results Area Conflict Messages" [05:07:25] Logged Actions or Wikidata Edits vs. any ORES filter message [05:07:31] "The “Unregistered” filter is in conflict with one or more Experience filters. Experience filters find registered users only. The conflicting filters are marked as inactive above." [05:07:32] ? [05:07:49] mooey|away, sorry, that's the old one. I meant to post both old and new, new is: [05:07:53] Contribution Quality and User Intent predictions are not available for certain types of change. One or more Quality or Intent filters are in conflict with the following Type of Change filters: "Filtername a"[, "Filtername b"] [05:08:09] * mooey|away is super confused [05:08:13] what's wrong with this message? [05:08:18] it's a list at the end... [05:08:30] (i'm half-here for a bit, phone) [05:08:32] Sorry, confusion is partly my fault. [05:08:39] mooey|away, but the issue is, which list is at the end. [05:08:51] mooey|away, this is a global message, exposed on both sides of the conflict. [05:09:10] But now that I think about it, I can just only expose it on the original side. [05:14:04] mooey|away, take the example of userExpLevel vs. hideanons. Right now it's sent to the front-end in both directions. For hideanons: [05:14:05] "[{"group":"userExpLevel","globalDescription":"rcfilters-filtergroup-user-experience-level-conflicts-unregistered-global","contextDescription":"rcfilters-filter-unregistered-conflicts-user-experience-level"}]" [05:14:28] For userExpLevel: [05:14:29] "[{"group":"registration","filter":"hideanons","globalDescription":"rcfilters-filtergroup-user-experience-level-conflicts-unregistered-global","contextDescription":"rcfilters-filtergroup-user-experience-level-conflicts-unregistered"}]" [05:15:14] Note they have the same structure (other than one being filter->group and another being group->filter, but filter->filter is also allowed in which case the structure would be identical) [05:15:32] So since it says: "the following Type of Change filters: "Filtername a"[, "Filtername b"]" [05:16:14] matt_flaschen, I'm breaking apart filter-group and group-filter anyways [05:16:18] how does the front-end know whether $1 or $2 is 'the type of change' (since globalDescription is the same for both) [05:16:31] That is, the conflicts are also set up as per-filter [05:16:46] So my proposed solution is that globalDescription only shows up on one side, and that's the $1 side. [05:16:48] Does that make sense? [05:16:50] so the filter knows that not only does it conflict with a group, it knows it conflicts with specific filters in the group [05:17:19] wait [05:17:32] i get what you're saying -- the "Type of Change" is $1 [05:17:36] and the list is $2 [05:17:38] well [05:17:46] mooey|away, no, 'Type of Change' is not a parameter at all. [05:17:48] That would be lego. [05:17:51] right [05:17:53] ok [05:17:55] I'm confused. [05:17:56] say what [05:17:58] Hey [05:18:03] haha [05:18:04] :-) [05:18:18] * mooey|away is just confused now [05:18:18] mooey|away, okay, so you know what I mean the globalDescription is bidirectional? [05:18:27] It's a shared message referring to the conflict, not specific to one side. [05:18:30] it appears in both messages as the same [05:18:32] right [05:18:41] (as opposed to the tooltips, right?) [05:18:43] mooey|away, and this particular message has only the type of change filters listed. [05:18:44] Right [05:18:55] Since we're listing one side, but it's bidirectional, that implies there are two parameters: [05:19:03] $1 - List of type of change filters [05:19:04] matt_flaschen, we could also ask joe to change the message to make more sense, btw, but go on [05:19:25] $2 - List of damaging filters [05:19:30] But how do you know the order. [05:19:34] Of $1 and $2. [05:19:53] Well [05:20:03] mooey|away, yeah, we did have a whole thing where we discussed then I diagrammed these messages and there were no issues. :) [05:20:06] since this is the general message at the bottom, the viewmodel is the one responsible [05:20:07] Until they changed. [05:20:10] not the individual filters [05:21:00] Okay, but the view model still needs to know which parameters to pass to globalDescription, right? [05:22:30] ^ mooey|away [05:46:36] matt_flaschen, if they changed and made an issue,we should talk to joe [05:46:41] these messages are pretty elaborate as it is [05:46:58] I venture to say, perhaps even over elaborate [05:47:45] I see what you mean with the parameters. I'm not sure. I mean, I am sure we can find a solution if we really need to, but it is starting to feel like this is symptomatic of showing how convoluted the entire conflict process is [05:48:04] it's supposed to help users, and that's fine, but I think we might be going a bit too far relative to the amount of effort this entire thing takes [08:10:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Small layout issue: Highlight button has moved all the way over to the right - https://phabricator.wikimedia.org/T160601#3105186 (10Pginer-WMF) > The button should move over to the left a bit to provide a margin. (I... [10:08:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3105440 (10Tr... [11:13:49] RoanKattouw: https://edit-analysis.wmflabs.org/beta-enables/#projects=plwiki/metrics=RCFilters%20Beta%20Enables [11:13:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Move 'ORES Sensitivity' controls and conform levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3105589 (10Trizek-WMF) >>! In T160575#3104099, @H... [11:14:41] A little awkward 'cause you have to pick wikis different from the default for that dashboard, but it's all hooked up. And I did it all from my iPad in bed :) [11:18:24] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3105597 (10Trizek-WMF) I've te... [12:27:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3105775 (10SBisson) >>! In T15... [13:38:37] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 5 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3105944 (1075.Abbasdhothar) The new translations are still not available on Western Punjabi Wikipedia [13:40:41] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 5 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3105949 (10Zppix) @75.Abbasdhothar they arent ready to be put on there @Matanya needs help with conflicting new translations as mentioned... [13:45:56] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3105982 (10Trizek-WMF) >>! In... [13:53:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3106014 (10Trizek-WMF) I've cr... [16:15:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3106700 (10SBisson) > Hide probably good edits from... [16:17:25] 06Collaboration-Team-Triage, 10Notifications, 10Timeless: Better icons for echo - https://phabricator.wikimedia.org/T160653#3106720 (10Isarra) [16:17:36] 06Collaboration-Team-Triage, 10Notifications, 10Timeless: Better icons for echo in timeless skin - https://phabricator.wikimedia.org/T160653#3106733 (10Isarra) [16:59:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3106899 (10SBisson) p:05Triage>03High >>! In T160493#3103248, @SBisson wrote: > I see results with those 2 URLs but lookin... [17:08:18] milimetric: Awesome, thanks! [17:21:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3107014 (10Mattflaschen-WMF) [17:22:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842494 (10Mattflaschen-WMF) @jmatazzoni approved going back to the old Results Area message (I just edited it), due... [17:24:57] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3107058 (10Mattflaschen-WMF) [17:25:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#2842510 (10Mattflaschen-WMF) [17:30:37] (03CR) 10Catrope: [C: 032] Change Special:Version description to 'Discussion system' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342980 (owner: 10Mattflaschen) [17:36:43] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 10Wikidata: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025#3107117 (10jmatazzoni) [17:36:51] 10MediaWiki-Recent-changes, 07Design: Core-ify the CleanChanges extension's intent (to filter RecentChanges when it is busy) - https://phabricator.wikimedia.org/T56203#3107119 (10Jdforrester-WMF) [17:37:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3107131 (10SBisson) [17:37:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Turn off 'classic' ORES highlighting on the RC page - https://phabricator.wikimedia.org/T159300#3107123 (10SBisson) 05Open>03Invalid This was done in {T159763} [17:37:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3107132 (10Mattflaschen-WMF) [17:42:16] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3107169 (10Mattflaschen-WMF) >>! In T160493#3103248, @SBisson wrote: > I see results with those 2 URLs but looking at the code... [17:42:31] (03Merged) 10jenkins-bot: Change Special:Version description to 'Discussion system' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342980 (owner: 10Mattflaschen) [17:42:45] (03CR) 10jenkins-bot: Change Special:Version description to 'Discussion system' [extensions/Flow] - 10https://gerrit.wikimedia.org/r/342980 (owner: 10Mattflaschen) [17:47:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3107196 (10jmatazzoni) In T159763#3106700, @SBisso... [17:49:48] 10MediaWiki-Recent-changes: Implement ability to filter recent changes by user group - https://phabricator.wikimedia.org/T6664#90941 (10Jdforrester-WMF) Though not entirely fixing the specific use cases you mention, most is now possible with the work on RC Filters; the interface will be launching as a Beta Featu... [17:50:15] 06Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), 10Edit-Review-Improvements-RC-Page, 10MediaWiki-extensions-ORES, 06Revision-Scoring-As-A-Service, 10Wikidata: Support ORES for propagated Wikidata edits - https://phabricator.wikimedia.org/T158025#3107204 (10jmatazzoni) As much as I'd like to do... [17:53:30] 10MediaWiki-Recent-changes, 07Design: Core-ify the CleanChanges extension's intent (to filter RecentChanges when it is busy) - https://phabricator.wikimedia.org/T56203#3107211 (10Jdforrester-WMF) The first of these features (show/ignore edits in languages other than ) could reasonably be added in the future... [18:02:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3107259 (10SBisson) >>! In T159763#3107196, @jmataz... [18:02:47] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3107260 (10Catrope) >>! In T159763#3107196, @jmataz... [18:15:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Manage ORES preferences on Watchlist (and Contributions) - https://phabricator.wikimedia.org/T160475#3107347 (10SBisson) > To reflect the above, the option s... [18:26:18] milimetric: Thanks a lot! I've used eval.php to give the beta feature to myself on ptwiki so that we can see if it jumps from 0 to 1 tomorrow [18:27:25] k, lemme know if anything doesn't work as expected, but the query looked right to me [18:30:42] mooey|away: Hah I had just made the exact same edits to https://gerrit.wikimedia.org/r/#/c/342962/2..3 but you beat me by one minute [18:30:56] milimetric: Yeah I have faith that it'll work, I just want to make sure [18:31:12] I'll also write a patch to add another graph for an existing beta feature, so at least for that one we'll know if it works pretty quickly [18:32:53] K, you can follow my example on this one, for the two configs involved, let me know if you need help [18:35:26] milimetric: You mean https://meta.wikimedia.org/w/index.php?title=Dashiki:CategorizedMetrics&diff=prev&oldid=16440520 ? And what's the second one? [18:35:30] RoanKattouw, ha [18:35:36] RoanKattouw, about to submit another such patch [18:35:46] This time I beat you I think? [18:36:02] https://gerrit.wikimedia.org/r/#/c/343108/ ? [18:36:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Small layout issue: Highlight button has moved all the way over to the right - https://phabricator.wikimedia.org/T160601#3107442 (10Mooeypoo) a:03Mooeypoo [18:36:40] Oh I meant https://gerrit.wikimedia.org/r/342930 [18:37:00] In particular https://gerrit.wikimedia.org/r/#/c/342930/3..4/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FormWrapperWidget.js [18:37:05] haha oops [18:37:14] RoanKattouw, you fixing this or should I ? [18:37:19] I already did [18:37:22] oh hehe [18:37:23] thanks [18:37:27] That link is the diff of me fixing it [18:37:46] RoanKattouw, also, I answered the CR comments and fixed up the conflict patch [18:37:55] and re-rebased the top name/paramname patch [18:38:27] RoanKattouw, do you want me to take over https://gerrit.wikimedia.org/r/#/c/342165/ and move the operation to the model [18:38:31] or are you on it? [18:38:42] I will be after I grab some food [18:38:43] I know you're busy with tons of stuff [18:38:48] * mooeypoo nods [18:38:55] I didn't have much breakfast and there's a talk about device security at 12 [18:38:56] are you coming to the office? [18:39:05] I've been here the whole time :) [18:39:07] pj [18:39:09] oh [18:39:15] ... you're invisible! [18:39:24] I just hung back in R51 after the thing here ended because I'm lazy and it's nice and quiet here [18:39:40] ... is that a comment about how loud we are? [18:39:42] I'll move my stuff to the 5th floor lounge and then go get lunch [18:39:43] ... don't answer that [18:39:45] haha [18:39:53] ok I'll catch you soon ;) [18:39:53] No it's a comment on there being >0 people around my desk [18:40:00] RoanKattouw: https://meta.wikimedia.org/w/index.php?title=Config%3ADashiki%3AFlowByWiki&type=revision&diff=16440539&oldid=16432720 [18:40:21] milimetric: Aha, thanks, didn't find that one because you weren't logged in [18:40:26] oops [18:40:36] (I went to Special:Contributions/Milimetric_(WMF) to find out what you did) [18:40:55] oh, man, you all too fancy for me, I have to like remember stuff the old fashioned way [18:59:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Approved interface text for RC page interface elements - https://phabricator.wikimedia.org/T149385#3107492 (10Mattflaschen-WMF) @jmatazzoni Follow-up to {T158025} and today's standup: Can we use: "The “Wikidata” fi... [19:15:35] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017): [betalabs-regression] enwiki Show/hide patrolled edits link is not present on RC page - https://phabricator.wikimedia.org/T160682#3107568 (10Etonkovidova) [19:17:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3107582 (10Et... [19:22:16] mooeypoo: I've re-1ed your patch with a minor thing about the tests [19:28:07] RoanKattouw, fixed [19:34:44] mooeypoo, I see Contribution quality out of the box, looking at 'goodfaith' (probably just need to enable it). [19:34:53] mooeypoo, we can take a look together if you're waiting on Roan. [19:35:40] RoanKattouw, also, it totally took me a moment to wonder what is "re-led" the code [19:35:50] haha [19:36:03] matt_flaschen, yep can do after the brown bag and after I get lunch [19:36:28] Sounds good. [19:46:26] mooeypoo, https://gerrit.wikimedia.org/r/#/c/343115/ was all I needed to do to get goodfaith as well. [19:51:19] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3107670 (10jm... [20:10:43] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3107770 (10Et... [20:20:57]