[00:00:00] matt_flaschen, meh. Can I go back to _ ? [00:00:06] maybe even __ or something? [00:00:10] ____ [00:09:58] mooeypoo, why does : require more quotes? [00:11:09] because you can do { foo: 'bar' } in js, but if you do { foo:bar: 'baz' } then the key must have quotes [00:11:17] { 'foo:bar': 'baz' } [00:11:37] also, I found out my double-prefixing problem [00:11:55] I was misguidedly adjusting the definition, as if I'd toss it out (which I usually do in the system) [00:12:06] except the unit tests sometimes "reset" and then re-read the definition [00:12:24] and so at that point your filter name isn't "filter1" it's the "corrected" "group1_filter1" because it already ran once and got "fixed" [00:12:27] so now it get "fixed" again [00:12:28] >.< [00:12:37] $.extend() to the rescue [00:18:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100555 (10jmatazzoni) [00:18:38] mooeypoo, ah, yeah. Okay, we can keep it _. People should be using camel-case (userExpLevel) or nothing ('hidehumans', 'maybebad'), so it's fine. [00:18:56] : seemed less likely to be accidentally used, but we don't want people accidentally using _ anyway for style conventions. [00:19:07] I changed it to __ (double) just in case, but we can also revert that to _ [00:19:22] That's fine, but I'll just block _. [00:19:59] I tried LiveRC. It's nice, but *very* information-dense. [00:20:44] You can use it in English (which is pretty cool for a gadget on French Wikipedia). You just have to set your French Wikipedia language settings to English: [00:20:45] https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:LiveRC [00:23:29] ooh [00:23:33] * mooeypoo shall check it out [00:23:38] I have to run for a bit [00:23:44] i'll see you later or tomorrow [00:27:41] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Port RecentChangesFlags to structured filters - https://phabricator.wikimedia.org/T160489#3100591 (10Mattflaschen-WMF) [00:35:17] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100631 (10jmatazzoni) >>! In T150... [01:00:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100658 (10Mattflaschen-WMF) >>! I... [01:18:58] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)), 05MW-1.29-release-notes, and 2 others: Build all front-end elements for the new Recent Changes (RC) Page user interface - https://phabricator.wikimedia.org/T144448#3100672 (10jmatazzon... [01:19:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), 05MW-1.29-release (WMF-deploy-2017-03-14_(1.29.0-wmf.16)), and 2 others: Update RC page results withou... - https://phabricator.wikimedia.org/T153949#3100671 [01:27:50] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100678 (10jmatazzoni) @Mattflasch... [03:46:44] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100754 (10Mattflaschen-WMF) >>! I... [04:02:58] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3100769 (10Mattflaschen-WMF) [04:03:06] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3100782 (10Mattflaschen-WMF) a:03Mattflaschen-WMF [04:04:18] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3100769 (10Mattflaschen-WMF) a:05Mattflaschen-WMF>03None [04:04:27] etonkovidova, I fixed your Beta thing. 'goodfaith' is hooked up now. Not sure the status of the other wikis, but it's available on enwiki. [04:13:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100816 (10jmatazzoni) Oh, cool. G... [04:31:18] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3100834 (10Mattflaschen-WMF) The "... [04:39:32] kmuthu, are you there? [08:28:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3101054 (10Pginer-WMF) >>! In T150... [08:36:53] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 3 others: Add wl_id to watchlist tables on production dbs - https://phabricator.wikimedia.org/T130067#3101065 (10Marostegui) We have tested an ALTER table + parallel replication + gtid_domain_id on x1 (T160407). It was a pretty small... [09:34:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3101201 (10Pginer-WMF) >>! In T160063#3098157,... [10:09:06] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Contact Portuguese Wikipedia about testing ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T156157#3101299 (10Trizek-W... [10:09:11] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Followup with Polish Wikipedia about testing ERI filters for Recent Changes - https://phabricator.wikimedia.org/T158042#3101300 (10Trizek-... [11:26:09] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Inform users when a URL cannot be adapted to the new filter system for Recent Changes - https://phabricator.wikimedia.org/T151873#3101456 (10SBisson) a:05SBisson>03Mattflaschen-WMF [12:34:08] 10MediaWiki-Recent-changes, 10Wikimedia-Site-requests, 05MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), 05MW-1.27-release-notes, and 3 others: Rebuild Recent changes for 2016-04-19 14:48 - 15:10 UTC due to Dallas data centre migration - https://phabricator.wikimedia.org/T133053#3101577 (10MarcoAur... [13:35:41] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Flow, 10Mention-Notification, 06TCB-Team, and 3 others: Inform Flow users when they hit the flow mention limit - https://phabricator.wikimedia.org/T144614#3102014 (10Trizek-WMF) >>! In T160088#3098780, @Catrope wrote: > A patch was submitted to a... [13:58:48] 06Collaboration-Team-Triage, 10Flow, 10Collection, 10Gadgets, and 5 others: Add translation of namespaces in Western Punjabi - https://phabricator.wikimedia.org/T157871#3102080 (10matmarex) @75.Abbasdhothar Looks like there are a few pages on Western Punjabi Wikipedia whose names conflict with the new tran... [14:26:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3102203 (10SBisson) >>! In T159763#3100080,... [14:43:37] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Design: Clarify functional zones / organization of the RC page - https://phabricator.wikimedia.org/T159345#3102262 (10Trizek-WMF) >>! In T159345#3099659, @jmatazzoni wrote: >>>! In T159345#3094465, @Quiddity wrote: >... [14:57:59] 06Collaboration-Team-Triage, 10Flow, 10UI-Standardization, 10VisualEditor, and 6 others: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#3102302 (10Trizek-WMF) >>! In T116417#310008... [15:17:42] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3102397 (10jmatazzoni) I think this diagram doe... [15:24:20] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement: Explore ways to represent visually the ORES-related filters and associated tradeoffs - https://phabricator.wikimedia.org/T160063#3102431 (10Pginer-WMF) >>! In T160063#3102397,... [15:33:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3102471 (10jmatazzoni) @SBisson, good info.... [16:11:26] 06Collaboration-Team-Triage, 10Flow: tracking: Flow loses session/token information - https://phabricator.wikimedia.org/T68076#3102712 (10Liuxinyu970226) [16:55:35] 10MediaWiki-Watchlist, 10DBA, 10Expiring-Watchlist-Items, 06TCB-Team, and 2 others: Allow setting the watchlist table to read-only on a per-wiki basis - https://phabricator.wikimedia.org/T160062#3102936 (10Lea_WMDE) [17:00:27] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3102946 (10SBisson) >>! In T159763#3102471,... [17:13:54] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3103021 (10Catrope) >>! In T159763#3102471,... [17:18:33] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3103046 (10Mattflaschen-WMF) [17:33:08] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3103130 (10Mattflaschen-WMF) [17:46:53] 06Collaboration-Team-Triage, 10Edit-Review-Improvements-RC-Page: Good faith filter group not UNIONing properly - https://phabricator.wikimedia.org/T160493#3100769 (10SBisson) I see results with those 2 URLs but looking at the code, I would add parenthesis around the condition in [[ https://phabricator.wikimedi... [17:52:15] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10Collaboration-Community-Engagement, 06Community-Liaisons (Jan-Mar 2017): Create dedicated pages for ERI Recent Changes Beta project - https://phabricator.wikimedia.org/T146669#3103276 (10Trizek-WMF) [17:53:30] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-ReviewStream, 10Analytics, 10ChangeProp, and 4 others: Set up the foundation for the ReviewStream feed - https://phabricator.wikimedia.org/T143743#3103281 (10Ottomata) Status update? :) [18:27:28] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3103471 (10jmatazzoni) @SBisson, sorry I didn't think of this sooner, but this morning's me... [18:30:21] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 13Patch-For-Review: Show a message on the RC page introducing the new features - https://phabricator.wikimedia.org/T159010#3103477 (10SBisson) >>! In T159010#3103471, @jmatazzoni wrote: > Can we please just add the... [18:35:53] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3103490 (10Etonkovidova) Just to add to the... [18:59:40] NAME/PARAM UNIT TESTS PASSSSS \o/ [19:00:01] RoanKattouw, (PS2) Mooeypoo: [wip] RCFilters UI: Separate name from paramName in filters [core] - https://gerrit.wikimedia.org/r/342295 [19:00:25] RoanKattouw, I'm going to deal with a few of the "small" bugs and then see if I can try and rebase, but you seem to have had ideas on how to sensibly do that... [19:11:52] The conflict patch should be rebased first [19:12:08] Also stephanebisson said he might review that one [19:18:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: Make sure all Preferences for Recent Changes are compatible with new filtering system/page tools (and that users' preferences carry over) - https://phabricator.wikimedia.org/T150059#3103644 (10Etonkovidova) **(1) **... [20:36:41] (03Abandoned) 10Catrope: [WIP] Create notification for The Wikipedia Library users [extensions/Echo] - 10https://gerrit.wikimedia.org/r/318140 (https://phabricator.wikimedia.org/T132084) (owner: 10Kmuthu) [21:01:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3103971 (10Catrope) >>! In T132084#30734... [21:01:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page: [betalabs-regression] Filters' background for selected filters always looks grey - https://phabricator.wikimedia.org/T160574#3103972 (10Etonkovidova) [21:16:59] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform 'ORES Sensitivity' levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104020 (10jmatazzoni) [21:18:12] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform 'ORES Sensitivity' levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104020 (10jmatazzoni) a:05SBisson>03None [21:33:36] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform 'ORES Sensitivity' levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104099 (10Halfak) Looks OK to me. You might want to signal how muc... [21:33:54] etonkovidova, where was that task number from this morning? [21:34:01] etonkovidova, I have a fix [21:34:20] mooeypoo: https://phabricator.wikimedia.org/T157594 [21:34:28] mooeypoo: thank you! [21:36:20] etonkovidova, I pulled it into the "Needs Review" column [21:36:28] nurray [21:36:38] I meant hurray! :) [21:37:52] haha [21:44:00] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, 13Patch-For-Review: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3104108 (10jmatazzoni) [21:44:02] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service: Conform 'ORES Sensitivity' levels to the new ERI standards - https://phabricator.wikimedia.org/T160575#3104106 (10jmatazzoni) 05Open>03Invalid I think I defined this i... [22:12:07] milimetric: https://gerrit.wikimedia.org/r/342946 [22:12:55] RoanKattouw, rebase #1 done [22:13:00] Yay [22:13:32] Preparing for uberterribleness that is Rebase #2 [22:13:51] Doing breathing exercises [22:14:06] Making calming chamomile [22:15:29] Playing Enya [22:17:38] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-03-21_(1.29.0-wmf.17)), 13Patch-For-Review: Add ORES to RCFilters - https://phabricator.wikimedia.org/T158459#3037721 (10Etonkovidova) **QA recommendation: Resolve.** Just as a... [22:26:15] matt_flaschen, RoanKattouw I'm getting a new failure in the unit tests now [22:26:29] "Unselected filters return all parameters falsey or ''." --> My 'expect' is to get filterGroup: '' if nothing is selected [22:26:33] but I get filterGroup: 'all' [22:26:48] is this intentional? Are we translating to "all" if there's nothing? If so, I need to fix up the code [22:27:04] * mooeypoo trying to understand if there's a bug or a feature [22:27:20] mooeypoo, if the user doesn't touch a group, it should reflect the default. [22:27:32] mooeypoo, the default for a string group can be 'all', '' (empty string), or anything else. [22:27:38] hm [22:28:14] mooeypoo, for full-coverage, all and '' are equivalent. [22:28:24] userExpLevel happens to be empty string default. [22:28:32] matt_flaschen, I'm starting with all params falsey (group3: '' ) [22:28:36] I get group3: 'all' [22:28:49] So something seems to have changed in the JS now.....? [22:29:08] mooeypoo, I did change some JS here, but I think I changed it to do the opposite. [22:29:25] I changed it too on the underlying commit from the one I'm fixing now, though [22:29:28] where it passes [22:29:36] so it might be a bug in my current patch [22:29:43] Before you were converting none-selected to 'all', which is not correct unless it's full-coverage (and keeping it empty string works regardless of full-coverage) [22:29:53] mooeypoo, I'll take a look after I finish my current patch update. [22:30:21] pretty sure I spotted it now [22:30:24] based on what you just said [22:30:38] 'cause I reworked the way getFiltersFromParamters and getParametersFromFilters work [22:30:44] the latter now does its thing in the group [22:30:47] mooeypoo, yeah https://gerrit.wikimedia.org/r/#/c/337546/24/resources/src/mediawiki.rcfilters/dm/mw.rcfilters.dm.FiltersViewModel.js [22:30:53] It should be the opposite from what you said though. [22:30:54] and I believe i'm outputting it wrong [22:31:19] none-checked used to be converted to 'all', now it shouldn't be unless the actual behavior (not just test) was changed in your top one. [22:31:33] matt_flaschen, heh, when I moved the code into the group I forgot to remove values.length === 0 [22:31:40] and since i changed the location of it, rebase didn't catch it [22:31:51] all hail unit tests! [22:33:15] mooeypoo, +1. [22:44:40] rebase #2 done! [22:44:42] \o/ [22:46:46] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3104337 (10Et... [22:53:10] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 05MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), 05MW-1.29-release-notes, 13Patch-For-Review: Build user interface for the Dropdown Filter Panel - https://phabricator.wikimedia.org/T149452#3104357 (10Et... [23:05:04] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3104416 (10Samwalton9) >>! In T132084#31... [23:05:26] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#3104417 (10Samwalton9) [23:06:23] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Notifications, 10The-Wikipedia-Library, 07User-notice, 07User-notice-collaboration: Notify editors that they are now eligible for the Wikipedia Library program - https://phabricator.wikimedia.org/T132084#2187899 (10Samwalton9) [23:28:08] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3104463 (10jmatazzoni) [23:30:29] matt_flaschen, https://gerrit.wikimedia.org/r/#/c/342930/2 <-- fixed the commit message (oops!) [23:30:34] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3104487 (10jmatazzoni) @SBisson, the spec for this... [23:32:22] 06Collaboration-Team-Triage (Collab-Team-Q3-Jan-Mar-2017), 10Edit-Review-Improvements-RC-Page, 10ORES, 06Revision-Scoring-As-A-Service, and 2 others: Add feature flag to enable parts of ORES extension by default - https://phabricator.wikimedia.org/T159763#3104528 (10jmatazzoni) [23:49:13] RoanKattouw: I don't think you meant T159673. [23:49:13] T159673: Book restaurant for dinner for those who wants at Wikipedia Day - https://phabricator.wikimedia.org/T159673 [23:49:24] LOL nope good catch [23:49:27] :-) [23:50:11] RoanKattouw: Also, merging this means that old-style highlighting will be gone on RC pages, regardless of 'beta' vs. 'on' setting, right? [23:50:36] RoanKattouw: So either it can't be merged until the same train as RC Filters or you're going to have a temporary loss of functionality? [23:50:46] Oh hmm that needed to be conditional on 'on' mode, good catch [23:50:53] * James_F bows. [23:50:58] That's two good catches. [23:51:00] It is intended to be that way but only if RCFilters is available [23:51:17] Are we going with 'on' meaning 'RC Filters is available'? [23:51:28] Or do we need YetAnotherDamnSetting™? [23:59:46] Yes, the idea is that $wgOresExtensionStatus = $wmgRCFilters ? 'on': 'beta' [23:59:50] We need unit tests to our brains [23:59:55] James Unit Tests